GitLab

Tries to reland 237638 after fixing compiler warnings from a more recent compiler used on arm.

This cl ports the nacl wrapper to the chromium build system and adds local modifications from Chromevox to liblouis. The native library and braille tables are copied to the location in the resources output directory where chromevox can pick them up.

BUG=316353

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237638

Review URL: https://codereview.chromium.org/67283007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238548 0039d316-1c4b-4281-b951-d872f2087c98

The CL was change a bit as suggested by the reviewers.

This CL now introduces a worklist model in GoogleAutoLoginHelper. Instead of firing all the refresh token events in a row, it queues up all the login requests and insert GAIA cookies one-by-one. This would let accounts to be appended instead of overwriting one another.

This also introduces GoogleAutoLoginHelperTest for some unit testing.

BUG=305249

Review URL: https://codereview.chromium.org/63253003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238547 0039d316-1c4b-4281-b951-d872f2087c98

Remove WGC3D from the map in Destroy() rather than ~WGC3DCBImpl(),
because removal from the multimap needs |host_|.
Otherwise it's possible that MaybeInitializeGL() and CreateContext()
fail and call Destroy(), which resets |host_|, and we already inserted
ourselves in the map.

BUG=325071

Review URL: https://codereview.chromium.org/102823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238546 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238545 0039d316-1c4b-4281-b951-d872f2087c98

BUG=321906

Review URL: https://codereview.chromium.org/102673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238544 0039d316-1c4b-4281-b951-d872f2087c98

This openmax_dl revision makes the FFT API the same for both ARM and X86 so that dependent code doesn't need to know. See https://webrtc-codereview.appspot.com/4749004/

BUG=
TBR=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/102473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238543 0039d316-1c4b-4281-b951-d872f2087c98

This allows extension install dialogs, and permissions upgrade prompts,
to be shown on mac without requiring a parent WebContents to attach a
sheet to. Currently, they hit NOTIMPLEMENTED().

The window is a titled NSPanel, centred on screen using [NSWindow
center]. The implementation mostly uses the existing
ExtensionInstallViewController, but puts it in a new, windowed-version
of ExtensionInstallDialogController.

Adds a test:
WindowedInstallDialogControllerBrowserTest.ShowInstallDialog that mimics
the way extension install and upgrade prompts are invoked via the app
launcher.

Screenshot at http://crbug.com/325030#c2

BUG=325030, 229094, 271809, 269151

Review URL: https://codereview.chromium.org/65043015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238542 0039d316-1c4b-4281-b951-d872f2087c98

ImportDefault, ImportBookmarksFile and ImportNothingAndShowNewTabPage tests are failing consistently on official MacOSX builder. Disabling it for now until it is fixed to keep the official bot green.

BUG=314221

Review URL: https://codereview.chromium.org/88953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238541 0039d316-1c4b-4281-b951-d872f2087c98

BUG=267667

Review URL: https://codereview.chromium.org/86123003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238540 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/85403005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238539 0039d316-1c4b-4281-b951-d872f2087c98

BUG=322710
TEST=NONE

Review URL: https://codereview.chromium.org/84063004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238538 0039d316-1c4b-4281-b951-d872f2087c98

BUG=309636

Review URL: https://codereview.chromium.org/83483004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238537 0039d316-1c4b-4281-b951-d872f2087c98

This is a follow up on a previous cl that switched Cast sender to use VideoFrame.

Review URL: https://codereview.chromium.org/82593005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238536 0039d316-1c4b-4281-b951-d872f2087c98

Makes sure that all interaction with the video decoder is done on the VIDEO_DECODER thread.
Logging which was removed here, will be added in a follow  up cl.

Review URL: https://codereview.chromium.org/80383006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238535 0039d316-1c4b-4281-b951-d872f2087c98

The extension contentSettings API (http://developer.chrome.com/extensions/contentSettings.html) was affecting the behavior of <webview> content. This CL isolates <webview> and other <*view> from this API.

BUG=320109
Test=Try an extension that uses the content settings API and verify that <webview> content is not impacted.

Review URL: https://codereview.chromium.org/78303005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238534 0039d316-1c4b-4281-b951-d872f2087c98

This cl contains the generation of the RTCP packets containing the log
messages, no code (more than this unittest) trigger the send.
Additionally the receiver is not wired up either. If a receiver receives
a log message today it would be ignored.

Review URL: https://codereview.chromium.org/74613004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238533 0039d316-1c4b-4281-b951-d872f2087c98

This change moves the update application functionality from the
ApplyUpdatesAndResolveConflictsCommand into the
SyncDirectoryUpdateHandler class.  This change will allow us to
implement update application differently for different types.

Because update application happens on the model threads, the
ApplyUpdatesAndResolveConflictsCommand had to be aware of
ModelSafeRoutingInfo, ModelSafeWorkers, and other concepts intended to
hide threading details.  The new code takes a different approach.  It
hides the threading details specific to each type inside its
SyncDirectoryUpateHandler by initializing it with a scoped_refptr to its
associated ModelSafeWorker.

The ApplyUpdatesAndResolveConflictsCommand was the last SyncerCommand.
With its removal, we can also remove the definitions of SyncerCommand,
ModelChangingSyncerCommand and SyncerCommandTest.

BUG=278484

Review URL: https://codereview.chromium.org/72403003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238532 0039d316-1c4b-4281-b951-d872f2087c98

Use the inferred MIME type of download items, rather than the server value,
when deciding if the tab strip can allow a drop. Get the MIME type
asynchronously so we don't crash (IO must be allowed in the call to
GetMimeTypeFromFile).

Also check the profile's plugins when determining whether a MIME type is
supported.

Regardless of whether a file is supported, the dragging operation should
still be allowed so that spring-loaded tabs work with file drags.

BUG=274288
R=asanka@chromium.org, sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238253

Review URL: https://codereview.chromium.org/68133020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238531 0039d316-1c4b-4281-b951-d872f2087c98

BUG=316717

Review URL: https://codereview.chromium.org/59023007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238530 0039d316-1c4b-4281-b951-d872f2087c98

reference. Note that until the whole of bug 325555 is fixed the API reference
will still look wonky, and in fact this makes it look even wonkier.

BUG=325555
R=yoz@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/103413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238529 0039d316-1c4b-4281-b951-d872f2087c98

The app launcher will be positioned on the center of the dock if the
cursor is not visible (previously would be in the lower-left corner) or
too far away from the dock (previously would be aligned with the cursor).

BUG=312851

Review URL: https://codereview.chromium.org/93863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238528 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238527 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=163088:163098&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/102383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238526 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238525 0039d316-1c4b-4281-b951-d872f2087c98

r1240: Add missing #include of eintr_wrapper.h to auto_testfile.h.
r1239: Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close.
r1238: Re-enable ios_exception_minidump_generator being built on non-ARM.
r1237: Fix BREAKPAD_OUTPUT_DUMP_FILE on iOS.
r1236: Process minidumps generated on ARM64 in iOS apps.
r1235: Generate minidumps for 64-bit ARM apps on iOS.

Review URL: https://codereview.chromium.org/102103003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238524 0039d316-1c4b-4281-b951-d872f2087c98

Just to disambiguate metadata callback for file systems vs. media files.

BUG=318450

Review URL: https://codereview.chromium.org/102723003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238523 0039d316-1c4b-4281-b951-d872f2087c98

The printf in that file is legitimate, so it shouldn't
trigger the warning.

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/103133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238522 0039d316-1c4b-4281-b951-d872f2087c98

Android is still broken:
 https://chromegw.corp.google.com/i/clank.tot/builders/clang-clankium-tot-builder/builds/23775/steps/runhooks/logs/stdio 

ERROR [0mat the command-line "--gyp_vars":1:29: Invalid token.
data_reduction_fallback_host%="http://compress.googlezip.net:80/" app_manifest_version_name="clang-clankium-tot-builder 33.0.1728.0" gcc_version="46" app_manifest_version_code="1728000" data_reduction_proxy_probe_url%="http://check.googlezip.net/connect" host_os="linux" component="shared_library" clang="1" spdy_proxy_auth_origin%="https://proxy.googlezip.net:443/" order_text_section="/b/build/slave/clang-clankium-tot-builder/build/src/orderfiles/orderfile.out" spdy_proxy_auth_value%="3c1d997267c567617ffe0e1b1ebbeed71398dd27" target_arch="arm" chrome_build_id="none" fastbuild="1" OS="android" android_app_targets="['../clank/native/framework/clank.gyp:clank', '../clank/native/framework/clank.gyp:devtools_resources', '../clank/native/framework/clank.gyp:chrome_test_apk', '../clank/java/geppetto/uiautomator.gyp:chrome_uiautomator_tests']"
[0m                            ^
[0mI have no idea what this is.
Generating gyp files from GN...
< gclient runhooks
ERROR: process exited with code 2
@@@STEP_FAILURE@@@
FATAL 2 != 88

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/99963007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238519 0039d316-1c4b-4281-b951-d872f2087c98

R=enne
BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/103163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238518 0039d316-1c4b-4281-b951-d872f2087c98

This CL restructures how sample_app integrates with the GPU command buffer.
Instead of mojo/public containing code that depends directly on
gpu/command_buffer, this CL isolates that dependency into a dynamically linked
library modelled after mojo_system.

1) mojo/public/gles2 contains a simple C API to libmojo_gles2.so.
2) mojo/gles2 contains a "thin" implementation of this API in terms of
   gpu/command_buffer.
3) Instead of subclassing GLES2ClientStub in mojo/public/bindings, we now
   subclass the stub directly in sample_app and control the GLES2 C API via
   mojo/public/gles2.

I've also added a couple of README.md files that describe the purposes of the
various directories and the reasons why the code is structured in this way.

R=darin@chromium.org

Review URL: https://codereview.chromium.org/101413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238517 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true
BUG=273986, 325479

Review URL: https://codereview.chromium.org/103153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238516 0039d316-1c4b-4281-b951-d872f2087c98

The popup collection was not handling correctly the case where it tells
the message center to mark its popups read, causing a NOTREACHED in
observer list.

BUG=324142

Review URL: https://codereview.chromium.org/99543003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238515 0039d316-1c4b-4281-b951-d872f2087c98

The previous CL landed (r238359) is missing a size check to prevent upscaling
in desktop capture. The correct logic should be to use native resolution
if both maxWidth and maxHeight are no smaller than source dimensions, and
to compute letterbox region if otherwise.

BUG=324923
TEST=trybot, Chrome OS feedback screen captures in native resolution
R=sergeyu@chromium.org
TBR=wjia@chromium.org

Review URL: https://codereview.chromium.org/103253003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238514 0039d316-1c4b-4281-b951-d872f2087c98

This is the first patch in a sequence of changes to enable Pipeline
to properly manage underflows. This change allows the VideoRendererImpl
to be prerolled in non-seek situations.

BUG=144683
TEST=VideoRendererImplTest.Rebuffer, VideoRendererImplTest.Rebuffer_AlreadyHaveEnoughFrames

Review URL: https://codereview.chromium.org/89673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238513 0039d316-1c4b-4281-b951-d872f2087c98

This catches bugs related to parameter lifetime that are not caught when
the Run() method is called directly.  See crbug.com/315624 for an
example.

BUG=chromium:316249
TEST=ran unit tests with and without fix for crbug.com/315624
R=nkostylev@chromium.org

Review URL: https://codereview.chromium.org/93383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238512 0039d316-1c4b-4281-b951-d872f2087c98

This test is super flaky since the tests were moved around, it's failing like 90% of the time.

NOTRY=true
BUG=166703

Review URL: https://codereview.chromium.org/102543005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238510 0039d316-1c4b-4281-b951-d872f2087c98

see https://codereview.chromium.org/78033003/ for the original CL...

BUG=324464
TEST=https://simpl.info/getusermedia/sources/ and manual unittests in media.

Review URL: https://codereview.chromium.org/99063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238509 0039d316-1c4b-4281-b951-d872f2087c98

RenderWidgetHostViewAndroid no longer subclasses DelegatingRendererLayerClient.
As it was the only use case for DelegatingRendererLayerClient, we can now remove
this class.

BUG=273250

Review URL: https://codereview.chromium.org/93463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238508 0039d316-1c4b-4281-b951-d872f2087c98

BUG=321704
TEST=ash_unittests --gtest_filter=*WorkspaceControllerTestDragging.DragWindowOverlapShelf*

Review URL: https://codereview.chromium.org/93103003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238507 0039d316-1c4b-4281-b951-d872f2087c98

Because we need hooks to do a bunch of things.

R=ben@chromium.org
NOTRY=True

Review URL: https://codereview.chromium.org/103123004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238506 0039d316-1c4b-4281-b951-d872f2087c98