GitLab

BUG=570113

Review URL: https://codereview.chromium.org/1552813002

Cr-Commit-Position: refs/heads/master@{#367197}

Should fix:
../../buildtools/third_party/libc++/trunk/include/map:843:5: error: static_assert failed
    "Allocator::value_type must be same type as value_type"
    static_assert((is_same<typename allocator_type::value_type, value_type>::value),
    ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../components/metrics/leak_detector/leak_analyzer.h:69:55: note: requested here
           Allocator<std::pair<ValueType, uint32_t>>> suspected_histogram_;

BUG=573250

Review URL: https://codereview.chromium.org/1557663002 .

Cr-Commit-Position: refs/heads/master@{#367196}

Picks up https://codereview.chromium.org/1557653002/

BUG=573250
TBR=thestig

Review URL: https://codereview.chromium.org/1552883002 .

Cr-Commit-Position: refs/heads/master@{#367195}

This occurred because a ChildBrokerHost noticed that its connection to the child process died and so it nulled out its channel. On POSIX, this leads to the destruction of the ChildBrokerHost immediately and so the singleton BrokerState is notified synchronously. On Windows, there's another channel for sandboxing related sync IPCs which uses IO completition ports. To ease lifetime issues because of that, the ChildBrokerHost is only deleted in response to errors from that second channel. So if the first channel dies first, it is possible that BrokerState tries to connect to a message pipe in that ChildBrokerState with a null channel.

The fix is to null check the channel and to inform the other side of the message pipe that its peer has died so that it can fire peer closed notifications.

BUG=573244

Review URL: https://codereview.chromium.org/1558643002

Cr-Commit-Position: refs/heads/master@{#367194}

(╯^□^)╯︵ ❄☃❄

BUG=557422
R=avi@chromium.org
TBR=ddorwin@chromium.org

Review URL: https://codereview.chromium.org/1551103002

Cr-Commit-Position: refs/heads/master@{#367193}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/73c62df3..3a586236

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1551123002

Cr-Commit-Position: refs/heads/master@{#367192}

FPDFAvail_IsFormAvail() must be called before the PDF form is
initialized if new data was downloaded since the document was created.

BUG=572943

Review URL: https://codereview.chromium.org/1556603002

Cr-Commit-Position: refs/heads/master@{#367191}

It's no longer used.

BUG=none
TEST=none
R=ben@chromium.org
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/1554783002

Cr-Commit-Position: refs/heads/master@{#367190}

BUG=573259,573250

Review URL: https://codereview.chromium.org/1557623002

Cr-Commit-Position: refs/heads/master@{#367189}

In a previous CL: https://codereview.chromium.org/1502283002/, this equation
was changed and now when the blur radius is 2px the blur effect completely
disappears. This CL change the equation back to the original one but add
a special case handler so that when the blur radius is 0 there is no blur
effect at all.

Also, together with this change, a bunch of layout test will need to
rebaseline.

BUG=572822

Review URL: https://codereview.chromium.org/1556523002

Cr-Commit-Position: refs/heads/master@{#367188}

BUG=570955
TBR=sullivan@chromium.org

Review URL: https://codereview.chromium.org/1556583003

Cr-Commit-Position: refs/heads/master@{#367187}

Instead of casting Numbers to Integer or Long (which doesn't work), we
use longValue() and intValue().

BUG=529962

Review URL: https://codereview.chromium.org/1556583002

Cr-Commit-Position: refs/heads/master@{#367186}

BUG=568706
R=eae@chromium.org

Review URL: https://codereview.chromium.org/1553493003

Cr-Commit-Position: refs/heads/master@{#367185}

This change adds the following metrics:
- The type of route when the user closes it.
- The type of cast source when the user picks one.
- The index of the sink that the user selected in the sink list.

BUG=547977

Review URL: https://codereview.chromium.org/1548283003

Cr-Commit-Position: refs/heads/master@{#367184}

BUG=chromium:573287

Review URL: https://codereview.chromium.org/1553753002

Cr-Commit-Position: refs/heads/master@{#367183}

Suppport to override existing locale resources in dep graph for
android_apk targets.

- Used is_locale_resource in build_config file to indicate that
  android_resources is locale_resource

- Removed all locale_resource in deps graph if
  alternative_locale_resource_dep is specified in android_apk target.

This feature was implemented in gyp.

BUG=565532

Review URL: https://codereview.chromium.org/1554533003

Cr-Commit-Position: refs/heads/master@{#367182}

Chromium does not support PDF content in <img> tags, which this test uses.
Hence we are removing the test.

TBR=chrishtr@chromium.org
BUG=365400

Review URL: https://codereview.chromium.org/1554773002

Cr-Commit-Position: refs/heads/master@{#367181}

Picks up:
gn roll https://codereview.chromium.org/1547563004/
libcxx/libcxxabi roll: https://codereview.chromium.org/1559483002/
Revert gn roll: https://codereview.chromium.org/1559513002/
Fix libcxx build: https://codereview.chromium.org/1554723003/

BUG=573250
R=thestig@chromium.org
TBR=agrieve

Review URL: https://codereview.chromium.org/1551913002 .

Cr-Commit-Position: refs/heads/master@{#367180}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/c80d154e..73c62df3

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1552843002

Cr-Commit-Position: refs/heads/master@{#367179}

This was used by the legacy chromium ARM builder and
is not longer needed (AFAICT).

Review URL: https://codereview.chromium.org/1536123003

Cr-Commit-Position: refs/heads/master@{#367178}

Pass() is a legacy of the original C++03 move emulation implementation.
New code should use std::move from <utility>. ChromeOS is exempt until the
migration there is complete.

❆(੭ु ◜◡‾)੭ु⁾☃❆

BUG=557422
R=thestig@chromium.org

Review URL: https://codereview.chromium.org/1548273002 .

Cr-Commit-Position: refs/heads/master@{#367177}

* Adds InfoBarDelegate::GetIdentifier(), which returns an
  enum identifying the InfoBar being created.  Generally,
  this is the name of the InfoBarDelegate, but in cases of
  classes using SimpleAlertInfoBarDelegates (or other wrapper
  classes), it uses the name of the class using the delegate.

* Adds a histogram that records which infobars were shown to
  the user via InfoBarContainer#AddInfoBar().

BUG=567483

Review URL: https://codereview.chromium.org/1520543004

Cr-Commit-Position: refs/heads/master@{#367176}

It looks like we may try to run these tests even if the we didn't
build them. No doubt I'm misunderstanding how the buildbots work with
mojo_apptests.py.

BUG=569367
TEST=none
TBR=msw@chromium.org
R=msw@chromium.org

Review URL: https://codereview.chromium.org/1554733002

Cr-Commit-Position: refs/heads/master@{#367175}

Remove the callback mocks and validate data for various types of
reports.

Also removes redundant code.

BUG=530843

Review URL: https://codereview.chromium.org/1521173002

Cr-Commit-Position: refs/heads/master@{#367174}

BUG=565532
TBR=yfriedman

Review URL: https://codereview.chromium.org/1553663002

Cr-Commit-Position: refs/heads/master@{#367173}

alternative_sdk_jar is used in proguard

BUG=565532

Review URL: https://codereview.chromium.org/1551863002

Cr-Commit-Position: refs/heads/master@{#367172}

Review URL: https://codereview.chromium.org/1553623002

Cr-Commit-Position: refs/heads/master@{#367171}

It doesn't incur any allocations, is simple, and handles 16-bit strings
well. Since the number of supported properties is so small, a linear search
is quite fast.

BUG=531577

Review URL: https://codereview.chromium.org/1552793002

Cr-Commit-Position: refs/heads/master@{#367170}

BUG=570703
TBR=aberent@chromium.org

Review URL: https://codereview.chromium.org/1555693002

Cr-Commit-Position: refs/heads/master@{#367169}

This was exposed by the three tests below when the new EDK was switched on for the test target. The problem is we have the following three pairs of ports:
A <> B
C <> D
E <> F

A is sent over C and then C is sent over E. C is closed immediately after it's recieved. Before this fix, A was not recieved (i.e. TransportData::DeserializeDispatchers wasn't called for it). As a result, B never received a peer closed notification so its error handler was never called.

The fix is to ensure that when a message pipe is closed it asks its peer to close instead. That way by the time the notification is received from the peer that it's been closed we can ensure that all in-flight messages are dispatched.

BUG=561803
TEST=mojo_shell_unittests --gtest_filter=AboutFetcherTest.AboutBlank:ApplicationManagerTest.TestEndApplicationClosure:AboutFetcherTest.UnrecognizedURL

Review URL: https://codereview.chromium.org/1554623005

Cr-Commit-Position: refs/heads/master@{#367168}

As the counterpart of android_sdk_jar, move webview_framework_jar
to config.gni, so it is easy to be overriden in downstream.

BUG=565532

Review URL: https://codereview.chromium.org/1554693002

Cr-Commit-Position: refs/heads/master@{#367167}

There is no need to Pass() on rvalues: in fact, it prevents the compiler
from applying optimizations like copy/move elision.

BUG=557422
TBR=rsleevi@chromium.org

Review URL: https://codereview.chromium.org/1558623002

Cr-Commit-Position: refs/heads/master@{#367166}

With current implementation for Java Bridge, there are 2 user scenarios related
to renderer freeze caused as message filter registration not working as
intended, namely:

A. On web page opened in tab Render process getting exited silently (or manually
killed from adb console) and user opt to reload on same tab so that new sandbox
renderer associates with the opened tab.

B. On web page opened in tab user opens a "chrome://" schema page and navigates
back (this triggers creation of new sandbox renderer for navigation to
"chrome://" and creation of another renderer on navigating back).

This patch addresses both these problems by overriding the RenderProcessGone()
and RenderViewHostChanged() WebContentsObserver interfaces respectively, and
initiates the re-registration and filter object creation if required.

BUG=572053

Review URL: https://codereview.chromium.org/1547043002

Cr-Commit-Position: refs/heads/master@{#367165}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/16088781..c80d154e

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1556673002

Cr-Commit-Position: refs/heads/master@{#367164}

We're currently devolving to the legacy API when painting vertical text
(due to mixed rotations required for upright vs. non-upright subruns).

This CL enhances the textblob paint path to also handle mixed/upright
subruns, unifies the glyph buffer paint methods and removes the legacy
path (Font::drawGlyphs, SkCanvas::drawPosText).

Main changes:

  * refactor the one-shot Font::buildTextBlob() as a text blob producer
  * refactor Font::drawGlypBuffer() as a text blob consumer
  * fold the drawGlyphs x-offset adjustments for vertical into the blob
    factory
  * fold the drawGlyphs CCW rotation for vertical text into
    drawGlyphBuffer

The blob factory is mostly lifted from Font::buildTextBlob(), with
additional logic to emit multiple blobs (when rotation changes) and
handle x-offset adjustments.

Note 1: this doesn't change the blob caching policy: only glyph buffers
which can be represented as a single, non-rotated blob are cached
(same as before).

Note 2: we now avoid the extra offset array stack copy in drawGlyphs by
applying the adjustment on the fly, as we copy data into the blob.

BUG=465353
R=jbroman@chromium.org,eae@chromium.org,drott@chromium.org

Review URL: https://codereview.chromium.org/1550993002

Cr-Commit-Position: refs/heads/master@{#367163}

R=aizatsky@chromium.org, inferno@chromium.org, krasin@chromium.org
TBR=krasin@chromium.org
BUG=539572

Review URL: https://codereview.chromium.org/1531743002

Cr-Commit-Position: refs/heads/master@{#367162}

The collection of retained object roots is preferably not allocated on
the Oilpan heap as that risks triggering an unnecessary GC.

R=haraken
BUG=

Review URL: https://codereview.chromium.org/1539133002

Cr-Commit-Position: refs/heads/master@{#367161}

BUG=566085

Review URL: https://codereview.chromium.org/1553433003

Cr-Commit-Position: refs/heads/master@{#367160}

[Aw]DevToolsServer is initialized in AwShellActivity, ChromeApplication,
and WebViewChromiumFactoryProvider. Make sure it is destroyed in the first
two instances. WebView lacks shutdown path, thus we can't do much there.

BUG=368171

Review URL: https://codereview.chromium.org/1559433002

Cr-Commit-Position: refs/heads/master@{#367159}

😵 There's so many different build configs...

BUG=557422
R=avi@chromium.org
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/1552763002

Cr-Commit-Position: refs/heads/master@{#367158}