GitLab

This uses the SecurityInterstitialIDNTest class to implement a test that
Safe Browsing blocking pages decode IDN correctly.

BUG=470406

Review URL: https://codereview.chromium.org/1035143002

Cr-Commit-Position: refs/heads/master@{#322682}

gfx::ElideRectangleText creates lots of RenderText object which
causes the performance regression. This CL avoids invoking the
method by moving allow_character_break property to RenderText.

BUG=470506
R=msw@chromium.org, sky@chromium.org
TEST=the new test case covers

Review URL: https://codereview.chromium.org/1015533016

Cr-Commit-Position: refs/heads/master@{#322681}

BUG=471290
R=jamiewalch@chromium.org

Review URL: https://codereview.chromium.org/1036413002

Cr-Commit-Position: refs/heads/master@{#322680}

fdatasync() should be faster than fsync().

From sqlite3.c:
/*
** We do not trust systems to provide a working fdatasync().  Some do.
** Others do no.  To be safe, we will stick with the (slightly slower)
** fsync(). If you know that your system does support fdatasync() correctly,
** then simply compile with -Dfdatasync=fdatasync
*/

BUG=469071

Review URL: https://codereview.chromium.org/1035903002

Cr-Commit-Position: refs/heads/master@{#322679}

HTTP cache clearing methods have been refactored into a
separate class: StoragePartitionBrowsingDataRemover in
http://crrev.com/1033013003/

One method was exposed in WebCacheManager so we can
clear renderer/ cache for a given render process.

<webview> already has a set of data it can clear, this
CL adds "cache" to that set, similar to chrome.browsingData
API.

BUG=406437
Test=Load a <webview> in a chrome app, e.g.
the browser sample app:
https://github.com/GoogleChrome/chrome-app-samples/tree/master/samples/webview-samples/browser

Open inspector for the webview: from chrome://inspect,
switch to Apps, and inspect the tab that says "Google"
under "Browser sample". Switch to network tab in that inspector so you can monitor http requests.

Visit some page in the <webview>, for my test case,
I visited http://www.google.ca
Now look at the network tab for image requests (cause it
should be much simpler), e.g. nav_logo_195.png
Reload the page couple of times, observer the status code
for the image request, it should say 304 OK.

Now open the app's inspector: Same as above, but inspect "Browser sample"
instead. Call <webview> clear cache api from its console:

document.querySelector('webview').clearData(
  {since: 1},
  {cache: true},
  function() { window.console.log('clear complete'); })

Expect "clear complete" message to show in app's console.
Now reload the page one more time and check the same
image's request, it should say 200 OK instead of 304.

Review URL: https://codereview.chromium.org/1021073002

Cr-Commit-Position: refs/heads/master@{#322678}

The gpu_times metric has been known to be flaky but it seems that the
flakiness only affects desktop devices. Enable it on android only.

R=nednguyen@chromium.org
BUG=455292

Review URL: https://codereview.chromium.org/1041963002

Cr-Commit-Position: refs/heads/master@{#322677}

Ever since https://codereview.chromium.org/710803002/, we haven't been
exposing a cookie jar or a clipboard to html_viewer. This looks like an
accident during refactoring.

BUG=

Review URL: https://codereview.chromium.org/1037423002

Cr-Commit-Position: refs/heads/master@{#322676}

Makes a method similar to DocumentUtilities.finishOtherTasksWithData(), but
specifically for killing tasks with the same DocumentTab ID.

BUG=445136

Review URL: https://codereview.chromium.org/1044513002

Cr-Commit-Position: refs/heads/master@{#322675}

$ git log 53ef01328..13e7c88b5 --date=short --format='%ad %ae %s' | sed 's/@chromium\.org//'
2015-03-26 maruel Add bot_delete command and add DELETE support to utils/net.
2015-03-24 maruel Print a proper error when the target directory exists.
2015-03-23 vadimsh Do not import oauth2client.crypt since it fails on bots.
2015-03-23 maruel Fix enumeration when using '&' in the url.
2015-03-23 maruel Do not print an exception if stdout is closed early.
2015-03-20 vadimsh Add support for service account.
2015-03-20 vadimsh Simplify authentication related code.
2015-03-20 maruel Do not hang if a grand children outlives the children process.

Add whitelist for pyasn1, it's BSD licensed.
Add whitelist for rsa, it's Apache v2.0 licensed.

R=vadimsh@chromium.org,phajdan.jr@chromium.org,thestig@chromium.org
BUG=471372

Review URL: https://codereview.chromium.org/1036243002

Cr-Commit-Position: refs/heads/master@{#322674}

Buffers are expected to be scheduled/released in FIFO order. When
enabling a display we want to re-use a buffer to avoid flashes. As
such we need to make sure that the buffer used for modesetting is the
last buffer queued.

BUG=chrome-os-partner:38267

Review URL: https://codereview.chromium.org/1041823002

Cr-Commit-Position: refs/heads/master@{#322673}

Automatic extern generation has gotten to the point where it yields a better
result than the somewhat hand-modified version (Yay!). Use the generated one
in the closure compiler externs.

BUG=469920

Review URL: https://codereview.chromium.org/1010083008

Cr-Commit-Position: refs/heads/master@{#322672}

Allows all packaged apps to use the chrome.mdns API, and removes whitelist that restricts the set of service type that can be discovered.

R=mkwst@chromium.org,mfoltz@chromium.org
BUG=426500

Review URL: https://codereview.chromium.org/668983003

Cr-Commit-Position: refs/heads/master@{#322671}

Review URL: https://codereview.chromium.org/1041973002

Cr-Commit-Position: refs/heads/master@{#322670}

It is not clear as to how this crash occurs. From the callstack, the crash occurs in the context of a bubble getting
created and before it is initialized. In the context of the bubble creation, DesktopNativeWidgetAura instantiates the IME
COM objects which instantiate a local COM server. This causes the main UI loop to be reentered and the bubble is resized in
this context. The WidgetObserver OnWidgetBoundsChanged method in the BubbleDelegateView gets invoked which crashes while
dereferencing the top level widget as it has not been initialized yet.

It is unclear as to how the WidgetObserver is set up here. From the code the BubbleDelegateView observer is setup after the
bubble is initialized, i.e in the BubbleDelegateView::CreateBubble function after the bubble is created.

Fix is to delay the initialization of the IME on Windows until we receive the first IME message or an input
language change notification

BUG=454375
TEST=None at the moment, as it is unclear as to how this crash can happen.

Review URL: https://codereview.chromium.org/1037103004

Cr-Commit-Position: refs/heads/master@{#322669}

Revert of Add switch (for cast_shell) to defer creation of GPU process. (patchset #8 id:140001 of https://codereview.chromium.org/1038783002/)

Reason for revert:
Breaking mac browser tests?

http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests/builds/436

BrowserGpuChannelHostFactoryTest.AlreadyEstablished (run #1):
[ RUN      ] BrowserGpuChannelHostFactoryTest.AlreadyEstablished
[35311:27139:0327/154011:20111614311426:ERROR:browser_gpu_channel_host_factory.cc(134)] Failed to launch GPU process.
[35311:27139:0327/154011:20111614504937:ERROR:browser_gpu_channel_host_factory.cc(134)] Failed to launch GPU process.
../../content/browser/gpu/gpu_ipc_browsertests.cc:179: Failure
Value of: event
  Actual: false
Expected: true
[  FAILED  ] BrowserGpuChannelHostFactoryTest.AlreadyEstablished, where TypeParam =  and GetParam() =  (215 ms)

Original issue's description:
> Add switch (for cast_shell) to defer creation of GPU process.
>
> For context - on Chromecast, we have the following scenario:
> * We support running in the background (i.e. not rendering anything)
>   with our service running in the browser process to listen for incoming
>   cast connections.
> * We cannot acquire any GPU resources (e.g. a GL context or surface)
>   during this time as another external application needs it, and it's a
>   global resource.
>
> We have supported starting up in the foreground and switching to this
> mode for a long time.
>
> But now, we need to support starting up in this mode.  In other words,
> we need to bring up the browser process and run our cast receiver
> service, but we cannot run any of the GPU process's initialisation
> code until an incoming cast arrives.
>
> BUG=internal b/19898960
>
> Committed: https://crrev.com/db7efe6dfbda08faa1e55cda4441b43dac005733
> Cr-Commit-Position: refs/heads/master@{#322655}

TBR=enne@chromium.org,nasko@chromium.org,piman@chromium.org,sievers@chromium.org,halliwell@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=internal b/19898960

Review URL: https://codereview.chromium.org/1043603002

Cr-Commit-Position: refs/heads/master@{#322668}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/5cffba8..d8b34c2

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=hcm@google.com

Review URL: https://codereview.chromium.org/1037293003

Cr-Commit-Position: refs/heads/master@{#322667}

- on Chrome OS, continue to enumerate all Aura windows when building the desktop tree via the Ash shell.
- on all other Aura platforms, lazily hook up top level windows that have been created in our object cache. This works by only presenting cached windows as children of the desktop node. Since serialization walks up the tree, we are guaranteed windows in the cache whenever a descendant view has an event fired upon it.

- allow ChromeVox to traverse the desktop automation tree on all platforms.

TEST=build ChromeVox webstore extension. Run it on linux chromium. Verify views-based UI reads.

Review URL: https://codereview.chromium.org/1003283002

Cr-Commit-Position: refs/heads/master@{#322666}

Instead of avoiding to send IPC from ChildDiscardableSharedMemoryManager
dtor, make sure ThreadSafeSender instance is still valid at the
time dtor is called.

BUG=471246

Review URL: https://codereview.chromium.org/1035313002

Cr-Commit-Position: refs/heads/master@{#322665}

The Chrome sync code is implemented both in C++ and Java, and spread over the
//sync top level folder and through //chrome/browser/sync. In addition, there's
another part that lives in the Java-part of the directory tree:
//chrome/android/java/src/org/chromium/chrome/browser/sync

This CL adds a set of natural owners for that folder to help with the review
process.

BUG=None

Review URL: https://codereview.chromium.org/1039583002

Cr-Commit-Position: refs/heads/master@{#322664}

Currently this class recurses to browser_view_->frame()->GetFrameView()
in OnPaintBackground. Instead, do this recursion in PaintChildren
so that it has access to the the recursion data to be passed through
PaintChildren.

R=sky
BUG=466426

Review URL: https://codereview.chromium.org/1036403002

Cr-Commit-Position: refs/heads/master@{#322663}

This was found by looking at the output of gyp_flag_compare step in
http://build.chromium.org/p/chromium.linux/builders/Linux%20GN/builds/25653/steps/gyp_flag_compare/logs/stdio

BUG=None
TEST=gn gen out-gn
R=brettw@chromium.org
TBR=zea@chromium.org

Review URL: https://codereview.chromium.org/1038913004

Cr-Commit-Position: refs/heads/master@{#322662}

This method is never used. It was introduced as a way to conveniently share pages among page sets. The implementation
is not correct as archive_data_file is defined in page_set.

In the future, sharing pages among pageset should be simple
when we can remove the page's dependence on pageset (https://code.google.com/p/chromium/issues/detail?id=466836)

Review URL: https://codereview.chromium.org/1033493003

Cr-Commit-Position: refs/heads/master@{#322661}

BUG=460972

Review URL: https://codereview.chromium.org/868233011

Cr-Commit-Position: refs/heads/master@{#322660}

A URL constant pointing to https://support.google.com/chrome/answer/1382847
existed in both handler_options_handler.cc and url_constants.cc.  This
removes the definition in handler_options_handler.cc.

BUG=471318

Review URL: https://codereview.chromium.org/1044493002

Cr-Commit-Position: refs/heads/master@{#322659}

BUG=470704

Review URL: https://codereview.chromium.org/1002283005

Cr-Commit-Position: refs/heads/master@{#322658}

Review URL: https://codereview.chromium.org/1036303003

Cr-Commit-Position: refs/heads/master@{#322657}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/53944e9..7a91f7f

TBR=pkasting@chromium.org,yutak@chromium.org

Review URL: https://codereview.chromium.org/1042453004

Cr-Commit-Position: refs/heads/master@{#322656}

For context - on Chromecast, we have the following scenario:
* We support running in the background (i.e. not rendering anything)
  with our service running in the browser process to listen for incoming
  cast connections.
* We cannot acquire any GPU resources (e.g. a GL context or surface)
  during this time as another external application needs it, and it's a
  global resource.

We have supported starting up in the foreground and switching to this
mode for a long time.

But now, we need to support starting up in this mode.  In other words,
we need to bring up the browser process and run our cast receiver
service, but we cannot run any of the GPU process's initialisation
code until an incoming cast arrives.

BUG=internal b/19898960

Review URL: https://codereview.chromium.org/1038783002

Cr-Commit-Position: refs/heads/master@{#322655}

This updates the gn_all and gyp_remaining targets to reflect the current
status.

R=tfarina@chromium.org, brettw@chromium.org
BUG=461019
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg

Review URL: https://codereview.chromium.org/1040543002

Cr-Commit-Position: refs/heads/master@{#322654}

- FallbackIconServiceFactory now get sFallbackIconService singleton from
  BrowserContext.
- FallbackIconClient & ChromeFallbackIconClient: wrap external code so the Favicon
  component won't have to include them. Specifically:
  - Choosing fonts: also removed duplicate code.
  - Extracting letter from URL to render Fallback.

BUG=455063

Review URL: https://codereview.chromium.org/996253002

Cr-Commit-Position: refs/heads/master@{#322653}

The task queue in guest_view.js waits until the previous operation has called its callback before proceeding to the subsequent operation. If BrowserPlugin is torn down while guest_view.js is waiting for an operation to complete, it will fail to make progress.

This CL addresses this issue by calling the appropriate callbacks on tear down of ExtensionsGuestViewContainer.

This CL also makes sure that the destruction callback is registered in guest_view.js as soon as attach(..) is called rather than after we hear the callback. This ensures that guest_view.js sets its state correctly in the event of a tear down of BrowserPlugin between the call to attach and hearing the callback.

BUG=470456

Review URL: https://codereview.chromium.org/1039643003

Cr-Commit-Position: refs/heads/master@{#322652}

BUG=466520

Review URL: https://codereview.chromium.org/1030323003

Cr-Commit-Position: refs/heads/master@{#322651}

This is a drop down that shows cast modes. It is styled after the current cast extension's cast mode picker. Some styling (e.g. positioning) will be updated when the rest of the WebUI has landed.

The default selectedCastMode is denoted with a -1. This refers to the default cast mode for the current tab. The possible cast mode values are defined elsewhere (to be landed later).

BUG=464222

Review URL: https://codereview.chromium.org/1026083003

Cr-Commit-Position: refs/heads/master@{#322650}

Modify unit test to regress crashing bug and verify the fix.

BUG=469935

Review URL: https://codereview.chromium.org/1036593003

Cr-Commit-Position: refs/heads/master@{#322649}

Revert of Enable BeginFrame scheduling on aura (patchset #12 id:210001 of https://codereview.chromium.org/1016033006/)

Reason for revert:
Bots are failing:
AutofillInteractiveTest.AutofillFormWithNonAutofillableField
WebViewTest.InterstitialTeardown
TouchExplorationTest.RewritesEventsWhenOn

Not sure if it's this CL but reverting to see.

Original issue's description:
> Enable BeginFrame scheduling on aura
>
> This cl is last partial cl from https://codereview.chromium.org/775143003/
> for easy review.
> Until now, BeginFrame is initiated by each renderer process.
> With this cl, BeginFrame is scheduled from parent(browser) cc scheduler
> to child(renderer) cc scheduler.
> For more detailed information, please see this (http://goo.gl/D1Qxrr)
>
> Also, --enable-begin-frame-scheduling is no longer needed because all platform except Mac
> uses it as a default.
>
> R=brianderson@chromium.org, danakj@chromium.org, mithro@mithis.com
> BUG=372086
>
> Committed: https://crrev.com/17dd2f109f3155ebf183627b63df25f97f34b67f
> Cr-Commit-Position: refs/heads/master@{#322622}

TBR=brianderson@chromium.org,mithro@mithis.com,sievers@chromium.org,oshima@chromium.org,boliu@chromium.org,simonhong@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=372086

Review URL: https://codereview.chromium.org/1040813002

Cr-Commit-Position: refs/heads/master@{#322648}

R=peter@chromium.org

Review URL: https://codereview.chromium.org/1043523002

Cr-Commit-Position: refs/heads/master@{#322647}

This just copies the content/ implementation.

BUG=none

Review URL: https://codereview.chromium.org/1040723003

Cr-Commit-Position: refs/heads/master@{#322646}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/135b7ec..5cffba8

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=hcm@google.com

Review URL: https://codereview.chromium.org/1039153003

Cr-Commit-Position: refs/heads/master@{#322645}

BUG=393441
TEST=See bug comment 23 for repro steps

Review URL: https://codereview.chromium.org/1011943003

Cr-Commit-Position: refs/heads/master@{#322644}

Screen rotation animations were slow and janky on low end hardware. This was due to animations being incorrectly initiated on the window bounds changed events.

TEST=Compared animation behavior pre-change and post-change for maximizable & non-maximizable windows when entering and exiting Touchview.  Tested after opening windows when Touchview was active and when it was not.

BUG=471341

Review URL: https://codereview.chromium.org/1043543002

Cr-Commit-Position: refs/heads/master@{#322643}