- 22 Mar, 2018 40 commits
-
-
Ian Vollick authored
Updating the strings to match spec. Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I3c283baf9224bf9167ed5165d1f4771abac7a500 Reviewed-on: https://chromium-review.googlesource.com/975481Reviewed-by:
Amirhossein Simjour <asimjour@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#545068}
-
Randy Rossi authored
Moving automation manifest handler into //extensions. Other automation bits & pieces to follow in subsequent CLs. Bug: 822747, b/74537394 Test: Tested install of ChromeVox on ChromiumOs and Google branded Chrome build Change-Id: I18d828f76c17cb120e7cc9ed8022f107f3f3a2ea Reviewed-on: https://chromium-review.googlesource.com/964732 Commit-Queue: Randy Rossi <rmrossi@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#545067}
-
Amirhossein Simjour authored
Make sure that AnchoredPopupWindow inside of DropdownPopupWindow is always focusable, so the items in the list can be selected. Bug: 820898 Change-Id: I8ede526787cad6bb585013d2c4280d502eff7652 Reviewed-on: https://chromium-review.googlesource.com/974172Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#545066}
-
Dianna Hu authored
This CL lands server change 188737435 by clshepherd. BUG=488484 Change-Id: Iaea875815b0de8713b72b1e7b9773a5bfff029f7 Reviewed-on: https://chromium-review.googlesource.com/974133 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#545065}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b8eac287..2d4815d9 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I1878ae3fc3f0a771f9efe801685e8ed82bf13e3a Reviewed-on: https://chromium-review.googlesource.com/975342Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#545064}
-
Mihai Sardarescu authored
The views implementation of the profile_chooser_view has been launched in M64. This CL removes the cocoa implementation of the profile_choose_view. Change-Id: If349ced487e4c6f2b37b0d52bd215a67f7be8f22 Reviewed-on: https://chromium-review.googlesource.com/968262 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#545063}
-
Peter Wen authored
Android Studio has split into channels, stable (3.0), beta (3.1) and canary (3.2) with corresponding packages. We should support all three. Bug: 620034 Change-Id: If8ebc37c137d53c5811aa8ce9258ac0dcef3d470 Reviewed-on: https://chromium-review.googlesource.com/974101Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#545062}
-
Mark Pilgrim authored
Explicitly mark GuestCallback as a RepeatingCallback and use BindRepeating on all callers BUG=714018 TBR=sky@chromium.org Change-Id: I5e1d7283b421872291fad9131fb6977d1ba8b3c0 Reviewed-on: https://chromium-review.googlesource.com/970904 Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#545061}
-
Jochen Eisinger authored
We shouldn't blanket allow including WebKit or content/public files. BUG=none R=dsinclair@chromium.org Change-Id: I3592f604b33c03984255b1af321db076ebaa17ca Reviewed-on: https://chromium-review.googlesource.com/974962Reviewed-by:
dsinclair <dsinclair@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#545060}
-
https://webrtc.googlesource.com/src.git/+log/3dc0125cf7e8..b3179c75ed40 $ git log 3dc0125cf..b3179c75e --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:None,chromium:None,chromium:824111,chromium:824679,chromium:none,chromium:None,chromium:None,chromium:None,chromium:824111,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Icaa35e74c476b297d3c935b54e86d9b172d7703e Reviewed-on: https://chromium-review.googlesource.com/975348Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#545059}
-
edchin authored
Previously, the new tab button would not change until after the page scroll completed the animation. In that case, the user is able to tap on the button during the animation, which potentially resulted in the wrong type of tab being created. This CL ensures that the new tab button, as well as all other visual appearances dependent on the current page gets updated during the scroll, so it is accurate as possible. Bug: 823842, 804580 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I541a2811929b4e0835649c64e76260f4e11962da Reviewed-on: https://chromium-review.googlesource.com/972435 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#545058}
-
David Roger authored
Bug: 822728 Change-Id: Iaf1de0917be3533d03da0e2aac3b9d33fb03d477 Reviewed-on: https://chromium-review.googlesource.com/966068 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#545057}
-
Yang Guo authored
The debug() function is going to be extended by a condition string argument. R=machenbach@chromium.org Bug: v8:178 Change-Id: I7d9a15bc3f17e9c23e4011d7f4ee55671519df3c Reviewed-on: https://chromium-review.googlesource.com/975402Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#545056}
-
Mark Cogan authored
This CL refactors the tab grid transition animation by separating the transition animator-specific logic (including getting state information vie the transition state provider) from the animation itself. The new GridTransitionAnimator object is a UIView sublcass that hosts the proxy cell views used for the animation. It isn't dependent on the specific view setup or timing of a transition animator, and so could be used anywhere. The transition animator still handles fading out the tab view (the BVC). A future CL may move this logic into the BVC's -viewWillDisappear:. This is a preparatory step to making the animator such that the reverse animation can use it as well. Bug: 804539 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I69382950f1fcc7b62f0afe365b1f1d85293d8f25 Reviewed-on: https://chromium-review.googlesource.com/973612 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
-
Peter Beverloo authored
The NotificationJobService needs to copy the data stored in a notification's PendingIntent to one that is safe to be used for starting a background job. It did so for most data members, but not for the scope. Bug: 824729 Change-Id: Ifbb7d8b22e15074545fd756a012f84f6a17b68e1 Reviewed-on: https://chromium-review.googlesource.com/975128 Commit-Queue: Peter Beverloo <peter@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#545054}
-
Jérôme Lebel authored
This patch is to fix crrev.com/c/973303. The new method for GetAccessToken (without the secret client) needs to be the main method. And the old method needs to have a the fallback to the new one if it is still called. Related to crrev.com/i/480972 and crrev.com/c/973229. Bug: 516021 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5086c2e26f8456a8a741072be2f46e0f90f8f91b Reviewed-on: https://chromium-review.googlesource.com/975127Reviewed-by:
-
Robert Liao authored
These textfields often return nothing. BUG=823532 Change-Id: I3e55d7c26ad46f065101ab8b5cf0fc3f085ae8f3 Reviewed-on: https://chromium-review.googlesource.com/974644 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#545052}
-
Robert Liao authored
This test contains an illegal thread join that likely impacts other platforms. Windows doesn't hit it because Windows does not yet DCHECK on thread joins on the UI thread. BUG=824570 Change-Id: If8e8f4b0620f6184986478c20eeef21fa68f749a Reviewed-on: https://chromium-review.googlesource.com/974569 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Robert Liao authored
BUG=824418 Change-Id: Iab8ded70524c59d50f8c10646df2a3dd3ee71dfe Reviewed-on: https://chromium-review.googlesource.com/974072 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Robert Liao authored
There are unexpectedly multiple focus managers in this test. BUG=824551 Change-Id: Id1d79745de9fb7ed1dd96c4224d9e57fb21ef8cd Reviewed-on: https://chromium-review.googlesource.com/974521 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Robert Liao authored
Disable Test on MacViews - BrowserCommandControllerInteractiveTest.KeyEventsShouldBeConsumedByWebPageInJsFullscreenExceptForF11 BUG=823478 Change-Id: I926882274251a6ba554594f993f82cec9bd26cbe Reviewed-on: https://chromium-review.googlesource.com/974452 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Fady Samuel authored
This reverts commit 075859bd. Reason for revert: The offending patch has been reverted. I'm re-enabling this. Original change's description: > Disable MediaRouterIntegrationBrowserTest.Dialog_Basic on MacOS > > It was detected to be flaky > > TBR=mfoltz@chromium.org > > Bug: 824610 > Change-Id: I958b7ecf83d01eb396638461271262599286fb7a > Reviewed-on: https://chromium-review.googlesource.com/975304 > Reviewed-by: Christos Froussios <cfroussios@chromium.org> > Commit-Queue: Christos Froussios <cfroussios@chromium.org> > Cr-Commit-Position: refs/heads/master@{#545046} TBR=cfroussios@chromium.org Change-Id: Ic791f98fcb60d7ed03636e3c45bcddb816f6b0bc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 824610 Reviewed-on: https://chromium-review.googlesource.com/975441Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#545047}
-
Christos Froussios authored
It was detected to be flaky TBR=mfoltz@chromium.org Bug: 824610 Change-Id: I958b7ecf83d01eb396638461271262599286fb7a Reviewed-on: https://chromium-review.googlesource.com/975304Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#545046}
-
Adam Rice authored
It's necessary to have a ScriptState::Scope active in order to call CreateTypeError(). https://chromium-review.googlesource.com/c/chromium/src/+/954765 removed this from BarrierCallbackForPut::OnError, causing crashes. Fix by inlining BarrierCallbackForPut::RejectWithState so that the TypeError is once against created within the ScriptState::Scope. BUG=824621 Change-Id: I7683ac83fd23e4ed9b1b4e2063481d54c37ee3d0 Reviewed-on: https://chromium-review.googlesource.com/975202Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#545045}
-
about://signin-internalsDavid Roger authored
The crash was caused by SigninErrorController being called before the AccountStatus was added to the map. Then when the about-internals page tried to handle the error, it would try to get the account, but it would crash because it was not completely added in the AccountStatusMap. This CL also converts link_ptr to unique_ptr as a cleanup. Bug: 823707 Change-Id: I0019da48de6e281d812538633a90f519f6b24d3a Reviewed-on: https://chromium-review.googlesource.com/973370Reviewed-by:
-
Christos Froussios authored
This reverts commit 20d09354. Reason for revert: Suspected of breaking * external/wpt/bluetooth/server/getPrimaryServices/blocklisted-services.https.html * external/wpt/bluetooth/service/getCharacteristic/gen-blocklisted-characteristic.https.html * external/wpt/bluetooth/service/getCharacteristics/blocklisted-characteristics.https.html * external/wpt/bluetooth/service/getCharacteristics/gen-blocklisted-characteristic-with-uuid.https.html Original change's description: > bluetooth: Use DeviceUUID in FakePeripheral > > This change refactors FakePeripheral to use the built-in DeviceUUIDs > helper class in BluetoothDevice to handle the UUIDs for a device. > > BUG=719826 > > Change-Id: I9c60f00912aca706f16f402031483711f6f3ae89 > Reviewed-on: https://chromium-review.googlesource.com/958337 > Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Reviewed-by: Conley Owens <cco3@chromium.org> > Cr-Commit-Position: refs/heads/master@{#544235} TBR=cco3@chromium.org,ortuno@chromium.org,odejesush@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 719826, 824704 Change-Id: I4543474f7412f954fe062c06d05a458cdf6d6447 Reviewed-on: https://chromium-review.googlesource.com/975123Reviewed-by:
-
Justin Cohen authored
|locationBarCoordinator| needs to disconnect itself from webStateList. Without this, closing the last incognito tab will DCHECK. Also adds stop/disconnect/nil to adaptive toolbar coordinator. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia631150a73cdb2975fc0592ec5840692bf906d02 Reviewed-on: https://chromium-review.googlesource.com/973686 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#545042}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a1ec7e112c5e..051b1952ca4b $ git log a1ec7e112..051b1952c --date=short --no-merges --format='%ad %ae %s' 2018-02-21 smbarber chromeos_config: promote tatl from experimental 2018-03-21 dgarrett chromeos_config: Mark master-release as important. Created with: roll-dep src/third_party/chromite BUG=chromium:814445,chromium:824582 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I7e9f8ce027937ff3b065c25f4c97e1ef77169f07 Reviewed-on: https://chromium-review.googlesource.com/974905Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#545041}
-
Adam Rice authored
git cl lint found a stray semicolon in Cache.cpp. Remove it. Change-Id: Ifb6535cf163b6febac0ee9da66bb671d7c827a0c Reviewed-on: https://chromium-review.googlesource.com/975085Reviewed-by:
-
stkhapugin@chromium.org authored
Adds new feature flag, kRefreshPopupPresentation, for UI refresh omnibox popup presentation. Bug: 821817 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib4ed4f181e49849d5c5858b2457e14553f8d60af Reviewed-on: https://chromium-review.googlesource.com/973308 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
-
Adam Rice authored
Update TransformStream to match the standard version https://github.com/whatwg/streams/commit/7b8dffe8ec270bb918340e011349e2c1b5521a15. Significant changes: Method lookups are now cached at construction time. Changing underlyingSink.write after construction will no longer do anything. This is https://github.com/whatwg/streams/pull/860. When the readable side is cancelled, the stored error on the writable side will be set to the |reason| that was passed to cancel(), rather than a TypeError. This is https://github.com/whatwg/streams/pull/903. Bug: 780689, 820387 Change-Id: I33c59541eea1bfc5f96722bce750ba4fa7ff96ee Reviewed-on: https://chromium-review.googlesource.com/964112Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#545038}
-
Koji Ishii authored
This patch skips importing tests that do not have active plans. We can re-start importing them when we start implementing them. Bug: 492664 Change-Id: I6d4e265c443af8619094202c791153d8a7271ec1 Reviewed-on: https://chromium-review.googlesource.com/974990Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#545037}
-
François Beaufort authored
Encoding API was mistakenly promoted stable earlier. This CL fixes this and introduces a new MediaCapabilitiesEncodingInfo runtime enabled feature marked as experimental. Bug: 824708 Change-Id: I8f06982471ee544919fe427f782b8d8ccf21f7b5 Reviewed-on: https://chromium-review.googlesource.com/970463 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#545036}
-
Hans Wennborg authored
TBR=brianderson Bug: none Change-Id: I3951025d11cf4d0be8308fcacfabcf73866c9291 Reviewed-on: https://chromium-review.googlesource.com/975121Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#545035}
-
Fredrik Söderquist authored
Like the equivalent helper on LayoutSVGModelObject, this provides a more specific type of Node (an SVGElement), since is guaranteed for subclasses of LayoutSVGBlock. Also update the documentation in LayoutSVGModelObject to reflect the current name. Bug: 769774 Change-Id: I720af53e5a24e960773059f7d2a113e74bd5bdc5 Reviewed-on: https://chromium-review.googlesource.com/973378 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#545034}
-
Bernhard Bauer authored
Bug: 810854 Change-Id: I90e5eb0c82e4d5495e760b631bb61e69eb6aaa43 Reviewed-on: https://chromium-review.googlesource.com/973521Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#545033}
-
Kent Tamura authored
clang produces errors for conditional mutex locking in HashTableStats::recordCollisionAtCount() and HashTableStats::DumpStats(). > .../wtf/HashTable.cpp:56:7: error: mutex 'hashTableStatsMutex()' is not held on every path through here [-Werror,-Wthread-safety-analysis] > if (count > maxCollisions) > ^ Avoid such errors by moving lock() and unlock() into a single block. This CL has no behavior changes. Change-Id: If64ca5700bda0d881fd96ee84b8115b419a8aa63 Reviewed-on: https://chromium-review.googlesource.com/974667Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#545032}
-
Yoshifumi Inoue authored
This patch changes |HonorEditingBoundaryAtOrAfter()| to handle nested editable. Before this patch, |HonorEditingBoundaryAtOrAfter()| returns null position for editable position anchored by non-editable position. After this patch, |HonorEditingBoundaryAtOrAfter()| returns the last position in the highest non-editable ancestor of |anchor| Note: This patch is a preparation of the patch[1] which changes finding word boundary in the block instead of inside editing boundary. Example: In below HTML, current code finds word boundary in "ABC", but the patch[1] finds from "abcABCdef". <div contenteditable>abc<span contenteditable=false>A^BC</span>def</div> where "^" is starting position to find word boundary. [1] http://crrev.com/c/737981 Simplify word granularity handling Change-Id: I1fa702cba0bd48e8eec642c008ddda8fd063a6b8 Reviewed-on: https://chromium-review.googlesource.com/970130 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#545031}
-
Yoshifumi Inoue authored
This patch introduces |FindWordBackward()| and |FindWordForward()| for a preparation of the patch[1]. [1] http://crrev.com/c/737981 Simplify word granularity handling Bug: 778507 Change-Id: I405683cd07a0dc3a5f8cc26c307e1d980dcb2961 Reviewed-on: https://chromium-review.googlesource.com/970191 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#545030}
-
Joel Hockey authored
Change to use test.html rather than test/main.html. Having the file in the regular dir makes it much better for many files that load other resources assuming that relative paths of 'foreground/foo/bar' will be valid. This has simplified the create_test_main.py script. Bug: 813477 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I388b3a914fde3cc99b76503251cbf6ffdd659e81 Reviewed-on: https://chromium-review.googlesource.com/972222Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#545029}
-
