- 19 May, 2020 40 commits
-
-
Ramin Halavati authored
Profile API is being updated (issue 1033903) and the usage of GetOffTheRecordProfile and HasOffTheRecordProfile without argument is getting deprecated. Use cases of this call that ONLY refer to incognito or guest mode can use [Get/Has]PrimaryOTRProfile() instead. Incognito test in durable_storage_permission_context_unittest.cc is updated to use the new API, and a new test is added for non-primary OTR profiles. Bug: 1060940 Change-Id: Iaa55ded4a36f993bca833ea0f68afcc9908cf693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2195961 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#770031}
-
Darwin Huang authored
Consistently nest more specific conditional statements under less specific conditional statements. This was previously inconsistent and sometimes confusing, since it wasn't always easy to quickly find which platforms included which files. Refactoring change. No functional changes. Change-Id: Ie746f4a28ad4d3cdfdca43938bbb41761a933604 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205007 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/416580cd..d0f8881c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie29365f444cf93e4331ca4b8a4ce67ec122cc468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208631Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770029}
-
Dmitriy Khodyrev authored
Test sync_performance_tests uses the following resource files: - $root_out_dir/chrome_100_percent.pak - $root_out_dir/chrome_200_percent.pak - $root_out_dir/locales/en-US.pak - $root_out_dir/resources.pak But there were no any dependency in build.gn between tests and the resources. The resources were not regenerated during sync_performance_tests build. The change contains the fix of the resources generation used by sync_performance_tests. Change-Id: Id311bc25189ef5ec08fd4ea733a39c30b490bce4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207215Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#770028}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I0e798c56a4356a4d8a0cb3b9f7354bdff58d21f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208700Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770027}
-
Matthias Körber authored
Besides formatting, this is a one line change. By adding word boundaries to "land" the reported unintended mismatching with "landgrid" should be solved. Bug: 1083446 Change-Id: I9ee538118699a9fc03ee64c593a3561d9676e4fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206834 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Auto-Submit: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#770026}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9d8c46579122..3d9f3b12043b git log 9d8c46579122..3d9f3b12043b --date=short --first-parent --format='%ad %ae %s' 2020-05-19 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@3d9f3b12043b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9d8182b3427b9198a8bdbb58bab4c9eb5b274334 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208696Reviewed-by:
-
Mario Sanchez Prada authored
This CL replaces usage of the routing ID to identify a frame's contents when saving a page with using the frame token instead. This will be useful in the short term to help with the conversion of FrameMsg_GetSerializedHtmlWithLocalLinks to mojo, where we'd like to avoid having to pass routing IDs so that we can eventually have the browser process communicating directly with Blink (i.e. Onion Soup). Bug: 1044088 Change-Id: Ifc6d25b76800c96c29f8a7f03637c01dd512244b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167763Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#770024}
-
Leo Zhang authored
Previously when the IME service is launched in the ime sandbox, it will try to load a the final DSO as its main entry. Now we create a fake impl for testings only. This CL also renames the ime flag with a clearer name and add some straightforward desc. BUG=b:156897880, chromium:837156 TEST='Locally run browser_tests NativeInputMethodEngineTest.*' Change-Id: I26e8007950731f490d812fd1e3c3379f899154c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206855 Commit-Queue: Leo Zhang <googleo@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#770023}
-
Tsuyoshi Horo authored
Bug: 1084048 Change-Id: I9c4ca0ce38812f1d51f4bcf349c47925489b46cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206936Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#770022}
-
Alex Rudenko authored
Sets the color space for DevToolsEyeDropper's bitmap Bug: 884170, 1066415 Change-Id: I2436c326f06dd7d68671cac9ae041fa63c93a60d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207370Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#770021}
-
Leo Zhang authored
Bug: 837156,937152 Change-Id: I1b7a61f929e40ae20d32295505e00b19c04b067b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208519 Commit-Queue: Leo Zhang <googleo@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes "block-with-positioned-lastchild.html" to utilize |selection_test()| for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: Ibf7e74bae974f3e0ed77ae7905e19b0510d77e18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208317 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#770019}
-
David Munro authored
In some cases the user could end up with a disk larger than we allow them to have. When that happens they can still go up to their current size instead of us erroring out. Bug: chromium:1083847 Test: Unit Change-Id: If55591bfbf8d7c81c1aea27db9dc06a54ea0988f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208157 Auto-Submit: David Munro <davidmunro@google.com> Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#770018}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/41d405e9fe05..f3dc33457905 git log 41d405e9fe05..f3dc33457905 --date=short --first-parent --format='%ad %ae %s' 2020-05-19 dberris@chromium.org auto-triage: File issues on specific projects Created with: gclient setdep -r src/third_party/catapult@f3dc33457905 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1082032 Tbr: oysteine@google.com Change-Id: I82d6e22538cc69c730f442735d749dfee1da39a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208694Reviewed-by:
-
Piotr Tworek authored
The class declared in this header uses both std::unique_ptr and std::vector. Unfortunately it fails to include header files declaring both types. This leads to build failures on Linux systems using libstdc++ instead of bundled libcxx. Change-Id: I60eeb8a0f06ea82c3e484eff37329e1fb263a696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206638Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Piotr Tworek <ptworek@vewd.com> Cr-Commit-Position: refs/heads/master@{#770016}
-
Piotr Tworek authored
The code in this file uses memset function, but does not include the header file declaring this type. This leads to build failure on Linux systems using recent glibc versions. Bug: 1074286 Change-Id: I6bb0b1ed1cd70ef872a9809a6fff1d78eeb8de3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206637Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Piotr Tworek <ptworek@vewd.com> Cr-Commit-Position: refs/heads/master@{#770015}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/763905cc6884..9b28b9695df9 git log 763905cc6884..9b28b9695df9 --date=short --first-parent --format='%ad %ae %s' 2020-05-19 jophba@chromium.org Fix code coverage bot--blocking checkin Created with: gclient setdep -r src/third_party/openscreen/src@9b28b9695df9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I67beadac68a5ae681a34e4e210dd9f2936691d00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208692Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7a960b632510..fabf74bda604 git log 7a960b632510..fabf74bda604 --date=short --first-parent --format='%ad %ae %s' 2020-05-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 08a05bc2b9d1..0ab78114a9e1 (5 commits) 2020-05-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader c9625f1660da..b6e8c3f0f483 (7 commits) Created with: gclient setdep -r src/third_party/angle@fabf74bda604 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: I4b39408a2673779106dc202c91918f64d7d15016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208461Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/de89a4a8e174..d077e6a3d013 git log de89a4a8e174..d077e6a3d013 --date=short --first-parent --format='%ad %ae %s' 2020-05-19 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-05-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/dawn 275a95c1dc64..949f1e45f1dc (4 commits) 2020-05-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 32d57fc3..2d0aebd8 (378 commits) Created with: gclient setdep -r src/third_party/skia@d077e6a3d013 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I64b005da77b9b1d198fd002f6641c10bd2a22a2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208691Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 41a8003c. With Chromium commits locally applied on WPT: f6984fd9 "De-flaky pointerlock/pointerevent_pointermove_in_pointerlock.html" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I3d79a865007ca08e16caea527e313b408e93d46f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208630Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770011}
-
Alex Rudenko authored
Repaints the overlay once in 250ms to reduce CPU usage for highly dynamic pages when the inspected node is the same. Reduces the cpu usage by 30% for my tests. The drawback is that you will see the updates after 250ms for frequently updated elements. Bug: chromium:1066415, chromium:1062574 Change-Id: I3e4b5ae2d187ec729cad04111a70971532f1cdda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202858 Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#770010}
-
Dominick Ng authored
When web apps are uninstalled and the clear site data option is selected, the |web_app| object was being accessed after uninstallation was completed, causing a DCHECK failure. This CL rearranges the call to clear site data so that its origin is computed before uninstallation. BUG=1084394 Change-Id: Iab3705096f5658cc30e2aa08c43d56247281cf5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208156Reviewed-by:
-
Christopher Lam authored
This CL adds easy file path override points for changes that need to be made to bring the Style Variable Generator into google3. Bug: 1018654 Change-Id: I4b8fd9de2baeaf7972c9319a05551df32c26b50f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198702Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#770008}
-
Roman Sorokin authored
The feature was never fully implemented Fixed: 899812 Change-Id: I6e813038fc20c1aab4ef785b7099d0a601b46b2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198985Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#770007}
-
Yuki Shiino authored
Prints a warning message to the inspector's console when an invalid enum value is set to an IDL attribute. Bug: 839389 Change-Id: I27f12b5af8b510ea748ef2b3238af4d40e7e485a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202831 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#770006}
-
Yuki Shiino authored
In case of IDL primitive types, applies strict typing to bindings::V8SetReturnValue. Bug: 839389 Change-Id: Ia059a21ed120b6e31e35c8431a7357e07ae6e2ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202830Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1c8cab8f9441..7fd030c0d06f Created with: gclient setdep -r src-internal@7fd030c0d06f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC shend@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: shend@google.com Change-Id: I9455b7e97d76922c29d1a3d3bc766280d9f6e671 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208457Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770004}
-
Yuki Yamada authored
Removes a WeakPtrFactory for WorkerAnimationFrameProvider which is a BlinkGC class. Change-Id: I18d0af057804cef01abefe3229627d706d6cf90d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208153Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Yuki Yamada <yukiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#770003}
-
Ankit Kumar authored
This CL adds a browser test for TouchSelectionMenu in PDF. There is no utility class which could help in determining when touch selection menu is opened. This CL adds TouchSelectionMenuWaiter() to determine when touch selection menu is shown and helps in executing commands on the touch selection menu. Fix some nits in TouchSelectionMenuViews along the way. This CL originally landed as https://crrev.com/c/2082750 but got reverted in https://crrev.com/c/2178584 due to failures on bots with CFI enabled. The static cast from View to TouchSelectionMenuViews should be safe but for some reason CFI bot isn't happy. Given we don't need TouchSelectionMenuViews and View can satisfy the test, using View instead of casting to TouchSelectionMenuViews. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_cfi_rel_ng Bug: 1027842 Change-Id: Ia055dd15caf894fad64e2a35fed524244ed598f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203785 Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Reviewed-by:Peter Kasting <pkasting@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#770002}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e67e41aa8994..5a7be3da2119 git log e67e41aa8994..5a7be3da2119 --date=short --first-parent --format='%ad %ae %s' 2020-05-19 yekuang@google.com Roll out new goma client binary VERSION=200 Created with: gclient setdep -r src/third_party/depot_tools@5a7be3da2119 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Idba87111ad7217b52e537c996aee6e1cc9f77d79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208464Reviewed-by:
-
Takashi Toyoshima authored
To reduce risks for launching OOR-CORS on WebView 83/84, we temporarily disable the kStrictAccessControlAllowListCheck for M84. Once this patch is merged to the M84 branch, I will quickly revert this for M85. Bug: 1084376 Change-Id: I2256eed511ea995bad91b611f976d72eb228443b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206861 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7a4ea2baf5df..de89a4a8e174 git log 7a4ea2baf5df..de89a4a8e174 --date=short --first-parent --format='%ad %ae %s' 2020-05-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 d34ab323f368..fabf74bda604 (4 commits) Created with: gclient setdep -r src/third_party/skia@de89a4a8e174 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: If8a3eaa50fcbf60e6f35332b92ee12c2cedcfe09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208463Reviewed-by:
-
John Abd-El-Malek authored
This makes it less error prone that an embedder would forget to call these methods on their profiles. e.g. WebLayer didn't do it correctly (see r769103). The one behavior change is to stop calling content::UpdateCorsExemptHeader() for the system network contexts in chrome, cast, and weblayer. This shouldn't be needed because web pages don't request URLs through these network contexts. Change-Id: I53d8aec24a6b129a1a711df6c8e6168068434807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203759 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#769998}
-
Samuel Huang authored
DeltaSymbolGroup.CountUniqueSymbols() sums separate unique leaf symbol counts in "before" and "after". Previously this was done via temporary SymbolGroups and using their CountUniqueSymbols(). As a memory optimization, both temporary SymbolGroups were given Symbol iterators at construction. However, the |_symbols| member become single- use as a result. This violates the immutability property of the object, and causes problem as we plan to process |_symbols| in upcoming work to add multi-container support. A short fix is to convert input and make |_symbols| as a list, but this is opaque, and undoes the optimization above. This CL makes the following changes instead: * Assert that SymbolGroup() is given list at construction. * Replace SymbolGroups.IterUniqueSymbols() with a static generator SymbolGroups.IterUnique() that takes an input iterator. * All callers undergo minor change. * Callers of {Delta}SymbolGroups.CountUniqueSymbol() are unchanged. * Update DeltaSymbolGroup.CountUniqueSymbols() to use the new interface, without needing temporary SymbolGroups. Optimization is kept. Bug: 1040645 Change-Id: I32c3867fe006a078f9a6ddcf764349b360120e9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204304 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#769997}
-
rbpotter authored
Adding closure compilation for destination_settings_test. This also requires adding compilation for cloud_print_interface_stub and native_layer_stub. Bug: 1000989 Change-Id: Ie8ca55910c869208d0833bed8ca47676f84052e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204531 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#769996}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/e25ee25e7743..949f1e45f1dc git log e25ee25e7743..949f1e45f1dc --date=short --first-parent --format='%ad %ae %s' 2020-05-19 natlee@microsoft.com Refactor MapRequestTracker to be its own class file. 2020-05-19 jiawei.shao@intel.com Disallow the copies within the same buffer 2020-05-18 hugo.amiard@laposte.net D3D12: Implement UseDxc toggle to use DXC for HLSL compilation Created with: gclient setdep -r src/third_party/dawn@949f1e45f1dc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I0cab6148884cf11e81105bc7d999b9d2f7e006e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208462Reviewed-by:
-
rbpotter authored
- Add closure targets for Print Preview test directory - Closure compile test utils and advanced_dialog_test - Resolve a circular dependency between print_preview_test_utils and native_layer_stub. - Add print_preview target in c/b/r/print_preview/BUILD.gn Bug: 1000989 Change-Id: Iba95a93b9c974c382fd7fd222f393861a2fae07a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204271 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Wei Lee authored
Since we already removed GCA and Migration app from latest image, we don't need to use preference service in Chrome to store the migration status. Instead, we can use local storage for it. Bug: 980846 Test: Launch CCA and it works normally Change-Id: I99c9a11f1dc4cdc5ebe871367cd596e7e0a66f3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132646 Auto-Submit: Wei Lee <wtlee@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kuo Jen Wei <inker@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#769993}
-
Yuke Liao authored
TBR=thakis@chromium.org Cq-Include-Trybots: chrome/try:mac-chrome Cq-Include-Trybots: chrome/try:win-chrome Cq-Include-Trybots: chrome/try:win64-chrome Bug: 1071576 Change-Id: Ia1972fc48ffee6957bffa7d2639ae7a30817a01f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208029Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#769992}
-
