GitLab

This CL improve the sharding algorithm by adjusting the policy of picking a story
at the boundary a benchmark shard.

Before this, we will keep adding story to a benchmark shard until the total time
assigned is greater than expected total time (assuming assignment is perfect).
This CL changes it to keep adding story until the absolute value of the difference
between total time assigned and expeted total time is minimal.

The effectiveness of this change can be shown by looking at the predict stats ("extra_info" field)
in the 3 shards: linux_perf_shard_map, mac_1012_low_end_26_shard_map,
mac_1013_high_end_26_shard_map.

Change-Id: I3ace373fb1393658cc21aca1a61a66d865a8c059

NOTRY=true  # tests covered by PRESUBMIT

Change-Id: I3ace373fb1393658cc21aca1a61a66d865a8c059
Reviewed-on: https://chromium-review.googlesource.com/1108374
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Emily Hanley <eyaich@chromium.org>
Reviewed-by: Ashley Enstad <ashleymarie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569241}

Locally the SitePerProcessBrowserTests were working with surface sync on Android.
This updates the filter to only block SitePerProcessHitTests instead.

Also updates the Viz filter to remove the Mac only failures.

TBR=fsamuel@chromium.org
TEST=surface_sync_content_browsertests, viz_content_browsertests

Bug: 849746
Change-Id: Id6fca3c0ff2ad31a2ee0051b2b889fb80d0c51e3
Reviewed-on: https://chromium-review.googlesource.com/1110038Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569240}

This reverts commit 8f2591ae.

Reason for revert: Likely broke DesktopMediaPickerViewsTest.
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/33273

Original change's description:
> [ozone/wayland] Manually handle fullscreen states.
> 
> In order to ensure media files can enter fullscreen mode, manually
> handle fullscreen states. Basically, a compositor sends configuration
> events on each request for state changes from clients asynchronously,
> which is unefficient for media files when they enter a fullscreen mode.
> 
> For example, when a youtube video file is being set to fullscreen, a
> WaylandWindow is also set to a fullscreen mode, but the return value from
> the WaylandWindow::GetPlatformWindowState still contains an old value until
> the compositor calls with a configuration event. This short race is
> enough for a media content to be placed in a forever "entering fullscreen"
> state, which never results in a fullscreen state for media files.
> 
> Bug: 843018
> TEST: XdgVersionV5Test/WaylandWindowTest.SetFullscreenAndRestore/0
> XdgVersionV6Test/WaylandWindowTest.SetFullscreenAndRestore/0
> 
> Change-Id: Ib9bc8c0ce09412c36437d165efc6a0cad60c4d17
> Reviewed-on: https://chromium-review.googlesource.com/1107636
> Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
> Commit-Queue: Maksim Sisov <msisov@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#569172}

TBR=rjkroege@chromium.org,msisov@igalia.com

Change-Id: I9920185d61395a70663fa184e834592f02176da3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 843018
Reviewed-on: https://chromium-review.googlesource.com/1110057Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569239}

Moving static variables and functions to anonymous namespace.

Bug: None

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I91789dd354da254dd13410425792321a2608f19c
Reviewed-on: https://chromium-review.googlesource.com/1049587
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Prashant Nevase <prashant.n@samsung.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569238}

This is mainly for compile step time improve for android-kitkat-arm-rel builder
having symbol_level=1

I measured peak memory usage when link some large targets with android-kitkat-arm-rel builder's config.

libchrome.so: 4776232 KB
lib_unit_tests__library.so: 5308156 KB
lib_components_unittests__library.so: 5383500 KB

So 6GB will be sufficient for such builder. This also increase parallelism of proguard steps too.

Bug: 804251
Change-Id: I7e8785ae3f14d8ba1f45da532585d7c61875d321
Reviewed-on: https://chromium-review.googlesource.com/1104280Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569237}

For compatibility, make all callbacks return false when is_main_frame is
false (current behavior).

Bug: 823285
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I0bd4c7d1561df87f80c88b37e2342e4589a1fd24
Reviewed-on: https://chromium-review.googlesource.com/1105989Reviewed-by: John Wu <jzw@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569236}

This patch adapts accessibility module to LayoutNG by:
 * Make |AbstractInlineTextBox| as an interface like class and implements legacy
 version |LegacyAbstractInlineTextBox| using InlineTextBox and LayoutNG
 version |NGAbstractInlineTextBox| using NGPaintFragment.
 * Make |AXLayoutObject| to handle |LayoutNGListMarker|
   - |LayoutListMarker| has no children.
   - |LayoutNGListMarker| is a container of list marker.
 * Make |AXLayoutObject::ComputeAccessibilityIsIgnored()| to handle LayoutNG
 block flow to check empty block flow.
 * Make |NGPaintFragment::FragmentRange::iterator| to work with |std::next()|
 * Intrdouce LayoutText::GetFirstLetterPart() for ease of getting layout object
  for first-letter part from layout object for remaining part.

Following patch will implements NGAbstractInlineTextBox::CharacterWidths()

The doc,https://bit.ly/2kUEFZy, contains study and change details.

TBR=dmazzoni@chromium.org

Bug: 714962
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iae25e8a7d7e6be0c7478470c690e081084476e85
Reviewed-on: https://chromium-review.googlesource.com/1104082
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569235}

Per the HTML Standard, the recommended JavaScript MIME type is
`text/javascript` and not `application/javascript`. We should use
the former in all examples by default. This patch updates the CORB
explainer accordingly.

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I8435745806eb04fdde9d44a9cb0133986d165ef8
Reviewed-on: https://chromium-review.googlesource.com/1109687Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569234}

This CL just extracts some commonly-used logic into helper functions
in preparation for introducing several more unittests that use this
logic extremely heavily.

There is more such extraction that could be performed for different
pieces of code; this CL just focuses on the pieces that are relevant
for the upcoming unittests.

Change-Id: I83f86faa4679dc0639cc1abff561b640baff5816
Reviewed-on: https://chromium-review.googlesource.com/1101687
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569233}

As Service Worker IPCs are all in Mojo now, we no longer use
ServiceWorkerDispatcherHost to handle any legacy IPCs, its only usage is
to implement mojom::ServiceWorkerDispatcherHost interface, so, it no
longer needs to be a BrowserMessageFilter.
This CL makes ServiceWorkerDispatcherHost not a BrowserMessageFilter any
more, but still keeps its Mojo interface being associated with the
legacy IPC channel.

In future once we make clear of those potential races with some legacy
IPCs like navigation IPCs, we can consider putting
mojom::ServiceWorkerDispatcherHost on a dedicated Mojo message pipe, or
we'd remove mojom::ServiceWorkerDispatcherHost completely if we can find
an alternative/clear way to achieve the same goal.

BUG=845341

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I9f764017832a5e2f9ff15aff9b49b4c2a6834b78
Reviewed-on: https://chromium-review.googlesource.com/1105623Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#569232}

The profile avatar opens the Chrome profile menu. This change adds 3 new menu items there.
- Passwords -> chrome://settings/passwords
- Payment methods -> chrome://settings/autofill
- Addresses -> chrome://settings/autofill
It's expected for M69 that Payment methods and Addresses link to the same page.
The icon for addresses is just temporary.

Bug: 854562
Change-Id: I7f5b62914e49b8e3ae9d882a7d6eaaf05a532100
Reviewed-on: https://chromium-review.googlesource.com/1108097
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569231}

This reverts commit 3948b2b2.

Reason for revert: root cause was fixed

Original change's description:
> Disable failing brows:news:cnn on webview system_health.common
> 
> Bug: 854683
> Change-Id: I6cd308c8eadf151051916262c1d17530e85be0c1
> TBR: charliea@chromium.org
> NOTRY: true
> Reviewed-on: https://chromium-review.googlesource.com/1108396
> Reviewed-by: Annie Sullivan <sullivan@chromium.org>
> Commit-Queue: Annie Sullivan <sullivan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#568918}

TBR=sullivan@chromium.org

Change-Id: Id6aa4dd0526a4b6fea26d825cbca8e1639eebabe
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 854683
Reviewed-on: https://chromium-review.googlesource.com/1109997Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#569230}

Bug: 854778
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I9cfb73cb5a33085a89a127591d86c70da11171b4
TBR: penghuang@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1109919Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569229}

Those tests trigger code path that access the toolbar if there
is an active WebState in the WebStateList. This requires that
the WebState returns non-null BrowserState and NavigationManager
so set the corresponding property on the TestWebState.

Bug: none
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ic950a706b31ac153cdfb71b510681c09886c3da0
Reviewed-on: https://chromium-review.googlesource.com/1106176Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569228}

In particular, remove any notion of 'bridge' and hence stop using
ModelTypeChangeProcessor altogether, since it's irrelevant for testing
ModelTypeController.

Bug: 791939
Change-Id: I76abc5e3ff48fb73ecb943e17fd114b11ec5aed6
Reviewed-on: https://chromium-review.googlesource.com/1109822
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569227}

Previously, we cleared Sync data on most, but not all types of
unrecoverable errors: Engine initialization failure was treated
specially. Per the TODO removed in this CL, there was no reason
for the special treatment anymore.

Bug: 839834
Change-Id: I3b473c65b837c810e6fe8456defffe6ebe6e53a2
Reviewed-on: https://chromium-review.googlesource.com/1107991Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569226}

They are motivated by an ongoing investigation for test
flakiness on iOS, with the suspicion that some of the codepaths
(namely, where calls to OnSyncStopping() could be dropped) can
cause issues (e.g. sync metadata being leaked).

Bug: 854446
Change-Id: I6fe7da40c36d00e01afa176334f59f9dc66a74e1
Reviewed-on: https://chromium-review.googlesource.com/1108200Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569225}

The UI needs the new password value. Thus, the method is needed in ChromePasswordManagerClient.
Also it doesn't seem right to scatter all the generation events across two interfaces while autofill::mojom::PasswordManagerClient solely concentrates on generation.

Bug: 851021
Change-Id: I6a6dcc59a934202bb0e2e336ff1324da131c6dfd
Reviewed-on: https://chromium-review.googlesource.com/1104339Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569224}

And that's how it's supposed to work, apparently. We're just supposed to mark
such lines dirty when the objects get deleted, and the dangling pointers will
be cleaned up "soon enough".

When removing a FloatingObject, we need to mark the RootInlineBox object that
points to it as dirty. The case we were missing was the one where we remove ALL
floating objects. When removing just one, on the other hand, we use
LayoutBlockFlow::RemoveFloatingObject(), which already takes care of this.

Bug: 835613
Change-Id: I2b978f1bb4c9a496a5dad4b097ef598630059a9d
Reviewed-on: https://chromium-review.googlesource.com/1108936
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569223}

SpeechGrammarList's addFromURI because it doesn't match the spec:
https://github.com/w3c/speech-api/issues/26

SpeechRecognitionEvent's interpretation and emma attributes because
they actually always return null and might be better to remove:
https://chromium.googlesource.com/chromium/src/+/7ad6ea7c2583942e86017bdd6fd5df991f6a05af/third_party/blink/renderer/modules/speech/speech_recognition_event.h#55

SpeechSynthesis#speak() to measure real SpeechSynthesis usage, like
the existing counter for SpeechRecognition#start().

Bug: 755287
Change-Id: I4f7fdcc5630887aaa051ac8ab13f72dab52c8dfb
Reviewed-on: https://chromium-review.googlesource.com/1109510Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569222}

Although there have been the thresholds of cache usage limitations for the Android
in /gpu/config/gpu_preferences.h, it would be good if we can give embedders the power
to set the cache size for the ShaderDiskCache. Because there are many various embedded
devices which have different sizes of disk.

Bug: 854494
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ie1ecb903a79e52ee79503df30fe1ae15b95739ea
Reviewed-on: https://chromium-review.googlesource.com/1107517
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569221}

https://chromium.googlesource.com/catapult.git/+log/f3c454475aee..44fc6f687b35


git log f3c454475aee..44fc6f687b35 --date=short --no-merges --format='%ad %ae %s'
2018-06-21 perezju@chromium.org [soundwave] Fix GetAlertData API call


Created with:
  gclient setdep -r src/third_party/catapult@44fc6f687b35

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I3a63d4bb9a29fdf8634d1713085da7950a5563b9
Reviewed-on: https://chromium-review.googlesource.com/1109698Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#569220}

The issues that this logging was introduced to diagnose are understood
and/or resolved, so it can be removed.

Also clean up some OS_POSIX && !OS_FUCHSIA preprocessor conditionals,
and migrate TestLauncher to use the zx::job container from the SDK.

Bug: 755282, 750370, 738275, 706592
Change-Id: Iedfaa62684a0b6e8524a456766186b4122e98ae0
Reviewed-on: https://chromium-review.googlesource.com/1108483
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569219}

If the device is disabled, it can be brought back to life only by the
admin of the domain. And to re-enable the device, admin needs the serial
number which might not match the data displayed on the sticker. Or the
sticker could be damaged. This change will provide the serial number on
the disabled device screen.

BUG=chromium:852284
TEST=Unit tests

Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I3fe38afc59d7c08ffc175c723b1a37660d8b1160
Reviewed-on: https://chromium-review.googlesource.com/1101209Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Igor <igorcov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569218}

This improves down sampling performance by 40 percent in all cases on
x64 with AVX and up sampling performance by 50 percent in the case of
large input block sizes (256 samples or more) on x64 with AVX. Up
sampling performance in the case of normal input block sizes (128
samples) is not affected. Performance improvements on x64 with SSE but
without AVX are even bigger than those on x64 with AVX.

On Arm, the performance improvement is 270 percent.

When FFT resampling is used for the WaveShaper, we need to account
for some small round-off errors in the result compared with the
previous direct convolver.  Slightly adjust how the thresholds work
and the threshold value for the tests. Thanks to Raymond Toy (rtoy@)
for these layout test updates.

Bug: 851941
Change-Id: I2dc4bb30ccc6d1314a3e779a61ffac210cf702a1
Reviewed-on: https://chromium-review.googlesource.com/1090841
Commit-Queue: Eero Häkkinen <eero.hakkinen@intel.com>
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569217}

https://android.googlesource.com/platform/external/perfetto.git/+log/c203a76fa400..ae8db279f88e


git log c203a76fa400..ae8db279f88e --date=short --no-merges --format='%ad %ae %s'
2018-06-21 taylori@google.com Merge "trace_processor: Parse process and trace packets"
2018-06-21 taylori@google.com Merge "trace_processor: Assign utid and store thread info when processing sched event"
2018-06-20 taylori@google.com trace_processor: Parse process and trace packets
2018-06-20 taylori@google.com trace_processor: Assign utid and store thread info when processing sched event


Created with:
  gclient setdep -r src/third_party/perfetto@ae8db279f88e

The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:80416541,chromium:80416541
TBR=perfetto-bugs@google.com

Change-Id: I7456bbaa350186324026a76a4e57062b364005f3
Reviewed-on: https://chromium-review.googlesource.com/1109699
Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#569216}

This reverts commit c6c7cdfc.

Reason for revert: Wrong story was disabled.

Original change's description:
> Disable Flaky SystemHealthBenchmarkSmokeTest.
>
> BUG=852888
>
> TBR=perezju@chromium.org
>
> Change-Id: I773594071fb0e9357af63d3024dd71125cad9723
> Reviewed-on: https://chromium-review.googlesource.com/1104880
> Reviewed-by: Steven Holte <holte@chromium.org>
> Commit-Queue: Steven Holte <holte@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#568140}

TBR=holte@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

NOTRY=True

Bug: 852888
Change-Id: Ibded1b8ca4185a53323dcd26e76501b25dfd6a54
Reviewed-on: https://chromium-review.googlesource.com/1109039
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569215}

This CL sets the alignment of the Anchor node in accordance, when
vertical-rl writing-mode is set

Bug: 844868
Change-Id: I8357bcccbc88ffcd3b5d01265737a5b60f1e59a8
Reviewed-on: https://chromium-review.googlesource.com/1075956
Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569214}

When the user is signed out of Chrome and the profile icon
has not been explicitly changed, AvatarToolbarButton now
uses the account icon of the first sync promo account.

Screenshots:
https://drive.google.com/file/d/1a7kr12KtA11Wt7MQ9MLnSf-M3D9nlLdg/view?usp=sharing
https://drive.google.com/file/d/1nKLnoD1sbcZOvwGQY3YtHVTUv32DQNFn/view?usp=sharing

Bug: 853363
Change-Id: I11ed80e2250bc4eb9202e4a1c4cabf242954f726
Reviewed-on: https://chromium-review.googlesource.com/1105772
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569213}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/160d2815..2b67614b

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: Id66e0898bb76dbdbb592239dde3dd0db2cbc0f66
Reviewed-on: https://chromium-review.googlesource.com/1108889Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#569212}

The feature of WebRTC event logging to a remote server, is now
intended to be gated behind a Chrome policy. As such, it would make
more sense to treat incognito mode as any other profile, which
does not have the policy enabled.

Bug: 775415
Change-Id: I14c0b5e14578fc8a5ae27d8921583728e8850282
Reviewed-on: https://chromium-review.googlesource.com/1105770
Commit-Queue: Elad Alon <eladalon@chromium.org>
Reviewed-by: Henrik Grunell <grunell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569211}

The Clank orderfile is being improved as part of an effort to improve
Clank memory usage [1]. One step in this effort is to give telemetry
benchmarks more control over instrumentation profiling.

In this CL I extend the devtools RequestMemoryDump command to also
tell instrumentation support to dump the current profile. This only
happens if chrome is compiled with instrumentation turned on
(use_order_profiling=true). The instrumentation dump is done at the
same time as the memory dump is handled on the client side.

[1] https://docs.google.com/document/d/1dAt_puAX4SyqXDOdglxe6ku9GwnyBiOMjHAsDNwN0HY/edit#

Bug: 843561
Change-Id: I6d08e1cd24dc6f16ca12f8fa519ab9725d3ed914
Reviewed-on: https://chromium-review.googlesource.com/1087959
Commit-Queue: Matthew Cary <mattcary@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569210}

It's sometimes useful for Blink to define features instead of putting them in
//content. In this case, ServiceWorkerServicification.

Follow-up to r568796 <https://chromium-review.googlesource.com/1107435>.

Change-Id: Ia174481414f2ceeb2f463307436170628da84346
Reviewed-on: https://chromium-review.googlesource.com/1108237
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569209}

The name was appropriate at the start but not it checks much more than
this.

Change-Id: Id9b01ae5f62cc2fbc834559e80f75dc6305e7d21
Reviewed-on: https://chromium-review.googlesource.com/1109670Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569208}

v8_context_snapshot is not the target to be linked to other libraries.

This improves build time of some targets by utilize parallelization.
For example, build time of -j800 content_shell reduced from 316.8s to 254.5s on Z840 linux without goma backend cache.

See the difference of build trace screenshots in
https://bugs.chromium.org/p/chromium/issues/detail?id=725639#c20

Bug: 725639
Change-Id: I64d57241ff6b742db4ddcb31afc07a5e7c2e2eb1
Reviewed-on: https://chromium-review.googlesource.com/1107431Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569207}

Next cleanup after
https://chromium-review.googlesource.com/c/chromium/src/+/1091753

* Using int const instead of String inside SiteSettingsCategory.java
* Creating dynamically ContentSettingException array
  inside Website.java
* Sharing preference keys from SiteSettingsPreferences.java
  with category keys in the SiteSettingsCategory.java
* Other minor cleanups inside Android preferences/website directory

Change-Id: I2e4a97e0f54f6e91aa47a931905e869988ad1858
Reviewed-on: https://chromium-review.googlesource.com/1097408Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Cr-Commit-Position: refs/heads/master@{#569206}

The cu_id_web_contents_map_ can be mutated by observers and can make
the iterator in NotifyObserversIfKnownCu invalid.

See the comment of the regression test for the description of the
scenario that can happen with tab discarding.

Change-Id: I90a7f1710655573fa059bf3f12bf40013ebc7743
Reviewed-on: https://chromium-review.googlesource.com/1107798
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569205}

They are only used for storing an extra ComputedStyle for
display:contents pseudo elements as the ComputedStyle for rendering uses
a display:inline with only properties inherited for the parent element.

Bug: 854563
Change-Id: I4dd3d99b0dee0b538645d005b36347b469799244
Reviewed-on: https://chromium-review.googlesource.com/1107802Reviewed-by: Anders Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569204}

Add the @RetryOnFailure annotations. These tests rely on the keyboard
which seems to have massive troubles on some trybots only.

I am still looking for a better way to ensure the keyboard is up and
will try to replace this. If this doesn't improve the tests, the next,
sad step is to disable them temporarily.

Bug: 854326
Change-Id: I7d1bba9a5efa6213fc53c1d84e0fcf88ec3ba9dd
Reviewed-on: https://chromium-review.googlesource.com/1109679Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569203}

Another test that relies on the keyboard to work. Disabling it for now.

(If more tests in this directory flake, feel free to disable them right
away - they are not testing live code. A big rework for all of them is
likely in a forseeable future.)

TBR: bauerb@chromium.org
Bug: 854224
Change-Id: I3b27fd0e500f282ef71d7206ee1ef774edcbe4a5
Reviewed-on: https://chromium-review.googlesource.com/1109682Reviewed-by: Friedrich Horschig <fhorschig@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569202}