1. 25 Aug, 2016 40 commits
    • v8-autoroll's avatar
      Update V8 to version 5.4.520. · ac33f572
      v8-autoroll authored
      Summary of changes available at:
      https://chromium.googlesource.com/v8/v8/+log/b4f9789f..5b52c69a
      
      Please follow these instructions for assigning/CC'ing issues:
      https://github.com/v8/v8/wiki/Triaging%20issues
      
      Please close rolling in case of a roll revert:
      https://v8-roll.appspot.com/
      This only works with a Google account.
      
      CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
      
      TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org
      
      Review-Url: https://codereview.chromium.org/2279753002
      Cr-Commit-Position: refs/heads/master@{#414414}
      ac33f572
    • kraynov's avatar
      Tracing V2: Fully-functional plugin. · e4f1cbdb
      kraynov authored
      Added wrapper namespace for unit tests to avoid name collisions
      with official protobuf. Tiny varint support in ProtoZeroMessage.
      Added tests to check conformance with the official protobuf.
      
      BUG=608721
      
      Review-Url: https://codereview.chromium.org/2240043004
      Cr-Commit-Position: refs/heads/master@{#414413}
      e4f1cbdb
    • vasilii's avatar
      Set the 3 times suppress threshold for the smart password bubble. · db85689d
      vasilii authored
      This is essentially launching the smart password bubble unless the server config overwrites the value.
      
      BUG=618312
      
      Review-Url: https://codereview.chromium.org/2278093003
      Cr-Commit-Position: refs/heads/master@{#414412}
      db85689d
    • johnme's avatar
      Revert of Move scaling of ui resources for scrollbars to the time of upload... · 4e32d1b8
      johnme authored
      Revert of Move scaling of ui resources for scrollbars to the time of upload (patchset #1 id:1 of https://codereview.chromium.org/2280663002/ )
      
      Reason for revert:
      Sorry about the spam. Re-reverting now that https://codereview.chromium.org/2282433002 which depends on this patch has been reverted.
      
      Original issue's description:
      > Reland of Move scaling of ui resources for scrollbars to the time of upload (patchset #1 id:1 of https://codereview.chromium.org/2278083002/ )
      >
      > Reason for revert:
      > Reverting this broke compile:
      >
      > cc/layers/painted_scrollbar_layer.cc:83:29: error: no member named 'GetRendererCapabilities' in 'cc::LayerTreeHost'
      >   return layer_tree_host()->GetRendererCapabilities().max_texture_size;
      >          ~~~~~~~~~~~~~~~~~  ^
      >
      > Original issue's description:
      > > Revert of Move scaling of ui resources for scrollbars to the time of upload (patchset #6 id:100001 of https://codereview.chromium.org/2276633003/ )
      > >
      > > Reason for revert:
      > > Sorry, seems to have caused LayerTreeHostScrollbarsPixelTest.HugeTransformScale to fail on Mac10.10 Tests,  Mac10.11 Tests, Win 7 Tests x64 (1), Win10 Tests x64, Mac10.9 Tests and Linux Tests, with failures like:
      > >
      > > [8034:1287:0825/033725:3059591139598:ERROR:pixel_comparator.cc(50)] Number of pixel with an error: 672
      > > [8034:1287:0825/033725:3059591187709:ERROR:pixel_comparator.cc(51)] Error Bounding Box : 0,304 368x66
      > > [8034:1287:0825/033725:3059610880597:ERROR:pixel_test_utils.cc(79)] Pixels do not match!
      > > [8034:1287:0825/033725:3059610905829:ERROR:pixel_test_utils.cc(80)] Actual: data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAZAAAAGQCAYAAACAvzbMAAAF4ElEQVR4nO3ZQY1CQRRFwccEUWhhgQEMYAED7FGDKtJsxsCcTYdMVQt4d3eS/w9rrTUAX+g+97nNbfeMbS5zmec8t93/2XYZgK8mIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAcnzMY/cGgOQ1r90T/rXjda67NwDwhXzCAiAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREACS43nOuzcAEJzmtPX+4b3ea+sCAJLD79t2f60lIAD8mX8gACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJB9NHxfMgTV5VwAAAABJRU5ErkJggg==
      > > [8034:1287:0825/033725:3059610929427:ERROR:pixel_test_utils.cc(81)] Expected: data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAZAAAAGQCAYAAACAvzbMAAAF4klEQVR4nO3ZQY1CQRRFwfcJotDCYhQgAAsIQABqMEXSo2HOpkOmysC7u5N0H2utNQBf6DGPuc9994xtfuZnXvPadv+07TIAX01AAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIDk/Jzn7g0AyXveuyf8a+fb3HZvAOALecICIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQAJLzda67NwAQXOay9f7xWZ+1dQEAyWlOc8yx7f6x1hIQAP7MHwgAiYAAkAgIAImAAJAICACJgACQCAgAiYAAkAgIAImAAJAICACJgACQCAgAiYAAkAgIAImAAJAICACJgACQCAgAiYAAkAgIAImAAJAICACJgACQCAgAiYAAkAgIAImAAJAICADJLzUdF8xyVTjQAAAAAElFTkSuQmCC
      > > ../../cc/test/layer_tree_pixel_test.cc:124: Failure
      > > Value of: MatchesPNGFile(*result_bitmap_, ref_file_path, *pixel_comparator_)
      > >   Actual: false
      > > Expected: true
      > >
      > > Original issue's description:
      > > > Move scaling of ui resources for scrollbars to the time of upload
      > > >
      > > > Instead of trying to figure out what the max texture size is on the
      > > > main thread, and scale raster to meet that, just raster freely. Then
      > > > when uploading the UIResource to a texture, we can easily tell what
      > > > the max texture size is, and if the UIResource is too large, scale it
      > > > down to fit in a texture.
      > > >
      > > > R=enne
      > > > BUG=606056
      > > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
      > > > NOTRY=true
      > > >
      > > > Committed: https://crrev.com/941e52edd1522f7c3935aa4f4d763c43578b4944
      > > > Cr-Commit-Position: refs/heads/master@{#414202}
      > >
      > > TBR=enne@chromium.org,danakj@chromium.org
      > > # Skipping CQ checks because original CL landed less than 1 days ago.
      > > NOPRESUBMIT=true
      > > NOTREECHECKS=true
      > > NOTRY=true
      > > BUG=606056
      > >
      > > Committed: https://crrev.com/706757873f077fcf245c8e4054a5dfd8424d5ed2
      > > Cr-Commit-Position: refs/heads/master@{#414391}
      >
      > TBR=enne@chromium.org,danakj@chromium.org
      > # Skipping CQ checks because original CL landed less than 1 days ago.
      > NOPRESUBMIT=true
      > NOTREECHECKS=true
      > NOTRY=true
      > BUG=606056
      >
      > Committed: https://crrev.com/f56ab5d893d9c1ff735136d8df7d738b16634a7a
      > Cr-Commit-Position: refs/heads/master@{#414394}
      
      TBR=enne@chromium.org,danakj@chromium.org
      # Skipping CQ checks because original CL landed less than 1 days ago.
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      BUG=606056
      
      Review-Url: https://codereview.chromium.org/2282443002
      Cr-Commit-Position: refs/heads/master@{#414411}
      4e32d1b8
    • blundell's avatar
      PlzNavigate: Triage renderer-initiated failed navigation tests · 76f7fed1
      blundell authored
      These tests fail due to WebFrameClient having a difference sequence of
      callbacks, which is itself due to the fact that in PlzNavigate, the
      navigation failure is detected in the browser.
      
      BUG=640631
      
      Review-Url: https://codereview.chromium.org/2278563002
      Cr-Commit-Position: refs/heads/master@{#414410}
      76f7fed1
    • recipe-roller's avatar
      Roll recipe dependencies (trivial). · 55bdc02c
      recipe-roller authored
      This is an automated CL created by the recipe roller. This CL rolls recipe
      changes from upstream projects (e.g. depot_tools) into downstream projects
      (e.g. tools/build).
      
      More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
      (or complain)
      
      build:
        https://crrev.com/8009c7dfc942b4feddfc631d8764e508824b6756 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
      depot_tools:
        https://crrev.com/f8757b7e02226594655230ccbeae3543c7dc49c6 gclient: kill git fetch operation that hangs. (tandrii@chromium.org)
      
      TBR=martiniss@chromium.org,phajdan.jr@chromium.org
      BUG=635641
      
      Recipe-Tryjob-Bypass-Reason: Autoroller
      Bugdroid-Send-Email: False
      Review-Url: https://codereview.chromium.org/2273313002
      Cr-Commit-Position: refs/heads/master@{#414409}
      55bdc02c
    • johnme's avatar
      Revert of cc: Delete all the RendererCapabilities. (patchset #2 id:20001 of... · c2673922
      johnme authored
      Revert of cc: Delete all the RendererCapabilities. (patchset #2 id:20001 of https://codereview.chromium.org/2267263002/ )
      
      Reason for revert:
      This patch prevents reverting https://codereview.chromium.org/2280663002
      
      Original issue's description:
      > cc: Delete all the RendererCapabilities.
      >
      > The one left that gets used is max_texture_size, for scrollbars. Since
      > painted scrollbars only happen on desktop, and we just make them blurry
      > if they exceed the max size, we just hardcode a limit of 2048 which
      > should be supported on any desktop device (it's guaranteed by DirectX9)
      > and we're fine with scrollbars becoming less than pixel-perfect if you
      > pinch zoom in and they become larger than max-texture-size anyhow.
      >
      > Everything else is unused or already deleted, so kill the structures
      > and the thread/ipc messages related to them.
      >
      > R=enne
      > BUG=606056
      > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
      >
      > Committed: https://crrev.com/6484c37f7b2cfcaed90cc8a37677c670a75be023
      > Cr-Commit-Position: refs/heads/master@{#414212}
      
      TBR=enne@chromium.org,danakj@chromium.org
      # Skipping CQ checks because original CL landed less than 1 days ago.
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      BUG=606056
      
      Review-Url: https://codereview.chromium.org/2282433002
      Cr-Commit-Position: refs/heads/master@{#414408}
      c2673922
    • treib's avatar
      [NTP Snippets] Safe(r) defaults for background fetching intervals · 8e47dfc3
      treib authored
      BUG=none
      
      Review-Url: https://codereview.chromium.org/2277223002
      Cr-Commit-Position: refs/heads/master@{#414407}
      8e47dfc3
    • droger's avatar
      Renderer-side changes for NoState Prefetch · 04f065d8
      droger authored
      NoState Prefetch design doc:
      https://docs.google.com/document/d/16VCYGGWau483IMSxODpg5faZny1FJ6vNK2v-BuM5EhU
      
      This CL is the first step for NoState Prefetch implementation
      in the renderer.
      
      The code added in this CL is not called yet (it will be called
      only when the PREFETCH_ONLY enum is sent through IPC).
      
      The prefetching is implemented in the HTMLDocumentParser.
      When prefetching, the parser runs in single-thread mode.
      When feeded with HTML input, it runs the preload scanner on
      it, and stops without actually building or executing the page.
      
      BUG=632361
      
      Review-Url: https://codereview.chromium.org/2172613002
      Cr-Commit-Position: refs/heads/master@{#414406}
      04f065d8
    • ericwilligers's avatar
      CSS: Make ~InvalidationSet protected · 4cfb70c6
      ericwilligers authored
      InvalidationSet now implements ref counting directly, in the same manner
      as LayoutPart, instead of inheriting from RefCounted.
      
      Previous attemps at making the InvalidationSet destructor protected had
      failed because in one or more builds (win_chromium_compile_dbg_ng), an
      error message was being reported in
      'void WTF::RefCounted<blink::InvalidationSet>::deref(void) const'.
      
      BUG=412572
      
      Review-Url: https://codereview.chromium.org/2274143002
      Cr-Commit-Position: refs/heads/master@{#414405}
      4cfb70c6
    • tasak's avatar
      Make PendingScript MemoryCoordinatorClient: · 2635c95b
      tasak authored
      - implement prepareToSuspend for background renderer's purge + suspend. prepareToSuspend is invoked before a background renderer is suspended.
      - PendingScript's prepareToSuspend cancels ScriptStreaming.
      - intent-to-implement-and-ship of background renderer's purge + suspend is https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/DK189tnM8l4
      - one of the documents attached in the above intent is https://docs.google.com/document/d/1EgLimgxWK5DGhptnNVbEGSvVn6Q609ZJaBkLjEPRJvI/edit?usp=sharing
      
      BUG=635419
      
      Review-Url: https://codereview.chromium.org/2268153002
      Cr-Commit-Position: refs/heads/master@{#414404}
      2635c95b
    • sunyunjia's avatar
      Fix two crashes caused by crrev.com/413616 · 41928a8e
      sunyunjia authored
      BUG=640150, 640494
      
      Review-Url: https://codereview.chromium.org/2270833002
      Cr-Commit-Position: refs/heads/master@{#414403}
      41928a8e
    • sfiera's avatar
      Allow category["suggestions"] to be absent. · 90f20b32
      sfiera authored
      APIs do not return empty lists, apparently. If a repeated field is
      empty, then it will be absent in the JSON. Allow this, but make sure
      that the empty category is created first.
      
      Review-Url: https://codereview.chromium.org/2279483002
      Cr-Commit-Position: refs/heads/master@{#414402}
      90f20b32
    • johnme's avatar
      Mark pixel-crack-image-background-webkit-transform-scale failing on Mac · 0b70c48a
      johnme authored
      Test
      virtual/gpu-rasterization/fast/images/pixel-crack-image-background-webkit-transform-scale.html
      has been failing consistently on WebKit Mac10.10, WebKit Mac10.11
      (retina) and mac10.10_blink_rel tryserver, for as far back as the
      flakiness dashboard can show (which in practice is when
      https://codereview.chromium.org/2265333002 added it to SlowTests; before
      that it always timed out). However it always passes on other Mac bots.
      
      BUG=614910
      NOTRY=true
      NOTREECHECKS=true
      TBR=noel@chromium.org,schenney@chromium.org
      
      Review-Url: https://codereview.chromium.org/2270693010
      Cr-Commit-Position: refs/heads/master@{#414401}
      0b70c48a
    • keishi's avatar
      Trigger Blink GC on v8::kGCCallbackFlagCollectAllExternalMemory · c987ef55
      keishi authored
      BUG=570268
      
      Review-Url: https://codereview.chromium.org/2238173002
      Cr-Commit-Position: refs/heads/master@{#414400}
      c987ef55
    • treib's avatar
      [NTP Snippets] Don't show the bookmark section if there are no bookmarks at all · 92489594
      treib authored
      Also introduce a variation parameter to enable the "show if empty" behavior - it's off by default.
      
      Followup to https://codereview.chromium.org/2277743002
      
      BUG=640568
      
      Review-Url: https://codereview.chromium.org/2277523003
      Cr-Commit-Position: refs/heads/master@{#414399}
      92489594
    • Paweł Hajdan, Jr's avatar
      22feb81b
    • treib's avatar
      [NTP Snippets] Always show the bookmarks section, but at the end if it's empty · 063e6a61
      treib authored
      BUG=640568
      
      Review-Url: https://codereview.chromium.org/2277743002
      Cr-Commit-Position: refs/heads/master@{#414397}
      063e6a61
    • Paweł Hajdan, Jr's avatar
      infra: add presubmit check for recipes · 5a82f50c
      Paweł Hajdan, Jr authored
      BUG=584079
      R=emso@chromium.org
      
      Review URL: https://codereview.chromium.org/2275263002 .
      
      Cr-Commit-Position: refs/heads/master@{#414396}
      5a82f50c
    • kochi's avatar
      Ship Custom Elements v1 · ed691cd5
      kochi authored
      Flip CustomElementsV1 flag in RuntimeEnabledFeatures to stable.
      
      Got 3 LGTMs for Intent-to-Ship in blink-dev:
      https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/P2UKXfsFWWE/discussion
      
      BUG=594918
      
      Review-Url: https://codereview.chromium.org/2274883004
      Cr-Commit-Position: refs/heads/master@{#414395}
      ed691cd5
    • johnme's avatar
      Reland of Move scaling of ui resources for scrollbars to the time of upload... · f56ab5d8
      johnme authored
      Reland of Move scaling of ui resources for scrollbars to the time of upload (patchset #1 id:1 of https://codereview.chromium.org/2278083002/ )
      
      Reason for revert:
      Reverting this broke compile:
      
      cc/layers/painted_scrollbar_layer.cc:83:29: error: no member named 'GetRendererCapabilities' in 'cc::LayerTreeHost'
        return layer_tree_host()->GetRendererCapabilities().max_texture_size;
               ~~~~~~~~~~~~~~~~~  ^
      
      Original issue's description:
      > Revert of Move scaling of ui resources for scrollbars to the time of upload (patchset #6 id:100001 of https://codereview.chromium.org/2276633003/ )
      >
      > Reason for revert:
      > Sorry, seems to have caused LayerTreeHostScrollbarsPixelTest.HugeTransformScale to fail on Mac10.10 Tests,  Mac10.11 Tests, Win 7 Tests x64 (1), Win10 Tests x64, Mac10.9 Tests and Linux Tests, with failures like:
      >
      > [8034:1287:0825/033725:3059591139598:ERROR:pixel_comparator.cc(50)] Number of pixel with an error: 672
      > [8034:1287:0825/033725:3059591187709:ERROR:pixel_comparator.cc(51)] Error Bounding Box : 0,304 368x66
      > [8034:1287:0825/033725:3059610880597:ERROR:pixel_test_utils.cc(79)] Pixels do not match!
      > [8034:1287:0825/033725:3059610905829:ERROR:pixel_test_utils.cc(80)] Actual: data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAZAAAAGQCAYAAACAvzbMAAAF4ElEQVR4nO3ZQY1CQRRFwccEUWhhgQEMYAED7FGDKtJsxsCcTYdMVQt4d3eS/w9rrTUAX+g+97nNbfeMbS5zmec8t93/2XYZgK8mIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAcnzMY/cGgOQ1r90T/rXjda67NwDwhXzCAiAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREACS43nOuzcAEJzmtPX+4b3ea+sCAJLD79t2f60lIAD8mX8gACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJB9NHxfMgTV5VwAAAABJRU5ErkJggg==
      > [8034:1287:0825/033725:3059610929427:ERROR:pixel_test_utils.cc(81)] Expected: data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAZAAAAGQCAYAAACAvzbMAAAF4klEQVR4nO3ZQY1CQRRFwfcJotDCYhQgAAsIQABqMEXSo2HOpkOmysC7u5N0H2utNQBf6DGPuc9994xtfuZnXvPadv+07TIAX01AAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIDk/Jzn7g0AyXveuyf8a+fb3HZvAOALecICIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQAJLzda67NwAQXOay9f7xWZ+1dQEAyWlOc8yx7f6x1hIQAP7MHwgAiYAAkAgIAImAAJAICACJgACQCAgAiYAAkAgIAImAAJAICACJgACQCAgAiYAAkAgIAImAAJAICACJgACQCAgAiYAAkAgIAImAAJAICACJgACQCAgAiYAAkAgIAImAAJAICADJLzUdF8xyVTjQAAAAAElFTkSuQmCC
      > ../../cc/test/layer_tree_pixel_test.cc:124: Failure
      > Value of: MatchesPNGFile(*result_bitmap_, ref_file_path, *pixel_comparator_)
      >   Actual: false
      > Expected: true
      >
      > Original issue's description:
      > > Move scaling of ui resources for scrollbars to the time of upload
      > >
      > > Instead of trying to figure out what the max texture size is on the
      > > main thread, and scale raster to meet that, just raster freely. Then
      > > when uploading the UIResource to a texture, we can easily tell what
      > > the max texture size is, and if the UIResource is too large, scale it
      > > down to fit in a texture.
      > >
      > > R=enne
      > > BUG=606056
      > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
      > > NOTRY=true
      > >
      > > Committed: https://crrev.com/941e52edd1522f7c3935aa4f4d763c43578b4944
      > > Cr-Commit-Position: refs/heads/master@{#414202}
      >
      > TBR=enne@chromium.org,danakj@chromium.org
      > # Skipping CQ checks because original CL landed less than 1 days ago.
      > NOPRESUBMIT=true
      > NOTREECHECKS=true
      > NOTRY=true
      > BUG=606056
      >
      > Committed: https://crrev.com/706757873f077fcf245c8e4054a5dfd8424d5ed2
      > Cr-Commit-Position: refs/heads/master@{#414391}
      
      TBR=enne@chromium.org,danakj@chromium.org
      # Skipping CQ checks because original CL landed less than 1 days ago.
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      BUG=606056
      
      Review-Url: https://codereview.chromium.org/2280663002
      Cr-Commit-Position: refs/heads/master@{#414394}
      f56ab5d8
    • recipe-roller's avatar
      Roll recipe dependencies (trivial). · 8ad7faf9
      recipe-roller authored
      This is an automated CL created by the recipe roller. This CL rolls recipe
      changes from upstream projects (e.g. depot_tools) into downstream projects
      (e.g. tools/build).
      
      More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
      (or complain)
      
      build:
        https://crrev.com/734467cd180cd100f1b8cc6710b101413abc9cd6 Use files in path['checkout'] not resource. (yyanagisawa@chromium.org)
      
      TBR=martiniss@chromium.org,phajdan.jr@chromium.org
      BUG=314403
      
      Recipe-Tryjob-Bypass-Reason: Autoroller
      Bugdroid-Send-Email: False
      Review-Url: https://codereview.chromium.org/2278923002
      Cr-Commit-Position: refs/heads/master@{#414393}
      8ad7faf9
    • grunell's avatar
      Add UMA histograms for time spent getting WebRTC audio render data. · af11e92e
      grunell authored
      Adding:
      * Media.Audio.Render.GetSourceDataTime.WebRTC
      * Media.Audio.Render.GetSourceDataTimeMax.WebRTC
      
      Deprecating WebRTC.AudioRenderTimes. It is replaces by Media.Audio.Render.GetSourceDataTime.WebRTC which logs every render call (instead of every 10 calls) and provides higher resolution.
      
      The Max histogram logs the max time during a session (between Start() and Stop()).
      
      This will better help show how often there is missed realtime deadlines on the process boundary due to WebRTC not delivering data in time. Plus a general picture of WebRTC's data delivery performance.
      
      The new name allows adding this data for other sources under a common naming.
      
      Review-Url: https://codereview.chromium.org/2264073002
      Cr-Commit-Position: refs/heads/master@{#414392}
      af11e92e
    • johnme's avatar
      Revert of Move scaling of ui resources for scrollbars to the time of upload... · 70675787
      johnme authored
      Revert of Move scaling of ui resources for scrollbars to the time of upload (patchset #6 id:100001 of https://codereview.chromium.org/2276633003/ )
      
      Reason for revert:
      Sorry, seems to have caused LayerTreeHostScrollbarsPixelTest.HugeTransformScale to fail on Mac10.10 Tests,  Mac10.11 Tests, Win 7 Tests x64 (1), Win10 Tests x64, Mac10.9 Tests and Linux Tests, with failures like:
      
      [8034:1287:0825/033725:3059591139598:ERROR:pixel_comparator.cc(50)] Number of pixel with an error: 672
      [8034:1287:0825/033725:3059591187709:ERROR:pixel_comparator.cc(51)] Error Bounding Box : 0,304 368x66
      [8034:1287:0825/033725:3059610880597:ERROR:pixel_test_utils.cc(79)] Pixels do not match!
      [8034:1287:0825/033725:3059610905829:ERROR:pixel_test_utils.cc(80)] Actual: data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAZAAAAGQCAYAAACAvzbMAAAF4ElEQVR4nO3ZQY1CQRRFwccEUWhhgQEMYAED7FGDKtJsxsCcTYdMVQt4d3eS/w9rrTUAX+g+97nNbfeMbS5zmec8t93/2XYZgK8mIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAcnzMY/cGgOQ1r90T/rXjda67NwDwhXzCAiAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREACS43nOuzcAEJzmtPX+4b3ea+sCAJLD79t2f60lIAD8mX8gACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJB9NHxfMgTV5VwAAAABJRU5ErkJggg==
      [8034:1287:0825/033725:3059610929427:ERROR:pixel_test_utils.cc(81)] Expected: data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAZAAAAGQCAYAAACAvzbMAAAF4klEQVR4nO3ZQY1CQRRFwfcJotDCYhQgAAsIQABqMEXSo2HOpkOmysC7u5N0H2utNQBf6DGPuc9994xtfuZnXvPadv+07TIAX01AAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIDk/Jzn7g0AyXveuyf8a+fb3HZvAOALecICIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQAJLzda67NwAQXOay9f7xWZ+1dQEAyWlOc8yx7f6x1hIQAP7MHwgAiYAAkAgIAImAAJAICACJgACQCAgAiYAAkAgIAImAAJAICACJgACQCAgAiYAAkAgIAImAAJAICACJgACQCAgAiYAAkAgIAImAAJAICACJgACQCAgAiYAAkAgIAImAAJAICADJLzUdF8xyVTjQAAAAAElFTkSuQmCC
      ../../cc/test/layer_tree_pixel_test.cc:124: Failure
      Value of: MatchesPNGFile(*result_bitmap_, ref_file_path, *pixel_comparator_)
        Actual: false
      Expected: true
      
      Original issue's description:
      > Move scaling of ui resources for scrollbars to the time of upload
      >
      > Instead of trying to figure out what the max texture size is on the
      > main thread, and scale raster to meet that, just raster freely. Then
      > when uploading the UIResource to a texture, we can easily tell what
      > the max texture size is, and if the UIResource is too large, scale it
      > down to fit in a texture.
      >
      > R=enne
      > BUG=606056
      > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
      > NOTRY=true
      >
      > Committed: https://crrev.com/941e52edd1522f7c3935aa4f4d763c43578b4944
      > Cr-Commit-Position: refs/heads/master@{#414202}
      
      TBR=enne@chromium.org,danakj@chromium.org
      # Skipping CQ checks because original CL landed less than 1 days ago.
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      BUG=606056
      
      Review-Url: https://codereview.chromium.org/2278083002
      Cr-Commit-Position: refs/heads/master@{#414391}
      70675787
    • yuryu's avatar
      Move createCrossThreadTask to ExecutionContextTask.h · 84f5959a
      yuryu authored
      Move createCrossThreadTask to ExecutionContextTask.h so that
      both same thread and cross thread versions of createTask are in the
      same header file.
      Currently createCrossThreadTask is in CrossThreadTask.h,
      but the implementation is a few lines of code, so merging it to
      ExecutionContextTask.h and removing CrossThreadTask.h.
      
      BUG=638839
      
      Review-Url: https://codereview.chromium.org/2264543002
      Cr-Commit-Position: refs/heads/master@{#414390}
      84f5959a
    • eranm's avatar
      Certificate Transparency: Make DNS front-end required. · efc343f3
      eranm authored
      From an out-of-band discussion with rsleevi came the conclusion that
      all CT logs, including ones that ceased operation, must be auditable
      (since some of their SCTs are accepted).
      
      This change ensures that if logs are added to the known logs list
      without a DNS front-end address, it will be detected on start-up.
      
      BUG=624894
      
      Review-Url: https://codereview.chromium.org/2269383003
      Cr-Commit-Position: refs/heads/master@{#414389}
      efc343f3
    • johnme's avatar
      Revert of Updates the IME list when the IME has refreshed. (patchset #7... · 70178552
      johnme authored
      Revert of Updates the IME list when the IME has refreshed. (patchset #7 id:120001 of https://codereview.chromium.org/2271483003/ )
      
      Reason for revert:
      ImeMenuTrayTest.RefreshImeWithListViewCreated is failing consistently on https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/15622
      
      Original issue's description:
      > Updates the IME list when the IME has refreshed.
      >
      > When the IME refreshes, we need to update the view of the list in IME menu.
      > Saves the created ImeListView and updates it when get IME refreshing event.
      > Add ImeMenuTrayTest.RefreshImeWithListViewCreated test.
      >
      > BUG=640432
      > TEST=Verified on local build.
      >
      > Committed: https://crrev.com/c6f28a1effd401fd7e2e03707e0dd84f5346185b
      > Cr-Commit-Position: refs/heads/master@{#414329}
      
      TBR=jamescook@chromium.org,azurewei@chromium.org
      # Skipping CQ checks because original CL landed less than 1 days ago.
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      BUG=640432
      
      Review-Url: https://codereview.chromium.org/2281473002
      Cr-Commit-Position: refs/heads/master@{#414388}
      70178552
    • dvadym's avatar
      Improvement of password manager logging. · 528c53ea
      dvadym authored
      It's nice to have more information in password manager logging in order to debug password generation in Chrome. This CL updates FormStructure presentation.
      
      For example Linkedin SignUp form has the following presentation in logs:
      
      Adding manager for form: {
      Signature of form: 5301209056338178556
      Signon realm: https://www.linkedin.com/
      Origin: https://www.linkedin.com/
      Action: https://www.linkedin.com/
      Form name:
      Form fields:
      firstname: 1855613035, text
      lastname: 4163345999, text
      emailaddress: 4103469401, email
      password: 2051817934, password, off
      }
      
      BUG=None
      
      Review-Url: https://codereview.chromium.org/2268313003
      Cr-Commit-Position: refs/heads/master@{#414387}
      528c53ea
    • rune's avatar
      Use LocalStyleChange for insertion point inheritance propagation. · dfe6cf58
      rune authored
      For shadow dom v0, we used a SubtreeStyleChange for propagating
      inherited style changes through insertion points to distributed nodes.
      LocalStyleChange should suffice. We already use LocalStyleChange in the
      HTMLSlotElement case.
      
      We still need to use SubtreeStyleChange where we have a
      SubtreeStyleChange/Force from further up the tree like:
      
      <host>
        <:shadow-root>
          <style>.a::content * { background: green }</style>
          <div id="a">
            <content></content>
          </div>
        </:shadow-root>
        <div>Green when #a gets class a.</div>
      </host>
      
      R=kochi@chromium.org
      BUG=638869
      
      Review-Url: https://codereview.chromium.org/2258793003
      Cr-Commit-Position: refs/heads/master@{#414386}
      dfe6cf58
    • skyostil's avatar
      headless: Fix browser test build failure · beb3a83f
      skyostil authored
      The RunIfWaitingForDebugger command was made stable, breaking this test
      which is specifically trying to check the behavior of an experimental
      command. Switch to another experimental command.
      
      (The API should have remained compatible even if the command was made
      stable. This bug will be fixed separately.)
      
      BUG=640919
      NOTRY=true
      
      Review-Url: https://codereview.chromium.org/2277193002
      Cr-Commit-Position: refs/heads/master@{#414385}
      beb3a83f
    • blundell's avatar
      PlzNavigate: Support renderer-side failed navigations · c286509b
      blundell authored
      In PlzNavigate, RenderFrameHostImpl currently requires that when it
      gets a DidFailProvisionalLoad IPC, it has previously seen a net error.
      This requirement holds for browser-side failed navigations but not for
      renderer-side failed navigations. The latter fact causes some layout
      tests to fail.
      
      The DidFailProvisionalLoad IPC is scheduled for removal once all
      WebContentsObservers have moved to listening for DidFinishNavigation().
      As a step in the process (and to move layout tests towards being green
      in PlzNavigate), this CL eliminates the sending of this IPC for
      browser-side failed navigations. It additionally eliminates the
      assertion in RFHI that it has already seen a network error when
      receiving a DidFailProvisionalLoad IPC (since it will now be seeing
      that IPC only for renderer-side failed navigations).
      
      This CL also updates the browser_tests PlzNavigate filter for the tests
      that are now failing because they rely on listening for the deprecated
      WCO callbacks from browser-side failed navigations.
      CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
      
      Review-Url: https://codereview.chromium.org/2173803003
      Cr-Commit-Position: refs/heads/master@{#414384}
      c286509b
    • tkent's avatar
      Replace two ASSERT()s for HashMap iterators with DCHECK_NE()s. · 9fb35e47
      tkent authored
      These ASSERT()s compare HashMap iterators, and DCHECK*() requires stream printers
      for the iterators. This CL adds them.
      
      BUG=596760
      
      Review-Url: https://codereview.chromium.org/2274403002
      Cr-Commit-Position: refs/heads/master@{#414383}
      9fb35e47
    • harkness's avatar
      Created Mojo BudgetService implementation in chrome/browser · 4108cd01
      harkness authored
      This implementation will be invoked from Blink via Mojo and will return the
      budget information specified in the BudgetAPI.
      
      Current implementation only support the getCost call, although the GetBudget
      call is also defined.
      
      BUG=617971
      
      Review-Url: https://codereview.chromium.org/2265173002
      Cr-Commit-Position: refs/heads/master@{#414382}
      4108cd01
    • yosin's avatar
      Introduce DragController::hasCaretIn() · 9f661dae
      yosin authored
      This patch introduces |DragController::hasCaretIn()| as replacement of
      |DragController::caretLayoutObject()| and |DragController::isContentEditable()|
      to provide high-level API for improving code health.
      
      BUG=n/a
      TEST=n/a; no behavior changes
      
      Review-Url: https://codereview.chromium.org/2272343002
      Cr-Commit-Position: refs/heads/master@{#414381}
      9f661dae
    • bauerb's avatar
      Dispatch touch events to the NewTabPageView if the toolbar is moved away. · de780ec0
      bauerb authored
      As of https://crrev.com/414077, we would not recognize swipe gestures when the NTP is scrolled, but the touch event would still be dispatched by the toolbar (which would then ignore it). Instead, we now forward the touch events to the NewTabPageView if the toolbar is moved away from its original position.
      
      BUG=631976
      
      Review-Url: https://codereview.chromium.org/2276793003
      Cr-Commit-Position: refs/heads/master@{#414380}
      de780ec0
    • fukino's avatar
      Files app: Make the warning banner about local space dismissable. · 21472981
      fukino authored
      This CL includes following changes
      - Add a dismiss button on warning banner about Downloads space. If a user dismiss the banner, we won't show unless 36 hours have passed.
      - Show the warning banner about Downloads when the available size is less than 1GB. (It used to be 20%)
      
      BUG=634207
      TEST=manually tested by modifying DOWNLOADS_SPACE_WARNING_DISMISS_DURATION from 36 hours to 10 seconds.
      
      Review-Url: https://codereview.chromium.org/2271203002
      Cr-Commit-Position: refs/heads/master@{#414379}
      21472981
    • robpercival's avatar
      Adds WoSign log to CT logs list · 64cb9e2a
      robpercival authored
      It has recently completed its 90d compliance monitoring period.
      
      BUG=605415
      
      Review-Url: https://codereview.chromium.org/2202823003
      Cr-Commit-Position: refs/heads/master@{#414378}
      64cb9e2a
    • bauerb's avatar
      Properly reenable focus change animations when aborting a page load on the NTP. · 2fad80e5
      bauerb authored
      BUG=640560
      
      Review-Url: https://codereview.chromium.org/2277833002
      Cr-Commit-Position: refs/heads/master@{#414377}
      2fad80e5
    • Pawel Hajdan, Jr's avatar
      Fix GN bootstrap · 45b76eee
      Pawel Hajdan, Jr authored
      BUG=none
      R=brettw@chromium.org
      
      Review URL: https://codereview.chromium.org/2272653003 .
      
      Cr-Commit-Position: refs/heads/master@{#414376}
      45b76eee
    • ricea's avatar
      Re-write many calls to WrapUnique() with MakeUnique() · 3cdd7ebe
      ricea authored
      A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
      MakeUnique<Foo>(...). See the thread at
      https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
      for background.
      
      To avoid requiring too many manual fixups, the change skips some cases that are
      frequently problematic. In particular, in methods named Foo::Method() it will
      not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
      Foo::Method() may be accessing an internal constructor of Foo.
      
      Cases where MakeUnique<NestedClass>(...) is called within a method of
      OuterClass are common but hard to detect automatically, so have been fixed-up
      manually.
      
      The only types of manual fix ups applied are:
      1) Revert MakeUnique back to WrapUnique
      2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
         correctly)
      3) Add base:: namespace qualifier where missing.
      
      WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
      change behaviour if Foo does not have a user-defined constructor. For example,
      WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
      creates an integer initialised to 0.
      
      git cl format has been been run over the CL. Spot-checking has uncovered no
      cases of mis-formatting.
      
        BUG=637812
      
      Review-Url: https://codereview.chromium.org/2253943004
      Cr-Commit-Position: refs/heads/master@{#414375}
      3cdd7ebe