GitLab

Change-Id: I10e8f8bebfc0099e982610dc3a527f282d126cb8
Reviewed-on: https://chromium-review.googlesource.com/569455Reviewed-by: Vladimir Levin <vmpstr@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486511}

There's already a MEDIA_EXPORT on everything else in media/audio/alsa/;
this one was missed.

BUG=NONE
TEST=NONE

Change-Id: Ia79046f0cee05b1da12074f0c69e073381644499
Reviewed-on: https://chromium-review.googlesource.com/570938Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Stephen Lanham <slan@chromium.org>
Commit-Queue: Jenny Wong <jyw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486510}

When UI Service runs inside the browser process in its own separate thread,
there is a few things it needs to do differently:

 1. It shouldn't set its Screen as a global singleton.
 2. It shouldn't set its ClientNativePixmapFactory as a global singleton.
 3. It can't access the ResourceBundle from its own thread - that can only be
    done from the browser thread.

The third point is the source of most of the complexity in this CL. UI Service
needs to manipulate the cursor, which is done through the ui::ImageCursors
object, which needs to load resources. Since resources can't be loaded on the
UI Service's thread, a mechanism is introduced to let the UI Service do this by
posting tasks to the browser's thread task runner, which is passed into the
UI Service's constructor.

This CL doesn't contain browser-side changes to run the UI Service in-process.

BUG=722527

Review-Url: https://codereview.chromium.org/2979933002
Cr-Commit-Position: refs/heads/master@{#486509}

The FileDescriptorWatcher POSIX wrapper assumes that it is safe to call
StopWatchingFileDescriptor() on a MessageLoopForIO::FDWatcher instance
from within an FDWatcher event callback.

The Fuchsia implementation was incorrectly keeping a record of the
asynchronous IO |handle_| for the freshly-ended wait operation, which
was causing StopWatchingFileDescriptor to try to re-cancel the
already-ended wait.

Bug: 741788
Change-Id: Id1572166fcdb166c6be5700ea7e137b486ebaf5d
Reviewed-on: https://chromium-review.googlesource.com/569278Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486508}

Always place it in the center of the "root window for new windows", which
is the display where the user last interacted with a window.

This fixes a regression where the dialog could be centered over a tabbed
browser window. It also fixes a couple cases where adding a new Wi-Fi
network from the status tray menu on a secondary monitor would open the
dialog on the primary monitor.

Added some basic test coverage to NetworkConfigView.

Bug: 740316
Test: chrome browser_tests. Also manually add a new Wi-Fi network during OOBE, at the login screen, and after login on both primary and secondary displays.
Change-Id: I60f2070dea9f39da586c97ff8b178fc34c5fb325
Reviewed-on: https://chromium-review.googlesource.com/569025
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486507}

Bug: NONE

Change-Id: Id7209e1084e4e493c8773552a753fb6656e83f5c
Reviewed-on: https://chromium-review.googlesource.com/542944
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Reviewed-by: Blaise Bruer <allada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486506}

BUG=724695

Change-Id: Ibb733a5ac20664aa4bac20fe41e13ffe1523ffef
Reviewed-on: https://chromium-review.googlesource.com/570665Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486505}

When an inline has relative position we need to apply that to the
ellipsis as well. 

We also need to be able to detect cases where
relative position moves the inline so that it requires ellipsis in
the first place. This means that we need to look at the layout
overflow rather than the linebox edge when deciding if ellipsis is
required - this is because the dimensions of the root inline box
won't tell us if relative positioning makes it exceed the horizontal
bounds.

When flexbox applies line clamp it depends on the ellipsis logic
to apply an ellipsis even when there's adequate space for the line
box. We now make it force that rather than apply it in all cases,
because where we're looking at a normal ellipsis we want to ensure
we account for relative positioning on the line boxes before deciding
to apply an ellipsis on a line box that would otherwise already fit
on the line.

The final complication to deal with here is cases where relative
positioning changes a line box from having an overflow (e.g. text
overflowing the left hand side of the box in an rtl flow) to not
having an overflow. InlineFlowBox::ComputeOverflow needs to notice
when this is happening, so we change it so that the dimensions of the
root inline box are not used to initialize its layout overflow because shifting the box
subsequently for relative positioning doesn't subtract the overflow
they initially create.

Bug: 737837
Change-Id: I66c848299a93b2b796f2f831d9237f41aa50e962
Reviewed-on: https://chromium-review.googlesource.com/563625Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486504}

This focuses primarily on getting a proof-of-concept working.
The architecture for ProfilingProcess being the mojo service
as separate from the various ReceiverPipeServers does not make
sense. Those should be collapsed in a following CL.

Change-Id: Ic851df75550831a50bda6c54da481ae0b32361bb
Bug: 
Reviewed-on: https://chromium-review.googlesource.com/568700Reviewed-by: Brett Wilson <brettw@chromium.org>
Commit-Queue: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486503}

This CL goes over the base/ and chrome/ directory.

Bug: 579196
Change-Id: Icc97c5709072e833a62c1e0f75a28f2917d1dd19
Reviewed-on: https://chromium-review.googlesource.com/565962
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486502}

Both with 8 shards and 16min timeout.

Example release shard:
https://chromium-swarm.appspot.com/task?id=375199b32dd47210

Example debug shard:
https://chromium-swarm.appspot.com/task?id=37519aa55a5dae10

Will move some *-b4 bots over to the 1-device pool if necessary.

Bug: 670879
Change-Id: I3b49ba2c34f37bc3ad2d283294d41e5dce4949d7
Reviewed-on: https://chromium-review.googlesource.com/569004Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Yoland Yan <yolandyan@chromium.org>
Commit-Queue: Benjamin Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486501}

R: jsbell@chromium.org
Bug: 742503
Change-Id: I57bb42b891840c4100956f264e1dd19c4b2b1e8e
Reviewed-on: https://chromium-review.googlesource.com/570951
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486500}

This will be superseded by base::ScopedPlatformFile, which is strictly
target at files. base::ScopedPlatformHandle was originally going to
support other types of scoped platform handles (such as Mach ports), but
that was dropped due to the additional complexity it would incur.

Change-Id: I3ec8324ce842aca3f64670b630255717ec6bbda0
Reviewed-on: https://chromium-review.googlesource.com/570599Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486499}

The data_deps require android, which cause a failure when running gn args for
vr_common_unittests on linux.

Bug: 
Change-Id: I7b44d0e62ada06b64ce50341ea46378c612b142e
Reviewed-on: https://chromium-review.googlesource.com/568462Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Yash Malik <ymalik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486498}

Ash may recycle a WindowTreeHost for a different display. This means
overriding OnDisplayAdded() and looking up a root window may result in
getting a root already seen. Fix this by converting to
ShellObserver::OnRootWindowAdded() which doesn't suffer from this
problem.

BUG=740589
TEST=none (this code is only used in non-production code)

Change-Id: Ic4accf920cedfe0f6c9c3b2ce2ed27c7bf2a9f37
Reviewed-on: https://chromium-review.googlesource.com/570777Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486497}

Adding a first launch view to be shown when the user is not signed in.
The view will also kick in if the user signs out.

Bug: 741842
Change-Id: Ib80df93df428f9923834573b19f10cc4f973f42e
Reviewed-on: https://chromium-review.googlesource.com/568858
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Scott Nichols <nicholss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486496}

icons in a different size.

Bug: 733301
Change-Id: Idf325b1849ef8cad471044c26b449fa9cbfbb5e0
Reviewed-on: https://chromium-review.googlesource.com/567206Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486495}

For sucessfully downloaded items, add extras for origin and
referrer when launching activities.
This allows the security team to analyze malware data.

see b/63351122

TBR=mdjones@chromium.org

Bug: 
Change-Id: I9fb7d1df6fdce8bf6803723555270c7f36ac0637
Reviewed-on: https://chromium-review.googlesource.com/565653
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486494}

This CL moves FrameSinkManager, FrameSinkManagerClient and FrameSinkManager's
unittests to components/viz/service/frame_sinks.

The rest of this CL updates includes, forward declarations, and namespaces.

Note that there is confusion between cc::mojom::FrameSinkManager and
viz::FrameSinkManager at the momenet and so viz:: needs to be used in
FrameSinkManagerImpl to disambiguate.

TBR=reveman@chromium.org

Bug: 722935
Change-Id: I4497699fe7e3654d1562781263f836d983af2d2b
Reviewed-on: https://chromium-review.googlesource.com/570000
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Bo Liu <boliu@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486493}

https://chromium.googlesource.com/angle/angle.git/+log/3ec7568..c5af8ba

BUG=

TBR=cwallez@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Change-Id: Ie7d3864d6d00c4e6af2e3e61b54c05f40dddbe43
Reviewed-on: https://chromium-review.googlesource.com/570946Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486492}

Remove the ImagePaintContext class now that ImageQualityController is no
more and move the remaining mask and blending logic into PaintFillLayer.

Break out tiled image painting and text box painting from PaintFillLayer
in to PaintFillLayerBackground & PaintFillLayerTextFillBox respectively.

Share border rect logic between PaintFillLayer and PaintFastBottomLayer.

Change-Id: Ie77fa832964941e2fee4732824db54042c9b47af
Reviewed-on: https://chromium-review.googlesource.com/565024Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486491}

These are known offenders of the UMA.NegativeSamples.Histogram
metric.

https://bugs.chromium.org/p/chromium/issues/detail?id=739925

Bug: 682680,739925
Change-Id: Ie3e394baf5e1dfb2cf8f1028c5273c0a3d19ab4a
Reviewed-on: https://chromium-review.googlesource.com/570262Reviewed-by: Alexei Svitkine (slow) <asvitkine@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486490}

Bug: 
Change-Id: I376d927b3389c436611f924e1c324a7c38eecc5b
Reviewed-on: https://chromium-review.googlesource.com/570125Reviewed-by: Cathy Li <chili@chromium.org>
Reviewed-by: Peter Williamson <petewil@chromium.org>
Commit-Queue: Collin Baker <collinbaker@google.com>
Cr-Commit-Position: refs/heads/master@{#486489}

This is needed because PPAPI uses Platform without Core, so font names
aren't initialized properly there.

Bug: 742311
Change-Id: Ia0c89ffa9391759b54a73ec0d020ff437343e7a3
Reviewed-on: https://chromium-review.googlesource.com/570661Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486488}

This reverts commit 7e3d0c03.

Reason for revert:
The race was on second dump and shutdown.
1. The main thread starts a dump. Posts task on WP2 first for MPD1.
2. WP2-thread posts task to itself for MDP2.
3. WP2-thread posts task to WP1 for MDP1. At this point, WP2-thread
is waiting on WP1 to create a new thread.
4. The test finishes with WP1-thread finalizing the dump, main
thread returns.
5. The MDM destructor decides to delete it's reference to the task
runner (MDPInfo). This clears the WP1 first.

Step 5 calls WP1 destructor which calls thread destructor.
The thread in Step 3 comes back to life and tries to check if the
new thread has been created in WP1.
MDM should not destroy the task runner when PostTask is not done.
So, hold a reference in SetupNextMemoryDump().


Original change's description:
> Revert "memory-infra: Move TracingObserver to service/"
> 
> This reverts commit 15617f0b.
> 
> Reason for revert:
> https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20TSan%20Tests/builds/8765
> 
> base_unittest MemoryDumpManagerTest.PostTaskForSequencedTaskRunner is crashing due to the data race.
> 
> Original change's description:
> > memory-infra: Move TracingObserver to service/
> > 
> > The memory tracing observer along with peak detector and periodic
> > scheduler should live in service/resource_coordinator since the peak
> > detector needs to know about the OS dump providers.
> > The tests were moved in previous CL.
> > 
> > BUG=728199
> > 
> > Change-Id: Ib4934421d1d057fd7d062258179f17d3ca8209f7
> > Reviewed-on: https://chromium-review.googlesource.com/554280
> > Commit-Queue: Primiano Tucci <primiano@chromium.org>
> > Reviewed-by: Helen Li <xunjieli@chromium.org>
> > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > Reviewed-by: Primiano Tucci <primiano@chromium.org>
> > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#485968}
> 
> TBR=dcheng@chromium.org,primiano@chromium.org,dpranke@chromium.org,hjd@chromium.org,xunjieli@chromium.org,ssid@chromium.org
> 
> Change-Id: Iea202e6099216cb8ccad38d6f0d5354ea82643fe
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 728199
> Reviewed-on: https://chromium-review.googlesource.com/568401
> Reviewed-by: Hongchan Choi <hongchan@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Commit-Queue: Hongchan Choi <hongchan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#486014}

TBR=dcheng@chromium.org,primiano@chromium.org,dpranke@chromium.org,hjd@chromium.org,xunjieli@chromium.org,ssid@chromium.org,hongchan@chromium.org

Change-Id: Ic58718b4d4497f9cb28cb2962deb653b45f2f6da
Bug: 728199
Reviewed-on: https://chromium-review.googlesource.com/568402
Commit-Queue: Siddhartha S <ssid@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: Siddhartha S <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486487}

Bug: 
Change-Id: Idca8b4471422732fdb854ecc29605d27a09b8c46
Reviewed-on: https://chromium-review.googlesource.com/570422Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486486}

BUG=689520

Change-Id: I430bc144a3b566894741b033258e672937053d32
Reviewed-on: https://chromium-review.googlesource.com/562756Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486485}

Bug: 740986
Change-Id: I0b478cb89853994d444e9a17796aa06c6a36a430
Reviewed-on: https://chromium-review.googlesource.com/570676Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486484}

BUG=738628

Review-Url: https://codereview.chromium.org/2963393002
Cr-Commit-Position: refs/heads/master@{#486483}

This CL adds xcode_test_application_name to create_bundle target so 
that the relationship between xcode unit or ui test target and test 
application target can be specified in BUILD files instead of being 
identified by parsing target names in GN.

Bug: 741147, 709289
Change-Id: Idf0cb700b300d80d49803dae33eb90c87c0e41a0
Reviewed-on: https://chromium-review.googlesource.com/566587
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486482}

There are five different classes in
third_party/WebKit/Source/platform/exported named ExtraDataContainer.
They are only used as local internal classes so they don't normally
collide in the compiler, but they do so in jumbo builds.

This patch renames them so that the names are more unique.

Bug: 742337
Change-Id: Iad42e0d29f600fabd6ea9081687a7107d3043282
Reviewed-on: https://chromium-review.googlesource.com/570052Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: bratell at Opera <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#486481}

Changes:
1. Change SearchBoxView and SearchResultPageView's corner radius and
layout in state AppListModel::STATE_SEARCH_RESULTS.
2. Remove separators between SearchResultView.
3. Add separators in SearchResultPageView to separate
SearchResultContainerView.

specs: https://screenshot.googleplex.com/409fBM7pTO2
screenshot: https://screenshot.googleplex.com/zYZqsT9ndum
    
BUG=740732

Change-Id: Iffeb6d726970dacfe0745acd7d809d482e801b19
Reviewed-on: https://chromium-review.googlesource.com/566024
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486480}

Commit 5fb31977 added this new target but
didn't depend on the //sandbox:sandbox_features target so it failed to
compile:

In file included from ../../sandbox/linux/seccomp-bpf-helpers/seccomp_starter_android.cc:5:                                                                       
../../sandbox/linux/seccomp-bpf-helpers/seccomp_starter_android.h:10:10: fatal error: 'sandbox/sandbox_features.h' file not found                                 
#include "sandbox/sandbox_features.h"                                                                                                                             

NOTRY=true

Bug: 742028
Bug: 730066
Bug: 739879
Change-Id: Ib0bc9f34f0cbf35be0f9f3cf412cd0fdcf678f3f
Reviewed-on: https://chromium-review.googlesource.com/570514
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Glenn Hartmann <hartmanng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486479}

Bug: 579255
Change-Id: I30c8e76c6fa35c77bfe731d6bd7e89bb7d8f8c08
Reviewed-on: https://chromium-review.googlesource.com/570513Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486478}

Change-Id: Ice02da6a6906b27bee7ece5e8567c559dbbe0673
Reviewed-on: https://chromium-review.googlesource.com/568911Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486477}

"getInitialSettings" should always be the first message from
the print preview Javascript, so only call AllowJavascript()
in PrintPreviewHandler::HandleGetInitialSettings().

Bug: None
Change-Id: I764e72c10a39c82cf85f75b38867def5fae41c99
Reviewed-on: https://chromium-review.googlesource.com/569301
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486476}

Bug: 742355
Change-Id: I6b94d7358bd77d6d5d80d2eb608653aecd759cff
Reviewed-on: https://chromium-review.googlesource.com/570628
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486475}

Bug: 721802
Change-Id: I12cc789f4052be4b02e175ad6cb9c0c763c3de6b
Reviewed-on: https://chromium-review.googlesource.com/567043
Commit-Queue: Anna Maria <paezagon@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486474}

When crrev.com/2850863002 added a call to InitChromeLogging() it had to
pull in //chrome/common:common, and that necessarily pulls in several MB
of code that is not wanted. The tendrils of dependencies are many and
varied and since a sword was disallowed there was no practical way to
cut this Gordian knot. See the investigation in bug 717103 for details.

So, InitChromeLogging() was copied, named as InitChromeWatcherLogging(),
and made to work. This gets the size-cost of the logging code down to
~25 KB.

A non_code_constants target was added to //chrome/common because the
existing constants target was actually the main cause of excess code
being pulled in.

While testing this change it was discovered that the command-line
logging flags were not passed to the chrome_watcher process, so that
logging was not actually being enabled. This was also fixed.

It may be possible to delete more of the copied code, depending on what
logging features are actually needed. Thoughts?

Bug: 717103, 715060
Change-Id: I536b0813fff32e513dfd3e0bbb8fc3cb715546c1
Reviewed-on: https://chromium-review.googlesource.com/567030Reviewed-by: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486473}

Previously media/mojo/sevices:lib was done as a source_set due to issue
670094. Now that that issue is fixed, the intermediate "lib" target is
no longer needed.

Removing the suppression of duplicate symbols revealed that some of the
CdmPromiseTemplate methods end up in multiple modules when doing a
component build. So fix CdmPromiseTemplate<>::GetResolveParameterType()
implementation to avoid this.

This also enables //media/mojo/services/media_service_unittests on
Windows (which was disabled due to linking issues that are now fixed).

BUG=676418,676055,656706
TEST=media_mojo tests compile and run

Review-Url: https://codereview.chromium.org/2737513004
Cr-Commit-Position: refs/heads/master@{#486472}