- 05 Oct, 2018 40 commits
-
-
Ulan Degenbaev authored
Bug: 878390 Change-Id: Ibdc7919fb7658858b16227976e7e74c9eb74a007 Reviewed-on: https://chromium-review.googlesource.com/c/1261448Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#597092}
-
Martin Šrámek authored
...due to a high amount of flakes. TBR=noel@chromium.org Bug: 891119 Change-Id: I2b13e7542bbd4cb4e827ab049f761c0f6eb73fc1 Reviewed-on: https://chromium-review.googlesource.com/c/1264539Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#597091}
-
Koji Ishii authored
Following bot results are included. 10292 10296 10303 10312 10317 10322 10325 10332 10339 10349 10352 0 lines were removed and 0 lines were deflaked by consecutive results since 10290. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I8518b892ef22e220e79efa2ac93ef6e0d5597535 Reviewed-on: https://chromium-review.googlesource.com/c/1260606 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#597090}
-
Armando Miraglia authored
Since the parameters are now checked when passed through Mojo, this test is now outdated as the parameters are never invalid. This is verifyed by a DCHECK intorduced in crrev.com/c/1181134. BUG=891202 TESTS=None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ibbda19ce4d6d99363e02136883709082383582c2 Reviewed-on: https://chromium-review.googlesource.com/c/1264676Reviewed-by:
Max Morin <maxmorin@chromium.org> Reviewed-by:
Henrik Grunell <grunell@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#597089}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/78cdde3df652..4bb1e4a1d50f git log 78cdde3df652..4bb1e4a1d50f --date=short --no-merges --format='%ad %ae %s' 2018-10-05 aleloi@webrtc.org Lower gain parameters for AGC2. 2018-10-05 sprang@webrtc.org Hide libvpx vp8 encoder behind an interface and add mock for testing. Created with: gclient setdep -r src/third_party/webrtc@4bb1e4a1d50f The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:892043 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I1c344b233a72919ef2cfa09d34ea7f3adb194e41 Reviewed-on: https://chromium-review.googlesource.com/c/1264619Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597088}
-
Harald Alvestrand authored
This reverts commit 3f90035e. Reason for revert: The original problem was solved using another approach, and this CL (which modifies the content layer) just adds complexity with no purpose. Original change's description: > Implement DTMF [[ToneBuffer]] in the blink layer > > This CL makes the Blink layer keep a copy of the tone buffer > and update it on insertDTMF and ontonechange events only; this > makes it possible to expose the state of the tone buffer at the > time the event is fired to the Javascript callback. > > It removes a queueing step inside the DTMF sender, because > that queueing step destroyed the consistency. > > Bug: chromium:816475 > Change-Id: I5aa68396299a67d6cea1e8a17d364f553514c291 > Reviewed-on: https://chromium-review.googlesource.com/1213084 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Harald Alvestrand <hta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589910} Bug: chromium:816475 Change-Id: Iaee9fefa8a37e3c6c7256dacac0855f426601e0d Reviewed-on: https://chromium-review.googlesource.com/c/1264165Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#597087}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/25a2b998..060ca87d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I80f8e5e2cbd4331da184465825f7eb3ba7809a9d Reviewed-on: https://chromium-review.googlesource.com/c/1263892Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597086}
-
Mikel Astiz authored
A new feature toggle is introduced to influence how TabNodePool::CleanupTabNodes() issues deletions of tab nodes (i.e. sync entities for SESSIONS). The new mode is very aggressive and is conceptually similar to removing the notion of 'free' nodes, although this is not obvious in the code because it depends on how TabNodePool is used by upper layers (i.e. FreeTab() is followed closely by CleanupTabNodes() for the local session, in SyncedSessionTracker::CleanupLocalTabs()). The risk that this mode (disabled by default) entails is that closed tabs may never have the chance to sync, so if the user closed the tab accidentally, or expected to see the tab in other devices, it would be a regression. This doesn't seem very realistic, so let's experiment via Finch and assess the impact of the change. Bug: 882489 Change-Id: I76609434e5a733b8b5e4c94820ef2f29dd862ce5 Reviewed-on: https://chromium-review.googlesource.com/c/1264597 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#597085}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7a4d068d23a6..4c11f3dcc855 git log 7a4d068d23a6..4c11f3dcc855 --date=short --no-merges --format='%ad %ae %s' 2018-10-05 treehugger-gerrit@google.com Merge "Hopefully actually fix Windows build." 2018-10-05 treehugger-gerrit@google.com Merge "base: extract Event class for eventfd/pipe" 2018-10-05 hjd@google.com Merge "trace_processor: Add execution time to raw_query.proto" 2018-10-04 primiano@google.com Roll libunwindstack/libcore for standalone builds 2018-10-05 primiano@google.com Speculative (2) Windows fix 2018-10-04 cferris@google.com Merge "Add new parameter for creation of MapInfo object." 2018-10-04 primiano@google.com Merge "Speculatively fix windows build and unblock autoroller" 2018-10-04 primiano@google.com Merge "perfetto-ui: Add copy to tsv for queries" 2018-10-04 primiano@google.com Merge "Chrome: Change string table indices to unsigned" 2018-10-04 primiano@google.com Fix mac build 2018-10-04 primiano@google.com Merge "perfetto-ui: Improve thread data loading performance" 2018-10-04 fmayer@google.com Merge "Fix windows build." 2018-10-04 treehugger-gerrit@google.com Merge "Update README.chromium to point to correct license file" 2018-10-04 hjd@google.com Merge "perfetto-ui: Factor common code from loadTraceFromX" 2018-10-04 dproy@google.com Merge "[perfetto-ui] Update canvas size when container parent size changes" 2018-10-04 hjd@google.com Merge "perfetto-ui: Refactor to remove old Actions" 2018-10-04 fmayer@google.com Merge "Correctly handle partial writes." Created with: gclient setdep -r src/third_party/perfetto@4c11f3dcc855 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ie9129dc2f538996c7fb27acc29d72633c76aee8c Reviewed-on: https://chromium-review.googlesource.com/c/1264617Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/74a9acd4a7c1..d61a9f0f0d98 Created with: gclient setdep -r src-internal@d61a9f0f0d98 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I287cf1076b7d5aa86591d9938239a1a716e0f941 Reviewed-on: https://chromium-review.googlesource.com/c/1264620Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597083}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/92d10833de63..a6262495da48 git log 92d10833de63..a6262495da48 --date=short --no-merges --format='%ad %ae %s' 2018-10-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 14246813a110..0ca09753392d (1 commits) Created with: gclient setdep -r src/third_party/skia@a6262495da48 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=mtklein@chromium.org Change-Id: I3d7c6cded307e698887ff2d63985f475f508f64c Reviewed-on: https://chromium-review.googlesource.com/c/1264616Reviewed-by:
-
Rune Lillesveen authored
ApplyRuleSetChanges was hard to understand because it contained various branching for user style updates which wasn't clear were for user style. Move the user style specific font and keyframes handling to a separate ApplyUserRuleSetChanges and create a common InvalidateForRuleSetChanges to do the common code for marking nodes for style invalidation/recalc. Change-Id: I7b4907e526e5768f1957e5be3ad1b41f9a5d35f0 Reviewed-on: https://chromium-review.googlesource.com/c/1258543Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#597081}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0ca09753392d..2343836c4210 git log 0ca09753392d..2343836c4210 --date=short --no-merges --format='%ad %ae %s' 2018-10-05 jmadill@chromium.org Remove gl::ErrorOrResult. 2018-10-05 jmadill@chromium.org Remove gl::LinkResult. Created with: gclient setdep -r src/third_party/angle@2343836c4210 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I306e90894630a4365e3910d50fd07017804b4662 Reviewed-on: https://chromium-review.googlesource.com/c/1264618Reviewed-by:
-
Thomas Tangl authored
When a custom passphrase is recognized for a user that is eligible for the consent bump otherwise, the consent bump will be suppressed. Note: Checking whether a user has a custom passphrase takes some time, because this information is only available when the sync engine is initialized. Bug: 888756 Change-Id: Ie661769cb65cfd2b432ed433ad416e944a979fce Reviewed-on: https://chromium-review.googlesource.com/c/1261441 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#597079}
-
jdoerrie authored
This change applies clang-tidy's modernize-use-auto [1] in /components. This change does not rewrite new and cast expressions. Reproduction steps: - run clang-tidy's modernize-use-auto - run git cl format - manually remove unused typedefs due to -Wunused-local-typedef error [1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html This CL was uploaded by git cl split. R=jochen@chromium.org Bug: 890902 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ibbb775036736e0b07c6ce5393569ed40878b5c62 Reviewed-on: https://chromium-review.googlesource.com/c/1257852Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#597078}
-
Ulan Degenbaev authored
Bug: 878390 Change-Id: I6ba0ce622392c38fe1f7fc23fcfde7829bbe0480 Reviewed-on: https://chromium-review.googlesource.com/c/1261556Reviewed-by:
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/push_messaging. This CL was uploaded by git cl split. R=mvanouwerkerk@chromium.org Bug: 809610 Change-Id: Ib8ccd8e3763c2c8172b9d7dcb7dac3cbc5e8e809 Reviewed-on: https://chromium-review.googlesource.com/c/1261699Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#597076}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/530c5963e910..74a9acd4a7c1 Created with: gclient setdep -r src-internal@74a9acd4a7c1 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ib629adf6e50a488136ae6ba1e53efed13fffbee4 Reviewed-on: https://chromium-review.googlesource.com/c/1263874Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1b2f9583. With Chromium commits locally applied on WPT: 65d72632 "Make DTMF tone change more deterministic" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25868 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=markdittmer No-Export: true Change-Id: If543bcc74b17c59182501eb945d642aacb71cd8e Reviewed-on: https://chromium-review.googlesource.com/c/1263891 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#597074}
-
Alexander Timin authored
Replacing MessageLoop with ScopedTaskEnvironment will allow us to get more accurate information about its lifetime and get rid of lazy bindings. R=jochen@chromium.org CC=gab@chromium.org,alexclarke@chromium.org BUG=892139,891670 Change-Id: I9ffc7fec4c34a87c205c4d65d6e0fb8c5e21b05e Reviewed-on: https://chromium-review.googlesource.com/c/1261816Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#597073}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0a74e09b39c1..78cdde3df652 git log 0a74e09b39c1..78cdde3df652 --date=short --no-merges --format='%ad %ae %s' 2018-10-05 kron@webrtc.org Add support for sending RTP two-byte header extensions. 2018-10-05 mbonadei@webrtc.org Don't include <memory.h> in aligned_malloc.cc. Created with: gclient setdep -r src/third_party/webrtc@78cdde3df652 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I432e0de72785e0570e96b15624b6c46f2d31f220 Reviewed-on: https://chromium-review.googlesource.com/c/1263873Reviewed-by:
-
Fredrik Söderquist authored
Rather than resolving the URL again during Task::Create, pass the KURL resolved by ImageLoader::UpdateFromElement through. Also move the resolution before the |loading_image_document_| special- case. Bug: 889183 Change-Id: I52ea65d1af96a5919e128f0623fa6bd9026850f7 Reviewed-on: https://chromium-review.googlesource.com/c/1254266Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#597071}
-
vitaliii authored
1) Add the following comment // If you change or add any fields in this file, update proto_visitors.h // and potentially proto_enum_conversions.{h, cc}. to all *_specifics.proto, which are actually mentioned in proto_visitors.h. Previously some of them were missing the comment at all and others were telling about proto_value_conversions, which actually does not need to be updated. 2) Add // If you change or add any enums in this file, update // proto_enum_conversions.{h, cc}. to sync_enums.proto, since it containts enums only. Change-Id: Ic68f5694a4a227bc20aeb84f21593b41581ae0af Reviewed-on: https://chromium-review.googlesource.com/c/1055627 Commit-Queue: vitaliii <vitaliii@chromium.org> Reviewed-by: -
Eric Seckler authored
.. to make them conform to the styleguide. Also includes some minor comment edits. TBR=mbarbella@chromium.org Change-Id: I8dc5616979e9a97c8837a98ed6565cbf4b266c82 Reviewed-on: https://chromium-review.googlesource.com/c/1264204Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#597069}
-
Sergio Villar Senin authored
Early implementations of IdentityManager used to cache its internal state and update it (notifying its observers) via custom callbacks. That's no longer the case as IdentityManager acts now as a passthrough to the backing classes. There is no guarantee that the IdentityManager is going to receive the "events" before any other observer. The tests are still valid though, as they can be used to verify that we get consistent values from IdentityManager from within SigninManagerBase::Observer and OAuth2TokenService::Observer while we transition all of these observers (and the flows that start from them) incrementally to IdentityManager. Bug: 892077 Change-Id: I4bfea3f5114c5ad21444af43e6bfd119ffce65ba Reviewed-on: https://chromium-review.googlesource.com/c/1264199 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#597068}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/be4324e9..25a2b998 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I91e06d633087ba00fb3a9f805f78894d935f0825 Reviewed-on: https://chromium-review.googlesource.com/c/1263889Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/30f82e022cc4..530c5963e910 Created with: gclient setdep -r src-internal@530c5963e910 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I04cc33a13cbfd8393b604cdeb761f7a246d76252 Reviewed-on: https://chromium-review.googlesource.com/c/1263870Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/14246813a110..0ca09753392d git log 14246813a110..0ca09753392d --date=short --no-merges --format='%ad %ae %s' 2018-10-05 oetuaho@nvidia.com Add GLES3 support for EXT_blend_func_extended Created with: gclient setdep -r src/third_party/angle@0ca09753392d The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Ib42c47a895b8882d9035cef2b8669dc5367fd6c8 Reviewed-on: https://chromium-review.googlesource.com/c/1263872Reviewed-by:
-
Colin Blundell authored
"Signing out" always happens via SigninManager and causes the account to be removed from SigninManager as well as AccountTrackerService. However, the primary account can be removed from AccountTrackerService in circumstances *other than* the user signing out of the primary account; e.g., if the refresh token for the account is revoked from ProfileOAuth2TokenService. In these circumstances, there would still be a primary account (i.e., SigninManagerBase::GetAuthenticatedAccountId() returns a valid account ID), but there would be no AccountInfo for the account (i.e., SigninManagerBase::GetAuthenticatedAccountInfo() returns an empty AccountInfo). IdentityManager::HasPrimaryAccount() currently internally uses SigninManagerBase::GetAuthenticatedAccountInfo(). This will result in it giving an incorrect result in these edge cases. This CL changes it to use SigninManagerBase::IsAuthenticated() and adds a test that fails before the change. Bug: 892553 Change-Id: I227ad6767089b259c0d54e33f5f88f6789f2de9a Reviewed-on: https://chromium-review.googlesource.com/c/1264203Reviewed-by:
-
Matt Falkenhagen authored
This treats the network service crashing like the worker's process crashing, and prevents clients getting stuck with a broken worker. Originally landed at: https://chromium-review.googlesource.com/c/1260903 It was reverted because the test flaked because the host was sometimes not yet created. The diff in the reland is to wait for the host to be created. Bug: 848256 Change-Id: Ic656f0bf5a320526cf6f7715399f8f71db05619b Reviewed-on: https://chromium-review.googlesource.com/c/1264139Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#597063}
-
jdoerrie authored
This change applies clang-tidy's modernize-use-auto [1] in /chrome/browser/extensions/api. This change does not rewrite new and cast expressions. Reproduction steps: - run clang-tidy's modernize-use-auto - run git cl format - manually remove unused typedefs due to -Wunused-local-typedef error [1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html This CL was uploaded by git cl split. R=tbarzic@chromium.org Bug: 890902 Change-Id: Ie70b063af990199a2c23956114a026264d8a7e67 Reviewed-on: https://chromium-review.googlesource.com/c/1257905 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#597062}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/15082f69653d..39be1c969580 git log 15082f69653d..39be1c969580 --date=short --no-merges --format='%ad %ae %s' 2018-10-05 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@39be1c969580 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I539f6d9f35c76faf2e9b0519c0f3fcc817fa8c34 Reviewed-on: https://chromium-review.googlesource.com/c/1263871Reviewed-by:
-
Martin Šrámek authored
...due to flakiness. Bug: 892484 Change-Id: Ic947c7c7f9a7868249ec200e760ef3cdcf52ca1b TBR: hnakashima@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1264381Reviewed-by:
-
henrika authored
Bug: NONE Change-Id: I596b793a81a4e4d29e05d7459b273028a96c4a99 Reviewed-on: https://chromium-review.googlesource.com/c/1264380Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#597059}
-
Sylvain Defresne authored
TestingFactory is a base::Callback<> while TestingFactoryFunction is a function pointer. Convert ProfileInvalidationProviderFactory to the callback based type. Bug: 809610 Change-Id: Id6ddc4e75960f5fd1ed952877d4bebdca515b706 Reviewed-on: https://chromium-review.googlesource.com/c/1246166Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#597058}
-
Matt Falkenhagen authored
This CL allows media to play and be seekable when service worker provides the response from cache storage. Live demo from Jake Archibald: https://static-misc.glitch.me/sw-audio-bug/ This CL fixes two things: - Supports blob responses from service worker for partial requests with a range of [x, -1] where x is not 0 (the zero case was already supported). This requires changes to ServiceWorkerLoaderHelpers::ReadBlobResponseBody and mojom.Blob.ReadRange(). - Sets ResourceResponseInfo.content_length based on the HTTP header Content-Length for service worker loaders. This allows Chromium's media code to allow seeking over the media source. Bug: 892227 Change-Id: I9e6f6faaae7b83ad3aee9c0f217834d62c214b85 Reviewed-on: https://chromium-review.googlesource.com/c/1263739Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/787bb77798ed..92d10833de63 git log 787bb77798ed..92d10833de63 --date=short --no-merges --format='%ad %ae %s' 2018-10-05 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files Created with: gclient setdep -r src/third_party/skia@92d10833de63 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=mtklein@chromium.org Change-Id: Ie852c315e773c8c2ab5c47e35805b0cbc630592e Reviewed-on: https://chromium-review.googlesource.com/c/1263867Reviewed-by:
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/ui/webui. This CL was uploaded by git cl split. R=calamity@chromium.org Bug: 809610 Change-Id: I7c730e9e509e911411e693892b817ce8992517c6 Reviewed-on: https://chromium-review.googlesource.com/c/1259025Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#597055}
-
Yuki Yamada authored
This CL implements these classes in Blink: JSBasedEventListener (The base class for | EventLisntener/EventHandler) +- JSEventListener (Implements EventListener) +- JSEventHandler (Implements EventHandler and | other special types) +- JSEventHandlerForContentAttribute (Supports lazy compilation for content attribute) EventHandlers start to support incumbent realm using blink::V8EventHandlerNonNull that inherits blink::CallbackFunctionBase. (EventListener already supports incumbent realm.) These four classes are no longer referenced from anywhere: blink::V8AbstractEventListener blink::V8EventListenerOrEventHandler blink::V8ErrorHandler blink::V8LazyEventListener Although these are no longer necessary, this CL does not remove them so that we can easily switch which classes to use in case new classes contains some problems. regarding crbug.com/759461 : OnErrorEventHandler for content attribute, which has different number of arguments, gets supported by blink::JSEventHandler and blink::JSEventHandlerForContentAttribute. regarding crbug.com/664676 : |js_event| in the relevant realm of |event|'s target is created in blink::JSBasedEventListener::handleEvent(). Bug: 872138, 849236, 759461, 664676, 606900 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I356734fc16611277ad9f3f279a676e7dc8083408 Reviewed-on: https://chromium-review.googlesource.com/c/1215512 Commit-Queue: Yuki Yamada <yukiy@google.com> Reviewed-by:Hayato Ito <hayato@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#597054}
-
Mythri Alle authored
V8 API will deprecate the non maybe versions of v8::Object::Has and v8::Object::Delete. Updated pepper implementation to use maybe versions. Bug: v8:7284 Change-Id: Ie582b1ef97f3943ba06e8f3f76d2225f9fffe616 Reviewed-on: https://chromium-review.googlesource.com/c/1254145 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#597053}
-
