GitLab

This change introduces a notification that will be displayed when a
user plugs in a USB printer that requires manual configuration. Clicking
the notification will open CrOS settings so the user can manually
configure the printer.
- Subsequent CL will call ShowConfigurationNotification() to show the
notification.

Bug: 951139
Change-Id: Ibff4d415de9c3ccf8eda45f470cfa30513468bb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606193Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Auto-Submit: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661038}

This patch adds links to the "Debugging blink objects" doc to the
renderer/core/paint/README.md file.

Change-Id: I1397bbb171892aa0f3438927cfb1e1666dabfb8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615370
Auto-Submit: Philip Rogers <pdr@chromium.org>
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661037}

Moves named_message_port_connector.js to a common location so it can
be used by more platforms than just Fuchsia.

Bug: 953958
Change-Id: Iabcab36f6f1fc421f0afb77ca88eb499d3a29bff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610602Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Sean Topping <seantopping@chromium.org>
Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661036}

There was a missing }

Change-Id: I609a0e16968091f5fc5d487ad23059204299bd8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617204Reviewed-by: Erik Luo <luoe@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661035}

DownloadServiceFactory and PrefetchServiceFactory are currently
BrowserContextKeyedServiceFactories (BCKSFs). This CL makes them
SimpleKeyedServiceFactories (SKSFs), so they can be used in Service
Manager Only mode.

Both need to be changed at the same time because they have circular
dependencies on each other through OfflinePrefetchDownloadClient.

Helper GetForBrowserContext() methods have been left in both factories
to control the breadth of this CL. I'll send a follow-up to change all
callers to GetForKey().

Bug: 943724, 953918
Change-Id: I6ae3404bc301f6bcb3c5665dbc59457e53d8a07e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600839
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661034}

We currently start the VK in an UNKNOWN state. When we enable the VK,
we first transition to INITIAL and then immediately transition to
LOADING_EXTENSION. When we disable the keyboard, we reset to the INITIAL
state.

This is kind of weird. We might as well start at INITIAL state and
transition to LOADING_EXTENSION when we enable the keyboard.

The only impact would be on the UNKNOWN -> INITIAL transition for
metrics, but the number of UNKNOWN -> INITIAL transitions should be
the same as INITIAL -> LOADING_EXTENSION anyway.

Bug: 845780
Change-Id: I39c6190a73daf9d9b4349916bfc0d1c825812ab1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616824Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661033}

Registers an NSPrincipalClass in the test bundle's Info.plist, which
provides the name of a class that is automatically instantiated when the
test bundle is loaded into the test runner process.  We can use this
class, along with the XCTestObservation protocol, to run startup code
before any tests are run.

In this CL, we copy pak files into the test runner's bundle and
initialize the ResourceBundle at startup, which allows EG2 tests to use
string resources as needed.

BUG=922813

Change-Id: I348ed41be3939aea2a7525205969a538bbaaefa2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618024
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661032}

This reverts commit 0cf7d62e.

Reason for revert: likely cause of WebKit MSAN failures: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Trusty%20MSAN/14589

Original change's description:
> DevTools: Make Preferences Settings Pane Accessible
> 
> Preferences pane had following accessibility issues and is fixed as follows:
> - The top heading was in h3.
> 
> Fix: Updated h3 to h1
> - Subcategories was missing heading role of h2 and group roles for subcategories was missing
> Fix: Added role heading of level 2
> Fix: Added role group to each sub categories
> - Label for drop-downs were not linked with select element so, screen reader wasn't reading out for drop-downs.
> Fix: Added 'for' attribute in label with id value of drop-down select element
> Change-Id: I64d433522c814b8f65ced29958524ac175d987ac
> 
> Bug: 963183
> 
> Video showing Preferences pane after this change https://imgur.com/caUMd46
> 
> Change-Id: I64d433522c814b8f65ced29958524ac175d987ac
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600533
> Reviewed-by: Erik Luo <luoe@chromium.org>
> Commit-Queue: Chandani Shrestha <chshrest@microsoft.com>
> Cr-Commit-Position: refs/heads/master@{#660890}

TBR=einbinder@chromium.org,luoe@chromium.org,jeffish@microsoft.com,jalissia@microsoft.com,ambake@microsoft.com,juxiao@microsoft.com,chshrest@microsoft.com

Change-Id: Ie904d53939015381c962e50e310f4ceaae484e49
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 963183
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618170
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Reviewed-by: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661031}

https://skia.googlesource.com/skia.git/+log/f3fa60010e45..efb9f14aba03


git log f3fa60010e45..efb9f14aba03 --date=short --no-merges --format='%ad %ae %s'
2019-05-17 robertphillips@google.com Add testing of mipmaps to backend allocation test
2019-05-17 bsalomon@google.com Revert "Make SkSurface::asyncRescaleAndRead use kStrict constraint"
2019-05-17 jvanverth@google.com Fix matrix layout in Metal.
2019-05-17 mtklein@google.com Revert "byte align everything in SkSLInterpreter"
2019-05-17 reed@google.com Experimental SkVideoDecoder, to wrap calls to ffmpeg
2019-05-17 mtklein@google.com byte align everything in SkSLInterpreter
2019-05-17 michaelludwig@google.com Force snapBackImage() to N32 for image filters
2019-05-17 bsalomon@google.com Make SkSurface::asyncRescaleAndRead use kStrict constraint


Created with:
  gclient setdep -r src/third_party/skia@efb9f14aba03

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=michaelludwig@google.com

Change-Id: I36b82379876dc84bc79108a5d489b9cfaad35da9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618102Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#661030}

This reverts commit b8296ec2.

Reason for revert: reverting to allow revert @ crrev.com/c/1618170

Original change's description:
> DevTools: Make Settings Blackboxing Pane Accessible
> 
> This change provides fixes for these issues:
> Problem: The content title was heading role
> Fix: Added heading role of level 1
> Problem: Aria-label was missing in drop-downs
> Fix: Added aria-label in drop-downs
> 
> Tested keyboard navigation
> - navigate up/down drop-down items using arrow keys
> - Checkbox is checked/unchecked using space bar
> - Tab into/out (no tab traps)
> 
> Tested screen reader
> - reads checkbox label
> - reads items selected from the drop down list
> 
> Bug: 963183
> 
> Change-Id: Iaab2dd37323427215f765b3d7bbef885861c210f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605506
> Commit-Queue: Chandani Shrestha <chshrest@microsoft.com>
> Reviewed-by: Joel Einbinder <einbinder@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#660991}

TBR=einbinder@chromium.org,luoe@chromium.org,jeffish@microsoft.com,jalissia@microsoft.com,ambake@microsoft.com,juxiao@microsoft.com,chshrest@microsoft.com

Change-Id: I043b25bb968124defd01edd2058bb2603bc1e386
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 963183
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618026Reviewed-by: Collin Baker <collinbaker@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661029}

Bug: 964341
Change-Id: Id669a728089030cfb7f638eaa38668ac15e2bad1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617442
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661028}

https://quiche.googlesource.com/quiche.git/+log/63d0bc4ae8dc..da26cdbf3574

$ git log 63d0bc4ae..da26cdbf3 --date=short --no-merges --format='%ad %ae %s'
2019-05-17 rch gfe-relnote: Fix a bug in QuicSpdyClientStreamBase. Protected by --gfe2_reloadable_flag_quic_eliminate_static_stream_map_3
2019-05-17 fayang gfe-relnote: In QUIC, ignore bad bandwidth samples.
2019-05-17 dschinazi Prevent include failures of quic_flag_utils
2019-05-16 rch gfe-relnote: n/a - Remove unused includes in quic_toy_client.cc
2019-05-16 nharper Renumber QUIC streams when there is no crypto stream
2019-05-16 fayang gfe-relnote: In QUIC, only vlidate destination_connection_id_length and source_connection_id_length when should_update_expected_connection_id_length is false. No functional change expected, not protected.
2019-05-16 rch gfe-relnote: n/a - Remove overly broad include from quic_toy_client.h
2019-05-16 fayang Add logging only ack_frame accessor.
2019-05-15 rch gfe-relnote: n/a - Add missing include for quic_flag_utils.h in quic_packet.cc
2019-05-15 nharper Add QUIC_BUG_IF to QuicUtils::GetCryptoStreamId
2019-05-15 rch Move virtually all the toy client logic out of quic_client_bin.cc and into a new QuicToyClient class which can be used in chromium.
2019-05-15 wub gfe-relnote: (n/a) Delete use_stateless_rejects_if_peer_supported from QuicCryptoServerStream's constructor. No behavior change, not protected.
2019-05-15 dschinazi Replace a DCHECK with a parse failure in connection ID parsing
2019-05-15 rch Move drop_response_body from QuicClient to QuicSpdyClientBase to share with chromium
2019-05-15 rch Extract the FakeProofVerifier from quic_client_bin.cc to facilitate sharing with Chromium.
2019-05-15 dschinazi Add QuicFramer Probe methods
2019-05-15 vasilvv Remove .impl() method from QuicSocketAddress and QuicIpAddress.
2019-05-15 quiche-dev Change QuartcClientEndpoint to handle client-side version negotiation.
2019-05-15 wub In quic_client_bin.cc, print the "Request (succeeded|failed)" messages in stdout instead of stderr.
2019-05-15 fkastenholz Have separate uni- and bi-directional stream limits for IETF QUIC
2019-05-15 wub Fix a use-after-free in quic_client.
2019-05-14 quiche-dev Project import generated by Copybara.
2019-05-14 fayang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_fix_termination_packets.

Created with:
  roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src

[Reland https://chromium-review.googlesource.com/c/chromium/src/+/1616941 with Fixes]

Change-Id: I5236123890aefa12a6f1c09c9ce4c3db021580e4

TBR=steveanton@chromium.org

Change-Id: I5236123890aefa12a6f1c09c9ce4c3db021580e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618019Reviewed-by: Brad Lassey <lassey@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661027}

This CL implements UI updates include
1. Hide volume slider immediately when showing mid
overlay (and vice versa), and
2. Set display to none after hide bottom progress bar UI
to give captions space to show.

Bug: 928443
Change-Id: I73db74c3047056424784804ae7f5ea942bcde22a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610993Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Jazz Xu <jazzhsu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661026}

A previous change made ImageDecoder take a OnceCallback, using that
here to eliminate BindRepeating and Passed.

Bug: 946757
Change-Id: Id31ee666738efe3d4a1672b14b286fb9e5459188
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617093Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661025}

This param does not change the default behavior, but allows adjusting
behavior via finch. This will allow us to modify pre-connect retry
behavior to be slightly less aggressive.

Bug: 964089
Change-Id: I989c075c733e1d5edb5d0b070abcda86acd57545
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614706Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Auto-Submit: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661024}

This is a reland of 9a00ff2b

Original change's description:
> Use IMM32 instead of TSF on Win7.
>
> On Windows 7, there are many IMM32-based IMEs are relying on IMM32
> support. We should continue supporting those legacy IMEs on Win7. We
> should disable TSF on Win7 and use IMM32. All other Windows platforms
> are not affected.
>
> Bug: 963558
> Change-Id: I8f77afbdb734c355f4393880e80fafd98e25ae88
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613974
> Reviewed-by: Yohei Yukawa <yukawa@chromium.org>
> Commit-Queue: Siye Liu <siliu@microsoft.com>
> Cr-Commit-Position: refs/heads/master@{#660261}

TBR=yukawa@chromium.org,siliu@microsoft.com

Bug: 963558
Change-Id: I6fe82b458f09131dc05a257e4a4fa8eba879e75a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616740Reviewed-by: Lan Wei <lanwei@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661023}

ChromeEarlGreyImpl will assert with correct file name and line number
with the help of EG_TEST_HELPER_ASSERT_TRUE macro. helpers now always
return nil to keep compatibility with test code that wraps method calls
into CHROME_EG_ASSERT_NO_ERROR macro.

ChromeEarlGreyImpl is used by ChromeEarlGrey macro that saves the
caller's file and line number.

No test code is changed in this CL and EG_TEST_HELPER_ASSERT_TRUE calls
will be cleaned up in followup CLs.

Converted the following helpers:
 -reload
 -goBack
 -goForward
 -openNewTab
 -openNewIncognitoTab
 -closeAllIncognitoTabs
 -waitForPageToFinishLoading
 -waitForStaticHTMLViewContainingText
 -waitForStaticHTMLViewNotContainingText

Bug: 963613
Change-Id: Id56d6238eddf8a82c5237ae56823d97ac81fd1ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615907
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661022}

This CL removes the last subclass of BrowserContextKeyedBaseFactory.

Bug: 937770
Change-Id: I0a146ff1eb08a3183bfdb27ada01bf89e1b32058
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579768
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661021}

This patch rolls openscreen to the latest HEAD.

Change-Id: I9890293e3b2ed62a702bd0aa08a0615cf26798a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618022Reviewed-by: Brandon Tolsch <btolsch@chromium.org>
Commit-Queue: Jordan Bayles <jophba@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661020}

A further CL will decouple the existing observer implementations to use
these directly, but there will be some small breaking logic changes to
ShouldObserve/OnNodeAdded/OnBeforeNodeRemoved to handle on a case by
case basis.

BUG=910288

Change-Id: I3ac75aac01dd2b961926df46b2e0ba8b73c3f141
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610987
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661019}

This is a follow up to bug discussion 960409:
https://bugs.chromium.org/p/chromium/issues/detail?id=960409#c8

The patch adds the 'devtools://' url scheme to the list of internal
schemes and adds a check to ensure that navigations to that scheme
don't bounce out to external apps.

Change-Id: Ibe9ab69a2bebc20e7636e65943dc67b426f0fea5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615605Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: James Lissiak <jalissia@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#661018}

https://swiftshader.googlesource.com/SwiftShader.git/+log/62ad1eeb0e6b..036cc9ae1244


git log 62ad1eeb0e6b..036cc9ae1244 --date=short --no-merges --format='%ad %ae %s'
2019-05-17 sugoi@google.com Unnormalized texture coordinates


Created with:
  gclient setdep -r src/third_party/swiftshader@036cc9ae1244

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=swiftshader-team+autoroll@google.com

Change-Id: I916448feebc044c8970d3eaee6c8999d6f53e2b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617312Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#661017}

https://chromium.googlesource.com/catapult.git/+log/6ea34ccba4c6..662a859f9bb3


git log 6ea34ccba4c6..662a859f9bb3 --date=short --no-merges --format='%ad %ae %s'
2019-05-17 perezju@chromium.org [Telemetry] Close devtools client backend as best effort


Created with:
  gclient setdep -r src/third_party/catapult@662a859f9bb3

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:958778
TBR=simonhatch@google.com

Change-Id: I1973aefcf13450280c03dd676c4af90f967804fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617399Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#661016}

This patch disables the location selection dialog and always shows
the duplicate download infobar.

Bug: 958473
Change-Id: Id1ace68e1636728097e7865e270f08a57fb8ab3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618009Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661015}

Bug: 699562
Change-Id: I9c818a0c0c490b2d32929a9867d5d3bebf6e8ca9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618016
Auto-Submit: David Benjamin <davidben@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661014}

Introduce ChromeSupplier and use it to provide OverviewModeBehavior to
the app menu and SystemUiCoordinator/NavigationBarColorController.

The ChromeSupplier allows classes to register a callback to be notified
when the wrapped dependency is available.

BUG=956260, 960129

Change-Id: If1e363be247a237b45931b1727cb76f2a6ee694b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610205
Commit-Queue: Theresa <twellington@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661013}

Before this patch, Payment Request would always return false for
canMakePayment() and hasEnrolledInstrument() and reject show() with
NotSupportedError for websites with invalid certificates, even if the
--ignore-certificate-errors flag was passed on the command line. This
flag is used by web platform tests, which was unable to run some Payment
Request tests.

This patch checks for --ignore-certificate-errors flag the SSL validity
checker for Payment Request.

After this patch, web platform tests are able to run more of the Payment
Request tests.

Bug: 964472
Change-Id: I94be74cbaa973a37b5effc0d3925e18ca5a50f2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618121Reviewed-by: Danyao Wang <danyao@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661012}

In KeyboardController::NotifyKeyboardBoundsChanging, when keyboard
window is null or invisible, |visual_bounds_in_root_| is reset and
it changes the return value of GetWorkspaceOccludedBoundsInScreen.
However we still use the old value returned by GetWorkspaceOccluded-
BoundsInScreen before condition block as parameter. This CL fixes
this issue.

Bug: 960174
Change-Id: Iee95babce7a01328d90a1065b2da8f171ff7d844
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618181
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661011}

This reverts commit 3cf15f91.

Reason for revert:
https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Trusty%20Leak
08:51:48.392 3538 worker/2 external/wpt/wasm/webapi/body.any.html leaked
08:51:48.397 3431 [5197/7478] external/wpt/wasm/webapi/body.any.html failed unexpectedly (leak detected: ({"numberOfLiveDocuments":[1,2],"numberOfLiveNodes":[4,22],"numberOfLiveResourceFetchers":[1,2],"numberOfLiveResources":[0,3]}))
08:51:48.393 3538 worker/2 external/wpt/wasm/webapi/body.any.html failed:
08:51:48.393 3538 worker/2  leak detected: ({"numberOfLiveDocuments":[1,2],"numberOfLiveNodes":[4,22],"numberOfLiveResourceFetchers":[1,2],"numberOfLiveResources":[0,3]})

Since it appears WASM related and the V8 roll is in a pretty small set, this seems the most likely culprit.

https://chromium.googlesource.com/chromium/src.git/+log/2b9db0045e4d669a0615c40215de3cfb95e729ea..0daa25d5051667136a263f627aa0a61703f26dd4

Original change's description:
> Update V8 to version 7.6.206.
>
> Summary of changes available at:
> https://chromium.googlesource.com/v8/v8/+log/c9178292..92b8322b
>
> Please follow these instructions for assigning/CC'ing issues:
> https://v8.dev/docs/triage-issues
>
> Please close rolling in case of a roll revert:
> https://v8-roll.appspot.com/
> This only works with a Google account.
>
> CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
> CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
> CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
> CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
> CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel
>
> TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com
>
> Change-Id: Iac0d4b87103b6c56b70aad5f27f8a66405e62130
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617067
> Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#660835}

TBR=hablich@chromium.org,v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I6ef39c00255ca2a86f9cddacc5ea4c5ec4122f8b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618163
Commit-Queue: Brian White <bcwhite@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661010}

Change-Id: Ibc6258557227b34a56dc3a1b5e3239a375a86584
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616947
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Auto-Submit: Staphany Park <staphany@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661009}

This fixes an issue with key functions In-Product Help which caused it
to show the incurrect view on quick changes in cursor visibility.

Bug: 962683
Change-Id: Ibc86a91a877e42ceab69bbf133db07b8ff0f78d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617718Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661008}

The use of Bind() is deprecated, replace with BindRepeating because
this callback is called more than once, and make the type explicit
as well in the receiver.

This was discussed in "Should AuthCallback be a OnceCallback?" on
blink-network-dev@chromium.org.

R=mmenke@chromium.org

Bug: 953861
Change-Id: Iaa4a155e767da077688a4a107d2f0d7bf37d6a15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615835Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661007}

Fix for:
Issue 963392: Regression:'Drop and Install' Message is seen when a
bookmarked item is dragged in chrome://extension page.

On initiating a bookmark drag, the UniformResourceLocatorW clipboard
format is added to the data object, as well as a "virtual" .url file
using CFSTR_FILEDESCRIPTORW/CFSTR_FILECONTENTS formats, which represents
an internet shortcut intended to be dropped on the desktop. Before my
introduction of virtual file support:

https://chromium.googlesource.com/chromium/src/+/e524176b0fb387f1c3e509364cde09af045b8a91

a Chromium drop target ignored the virtual file content, but now it is
recognized on drag enter and drop. The chrome:://extensions page "sees"
the presence of file data and assumes the intent is to install an
extension and thus displays the Drop to Install feedback--you see the
same thing without my fix when dragging an arbitrary file in from the
desktop into the extensions page.

The least risky fix is to ignore virtual files if there is also url data
present. Note you can't just check if the "chromium/x-bookmark-entries"
custom format is present, since this bug also repros dragging the favicon
or site info icon out of the address bar, and in that scenario
"chromium/x-bookmark-entries" is not added. In my experimentation
dragging items out of Outlook.exe, no url data is added to the data
object, so this fix won't break the primary scenario addressed by my
original change.

Bug: 963392
Change-Id: I902cecedca49e1fc6f39cbf9a62de8895dfd0d10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615962
Commit-Queue: Bruce Long <brlong@microsoft.com>
Reviewed-by: Darwin Huang <huangdarwin@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661006}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/fdbb15913346..e6f19dda56ee


git log fdbb15913346..e6f19dda56ee --date=short --no-merges --format='%ad %ae %s'
2019-05-17 akeshet@chromium.org skylab: delete suite_id argument from AbortSkylabHWTests
2019-05-17 saklein@chromium.org PrepareBinhostUploads: Write the package index file with sudo


Created with:
  gclient setdep -r src/third_party/chromite@e6f19dda56ee

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Change-Id: I4726ceb812f9b1e3338b98495f8cea9ab17ef642
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617398Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#661005}

Bug: 962500
Change-Id: Ib5e275a7f31be3a7e24dfc7bf976b6e2866624fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614703
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661004}

Bug: 964451
Change-Id: I27f4a28ade2cee226c5a65b366d9aaeda503d0ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618013Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661003}

This addresses some comments from UX review on settings for touchless
devices. More information on the bug.

Bug: 962562,963515,961904
Change-Id: I6146f1dbddbb580748074ad201c82f267e5306ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613709
Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661002}

Fixes: 963456
Bug: 939312,963456
Change-Id: Ia3d040d396cfaffe1d8ca68fd51cda42beed7e01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613985
Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org>
Reviewed-by: Anna Malova <amalova@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661001}

This CL changes PrintPreviewHandler to obtain the sign in state from the
identity service, and send this with initial settings. This will
eventually allow Print Preview to set the initial cloudPrintState
without querying the cloud print server.

Bug: 961359
Change-Id: I4382801b7e9a474e3664966d1794e4f4d6b0a7a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616329
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661000}

Bug: 956737
Change-Id: I0283330437fb75a973b92281c4237ba14b3a44ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614077Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660999}