GitLab

This is a follow up fix to r361481. After r361481 additional info
about a LoadDataWithBaseURL is stored in DocumentState.

However, if there is an in-page fragment navigation, this additional
info is just thrown away, causing incorrect behavior. Fix this by not
updating this additional info for in-page navigations.

Note this is NOT a fix for crbug.com/561034, which describes a similar
problem, but on the browser side.

BUG=594611
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review URL: https://codereview.chromium.org/1802383004

Cr-Commit-Position: refs/heads/master@{#381588}

The inputs needed for isSecureContext() were, previously:
a.) the origins of the current frame and its ancestors
b.) for any sandboxed origins in the ancestor chain, the URLs of those frames

(a) is easily accessible in --site-per-process, but (b) is not. For
sandboxed frames, the URL was used to construct a stand-in origin. The
sandboxed frame was considered potentially trustworthy if the stand-in
origin was potentially trustworthy.

In --site-per-process, instead of using the URL for a sandboxed origin,
we save the necessary information (the potential-trustworthiness) at the
time that the origin becomes sandboxed.

Based on https://codereview.chromium.org/1716303002/

BUG=571079
TEST=secureContexts/* layout tests with --site-per-process
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review URL: https://codereview.chromium.org/1723753002

Cr-Commit-Position: refs/heads/master@{#381587}

This is toward deleting the class entirely. These methods were not used
at all, or for a couple of them, had one caller which we redirect to the
GLES2Interface directly.

Adds a DEPS entry for core/testing/ to use GLES2Interface as there's
code in there calling things on WebGraphicsContext3D now.

R=kbr,esprehn,sievers,chrishtr
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review URL: https://codereview.chromium.org/1809553002

Cr-Commit-Position: refs/heads/master@{#381586}

Revert of Fix typo in Android perf variations for unified media pipeline trial. (patchset #1 id:1 of https://codereview.chromium.org/1808803002/ )

Reason for revert:
This is breaking the media tests downstream.

Original issue's description:
> Fix typo in Android perf variations for unified media pipeline trial.
>
> BUG=533190
> TEST=none
>
> Committed: https://crrev.com/31d22b6338ac6ac8b95e9f4c20cdccea11609be2
> Cr-Commit-Position: refs/heads/master@{#381498}

TBR=asvitkine@chromium.org,dalecurtis@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=533190

Review URL: https://codereview.chromium.org/1813553002

Cr-Commit-Position: refs/heads/master@{#381585}

TBR=sullivan
BUG=595404
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq

Review URL: https://codereview.chromium.org/1812613002

Cr-Commit-Position: refs/heads/master@{#381584}

This change implements the SetWifiEnabledState API for the Host.

BUG=594723
BUG=b/27107139

Review URL: https://codereview.chromium.org/1798293002

Cr-Commit-Position: refs/heads/master@{#381583}

The solid line separator is retained for both the top and between infobars.

Now both the bottom and the top have pieces that overlap the rest of the
browser. On the top, it's the arrow, and on the bottom, it's the shadow.

This changes the layout of InfoBarContainerView such that it's always
sized with zero overlap. This simplifies layout in the browser view and
is now possible because layers allow child views to draw outside their
bounds. This also makes event hit testing simpler (no need to override
the event targeter for the container).

BUG=520266

Review URL: https://codereview.chromium.org/1800373002

Cr-Commit-Position: refs/heads/master@{#381582}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/e4173cd91158..468628c224cf

$ git log e4173cd91..468628c22 --date=short --no-merges --format='%ad %ae %s'

CQ_INCLUDE_TRYBOTS=
TBR=catapult-sheriff@chromium.org

Review URL: https://codereview.chromium.org/1811693003

Cr-Commit-Position: refs/heads/master@{#381581}

Tryjobs on this bot try to run the angle_deqp_gles3_tests but it
isn't found causing gn gen to fail. This fixes this issue by adding
the correct gn flag to make ANGLE generate the dEQP targets.

BUG=583702

Review URL: https://codereview.chromium.org/1809803003

Cr-Commit-Position: refs/heads/master@{#381580}

https://chromium.googlesource.com/skia.git/+log/830dfd87a770..2732e186a113

$ git log 830dfd87a..2732e186a --date=short --no-merges --format='%ad %ae %s'
2016-03-16 benjaminwagner Un-deprecate new methods to fix Android.
2016-03-16 mtklein detach -> release

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=bungeman@google.com

Review URL: https://codereview.chromium.org/1806013004

Cr-Commit-Position: refs/heads/master@{#381579}

* Adds ability to display an offline bolt icon in CCT, when viewing an
  offline copy of the page
* Appropriately animates 6 state transitions between the following 3
  states: no icon, security icon, offline icon.

BUG=593833
R=tedchoc@chromium.org

Review URL: https://codereview.chromium.org/1804723002

Cr-Commit-Position: refs/heads/master@{#381578}

BUG=581974

Review URL: https://codereview.chromium.org/1804963003

Cr-Commit-Position: refs/heads/master@{#381577}

BUG=594850

Review URL: https://codereview.chromium.org/1801333002

Cr-Commit-Position: refs/heads/master@{#381576}

Revert of Add sk_sp helpers and switch Blink SkShader clients to the new APIs (patchset #7 id:120001 of https://codereview.chromium.org/1789063005/ )

Reason for revert:
Suspecting this patch to have caused the compilation failure: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20non-Oilpan/builds/811

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20non-Oilpan/builds/811/steps/compile/logs/stdio

Original issue's description:
> Add sk_sp helpers and switch Blink SkShader clients to the new APIs
>
> Introduce a couple of Skia utilities to support PassRefPtr <-> sk_sp
> interoperability:
>
>  * adoptRef(sk_sp<T>)       - for adopting sk_sps rvals into PassRevPtr
>                               (when transferring ownership from Skia->Blink)
>  * adoptSkSp(PassRefPtr<T>) - for adopting PassRefPtr rvals into sk_sp
>                               (when transferring ownership from Blink->Skia)
>
> Update clients to use the new Skia shader factories ("makers" vs. prev
> "creators"), and sk_sp-based setters.
>
> A tangential change: deconstify SkPicture fields/args to align with the new
> Skia APIs (SkPicture is inherently const - no non-cost methods - and Skia now
> expects non-const SkPicture args).
>
> BUG=skia:5077
> R=jbroman@chromium.org,reed@google.com,senorblanco@chromium.org
>
> Committed: https://crrev.com/2df3d4433fc756f1297c4e0ced6524cbfcba9571
> Cr-Commit-Position: refs/heads/master@{#381563}

TBR=jbroman@chromium.org,bungeman@chromium.org,reed@google.com,senorblanco@chromium.org,danakj@chromium.org,fmalita@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:5077

Review URL: https://codereview.chromium.org/1814473003

Cr-Commit-Position: refs/heads/master@{#381575}

This CL adds a stub service that implements interface::AudioDecoder.
The interface is modified to pass the AudioDecoderClient which
can transfer the results back to the proxy.

BUG=542910

Review URL: https://codereview.chromium.org/1808593002

Cr-Commit-Position: refs/heads/master@{#381574}

This reverts commit 13fe4645.
See https://codereview.chromium.org/1761673002/

TBR=thakis@chromium.org

Review URL: https://codereview.chromium.org/1811743002

Cr-Commit-Position: refs/heads/master@{#381573}

This code was landed but -silly me- I was setting the complexity
_before_ creating the encoder :P

Also, the values the VP8E_SET_CPUUSED parameter are:
 - up to 8 for VP9 (and not up to 16, that's for VP8)
 - Real Time values are 5 - 8 [1]

BUG=591342, 589162

[1] https://code.google.com/p/chromium/codesearch#chromium/src/third_party/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc&sq=package:chromium&type=cs&l=35&rcl=1458143321

Review URL: https://codereview.chromium.org/1809853002

Cr-Commit-Position: refs/heads/master@{#381572}

BUG=581917
TEST=LayerOwnerTest.RecreateLayerWithTransform

Review URL: https://codereview.chromium.org/1800393002

Cr-Commit-Position: refs/heads/master@{#381571}

Previously, WebExternalTextureLayerImpl inferred the size of the texture from
the bounds of the WebLayer, but the two are not necessarily the same. This CL
passes the texture size through WebExternalTextureMailbox.

This CL also adds a pixel test.

BUG=595063
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1804243002

Cr-Commit-Position: refs/heads/master@{#381570}

- blink-side usages migrated to v8::MicrotasksScope;
- clients of WebScopedMicrotaskSuppression migrated to v8::MicrotasksScope;
- moved Microtask.{h,cpp} to bindings/core/v8;
- removed extra wrappers from V8DebuggerClient;
- fixed a couple of inspector tests which relied on trace event not emitted from debugger anymore.

Attempt #2. First one failed due to missing scopes in platform/v8_inspector. See issue 594974.

BUG=585949

Review URL: https://codereview.chromium.org/1769273004

Cr-Commit-Position: refs/heads/master@{#381569}

Ensures that any accessibility attributes on Windows whose values have not been specified get a default value in tests.

BUG=508794
R=dmazzoni@chromium.org

Review URL: https://codereview.chromium.org/1806813003

Cr-Commit-Position: refs/heads/master@{#381568}

BUG=588152

Review URL: https://codereview.chromium.org/1718563002

Cr-Commit-Position: refs/heads/master@{#381567}

Upcoming changes in the Chrome OS networking daemon (shill) will allow
third party VPNs to transition "backwards" from Online->Configuring if
the default physical connection changes.  Add a "reconnect" flag so
that VPN apps can signal their compatibility with this new scheme,
and add the necessary UI changes so that Chrome can identify
reconnections and present them to the user in a sensible way.

Also, change the UI so that users can cancel VPN reconnections
(and connections) using the "Disconnect" button.

BUG=514343

Review URL: https://codereview.chromium.org/1722453002

Cr-Commit-Position: refs/heads/master@{#381566}

Review URL: https://codereview.chromium.org/1783133002

Cr-Commit-Position: refs/heads/master@{#381565}

This patch rebaselines the following svg tests:
svg/batik/text/textAnchor3.svg
svg/W3C-SVG-1.1-SE/coords-dom-02-f.svg

These tests just need new baselines. I manually verified they are
correct.

BUG=589525
TBR=fgorski@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1808653007

Cr-Commit-Position: refs/heads/master@{#381564}

Introduce a couple of Skia utilities to support PassRefPtr <-> sk_sp
interoperability:

 * adoptRef(sk_sp<T>)       - for adopting sk_sps rvals into PassRevPtr
                              (when transferring ownership from Skia->Blink)
 * adoptSkSp(PassRefPtr<T>) - for adopting PassRefPtr rvals into sk_sp
                              (when transferring ownership from Blink->Skia)

Update clients to use the new Skia shader factories ("makers" vs. prev
"creators"), and sk_sp-based setters.

A tangential change: deconstify SkPicture fields/args to align with the new
Skia APIs (SkPicture is inherently const - no non-cost methods - and Skia now
expects non-const SkPicture args).

BUG=skia:5077
R=jbroman@chromium.org,reed@google.com,senorblanco@chromium.org

Review URL: https://codereview.chromium.org/1789063005

Cr-Commit-Position: refs/heads/master@{#381563}

BUG=561873

Review URL: https://codereview.chromium.org/1805803002

Cr-Commit-Position: refs/heads/master@{#381562}

BUG=595348

Review URL: https://codereview.chromium.org/1811533004

Cr-Commit-Position: refs/heads/master@{#381561}

BUG=484228
TESTED=unit test, dump accessibility tree tests, manually with Jaws and NVDA screen readers
R=dmazzoni@chromium.org,aboxhall@chromium.org

Review URL: https://codereview.chromium.org/1768753003

Cr-Commit-Position: refs/heads/master@{#381560}

Spake2Authenticator requires that local_id and remote_id are the same
on both ends of the connection, so JIDs need to be normalized to avoid
issues when one of the ends gets JID in a different case.

BUG=589698

Review URL: https://codereview.chromium.org/1803893002

Cr-Commit-Position: refs/heads/master@{#381559}

To avoid cc::Scheduler having to sometimes own / sometimes create /
switch between sources / manage parameters on sources, hoist all this
logic up to the owners of cc::Scheduler.

This refactoring makes it possible to eventually allow an OutputSurface
to set a BeginFrameSource on its client and then forward that to the
scheduler to use.  That future is made easier by the scheduler having a
single begin frame source managed by its owner.

This patch adds a bit of duplicated logic in three places (single thread
proxy / threaded proxy / tests) for the creation of the begin frame
source.  However, the single thread and threaded versions were already
doing different things (re: authoritative vsync signals).  The hope
is that the vsync information and begin frame source creation for the
synthetic sources can get further hoisted into OutputSurface itself.

Depends on https://codereview.chromium.org/1762823002

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1765723002

Cr-Commit-Position: refs/heads/master@{#381558}

If the icon path that we get from the manifest contains a reference to
the parent directory ("..") we would not save it and associate with the
whitelist. This is done in order to avoid malicious access to parent
folders.

Review URL: https://codereview.chromium.org/1770313004

Cr-Commit-Position: refs/heads/master@{#381557}

This change introduces the OverlayPanelEventFilter; a single event
filter for any of the actions that can occur on an OverlayPanel. This
change will be used once OverlayPanels are SceneOverlays.

Tests added here: https://codereview.chromium.org/1808653006

BUG=584340

Review URL: https://codereview.chromium.org/1739203003

Cr-Commit-Position: refs/heads/master@{#381556}

If there is an existing chrome://extensions page open, it should be able to be
overridden to show an extension's options page if that options page opens in
a view in the chrome://extensions page.

BUG=595253

Review URL: https://codereview.chromium.org/1805013005

Cr-Commit-Position: refs/heads/master@{#381555}

Drop the unnecessary restriction that eagerly finalized objects aren't
allowed to touch access other eagerly finalized, but live, objects during
finalization. They're allowed to access live objects in other heaps/arenas,
so the same-heap restriction makes little sense.

Simplify the HeapPage poisoning methods as a result.

R=haraken
BUG=594129

Review URL: https://codereview.chromium.org/1805343004

Cr-Commit-Position: refs/heads/master@{#381554}

git cl lint told me to:
* include <vector> for vector,
* mark single argument constructor explicit,
* leave space before '('.

Codesearch told me that SpdySession::pool_ is never set to nullptr, removing
incorrect comment.

BUG=

Review URL: https://codereview.chromium.org/1801293002

Cr-Commit-Position: refs/heads/master@{#381553}

Revert of Remove the leak expectation for web-animations-api/player-cancel-event.html since it seems to be wo… (patchset #1 id:1 of https://codereview.chromium.org/1766243002/ )

Reason for revert:
https://codereview.chromium.org/1750453002 was reverted and now the leak is happening again.

Original issue's description:
> Remove the leak expectation for web-animations-api/player-cancel-event.html.
>
> It seems to have been fixed by https://codereview.chromium.org/1750453002
>
> BUG=588598
>
> Committed: https://crrev.com/bc817fe1b14552590efd801e683686074e928570
> Cr-Commit-Position: refs/heads/master@{#379721}

TBR=alancutter@chromium.org,dsansome@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=588598

Review URL: https://codereview.chromium.org/1809783002

Cr-Commit-Position: refs/heads/master@{#381552}

BUG=none
R=dgozman, pfeldman

Review URL: https://codereview.chromium.org/1809773002

Cr-Commit-Position: refs/heads/master@{#381551}

TBR=sullivan
BUG=595069
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq

Review URL: https://codereview.chromium.org/1801123003

Cr-Commit-Position: refs/heads/master@{#381550}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/07ebb39b800b..e4173cd91158

$ git log 07ebb39b8..e4173cd91 --date=short --no-merges --format='%ad %ae %s'

CQ_INCLUDE_TRYBOTS=
TBR=catapult-sheriff@chromium.org

Review URL: https://codereview.chromium.org/1809763002

Cr-Commit-Position: refs/heads/master@{#381549}