GitLab

BUG=516618

Review URL: https://codereview.chromium.org/1314493013

Cr-Commit-Position: refs/heads/master@{#347872}

packets are lost) for 4 consecutive crypto handshakes.

For a session, during crypto handshake if there is a bad packet loss
rate, then we mark that QUIC is recently broken for that host/port.

We disable QUIC and close that connections if 4 consecutive handshakes
have bad packet loss rate. QUIC was disabled for 0.002% of the time.

We have been running the above experiment in M45 (in Canary, Dev and
Beta). In M45 Beta, Net.HttpJob.TotalTimeNotCached.Quic's mean is
faster by 4.4% (for data aggreagted for 28 days) when this experiment
was enabled.

R=rch@chromium.org

Review URL: https://codereview.chromium.org/1326763007

Cr-Commit-Position: refs/heads/master@{#347871}

paste command's hidden property is set true when one directory is focused.
However, it will not be reset when an input is focused just after on directory is focused,
because different handler (forceDefaultHandler) handles canExecute event when inputs are focused.
All cut/copy/paste/delete commands should be shown in input element,
so this CL reset the hidden property of them.

BUG=528843
TEST=manually tested on rename input, search input, and filename input on save-as dialog.

Review URL: https://codereview.chromium.org/1312583009

Cr-Commit-Position: refs/heads/master@{#347870}

BUG=529543

Review URL: https://codereview.chromium.org/1310663007

Cr-Commit-Position: refs/heads/master@{#347869}

When channel IDs are deleted, QUIC sessions  need to be close to avoid reusing the old channel ID.

Review URL: https://codereview.chromium.org/1320423011

Cr-Commit-Position: refs/heads/master@{#347868}

views::Combobox currently does its own menu-building rather than using a
ui::MenuModel. However, the only thing missing from MenuModel is the
ability to set a minimum menu width. (Combobox currently does this by
adding an invisible SubmenuView with a given width.)

Moving the menu building out of Combobox allows Mac to build a native
menu instead, which gives a much nicer menu experience there. In
particular, Comboboxes on Mac center the menu over the button vertically,
and have fancy scrolling/repositioning mechanisms when the menu is shown
near the edge of the screen.

This CL adds an Adapter class that adapts a ui::ComboboxModel to the
ui::MenuModel interface, allowing views:Comboxbox to be simplified
elsewhere. MenuRunnerImplCocoa will be extended to support comboboxes in
a follow-up. For the minimum width, MenuController::CalculateMenuBounds()
can just use the width of the anchor rectangle for the same effect.

Note that TranslateBubbleView is the only user of
Combobox::STYLE_ACTION. TranslateBubbleView puts a separator after the
first item which Combobox always removes. MenuModel::IsVisibleAt() isn't
checked for separators, so simply don't add the separator to keep things
simple.

BUG=522365

Review URL: https://codereview.chromium.org/1310903004

Cr-Commit-Position: refs/heads/master@{#347867}

This patch added webusb notification UI unit tests code.

BUG=492204

Review URL: https://codereview.chromium.org/1326003006

Cr-Commit-Position: refs/heads/master@{#347866}

This CL designs a framework for deprecated accelerators.
In this CL we deprecate the following accelerators:
- Lock Screen: Ctrl+Shift+L --> Search+L
- Task Manager: Shift+Esc --> Search+Esc

The old accelerators are still enabled, but the user is shown a
notification message telling him about the new accelerator.
UMA stats are recorded for both old and new accelerators.
Keyboard overlay has been updated.

BUG=492454,486198,498565,405317,503351
TEST=manually, ash_unittests --gtest_filter=DeprecatedAcceleratorTester.*,
     ash_unittests --gtest_filter=AcceleratorTableTest.CheckDeprecatedAccelerators

Committed: https://crrev.com/c2b81c9fca4abc10cafdc75d2e7b4f15314e2e5b
Cr-Commit-Position: refs/heads/master@{#335410}

Review URL: https://codereview.chromium.org/1177773002

Cr-Commit-Position: refs/heads/master@{#347865}

Enhance MaybeCreateHardwareFrame() to be able to create a NV12 hardware
frame backed by a YUV_420_BIPLANAR GpuMemoryBuffer.

This code path is not enabled yet.

BUG=524582
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1307853003

Cr-Commit-Position: refs/heads/master@{#347864}

BUG=523228

Review URL: https://codereview.chromium.org/1310853004

Cr-Commit-Position: refs/heads/master@{#347863}

BUG=514853
TEST=unit_tests:SearchMetadataTest.*;SearchMetadataSimpleTest.*

Review URL: https://codereview.chromium.org/1321553003

Cr-Commit-Position: refs/heads/master@{#347862}

This format is already supported in the rest of the capture path.
Bluefish 444 is the capture card using it.

BUG=508413
TEST=Capture using a Bluefish 444 capture card

Review URL: https://codereview.chromium.org/1325303004

Cr-Commit-Position: refs/heads/master@{#347861}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/036fd8e..a5783ae

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=jcgregorio@google.com

Commits in this roll:
a5783ae msarett@google.com Provides various implementations of Android's SkBitmapRegionDecoder.

Review URL: https://codereview.chromium.org/1326383002

Cr-Commit-Position: refs/heads/master@{#347860}

They're triggering for hosted apps, which is a bug. It's still not correct and
that will be fixed soon, but in the meantime don't crash.

BUG=525965, 529516
R=rdevlin.cronin@chromium.org

Review URL: https://codereview.chromium.org/1328313002

Cr-Commit-Position: refs/heads/master@{#347859}

BUG=527500

Review URL: https://codereview.chromium.org/1321543010

Cr-Commit-Position: refs/heads/master@{#347858}

Warm up locales in LowerToken() after RevertToSelf() as existing warmup was not working on Win 8.1 x64.
Remove existing warmup which was done outside of LowerToken().

BUG=464430

Review URL: https://codereview.chromium.org/1324523008

Cr-Commit-Position: refs/heads/master@{#347857}

Tests would request a new Gaia account only when running
against external servers AND when no --sync-user-for-test
flag is present.

BUG=525165

Review URL: https://codereview.chromium.org/1306163003

Cr-Commit-Position: refs/heads/master@{#347856}

Cr-Commit-Position: refs/heads/master@{#347855}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/46b16a4..9e49999

Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.

NOTRY=true
TBR=alph@chromium.org,eae@chromium.org

Review URL: https://codereview.chromium.org/1321293004

Cr-Commit-Position: refs/heads/master@{#347854}

These tests depend on prerender feature which is disabled on svelte devices.

BUG=529490

Review URL: https://codereview.chromium.org/1305063010

Cr-Commit-Position: refs/heads/master@{#347853}

Ethersuggest++ stopped working on CR44. https://codereview.chromium.org/1189033002/patch/20001/30002 made the change in such a way that current URL is not sent to GWS. More details can be found in the bug.

BUG=529447

Review URL: https://codereview.chromium.org/1305163010

Cr-Commit-Position: refs/heads/master@{#347852}

This reduces the DOM nodes in the page roughly in half, and I haven't
even started on the dangerous ones yet :).

R=tommycli@chromium.org
BUG=526577

Review URL: https://codereview.chromium.org/1325853006

Cr-Commit-Position: refs/heads/master@{#347851}

This makes final integration with the MemoryPressureMonitor easier, as it will own a single TickClock which can be injected down the entire stack of dependencies.

BUG=520962

Review URL: https://codereview.chromium.org/1317353006

Cr-Commit-Position: refs/heads/master@{#347850}

When a spell checker service is not available on a device (e.g. Samsung S4)
Android will return a null object and thus SpellCheckerSessionBride will
return null. This CL adds early returns for such cases.

BUG=529355

Review URL: https://codereview.chromium.org/1310093007

Cr-Commit-Position: refs/heads/master@{#347849}

[!] instead of [x] badge

BUG=505953

Review URL: https://codereview.chromium.org/1309063006

Cr-Commit-Position: refs/heads/master@{#347848}

They're already disabled on Beta and Stable channels. Leaving them
enabled in Dev/Canary confuses users and makes people suspect
regressions.

After this, panels are only enabled when --enable-panels is set in
chrome://flags and for the whitelist (Hangouts).

CL also tries to consolidate all the Hangouts extension IDs scattered
around the codebase.

BUG=467808, 526708

Review URL: https://codereview.chromium.org/1329033002

Cr-Commit-Position: refs/heads/master@{#347847}

J420ToABGR is impliemented using I420ToABGR with a jpeg color matrix parameter.
BUG=libyuv:470

Review URL: https://codereview.chromium.org/1321023006

Cr-Commit-Position: refs/heads/master@{#347846}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/dd364bc..46b16a4

Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.

NOTRY=true
TBR=alph@chromium.org,eae@chromium.org

Review URL: https://codereview.chromium.org/1320563005

Cr-Commit-Position: refs/heads/master@{#347845}

Blink side CL: https://codereview.chromium.org/1303343009/

BUG=527249
TEST=conformance2/state/gl-object-get-calls.html related parts pass
R=piman@chromium.org

Review URL: https://codereview.chromium.org/1319453010

Cr-Commit-Position: refs/heads/master@{#347844}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/b34cb4e..dd364bc

Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.

NOTRY=true
TBR=alph@chromium.org,eae@chromium.org

Review URL: https://codereview.chromium.org/1312833012

Cr-Commit-Position: refs/heads/master@{#347843}

Based on the structure given at https://msdn.microsoft.com/en-us/library/windows/desktop/ms684280(v=vs.85).aspx.

BUG=528450

Review URL: https://codereview.chromium.org/1328703003

Cr-Commit-Position: refs/heads/master@{#347842}

BUG=
R=felt@chromium.org

Review URL: https://codereview.chromium.org/1308693013

Cr-Commit-Position: refs/heads/master@{#347841}

Before, two static methods (GetAll and FindByID) were declared
on SyncedWindowDelegate but defined in platform specific files.
Now, those methods exist on SyncedWindowDelegatesGetter so
they can use polymorphism for platform specificity.

SyncedTabDelegate was the biggest challenge since it is not
really accessible when constructed to pass the getter in.
Instead, the SyncedWindowDelegatesGetter is set in
SyncedTabDelegate::ImplFromWebContents, before anything
else uses the object as a SyncedTabDelegate.

This CL is a prerequisite to componentizing SyncedWindowDelegate
and SyncedWindowDelegatesGetter.

BUG=512472

Review URL: https://codereview.chromium.org/1310373009

Cr-Commit-Position: refs/heads/master@{#347840}

Revert of Fix typo in install-sysroot.py (patchset #2 id:20001 of https://codereview.chromium.org/1317973005/ )

Reason for revert:
Caused check_licenses to fail:

https://build.chromium.org/p/chromium/builders/Linux/builds/66701

Original issue's description:
> Fix typo in install-sysroot.py
>
> install-sysroot.py was intended to default to installing
> the sysroot ia32, but within this script 'i386' is used to
> refer to this architecture.
>
> This most likely went unnoticed since the ia32 builder
> either use branding=Official, or explicitly set
> use_sysroot=1, or have a complete set of packages for
> cross building on the host system.
>
> BUG=504446
>
> Committed: https://crrev.com/1d62049b4c176fbd43bed90fc9a76273b11ad406
> Cr-Commit-Position: refs/heads/master@{#347821}

TBR=dpranke@chromium.org,sbc@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=504446

Review URL: https://codereview.chromium.org/1315773003

Cr-Commit-Position: refs/heads/master@{#347839}

For the expression F(G(), H()), C++ does not guarantee whether G() or
H() will be evaluated first.  Apparently the system compiler on Chrome
OS makes a different decision than on Ubuntu, which causes the golden
file tests introduced by https://crrev.com/1306723002 (which were
generated on Ubuntu) to fail on Chrome OS.

Easy fix: rewrite the expression as

    g = G()
    h = H()
    F(g, h)

to avoid any compiler behavior dependency.

BUG=529480

Review URL: https://codereview.chromium.org/1327693005

Cr-Commit-Position: refs/heads/master@{#347838}

Revert of [Android][telemetry] Break logging deadlock when attempting to log an AppCrashException. (patchset #2 id:20001 of https://codereview.chromium.org/1328093006/ )

Reason for revert:
somehow managed to break Linux Tests: https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/30632/steps/telemetry_unittests/logs/stdio

Original issue's description:
> [Android][telemetry] Break logging deadlock when attempting to log an AppCrashException.
>
> BUG=
>
> Committed: https://crrev.com/e1bf30fc53406ba3bc1b302e87ecda6e3ad2025d
> Cr-Commit-Position: refs/heads/master@{#347816}

TBR=nednguyen@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/1314953011

Cr-Commit-Position: refs/heads/master@{#347837}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/3e944fd..b34cb4e

Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.

NOTRY=true
TBR=alph@chromium.org,eae@chromium.org

Review URL: https://codereview.chromium.org/1329143005

Cr-Commit-Position: refs/heads/master@{#347836}

Review URL: https://codereview.chromium.org/1312843012

Cr-Commit-Position: refs/heads/master@{#347835}

BUG=
TBR=agl@chromium.org

Review URL: https://codereview.chromium.org/1320983006

Cr-Commit-Position: refs/heads/master@{#347834}

BubbleManager doesn't always know when to update a bubble.
Ex: Bubble needs to change label from "Translating..." to "Translated".

Also fix naming from UI -> Ui

BUG=496955

Review URL: https://codereview.chromium.org/1310483003

Cr-Commit-Position: refs/heads/master@{#347833}