- 07 Nov, 2018 40 commits
-
-
Colin Blundell authored
As suggested by msarda@ on https://chromium-review.googlesource.com/c/chromium/src/+/1317915. TBR=jochen@chromium.org Bug: 901859 Change-Id: I4b317bafa5e4a1a017e1977e2ddd444c61c3cfd3 Reviewed-on: https://chromium-review.googlesource.com/c/1319596 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#606049}
-
Matthew Cary authored
Google.com may show a location-usage permission dialog which interferes with page interaction during profiling and may even cause chrome to crash. Wikipedia is more benign, even if it doesn't exercise the javascript and other processing that Google search result page does. Bug: 898979 Change-Id: I8f48f49ac58162bab482615f843651fafcaa9c0f Reviewed-on: https://chromium-review.googlesource.com/c/1317917Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#606048}
-
Justin Cohen authored
WKWebView -takeSnapshotWithConfiguration can return a nil UIImage if there is an error. Change-Id: Ifb1de97f9afed7436b5fae655ac9a35facdc2868 Reviewed-on: https://chromium-review.googlesource.com/c/1316750Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#606047}
-
Colin Blundell authored
//components/signin/core/browser contains three different types of code: 1. Code that forms the guts of IdentityManager and will form the guts of the Identity Service implementation (e.g., SigninManager). 2. Code that will be clients of IdentityManager (e.g., SigninTracker). 3. Code that will be used on both sides (e.g., AccountInfo). Currently, the test support for all of these is naturally grouped in the same GN target, since there was never any distinction between them. However, we need to separate this test support in GN now, as the test support for IdentityManager should depend only on 1 and 3 (and their associated test support). This CL performs an initial split, via the following process: - Moved fake_signin_manager.*, fake_profile_oauth2_token_service.*, and fake_gaia_cookie_manager_service.* into a new "test_support_internals" target that the existing target now depends on. - Kept moving in code (and adding dependencies as needed) until "gn check" no longer complained about the "test_support_internals" target including code that wasn't in any dependencies. This CL also modifies //services/identity/public/cpp:test_support to depend only on //components/signin/core/browser:internals_test_support; this change is is the concrete benefit from doing the split. Finally, this CL strips both the test_support_internals and the test_support target down to the dependencies that they actually need; this change necessitated added some missing direct dependencies to other targets. Bug: 901859 Change-Id: I0ac61f69c0c897d97b570c16d06f0e4f5f99d037 Reviewed-on: https://chromium-review.googlesource.com/c/1319669 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Luna Lu authored
Bug: 829921 Change-Id: Ia2c70c62d4a4235b21996bbd185746080e1efa35 Reviewed-on: https://chromium-review.googlesource.com/c/1320010Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#606045}
-
Vadym Doroshenko authored
MSAN started complaining on uninitializing this variable (the first fail https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/9484). Probably the immediate culprit is https://chromium-review.googlesource.com/c/1320027, but it's hard to say. Anyway this issue was earlier and it's easier to fix it, by initializing it to null then revert the CL. TBR=dtseng@chromium.org TBR=dmazzoni@chromium.org Change-Id: Ie045adfcf6860b47c8e649432c6b6c6abf2061b4 Reviewed-on: https://chromium-review.googlesource.com/c/1323090Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#606044}
-
Mark Cogan authored
The CL removes a method that was functionally a no-op. Change-Id: I721a3f573253df4728dd9cc18ff484c56b52488a Reviewed-on: https://chromium-review.googlesource.com/c/1317860 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#606043}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/add61bdaac69..aced3af1656c Created with: gclient setdep -r src-internal@aced3af1656c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Idf2d018263fe823b73d57e5faf02ef3a76ece6f8 Reviewed-on: https://chromium-review.googlesource.com/c/1323169Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606042}
-
Vadym Doroshenko authored
Sometimes sites change forms after adding them. For example removing/ adding fields. This CL makes NewPasswordFormManager process this situation, by updating |observed_form|, parsing it again and sending new data to the renderer. Bug: 895411, 831123, 895788 Change-Id: I296180c5b30f879a3f9bcc7af7cccb98f5fa8eb8 Reviewed-on: https://chromium-review.googlesource.com/c/1317893 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#606041}
-
Takuto Ikuta authored
To speed up build time on windows component build, I will enable newly added /Zc:dllexportInlines- flag. The flag is similar to -fvisibility-inlines-hidden in gcc/clang. This flag makes inline member function is not exported if it does not have static local variables. But in few classes of chromium, we need to add additional EXPORT specifier to prevent link failure. This is a part of effort adding EXPORT speicifer to enable the flag. Master CL is https://chromium-review.googlesource.com/c/chromium/src/+/1317069 This CL was uploaded by git cl split. R=fmalita@chromium.org Bug: 901709 Change-Id: I32a755124e41532ceebc67900047ccb4580de9c2 Reviewed-on: https://chromium-review.googlesource.com/c/1322331Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#606040}
-
Jason Chase authored
The ExperimentalProductivityFeatures flag, with a corresponding chrome flag, was intended as an easy way for developers to turn on the Feature Policy bits. The Feature Policy reporting functionality and JS API have separate runtime flags. This CL configures an implied_by relationship, so that reporting and the JS API can be turned on together with other Feature Policy functionality. Bug: 899366 Change-Id: I2ff6ac9ed48902e7d1383ace94828f9e5154a27e Reviewed-on: https://chromium-review.googlesource.com/c/1303038Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#606039}
-
Patrik Höglund authored
The tests are clearly broken on Windows if a webcam is plugged in. They pass on win10 but only because they're disabled there. See bug for example breakages on Windows. Bug: 893494 Change-Id: I8ea43cc4e3ef23082246ff23ec635f2ec5bfbbe2 Reviewed-on: https://chromium-review.googlesource.com/c/1309789Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#606038}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/67f5c0ceac22..273fa2f3bd0b git log 67f5c0ceac22..273fa2f3bd0b --date=short --no-merges --format='%ad %ae %s' 2018-11-07 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@273fa2f3bd0b The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@chromium.org Change-Id: I45336359f6589fa969824646b01cd8a29a630009 Reviewed-on: https://chromium-review.googlesource.com/c/1323010Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606037}
-
Arthur Sonzogni authored
After a cross process navigation, the old RenderFrameHostImpl is kept alive the time needed for executing its unload handler. This CL generalize this by also keeping its subframes alive. This fixes unload handler not always being run. RenderFrameHostImpl is now delete as soon as: * All of its children have been deleted. * In case of an unload handler, wait FrameHostMsg_Detach. Explainer: https://goo.gl/85KSff Bug: 609963 Change-Id: Ie5b5585e54b9d1740798d649fcfac5dd2666920f Reviewed-on: https://chromium-review.googlesource.com/c/1122629 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#606036}
-
Christopher Grant authored
This change is credited to digit@, who included this cleanup in a prototype reference CL. I'm cleaning it up and landing it. Refactor common shared_library() declarations for libchrome.so, libchromefortest.so and libmonochrome.so into a shared template. BUG= Change-Id: Ie0c2005c04a664de1cf24e3536aa8b02d745f75d Reviewed-on: https://chromium-review.googlesource.com/c/1318432 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
David Turner <digit@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#606035}
-
Takuto Ikuta authored
To speed up build time on windows component build, I will enable newly added /Zc:dllexportInlines- flag. The flag is similar to -fvisibility-inlines-hidden in gcc/clang. This flag makes inline member function is not exported if it does not have static local variables. But in few classes of chromium, we need to add additional EXPORT specifier to prevent link failure. This is a part of effort adding EXPORT speicifer to enable the flag. Master CL is https://chromium-review.googlesource.com/c/chromium/src/+/1317069 This CL was uploaded by git cl split. R=schenney@chromium.org Bug: 901709 Change-Id: I605f83511671f07dbf464fa1fd151954d6068da1 Reviewed-on: https://chromium-review.googlesource.com/c/1322332Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#606034}
-
Alexander Timin authored
- Do not allow assigning MessageLoop to MessageLoopCurrent. - Remove hash operator from MessageLoopCurrent. R=alexclarke@chromium.org,gab@chromium.org TBR=gab@chromium.org BUG=891670 Change-Id: If558357328d1b07abaa5ccf7bcba5f9ef3609531 Reviewed-on: https://chromium-review.googlesource.com/c/1322874Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#606033}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8770ce70746a..a7f77a7c05b5 git log 8770ce70746a..a7f77a7c05b5 --date=short --no-merges --format='%ad %ae %s' 2018-11-07 alessiob@webrtc.org Isolating APM API build target: making :api an actual target. 2018-11-07 sprang@webrtc.org Update ObjCVideoEncoder to use GetEncoderInfo() 2018-11-07 nisse@webrtc.org Reland "Delete rtc::Pathname" 2018-11-07 perkj@webrtc.org Add counter to the end of FakeEncoder frames in order to make them unique. 2018-11-07 nisse@webrtc.org Add default constructor for rtc::Event 2018-11-07 qingsi@webrtc.org Resolve the race condition between mDNS name registration and Created with: gclient setdep -r src/third_party/webrtc@a7f77a7c05b5 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:none TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ibb7c3f8a436ffa9057bf780107cb6da0e6016cd3 Reviewed-on: https://chromium-review.googlesource.com/c/1322929Reviewed-by:
-
Clemens Arbesser authored
Bug: 806868 Change-Id: I24dbe28166fe9b1ff0193409df45cf9bfd7c7d97 Reviewed-on: https://chromium-review.googlesource.com/c/1322829Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#606031}
-
Eric Karl authored
Adds begin/end functions to the GL command buffer for shared image access. Currently, begin/end is a no-op in all SharedImageRepresentations, this will be fixed up in a follow up. This change just adds the commands and parameter validation in the validating and passthrough command decoders. Bug: 891059 Change-Id: Idb4bd900fa56bd470ad44ad955267e76860792cd Reviewed-on: https://chromium-review.googlesource.com/c/1313668 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#606030}
-
Christian Dullweber authored
Lots of deletion code supports a nullable filter but we pass a proper filter even when there is an empty blacklist. To avoid checking the empty filter for every type of data we should just pass a nullable filter. Change-Id: I2a580e17f3b8e18a4a1181705907abea2617b6d3 Reviewed-on: https://chromium-review.googlesource.com/c/1322769 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#606029}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0fc9f7540077..add61bdaac69 Created with: gclient setdep -r src-internal@add61bdaac69 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I62b8b88d50abc8f6365da5c2d10ce1081424e2e3 Reviewed-on: https://chromium-review.googlesource.com/c/1322930Reviewed-by:
-
Vasilii Sukhanov authored
The flag was used only in the tests and had a dedicated production code. Bug: 845458 Change-Id: I27265ad5a69eecb31663b5fb1526c696f1b35d3d Reviewed-on: https://chromium-review.googlesource.com/c/1322831Reviewed-by:
-
Rayan Kanso authored
Few more minor changes that didn't make it in cr/1297412. Bug: 850512 Change-Id: I7a1070135aa4d10a238c8c12fd4a95ffeac34343 Reviewed-on: https://chromium-review.googlesource.com/c/1320130 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#606026}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5c8d3e17aba1..67f5c0ceac22 git log 5c8d3e17aba1..67f5c0ceac22 --date=short --no-merges --format='%ad %ae %s' 2018-11-07 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset 2018-11-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 6e8ec338eb25..825d344daa31 (1 commits) 2018-11-07 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-11-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 77b2436e28f4..1bf18ce9e2ca (2 commits) 2018-11-07 caryclark@skia.org fix paint docs 2018-11-07 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-11-07 mtklein@google.com remove SkScalarFastInvert Created with: gclient setdep -r src/third_party/skia@67f5c0ceac22 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@chromium.org Change-Id: I97247d038e1401a8fcf85457942ae47c77755515 Reviewed-on: https://chromium-review.googlesource.com/c/1322314Reviewed-by:
-
Sam McNally authored
For the first DriveFS, mount, mount_start_ is retained across mount attempts to record the total time taken to launch. When the DriveFS mount fails while offline, retries are delayed until online again. If a retry for the first launch is delayed in this fashion, the original start time is retained, causing spurious long first mount time metrics to be reported. Avoid this by clearing mount_start_ when delaying retries due to being offline. Clear it when disabling drive too. Bug: 892524 Change-Id: I47db55ca5b17965267ef813e2e70b7f7d90b662a Reviewed-on: https://chromium-review.googlesource.com/c/1322345Reviewed-by:
Sergei Datsenko <dats@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#606024}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2e9640bf..8eba77ea Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I76fbbf54027b9ba0cc9a1ddb115ac3ca1c849e76 Reviewed-on: https://chromium-review.googlesource.com/c/1322849Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606023}
-
philipel authored
Cleanup related to https://webrtc-review.googlesource.com/c/src/+/108861 Bug: webrtc:9946 Change-Id: I888142e2909a12232e7385edc1644d314ced7d10 Reviewed-on: https://chromium-review.googlesource.com/c/1317857 Commit-Queue: Philip Eliasson <philipel@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#606022}
-
David 'Digit' Turner authored
A bug matched the Filipino locale with the Finish language, which caused Chrome Canary, which uses bundles, to crash at load time when the device's locale is set to Finish. BUG=901837 R=benmason@chromium.org,yfriedman@chromium.org,tiborg@chromium.org,ajha@chromium.org Change-Id: Ib07f95e686bbae02cc2bd17c785818e03741042e Reviewed-on: https://chromium-review.googlesource.com/c/1317863Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#606021}
-
Stephane Zermatten authored
This change defines the following end states: - expected: a script is run that contains a stop action with a tell before. This leaves the message from the tell on the screen for 5s then shuts everything down. - expected: a script is run that contains a stop action with no tell before This shuts everything down immediately. - unexpected: navigation to another page, not triggered by a script - unexpected: back button - unexpected: new tab This shows a specific error message for 5s, before shutting everything down. - error: a script failed - error: we waited for a long time for scripts, but got nothnig. - error: there cannot be any runnable scripts on the current page, not even if the page changes. This shows the default error message for 5s, before shutting everything down. Bug: 806868 Change-Id: I9b6afd061705c3c9bd98694a696914c137397af5 Reviewed-on: https://chromium-review.googlesource.com/c/1311928 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#606020}
-
Anna Malova authored
Bug: 853793 Change-Id: I45aa3b2ad9729d26faa496f3e8fd522ef492d109 Reviewed-on: https://chromium-review.googlesource.com/c/1299146 Commit-Queue: Anna Malova <amalova@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#606019}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d8f7f3c91f72..0fc9f7540077 Created with: gclient setdep -r src-internal@0fc9f7540077 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I0d32959ac61bcd65c8a542cb012eda2025493dc7 Reviewed-on: https://chromium-review.googlesource.com/c/1322365Reviewed-by:
-
Gabriela Melchior authored
These tests should ensure that bounds are being checked for span functions and that these guarantees don't decay. R=palmer@chromium.org BUG=817982 Change-Id: Ief96bcc56a78187c615cbb15e906320290eafc59 Reviewed-on: https://chromium-review.googlesource.com/c/1317894Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Gabriela Melchior <gabimelchior@google.com> Cr-Commit-Position: refs/heads/master@{#606017}
-
Keishi Hattori authored
Converts Canvas* and Image* class allocations from new to MakeGarbageCollected. Bug: 757708 Change-Id: I0e324ba213af3ce3ab892bc8f1bf6d3712d6ead6 Reviewed-on: https://chromium-review.googlesource.com/c/1319652 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#606016}
-
Vaclav Brozek authored
This CL implements the part of the design https://goo.gl/Mc2KRe, which handles the situations when the autofill server marks two fields as usernames, and the parser needs to decide which is relevant. Bug: 895781 Change-Id: I37ef3bc55697c108b1761bf45e28deb9a20a2c1d Reviewed-on: https://chromium-review.googlesource.com/c/1318894Reviewed-by:
-
Camille Lamy authored
This CL updates the checks in NavigationControllerImpl::CreateNavigationRequestFromLoadParams so that we can distinguish which of the main frame vs subframe case is triggering. It also adds additional checks in FrameNavigationEntry url starts to diverge from the computed url_to_load. NavigationControllerImpl: :NavigateWithoutEntry to understand when the Bug: 896028 Change-Id: I4bf4fbb9e0dc668e88456181fae425c6cb79570a Reviewed-on: https://chromium-review.googlesource.com/c/1318978Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#606014}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4b49707cb5ca..4d2d5b4bbe38 git log 4b49707cb5ca..4d2d5b4bbe38 --date=short --no-merges --format='%ad %ae %s' 2018-11-07 lowell@google.com Fix unhelpful error when gn.py run in wrong directory. Created with: gclient setdep -r src/third_party/depot_tools@4d2d5b4bbe38 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I8854c0571e2b5bfdd0102b9730c6a568306a7712 Reviewed-on: https://chromium-review.googlesource.com/c/1322317Reviewed-by:
-
Rayan Kanso authored
The test is timing out on Android. More details in the bug. TBR=kylechar@chromium.org Bug: 902674 Change-Id: I080e46a5b15d1e4742793ce3ca4f992147a8b90a Reviewed-on: https://chromium-review.googlesource.com/c/1322830Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#606012}
-
Alexander Hendrich authored
This CL is a followup to 1296539 and fixes a TypeError in webRequestInternal.eventHandled() caused by this CL. onHeadersReceived_ previously only returned headers when they contained a SAML_HEADER, but the fix CL always returned all headers. Bug: 900950, 887061 Change-Id: Ic39e2bd6a98c6e2e3411812f7cd90310c32e1d3b Reviewed-on: https://chromium-review.googlesource.com/c/1314471Reviewed-by:
-
Fredrik Söderquist authored
Hopefully these tests are no longer flaky, but as a cautionary step, mark them as Pass/Fail for now and keep an eye on them. TBR=schenney@chromium.org Bug: 306222 Change-Id: Ia0e87564e2113dfaa50cd723654786805026924d Reviewed-on: https://chromium-review.googlesource.com/c/1322789Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#606010}
-
