- 07 Apr, 2017 40 commits
-
-
edchin authored
This CL enables the user to select a tab in the tab switcher and the new tab is reflected immediately in the currently open tab container. BUG=none Review-Url: https://codereview.chromium.org/2780423003 Cr-Commit-Position: refs/heads/master@{#462776}
-
foolip authored
BUG=708919 R=junov@chromium.org Review-Url: https://codereview.chromium.org/2799893002 Cr-Commit-Position: refs/heads/master@{#462775}
-
foolip authored
R=kbr@chromium.org BUG=706559 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2805013002 Cr-Commit-Position: refs/heads/master@{#462774}
-
fukino authored
This CL includes following changes: * Add |is_forcing_dircrypto| to UserContext to pass the configuration from ExistingUserController to CryptohomeAuthenticator. The flag affects MountParameter for MountEx API. * If a regular user signs in and ARC is available, ExistingUserController flips the flag to ensure that the cryptohome is encrypted in dircrypto. * Add a user-facing flag to enable the migration, since the backend of the migration procedure is not completely ready yet. * If a user choose "SKIP" in the migration screen, the screen handler let the user sign in by using previously-used UserContext and LoginPerformer, and dripping the |is_forcing_dircrypto| flag. BUG=706017 TEST=manually tested following cases on samus with ARC support. 1) Enable the flag in owner profile, create a cryptohome in ecryptfs, and sign in to the new profile. It showed migration screen. 2) Clicking "SKIP" on the screen shows the user's desktop. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2798023005 Cr-Commit-Position: refs/heads/master@{#462773}
-
leon.han authored
base::ScopedVector is deprecated, see bug. BUG=554289 Review-Url: https://codereview.chromium.org/2794263002 Cr-Commit-Position: refs/heads/master@{#462772}
-
patricialor authored
Remove unnecessary includes for ui/views/layout/layout_constants.h and do some refactoring to remove references to layout constants in ProfileSigninConfirmationDialogViews under chrome/browser/ui/views/sync/*. See https://drive.google.com/file/d/0BzEa5HU1aAqBOXBDazdRT245Wk0/view?usp=sharing for before/after screenshots of ProfileSigninConfirmationDialogViews. BUG=691897 Review-Url: https://codereview.chromium.org/2799163002 Cr-Commit-Position: refs/heads/master@{#462771}
-
pdfium-deps-roller authored
https://pdfium.googlesource.com/pdfium.git/+log/8a24b25ee0b0..4bb4029b1523 $ git log 8a24b25ee..4bb4029b1 --date=short --no-merges --format='%ad %ae %s' 2017-04-06 npm Use CFX_MaybeOwned on the buffer of CFX_DIBitmap 2017-04-06 palmer Fix unit tests to initialize PartitionAlloc. Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Review-Url: https://codereview.chromium.org/2806673002 Cr-Commit-Position: refs/heads/master@{#462770}
-
einbinder authored
When navigating with keyboard, focus would get stuck in the ConsolePrompt. BUG=706699 Review-Url: https://codereview.chromium.org/2802963002 Cr-Commit-Position: refs/heads/master@{#462769}
-
mgiuca authored
If the Origin Trial is disabled from a server config, the Mojo service will no longer be created. This prevents a compromised renderer from using the service, even after the API is shut down in the event of a security problem being discovered. BUG=703476 Review-Url: https://codereview.chromium.org/2799393003 Cr-Commit-Position: refs/heads/master@{#462768}
-
qyearsley authored
R=ecobos@igalia.com BUG=706118 Review-Url: https://codereview.chromium.org/2802063002 Cr-Commit-Position: refs/heads/master@{#462767}
-
ichikawa authored
WebState::CreateWithStorageSession(). Because it looks passing nil doesn't work. Alternatively I can update the code to make CreateWithStorageSession(params, nil) to be equivalent of Create(params) if you prefer. Background: I wrote code to expect that CreateWithStorageSession(params, nil) is equivalent of Create(params), resulted in a weird error. Review-Url: https://codereview.chromium.org/2802613005 Cr-Commit-Position: refs/heads/master@{#462766}
-
yhirano authored
It's not used by anyone. BUG=707371 Review-Url: https://codereview.chromium.org/2806663002 Cr-Commit-Position: refs/heads/master@{#462765}
-
bpastene authored
Also tweak the shards. BUG= Review-Url: https://codereview.chromium.org/2805163002 Cr-Commit-Position: refs/heads/master@{#462764}
-
yutak authored
This is essentially the result of the following shell command followed by git cl format: find . -type f -exec sed -i 's/"wtf\//"platform\/wtf\//g' {} \; DEPS is updated in order to prevent further introduction of "wtf/". BUG=691465 R=tsepez@chromium.org Review-Url: https://codereview.chromium.org/2803603004 Cr-Commit-Position: refs/heads/master@{#462763}
-
amaralp authored
Don't enable select all if the contenteditable has nothing to select. BUG= 696134 Review-Url: https://codereview.chromium.org/2787893004 Cr-Commit-Position: refs/heads/master@{#462762}
-
takise authored
This CL just adds a flags for zip archiver, a new chrome extension for files app. BUG=706851 Review-Url: https://codereview.chromium.org/2799233002 Cr-Commit-Position: refs/heads/master@{#462761}
-
zhongyi authored
base::MRUCache instead of std::map. No functional change. BUG=705029 Review-Url: https://codereview.chromium.org/2801533002 Cr-Commit-Position: refs/heads/master@{#462760}
-
jrummell authored
Relax the restrictions on the list of top-level boxes so that MP4 files are more reliably detected. BUG=709166 TEST=updated test passes Review-Url: https://codereview.chromium.org/2797133009 Cr-Commit-Position: refs/heads/master@{#462759}
-
kainino authored
https://crbug.com/682075#c17 for details. BUG=682075,707839 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2806623002 Cr-Commit-Position: refs/heads/master@{#462758}
-
mgiuca authored
I am looking at refactoring some code used by UpdateLanguageList and I found that it had no test case. Review-Url: https://codereview.chromium.org/2722413002 Cr-Commit-Position: refs/heads/master@{#462757}
-
caseq authored
- use symbols to map scripts and UISourceCodes to FormatData; - make FormatterScriptMapping independent on both debugger model and editor action; - make FormatData agnostic of source code type, just keep original and formatted source codes. Review-Url: https://codereview.chromium.org/2801543002 Cr-Commit-Position: refs/heads/master@{#462756}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/e650872309eb..f0fd0b23669d $ git log e65087230..f0fd0b236 --date=short --no-merges --format='%ad %ae %s' 2017-04-06 simonhatch Dashboard - Make update_test_suites use less memory. 2017-04-06 benjhayden Refactor histogram-set-view to an MVC pattern. 2017-04-06 eakuefner [Dashboard] Replace paper-progress with paper-spinner Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2798863006 Cr-Commit-Position: refs/heads/master@{#462755}
-
xunjieli authored
BUG=475060 Review-Url: https://codereview.chromium.org/2799113003 Cr-Commit-Position: refs/heads/master@{#462754}
-
wutao authored
For new added accelerators, we want to ensure it is search key based by adding the test. BUG=706018,706462 TEST=AcceleratorTableTest.CheckSearchBasedAccelerators Review-Url: https://codereview.chromium.org/2802583002 Cr-Commit-Position: refs/heads/master@{#462753}
-
khorimoto authored
[CrOS Tether] Refactor BleScanner so that it takes a BluetoothAdapter in its constructor instead of constructing it itself. The tether module will have a shared adapter passed to all classes which need it. BUG=672263 Review-Url: https://codereview.chromium.org/2803153002 Cr-Commit-Position: refs/heads/master@{#462752}
-
thomasanderson authored
BUG=676220 R=thestig@chromium.org,peter@chromium.org Review-Url: https://codereview.chromium.org/2803873003 Cr-Commit-Position: refs/heads/master@{#462751}
-
Daniel Cheng authored
BUG=676588 R=tkent@chromium.org Review-Url: https://codereview.chromium.org/2798293003 . Cr-Commit-Position: refs/heads/master@{#462750}
-
ntfschr authored
No logic change. This CL swaps "about:*" literals for the correct value in ContentUrlConstants. Review-Url: https://codereview.chromium.org/2803853006 Cr-Commit-Position: refs/heads/master@{#462749}
-
wkorman authored
In SPv1 we create cc layers for composited animations even if they paint no content. In SPv2, we only create cc layers when something is painted, a.k.a., there is a PaintChunk. This means that in SPv1 we could be assured that a composited animation that painted no content would still have a cc layer with the animation's compositor element id set on it, but in SPv2 such an animation will have no cc layer and accordingly it is impossible to run it as a composited animation. In SPv2, we choose to not composite such animations. To do otherwise would require: 1. code complexity to identify when this is the case, through a dummy PaintChunk or similar, and ensure that we create a cc layer even though there's nothing in need of painting. 2. compositor resource overhead to maintain a layer solely for the purpose of executing a composited animation even though it is not producing any visible content. BUG=692310 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2724083002 Cr-Commit-Position: refs/heads/master@{#462748}
-
khorimoto authored
[CrOS Tether] Make BluetoothThrottler a singleton which can be easily shared between EasyUnlock and tethering. BUG=672263 Review-Url: https://codereview.chromium.org/2805113002 Cr-Commit-Position: refs/heads/master@{#462747}
-
ksakamoto authored
If a script injection is cancelled (e.g. context destroyed before execution), ScriptInjectionCallback::willExecute() is not called but ::completed() is called. In such cases, execution time shouldn't be reported. BUG=708897 Review-Url: https://codereview.chromium.org/2797423002 Cr-Commit-Position: refs/heads/master@{#462746}
-
hansberry authored
BUG=672263 Review-Url: https://codereview.chromium.org/2781263004 Cr-Commit-Position: refs/heads/master@{#462745}
-
findit-for-me authored
Revert of Media Remoting: End to end integration tests. (patchset #4 id:120001 of https://codereview.chromium.org/2692593002/ ) Reason for revert: Findit identified CL at revision 462739 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzYwZDRlMGE2M2ViM2YyYmUyNmFjYTEyODFiZTI5YzY0YjBmNWM2NzAM Original issue's description: > Media Remoting: End to end integration tests. > > Add end to end integration tests for Media Remoting. Refactors > PipelineIntegrationTest to test both media and media remoting pipeline. > Re-use current tests. No new tests are added in this CL. > > BUG=684065 > > Review-Url: https://codereview.chromium.org/2692593002 > Cr-Commit-Position: refs/heads/master@{#462739} > Committed: https://chromium.googlesource.com/chromium/src/+/60d4e0a63eb3f2be26aca1281be29c64b0f5c670 TBR=miu@chromium.org,sandersd@chromium.org,xjz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=684065 Review-Url: https://codereview.chromium.org/2804183002 Cr-Commit-Position: refs/heads/master@{#462744}
-
chrome-cron authored
Cr-Commit-Position: refs/heads/master@{#462743}
-
ccameron authored
This was assuming that YUV to RGB conversion had been done if the output format was YUV, which is the opposite of what should be happening. Make the CHECK for extra YUV to RGB conversion happen always, by adding a "can ignore for testing" flag for the pixel tests that violate this assumption. BUG=709099 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2799603006 Cr-Commit-Position: refs/heads/master@{#462742}
-
tedchoc authored
The problem is that it was registering as a TabObserver but not removing itself. This moves the TabObserver logic into NewTabPage, which does handle proper clean up. BUG=708710 Review-Url: https://codereview.chromium.org/2803063003 Cr-Commit-Position: refs/heads/master@{#462741}
-
slangley authored
This is a continuation of other work to move CSS.*Value types to the nested namespace blink::cssvalue to avoid name collisions. I will be moving over type 2 or 3 at a time per CL. In some cases we need to temporarily introduce using statements while we're shuffling the classes around. These will be cleaned up once all types have been moved to blink::cssvalue. BUG=667961 Review-Url: https://codereview.chromium.org/2804673003 Cr-Commit-Position: refs/heads/master@{#462740}
-
xjz authored
Add end to end integration tests for Media Remoting. Refactors PipelineIntegrationTest to test both media and media remoting pipeline. Re-use current tests. No new tests are added in this CL. BUG=684065 Review-Url: https://codereview.chromium.org/2692593002 Cr-Commit-Position: refs/heads/master@{#462739}
-
jbauman authored
Ideally this should be YUY2, but we have a fallback to B8G8R8A8 and should check that it's being used at most very rarely. BUG=678800 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2799183002 Cr-Commit-Position: refs/heads/master@{#462738}
-
paulmiller authored
BUG=709208 Review-Url: https://codereview.chromium.org/2800013002 Cr-Commit-Position: refs/heads/master@{#462737}
-