- 17 Oct, 2018 40 commits
-
-
Ahmed Fakhry authored
Users of Chromevox may need to touch explore the webpage, and for things to remain consistent, we should disable hiding top-chrome with gesture scrolls as long as Chromevox is enabled. BUG=857331 TEST=Added a new browser test. Change-Id: Ic70ebcad475ea7885ea3b6bd826b9b1f08f03e1b Reviewed-on: https://chromium-review.googlesource.com/c/1284289Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#600408}
-
Adithya Srinivasan authored
This should make mojofying MidiHost and MidiMessageFilter easier. Bug: 582328 Change-Id: I4dfcdb990cd938a63ec99f238020bc6ba325350f Reviewed-on: https://chromium-review.googlesource.com/c/1244601Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#600407}
-
Jordan Demeulenaere authored
This is a reland of bb70008e Original change's description: > [Autofill Assistant] Add ShowProgressBar action. > > Screenshot: https://screenshot.googleplex.com/chZ1byvKBqa.png > > Bug: 806868 > Change-Id: Ib7714b1b554d030c461614bcd51cc30156cac594 > Reviewed-on: https://chromium-review.googlesource.com/c/1278808 > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Ganggui Tang <gogerald@chromium.org> > Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> > Cr-Commit-Position: refs/heads/master@{#600015} Bug: 806868 Change-Id: Ieb4d6c6305a155985fb3eabf80763d6d2e1b491d Reviewed-on: https://chromium-review.googlesource.com/c/1284929Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#600406}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a63809a3..db22e96f Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I570b3d36e3e84c8108986433655972ed6466ca21 Reviewed-on: https://chromium-review.googlesource.com/c/1286439Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600405}
-
Christian Biesinger authored
R=eae@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I8fa58c33fc9fab68edac7c8159254bfd8389560f Reviewed-on: https://chromium-review.googlesource.com/c/1285313 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#600404}
-
Lindsay Pasricha authored
ios12-beta-simulator ios12-sdk-device ios12-sdk-simulator Bug: 895976 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I48d0050afbe589bf5b2a9d02a4987f7bc244eb15 Reviewed-on: https://chromium-review.googlesource.com/c/1284732Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Cr-Commit-Position: refs/heads/master@{#600403}
-
Tibor Goldschwendt authored
This is a reland of 01e91776 with a fix for crbug/895206. Original change's description: > [bundles] Add getter for whether build is a bundle, activate O split fix > > Add BundleUtils class, which has a method to check whether current build > is a bundle. Use that getter to activate split APK - WebView workaround > for Android O. > > Bug: 889954 > Change-Id: I443584edf8bd55a6c7e2b5d0664dc943466159d4 > Reviewed-on: https://chromium-review.googlesource.com/c/1261969 > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Richard Coles <torne@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599509} TBR=torne@chromium.org Bug: 889954 Change-Id: If7cd717029bd8243d19ec212361e505340c3ce2d Reviewed-on: https://chromium-review.googlesource.com/c/1286420Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#600402}
-
Etienne Pierre-doray authored
This CL creates a feature experiment that removes blocking worker pools from the task scheduler. Tasks with MayBlock trait are instead posted to the usual foreground/background pool, giving us better control over scheduling. Note: ScopedBlockingCall is used to add extra workers to the pool when a task is blocking. In this CL, we take advantage of this behavior to make sure enough workers are running on the CPU. Bug: 874080 Change-Id: I7889a941f82203388c259b0d96073eb5ddf3de69 Reviewed-on: https://chromium-review.googlesource.com/c/1249836 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Robert Kaplow (sloooow) <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#600401}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0b8fcbcfa3d5..7bae65d0070c git log 0b8fcbcfa3d5..7bae65d0070c --date=short --no-merges --format='%ad %ae %s' 2018-10-17 caryclark@skia.org fix bookmaker 2018-10-17 kjlubick@google.com Revert "Re-enable NVPR on flutter." 2018-10-17 bsalomon@google.com Some cleanup of GrSwizzle 2018-10-17 brianosman@google.com Revert "Remove SK_LEGACY_XFORM_CANVAS_IN_PICTURE_IMAGES" 2018-10-17 kjlubick@google.com [canvaskit] POC working on Node.js 2018-10-17 caryclark@skia.org remove pathop template Created with: gclient setdep -r src/third_party/skia@7bae65d0070c The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=egdaniel@chromium.org Change-Id: I38da00e4418437853b657d55691144f102792120 Reviewed-on: https://chromium-review.googlesource.com/c/1286271Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600400}
-
iOS Autoroller authored
TBR=smut Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I2cabb859e83add6f24525bf8bde46cd9516a0c1a Reviewed-on: https://chromium-review.googlesource.com/c/1286729 Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Reviewed-by:
iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#600399}
-
Takuto Ikuta authored
The flag was added more than 5 years ago in https://chromium.googlesource.com/chromium/src/+/8338eeabe776455a934ccf099cac7bd87fa57588 But current clang does not enable the warning by default. ref: http://llvm.org/viewvc/llvm-project?view=revision&revision=150055 Change-Id: I7580d77954f2a9cdef047af6b181d35ee6721a9e Reviewed-on: https://chromium-review.googlesource.com/c/1286609 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#600398}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/91f54792a979..5146376782a1 git log 91f54792a979..5146376782a1 --date=short --no-merges --format='%ad %ae %s' 2018-10-17 hjd@google.com Merge "perfetto-ui: Fix doubled tracks when reloading from permalinks" 2018-10-17 hjd@google.com Merge "perfetto-ui: Record page improvements" Created with: gclient setdep -r src/third_party/perfetto@5146376782a1 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ide01097024bcabaac41c851f5fc1b8633c34d729 Reviewed-on: https://chromium-review.googlesource.com/c/1286473Reviewed-by:
-
Daniel Cheng authored
Bug: 891908 Change-Id: I56c0feb3b4a92232a93271f8097fc56e5703e1b6 Reviewed-on: https://chromium-review.googlesource.com/c/1286292Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#600396}
-
Joshua Bell authored
Add test variants to ensure that various storage types are deleted via the browsing data remover code in Incognito sessions. Bug: 876659 Change-Id: Iad59adf8e7b07e2261257f2fbbfb43b3e31c5851 Reviewed-on: https://chromium-review.googlesource.com/c/1285071Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#600395}
-
Scott Violet authored
This makes it easier to attach state to an individual event being processed. BUG=891489 TEST=covered by tests Change-Id: I50f70567d195c60187c9c8e8a2a68255c4c47f08 Reviewed-on: https://chromium-review.googlesource.com/c/1282031Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#600394}
-
Etienne Bergeron authored
This CL is adding a metric to collect metric on the fallback fonts issue. Slow-reports show that many bad cases (99th percentile) of different heartbeat metrics are affected by: gfx::GetFallbackFonts(gfx::Font const &) gfx::RenderTextHarfBuzz::ShapeRuns(std::basic_string<wchar_t,std::char_traits<wchar_t>,std::allocator<wchar_t> > const &,gfx::internal::TextRunHarfBuzz::FontParams const &,std::vector<gfx::internal::TextRunHarfBuzz *,std::allocator<gfx::internal::TextRunHarfBuzz *> >) gfx::RenderTextHarfBuzz::ItemizeAndShapeText(std::basic_string<wchar_t,std::char_traits<wchar_t>,std::allocator<wchar_t> > const &,gfx::internal::TextRunList *) gfx::RenderTextHarfBuzz::EnsureLayoutRunList() This UMA metric will help us to estimate the size of the population affected by this scenario. R=fdoray@chromium.org, holte@chromium.org, ccameron@chromium.org Bug: 894459 Change-Id: Ic0d1fac1f69a329bf11544f49e34c91635046331 Reviewed-on: https://chromium-review.googlesource.com/c/1281227Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#600393}
-
Etienne Pierre-doray authored
This CL uses ScopedBlockingCall to mark blocking calls in /chrome/browser/extensions/api. This CL was created by replacing calls to AssertBlockingAllowed() with instantiations of ScopedBlockingCall(MAY_BLOCK). I kindly ask the reviewer to make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation: MAY_BLOCK: The call might block (e.g. file I/O that might hit in memory cache). WILL_BLOCK: The call will definitely block (e.g. cache already checked and now pinging server synchronously). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). This CL was uploaded by git cl split. R=tbarzic@chromium.org Bug: 874080 Change-Id: I2d289daff2684837a6be032e5ca1e5acf37ad3cf Reviewed-on: https://chromium-review.googlesource.com/c/1194105 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#600392}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4744e5b896a5..5a464d3ee56a git log 4744e5b896a5..5a464d3ee56a --date=short --no-merges --format='%ad %ae %s' 2018-10-17 danilchap@webrtc.org Add resolution to generic frame descriptor extension Created with: gclient setdep -r src/third_party/webrtc@5a464d3ee56a The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I289152f6b317197a530715de3ffab0fccb01a998 Reviewed-on: https://chromium-review.googlesource.com/c/1286215Reviewed-by:
-
Marc Treib authored
This resolves a 7-year-old TODO in sync_prefs.h :) Bug: none Change-Id: I5d337ee116e8fbce60758b0c23fdd70be19a8d60 Reviewed-on: https://chromium-review.googlesource.com/c/1286417 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#600390}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4e423c45bcbb..15255d3e71b1 Created with: gclient setdep -r src-internal@15255d3e71b1 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ife15752f95e14928fce33366231a228f4616fa85 Reviewed-on: https://chromium-review.googlesource.com/c/1286691Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600389}
-
Brian Osman authored
This is a reland of 530a1ad5 The CL was reverted by the sheriff with https://chromium-review.googlesource.com/c/1286465 but this resulted in even more failures TBR=fmalita@chromium.org,brianosman@google.com,mtklein@chromium.org Bug: 896205 Original change's description: > Stop using color space xform canvas in Skia's picture backed images > > Change-Id: Ia77210022ac412d00be1fc2f8831eb973e07de62 > Reviewed-on: https://chromium-review.googlesource.com/c/1280786 > Reviewed-by: Mike Klein <mtklein@chromium.org> > Commit-Queue: Brian Osman <brianosman@google.com> > Cr-Commit-Position: refs/heads/master@{#599979} No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic5fe8658f90f4688833d567b04d3026929ae55bf Reviewed-on: https://chromium-review.googlesource.com/c/1286655Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#600388}
-
Jonathan Backer authored
With OOP-D, we no longer have draw call pressure inducing flushes. https://crbug.com/c/875319 suggests that there are cases where we reuse tiles enough in the UI compositor that we never hit the unused_resources_.empty() condition in the EvictExpiredResource method. This CL adds a deadline for the flush, so that we wait at most 1 second. Bug: 875319 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ifa8d516699be7ae1eff47db01f8be55a0aae92c8 Reviewed-on: https://chromium-review.googlesource.com/c/1284435 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#600387}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/190645c34266..b01628451a54 git log 190645c34266..b01628451a54 --date=short --no-merges --format='%ad %ae %s' 2018-10-17 thestig@chromium.org Do more selection checks in form fill embedder tests Created with: gclient setdep -r src/third_party/pdfium@b01628451a54 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I1ad8dbf11b252ed61c054d5ab51d11cb67e6cfa9 Reviewed-on: https://chromium-review.googlesource.com/c/1286214Reviewed-by:
-
Fan Yang authored
In QUIC, on server side, when a session is created, only a single version is provided to the connection and received packets with mismatched version will be dropped. Protected by FLAGS_quic_restart_flag_quic_no_server_conn_ver_negotiation. Merge internal change: 215728318 R=rch@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I3fbc8e96393424539ebdb8996ce6cde422646ddb Reviewed-on: https://chromium-review.googlesource.com/c/1283831 Commit-Queue: Fan Yang <fayang@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#600385}
-
Daniel Cheng authored
- Update more scoped enums to use kMaxValue instead of defining a dummy COUNT enumerator. - Update more UMA enumeration histograms to use the two-argument version of the macro, which autodeduces the boundary value. - Use base::UmaHistogram* where appropriate instead of manually expanding the corresponding macros. Bug: 742517, 857134 Change-Id: I0feb837ecb41a780c8d3234e9d2e75c23229a24b Reviewed-on: https://chromium-review.googlesource.com/c/1283250 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#600384}
-
Justin Cohen authored
Move self.showing update from -viewDidAppear to -viewWillAppear. Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I2be12224f8ac9156f16c87665aa22a84c221bf1d Reviewed-on: https://chromium-review.googlesource.com/c/1283832Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#600383}
-
Valeriya Sinevich authored
Extracting refresh token from iOS seems to require more effort, don't know if it is worth it. Change-Id: Iff6fd7d1f694785d60d9c5d6fde026a088e2625b Reviewed-on: https://chromium-review.googlesource.com/c/1257930 Commit-Queue: Valeriya Sinevich <valeriyas@google.com> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#600382}
-
Lukasz Suder authored
If none of the scripts within the set of runnable have initialPrompt (all of them are empty), then we shouldn't clean the current status message. Usually in the chain of Scripts that form an execution path, only the first Script contains the status message. Next scripts don't, and the assumption is that the previous status message should stay as long as it is not explicitly changed by next tell action. Bug: 806868 Change-Id: I4431c2b33db83ec3bdbc2f8fb71096cc8b4a3149 Reviewed-on: https://chromium-review.googlesource.com/c/1283610Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Lukasz Suder <lsuder@google.com> Cr-Commit-Position: refs/heads/master@{#600381}
-
Leszek Swirski authored
Decrease scheduler flakes of layout tests which can incorrectly infer console message line numbers depending on execution scheduling. Do this by ignoring line numbers of console messages which do not have an associated discovered source file. Bug: 894792 Bug: 894795 Bug: 896194 Change-Id: Ic8565ba7ac4a2e036f9d333c319544efdc8a3601 Reviewed-on: https://chromium-review.googlesource.com/c/1283037 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#600380}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/483536c242f3..0b8fcbcfa3d5 git log 483536c242f3..0b8fcbcfa3d5 --date=short --no-merges --format='%ad %ae %s' 2018-10-17 scroggo@google.com Add fuzzers for SkAndroidCodec & incrementalDecode Created with: gclient setdep -r src/third_party/skia@0b8fcbcfa3d5 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=egdaniel@chromium.org Change-Id: Idc0680878c5771580534f0c80d151f2e7327cbe9 Reviewed-on: https://chromium-review.googlesource.com/c/1286629Reviewed-by:
-
Anna Malova authored
Bug: 885099 Change-Id: I3685726603ae9ba050d1316d227a0a8f77d3e3cc Reviewed-on: https://chromium-review.googlesource.com/c/1283257 Commit-Queue: Anna Malova <amalova@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#600378}
-
Adithya Srinivasan authored
This behavior was accidentally lost when onion souping and caused a memory leak. Bug: 891018, 787281 Change-Id: Ib41155660b72548582f809e75c7ca3c596234b65 Reviewed-on: https://chromium-review.googlesource.com/c/1284391Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#600377}
-
Christos Froussios authored
This reverts commit 6f65bd26. Reason for revert: Speculative revert Suspected of breaking browser_tests, ebui_polymer2_browser_tests, single_process_mash_browser_tests and viz_browser_tests on Linux ChromiumOS MSan Note: resolved conflicts with ES6 refactoring, therefore running tests... Bug: 896219 Original change's description: > Files app: Select My files when there are no volumes > > Make Files app select "My files" when there are no available volumes, > this to allow Files app to behave properly when volumes subsequently > become available. > > Change DirectoryModel.onVolumeInfoListUpdated_ method to check for > non-null |displayRoot| before trying to change to |displayRoot|. This > fixes the error "Cannot read property 'getParent' of null" when Drive > volume becomes available before the (default) Downloads volume/root. > > Change FakeDriveFs to unbind the two mojo bindings if they're bound, so > DriveFsTestVolume can re-mount itself. > > Changes since revert: > 1. Add a new function |getVolumesCount| to return the number of volumes > available in the background page. > 2. Add the new function above to wait for background page to have all > volumes before un-mounting and wait it to unmount all volumes. > 3. Change some logs from error to warn because errors are expected and > handled when initializing volumes that are unmounting/unmounted in the > backend. > 4. Change selector used to click on Drive to actually wait for > "My Drive" to be available. > 5. A bit of more info in some logs around volume initialization. > > Test: browser_tests --gtest_filter="*/fileDisplayWithoutVolumesThenMount*" > Bug: 893161, 884967, 894799 > Change-Id: I7dcb340991750e9e79a9963990b614c6d7275890 > Reviewed-on: https://chromium-review.googlesource.com/c/1278619 > Reviewed-by: Noel Gordon <noel@chromium.org> > Reviewed-by: Sam McNally <sammc@chromium.org> > Commit-Queue: Luciano Pacheco <lucmult@chromium.org> > Cr-Commit-Position: refs/heads/master@{#600282} TBR=noel@chromium.org,sammc@chromium.org,lucmult@chromium.org Change-Id: Ifaadea8b49cffc6deb70b429a42bab39d4a3d52b Bug: 893161, 884967, 894799 Reviewed-on: https://chromium-review.googlesource.com/c/1286146 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
-
Vitaliy Kharin authored
liblcang 6.0 chokes on -march=armv7-a with a message "ClangParseError: Failed to parse the translation unit." In this CL flag '-march' is filtered off for all arm architectures. Change-Id: I6d7074c7b337b0a07633d728d0779ec3559652fa Reviewed-on: https://chromium-review.googlesource.com/c/1278633 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#600375}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/deda0b4d..a63809a3 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia9231153a6f3d775bb957c486d1e8441ed47f653 Reviewed-on: https://chromium-review.googlesource.com/c/1286436Reviewed-by:
-
Patrik Höglund authored
Let's try adding these from the recipes while we figure out a better solution. Tbr: kbr@chromium.org Bug: 888429 Change-Id: I1a3c8c4a7ba326dbcb2c4c3058a0f3272198ab0d Reviewed-on: https://chromium-review.googlesource.com/c/1286134Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#600373}
-
Markus Heintz authored
It's been way to long since I touched that code. :-( Bug: NA Change-Id: Ib56da5e0b1a44782bd5833047cf3824c5b244e43 Reviewed-on: https://chromium-review.googlesource.com/c/1283752Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Markus Heintz <markusheintz@chromium.org> Cr-Commit-Position: refs/heads/master@{#600372}
-
Kamila authored
Changed "Allow third-party cookies" (default-checked), to "Block third-party cookies" (default-unchecked) in Android, to match the Desktop option. "Block..." language was chosen, due to expressing direct intent of the user using this option. Link to the slides where this bug was discussed (s6): https://docs.google.com/presentation/d/1ZFtyGpfeZxCIXPYftwyvB5pnOiGhMJenDX3KbDbyINQ/edit?usp=sharing Bug:882382 Change-Id: I05339306646e0f50b5cb50628a8fb93465a80f1e Reviewed-on: https://chromium-review.googlesource.com/c/1238461 Commit-Queue: Kamila Hasanbega <hkamila@google.com> Reviewed-by:
-
Daniel Cheng authored
Bug: 891908 Change-Id: If954e2ea4309578b50d987db8a7ce4db31845057 Reviewed-on: https://chromium-review.googlesource.com/c/1283251Reviewed-by:
-
Jeremy Roman authored
bindings: Drop use of V8CallBoolean in generated dictionary code in favor of a lambda that uses v8::MaybeLocal::To. Bug: 670615 Change-Id: Ib4f1b5674cec44a328b484510b4b197b2afec21d Reviewed-on: https://chromium-review.googlesource.com/c/1281087 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
-
