- 04 May, 2017 40 commits
-
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/cf53b788ca1c..d41f4752c81d $ git log cf53b788c..d41f4752c --date=short --no-merges --format='%ad %ae %s' 2017-05-04 dsinclair Remove unused IFX_Pause member 2017-05-04 thestig Mention pdfium_all target in README.md. 2017-05-04 npm Fix undefined shift in opj_get_all_encoding_parameters Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: Iaebce2e41bf2d1afe065f38102647a2e25985ddd Reviewed-on: https://chromium-review.googlesource.com/496646 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#469486}
-
jbudorick authored
Android GN builds have been unable to build raw "unit_tests" as a target, instead relying on unit_tests_apk or chrome/test:unit_tests. Linux builds, in contrast, can do so without issue. I had thought that the issue was that a "unit_tests" gn target in another directory was preventing gn from creating a top-level alias. While this may be true, it's not the reason for the discrepancy between Android and Linux builds. Instead, the difference is that Linux builds create a unit_tests executable in the top-level output directory, while Android builds create an APK and a wrapper script in child directories. This CL writes an additional wrapper script for gtest targets on Android in the top-level directory that matches the suite's output_name (usually its target name), allowing us to successfully build raw "unit_tests" on Android. As a bonus, we can now run $ out/Release/unit_tests (etc) on Android. BUG=716117 Review-Url: https://codereview.chromium.org/2851523002 Cr-Commit-Position: refs/heads/master@{#469485}
-
yusufo authored
Adds a more generic call to the helper delegate and calls out to the LocaleManager. Then LocaleManager does the actual search engine setting and any other potential fallout of the search engine choice. BUG=712836, 712833 Review-Url: https://codereview.chromium.org/2860643003 Cr-Commit-Position: refs/heads/master@{#469484}
-
ctzsm authored
"paste as plain text" introduced an empty option in selection menu due to the runtime string resource setting. Since we need to update |canEditRichly| flag for the option in selection menu, there is no simple way to do so right now, so simply remove this option. Need to add it back later. BUG=718330 Review-Url: https://codereview.chromium.org/2858333002 Cr-Commit-Position: refs/heads/master@{#469483}
-
fsamuel authored
A child surface ID is either a dependency (something the parents wants to block its CompositorFrame on and may not exist in the display compositor yet) or a reference (it is known to exist in the display compositor). Dependencies are held in CompositorFrameMetadata::embedded_surfaces, and references are held in CompositorFrameMetadata::referenced_surfaces. It was possible for a surface ID to end up in both places if the primary and fallback SurfaceInfos in a SurfaceLayer matched. This causes issues in an upcoming CL https://codereview.chromium.org/2831213004/ that "closes" an old fallback surface to receiving new CompositorFrames if a new primary surface is being requested by a parent to reduce latency. BUG=672962, 711948 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2861593002 Cr-Commit-Position: refs/heads/master@{#469482}
-
mfomitchev authored
Now that renderer Compositor Frames go through SurfaceFactory, we don't need to log DISPLAY_COMPOSITOR_RECEIVED_FRAME_COMPONENT in RenderWidgetHostLatencyTracker. BUG=NONE CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2863503002 Cr-Commit-Position: refs/heads/master@{#469481}
-
mohsen authored
When a HoverHighlightView needs to be repopulated, other than removing its children, the pointers it has to its children should be nulled out, too. Otherwise, it would try to reuse them causing crashes. This CL adds a Reset() function to HoverHighlightView that properly resets the state of HoverHighlightView before re-populating it. BUG=718411 TEST=none Review-Url: https://codereview.chromium.org/2865533002 Cr-Commit-Position: refs/heads/master@{#469480}
-
robhogan authored
Even if an image is smaller than the broken image icon it still needs to render as a replaced element per https://html.spec.whatwg.org/multipage/rendering.html#images-3. So do that, but ensure the broken image icon is hidden and don't render it with a border or any other decoration. BUG=715535 Review-Url: https://codereview.chromium.org/2853733004 Cr-Commit-Position: refs/heads/master@{#469479}
-
ccameron authored
Change this to match ColorMediaFeatureEval's behavior. Previously, this was incorrectly comparing the monochrome feature against color bit depth. BUG=645697 Review-Url: https://codereview.chromium.org/2863603002 Cr-Commit-Position: refs/heads/master@{#469478}
-
vadimt authored
Launcher_ClickOnAppListButton is generated both on launcher start and closing. Replaced (in sequencer) with Launcher_Show (new) and Launcher_Dismiss (see prev CL) pair. Bug=712331 Review-Url: https://codereview.chromium.org/2854283005 Cr-Commit-Position: refs/heads/master@{#469477}
-
fsamuel authored
SurfaceDependencies is a type alias that was introduced in PendingFrameObserver but is not used consistently making understanding types more difficult. This CL simplify removes the type alias. BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2861713003 Cr-Commit-Position: refs/heads/master@{#469476}
-
cbiesinger authored
The functions are practically identical and this can be better handled with an if statement. R=jfernandez@igalia.com Review-Url: https://codereview.chromium.org/2829303002 Cr-Commit-Position: refs/heads/master@{#469475}
-
juliatuttle authored
Reporting is a spec for delivering out-of-band reports from various other parts of the browser. See http://wicg.github.io/reporting/ for the spec, or https://goo.gl/pygX5I for details of the planned implementation in Chromium. This CL plumbs from Chromium's browsing data removal code to Reporting (and also makes a few tweaks to Reporting's browsing data removal). BUG=704259 Review-Url: https://codereview.chromium.org/2829683004 Cr-Commit-Position: refs/heads/master@{#469474}
-
acondor authored
BUG= Review-Url: https://codereview.chromium.org/2863733002 Cr-Commit-Position: refs/heads/master@{#469473}
-
rjkroege authored
Added crashing layout tests. BUG=717019 TBR=ethannicholas@chromium.org Review-Url: https://codereview.chromium.org/2862913003 Cr-Commit-Position: refs/heads/master@{#469472}
-
ortuno authored
Follow up of http://crrev.com/2853433002 that removes fake c++ adapters that are no longer used. Review-Url: https://codereview.chromium.org/2856093002 Cr-Commit-Position: refs/heads/master@{#469471}
-
robliao authored
This reverts commit f07732ec (https://codereview.chromium.org/2791933004) and reapplies b6d0c9a0 (https://codereview.chromium.org/2690183002/). BUG=653916 TBR=jam@chromium.org, rkaplow@chromium.org Previously reviewed at https://codereview.chromium.org/2690183002/ Review-Url: https://codereview.chromium.org/2856583002 Cr-Original-Commit-Position: refs/heads/master@{#468376} Committed: https://chromium.googlesource.com/chromium/src/+/3e27cb6e501ae55d614b56d566487590518ec223 Review-Url: https://codereview.chromium.org/2856583002 Cr-Commit-Position: refs/heads/master@{#469470}
-
kqyang authored
BUG=715161 TEST=Manually tested with SRC/MSE playback (then checked about:://histograms) Review-Url: https://codereview.chromium.org/2846693002 Cr-Commit-Position: refs/heads/master@{#469469}
-
jbauman authored
Modify ScheduleDCLayers command to take an array of textures. This will allow using NV12 shared-memory GpuMemoryBuffers, which will have separate Y and UV GLImages. BUG=716286 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2849743002 Cr-Commit-Position: refs/heads/master@{#469468}
-
ynovikov authored
deqp/functional/gles3/multisample.html flakiness is supposed to be fixed by https://codereview.chromium.org/2857953002/ BUG=714207 TBR=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2856403003 Cr-Commit-Position: refs/heads/master@{#469467}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/59ad782b2b05..18f9602094ac $ git log 59ad782b2..18f960209 --date=short --no-merges --format='%ad %ae %s' 2017-05-04 egdaniel Add support for Geom shaders in Vulkan backend. 2017-05-04 herb Factor out common code from sweep and linear. 2017-05-04 jvanverth Add ShadowUtils sample. 2017-05-04 benjaminwagner Marker for Windows NVIDIA driver update. Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: Ide81efd89d01095d7389948976ed2b95afbb2722 Reviewed-on: https://chromium-review.googlesource.com/496546Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#469466}
-
paulmeyer authored
BUG=710486 TBR=wjmaclean@chromium.org Review-Url: https://codereview.chromium.org/2863633003 Cr-Commit-Position: refs/heads/master@{#469465}
-
ericrk authored
Currently, mask SINGLE_TEXTURE_MASK UVs are determined solely by the size of the masked layer. This means that if the mask texture size does not match the expected texture size, we will end up squishing the mask when it's applied. This CL adds a new out param, |resource_uv_size| to GetContentsResourceId. This param represents the UV coordinate size of the mask contents within its texture. This factor is used to adjust the existing calculation, allowing for non-exact mask texture sizes. R=sunxd@chromium.org, enne@chromium.org BUG=713872 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2828353003 Cr-Commit-Position: refs/heads/master@{#469464}
-
dahollings authored
This cl merges server change 154325175 by yasong. BUG=488484 Review-Url: https://codereview.chromium.org/2861893002 Cr-Commit-Position: refs/heads/master@{#469463}
-
thomasanderson authored
BUG=676220 R=peter@chromium.org CC=thestig@chromium.org Review-Url: https://codereview.chromium.org/2857293002 Cr-Commit-Position: refs/heads/master@{#469462}
-
robliao authored
In production, FileDescriptorWatchers can be leaky and post BLOCK_SHUTDOWN tasks in response to their notification. Stopping the service thread requires some non-trivial task lifetime fixes to do it correctly, so this was deemed the next best quick fix for redirection. BUG=717380 Review-Url: https://codereview.chromium.org/2857103005 Cr-Commit-Position: refs/heads/master@{#469461}
-
meacer authored
The flakes are from 2011 and don't seem to happen on local runs. Deflake the test. BUG=368280,92292 Review-Url: https://codereview.chromium.org/2865503002 Cr-Commit-Position: refs/heads/master@{#469460}
-
anthonyvd authored
BUG=714691 Review-Url: https://codereview.chromium.org/2866443002 Cr-Commit-Position: refs/heads/master@{#469459}
-
jlebel authored
Adding NOTIMPLEMENTED() to BluetoothLowEnergyDeviceMac::IsConnectable() and removing BluetoothLowEnergyDeviceMac::connectable_. BUG= Review-Url: https://codereview.chromium.org/2854733002 Cr-Commit-Position: refs/heads/master@{#469458}
-
jlebel authored
This patch is to fix this scenario: * Device: DidModifyServices notification - Chrome: Scan for primary services * Device: DidDiscoverServices - Chrome: Scan for characteristics * Device: DidModifyServices notification - Chrome: Scan for primary services * Device: DidDiscoverCharacteristics * Device: DidDiscoverServices - Chrome: Scan for characteristics * Device: DidDiscoverCharacteristics We need to wait until all the pending characteristic discoveries are done until we can start scanning for descriptors. We need to make sure descriptors are not ready if DidModifyServices notification is received while scanning for descriptors. Adding discovery_pending_count_ in BluetoothRemoteGattServiceMac and BluetoothRemoteGattCharacteristicMac. |is_discovery_complete_| can be set to true when discovery_pending_count_ is equal to 0. BUG=690204 Review-Url: https://codereview.chromium.org/2638653002 Cr-Commit-Position: refs/heads/master@{#469457}
-
rbpotter authored
chrome/browser/resources/print_preview/settings/* After this CL, there are 2 warnings and 222 errors when running the closure compiler. BUG=717620 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2861713004 Cr-Commit-Position: refs/heads/master@{#469456}
-
bpastene authored
TBR=jbudorick@chromium.org BUG= Review-Url: https://codereview.chromium.org/2856123005 Cr-Commit-Position: refs/heads/master@{#469455}
-
juncai authored
This CL adds device_chooser watchlist. BUG=None Review-Url: https://codereview.chromium.org/2860153002 Cr-Commit-Position: refs/heads/master@{#469454}
-
thestig authored
Also use existing values from chrome/common/url_constants.h. Review-Url: https://codereview.chromium.org/2855423002 Cr-Commit-Position: refs/heads/master@{#469453}
-
jcivelli authored
In preparation for making the ChildProcessConnection simpler, removing the service number member from BaseChildProcessConnection. It is pertaining to the allocator, not the connection. Also replaced the LruCache used for the moderate binding pool in BindingManagerImpl (which was relying on the service number from the connection) with a LinkedList. It makes the code clearer since we were only using the LruCache to evict old connections, not the cache part. BUG=689758 Review-Url: https://codereview.chromium.org/2855323003 Cr-Commit-Position: refs/heads/master@{#469452}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/dcefccc9f0f2..cf53b788ca1c $ git log dcefccc9f..cf53b788c --date=short --no-merges --format='%ad %ae %s' 2017-05-04 dsinclair Cleanup CXFA_RenderContext 2017-05-04 dsinclair Cleanup CFX_CharMap 2017-05-04 tsepez Remove CFX_GlyphMap Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: Ie4bc9e9977e2df14968ad260bb8e37b892c40b37 Reviewed-on: https://chromium-review.googlesource.com/495498 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#469451}
-
danakj authored
Raster can be done on multiple threads at once, so it is not okay to mutate a PaintOp while doing raster. This fixes the case of RasterWithAlpha needing to change the PaintFlags back to having it make a copy. To do this, we add a RasterWithFlags() static method to each subclass of PaintOpWithFlags, and call that directly with the modified flags when needed. These subclasses still need to provide a Raster() method which just passes the |flags| member thru to the RasterWithFlags(). Before MonochromePublic.apk: 79,762,639 bytes After MonochromePublic.apk: 79,762,639 bytes R=enne@chromium.org BUG=718309 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2863673002 Cr-Commit-Position: refs/heads/master@{#469450}
-
trchen authored
Prior to this CL, the behavior of GeometryMapper version and non-GM version of PaintLayerClipper was inconsistent with kIgnoreOverflowClip when both CSS clip and overflow clip present on the painting root. | CSS clip | Overflow clip | Both -------+----------+---------------+-------- GM | Applied | Skipped | Skipped Non-GM | Applied | Skipped | Applied Also the GM-version applies only CSS clip when both present and context.root_layer == layer_. (While non-GM applies both) This CL changes the behavior so that both CSS clip and overflow clip are ignored whether both or either one present. It is believed that it will also fix a bug that prevented us from enabling impl-side scrolling on scrollers that has CSS clip. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2856373002 Cr-Commit-Position: refs/heads/master@{#469449}
-
yzshen authored
BUG=None Review-Url: https://codereview.chromium.org/2855303003 Cr-Commit-Position: refs/heads/master@{#469448}
-
sebsg authored
Plug in the JourneyLogger on the Desktop code and use it to record CanMakePayment metrics. BUG=716483 Review-Url: https://codereview.chromium.org/2851893002 Cr-Commit-Position: refs/heads/master@{#469447}
-