GitLab

Crash dumps are unclear and the issue seems resolved on Pixel hardware,
but some earlier stack traces suggest we're getting a null TaskRunner
when attempting to BindToCurrentLoop during CreateCodec(). As such
move binding to a known good thread.

This should be reverted if the issue is not fixed. If it is fixed
there's additional work to be done to understand the consequences
of CreateCodec() being called on an unexpected thread.

BUG=873094
TEST=none

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I2928d7866c1f40de63f526ee7393d2d8b90884f2
Reviewed-on: https://chromium-review.googlesource.com/1175092Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583067}

This caps these devices support for hardware decoding to 1080p.

BUG=873996
TEST=none

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I4b640cf8537a33518d06994d9aaeac772e428b8e
Reviewed-on: https://chromium-review.googlesource.com/1175095
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583066}

Use network quality tracker instead of network quality estimator (NQE)
to obtain network quality in data reduction proxy component.

Network quality tracker can provide network service when network
service is enabled as well as when network service is disabled.

data_reduction_proxy_service.h receives network quality
estimates on UI thread from network quality tracker.
On receiving estimates, it posts them to d_r_p_io_data
which lives on IO thread, and consumes the estimates.

PS#2 is the original CL that got reverted.

Bug: 819244
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Id9f28abaea42a7eb55dd3647c88d13a427a4e5ae
TBR: xunjieli@chromium.org, sky@chromium.org, ryansturm@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1174698
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583065}

Bug: 866941
Change-Id: I1c5a6a8117eb347dbe838ae1818e726ff1dafcb7
Reviewed-on: https://chromium-review.googlesource.com/1175062Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583064}

This reverts commit 562c52f7.

Reason for revert: cc_unittests failing on Linux TSan:

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20TSan%20Tests/24797

[ RUN      ] LayerTreeHostTilesTestPartialInvalidation.PartialRaster_SingleThread_OneCopy
[22487:22487:0814/143420.957209:26522082454:ERROR:pixel_comparator.cc(47)] Number of pixel with an error: 30000
[22487:22487:0814/143420.957442:26522082676:ERROR:pixel_comparator.cc(48)] Error Bounding Box : 0,0 200x200
[22487:22487:0814/143421.140401:26522265659:ERROR:pixel_test_utils.cc(79)] Pixels do not match!
[22487:22487:0814/143421.140586:26522265816:ERROR:pixel_test_utils.cc(80)] Actual: data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAMgAAADICAYAAACtWK6eAAACHUlEQVR4nO3VMRHAMBADwXf4ozUBh0DmWqfYRaDmRmvvOQN8em4PgD8TCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQFgz+9weAX/lQSAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAILygpAZjjfRdXgAAAABJRU5ErkJggg==
[22487:22487:0814/143421.140737:26522266017:ERROR:pixel_test_utils.cc(81)] Expected: data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAMgAAADICAIAAAAiOjnJAAACNklEQVR4nO3dsQ0DMQwEQb3hWP3XqQrcgEMvnm/MVMBgwfSutc6CX3vdfQD/SVgkhEVCWCSERUJYJIRFQlgkhEVCWCSERUJYJIRFQlgkhEVCWCSERUJYJIRFQlgkhEVCWCSERUJYJIRFQlgkhEVCWCSERUJYJIRFQlgkhEVCWCSERUJYJIRFQlgkhEVCWCSERUJYJIRFQlgkhEVCWCSERUJYJIRF4n33Ad+ds+8+4TH2nriR62OREBYJYZEQFglhkRAWCWGREBYJYZEQFglhkRAWCWGREBYJYZEQFglhkRAWCWGREBYJYZEQFglhkRAWCWGREBYJYZEQFglhkRAWCWGREBYJYZEQFglhkRAWCWGREBYJYZEQFglhkRAWCWGREBYJYZEQFglhkRAWCWGRuM7Eec6hq6EzzVyj9bFICIuEsEgIi4SwSAiLhLBICIuEsEgIi4SwSAiLhLBICIuEsEgIi4SwSAiLhLBICIuEsEgIi4SwSAiLhLBICIuEsEgIi4SwSAiLhLBICIuEsEgIi4SwSAiLhLBICIuEsEgIi4SwSAiLhLBICIuEsEgIi4SwSAiLhLBIDF1Y5el8LBLCIiEsEsIiISwSwiIhLBLCIiEsEsIiISwSwiIhLBLCIiEsEsIiISwSwiIhLBLCIiEsEsIiISwSwiIhLBLCIiEsEsIiISwSwiIhLBLCIiEsEsIiISwSwiIhLBLCIiEsEsIiISwSwiIhLBLCIiEsEsIiISwSwiIhLBIfCVIMShDYZKEAAAAASUVORK5CYII=
../../cc/test/layer_tree_pixel_test.cc:129: Failure
Value of: MatchesPNGFile(*result_bitmap_, ref_file_path, *pixel_comparator_)
  Actual: false
Expected: true
Stack trace:
#0 0x000001ceb5ff (/b/s/w/ir/out/Release/cc_unittests+0x1ceb5fe)
#1 0x0000017ae1e9 (/b/s/w/ir/out/Release/cc_unittests+0x17ae1e8)
#2 0x0000017bda1f (/b/s/w/ir/out/Release/cc_unittests+0x17bda1e)
#3 0x0000017bd178 (/b/s/w/ir/out/Release/cc_unittests+0x17bd177)
#4 0x000001a362be (/b/s/w/ir/out/Release/cc_unittests+0x1a362bd)
#5 0x000001a3b5ba (/b/s/w/ir/out/Release/cc_unittests+0x1a3b5b9)

[  FAILED  ] LayerTreeHostTilesTestPartialInvalidation.PartialRaster_SingleThread_OneCopy (4296 ms)

Original change's description:
> Roll src/third_party/skia 32c7d4dfcdca..d19fed1e291d (2 commits)
> 
> https://skia.googlesource.com/skia.git/+log/32c7d4dfcdca..d19fed1e291d
> 
> 
> git log 32c7d4dfcdca..d19fed1e291d --date=short --no-merges --format='%ad %ae %s'
> 2018-08-14 fmalita@chromium.org [skottie] Eliminate some temp SkString allocations
> 2018-08-14 mtklein@google.com pass sprite opacity to color xform when blitting.
> 
> 
> Created with:
>   gclient setdep -r src/third_party/skia@d19fed1e291d
> 
> The AutoRoll server is located here: https://autoroll.skia.org
> 
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
> 
> If the roll is causing failures, please contact the current sheriff, who should
> be CC'd on the roll, and stop the roller if necessary.
> 
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> TBR=kjlubick@chromium.org
> 
> Change-Id: Ib608389718b76c94782e3415bcc82dc607902e82
> Reviewed-on: https://chromium-review.googlesource.com/1174793
> Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#583019}

TBR=kjlubick@chromium.org,skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com

Change-Id: I0e6bc9c3c8c052a0ae17eb292cad8bb5e579faf2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1174639Reviewed-by: Chris Mumford <cmumford@chromium.org>
Commit-Queue: Chris Mumford <cmumford@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583063}

Final cleanup after https://crrev.com/581931

Bug: internal b/73383411
Test: manual
Change-Id: I9407ebbaa7b189bf3b71aa1700451198ec5c5810
Reviewed-on: https://chromium-review.googlesource.com/1169586Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583062}

Port a couple related browser tests to ash unit tests.

Change-Id: Id1fcf3b823b3f470dc93d651c681738053cc3383
Reviewed-on: https://chromium-review.googlesource.com/1173152Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583061}

Bug: 874102
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I64ae721146a6ac631800bd0bbd1ca6cca9f522f8
Reviewed-on: https://chromium-review.googlesource.com/1172741
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Katie Dektar <katie@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583060}

Previously, "OK Google"
Now, "Ok Google"

This string is used in Chrome OS settings.

Bug: b:112326023
Change-Id: Ic69713f93518241ade199034bce0a0c1063e89e1
Reviewed-on: https://chromium-review.googlesource.com/1171219Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Xiao Yang <yanxiao@google.com>
Cr-Commit-Position: refs/heads/master@{#583059}

"Answering on another device":
  To display when disambiguating "Ok Google" and we lose devie
  selection to another surface.

"What's on my screen":
  show on suggestion chip in Assistant UI to initiate a contextual search

Bug: b:112464186
Change-Id: Ia61f12d3c39f5005486824ad7982736719dfd14b
Reviewed-on: https://chromium-review.googlesource.com/1173263Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Xiao Yang <yanxiao@google.com>
Cr-Commit-Position: refs/heads/master@{#583058}

Bug: 854704
Change-Id: If3326d678e53b3ccff89bcd2ba98d02a0611b605
Reviewed-on: https://chromium-review.googlesource.com/1172739Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583057}

SafeStack [1] introduces a secondary thread stack called the unsafe
stack that also needs to be scanned for object references. Introduce
matching logic in oilpan to scan the unsafe stack for heap references.

[1] https://clang.llvm.org/docs/SafeStack.html

Bug: 864705
Change-Id: I376077bd985e2077aa3771101c1822e1570c7807
Reviewed-on: https://chromium-review.googlesource.com/1169772Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583056}

This patch adds a flag indicating whether an iframe element is occluded
or has visual effects applied in the parent document; and adds the flag
to the IPC message containing the iframe's intersection with the
parent's viewport.

BUG=869049
R=kenrb@chromium.org,chrishtr@chromium.org

Change-Id: I0891a3e6740dbce39f0cf0120353feb8c9fca173
Reviewed-on: https://chromium-review.googlesource.com/1167960Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583055}

Bug: 851609
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I2f261550d21f80e4b2143c0253a3867f11091885
Reviewed-on: https://chromium-review.googlesource.com/1175054
Commit-Queue: Eric Roman <eroman@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583054}

This fully enables support for context menu in iFrames.

Bug: 873660, 873662
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I3345f56f6812ef619c6ed5b7bcabd34e09de410f
Reviewed-on: https://chromium-review.googlesource.com/1174052
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583053}

For those subfolders of //chrome/ without violations, add them to
gn check targets. Otherwise, add number of errors in comments.

Bug: 367595
Change-Id: I8a2dc703f9b415e47f6fa3c1910b6338dd02ae69
Reviewed-on: https://chromium-review.googlesource.com/1174095Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583052}

Currently, the |FidoRequestHandlerBase::AddAuthenticator| method
synchronously invokes the virtual |DispatchRequest| method, which
subclasses implement to process the request and invoke the response
handling callback. Most authenticators are instantiated by a
|FidoDiscovery| which does some asynchronous discovery work and then
calls |AddAuthenticator|.

Platform authenticators, on the other hand, are instantiated by
|MaybeAddPlatformAuthenticator|, which gets invoked synchronously with
request handler instantiation. This makes it possible to have a
synchronous code path from request handler instantation to response
callback invocation (i.e.  hairpinning). In those cases,
|AuthenticatorImpl| is unable to handle the response (see e.g.
https://cs.chromium.org/chromium/src/content/browser/webauth/authenticator_impl.cc?sq=package:chromium&dr&g=0&l=749).

This change makes |DispatchRequest| invocation asynchronous, which
eliminates any possibility of response callback hairpinning.

Bug: 678128
Change-Id: I6bf273775885abac1fa38fe12c964e930407cc7e
Reviewed-on: https://chromium-review.googlesource.com/1172917
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Jun Choi <hongjunchoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583051}

TBR=kbr@chromium.org

Bug: 753483, 873914
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I958694f9db571b66c40baf144025d87acf824dc2
Reviewed-on: https://chromium-review.googlesource.com/1173169
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583050}

Specifically, adding new test suites webui_polymer2_browser_tests and
webui_polymer2_interactive_ui_tests that run a given list of tests and
explicitly excludes currently failing tests.

This will allow gradually getting to a state where all tests are passing
with the flag on.

Bug: 862472
Change-Id: Ia19ae36a4b2b63499b970e14c742b7719e118f83
Reviewed-on: https://chromium-review.googlesource.com/1132320
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583049}

This was removed in r577553 but I unintentionally reintroduced it
in r578809 (incorrect rebase).

This regressed https://crbug.com/860801#c18

R=kylechar@chromium.org

Bug: 860801
Change-Id: Ia42d24f915d271832b59c481ebe77ee1bc6fd11d
Reviewed-on: https://chromium-review.googlesource.com/1175060Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583048}

This is a reland of unmodified r582223, after separately taking care of
https://crbug.com/873780 which caused the earlier revert.  Original CL
description follows below:

After this CL site-per-process is the default in all layers on desktop
platforms, except:

- Layout Tests which still run with no isolation by default
  (see https://crbug.com/856734#c5 for the explanation why)

- //content embedders that don't want to use site-per-process: //chromecast

- //content embedders that don't yet support site-per-process, but will
  need to migrate eventually: //headless

Also note that even after this CL:

- //content on Android still defaults to no isolation.
  This is compatible with not_site_per_process_* test steps
  because such steps are not run on Android bots...

- //chrome layer ChromeContentBrowserClient controls usage of
  site-per-process in the Chrome browser and continues to be controlled
  by a field trial (note that Android is not covered by the field trial
  or by testing/variations/fieldtrial_testing_config.json).

Bug: 856734
Change-Id: I0cfd7e342c44a36d22a885b46892a9e4e3f2c758
Tbr: Stephen Lanham <slan@chromium.org>
Tbr: Sami Kyöstilä <skyostil@chromium.org>
Tbr: Bo <boliu@chromium.org>
Tbr: Nico Weber <thakis@chromium.org>
Tbr: Alex Moshchuk <alexmos@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1174855Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583047}

The drive-internals page uses GCache/v1 as the root for the files
displayed in the GCache Contents section of about:drive-internals. Use
its parent instead so the GCache/v2 contents are also displayed.

Bug: 829703
Change-Id: I7e47db743737a2331484e2b913600051470000b5
Reviewed-on: https://chromium-review.googlesource.com/1174135Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583046}

Moves any values that were still handled by ChromeLayoutProvider into
HarmonyLayoutProvider and adds a bunch of CHECK(false) inside
ChromeLayoutProvider to make sure that it's not called.

The next step will merge all HarmonyLayoutProvider code back into
ChromeLayoutProvider and remove the HarmonyLayoutProvider class
completely (effectively making HarmonyLayoutProvider the new
ChromeLayoutProvider).

Moving code into HarmonyLayoutProvider as a first step is only done
because it generates an easier diff for review (less code had to move
from ChromeLayoutProvider than vice versa).

Bug: chromium:867557
Change-Id: I477925c09e37b328103102e0d606a9d9db605eb5
Reviewed-on: https://chromium-review.googlesource.com/1171191Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583045}

Bug: None
Change-Id: Id76ae87bf92bf00c6f32e54afe963713b0e9f8c4
Reviewed-on: https://chromium-review.googlesource.com/1175064Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583044}

This CL migrates the CastMessageHandler for CAF. There's not
much code change between CastMessageHandler and CafMessageHandler.

Bug: 711860
Change-Id: Id58454c51cd6ada50b507d750a979ffe4e248241
Reviewed-on: https://chromium-review.googlesource.com/1169920
Commit-Queue: Zhiqiang Zhang <zqzhang@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583043}

isRemoteControlMode is obtained from (Cast)WebApplication when creating CastWebView and passed to
cast_content_window_android.cc -> CastContentWindowAndroid.java to reach Java side.

From cast to other Android app: add a param in intent to start CastWebContentsFragment in
CastWebContentsComponent.java

Bug: b/110761726 b/111887184

Test: cast_shell_junit_tests cast_shell_internal_junit_tests
Change-Id: I08cf42a492647d4d7c7b0c6593c6eb8852ae7179
Reviewed-on: https://chromium-review.googlesource.com/1164631
Commit-Queue: Zhiheng(Vincent) Li <vincentli@google.com>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Simeon Anfinrud <sanfin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583042}

After drag starts, the window needs to be dragged vertically a small
amount of distance to be considered as 'moved' and only after that, the
drag indicators will show up and the window can be snapped. But after
the window has been 'moved', it should stay moved even the window is
dragged toward to the top of the screen.

Bug: 873275
Change-Id: I4546a3a6839427c7232dcc5b6f234913b9dd516d
Reviewed-on: https://chromium-review.googlesource.com/1173472
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583041}

Bug: None
Change-Id: I27463c41df068ab0fb546f0d197cf77c3a47596b
Reviewed-on: https://chromium-review.googlesource.com/1174708Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583040}

Moved the onComplete listener to before the webview request is made so
the listener can be set up when the auth request is made. This is
necessary because of how network service handles the webRequest API. See
http://crrev.com/c/1139048 for more info.

Bug: 769401
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I0537bfaac2c8ba60fc4afeffcd3c39802eda01c1
Reviewed-on: https://chromium-review.googlesource.com/1174706Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583039}

These were using a URLRequestInterceptor, which doesn't work with the
network service. Switched to using content::URLLoaderInterceptor.

Bug: 769401
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I5032eaccac335a060d0d3dedd83d8d723c471d34
Reviewed-on: https://chromium-review.googlesource.com/1173012Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583038}

BUG=873972

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ic81c197c96e812e967958ff03aff6c55dc2bd119
Reviewed-on: https://chromium-review.googlesource.com/1174941Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583037}

Help distinguish WebRTC event logs from textual logs.

Bug: 775415
Change-Id: I17b14cfc25ab0c70eecd905cd28bad77304c3b3f
Reviewed-on: https://chromium-review.googlesource.com/1174352Reviewed-by: Henrik Grunell <grunell@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Elad Alon <eladalon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583036}

Currently playback will usually start in sync, but in some cases the AV
sync will be off by about 100ms or more at the start of playback. This
is especially reproducible after seeking. It is fixed in this CL.

MediaPipelineBackend will only start playback after all these conditions
are met:

1. Video is ready to play. This fixes issues with video starting too
   late.
2. Audio is ready to play. This fixes issues with audio starting too
   late.
3. A pause and resume operation has been executed. This is because the
   buffering logic in the upper layers always start us in the paused
   state. Having a pause and resume operations be executed at arbitrary
   times while the audio and video are getting ready to play is
   problematic when we want to accurately control when the first video
   and audio frames are played. So, to interop with the buffering logic,
   we start playback at the first resume call, which is what the
   buffering logic seems to want to accomplish anyway.

The audio pipeline now drops audio that preceeds the starting PTS time,
and preserves PTS for rate-changed audio.

Bug: b/111124705
Depends-On: eureka-internal/189521, eureka-internal/189519, eureka-internal/191050
Test: cast_media_unittests, manual testing with Youtube and Youtube TV.

Change-Id: Ib4cd98e010b8d29c183d321156c029551b05ef18
Reviewed-on: https://chromium-review.googlesource.com/1139397
Commit-Queue: Mina Almasry <almasrymina@chromium.org>
Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583035}

Add a simple WindowTree::SetHitTestMask impl and unit test.
Wire up the TouchHandleWindowTargeter, used in the KSV app, etc.
Clarify that the targeter only insets bounds, it does not extend them.

Bug: 872891
Test: KSV app text touches work as expected (modulo Issue 873743).
Change-Id: I4a1b79a8826a7e176ce3dafb29e1223ddd003966
Reviewed-on: https://chromium-review.googlesource.com/1171218Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583034}

These are histograms that have not been viewed in the last 6 months, but still
report data on the Stable channel. Set these histograms to stop being recorded
for Chrome releases after 2018-08-30. We will file bugs via Monorail (crbug)
reminding owners about the approaching histogram expiry – initially 30 days
prior to expiry, and also with follow-up alerts. The metrics dashboards will
also display a warning for anyone viewing a soon-to-expire histogram.

Owners and/or users of these histograms: Please comment on this CL if you think
that any affected histogram should not have an expiry date set! This should be
uncommon.

Otherwise, there are a few options going forward:
  * If the histogram is no longer needed, please send a follow-up CL to delete
    the recording code and to mark the histogram as <obsolete>. (You can also
    remove the expiry date in the same CL.)
  * If you want to set a different expiry date, please send a follow-up CL to do
    so.
  * If neither of the above apply, then keep an eye out for Monorail bugs as the
    histogram expiry date approaches.
For more info on how unused histograms are identified, see
https://goto.google.com/uma-unused-histograms-cleanup

Bug: 850539
Change-Id: Ic01c7e6444cf45c2cc42bf58a6207bd3216b92f5
Reviewed-on: https://chromium-review.googlesource.com/1126400
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583033}

It should be desktop only.

Change-Id: I3e498cbd9fe5a9abfa798c4f3719bf7089aa02f5
Reviewed-on: https://chromium-review.googlesource.com/1174998Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583032}

Currently, a guest view responds to control wheel zoom changes by
zooming the embedder. However, the embedder itself may not respond
to control wheel zoom changes. So a user could zoom an otherwise
non-zoomable embedder by control wheel zooming inside a guest.

We now have the guest view inform the embedder that a control wheel
zoom change has occurred so that the embedder can decide how to handle
it.

Bug: 874189
Change-Id: Icd49a2590e502bb60b7e3d6d372de3a133e2277f
Reviewed-on: https://chromium-review.googlesource.com/1175006Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583031}

Also fix a bug where continue button was still enabled after tabbing to
and pressing backspace with the keyboard.

Test: manual
Bug: 855014, 869641
Change-Id: I0f3e570fc87b1a2e60de112de47558885f5d4847
Reviewed-on: https://chromium-review.googlesource.com/1173139Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583030}

3 things are done here:
- add underscore to private properties of UsageTimeLimitProcessor class;
- fix a couple of comments with typos;
- rename 'override' property. Override is a reserved word starting on C++11;

Bug: 869954
Change-Id: I9d9f5ab133b9a9c639b68b25648beb3c8fbfe119
Reviewed-on: https://chromium-review.googlesource.com/1159041Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Henrique Grandinetti <hgrandinetti@google.com>
Cr-Commit-Position: refs/heads/master@{#583029}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/6febc356717c..db93180205a6


git log 6febc356717c..db93180205a6 --date=short --no-merges --format='%ad %ae %s'
2018-08-14 manojgupta@google.com chromeos_config: Mark eve as experimental.


Created with:
  gclient setdep -r src/third_party/chromite@db93180205a6

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I60803dea17bcaf7a0637b197bba81ac7c6b16670
Reviewed-on: https://chromium-review.googlesource.com/1174795Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#583028}