GitLab

Don't auto allow access to media devices unless a the security origin of the requester is the same as its ancestors.

This adds a field in MediaStreamRequest to verify that the security origin of the requester is the same as its ancestors.
This field have to be set on the UI-thread and is therefore set just before sending the request to the UI.

BUG=448378
TEST= please see bug report

Review URL: https://codereview.chromium.org/795703003

Cr-Commit-Position: refs/heads/master@{#313904}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/0437733..ebfe939

TBR=junov@chromium.org,vsevik@chromium.org

Review URL: https://codereview.chromium.org/890863002

Cr-Commit-Position: refs/heads/master@{#313903}

And, in the process, fix a bug in the CookieTreeModel, where it was prematurely sending BatchEnded events.

BUG=445962, 447395

Review URL: https://codereview.chromium.org/863503002

Cr-Commit-Position: refs/heads/master@{#313902}

After successfull pairing session will call auth API to get access token.

BUG=449864

Review URL: https://codereview.chromium.org/880373004

Cr-Commit-Position: refs/heads/master@{#313901}

BUG=none
R=jshin@chromium.org

Review URL: https://codereview.chromium.org/878143002

Cr-Commit-Position: refs/heads/master@{#313900}

Review URL: https://codereview.chromium.org/889663002

Cr-Commit-Position: refs/heads/master@{#313899}

Revert of Create a Android Sync integration test for typed URLs (patchset #4 id:140001 of https://codereview.chromium.org/862113005/)

Reason for revert:
This is breaking building chrome/android:chrome_sync_shell_test_apk
with gn due to a dependency to the autogenerated enum org.chromium.ui.base.PageTransition;

I am not sure why no bots failed when landing it (we don't seem to have gn builder upstream for android?) but reverting it locally makes it build again.

To repro: Reapply the patch and run
gn gen out/Release  --args='is_debug=false os="android" cpu_arch="arm" use_goma=true goma_dir="/usr/local/google/clank/goma/goma"'

ninja -C out/Release -j 200  chrome/android:chrome_sync_shell_test_apk

Original issue's description:
> Create a Android Sync integration test for typed URLs
>
> This CL introduces JNI plumbing for one method of the FakeServer's
> verification API. One test (testUploadTypedUrl) has been added to use
> the API; it types a URL on the client and verifies that the URL was
> sent to the server.
>
> BUG=NONE
>
> Committed: https://crrev.com/cba424b9309c8c75d0a3797b9b228f7ef11425e4
> Cr-Commit-Position: refs/heads/master@{#313824}

TBR=nyquist@chromium.org,maxbogue@chromium.org,zea@chromium.org,pvalenzuela@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=NONE

Review URL: https://codereview.chromium.org/881753003

Cr-Commit-Position: refs/heads/master@{#313898}

BUG=434643
TBR=jennyz@chromium.org

Review URL: https://codereview.chromium.org/871373011

Cr-Commit-Position: refs/heads/master@{#313897}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/8a5af16..0437733

TBR=junov@chromium.org,vsevik@chromium.org

Review URL: https://codereview.chromium.org/889853002

Cr-Commit-Position: refs/heads/master@{#313896}

Mainly, this breaks out braille span classes and the EditableTextBase
class into their own files.  This removes lots of dependencies on code that
should only run in the content script in ChromeVox classic from the
ChromeVox next background script.

BUG=

Review URL: https://codereview.chromium.org/889593002

Cr-Commit-Position: refs/heads/master@{#313895}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/06fb35f..f4ee92e

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/886963004

Cr-Commit-Position: refs/heads/master@{#313894}

TBR=kinuko@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/888823002

Cr-Commit-Position: refs/heads/master@{#313893}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/79abaa8..8a5af16

TBR=junov@chromium.org,vsevik@chromium.org

Review URL: https://codereview.chromium.org/891653002

Cr-Commit-Position: refs/heads/master@{#313892}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/863263005

Cr-Commit-Position: refs/heads/master@{#313891}

Pairing generates secret know to the session and
device. The secret will be used for for certificate validation and for device authentication.

BUG=449864

Review URL: https://codereview.chromium.org/877613002

Cr-Commit-Position: refs/heads/master@{#313890}

Following the discussion about the term "main-frame" in https://codereview.chromium.org/843413003/, I experimented with a testing webpage that embedded <iframe>s which triggered different content setting requests.

Apparently, in the descriptions in content_settings.json, we used the term "main-frame" in two different contexts. This CL get rids of the term completely in favor of "top-level frame" and "document which requests X".

BUG=447978

Review URL: https://codereview.chromium.org/883983003

Cr-Commit-Position: refs/heads/master@{#313889}

toolkit-views builds on mac are getting:
Undefined symbols for architecture x86_64:
   ShowProximityAuthErrorBubble

To fix, move proximity_auth_error_bubble.cc to mac_sources. This works
because the symbol is only referenced on platforms with extensions,
which are toolkit_views platforms + mac.

After proximity_auth_error_bubble_view.cc moves in
chrome_browser_ui.gypi from chrome_browser_ui_views_non_mac_sources to
chrome_browser_ui_views_sources then proximity_auth_error_bubble.cc can
be deleted.

BUG=399191
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/887563003

Cr-Commit-Position: refs/heads/master@{#313888}

Currently |SSL_shutdown| is only called to avoid that the
session is marked as unresumable. Without the quiet flag the
close notify message is generated without being sent on the
network.

BUG=None

Review URL: https://codereview.chromium.org/885083002

Cr-Commit-Position: refs/heads/master@{#313887}

BUG=346634

Review URL: https://codereview.chromium.org/860333003

Cr-Commit-Position: refs/heads/master@{#313886}

If only a single credential is available, and zero-click behavior is
enabled, then we don't need to ask the user for permission to present
the credential in response to a website's call to `request()`.

This patch implements that logic, walking through the local credentials
for an origin in the password store, and returning zeroclick credentials
without prompting.

If no such credential is available, and the caller set 'zero_click_only',
then we also won't prompt the user, and will simply return an empty
credential.

BUG=400674

Review URL: https://codereview.chromium.org/879913004

Cr-Commit-Position: refs/heads/master@{#313885}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/116cf7f..79abaa8

TBR=rjwright@chromium.org,junov@chromium.org

Review URL: https://codereview.chromium.org/886963002

Cr-Commit-Position: refs/heads/master@{#313884}

Revert of Manage profiles in BluetoothAdapter on ChromeOS (patchset #5 id:80001 of https://codereview.chromium.org/851123002/)

Reason for revert:
This causes a leak on Chrome Os ASan.

https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/6306/steps/device_unittests/logs/Connect

Original issue's description:
> Manage profiles in BluetoothAdapter on ChromeOS
>
> Profiles in bluez are not specific to a device.
> When client code tries to connect to two different devices, only
> one profile is created, managed by BluetoothAdapterChromeOS.
>
> dbus messages are multiplexed based on the device desired using new
> class BluetoothAdapterProfileChromeOS.
>
> BUG=chromium:421207
>
> Committed: https://crrev.com/c56186ac2901c99349cbb4b4a6b8aa0ff8088c4d
> Cr-Commit-Position: refs/heads/master@{#313837}

TBR=armansito@chromium.org,keybuk@chromium.org,rpaquay@chromium.org,jamuraa@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:421207

Review URL: https://codereview.chromium.org/868753006

Cr-Commit-Position: refs/heads/master@{#313883}

TBR=kkimlabs@chromium.org,ddorwin@chromium.org
BUG=446263

Review URL: https://codereview.chromium.org/890813002

Cr-Commit-Position: refs/heads/master@{#313882}

BUG=335778
TEST=build and run vaapi_jpeg_decoder_unittest

Review URL: https://codereview.chromium.org/825843002

Cr-Commit-Position: refs/heads/master@{#313881}

BUG=None
TEST=compile on CrOS

Review URL: https://codereview.chromium.org/885273002

Cr-Commit-Position: refs/heads/master@{#313880}

Since device processing is moved off-thread, we can't enter the device
code from nested UI message loops. So we can remove the task hop in
PostUiEvent and dispatch synchronously.

WarpCursorTo() did need update to do its own post, as it is the last
remaining case of dispatch that doesn't start in its own task. Everything
else already posts in ForwardingDeviceEventDispatcher.

We can stack-allocate the ui::Events now, too. They previously needed
heap allocation to extend their lifetime through the task hop.

BUG=449710
TEST=boot link_freon & move mouse

Review URL: https://codereview.chromium.org/858333006

Cr-Commit-Position: refs/heads/master@{#313879}

This makes the injector use the same interface as the devices
themselves. It also allows us to remove the PostTask after ui::Event
construction from EventFactoryEvdev, because all dispatches already
start in their own task (posted by ForwardingDeviceEventDispatcher).

BUG=449710
TEST=boot link_freon & move mouse

Review URL: https://codereview.chromium.org/882503002

Cr-Commit-Position: refs/heads/master@{#313878}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/65e27b8..116cf7f

TBR=rjwright@chromium.org,junov@chromium.org

Review URL: https://codereview.chromium.org/862113006

Cr-Commit-Position: refs/heads/master@{#313877}

This CL moves services code that is brought in from the Mojo repo and currently
living in //mojo/services to instead live in //third_party/mojo_services/src.
It fixes up include paths, buildfile references, and DEPS entries to account
for the new state of the world.

Review URL: https://codereview.chromium.org/861683003

Cr-Commit-Position: refs/heads/master@{#313876}

This is part of a series moving IO on evdev devices to a fast thread,
since UI thread is too slow for the cursor.

Make a new class ForwardingDeviceEventDispatcher that wraps
EventFactoryOzone and can be safely passed to another thread. When the
other thread dispatches, we'll post to EventFactoryOzone on the UI thread
with the event.

BUG=449710
TEST=boot link_freon & move mouse

Review URL: https://codereview.chromium.org/874723002

Cr-Commit-Position: refs/heads/master@{#313875}

Provides a second version of addTraceEvent that accepts a timestamp when #WEBKIT_HAS_NEW_ADD_TRACE_EVENT_WITH_TIMESTAMP is defined. This is in preparation for adding the Blink code that writes trace events with user-supplied timestamps.

BUG=345845

Review URL: https://codereview.chromium.org/870053006

Cr-Commit-Position: refs/heads/master@{#313874}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/daa5c18..65e27b8

TBR=rjwright@chromium.org,junov@chromium.org

Review URL: https://codereview.chromium.org/885063003

Cr-Commit-Position: refs/heads/master@{#313873}

BUG=None

Review URL: https://codereview.chromium.org/880123004

Cr-Commit-Position: refs/heads/master@{#313872}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/8949229..daa5c18

TBR=rjwright@chromium.org,junov@chromium.org

Review URL: https://codereview.chromium.org/889793002

Cr-Commit-Position: refs/heads/master@{#313871}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/527b287..06fb35f

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/886443004

Cr-Commit-Position: refs/heads/master@{#313870}

Changes in task state trigger import controller updates (triggering scanning and UI updates).
Update test to work with new async update model.

Also: Fix media importer code to pass logical destination when marking a file imported.

+satorux for chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
BUG=420680
TEST=browser_test: FileManagerJsTest.*

Review URL: https://codereview.chromium.org/888693002

Cr-Commit-Position: refs/heads/master@{#313869}

BUG=414283

Review URL: https://codereview.chromium.org/888743003

Cr-Commit-Position: refs/heads/master@{#313868}

BUG=445645
TEST=tools/perf/run_benchmark --browser=cros-chrome --remote=$device robohornet_pro
TEST=tools/telemetry/run_tests telemetry.core.platform.power_monitor.cros_power_monitor_unittest

Review URL: https://codereview.chromium.org/887613002

Cr-Commit-Position: refs/heads/master@{#313867}

Pipe DidStartNavigationToPendingEntry to WebContentsObserver and TabObserver.

BUG=442726

Review URL: https://codereview.chromium.org/877163005

Cr-Commit-Position: refs/heads/master@{#313866}

This is part of a series moving IO on evdev devices to a fast thread,
since UI thread is too slow for the cursor.

We must access DeviceDataManager from the UI thread only, so send a new
list to EventFactoryEvdev when devices are added or removed, and update
DeviceDataManager from there.

InputControllerEvdev also needs to know if there's a mouse or touchpad
attached, so additionally plumb lists for those devices and update this
property on InputControllerEvdev.

BUG=449710
TEST=boot link_freon & move mouse

Review URL: https://codereview.chromium.org/868043003

Cr-Commit-Position: refs/heads/master@{#313865}