GitLab

Uberblame now looks like this:
https://bugs.chromium.org/p/chromium/issues/detail?id=773350#c9

BUG=773350
R=dpranke

Change-Id: I43b75fbedac5a9350a5c227882743b8a9bd33282
Reviewed-on: https://chromium-review.googlesource.com/1014621
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551188}

The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:fuchsia_arm64_cast_audio;master.tryserver.chromium.linux:fuchsia_x64_cast_audio
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I829c73a630d817100f0632aeac194fdbc1e09d0a
Reviewed-on: https://chromium-review.googlesource.com/1014503
Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#551187}

If native VAO is disabled on ES2, but not ES3 contexts, and on ES2 we use client side arrays, then we have to switch to driver's default VAO (id = 0) when we switching to the ES2 contexts. Otherwise VertexAttribPointer for client array set up will fail with an GL_INVALID_OPERATION error.

BUG=829766
TEST=manual on affected devices
R=piman@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ide93c4fa4649dd2fd2b6d25137f3346320473b4b
Reviewed-on: https://chromium-review.googlesource.com/1013140Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551186}

Those were mistakenly and automatically generated by the rebaseline-cl tool in
(https://chromium-review.googlesource.com/c/chromium/src/+/1010511).

Change-Id: I5cc9f5dabf56a599883b4d14b57c72befb6584e8
Reviewed-on: https://chromium-review.googlesource.com/1012495
Commit-Queue: Yuqian Li <liyuqian@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551185}

This is in preparation for displaying the diff in the Uberblame visualization.
About 3 lines of context is nice when viewing diffs.

Some extra logic is now necessary to handle the context.

BUG=773350
TBR=dpranke

Change-Id: If202deb3d9fd85ee6f9376739205a15f542b8005
Reviewed-on: https://chromium-review.googlesource.com/1014349Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551184}

10fd672bde9d linux: Enable brokered memory reading
3a20d34ac356 Fix build with glibc 2.27
1bb4c233e341 linux: skip zero length mappings in the maps file
a3ba96c0d4c7 linux: Use an empty string for unmapped module names
914e7f76dd26 linux, x86: Read floating point state via mcontext.fpptr
e83103c80503 fuchsia: Implement CaptureContext() for x64
b08165c9e52a Extract BuildHandlerArgvStrings to common shared location
c7fe30dddbb0 fuchsia: Get generate_dump to start attempting process
             dumps
cf55a7ef5506 fuchsia: Implement SnapshotTime()
f5f0aa4a8e84 fuchsia: Implementation of system snapshot
a4f4d6a73659 fuchsia: Small fixes in system and process snapshot hit on
             generate_dump
d9bf38f39c5a fuchsia: More fixes to get a basic minidump written
856339b2d211 fuchsia: Avoid uname() in system snapshot
091308be6aeb gyp: build client_argv_handling
dd4ba4c8a168 linux, x86/x64: set fpregs to nullptr in CaptureContext()
c80bf96001dd Don't record reports as complete if there is no upload
             thread
f5d5a41317be fuchsia: Add implementation of ScopedTaskSuspend
c2583364a36e fuchsia: Capture general purpose registers in thread
             snapshot
eca0ea8427c2 Add limited version of URL cracking
ca2d7e776a0a Pull go toolchain for all host types
799dcef4c90f fuchsia: Fix compilation after hasty review changes

Bug: crashpad:30
Change-Id: Iab7c09aaa390e73129eb0eea308ba8af9eddb668
Reviewed-on: https://chromium-review.googlesource.com/1012446Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551183}

This fix the issue when default ARC app icons are not loaded in case
of provisioning is not finished for new user flow.

Test: Manually + unit_test
Bug: 833596
Change-Id: I99af81eafb78c65857b6fe5a6475d3372e08beb5
Reviewed-on: https://chromium-review.googlesource.com/1014326
Commit-Queue: Yury Khmel <khmel@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551182}

HostListFetcher returns a -1 error code when it fails to get the HTTP
response (because of timeout?). We map the HTTP code into error message
using net::GetHttpReasonPhrase(), which reaches NOTREACHED() when the
argument is -1 and causes a crash on debug build.

This CL prevents this by explicitly translating -1 into "Connection
failed".

Bug: 832994
Change-Id: I94f5c353de2674500190efb9dc8066ad40aaed8e
Reviewed-on: https://chromium-review.googlesource.com/1012787
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551181}

A LocalSurfaceId allocation/renewal for an aura::Window happens in
response to a bounds or dsf-change to its corresponding ui::Layer.
The root window is special in this regard, since its state can be
changed only by the WindowTreeHost, and should happen before the
ui::Compositor is updated for the new bounds/dsf (since it needs
to provide the LocalSurfaceId to the ui::Compositor).

Window::SetDeviceScaleFactor() is no longer needed after this. So
remove that.

BUG=821987

Change-Id: I3eb674b1c59a2728315125b6eb14b610033f6bf4
Reviewed-on: https://chromium-review.googlesource.com/1012932Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551180}

Adding tests as per request of the origin trial team.

Bug: 832387
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ie7d09c127f46d7de2928388d69712b2c73fdd630
Reviewed-on: https://chromium-review.googlesource.com/1003041Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Jason Chase <chasej@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Commit-Queue: Anna Offenwanger <offenwanger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551179}

PDF and QuickOffice plugins use the mimeHandler API only. Once QuickOffice that uses mimeHandler is updated to all users (depends on 67 reaching stable) we can delete the streams API code.

Bug: 705114
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ia402364e4ee88e9f3eb06b3e413253ffb5e71413
Reviewed-on: https://chromium-review.googlesource.com/1013403Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551178}

Easy win, additional 72 tests pass.

Bug: 635619
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I4c77bafcbce24245bac482c3fb3afe1f064e6f1c
Reviewed-on: https://chromium-review.googlesource.com/1014325
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551177}

Add a caching factory for Chrome OS |AccountManager|. Cache is keyed on
the basis of Profile path (|Profile::GetPath|).

AccountManager cannot be simply a part of |g_browser_process| because of
Chrome OS Multi Sign In. Accounts participating in Multi Sign In should
see separate instances of |AccountManager|.
Once Multi Sign In has been replaced by Multi Profile,
|AccountManagerFactory| can be removed and |AccountManager| can be made
a part of |g_browser_process|.

Bug: 820046
Change-Id: I8c2f2b2b5d8d61c5a818ab711197840bd605567b
Reviewed-on: https://chromium-review.googlesource.com/1010542Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Commit-Queue: Kush Sinha <sinhak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551176}

Static initializers are not allowed.

BUG=831951

Change-Id: I1c1d41ea66a34d38119c639c2af48183b9d1ab64
Reviewed-on: https://chromium-review.googlesource.com/1012870
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551175}

BUG=773295
TEST=
  1. <out_chromeos>/chrome --user-data-dir=<profile> --new-wallpaper-picker
  2. settings -> select wallpaper
  3. selection is functional.


Change-Id: Ia8cab4086550b723ce904705db26c5f171277dbf
Reviewed-on: https://chromium-review.googlesource.com/1014222Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#551174}

No change to production logic.

This aims to deflake
SafeBrowsingTest#testSafeBrowsingDontProceedNavigatesBackFor*.

These tests previously depended on the interstitial to change the page
title to the string "Security error." This is unreliable, however, as
chromium translates this for non-English locales.

This CL removes the dependency on page title, and asserts that the
previous page is visible after clicking "back to safety."

I couldn't locally reproduce test failures except by changing device
locale, but I expect this method to be more robust than relying on page
title. As mentioned below, I tested this ~200 times without failure, so
I don't expect many flakes.

This also removes the @FlakyTest annotation previously added.

Bug: 822753
Test: run_webview_instrumentation_test_apk -f SafeBrowsingTest#testSafeBrowsingDontProceedNavigatesBackFor*
Change-Id: I91ded411514302c2c34fdb8e06f7694f58f7e526
Reviewed-on: https://chromium-review.googlesource.com/1013686Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551173}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/82e2ac9a251e..90906cbf2fc5

$ git log 82e2ac9a2..90906cbf2 --date=short --no-merges --format='%ad %ae %s'
2018-04-16 chrome-bot Update config settings by config-updater.

Created with:
  roll-dep src/third_party/chromite


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I7bf207d4e784b569e8f6ddd6f3e1e7f5d74c12e9
Reviewed-on: https://chromium-review.googlesource.com/1013155Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#551172}

This reverts commit cdf4606b.

Reason for revert: Apparently some bots have java 1.8, some have 1.7 which caused flakiness. Need to update all bots to 1.8 before re-landing.

Original change's description:
> Roll closure compiler
> 
> Latest compiler version does not include Chrome's externs by default. They
> need to be explicitly included.
> 
> Change log:
> https://github.com/google/closure-compiler/compare/8fc82299c45b0a33f19834222acda4850fd77bc0...5cae9b78a16a2655627733b66d1c686d5f547925
> chrome.js: 7ef3422e1e87480d560247d75fee181b4cac24d9
> chrome_extensions.js: 3a0b0052782af3f0bd3a5fe10bb568cdd769db4e -> 03c824e85e7b77bde4e7449ed3727608b05b2acc
> polymer-1.0.js: 55e962227e676cd30f81439573771326933aae54 -> 8f3b8c9354813ae0e2f186bf2f504cf3f3182a66
> 
> BUG=831004
> 
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: I0db559ee9a198dadd3b23e57b835cc6b985540a9
> Reviewed-on: https://chromium-review.googlesource.com/1006182
> Reviewed-by: calamity <calamity@chromium.org>
> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#551058}

TBR=calamity@chromium.org,dpapad@chromium.org

Change-Id: I1d8bfeb4a6b79b7098cf2b1e4e975cacbd8f00ba
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 831004
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/1013548Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551171}

Create IOS.ITunesURLsStoreKitHandlingResult to Histogram to log the
result of itunes url handling by storekit.

Bug: 623016
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I6a9b7db91743df90cc7f2af1e1e42567691618d4
Reviewed-on: https://chromium-review.googlesource.com/1010964
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551170}

Bootstrap the id by always calling ReportEvent(FETCH_REQUESTED) before
fetching.
Report FETCH_DELAYED when we set the baseline timestamp.
Ensure that events generated by the tab and triggering
delayed fetch are not checked against page being loaded

Bug: 837212
Change-Id: Ida168013b0920a6428093af943f06762dfbe0600
Reviewed-on: https://chromium-review.googlesource.com/1012440
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551169}

Looking back on this TODO, I think using the FormatURL offsets is
overkill, requires a lot of plumbing, and confusing for the maintainer
compared to this "simple" logic.

So I'm deleting the TODO and replacing it with a comment that explains
why we can use the "simple" logic and when we would have to replace it.

Bug: 797354
Change-Id: Idffe358c054fb2f70a4bd91c928af324b1edf650
Reviewed-on: https://chromium-review.googlesource.com/1014394Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551168}

preload=metadata suspend prevents decoding and rendering of the
first video frame. In these cases the video memory usage is zero,
but WMPI always includes an estimate for the frame held by the
compositor even if no frame is being held.

This artificially inflates the memory used in the preload=metadata
experiment. The fix is to not include this estimate if we've never
painted a frame before.

BUG=833564
TEST=new unittest.

Change-Id: I0b8811f04b27e5cc5c4ea5789cbd3d9247720771
Reviewed-on: https://chromium-review.googlesource.com/1014387
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551167}

https://skia.googlesource.com/skia.git/+log/ffbe93296838..d234afdc2e56

$ git log ffbe93296..d234afdc2 --date=short --no-merges --format='%ad %ae %s'
2018-04-13 bungeman Remove SkPaint::kGenA8FromLCD_Flag.
2018-04-16 kjlubick Fix many return-std-move-in-c++11 warnings
2018-04-16 fmalita Remove unused BW mask blitters
2018-04-16 mtklein disable -Wself-assign in Google3
2018-04-16 mtklein skcms→2667f0a Add skcms_BestSingleCurve utility
2018-04-16 reed optimize fast/simple case in raster tiling
2018-04-13 liyuqian Simplify the operation on atomic fIsFinishing
2018-04-13 liyuqian Let SkCoverageDeltaList store width and use it during blitting
2018-04-11 liyuqian SkBlitter is not thread safe; make one for each thread.
2018-04-12 liyuqian Snap the bitmap as it may be changed later
2018-04-16 halcanary SkPDF: use std::aligned_storage for typed union
2018-04-16 rmistry Some Chromium bots have been LUCIfied
2018-04-16 angle-skia-autoroll Roll third_party/externals/angle2/ 76b2c3852..a4fa9c278 (3 commits)
2018-04-16 egdaniel Don't allow ganesh to allocate mip maps for wrapped textures.
2018-04-10 bsalomon Draw stroked circles with round caps analytically.
2018-04-16 liyuqian Reland "Cumulate deltas even if they're out of the clip"
2018-04-16 caryclark document SkColor.h

Created with:
  roll-dep src/third_party/skia
BUG=chromium:818693,chromium:820245,chromium:820470


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=scroggo@chromium.org

Change-Id: If635e8f9d3bdfb9b34afb9ba244c0a1cc269c868
Reviewed-on: https://chromium-review.googlesource.com/1014413
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#551166}

- Filled in all of the hook code.
- Basic shell for new 'main' testing, which will interface with the
black-box third_party_dlls project and test the whole thing with the
hook in place.  In an effort to keep this CL a reasonable size for review,
the more in-depth testing will be in the next CL.
- Also small adjustments to existing code: pe_image_safe::RVAToAddr()
needs to be public; blacklist::DLLMatch() will do a full conversion just to
be safe (it is deprecated and will be deleted soon).
NOTE: none of this code is active in the wild yet.

Bug=769590
Test=chrome_elf_unittests.exe, ThirdParty*

Change-Id: Ic50195ac966691c796f621ee7716b43e3e8cf660
Reviewed-on: https://chromium-review.googlesource.com/990552
Commit-Queue: Penny MacNeil <pennymac@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551165}

It changed from -r2 to -r3 recently, so the path is no longer valid.

This just lists the parent dir instead. (qemu should be the only thing
in it).

Bug: 828607
Change-Id: I2bc72b8f4202fedadc5274031d395df72ddd4276
Reviewed-on: https://chromium-review.googlesource.com/1014489Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551164}

Make animation/transition use real initial values for its longhands, instead
of just "initial". In order to support this add a method InitialValue to
the Longhand class and implement it for every longhand that is part
of the animation or transition shorthand.

Behavior matches Firefox.

Bug: 386459, 772772

Change-Id: I102107e8cb9ef0682c01c1156ec926dbb419c49c
Reviewed-on: https://chromium-review.googlesource.com/986502Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Rob Buis <rob.buis@samsung.com>
Cr-Commit-Position: refs/heads/master@{#551163}

https://chromium.googlesource.com/angle/angle.git/+log/a4fa9c2782da..aa8b3982aeeb

$ git log a4fa9c278..aa8b3982a --date=short --no-merges --format='%ad %ae %s'
2018-04-16 tobine Roll (1/2) LVL version forward and disable VANGLE
2018-04-16 jmadill Vulkan: Fix texture descriptor set alloc count.
2018-04-15 jmadill Optimize ValidateDrawAttribs: Part 1.
2018-04-13 jmadill Vulkan: Rename StagingStorage to PixelBuffer.

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jmadill@chromium.org
No-try: True

Change-Id: Ie22e822e0e4688b255c641ca2c3ea378f4f843dc
Reviewed-on: https://chromium-review.googlesource.com/1014465
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#551162}

This change allows the user to close the Picture-in-Picture
window. Temporarily, right clicking the window will close the
player.

Future work includes adding UX affordances for media controls and
consolidating with the Picture-in-Picture teardown in
WebMediaPlayerImpl.

BUG: 726619
Change-Id: Ia60d9153e53f4ae3dd7cf53c7ec505cee33e5b60
Reviewed-on: https://chromium-review.googlesource.com/976263
Commit-Queue: apacible <apacible@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551161}

Bug: 832175
Change-Id: I8723a8d5e92d1439760ae6a40b0cb444aad00531
Reviewed-on: https://chromium-review.googlesource.com/1014253Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551160}

Bug: 799524
Change-Id: If76472261a452021e0bc883a89d944d87e26dabc
Reviewed-on: https://chromium-review.googlesource.com/1013291Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Qiang Xu <warx@google.com>
Commit-Queue: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551159}

Previously, when the user placed the cursor in the URL and unelided the
URL, and then pressed Alt-Tab to switch windows, and then to switch
back, the URL would be re-elided.

This is not desirable. The Omnibox state should not change merely from
switching windows. It should re-elide only if the user focuses something
else in the same window.

This CL fixes the bug and adds a test for this behavior.

It also updates the test to make failure messages more clear about
which line has the failing condition.

Bug: 797354
Change-Id: I43905e1248c439651bd6b6a66d57d46dff0989e2
Reviewed-on: https://chromium-review.googlesource.com/1014347
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551158}

* This only adds a command line for enterprise policy bypass
  (no flag is added in about flags)
* Adds a policy bypass code in the bridge.

Bug: 832797
Change-Id: I9bca2c54dbfff37b52cb56ece5bd3632a5e0ec9c
Reviewed-on: https://chromium-review.googlesource.com/1014467Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551157}

The first time we know the Demuxer initialization is complete is when
Pipeline::Start() completes (asynchronously).

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I7451187be2d141780d5aa514fb3a1ec4abe8fbbe
Reviewed-on: https://chromium-review.googlesource.com/1000858
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551156}

Looks like it was accidentally removed in https://crrev.com/2577573002.

Bug: 673494

Change-Id: Ibb73e8ff0c8a1b3a222446b002eb5b7560e9fe31
Reviewed-on: https://chromium-review.googlesource.com/1012079Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551155}

FPDF_PageToDevice() and FPDF_DeviceToPage() now return results.

Change-Id: I2f49fa37d295ea7ee4bc3dcd8cdcebaa085f5b23
Reviewed-on: https://chromium-review.googlesource.com/1013283
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551154}

Bug: 832631
Change-Id: I211b693337c93a53fabd5aacd41bc4024cefc7c2
Reviewed-on: https://chromium-review.googlesource.com/1013877Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551153}

Mark kUseMonitorColorSpace disabled by default to avoid
the blue-color-looks-purple problems detailed in the bug.
This is just a temporary CL to allow cherry-picking it
into the beta branch.

TBR=dcastagna@chromium.org

Bug: 809909
Change-Id: I35bb8cc48c26091cb1752d3d7709a48d23fb4c6e
Reviewed-on: https://chromium-review.googlesource.com/1012305Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551152}

Fixes occasional crashes seen in render thread profiling when
attempting to unwind from the sigtramp function in non-leaf frames.

Bug: 831793
Change-Id: Ie07b9679c288262d8409904d4f4fe818324339bf
Reviewed-on: https://chromium-review.googlesource.com/1013337
Commit-Queue: Mike Wittman <wittman@chromium.org>
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551151}

This reverts commit 79605d54.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Revert "Reland "Surface synchronization: Add a diagnostic CHECK in ClientLayerTreeFrameSink""
> 
> This reverts commit 79edda64.
> 
> Reason for revert: We have branched into M68.
> 
> Original change's description:
> > Reland "Surface synchronization: Add a diagnostic CHECK in ClientLayerTreeFrameSink"
> > 
> > This is a reland of 119455cb
> > 
> > Original change's description:
> > > Surface synchronization: Add a diagnostic CHECK in ClientLayerTreeFrameSink
> > >
> > > There's a race in cc somewhere from commit to draw. I don't know exactly
> > > how to repro the race yet even though I have a high probably fix. This
> > > CL is intended to catch the race in the wild and produce a stack trace
> > > in a crash log. Hopefully from there we can acertain repro steps.
> > >
> > > Once repo steps are produced locally (either via user interaction or
> > > unit test) then this CL will be reverted.
> > >
> > > Bug: 672962
> > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
> > > Change-Id: I3bce066591e15d5c3aac7d4c8685dce411e284b7
> > > Reviewed-on: https://chromium-review.googlesource.com/973987
> > > Reviewed-by: Saman Sami <samans@chromium.org>
> > > Commit-Queue: Fady Samuel <fsamuel@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#544834}
> > 
> > Bug: 672962
> > TBR: samans@chromium.org
> > Change-Id: I880540f3f00c419efb4055007787e86f4722d675
> > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
> > Reviewed-on: https://chromium-review.googlesource.com/981154
> > Commit-Queue: Fady Samuel <fsamuel@chromium.org>
> > Reviewed-by: Fady Samuel <fsamuel@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#545994}
> 
> TBR=fsamuel@chromium.org,samans@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 672962
> Change-Id: I02cc346dddda60a02e9233ec6fcb7c9df50e1d8a
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
> Reviewed-on: https://chromium-review.googlesource.com/1008610
> Reviewed-by: Fady Samuel <fsamuel@chromium.org>
> Commit-Queue: Fady Samuel <fsamuel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#550171}

TBR=fsamuel@chromium.org,samans@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 672962
Change-Id: Ib3730fc78117cbaac36d141bfe03430a665bb3ea
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1012785Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551150}

Bug: 832919, 831251
Change-Id: I113dbedec6ee9b79f109aff876a2ccc97e057b73
Reviewed-on: https://chromium-review.googlesource.com/1014283Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Rahul Chaturvedi <rkc@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551149}