GitLab

We don't draw layers with non-invertible transforms, so this check is
a waste. Especially in the case where we don't even use the inverse
transform.

R=enne

Review URL: https://codereview.chromium.org/492953002

Cr-Commit-Position: refs/heads/master@{#291242}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291242 0039d316-1c4b-4281-b951-d872f2087c98

Extension options pages often have links to external pages as well as
internal extension pages. When embedded in an <extensionoptions> element
open external links in a new tab, and internal links in the embedded
view (unless specified otherwise).

BUG=386838

Review URL: https://codereview.chromium.org/471053003

Cr-Commit-Position: refs/heads/master@{#291241}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291241 0039d316-1c4b-4281-b951-d872f2087c98

BUG=359249

Review URL: https://codereview.chromium.org/465713002

Cr-Commit-Position: refs/heads/master@{#291240}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291240 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/491733002

Cr-Commit-Position: refs/heads/master@{#291238}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291238 0039d316-1c4b-4281-b951-d872f2087c98

Adding support for PpapiHostMessage_OpenResource to SFI mode is tricky.
Validating the file tokens requires that a message to be sent to the browser
(!) to validate that information in the case of a compromised renderer.

This change is one step to allowing processing for the reply of the
PpapiHostMessage_OpenResource message to send a message to the browser for
constructing a NaClDesc properly.

This makes the encapsulation of NaClMessageScanner a bit worse, but also
reduces the amount of code for which the critical section under lock_ must be
held.

BUG=394130

Review URL: https://codereview.chromium.org/472073003

Cr-Commit-Position: refs/heads/master@{#291234}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291234 0039d316-1c4b-4281-b951-d872f2087c98

Delaying launch of multi-profile for managed accounts to M38, so setting
the default policy to "not-allowed".

BUG=405983

Review URL: https://codereview.chromium.org/469003010

Cr-Commit-Position: refs/heads/master@{#291233}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291233 0039d316-1c4b-4281-b951-d872f2087c98

(Chrome part).
This patch adds code for removing spelling markers under words on 
chrome's side.

BUG=3506

Review URL: https://codereview.chromium.org/411393004

Cr-Commit-Position: refs/heads/master@{#291232}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291232 0039d316-1c4b-4281-b951-d872f2087c98

BUG=405950

Review URL: https://codereview.chromium.org/495123002

Cr-Commit-Position: refs/heads/master@{#291231}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291231 0039d316-1c4b-4281-b951-d872f2087c98

Adjusted DS2784PowerMonitor, DumpsysPowerMonitor, and MonsoonPowerMonitor 
to extend SysfsPowerMonitor to get CPU data. Also cleaned up a little bit
of SysfsPowerMonitor.

BUG=

Review URL: https://codereview.chromium.org/470803006

Cr-Commit-Position: refs/heads/master@{#291230}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291230 0039d316-1c4b-4281-b951-d872f2087c98

BUG=405682

Review URL: https://codereview.chromium.org/495723002

Cr-Commit-Position: refs/heads/master@{#291228}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291228 0039d316-1c4b-4281-b951-d872f2087c98

Remove enable-browser-text-subpixel-positioning flag.

BUG=388844
TEST=covered by tests

Review URL: https://codereview.chromium.org/485873002

Cr-Commit-Position: refs/heads/master@{#291227}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291227 0039d316-1c4b-4281-b951-d872f2087c98

This allows us to allocate a smaller region when painting native
controls on Mac.

BUG=247716

Review URL: https://codereview.chromium.org/462423006

Cr-Commit-Position: refs/heads/master@{#291226}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291226 0039d316-1c4b-4281-b951-d872f2087c98

We prefer immutable texture to mutable texture and normal texture to framebuffer target texture.

There are 3 changes;
1. Introduce TextureHint enum to clarify immutable and framebuffer target.
2. The texture for render pass and background filter target is changed from mutable
 framebuffer texture to immutable framebuffer texture.
3. The texture for background filter source is changed from mutable framebuffer
 texture to mutable texture.

TEST=ResourceProviderTest.TextureHint, ResourceProviderTest.TextureAllocationHint
BUG=404986

Review URL: https://codereview.chromium.org/486853002

Cr-Commit-Position: refs/heads/master@{#291223}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291223 0039d316-1c4b-4281-b951-d872f2087c98

This allows embedders to send a chunk when they do not yet know if it is
the final chunk or not.

BUG=405678

Review URL: https://codereview.chromium.org/492063002

Cr-Commit-Position: refs/heads/master@{#291222}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291222 0039d316-1c4b-4281-b951-d872f2087c98

Functionality:

The |AppRegistry| has for each running application an |AppActivityRegistry|.

The |AppActivityRegistry| knows all activities associated with the application it represents.
It can furthermore shut the app entirely down upon resource manager request. It will then create
an |AppActivityProxy| for the overview mode which shows a placeholder for an unloaded app. This
placeholder can then ask the |AppActivityRegistry| to restart the application again.

A shutdown request for the application is only performed when all activities were marked for
UNLOAD.

If there were multiple activities upon shutdown for one app, the app has to take care of
re-creating all windows and thus re-creating all activities. Since an activity match cannot
be performed, the |AppActivityProxy| will only be shown once and it will show in the location
of the most recently used activity of that app. If we later on find an app which really uses
multiple windows and it is imperative to keep the history for all of them tact & the app is
recreating them properly, (a lot of if's) we can revisit the single |AppActivityProxy| and
try to address it in a cleaner way, but at this time that seems rather un-useful since it is
not known if required.

BUG=388085
TEST=AppActivityTest.*

Review URL: https://codereview.chromium.org/477523002

Cr-Commit-Position: refs/heads/master@{#291221}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291221 0039d316-1c4b-4281-b951-d872f2087c98

Some extension files are compiled on android when enable_plugins is set
to 1. These files need to have the parts that references extension
files compiled out of the code.

BUG= https://code.google.com/p/nativeclient/issues/detail?id=3032
TEST= trybots

Review URL: https://codereview.chromium.org/468913006

Cr-Commit-Position: refs/heads/master@{#291219}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291219 0039d316-1c4b-4281-b951-d872f2087c98

 * AppListViewDelegate was accessing deleted search_provider.
 * DeviceSocketListener::StopListening can happen after DeviceSocketManager is deleted
 * Explicitly delete FilePathWatcher. This was causing
   recursive callback to FilePathWatcherImpl::Cancel from
   FilePathWatcherImpl::CancelOnMessageLoopThread, which
   caused crash.


Clean ups
 * change OnIO to OnFILE as they run on FILE thread.
 * removed unused singleton related code.

BUG=None
TEST=Run athena_main on desktop and close window.

Review URL: https://codereview.chromium.org/490033003

Cr-Commit-Position: refs/heads/master@{#291214}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291214 0039d316-1c4b-4281-b951-d872f2087c98

BUG=403618

Review URL: https://codereview.chromium.org/475263002

Cr-Commit-Position: refs/heads/master@{#291213}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291213 0039d316-1c4b-4281-b951-d872f2087c98

Original: https://codereview.chromium.org/487913004/
Reverted because of a conflict with a patch that landed after it.
Only change is to use the new location for id_util (crx_file).

Original Description:
Only show the checkbox for all urls when the switch is on
BUG=402958

TBR=kalman@chromium.org

Review URL: https://codereview.chromium.org/490793003

Cr-Commit-Position: refs/heads/master@{#291212}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291212 0039d316-1c4b-4281-b951-d872f2087c98

Update existing configs and add a bunch more.

BUG=396139,357253,361300

Review URL: https://codereview.chromium.org/491113002

Cr-Commit-Position: refs/heads/master@{#291211}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291211 0039d316-1c4b-4281-b951-d872f2087c98

* No need to pass manager in callback
* No need to keep pointer to manager in provider
* Rename test methods Foo to FooForTesting

Review URL: https://codereview.chromium.org/486203004

Cr-Commit-Position: refs/heads/master@{#291209}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291209 0039d316-1c4b-4281-b951-d872f2087c98

Design Doc (Googlers Only):
https://docs.google.com/a/google.com/document/d/1RUY0BcxBppdkwFP3T8qbQmQStBRFGsLmuR4WuIXhiCA/edit

BUG=384011
TBR=timsteele@chromium.org

Review URL: https://codereview.chromium.org/379283002

Cr-Commit-Position: refs/heads/master@{#291207}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291207 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#291206}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291206 0039d316-1c4b-4281-b951-d872f2087c98

See https://codereview.chromium.org/484923003

R=tomfinegan@chromium.org

Review URL: https://codereview.chromium.org/497513002

Cr-Commit-Position: refs/heads/master@{#291204}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291204 0039d316-1c4b-4281-b951-d872f2087c98

This patch contains a test page used for manually checking the
functionality of the Battery Status API. It is currently also
available at http://jsbin.com/battery-status-test.

BUG=

Review URL: https://codereview.chromium.org/464073003

Cr-Commit-Position: refs/heads/master@{#291203}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291203 0039d316-1c4b-4281-b951-d872f2087c98

BUG=403007
TBR=yurys@chromium.org

Review URL: https://codereview.chromium.org/493203003

Cr-Commit-Position: refs/heads/master@{#291202}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291202 0039d316-1c4b-4281-b951-d872f2087c98

(vs always opening on the first screen like it's happening now)

BUG=405602
TEST=Start Chrome with --enable-new-avatar-menu (if it's not own by default). If you've got to screens, when you press "Switch users" the User Manager should show up on whatever screen you triggered it from.

Review URL: https://codereview.chromium.org/489953002

Cr-Commit-Position: refs/heads/master@{#291201}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291201 0039d316-1c4b-4281-b951-d872f2087c98

BUG=405747

Review URL: https://codereview.chromium.org/493973002

Cr-Commit-Position: refs/heads/master@{#291200}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291200 0039d316-1c4b-4281-b951-d872f2087c98

This adds the ui/keyboard:keyboard_unittests target to the GN build and
adds the rest of ui/keyboard/webui/ to the build.  Since the webui bits
are the only parts that need mojo the mojo deps are restricted to that
source set.

R=sky@chromium.org

Review URL: https://codereview.chromium.org/493833002

Cr-Commit-Position: refs/heads/master@{#291199}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291199 0039d316-1c4b-4281-b951-d872f2087c98

The DataTypeManager is now in charge of reenabling previously failed types.

BUG=368834
R=maniscalco@chromium.org

Review URL: https://codereview.chromium.org/439903002

Cr-Commit-Position: refs/heads/master@{#291198}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291198 0039d316-1c4b-4281-b951-d872f2087c98

heap_profiler_unittests was previously a native executable target.
It turns out that we don't have the harness in place to run native
executable tests reliably on all Android versions due to the PIE
vs non-PIE issue (L vs ICS, see crbug.com/373219).
This caused a revert in crrev.com/416003005.
This change is making heap_profiler_unittests an apk target, following
the same pattern of the other tests we have in the codebase.
This change is also re-adding the tests to the the bot list.

BUG=393964

Review URL: https://codereview.chromium.org/465223005

Cr-Commit-Position: refs/heads/master@{#291197}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291197 0039d316-1c4b-4281-b951-d872f2087c98

A context factory is specific to a particular native viewport so we
shouldn't leak it between different WindowTreeHostImpl instances. This
fixes some crashes in mojo_view_manager_unittests.

R=sky@chromium.org

Review URL: https://codereview.chromium.org/494883002

Cr-Commit-Position: refs/heads/master@{#291196}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291196 0039d316-1c4b-4281-b951-d872f2087c98

- Some OEMs don't let us change the background, so the padding is incorrect.
- Also including sizing the menu too large causes clipping.

BUG=398837

Review URL: https://codereview.chromium.org/469673006

Cr-Commit-Position: refs/heads/master@{#291193}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291193 0039d316-1c4b-4281-b951-d872f2087c98

only when needed, and deleted as soon as they are no longer necessary.

Add methods to SSLClientSocketPool that are passed to the SSLConnectJob
and SSLConnectJobMessenger as callbacks. These allow the SSLConnectJob
to tell the SSLClientSocketPool to create a messenger for the job when
appropriate, and the SSLConnectJobMessenger to tell the
SSLCLientSocketPool to remove a messenger when appropriate. An
SSLConnectJob will now only create an SSLConnectJobMessenger if its
socket's session is not already in the session cache. The messenger
will then ask to be removed when there are no remaining pending or
connecting sockets in the messenger.

Written by Mackenzie Shelley <mshelley@chromium.org>
Original review URL: https://codereview.chromium.org/384873002/

R=rsleevi@chromium.org
TBR=mek@chromium.org
BUG=398967

Review URL: https://codereview.chromium.org/476313004

Cr-Commit-Position: refs/heads/master@{#291192}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291192 0039d316-1c4b-4281-b951-d872f2087c98

This CL enables usage of the Sync FakeServer in Android tests. This is
done by creating a new ChromeShell-based APK, ChromeSyncShell, and a
test APK that instruments it (ChromeSyncShellTest).

As part of this CL, previously-disabled tests (SyncTest.java) are
re-enabled. However, these tests will not run as part of the Chromium
waterfall/trybots as they are not configured to run ChromeSyncShellTest.

How to run the tests:
1) Build these targets:
   chrome_sync_shell_apk
   chrome_sync_shell_test_apk

2) Run test script
   build/android/adb_install_apk.py \
   --apk=ChromeSyncShell.apk && \
   build/android/test_runner.py instrumentation \
   --test-apk ChromeSyncShellTest

BUG=323265,348951,348117
TBR=cpu@chromium.org

Review URL: https://codereview.chromium.org/457883002

Cr-Commit-Position: refs/heads/master@{#291190}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291190 0039d316-1c4b-4281-b951-d872f2087c98

Shared Authentication is the only supported scheme starting with M39.
This CL removes the dependency on MutableProfileOAuth2TokenService
on iOS.

BUG=233117

Review URL: https://codereview.chromium.org/489113003

Cr-Commit-Position: refs/heads/master@{#291189}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291189 0039d316-1c4b-4281-b951-d872f2087c98

The code made assumptions about whether the window's root view was layer
backed. The CL that introduced the bug:
https://codereview.chromium.org/390503003/

BUG=NONE

Review URL: https://codereview.chromium.org/481273002

Cr-Commit-Position: refs/heads/master@{#291188}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291188 0039d316-1c4b-4281-b951-d872f2087c98

Some of the VDAs, like DXVA and AVDA, don't distinguish
between visible size and coded size. And given GVD is always
been used with container, we should keep using size from
config in GVD.

BUG=390048
TEST=Manually tested: flash player using youtube. html5
player with resolution 1280x720 and 1216x684, h264 and vp8.
apprtc with resolution 640x480 and 636x476. All tests are
performed on both daisy and link.
R=hshi@chromium.org, posciak@chromium.org

Review URL: https://codereview.chromium.org/426873004

Cr-Commit-Position: refs/heads/master@{#291187}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291187 0039d316-1c4b-4281-b951-d872f2087c98

Trackers for empty-title files were not handled in AddToPathIndexes()
and UpdateInPathIndexes(), while they are handled in RemoveFromPathIndexes().
So an entry in multi-backing lists could be inconsistent.

This CL fixes those two methods' behavior.


BUG=405448
TEST=./unit_tests --gtest_filter="MetadataDatabaseIndexOnDisk*"

Review URL: https://codereview.chromium.org/493643002

Cr-Commit-Position: refs/heads/master@{#291186}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291186 0039d316-1c4b-4281-b951-d872f2087c98

This patch implements Chart JSON for Telemetry, which represents a JSON format specifically for conveying data to Buildbot to be sent to the perf dashboard in charted/summarized form. 
Consult go/telemetry-json for further specs on this format.
This is an 0.1 since the overall metadata and description portions of the format are still in flux.

BUG=399970

Review URL: https://codereview.chromium.org/439613003

Cr-Commit-Position: refs/heads/master@{#291185}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291185 0039d316-1c4b-4281-b951-d872f2087c98