GitLab

The assertion failure in HarfBuzzShaper is triggered because the TextRun
passed to paintTextWithShadows is replaced with
objectReplacementCharacterTextRun which only has a length of 1.
Previously, we did not have an implementation of emphasis mark
drawing for complex text with HarfBuzz, so instead of running into the
assertion, those paint calls were not doing anything.  The indices have
been wrong since the emphasis marks drawing for RenderCombineText
elements was fixed in 7565e3bbdccf98450271 (in 2011).  I updated the
test case to be equivalent to the original fuzz testing report and so
that it actually combines text that is marked as combined where no
font with narrow digits exists.

BUG=348682

Review URL: https://codereview.chromium.org/187783002

git-svn-id: svn://svn.chromium.org/blink/trunk@168592 bbb929c8-8fbe-4397-9dbb-9b2b20218538

See the bug and http://crrev.com/255129 for the details.

BUG=345554
R=haraken@chromium.org, jamesr@chromium.org

Review URL: https://codereview.chromium.org/177053003

git-svn-id: svn://svn.chromium.org/blink/trunk@168591 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=168578

BUG=349222
TBR=qinmin@chromium.org

Review URL: https://codereview.chromium.org/187813010

git-svn-id: svn://svn.chromium.org/blink/trunk@168590 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These header files are not being referenced from anywhere. They were replaced by NewSVGAnimatedProperty.h

BUG=349370
TBR=haraken,pdr,fs

Review URL: https://codereview.chromium.org/188413003

git-svn-id: svn://svn.chromium.org/blink/trunk@168589 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Now TestRunner is being moved from CppBoundClass to gin::Wrappable,
where it is not appropriate to use WebElements directly. This CL moves
some functions which treats WebElement* from testRunner to internals.
(To be exact, this CL only copies some functions, but I'll remove those ones
in testRunner later.)

BUG=331301

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168495

Review URL: https://codereview.chromium.org/176953009

git-svn-id: svn://svn.chromium.org/blink/trunk@168588 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL also removes all calls to |localAttributeToPropertyMap()| and |registerAnimatedPropertiesFor##OwnerType()|, the methods which were defined via the macros. This map was already empty, so no change in behavior.
|SVGElement::cleanupAnimatedProperties()| contents are moved back to |~SVGElement()| again, as they were temporary workaround for the old SVGProperty implementation bug.

BUG=308818
NOTRY=true

Review URL: https://codereview.chromium.org/177803003

git-svn-id: svn://svn.chromium.org/blink/trunk@168587 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The members of RTCIceCandidate are no longer read-only.

BUG=349437

Review URL: https://codereview.chromium.org/187673002

git-svn-id: svn://svn.chromium.org/blink/trunk@168586 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change makes shapes implementation inline with webkit's.
Also using references is lot safe for caller method and
also removes extra null checks.

Insprired by https://bugs.webkit.org/show_bug.cgi?id=124876

Review URL: https://codereview.chromium.org/178473024

git-svn-id: svn://svn.chromium.org/blink/trunk@168585 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=255363

Review URL: https://codereview.chromium.org/187823003

git-svn-id: svn://svn.chromium.org/blink/trunk@168584 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This makes StyleSheets RefCountedGarbageCollected. Next step is
removing RefPtrs and raw pointers and dealing with finalization
order issues.

R=erik.corry@gmail.com, haraken@chromium.org, wibling@chromium.org
BUG=

Review URL: https://codereview.chromium.org/187313005

git-svn-id: svn://svn.chromium.org/blink/trunk@168583 bbb929c8-8fbe-4397-9dbb-9b2b20218538

idl_definitions_builder.py was separate from idl_definitions.py
b/c the latter had lots of Perl compatibility cruft (JSON export etc.)
Now that it's gone, there's no reason to have these separate, as
idl_definitions was almost only class definitions, and
idl_definitions_builder was basically constructors.

Keeping them separate made it harder to read (b/c had to bounce back
and forth), and the calls to the actual constructors were incredibly
long.

This merges them, deleting one file and making the code quite simple.
Net -70 lines, though more like -100 due to adding a few comments
(class diagram).

Change is just merging the functions into constructors (in a few cases
changing an alternative constructor into a class method) and adding
a few comments.

Further cleanup is possible (remove IdlEnum and IdlUnionType),
but involve CG changes, so will do in followup.

BUG=345137
TBR=haraken

Review URL: https://codereview.chromium.org/177233006

git-svn-id: svn://svn.chromium.org/blink/trunk@168582 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL broke oilpan Debug builds with clang.

>
../../third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp
> 1.      <eof> parser at end of file
> 2.      Per-file LLVM IR generation
> 3.      ../../third_party/WebKit/Source/heap/Heap.h:904:10: Generating code
for
> declaration
> 'WebCore::GarbageCollectedFinalized<WebCore::CSSCalcExpressionNode>::finalize'
> clang: error: unable to execute command: Aborted (core dumped)
> clang: error: clang frontend command failed due to signal (use -v to see
> invocation)



> Remove unneeded destructors and add finalization support to various classes.
> 
> Issues reported by the Blink GC clang plugin.
> 
> R=haraken@chromium.org
> BUG=
> 
> Review URL: https://codereview.chromium.org/184853006

TBR=zerny@chromium.org

Review URL: https://codereview.chromium.org/183853038

git-svn-id: svn://svn.chromium.org/blink/trunk@168581 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL might broke browser_tests in Mac:
http://build.chromium.org/p/chromium.webkit/builders/Mac10.8%20Tests/builds/6374

> id of iframe incorrectly sets window name
> 
> As per the specification, the iframe's name should be an empty string if unset:
> http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe-element.html#attr-iframe-name
> 
> Instead, Chromium was using the iframe's id as window name if the name was
> unset. This change makes us behave like Firefox 27 and IE 11, verified using:
> http://jsfiddle.net/xf5H7/9/
> 
> This CL sets the name attribute iframe in a lot of layout tests so that
> testRunner.dumpChildFramesAsText() keeps printing the same result.
> 
> R=arv@chromium.org, tkent@chromium.org, abarth, arv, tkent
> BUG=347169
> TEST=fast/frames/iframe-no-name.html
> 
> Review URL: https://codereview.chromium.org/187103002

TBR=ch.dumez@samsung.com

Review URL: https://codereview.chromium.org/184633004

git-svn-id: svn://svn.chromium.org/blink/trunk@168579 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Subtitle support for native fullscreen video is enabled in https://codereview.chromium.org/22454003/.
However, there are a couple bugs:
1. FullscreenElementStack::currentFullScreenElementFrom() returns NULL if the 
fullscreen element is in a child frame, we need to use 
FullscreenElementStack::fullscreenElementFrom().

2. When the video element is appended to the top level frame, we should exclude 
it when rebuilding the compositing layer tree.

A new layout test is added: fullscreen/full-screen-iframe-allowed-video.html

This CL also fixes a bug that some of the fullscreen pixel tests are no longer 
running due to  https://codereview.chromium.org/24438004

BUG=349222,347843

Review URL: https://codereview.chromium.org/187193002

git-svn-id: svn://svn.chromium.org/blink/trunk@168578 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The isCSSPrimitiveValue check is likely covering up parser bugs,
and toCSSPrimitiveValue has the assert to ensure we're not
doing something bad.

R=eae,ksakamoto@chromium.org,timloh@chromium.org
BUG=

Review URL: https://codereview.chromium.org/184103034

git-svn-id: svn://svn.chromium.org/blink/trunk@168577 bbb929c8-8fbe-4397-9dbb-9b2b20218538

If a constructor attribute is annotated with either [MeasureAs=..] or
[DeprecateAs=..], then emit a needed callback wrapper that performs
the required reporting before looking up the constructor.

Use it to correctly handle use counters for the "webkitURL" properties
that both Window and WorkerGlobalScope currently provide; use counters
also added for these here.

(The above change also happens to fix use counter reporting
for the window.WebKitShadowRoot constructor.)

R=nbarth@chromium.org,haraken@chromium.org
BUG=348985

Review URL: https://codereview.chromium.org/186673002

git-svn-id: svn://svn.chromium.org/blink/trunk@168576 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change moves effect and timing conversion logic out of Animation
and into EffectInput and TimingInput respectively.

This refactor includes a minor change in behaviour:
Animations created on elements without an active document renderer will no
longer return null, instead the animation's effect will be null.
This behaviour still avoids calls to the CSS parser and style resolver if
the check fails.

Review URL: https://codereview.chromium.org/182063005

git-svn-id: svn://svn.chromium.org/blink/trunk@168575 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Some change used PassRefPtrWillBeRawPtr for AnimatableColor which is not yet on the heap.
Thus build is broken in oilpan bots. This CL fixes it.

TBR=kouhei

Review URL: https://codereview.chromium.org/183183010

git-svn-id: svn://svn.chromium.org/blink/trunk@168574 bbb929c8-8fbe-4397-9dbb-9b2b20218538

 determine shrink-to-fit behavior

In order to determine whether the RemainingSpace is 
undetermined or not (shrink-to-fit) the current algorithm 
is checking out the style for clarifying if the Render object 
is float or absolute positioned.

It's better to use the Render functions instead, since the 
style might be applied or not, depending on several factors, 
like CSS properties inheritance.

BUG=79180, 234204

Review URL: https://codereview.chromium.org/181333003

git-svn-id: svn://svn.chromium.org/blink/trunk@168573 bbb929c8-8fbe-4397-9dbb-9b2b20218538

MediaControlPanelMuteButtonElement/MediaControlPanelVolumeSliderElement
were the only classes that inherited
MediaControlMuteButtonElement/MediaControlVolumeSliderElement.

Remove the m_panelMuteButton->show() in MediaControls::reset(), because
there is nothing that ever hides the button in the first place.

BUG=341813

Review URL: https://codereview.chromium.org/185363011

git-svn-id: svn://svn.chromium.org/blink/trunk@168572 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The noshade attribute is a boolean attribute and when set on hr element
it shows a gray color. When there is color attribute the default gray
color should be replaced by the color mentioned by the color attribute.
Firefox and IE show the same behaviour but Blink is different. Making
the behaviour of Blink similiar to Firefox and IE's behaviour.

When the color attribute is present that value is applied and the
default gray color is ignored. Incase of no color attribute the default
gray color is applied.

I already landed this patch on Webkit. Just modified the layout test file.
http://trac.webkit.org/changeset/161334

R=esprehn@chromium.org,eseidel@chromium.org
BUG=175359

Review URL: https://codereview.chromium.org/162993002

git-svn-id: svn://svn.chromium.org/blink/trunk@168571 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=348581

Review URL: https://codereview.chromium.org/185593011

git-svn-id: svn://svn.chromium.org/blink/trunk@168570 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/186763002

git-svn-id: svn://svn.chromium.org/blink/trunk@168569 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Issues reported by the Blink GC clang plugin.

R=haraken@chromium.org
BUG=

Review URL: https://codereview.chromium.org/184853006

git-svn-id: svn://svn.chromium.org/blink/trunk@168568 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The File API now defines Blobs as having a readability state of
opened/closed, http://dev.w3.org/2006/webapi/FileAPI/#readabilityState
With close() naturally making the Blob enter the 'closed' state,

  http://dev.w3.org/2006/webapi/FileAPI/#close-method

Like the FileReader operations, Blob methods will now throw
InvalidStateError when passed a Blob in such a 'closed' state.

Update the implementation to follow the spec.

R=kinuko@chromium.org
BUG=344820

Review URL: https://codereview.chromium.org/184473002

git-svn-id: svn://svn.chromium.org/blink/trunk@168567 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of DevTools: Enable antialiasing in the pie chart. (https://codereview.chromium.org/179853002/)

Reason for revert:
This change introduced significant performance penalty - paint time prevents timeline from animating even at 30 fps.

Original issue's description:
> DevTools: Enable antialiasing in the pie chart.
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168025

TBR=yurys@chromium.org,caseq@chromium.org,alph@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/188053004

git-svn-id: svn://svn.chromium.org/blink/trunk@168566 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Old profile is removed on HeapProfiler.resetProfiles message and a new one is added immediately to collect all object allocation events from the backend after navigation.

BUG=None

Review URL: https://codereview.chromium.org/172163005

git-svn-id: svn://svn.chromium.org/blink/trunk@168565 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://codereview.chromium.org/172263002/ moves AccessibilityController
from CppBoundClass to gin::Wrappable, and that CL changes this cached-
properties test's result so that 'accessibilityController' is enumerated
as properties of an object. However, it is hard to expect a stable cache
result of WebAXObject of AccessibilityController for now.

BUG=297480, 331301, 347331

Review URL: https://codereview.chromium.org/184233004

git-svn-id: svn://svn.chromium.org/blink/trunk@168564 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The spec now says that getUserMedia error messages are UA specific with
the exception for PermissionDeniedError and ConstraintNotSatisfied.

BUG=132812

Review URL: https://codereview.chromium.org/180683003

git-svn-id: svn://svn.chromium.org/blink/trunk@168562 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Intent to implement on blink-dev:
https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/addPath/blink-dev/YY-FmD8Efhc/y4Ag3pGF-toJ

BUG=159839

Review URL: https://codereview.chromium.org/170503002

git-svn-id: svn://svn.chromium.org/blink/trunk@168561 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We are currently removing trying to remove all references to base::Time (wall
clock time) from Chrome/Blink compositor/graphics stack.

This requires multiple two-sided patches. Following the process found at
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/ukaRczAK6t8/0ludyZ1Nu4cJ

The steps are;
 * (This Patch) -- Adding monotonic only API to Blink's animation delegate interface
   https://codereview.chromium.org/185633002

 * Making the delegate adapter use monotonic only API
   https://codereview.chromium.org/185643002

 * Remove the wallClockTime API from Blink/WebKit.
   https://codereview.chromium.org/185393005

BUG=299945

Review URL: https://codereview.chromium.org/185633002

git-svn-id: svn://svn.chromium.org/blink/trunk@168560 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Distance is defined in
http://dev.w3.org/fxtf/web-animations/ section 4.1.3.5

Web Animations use property distance calculations in paced keyframe animation effects, in assigning the timing for keyframes so that a 'paced' property changes at constant velocity.

BUG=348896

Review URL: https://codereview.chromium.org/186463002

git-svn-id: svn://svn.chromium.org/blink/trunk@168559 bbb929c8-8fbe-4397-9dbb-9b2b20218538

For any value update, dispatch both input and change event.

Also removes extra dispatch change event, as event are dispatch from TextFieldInputType:setValue.

R=tkent, keishi1
BUG=345611
TEST=On keyboard event, both oninput and onchange event are triggered

Review URL: https://codereview.chromium.org/178593003

git-svn-id: svn://svn.chromium.org/blink/trunk@168558 bbb929c8-8fbe-4397-9dbb-9b2b20218538

fabsf() is for float, use fabs() for double instead.

BUG=chromium:348044

Review URL: https://codereview.chromium.org/176713008

git-svn-id: svn://svn.chromium.org/blink/trunk@168557 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL broke win builds:
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20Builder%20%28dbg%29/builds/47919


> Reduce compositing update in Silk's toggle_drawer by 20%
> 
> This reduces the amount of time spent in compositing update for Silk's
> toggle_drawer test case by 20%. Previously, we would update the geometry for
> every composited layer mapping during every compositing update, regardless of
> whether any of the inputs to updateGraphicsLayerGeometry had changed. This CL
> introduces dirty bits on CompositedLayerMapping to track which RenderLayers
> underwent a change that could have resulted in changes during
> updateGraphicsLayerGeometry.
> 
> This CL takes a basic approach, which is sufficient for toggle_drawer.
> Specifically, if a RenderLayer changes style, we mark its
> CompositedLayerMapping (and any ancestors and decendants) as needing a geometry
> update. If we go through layout or scroll, we trigger a forced update, which
> updates the geometry of all graphics layers.
> 
> Over time, we can improve this system to track dirtiness during layout. We
> might also be able to avoid marking every ancestor dirty if we removed the
> downward tree walks during updateGraphicsLayerGeometry. Instead, we could
> compute the descendant-dependant information in an earlier phase and detect
> whether it changed directly.
> 
> R=esprehn@chromium.org, ojan@chromium.org
> 
> Review URL: https://codereview.chromium.org/183763016

TBR=abarth@chromium.org

Review URL: https://codereview.chromium.org/180953009

git-svn-id: svn://svn.chromium.org/blink/trunk@168556 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In profiling updateStyle on Silk's toggle_drawer test case, we saw some time
being spent updating the style of the resizer, which is wasted work because
there is no resizer. This CL teaches the code not to do work if there's no
resizer.

R=esprehn@chromium.org
BUG=335703

Review URL: https://codereview.chromium.org/182733014

git-svn-id: svn://svn.chromium.org/blink/trunk@168555 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This reduces the amount of time spent in compositing update for Silk's
toggle_drawer test case by 20%. Previously, we would update the geometry for
every composited layer mapping during every compositing update, regardless of
whether any of the inputs to updateGraphicsLayerGeometry had changed. This CL
introduces dirty bits on CompositedLayerMapping to track which RenderLayers
underwent a change that could have resulted in changes during
updateGraphicsLayerGeometry.

This CL takes a basic approach, which is sufficient for toggle_drawer.
Specifically, if a RenderLayer changes style, we mark its
CompositedLayerMapping (and any ancestors and decendants) as needing a geometry
update. If we go through layout or scroll, we trigger a forced update, which
updates the geometry of all graphics layers.

Over time, we can improve this system to track dirtiness during layout. We
might also be able to avoid marking every ancestor dirty if we removed the
downward tree walks during updateGraphicsLayerGeometry. Instead, we could
compute the descendant-dependant information in an earlier phase and detect
whether it changed directly.

R=esprehn@chromium.org, ojan@chromium.org

Review URL: https://codereview.chromium.org/183763016

git-svn-id: svn://svn.chromium.org/blink/trunk@168554 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As per the specification, the iframe's name should be an empty string if unset:
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe-element.html#attr-iframe-name

Instead, Chromium was using the iframe's id as window name if the name was
unset. This change makes us behave like Firefox 27 and IE 11, verified using:
http://jsfiddle.net/xf5H7/9/

This CL sets the name attribute iframe in a lot of layout tests so that
testRunner.dumpChildFramesAsText() keeps printing the same result.

R=arv@chromium.org, tkent@chromium.org, abarth, arv, tkent
BUG=347169
TEST=fast/frames/iframe-no-name.html

Review URL: https://codereview.chromium.org/187103002

git-svn-id: svn://svn.chromium.org/blink/trunk@168553 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Also, apply zoom to layer div sizes to keep resulting layers small.

BUG=

Review URL: https://codereview.chromium.org/177353005

git-svn-id: svn://svn.chromium.org/blink/trunk@168552 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- webaudio/codec-tests/vorbis/vbr-128kbps-44khz.html
- webaudio/codec-tests/vorbis/vbr-70kbps-44khz.html
- webaudio/codec-tests/vorbis/vbr-96kbps-44khz.html

TBR=rtoy@chromium.org,dalecurtis@chromium.org
BUG=349662

Review URL: https://codereview.chromium.org/187323008

git-svn-id: svn://svn.chromium.org/blink/trunk@168551 bbb929c8-8fbe-4397-9dbb-9b2b20218538