- 19 Aug, 2020 40 commits
-
-
tby authored
Most search result data is stored in a SearchResultMetadata object, which is synced between the ash and chrome objects representing results. One exception is the ash::SearchResultType enum which, confusingly named, is only used for metrics. Currently this enum is available via a virtual method on the chrome-side only. To fix a race condition in the impressions system, we now need to treat it like other search result data. This CL adds methods to SearchResultMetadata, deletes the old chrome getter, updates all ChromeSearchResult subclasses to correctly set the metadata. The ChromeSearchResult subclass updates are mostly trivial, these have slightly more logic: - chrome_search_result itself - arc_app_data_search_result - omnibox_result Bug: 1076270 Change-Id: I1b1da0e3248031df3f31c2cd8b622dfb0487e390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352256Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#799446}
-
Zhenyao Mo authored
This is Windows only. DWM won't consider a swap chain as an overlay candidate unless it's updating at high enough fps with full damages. So we need to force full damage when the actual damage is closer to full damage in order to promote the main back buffer as an overlay. This CL also added the bit to allow viz to make sure swap chain's buffers always have up to date pixels inside or outside damage rects. This enables us to force full damage. BUG=1117185 TEST=manual R=sunnyps@chromium.org,magchen@chromium.org Change-Id: Idff7a90952c810a07992df0ace040be92b63e4d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359730 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#799445}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I6de3fb6e0c3130e3b9736498a1fa531b988fabb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363919Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#799444}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/df143e8b..6a992541 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0409b008138e655fae909cef8643af7227038641 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362336Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799443}
-
Yi Gu authored
Bug: None Change-Id: I3557fcc552ca4e5505226dd20f978949bbae0de5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363491Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#799442}
-
Bettina authored
These histograms are needed because we can know how often synced account passwords are used and how often both synced and non-synced passwords are changed in comparison to how often they're reused. Bug: 1117113,1117111 Change-Id: I1ab9d79196f28fadeabbe9177052f85bf8523064 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358595Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#799441}
-
Tommy Li authored
This CL replaces the placeholder English strings with their internationalized equivalent. Bug: 893183 Change-Id: I62f828c6db7fb40a421feb2352fb4f49a5fa1738 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363641 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#799440}
-
Peter Boström authored
This introduces DialogModelField::AsButton, etc. instead of having DialogModelHost and DialogModel both downcast. Also adds DialogModel::AddField to make sure OnFieldAdded() is called from all call sites that add a field. Bug: 1106422 Change-Id: I512f5df9cf642314de7bde5b9ef4fe1d7c3efedc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363870 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#799439}
-
chrome://flagsWan-Teh Chang authored
Valid for five milestones: 86-90. In the chrome://flags UI, the entry looks like this: Enable AVIF image format Adds image decoding support for the AVIF image format. – Mac, Windows, Linux, Chrome OS #enable-avif Test: Manual test in chrome://flags. unit_tests --gtest_filter=AboutFlagsHistogramTest.CheckHistograms unit_tests --gtest_filter=AboutFlagsTest.EveryFlagHasMetadata Bug: 1117843 Change-Id: If293557d795c192c62918c932a72edf3b2d265e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363718 Commit-Queue: Wan-Teh Chang <wtc@google.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#799438}
-
David Munro authored
The path to disks has changed recently, so update the path we expect. Bug: chromium:1114826 Test: Manual, CQ Change-Id: I9f9bb5271d57021dd1c9559e9e7f858ce83dc059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362163 Auto-Submit: David Munro <davidmunro@google.com> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#799437}
-
Mehrdad Hessar authored
Bug: 1116210 Change-Id: I09a3ddbea5756cc569d38805b5c11e4f06ecee6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357679 Commit-Queue: Mehrdad Hessar <mehrdadh@google.com> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#799436}
-
Daniel Rubery authored
In preparation for per-profile SafeBrowsingNetworkContexts, we add a check to SafeBrowsingRemoveCookies in ChromeEnterpriseRealTimeUrlLookupServiceFactory, which will start using the Profile URLLoaderFactory with no credentials. Bug: 1049833 Change-Id: Ib2999c188ae3a4e49c1fd784816c0115c288b9d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360553Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#799435}
-
Kent Tamura authored
LayoutNGButton inherits from LayoutNGFlexibleBox. However it's an implementation detail, and we might change the base class in the future. This CL has no behavior changes. Bug: 1040826 Change-Id: I71aabd4b3bfdc9d1b6612c97aeb1fd3bff08a15d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362347 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#799434}
-
Brian Sheedy authored
Switches several GPU pixel tests on Fuchsia to use the new full screenshot capabilities in Telemetry instead of the version that only captures the visible portion of the web contents. This fixes the tests on Fuchsia, where the device screen is significantly smaller than previously tested devices. This path is not used everywhere because capturing the screenshot using fromSuface: True is less likely to catch GPU issues. Bug: 1115680 Change-Id: I69423b4995978c1455978b7d9bdc6e80192b6ccd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355133Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#799433}
-
Xinghui Lu authored
Add a histogram named "SafeBrowsing.Settings.UserAction" to log user actions on the Safe Browsing settings page. The metrics are suffixed with AccessPoint. Currently the AccessPoint can be either the privacy page or the safety check page. In the future, we will likely introduce more access points to promote Enhanced Safe Browsing. The enums are added on the native side, because they will be reused on the desktop setting page in the future. Bug: 1115758 Change-Id: I90ff69ddd3f6a7bf836e06cf69f63ea02cdf7344 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357677 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
-
Martin Kreichgauer authored
This adds the ability to selectively ignore HID FIDO devices by VID/PID during discovery in FidoHidDiscovery and ignores the ChromeOS u2fd virtual HID device during WebAuthn requests that don't originate from cryptoken if the ChromeOS platform authenticator is flag-enabled. The virtual HID device and the platform authenticator are both implemented in u2fd and both bring their own UI, so having a single WebAuthn request target both would cause all kinds of trouble. The platform authenticator will be able to challenge credentials registered by the virtual HID device via the appID extension. So eventually we might want to make the platform authenticator feature flag disable the virtual HID device during cryptotoken requests as well, and advise users to switch to the WebAuthn API instead. Change-Id: Ic19152fa76bf75079310719e3dcd2bd35466b3dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351139 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#799431}
-
Daniel Rubery authored
For SBER users, we send the SHA256 hash of the blurred image data along with the screenshot_phash. Fixed: 1115720 Change-Id: Ia9ecbbb3e83bd927a12590934492bc1d3f4d5c3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363952 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#799430}
-
Tibor Goldschwendt authored
Every time we update the background image URL the background image fades in. If the new URL is identical to the old URL the fade in is unnecessary. Fixed: 1116936 Change-Id: I58c880dd55dc50528c03614d4d4606c44c1254ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360339 Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#799429}
-
Yuri Wiitala authored
This reverts commit af48c8e6. Reason for revert: Test works now. Original change's description: > [Sheriff] Disable the test > > Disable the failing test on Linux. > > Bug=1108205 > TBR=miu@chromium.org > > Change-Id: Ie388ca75a2fadce937d613994847217e7f9579fc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310271 > Reviewed-by: Hayato Ito <hayato@chromium.org> > Commit-Queue: Hayato Ito <hayato@chromium.org> > Cr-Commit-Position: refs/heads/master@{#790745} TBR=miu@chromium.org,hayato@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I4c43284f7d4a0fec1cd4c05fc375f1f4d406526b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361023Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#799428}
-
Christopher Cameron authored
We use IOSurfaceSetColorSpace's return value to determine if an IOSurface can be an overlay. Continue to return true for these formats, because the HDRCopier will be used to composite them (https://crbug.com/1101041). Bug: 1108627 Change-Id: I06d5282bc508ec61698112f58a1c5f18efe68ebf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363950Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#799427}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c24096ed3b5c..1d251f6f077f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tommycli@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1105096 Tbr: tommycli@google.com Change-Id: Ic53b9fc2f026bab45f8b26a9c9a6670a40b79332 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363426Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799426}
-
Christian Biesinger authored
The newly failing block tests are because this does not yet support min-height: auto. I will investigate the newly failing flex test later. Bug: 1083010 Change-Id: Iedfa1c442d4a7d24a474642c882fe6238fd6f1a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357460 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#799425}
-
Joel Hockey authored
Multiple tests were creating and deleting the same file path, which looks like it lead to the flakes when tests run simultaneously. Now using scoped dirs for each test. Bug: 1117356 Change-Id: I4d949f5dfe735ea084f1a09f2b2f282eb7b1b004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362355 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Fergus Dall <sidereal@google.com> Reviewed-by:
Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#799424}
-
Gang Wu authored
This CL add icons for overflow menu, the icon will be in front of each menu item. Icons defined in main_menu.xml, and AppMenuPropertiesDelegate will decide show them or not. And then AppMenuAdapter will choose layout depending on AppMenuPropertiesDelegate#shouldMenuItemStartWithIcon. Bug:1114440 Change-Id: I160020cb2210053ce904af185c059af25b168580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335389 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#799423}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/560b983ff5a9..fb33bb85a9f7 2020-08-18 brgoddar@microsoft.com Performance: Fix perf issue with Event Log If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1112663 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib219661dae063202feb8df5b884fb5b4a188074e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363955Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799422}
-
John Z Wu authored
Allow client to display a "Suggest password..." suggestion to the user. Upon tapping this suggestion, trigger delegate method asking the user to accept the suggested password. Bug: 1022906 Change-Id: I5a7264eb4efaab3c6bfcafe0a35d82f5eead6e53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316847 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#799421}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/9aed03dcb02f..b54c82ed3948 2020-08-18 enga@chromium.org Support depth-only/stencil-only COPY_SRC on OpenGL 2020-08-18 cwallez@chromium.org Metal: Remove usage of MTLTextureUsagePixelFormatView If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I23a46acee92ef6202695c3cf6a1dd18f9640b2e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363305Reviewed-by:
-
Erik Jensen authored
The asynchronous writing code assumes that pointers to the data stay valid when ownership in transferred via std::move. However, due to the small-string optimization, that is not the case for std::string with less than 23 bytes of data. This CL switches to using std::vector, which is guaranteed by the standard to maintain iterator validity when moved. Bug: 1116785 Change-Id: Ib099eccad2e304ab33ae3d35cb15bd873ca7da18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359189Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Cr-Commit-Position: refs/heads/master@{#799419}
-
Peter Kasting authored
* Avoid restating type * Clarify computations * Follow style guide declaration order * Simplify * FromSecondsD(samples / samples_per_sec) is more unit-correct than FromSeconds(samples) / samples_per_sec * Make definition order match declaration order * Use more appropriate TimeDelta conversion accessors * Don't handle DCHECK failure * Avoid double-negative Bug: none Change-Id: Iedf42e24412bf1b11f3f56cec5f7a818454ab340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359004 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#799418}
-
Sky Malice authored
TBR: boliu@chromium.org Bug: 1117289 Change-Id: I0350cdaa7cf498ba0a40a6e6641f2f0a66f9ca8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359376 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#799417}
-
Sky Malice authored
TBR: wychen@chromium.org Bug: 1118181 Change-Id: I0d932c32a3ae8219f6842dd9c8ce07702b3c6dbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363565Reviewed-by:
-
Russ Hamilton authored
Change-Id: Idd9f8996b430df63f44273c07e6a4ad993aad38a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359558Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Russ Hamilton <behamilton@google.com> Cr-Commit-Position: refs/heads/master@{#799415}
-
rbpotter authored
Bug: 1000989 Change-Id: I8bf967219ae6fb20446bb2d096be49f4a3765be2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360697Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#799414}
-
Wan-Teh Chang authored
I completed an audit of the grid image code in libavif. See bug 1114916. Change-Id: Ifb2d4859bff5fc5647095b04e3bdb4db88a31ae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354777Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#799413}
-
Kenichi Ishibashi authored
This test depends on in-memory representations of service worker registrations and versions. Move the test from service_worker_storage_unittest.cc to service_worker_registry_unittest.cc so that the storage_unittest.cc can be moved to the Storage Service directory. This CL also modifies ServiceWorkerStorage::StoreRegistrationData so that it can LazyInitialize() when uninitialized. This allows the test to eliminate explicit LazyInitialize() call. Bug: 1055677 Change-Id: I2425d9aa964c37191df355f1c5c67ed250cb1f74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361382Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#799412}
-
Haiyang Pan authored
This reverts commit c3907c3e. Reason for revert: Observed multiple test failures in chrome_pulic_test_apk on android builders, since the following builds: * https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-x86-rel/973 * https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel/1894 * https://ci.chromium.org/p/chromium/builders/ci/android-arm64-proguard-rel/2437 Original change's description: > Migrate remaining chrome/android native_java_unittest to javatests > > native_java_unittests are going away, so these tests need to be migrated > to javatests. > > Bug: 1103344 > Change-Id: I49a99d1cc1e3170d4af01af8e1a75e9b09249fc5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353391 > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#799264} TBR=yfriedman@chromium.org,mthiesse@chromium.org Change-Id: Ia64e53afde3d7fdeecb1a4500c74bf6e0ad69ffa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1103344 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363925Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#799411}
-
Miguel Casas authored
ToT VaapiWrapper uses |va_buffers_| for internal Vpp uses and also for external VEA/JEA use. This CL starts refactoring these VABufferIDs lifetime, by splitting the Vpp VABufferID out of |va_buffers_| and into a ScopedID |va_buffer_for_vpp_|. Bug: b:162962069 Change-Id: Ic54d0d26f5d17ea49fe896cf7ca5e1c931d07e0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352522 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#799410}
-
Brandon Wylie authored
This property is captured implicitly by other events. When reparenting, this property isn't captured properly. Adding an explicit event for this to ensure it is. Bug: 1076798 Change-Id: I1e5fa720627128a13e3969abc0a891b37d846936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293160 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#799409}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c4a82aaabbdd..573931528077 2020-08-18 jmadill@chromium.org Auto-gen more Overlay code. 2020-08-18 jmadill@chromium.org Clean up Overlay code duplication. 2020-08-18 jmadill@chromium.org Vulkan: Clean up ImageLayout enum. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: I533bb3e858398874b6c3b0e3e90efc9ab864f9f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363793Reviewed-by:
-
Lily Chen authored
This fixes a crash caused by failure of a consistency check on the Reporting endpoints present in an endpoint group, triggered by receiving malformed Report-To headers (or multiple Report-To headers in one response). Upon parsing a Reporting group from a newly received header, if an equivalent group already exists in the cache, any preexisting endpoints with URLs that are not present in the newly parsed group are removed, i.e. a new header should overwrite the equivalent group set by a previous header. The problem occurs when there are multiple equivalent groups with disjoint endpoint URLs present in the same header (or multple headers on the same response). We should treat these headers as if a single group were specified, containing the combined set of URLs. However, we were deleting preexisting but no-longer-present endpoints multiple times, once for each duplicate group listed. The (malformed) header would effectively overwrite previous parts of itself, causing a consistency check failure. This is fixed by removing old endpoints only after the entire header has been processed. Bug: 1116529 Change-Id: I1bf5d57db2acf9f90a9d1cb63a5b1b79d9145fca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357468 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#799407}
-
