- 29 Aug, 2019 40 commits
-
-
rbpotter authored
It is not correct to assume that the delimiters will be in the same position in the formatted number string in every locale. Specifically, for Hindi, the formatted string is "1,23,456.78", which caused 3 and 6 to be sent as delimiters. Look for the delimiters after 3 and 6 instead. Bug: 998039 Change-Id: If3e7e1c245f458224c0916a2eb6b78acd5c61581 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774219Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#691493}
-
Christopher Cameron authored
Change ProfileState and AppState to be unique_ptrs and move them into the source file from the header file, and add a pointer from ProfileState to AppState. This stable pointer will be helpful in looking up the to-be-added shared AppShimHost. Bug: 982024 Change-Id: I94496d956bb387d5077eb565b598f08dd2cca4c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775665Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#691492}
-
Gabriel Charette authored
The only class defined in this header is ThreadPoolInstance and this is thus more correct. TBR=fdoray@chromium.org Change-Id: I023626583f2ed976e6d277b379def168e3ce87b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773663Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#691491}
-
Simon Que authored
The corresponding CI builders have been migrated. - Cast Linux (Goma RBE FYI) - Linux ASan LSan Builder (Goma RBE FYI) - Linux MSan Builder (Goma RBE FYI) Bug: 997101 Change-Id: Iadda1495d9138adfa0f338e2dc841ca737b4e7f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769416Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#691490}
-
Marina Sakai authored
Make V8CrossOriginCallbackInfo (was V8CrossOriginSetterInfo) ready for both of getter and setter, which is necessary to register callbacks for accessor properties. Bug: 809011 Change-Id: I2b7c29e67b6324d2b0c2bbd9f34f5da6ef2eb857 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774002 Commit-Queue: Marina Sakai <marinasakai@google.com> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#691489}
-
Tao Bai authored
This patch is part of the effort to component-ize page_load_metrics. Bug: 995880 Change-Id: Ie0ebb66fcd7120f5dfb2f0d58aab90b7822dfd76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773210 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#691488}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b72c39d07778..efbbd1c2f621 git log b72c39d07778..efbbd1c2f621 --date=short --no-merges --format='%ad %ae %s' 2019-08-29 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@efbbd1c2f621 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ic05e845b07de063aa0bd49dd2bedb7810df748db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775741Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691487}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ib34ea4262a9800b3785a362fe800031179f11217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774715Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691486}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/c72c8d769e87..eea9d35b8757 git log c72c8d769e87..eea9d35b8757 --date=short --no-merges --format='%ad %ae %s' 2019-08-29 bclayton@google.com Device/Renderer: Work arounds for MemorySanitizer false-positives 2019-08-29 chrisforbes@google.com Clamp float values to correct range before conversion to normalized 2019-08-28 capn@google.com Support running Vulkan unit tests from the output directory 2019-08-28 chrisforbes@google.com Add missing vkGetPhysicalDevicePresentRectanglesKHR function Created with: gclient setdep -r src/third_party/swiftshader@eea9d35b8757 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:998457,chromium:b/140203285,chromium:b/140182247 Change-Id: I1581b8c106f1812b97c4e78e553e396665100f4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774714Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691485}
-
Julie Jeongeun Kim authored
This CL cleans up WebSocketClientPtr from WebSocket. It uses Remote<mojom::WebSocketClient> and BindNewPipeAndPassReceiver instead of WebSocketClientPtr and MakeRequest. Bug: 955171, 978694 Change-Id: I67e31eb7d222ba500b510eced7e78cc248756885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773019 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#691484}
-
Marijn Kruisselbrink authored
Using kFileSystemTypeNativeLocal lets us modify the tests for the hashing code to not require passing in the file path to be hashed. This means we're not only testing that the correct hash is calculated, but also that we're hasing the correct file. Bug: 995967 Change-Id: I1130190b720d4febc971b0e4fd51800ec501857f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775191 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#691483}
-
Ankit Kumar 🌪️ authored
Links and images are sent in a vector from the plugin layer. This CL uses the vectors sent to create link and image nodes, and adds them in the PDFAccessibilityTree. Tests have been added to validate PdfAccessibilityTree creation mocking the data being sent from the plugin process. End to end tests will be added in another CL as vectors of links and images are not being populated as of right now. Once they are added in the plugin layer then we can add tests for the same. Bug: 981448 Change-Id: I5eecf643c0c50e0ec594e340344776f1f0d7a587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704718 Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Reviewed-by:Lei Zhang <thestig@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#691482}
-
Fergus Dall authored
The behaviour of these histograms was changed recently to send a report every time the install flow finishes, but the descriptions were not updated. Bug: 977201 Change-Id: I6c975339800e222630a0d24bd0f28c7fe14b749e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773882 Auto-Submit: Fergus Dall <sidereal@google.com> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Commit-Queue: Nik Bhagat <nikunjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#691481}
-
Hirokazu Honda authored
The VDA client for ARC++ (GpuArcVideoDecodeAccelerator) doesn't assign texture id for PictureBuffer. On the other hand, VDA unittest assigns the texture ids in import mode. This CL changes the test to pass no texture id to VDA and makes the test to follow the GpuArcVideoDecodeAccelerator implementation. Bug: None Test: video_decode_accelerator_unittest on kevin Change-Id: Id5edb0eccd90556eba6624da8fc47967a6036b7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773078 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#691480}
-
Scott Violet authored
BUG=none TEST=none Change-Id: Id73562a714c9a05e138558b2c4535ca98378b01b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774208 Auto-Submit: Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#691479}
-
Darren Shen authored
Flaky on Linux ASAN and TSAN. TBR=bsep Bug: 998946 Change-Id: Iead970e3ca6738c495a9b922c19f24294b9093e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774006Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#691478}
-
Kentaro Hara authored
TBR=haraken@chromium.org Bug: None Change-Id: I7add9c08f347651783fc3331969ef335250037e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774007Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#691477}
-
Lei Zhang authored
Change-Id: I665b95a6d848f6b5387c0298c11f9c0c5c7c220a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775393 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#691476}
-
Max Moroz authored
Bug: 991200 Change-Id: Ib7ce5dce09154d5970f664a6caf28f0544a67abd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774224Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Auto-Submit: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#691475}
-
Bailey Berro authored
- Removes the external page icon since it is already a link Bug: 998434 Change-Id: I46d2159c6e95ee172a66d9327a4a5d68fc02d578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775371 Auto-Submit: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#691474}
-
Miyoung Shin authored
This CL converts UsbDeviceManager{Ptr, PtrInfo, Request} in chrome, components, extensions and services to the new Mojo types, and uses pending_receiver<device.mojom.UsbDeviceManager> in usb_internals.mojom. Bug: 955171 Change-Id: I82621b45e224e9997b19e307209dc0dbb05c3207 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772897 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#691473}
-
Ryo Hashimoto authored
BUG=840743 Change-Id: Ie220fcaaad0204e23dbcc1c935e0aad8c7d0b88f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772848Reviewed-by:
Gabriel Marin <gmx@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#691472}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8c4bce8edcd8..68f2584d937d Created with: gclient setdep -r src-internal@68f2584d937d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I4a0ed3635903096cf1d00f5d7cf80086aa25da8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775666Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691471}
-
Zhenyao Mo authored
BUG=997863 TEST=manual R=kbr@chromium.org Change-Id: Ib9650c6d3ca1efabaa41df4c66a8055b4c42b0a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775385 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#691470}
-
Hirokazu Honda authored
This is a possible workaround for color artifacts issue on kepler device and ffmpeg with VP8 stream encoded by Intel HW encoder. This CL sets both mb_no_skip_coeff and loop_filter_adj_enable to 1, which are originally 0. After this CL, any color artifact is not observed on a kepler device. However, I have no evidence that the corruption issue will never happen. Setting mb_no_skip_coeff to 1 means that each macro block will be read (i.e. not skipped) by a decoder. Setting loop_filter_adj_enable to 1 means that the macroblock level loop filter adjustment is on for the frame. Even after this CL, the fps performance is comparable. The encoded quality is a bit improved in terms of PSNR and SSIM. Bug: 139766881 Test: Hangout meet with atlas (intel) and guado (kepler) Test: Decode the VP8 stream with FFmpeg VP8 decoder and confrim the result matches libvpx Change-Id: I62e82dcb4a39c15a3157591d75e07876c13c9aa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773662Reviewed-by:
Pawel Osciak <posciak@chromium.org> Commit-Queue: Pawel Osciak <posciak@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#691469}
-
Hirokazu Honda authored
A VideoEncodeAccelerator (VEA) client needs to specify a proper h264 level in the original VEA API. If the h264 level is unspecified, Level 4.1 is used by default. This design causes a failure of recording 4k video with media recorder because most VEA clients don't specify the level. This CL modifies the VEA API design. A VEA client is still able to specify h264 level. However, if it is invalid (or unspecified), VideoEncodeAccelerator s selects one of proper h264 levels for the specified resolution, bitrate and framerate. Bug: b:139788862 Test: video_encode_accelerator_unittest on hana and eve Test: Record 4k video Change-Id: I807a6fce10929739fe6ab161d2faddfd9e39d3a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765131Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#691468}
-
Darren Shen authored
This reverts commit 830d60ac. Reason for revert: Possible cause of crbug.com/999010 Original change's description: > [fuchsia] Add support for loading embedder content via fuchsia-dir://. > > Defines a new scheme for loading resources from named embedder > Directories. Resources from these directories can be loaded using > the URL: > > fuchsia-dir://<directory-name>/<path>/<to>/<file>.html. > > * Browser tests added for testing URLLoaderFactory & URLLoader logic. > * Integration tests added to test ContextProvider changes. > > Bug: 991298 > Change-Id: I5875594d9fe5cc7f9006ccdecda78cc3bdf667b3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764335 > Commit-Queue: Kevin Marshall <kmarshall@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#691363} TBR=wez@chromium.org,nasko@chromium.org,jam@chromium.org,kmarshall@chromium.org Change-Id: Ib11211bc041036e0a84d32d093dcaa209ffb0c81 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 991298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775641Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#691467}
-
Pratish Kumar authored
This CL modifies the method PDFiumPage::CalculateImages() to extract alternate text information of an image present in the struct tree element corresponding to that image object. This CL introduces a method PDFiumPage::PopulateImageAltText() which traverses the entire struct tree of the page recursively and extracts the alt text from struct tree elements corresponding to the marked content IDs of the images in the page. A unit test has been added to verify the alternate text of the images present in a page. Bug: 981448 Change-Id: I0d48019c3439f859a7856deb2ce29cdb117f20c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742246Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Pratish Kumar <prkum@microsoft.com> Cr-Commit-Position: refs/heads/master@{#691466}
-
Nigel Tao authored
The ARC_GET_INSTANCE_FOR_METHOD macro is really a private implementation detail of the ArcAppListPrefs class. Bug: 826982 Change-Id: Ibc6a74a2ebb54282b36b361ad2ee561ca600dce0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767468 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#691465}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ed2f5ecd..5c64cbb4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I01b784eda8caa8a14b056a024fad22306ae29284 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775010Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691464}
-
Varun Khaneja authored
If 3 consecutive lookups fail, enter backoff for 5 minutes. Bug: 992099,963165 Change-Id: I10a7745524a0a621aaf1a887b1a6a1dba22407bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767623 Commit-Queue: Varun Khaneja <vakh@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#691463}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: I0a1089b86302375ca5a77c4b654d7854eae0fcf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700863Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#691462}
-
Yutaka Hirano authored
Turn some into DCHECK, and remove others. Bug: 994000 Change-Id: Ic45693dd2ac1f50833a3aacd454479b2ba9083b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775678Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#691461}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I16425972e4deee547102b7ddbed31ba7b146c4a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775718Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691460}
-
Will Harris authored
This uses ACG with thread opt-out as the launcher thread needs to be able to write the sandbox intercepts into the child process which would normally be blocked. BUG=851565 Change-Id: I5e24c156700037fdd2f7849f4ce0210f01207f0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713906 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/master@{#691459}
-
Darren Shen authored
Test still flaky. TBR=shuchen No-Presubmit: True No-Try: True Bug: 997888 Change-Id: Ib6026d72ddbc881084472aa320f3f8b7c30ead92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772869Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#691458}
-
Nigel Tao authored
BUG=826982 Change-Id: Idd3fe21cecc08bb902b5708a772618dd3a5a4695 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767451 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#691457}
-
Andrew Comminos authored
For the initial trial, require site isolation to be present. Bug: 956688 Change-Id: I18c255118965357f46e46c7aef6ac4cbf4205060 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707591Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Andrew Comminos <acomminos@fb.com> Cr-Commit-Position: refs/heads/master@{#691456}
-
Alexey Baskakov authored
The external access to the apps that are owned by WebAppRegistrar (the LevelDb) should be read-only. We should support const_iterator properly: let's make AllApps const_iterator to return read-only reference |const WebApp&|. Next CL: Introduce a "batched writes" API, which allows to mutate apps. Bug: 891172 Change-Id: Ibf3b3bc361fd4273d4f28ffd26dbf3b6241e41f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774117Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#691455}
-
Andrew Luo authored
Bug: 997759 Change-Id: Ia3dab4a9d6ed99e1d1d71281c6897c88b47b09de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775192 Commit-Queue: Andrew Luo <aluo@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#691454}
-