- 08 Apr, 2020 40 commits
-
-
Ramin Halavati authored
Adds two shorthand functions to create, get, or check existence of primary OffTheRecord profile. Bug: 1033903, 1060940 Change-Id: Ic9ff38ea0f9961088a6d34a94ef2f7eaa2bcd9e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130351Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#757438}
-
Abhijeet Kandalkar authored
Migrate this test out of third_party/blink/web_tests/css3/filters and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 1063749 Change-Id: I1ecb61c85c3f0a08dffe1c502ea8aa9c05dae6af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139633 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#757437}
-
Christian Dullweber authored
Add values for actions performed with the cookie control toggle and update expiry date. Bug: 1037411 Change-Id: I9f71c0fc2ba4a3003ac2bbc83ecee5ffadc70720 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137393Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#757436}
-
Internal Frameworks Autoroller authored
TBR=bling-p10-rolls@google.com Change-Id: I2c550051d687dbc5e74584d7c18d32a763ffbb38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140916Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757435}
-
Wei-Yin Chen (陳威尹) authored
Bug: None Change-Id: I11f7a6588ad73669b85d4091cc8533719bd0c4c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139299 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#757434}
-
David Tseng authored
An example of unexpected cases include: - editable address bar. Whenever a user types, ChromeVox shifts focus over to the auto completions list. We want to have sticky mode continue to be off because further typing will actually continue entering text into the text field - within content editables, ChromeVox may place range on inline text boxes. These nodes are not themselves editable RELNOTES=n/a Change-Id: Iaafc60f978d76239a91284ee99aa773177c944e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138235 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#757433}
-
Vasiliy Telezhnikov authored
This is a reland of c961f8a8 Original change's description: > Build: remove resource_dirs support > > This CL removes resource_dirs support from android_resources, it was > deprecated in favour of sources. > > Details: > https://crbug.com/1026378 > https://groups.google.com/a/chromium.org/forum/#!msg/chromium-dev/KAFsfaoq7y4/OC4v5sb9BQAJ > > Bug: 1062263 > Change-Id: I5063b0b5c6d45a5e860901e27a66d6a503a1fbf4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136036 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#756711} Bug: 1062263 Change-Id: Ie547290a0390e050c8c3ed1ee55d323a2704fa7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139948Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#757432}
-
Manuel Rego Casasnovas authored
AdjustedFocusRingOffset() is no longer needed when FormControlsRefresh is enabled. Adding a DCHECK() to avoid calling it on that case. Also removing the "width" argument from AdjustedFocusRingOffset() as it's not used anymore. BUG=945181 Change-Id: Ifae803a8aeff6de5c7e6348be211e6957d0f0a3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141093Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#757431}
-
ckitagawa authored
Looks like this test was failing on some builders due to including the test in AR tests where DummyUiActivity isn't present. This re-enables the test and removes the culprit build dep. This required refactoring the JNI methods to a separate build target/class. Fixed as android-pie-arm64-dbg passes. Bug: 1067719 Change-Id: I6fd53af95d15027a65e9e2d57d9432edb2924b37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137376Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#757430}
-
John Abd-El-Malek authored
This matches Chrome, and avoids notification sounds each time the notification is updated. Bug: 1025603 Change-Id: Ibc66cf5371b18dfb32148784d760d18a8e37e229 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141199 Auto-Submit: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#757429}
-
Evan Stade authored
Added a test that verifies that closing a WebContents while a media stream permission request is active doesn't cause harm. The existing test, MediaStreamDevicesControllerTest.WebContentsDestroyed, only tests what happens when the code is passed a null WebContents. (AFAICT that should never actually happen, whereas a WebContents could actually be destroyed during a request.) There's also some cleanup of repetitive test code. Bug: 1025622 Change-Id: Icd82ef70c34bb8fbc4b181bb832d976dcaadac09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140595Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#757428}
-
Patrick Noland authored
This reverts commit cc5487e9. Reason for revert: testFindAppStoreBillingAppIgnoreNonAppStoreBillingApps is failing consistently on KitKat: https://ci.chromium.org/p/chromium/builders/ci/KitKat%20Phone%20Tester%20%28dbg%29 Original change's description: > [PlayBilling] Support app-store billing in AndroidPaymentAppFinder > > After: > When a merchant page runs in a Trusted Web Activity that's installed > from an app store (e.g., Google Play) and the PaymentRequest is not > requesting shipping or payer contact, if it satisfies the following > conditions, the TWA itself would be included: > - the PaymentRequest supports the (TWA installer) app store's > billing method in the payment request. > - the TWA can handle pay intents. > - the TWA can handle the app store billing method. > > Before: > AndroidPaymentAppFinder could not include a TWA for an app store > billing method. > > Change: > * In AndroidPaymentAppFinder#findAndroidPaymentApps, check if the > merchant page is a TWA installed from app store and if the > PaymentRequest is requesting shipping or payer contact. If it is, > add the TWA itself as a payment app if it's eligible. > * remove mIgnoredMethods. > > Note: > * Counterintuitively, the merchant page would send the pay intent to > the TWA instead of the Play Store, because it would be the TWA who > is responsible to interact with the app stores. > > Bug: 1064740 > > Change-Id: I0a2f6baebae422aaeab574e3c39a10cd61fafb4a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135152 > Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#757128} TBR=rouslan@chromium.org,maxlg@chromium.org Change-Id: I954a5d5589704b2c8ad13400fcb487eac00bc677 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1064740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141209Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#757427}
-
Dominic Battré authored
This reverts commit 9caea10d. Reason for revert: See crbug.com/1068949 Original change's description: > [bfcache] Blocklist Printing > > This CL disables BackForwardCache when window.print API is used. > > Change-Id: I52a1b350c70246344487f00b19682579cbceec58 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121638 > Commit-Queue: Yuzu Saijo <yuzus@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#757348} TBR=haraken@chromium.org,altimin@chromium.org,yuzus@chromium.org BUG=1068949 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ibef7f1e7e40575a17e6291c139ace2cf0459fcea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141895 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#757426}
-
Jérôme Lebel authored
This case should never happens for regular users since the sign-in promo would never be triggered when Chrome is started for the first time. This fix is only for debug reasons. The -[ScheneController scheduleShowPromo] needs to be called after triggering the first run. This is to avoid starting both, the FRE and the sign-in promo. The bug is, |scheduleShowPromo| is called by |startUpChromeUIPostCrash:needRestoration:| before |showFirstRunUI| Change-Id: Idb0e32fdd30f7fb72165f2c8bdfb6a7571bdd121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139824 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#757425}
-
Sebastien Lalancette authored
Removed failing test - testing background color was a bit overkill anyway. Previous review: https://chromium-review.googlesource.com/c/chromium/src/+/2130819 Revert CL: https://chromium-review.googlesource.com/c/chromium/src/+/2140293 Bug: 1064990 Change-Id: Ice4f5889217591be601373cf9fd8c595babadddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140174 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#757424}
-
Roman Aleksandrov authored
Add function which records user actions on the screen. Add new user actions. Bug: 1066606 Change-Id: Ibed665ad328c11073b512aa823d94acd84861986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130849 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#757423}
-
Peter Kotwicz authored
This reverts commit 6c17bc33. Reason for revert: This CL caused a compile failure https://ci.chromium.org/p/chromium/builders/ci/Linux%20Builder%20(dbg)(32)/141491? Original change's description: > Add field to SiteForCookies to indicate schemeful same-site of ancestors > > Add a new field to SiteforCookies which is used to indicate if |this| > would be the same when considered with schemeful same-site. > > The field is updated in the browser and renderer when th computation for > a sub-frame's SiteForCookies is done. > > This CL is groundwork for implementing schemeful same-site and thus > nothing is done with this new field yet. > > Bug: 1030938 > Change-Id: I3fe59fd58604b370e71f6b1d8edcd29d0f3d47a0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133237 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Maksim Orlovich <morlovich@chromium.org> > Reviewed-by: Lily Chen <chlily@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Steven Bingler <bingler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#757419} TBR=dcheng@chromium.org,jam@chromium.org,morlovich@chromium.org,chlily@chromium.org,bingler@chromium.org Change-Id: I274fbf0134c7103731ef5f3ffdc9e9b7a672ac86 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1030938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141207Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#757422}
-
Roman Aleksandrov authored
Remove error state cause it wasn't in the UX proposal. Bug: 1061098 Change-Id: I9d57b009f434611333d7b24f90af285470e6c95d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139766 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#757421}
-
Antonio Gomes authored
CL adds <title>, <link>s and <meta name=assert> entries to the original test, and moves it to external/wpt/css/filter-effects/. Target location/name: external/wpt/css/filter-effects/effect-reference-feimage.html Associated TestExpectations entries are also updated. BUG=968791,1063749 R=pdr@chromium.org Change-Id: I61a5f5c57d4fd0b891d52314b8dc1abdb8921cfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137871 Commit-Queue: Fredrik Söderquist <fs@opera.com> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#757420}
-
Steven Bingler authored
Add a new field to SiteforCookies which is used to indicate if |this| would be the same when considered with schemeful same-site. The field is updated in the browser and renderer when th computation for a sub-frame's SiteForCookies is done. This CL is groundwork for implementing schemeful same-site and thus nothing is done with this new field yet. Bug: 1030938 Change-Id: I3fe59fd58604b370e71f6b1d8edcd29d0f3d47a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133237Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Steven Bingler <bingler@chromium.org> Cr-Commit-Position: refs/heads/master@{#757419}
-
Victor Hugo Vianna Silva authored
The ShouldNotifyUnsyncedCredentialsIfAccountStore test is updated not to add any form for the primary key associated with a deletion metadata, in order to correctly reflect the current implementation of the password store. Bug: None Change-Id: Ib65349e4e152a6afca26f427640e6a9520d246ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141898Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#757418}
-
Chris Sharp authored
Test is flaky on WebKit Linux Leak. TBR=jarhar@chromium.org Bug: 1067650 Change-Id: I5bd2cccc0556808fc181c9439424771b236cd664 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141592Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#757417}
-
David Bienvenu authored
We shouldn't need the mock executable for the unit test anymore. Bug: 960245 Change-Id: Id7f39c4d7a84037771afd409eb48d5a5f6b06253 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140193Reviewed-by:
Jesse McKenna <jessemckenna@google.com> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#757416}
-
David Bienvenu authored
Change-Id: Ia47d938d63e2dabce498ebf264a031c80097a6c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140597Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#757415}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f16e550c142f..d03d968b75ce git log f16e550c142f..d03d968b75ce --date=short --first-parent --format='%ad %ae %s' 2020-04-08 marinaciocea@webrtc.org Revert "[InsertableStreams] Fix simulcast: set frame transformer for all streams" 2020-04-08 titovartem@google.com Extract activity executor into separate class from PC level fixture impl Created with: gclient setdep -r src/third_party/webrtc@d03d968b75ce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1065838 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Iab5f09fa65819a0c7eab172b99dab76d153bc8b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141850Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757414}
-
Elly Fong-Jones authored
This entry references a nonexistent OWNERS file; update it to a likely-looking better OWNERS file. Bug: None Change-Id: I281c2cc5002bd950e2e9be34a6716bf7ae2369df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135836Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#757413}
-
Richard Knoll authored
Widget observers need to make sure they unregister themselves before they are destroyed. Bug: 1055483 Change-Id: I53c78555a9cd9d28fe7edab0630bca17f90e47a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137319Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#757412}
-
Fan Yang authored
R=bnc@chromium.org Change-Id: I3d9356fb8b9fdadc13dc322056015d5c061ab361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140673Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Fan Yang <fayang@chromium.org> Cr-Commit-Position: refs/heads/master@{#757411}
-
Fan Yang authored
R=bnc@chromium.org Change-Id: Id498722f334e61142c4a930cc7be5f691b226c13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140180Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Fan Yang <fayang@chromium.org> Cr-Commit-Position: refs/heads/master@{#757410}
-
Jonathan Ross authored
When we expanded UMA coverage for PeakMemoryAllocationSources, we converted the suffixes for GPU.PeakMemoryUsage into "base". https://chromium-review.googlesource.com/c/chromium/src/+/2106115 Since then the UMA has stopped being parsed by our tools. This splits apart the suffixes so that the one used by PeakMemoryUsage is no longer a base Bug: 1065423 Change-Id: I2cd16951d13b24de046a3c14d27b4e6017b3c3cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139445Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#757409}
-
Johann Koenig authored
This reverts commit ffcf2b75. Reason for revert: Surprising impact to system_health.memory_desktop Bug: 1068911 Original change's description: > presentation controller: remove execution context > > The PresentationController class does not need > ExecutionContextLifecycleObserver since the mojo::Receiver was migrated > to HeapMojoReceiver. The replacement wrapper includes management of the > presentation_controller_receiver_. > > Change-Id: I1c96f897a7b604a23d3e7f0bd61a3b0598faa2f8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137162 > Commit-Queue: Johann Koenig <johannkoenig@google.com> > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/heads/master@{#756871} TBR=kouhei@chromium.org,mlamouri@chromium.org,johannkoenig@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I46cdb9285cf604eb41b38ac6cc8d7fcec1f10430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141996Reviewed-by:
Johann Koenig <johannkoenig@google.com> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#757408}
-
Rushan Suleymanov authored
This reverts commit 3926e905. Reason for revert: reland after M83 BP. Original change's description: > Revert "[Sync] Refactor model type processor: entity tracker lifetime" > > This reverts commit 83dccf5d. > > Reason for revert: this patch contains refactoring of client tag based > model type processor. To prevent too many changes in one release it is > better to reland this patch after M83 will be branched. > > Original change's description: > > [Sync] Refactor model type processor: entity tracker lifetime > > > > Make entity tracker's lifetime same as initial sync done. The tracker > > won't exist if we still have no data from the server. > > > > In this patch also authentication_account_id is not set explicitly for > > metadata coming from ModelReadyToSync. The behavior for this field > > becomes similar to cache_guid. If authentication_account_id differs from > > activation request then the metadata will be reset. Generally it should > > not affect anything. > > > > In the next patch unittests will be added. > > > > Bug: 947044 > > Change-Id: I34a75006d1f31888f8ca485a94538b6dd98923c1 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038733 > > Commit-Queue: Rushan Suleymanov <rushans@google.com> > > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#750920} > > TBR=mastiz@chromium.org,rushans@google.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 947044 > Change-Id: Icc0ae96eb2afa549024bf5b61efb799a6a92969c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130212 > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Commit-Queue: Rushan Suleymanov <rushans@google.com> > Cr-Commit-Position: refs/heads/master@{#755389} Bug: 947044 Change-Id: I1f391874672cab29b204e32fd21285122a575a1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135748Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#757407}
-
Shifona Garg authored
A crash occurs when user clicks on the Repair/Install dialog buttons after the extension is uninstalled. The scenario is that the user invokes both the "Repair" and "Remove" dialogs, but first clicks on the "Remove" button to uninstall the extension. Now, when the user clicks on "Repair" button, the browser crashes as the CHECK(extension.get()) fails. This CL adds Extension Registry Observer for extension install dialog, which enables it to listen to extension uninstall event and close the dialogs related to the extension. Bug: 1026206 Change-Id: I98a5b5833c0bf5c120a8ee1c29110c2e9d051e52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049444Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Shifona Garg <shgar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#757406}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4045cd82e755..6a5187a88958 git log 4045cd82e755..6a5187a88958 --date=short --first-parent --format='%ad %ae %s' 2020-04-08 cwallez@chromium.org PRESUBMIT: Don't check formatting of deleted files Created with: gclient setdep -r src/third_party/skia@6a5187a88958 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1064305 Tbr: csmartdalton@google.com Change-Id: I8135a33694c264a03de85a22289eb29d3f8d41f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141847Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757405}
-
Dominique Fauteux-Chapleau authored
These tests now try to record metrics for every DLP/malware scan verdicts. Bug: 1067608 Change-Id: I97c1cdfc0566034e765ada7ef2a1a50eff8c42bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140091Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#757404}
-
sauski authored
Fixes a typo in the computed property |selectSafeBrowsingRadio_| that prevented the property from updating as expected. Adds test to ensure that the property is correctly updated. Bug: 1068523 Change-Id: Icdd264ef9804d82f79af0773cd95f3464acbf295 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139696 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#757403}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/703b9d48..3d1d9352 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I48151a9c7d6fd0b03157a17451dc6c9d6e3382fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142031Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757402}
-
Roman Sorokin authored
Bug: 1068314 Change-Id: I26a375433d59e45abb18bd4001d70dea546b92df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138014Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#757401}
-
Clemens Arbesser authored
This was possible because the edited profile was not correctly sent via the JNI bridge, resulting in the creation of a new profile in native with a different GUID. Bug: b/153139772 Change-Id: If8747b2598666e43a007fc26511812420b5e3864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134237Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#757400}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/9d2de1d6d45f..36cd17488a63 git log 9d2de1d6d45f..36cd17488a63 --date=short --first-parent --format='%ad %ae %s' 2020-04-08 cwallez@chromium.org dawn_wire: Correctly handle buffer state changes on Destroy() Created with: gclient setdep -r src/third_party/dawn@36cd17488a63 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1068466 Tbr: cwallez@google.com Change-Id: I371049dba954fb23cc2b8a135fd4f318f58b3611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142131Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757399}
-