GitLab

We now provide frame tree, frame committed and frame deleted trace events
while tracing, and then show the processes which match them on Timeline.

Followups:
- move browser events from tracing handler to frame tree nodes;
- emit frame tree from tracing started observer;
- do the same for workers in renderer;
- remove InspectorTracingAgent;
- maybe show non-interesting events on the tracks, but grey them out;
- UI improvements.

Bug: 820250
Change-Id: I6a4a782cab2f286bc037742f4119e1eca9a34d3c
Reviewed-on: https://chromium-review.googlesource.com/974367
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548498}

Including a name in the trace makes it easier to diagnose bugs.

Bug: 777763
Change-Id: I81d80b4cc0f9d71be5631575730a7ae6479b18f0
Reviewed-on: https://chromium-review.googlesource.com/977969
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548497}

Now password_controller.js is injected by adding it to call of __gCrWeb.findPasswordForms().
It has performance drawbacks since __gCrWeb.findPasswordForms() could be called multiple times.
This CL makes injection of password_controller.js with WKWebView injection.

Also this CL updates the header comment in password_controller.js with up-to-date information.

Bug: 828824, 418827
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I4036e3279e0c3a32301795b46630c49801679106
Reviewed-on: https://chromium-review.googlesource.com/995534
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548496}

We attempt to optimize the background image destination rectangle to
avoid pointlessly painting under borders, thus allowing more non-tiling
image draws. But that breaks when there is a border image with outsets
because in that case, despite an opaque border, the background image
may not cover the border area.

Also clean up the conditional that prevents the optimization.

R=fmalita@chromium.org
BUG=827871

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ibd0fb4307fd2d7b7df4421f18fb07da2c669aa79
Reviewed-on: https://chromium-review.googlesource.com/996884
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548495}

Tests were broken because:
1: Not updating constants after reverting
   https://chromium-review.googlesource.com/957916
2: Not overriding some size classes in UIWindow
3: Removing width constants that would require pixel alignment, which
   means tests would be device scale dependent.

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I3813137b884475e645a3a7977b8ff699d53bfa20
Reviewed-on: https://chromium-review.googlesource.com/996216Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548494}

Include new archive additions like pak/dex/other parsing.

Bug: 827168
Change-Id: Idf9d851765d5a3b20cffa3c9177481a392cc8153
Reviewed-on: https://chromium-review.googlesource.com/997974
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548493}

Right now in TouchActionFilter class, the white_listed_touch_action_
member has a default value of Auto when the TouchActionFilter is
constructed. We have not started using this value yet to filter gesture
event and that's why this is not a problem for now. However, later on
we would want to use that value to determine whether a gesture is
definitely / partially allowed. In that case, a default value of auto
will cause a lot of trouble.

It makes sense to make white_listed_touch_action_ member Optional.
When we receive a computed value from cc, we set it. When we start
filtering gesture event, we will be able to check against the value
that we received from cc, instead of against the default value.

This CL should not cause any behavior change because we have not yet
using that value to do anything. It is a pre-requisite for following up
CLs that will be using the value to filter gesture event.

Bug: 772130
Change-Id: I6de715c62b86067d53c28b5241002b9b8f74e16c
Reviewed-on: https://chromium-review.googlesource.com/997763
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548492}

When the build flag enable_volume_tables_access is false the AThing speaker
build for CMA breaks. This adds the necessary #idefs.

Bug: internal b/77634874
Test: builds now
Change-Id: I8841c819c2ac5523c2953c6725c69b92bc328864
Reviewed-on: https://chromium-review.googlesource.com/998334Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Commit-Queue: Chris Kuiper <ckuiper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548491}

The 'AsyncTransferThread' was removed in crrev.com/345908. So remove the
reference to it from the benchmark code.

BUG=509076

Change-Id: I9b9fe755a87ea55eeff5ccc1c3a59943684a0958
Reviewed-on: https://chromium-review.googlesource.com/997102Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548490}

While geolocation is active, the network geolocation provider
periodically scans using WLAN hardware to identify nearby wifi APs.
The set of APs is sent to a Google service which returns a position
estimate. Once there are no active geolocation listeners, the
wifi data provider and network location provider are shut down.

Some state retained by these providers must be preserved in order to
properly enforce the wifi polling policy. Previously, the policy state
was destroyed whenever there were no active geolocation listeners,
allowing a situation where wifi scans could be performed in rapid
succession as long as the providers were recreated each time. With this
CL, a newly-created WifiDataProvider obeys the policy for its initial
scan.

When a newly-created WifiDataProvider is denied an initial scan, it may
cause a newly-created NetworkLocationProvider to fail to acquire fresh
wifi data in a timely manner. This may cause a related issue where a
Geolocation call is unable to acquire a fresh estimate due to policy,
and has no cached value to return, leading to long delays or timeouts on
Geolocation API calls. To provide a good experience in this situation,
NetworkLocationProvider's cache of the most recent network position
estimate is moved to LocationArbitrator where it is retained when the
provider is recreated. The cached value may be returned when it is
sufficiently recent and no new data is available.

BUG=828547

Change-Id: I7b25929404b4becd28c13a20f0a7f5fc74894334
Reviewed-on: https://chromium-review.googlesource.com/993752
Commit-Queue: Matt Reynolds <mattreynolds@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548489}

Bug: 807436
Change-Id: Ic908a9764c1f9432ee14783561f720597c2c2b42
Reviewed-on: https://chromium-review.googlesource.com/996453Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548488}

After the 1% rollout of the new app, we have seen a ~30% drop in the
reliability metrics. More than half of the failure are p2p-failure. We
are also getting lots of users reporting that the app used to work on
the old app but it no longer works.

Turns out many mobile ISPs have already switched into an IPv6-only
network (with NAT64 gateway), and they are not able to connect because
we hardcode IPv4 addresses in stanza and other places. We didn't had the
logic to handle this before so I'm not sure why many people with
IPv6-only network also claim that it used to work on the old app. Maybe
Apple had removed an IPv4 compatibility layer?

This CL fixes this issue by adding IPv6 translation logic when dealing
with IPv4 literals.

Change-Id: I1a25fad4c2f7c804a66f0e04b3569b5aa5d49b5c
Bug: 829117
Reviewed-on: https://chromium-review.googlesource.com/994587Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548487}

Add use counters for negative values in background-size and mask-size.

Spec forbids negative background-size.
https://drafts.csswg.org/css-backgrounds/#background-size

Bug: 825549
Change-Id: I5415bd9123b86907665c552801fbeca4b587b1ea
Reviewed-on: https://chromium-review.googlesource.com/984913
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548486}

Several tests override display::Screen and they left a screen
overridden after execution. When next test from current batch is
executed and it uses display::Screen::GetScreen(), it gets broken
screen.
This CL based on
https://chromium-review.googlesource.com/c/chromium/src/+/963961

Bug: None
Change-Id: I098c96a024a4817abaaf735563d5bddd93c461d8
Reviewed-on: https://chromium-review.googlesource.com/974142
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548485}

The linked bug uncovered a case where ShowClientNotification was called
multiple times with the same notification (i.e. the same notification
ID) on the Chrome side, while Ash sent a HandleNotificationClosed
for the first shown notification which arrived in Chrome after the
second ShowClientNotification. Then Ash subsequently sent a second
HandleNotificationClosed, but since the notification had already been
removed from the Chrome-side cache in response to the first
HandleNotificationClosed, an error was thrown (specifically, the check
in NotificationPlatformBridgeChromeOs::HandleNotificationClosed()).

The solution is to create a token that is separate from the
notification's ID to identify the Display call to which the Close is
paired. This token is not used for other callbacks, such as the button
handlers, because then Chrome could drop user input that occurred around
the same time as a notification being updated (seems fairly likely for
any notification that has a progress bar, such as downloads).

Bug: 825141
Change-Id: I01f66dcc1107bfa7337c447780edb897e24498e6
Reviewed-on: https://chromium-review.googlesource.com/979268
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548484}

NetLog will only be for net/ with out-of-process networking. This follow earlier changes to remove safe browsing requests' use of NetLog.

Per Luke, chrome://safe-browsing shows similar data and we can add extra data if we need it.

Change-Id: Ibc018d34e735ed79c6b4acb01724d2e743078595
Reviewed-on: https://chromium-review.googlesource.com/998072Reviewed-by: Eric Roman <eroman@chromium.org>
Reviewed-by: Luke Z <lpz@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548483}

This change removes the Android-specific implementation of USB device
enumeration for the WebUSB device chooser dialog and instead reuses the
desktop implementation.

This removes duplicate code and means the Android chooser now also
respects the status of the WebUSB guard permission.

Bug: 771703
Change-Id: I38f0765ced5966b8866fff086a12e4625282fe1c
Reviewed-on: https://chromium-review.googlesource.com/990591
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Jun Cai <juncai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548482}

The first race is only for Ozone DRM. In DrmDisplayHostManager
|primary_drm_device_handle_| was being accessed from multiple threads.
The value was changed by the IO thread while the OzoneUI thread was
still using it.

Change calls to GpuThreadObserver OnGpuProcessLaunched() so it happens
on the OzoneUI thread. This delays the call slightly but it removes
the possibility for a race modifying |primary_drm_device_handle_|.

The second race was with OzonePlatform::RegisterStartupCallback(). This
is called from the IO thread and it checks if there is an OzonePlatform
instance and if Ozone UI initialization has happened. If both of those
things are true, then it runs a callback immediately, otherwise it runs
a callback after those things become true. The problem is that
|g_platform_initialized_ui| was set true on the UI thread before Ozone
UI initialization was fully finished. The callback accessed a null
OzonePlatform member variable and crashed.

Make sure that |g_platform_initialized_ui| is set after initialization
is finished and that variable change is protected by the same lock used
in RegisterStartupCallback(). The lock only protects changing
|g_platform_initialized_ui|, not all of initialization, so the IO thread
won't block for an extended period.

Bug: 824809, 828407
Change-Id: I73b9404c823c9eeaaeaba99feb1e113953a5bb1b
Reviewed-on: https://chromium-review.googlesource.com/980574Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548481}

New metric - ComponentUpdater.CROS.Result: track the chrome os installer result (error code, etc.).
New metric - ComponentUpdater.CROS.MountTime: track time to mount a component image.

BUG=chromium:793052
TEST=platform_AddPrinter.epson

Change-Id: I502e1983adcacb488877e83723cc91b6ee504312
Reviewed-on: https://chromium-review.googlesource.com/963182
Commit-Queue: Xiaochu Liu <xiaochu@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548480}

TBR: jam@chromium.org

Bug: 721408
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ib1999e8752b1d76248eaa17aea1d12dc018d1662
Reviewed-on: https://chromium-review.googlesource.com/997020Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548479}

No functional changes are intended. This should only make the focus-
related logic in CVC much clearer.

Change-Id: I855dec9ead36fc1fe6df54c6fdef0b8673d9a3fb
Reviewed-on: https://chromium-review.googlesource.com/993772Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548478}

Fixes Init() and ShowWindowWithState() to do the right thing. This
better matches with what the other implementations do.

BUG=none
TEST=none

Change-Id: I67d3bbfe0844286631a5612d5740463ec9498480
Reviewed-on: https://chromium-review.googlesource.com/994454
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548477}

Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Change-Id: I55859eb79d307ffe7984d680d9a9e2ea6fc88295
Reviewed-on: https://chromium-review.googlesource.com/996852Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Andrei Kapishnikov <kapishnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548476}

We no longer use rsp files for compiles as of
https://chromium-review.googlesource.com/832593

Bug: 796021
Change-Id: I2ffb54f5bf2a596025af9a43d9e06fd992234f48
Reviewed-on: https://chromium-review.googlesource.com/997994Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548475}

The code casts an |int| to a |SimpleValue|. Since |SimpleValue| is an
|enum class|, this is safe. But it might not be for a traditional
|enum|, so add a comment in case it flags for anyone else.

Change-Id: Ifc50115d0ae9b047167f48b3d031b89d4494eda9
Reviewed-on: https://chromium-review.googlesource.com/982609Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548474}

With this change, CertificateReportingService now only lives on the UI thread.

Bug: 825242
TBR=rhalavati for test annotation removal

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I3945ab88a8d2f0507b4a2572df6c79edd7aab036
Reviewed-on: https://chromium-review.googlesource.com/996021
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548473}

Refactored our execution of non-telemetry tests so we wouldn't have to generate
new isolates for every non-telemetry test during migration.  Instead you need
to just pass --migrated-test=true in the src  side json.

Also pulled out the perf script deps so we wouldn't have to update every time
the perf isolated script deps changed.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I27fac5c9a36f9321be80f0c60ab8b53eaefdc1c4
Reviewed-on: https://chromium-review.googlesource.com/995576Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Emily Hanley <eyaich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548472}

This CL reimplements how ic_check_googblue_24dp_animated is animated by
replacing path morphing with trimPathEnd and removing no longer
necessary AnimatorSet. This fixes the issue when the first line in the
checkmark wasn't animated because both objectAnimators were trying to
animate pathData simultaneously (because default android:ordering for
AnimatorSet is "together").

Bug: 829388
Change-Id: I05e568e8f289cb71c869c916f488a159f11f6a64
Reviewed-on: https://chromium-review.googlesource.com/998034Reviewed-by: Becky Zhou <huayinz@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548471}

https://pdfium.googlesource.com/pdfium.git/+log/32942201a456..14f8897509d9

$ git log 32942201a..14f889750 --date=short --no-merges --format='%ad %ae %s'
2018-04-05 rharrison Remove spellchecking code from XFA

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I342d1d16619bdba0d0b3ac11d2abf5b55276716a
Reviewed-on: https://chromium-review.googlesource.com/997896
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#548470}

Change-Id: I50b6a8ed6f5b214c0ae6816a40d037107741f7e0
Reviewed-on: https://chromium-review.googlesource.com/996297Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Alan Lau <alanlau@google.com>
Cr-Commit-Position: refs/heads/master@{#548469}

WaylandPointer was supplying the complete set of flags to MouseEvent
rather than the button that actually changed.

BUG=none
TEST=covered by test

Change-Id: Ib44585549d67001fdab847205819cea4cd646544
Reviewed-on: https://chromium-review.googlesource.com/996924Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548468}

Bug: 819875
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I95e91504b6e28ac2f762881dde31924f05c2cf6e
Reviewed-on: https://chromium-review.googlesource.com/987388Reviewed-by: Yash Malik <ymalik@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Biao She <bshe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548467}

Better document pointer ownership.

BUG=123762

Change-Id: I7be106bbf079ea2a30024e129d693ebe49454acf
Reviewed-on: https://chromium-review.googlesource.com/993236Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548466}

BUG=828963

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I7d17bfdc8f4b312ff70bba4d700c528eaabd7948
Reviewed-on: https://chromium-review.googlesource.com/992322Reviewed-by: Rick Byers <rbyers@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548465}

Until now, we had to use IsSecureContext() to check whether an execution
context is a secure context manually. But we can use [SecureContext]
instead of the manual check now.

Bug: none
Change-Id: Ibfcd4a9a2eed3e7ac67819b9bf4204f4c73412d8
Reviewed-on: https://chromium-review.googlesource.com/990014Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#548464}

This is marginally better than what we're doing now, but more
importantly it satisfies a reasonable DCHECK that we currently
violate in these cases.

Bug: 829290
Change-Id: I68621d4f1c8f40c1b689d74e801c1cdb77e4663a
Reviewed-on: https://chromium-review.googlesource.com/997769Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548463}

This adds the FeatureFlagHolderBoundaryInterface. Support-lib-created
callback objects will implement this to indicate, on a per-object
granularity, which features they support.

Doc: http://go/wv-callback-feature-detection

Bug: 752521
Test: N/A
Change-Id: Iac86615052069d091a0db66f41bc9c852498815f
Reviewed-on: https://chromium-review.googlesource.com/997021Reviewed-by: Gustav Sennton <gsennton@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548462}

This turned out to be slow.

Bug: None
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Id2b89db4cd7fcd8b96eed66415a30afe33af0e59
Reviewed-on: https://chromium-review.googlesource.com/997755Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548461}

This asset will be shared by both the popup menu and collections.

BUG=None
TEST=None

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Id6c87412a3a4ebd5e7755058a67288fdcc035ced
Reviewed-on: https://chromium-review.googlesource.com/997156Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548460}

This commit:

- adds a class ChromeSearchResult;
- changes all SearchResult references to ChromeSearchResult in Chrome;
- fixes lint errors and presubmit errors on creating unique_ptr.

This commit touches a lot of files. To make it simple, we simply extend
SearchResult to create ChromeSearchResult, and cast between types for
mojo calls. We'll reorganize their contents and break the inheritance
in future CLs.

Bug: 733662
Change-Id: Iaef5174580dbd06bb26b4e864a6a367336458604
Reviewed-on: https://chromium-review.googlesource.com/996381Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jiaquan He <hejq@google.com>
Cr-Commit-Position: refs/heads/master@{#548459}