- 26 Mar, 2020 40 commits
-
-
Jonah Chin authored
This change sets up a code path to render a simple canvas with OOP rasterization. It covers the most basic Canvas2D cases (ie. draw operations with stroke()). This CL also introduces diverging code paths based on the CanvasOopRasterization flag. OOP-R canvas functionality will remain divergent behind this feature flag as we work towards parity with the current code path, at which point the current code path will be removed. In this change, the flag is often used to bypass uses of GrContext, SkSurface and SkImage (all of which are unavailable with OOP-R). References to these objects will be replaced in future changes as we flesh out the OOP code path. This is being done as part of the OOPR-Canvas2D project. For more info about the project see the tracking bug here: crbug.com/1018894 Bug: 1023277 Change-Id: Iffd279418f7b104a84513f14495983fc63e623c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076555 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#753520}
-
Patrick Monette authored
This is a reland of b7526e4f, but by with an additional fix. When a PerProfileWorkerTaskTracker instance is deleted because StopUpdating() was called, then the removal notifications must not be sent to the task manager (as part of the TaskProvider's API contract). This is handled in WorkerTaskProvider by dropping the notification when IsUpdating() is false. Original change's description: > [Task Manager] Properly clear worker tasks on profile shutdown. > > Fixes PerProfileWorkerTaskTracker so that the WorkerTaskTracker is > notified when there are outstanding tasks that are about to be > deleted. > > Bug: 1060506 > Change-Id: Ic81ad1557c1e27a8fc96fc079f7447efcc2ce7f3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110350 > Auto-Submit: Patrick Monette <pmonette@chromium.org> > Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#751915} Bug: 1060506 Change-Id: I3c1a7f8f94a580d021b7e3658af885110bfa8d2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118770 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#753519}
-
Trent Apted authored
This reverts commit 59211f2c. Reason for revert: Persistent failures on linux-chromeos-chrome waterfall bot starting https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/4305 errors like ../../chrome/browser/chromeos/accessibility/speech_monitor.h:64:54: error: predefined identifier is only valid inside function [-Werror,-Wpredefined-identifier-outside-function] const base::Location& location = FROM_HERE); Original change's description: > Include line numbers in SpeechMonitor async api > > Unfortunately, to resolve base::Location for each api call, we cannot support chaining. > > However, shortening the variable name for > |speech_monitor_| > to > |sm_| > and not having to indent, we actually save some indent space. > > Also, this change now includes all pending utterances (for understanding the state when the test is waiting). > > Sample output: > [158567:158567:0325/082550.588956:ERROR:speech_monitor.cc(276)] Still waiting for expectation(s). > Unsatisfied expectations... > ExpectSpeech("Fail!Rate 19 percent") RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:931 > Call() RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:933 > ExpectSpeech("Pitch 50 percent") RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:934 > Call() RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:936 > ExpectSpeech("Reset text to speech settings to default values") RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:938 > Call() RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:941 > ExpectSpeech("Rate 19 percent") RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:942 > Call() RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:943 > ExpectSpeech("Pitch 50 percent") RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:944 > > pending speech utterances... > Volume 100 percent > Rate 19 percent > > Satisfied expectations... > Call() RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:926 > ExpectSpeech("Reset text to speech settings to default values") RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:928 > Call() RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:930 > > Change-Id: If1bdbfb517014e681cb233800eab3f62f608188f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120741 > Reviewed-by: Akihiro Ota <akihiroota@chromium.org> > Commit-Queue: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753353} TBR=dmazzoni@chromium.org,dtseng@chromium.org,akihiroota@chromium.org Change-Id: Ib3acf61914b3dd81ce2d777961d16de060ae9192 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121598 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#753518}
-
Trent Apted authored
This reverts commit a3c46feb. Reason for revert: Landed on top of https://chromium-review.googlesource.com/c/chromium/src/+/2120741 which needs to be reverted Original change's description: > Re-enable some SpokenFeedbackTests > > General strategy: > - perform all actions (sm_.Call) > - gather pending utterances > - mix in Expect* calls between all Call actions (incrementally from the top) > - keep the tests mostly simple (limit UI interactions) to prevent flakes > - do use the async SpeechMonitor api which should be less flakey > - deleted one test who's behavior is still in flux (empty panel menu behavior) > > Some tests were still failing but due to external factors. Comments left. > > Change-Id: I7689880dbeeac3b31fe22a8029fae5078d975f0a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119382 > Commit-Queue: David Tseng <dtseng@chromium.org> > Reviewed-by: Akihiro Ota <akihiroota@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753470} TBR=dmazzoni@chromium.org,dtseng@chromium.org,akihiroota@chromium.org Change-Id: I01288031b7aab5694da31522da5393bf25ff2018 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121636Reviewed-by:
-
Jeff Yoon authored
This is a reland of f039e78b Original change's description: > [ios] ios-simulator-cronet tryjob src side Chromium config > > ios-simulator-cronet under chromium.fyi has already been migrated. > Missed migrating the trybot with it. > > Bug: 1055164,912681 > Change-Id: Ia58340308ba719dc6f39cf65ab40f73c4c89929b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120051 > Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753391} Bug: 1055164, 912681 Change-Id: If39fc51bcf87744f46345630881bdd6074a88638 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121136Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#753516}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b69c4e14c5e2..6719f54ac7ce git log b69c4e14c5e2..6719f54ac7ce --date=short --first-parent --format='%ad %ae %s' 2020-03-26 courtneygo@google.com Update Vulkan header and related repos Created with: gclient setdep -r src/third_party/angle@6719f54ac7ce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cnorthrop@google.com Change-Id: I52959a4e93b1deb319188c24ed42a5589bf7c9d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121464Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753515}
-
Jeff Yoon authored
- chromium recipe and xcode build version set in goma.star - additional_compile_targets in waterfalls.pyl - mb arguments in mb_config.pyl - clobber flag is set recipe side. Generated files: - chromium.goma.json - chromium.ci.json - cr-buildbucket.cfg Bug: 1055164, 912681 Change-Id: Ie7b99ec62aace430bd0a563fc341cf1104a32963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113431Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#753514}
-
tby authored
This removes the remaining references to the old 'cat' model, which we are no longer using. Bug: 1028447 Change-Id: I2d08e65e24fd979f485180338a03107902e57e76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121597 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#753513}
-
Kenichi Ishibashi authored
All methods/fields that should remain //content have moved to ServiceWorkerRegistry so these comments are no longer needed. Bug: 1039200 Change-Id: I6282c4d43c4cc59bd7d9782ad20ddea416d8fbe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120660 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Auto-Submit: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#753512}
-
Hayato Ito authored
Bug: 1064395 TBR: dominickn@chromium.org Change-Id: If8bcce47c110603e49155f5476104a2d7f30e104 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120835Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#753511}
-
Gyuyoung Kim authored
This CL moves flex-factor-less-than-one.html test from css3/css-flexbox to external/wpt/css/css-flexbox with WPT styles, adding links to the relevant specs, and a test description. Bug: 1063749 Change-Id: Ia2403deb69ca5f7e44f43d9b51c8b6664a09c999 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121596 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#753510}
-
Noel Gordon authored
Followup to CL:2066409. When quick-view first opens, it also opens the metadata box. Set the files-ng toolbar metadata info button's 'toogle' state (read the CL) to match the initial metadata box state [1]. [1] Missing from CL:2066409 and I missed it in code review :/ Bug: 992824 Change-Id: Ia81c809dc80f1290292379f2ef4cd63a949ed971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120833Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#753509}
-
Manuel Rego Casasnovas authored
These set of tests pass in Firefox but not in Chromium. They check what happens when you scroll an element with "text-overflow: ellipsis", right now in Chromium the rest of the content of the element is not visible at all (once truncated the text ellipsis is not moved). The solution would be to force a relayout during scrolling but it seems we prefer to keep current behavior to avoid performance issues on scrolling. The behavior is not mandatory according Both behaviors are allowed in the spec, so the tests are marked with the "should" flag: https://drafts.csswg.org/css-overflow/#ellipsis-scrolling Bug=745905 TEST=external/wpt/css/css-overflow/text-overflow-scroll-001.html TEST=external/wpt/css/css-overflow/text-overflow-scroll-rtl-001.html TEST=external/wpt/css/css-overflow/text-overflow-scroll-vertical-lr-001.html TEST=external/wpt/css/css-overflow/text-overflow-scroll-vertical-lr-rtl-001.html TEST=external/wpt/css/css-overflow/text-overflow-scroll-vertical-rl-001.html TEST=external/wpt/css/css-overflow/text-overflow-scroll-vertical-rl-rtl-001.html Change-Id: I975ca86dbdfedf92875c08736539fb2f33f68c54 Bug: 745905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113495 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#753508}
-
haozhe authored
The patch adds owning_element to CSSAnimation class. Now the CSSAnimations have an owning_element and we will clear the owning element if the animation disassociate from the owning_element. The next follow up patches will add the owning_element to CSSTransition and using owning element to compare the composite ordering. As per spec: https://drafts.csswg.org/css-transitions-2/#owning-element and: https://drafts.csswg.org/css-animations-2/#owning-element-section Bug: 1047316 Change-Id: I5ddb54b13330f851b830547f02d9acaad91f3e1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108613 Commit-Queue: Hao Sheng <haozhes@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#753507}
-
Wei-Yin Chen (陳威尹) authored
This reverts commit 4a511800. Reason for revert: break compile on many Android bots. See crbug.com/1064847. Original change's description: > Enable -Wunreachable-code on Android. > > Bug: 346399 > Change-Id: I41c8cf8581bff1256a28a15c80bdd59a599b0cc2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119759 > Auto-Submit: Nico Weber <thakis@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Commit-Queue: Bo <boliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753406} TBR=thakis@chromium.org,boliu@chromium.org Change-Id: I8cc1fea613255b63987bc1b1cc1c0af1972cf4b7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 346399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121468Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#753506}
-
Noel Gordon authored
Using setAttribute and removeAttribute is an anti-pattern in areas our code: toggleAttribute can be used to achieve the exact same result. Add a TODO about this.$.innerContentPanel.focus() not working. Comment is most likely out-of-date, we'll see. Bug: 992824 Change-Id: I58ab7ae8418273cde9eb41c78b9a9babfdd9658b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120775Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
-
Koji Ishii authored
Because we have |NGFragmentItem| for culled inline boxes, we don't have to loop and find descendants of inline boxes. This patch has no behavior changes. Bug: 982194 Change-Id: Iba288cfc788b0f30263c0f8910fa9a56ccd4bc2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120126Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#753504}
-
Koji Ishii authored
|MoveToLastForSameLayoutObject| saves |NGInlineCursor| because it was written before |NGInlineCursorPosition| was added. This patch changes to save |NGInlineCursorPosition|, saving a bit of memory bandwidth. This patch has no behavior changes. Bug: 982194 Change-Id: Ia1b8ddbf303c2823b2f72e8f24883435602d8399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120372Reviewed-by:
-
Noel Gordon authored
Nothing using this yet, but the hope is we can use :host-context() CSS html queries along with other html .foo state. No-try: true Bug: 992824 Change-Id: I74f6b8c28bb9f38e00848fee4ff3a37e73e2d668 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120776Reviewed-by:
-
Peng Huang authored
This is a reland of 838eb034 Original change's description: > VulkanImage: support create from GpuMemoryBufferHandle on Android > > VulkanImage::CreateFromGpuMemoryBufferHandle() is added to replace > VulkanImplementation::CreateVkImageAndImportAHB(), and will replace > VulkanImplementation::CreateImageFromGpuMemoryHandle() as well. > > Bug: None > Change-Id: I7c6e3cea685f1ec305790f4a6d7bb66164f26e55 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114587 > Commit-Queue: Peng Huang <penghuang@chromium.org> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753394} TBR=rjkroege@chromium.org,vasilyt@chromium.org Cq-Include-Trybots: luci.chromium.try:android_archive_rel_ng Bug: None Change-Id: Ie6132474ef4a386ed661116aa8f580fd8460901d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121442Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#753501}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e1d6f39d..3714932e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I30d3fc19f46e39f3c209e67c372d857c59127b7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121279Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753500}
-
Marijn Kruisselbrink authored
Bug: 1064795 Change-Id: Ib9999b6b2366872a92c508a292e8268936d54109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121416 Auto-Submit: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#753499}
-
Eriko Kurimoto authored
This CL removes the test expectation for shared worker parse error failure wpt which is exported from external Github. The timeout is fixed for module shared worker in the previous CL: https://chromium-review.googlesource.com/c/chromium/src/+/2100058 Bug: 1058259 Change-Id: Ifb5e4ccdb352d13cb3b4e9d42889ef3574c2e7d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121114Reviewed-by:
-
Ted Choc authored
This loosens the requirement that the activity is destroyed and allow a single SearchActivity to be in the finishing() state to determine success. BUG=1064092 Change-Id: I8149b1676d7dad21c508ae45464a1b12f2195f2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121457Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#753497}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I773f7e364ccc9e46095bed6a21447c977c1cdcc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121656Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753496}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/71cb6fda55ac..c2d325c1d67a git log 71cb6fda55ac..c2d325c1d67a --date=short --first-parent --format='%ad %ae %s' 2020-03-26 reed@google.com emptyshader should fail onProgram Created with: gclient setdep -r src/third_party/skia@c2d325c1d67a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: I2f9b3c40c41a9b2bb7b6a345e839c858c2e724f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121547Reviewed-by:
-
Hayato Ito authored
Bug: 1064839 TBR: davve@opera.com Change-Id: Ia74ae7cff46dba3e1ed01fad9b1deac02bfa41c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121635Reviewed-by:
-
Brandon Wylie authored
This logic is unnecessary because tablets always have the status view visible. Bug: 1059898 Change-Id: I37fcf536c71945ec844b346216495048315b44c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121088 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#753493}
-
Emily Andrews authored
This change removes the //mojo copy of zip.py and updates mojom.gni to use the one from //build/android Bug: 582594 Change-Id: I8e739c112696c47ce3afb68baf61b139359c5e98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119636 Commit-Queue: Emily Andrews <emiled@microsoft.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#753492}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/34f71abca1a1..de6c45646618 git log 34f71abca1a1..de6c45646618 --date=short --first-parent --format='%ad %ae %s' 2020-03-26 sokcevic@google.com Fix max value for git_common threading 2020-03-25 adrexler@google.com Use console url for recursive gsutil operations. Created with: gclient setdep -r src/third_party/depot_tools@de6c45646618 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ibb7e60517b4ce481b0226ad672266a5a5377bda0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121546Reviewed-by:
-
Bo Liu authored
There are two options to implement a callback for title changes. * Implement callback for when the active nav entry changes, and a callback for when the title of the nav entry changes * A callback for when the title of a tab changes, ignoring details about things like navigations. This CL takes the second option, since it's both simpler to implement and simpler to use. Bug: 1060997 Change-Id: I5ed1a3e41abcf5f7d7cf3c65cbd94533e8d9c36f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115695 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#753490}
-
David Tseng authored
TBR=dtseng@chromium.org Fixed: 1033649 Change-Id: I57b0ec7feaff6d07d0be16f626bfc6c46446699c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119767Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#753489}
-
Julie Jeongeun Kim authored
Migrate this test out of third_party/blink/web_tests/css3/flexbox and into the WPT-specific directory, adding links to the relevant specs, a test assertion describing its purpose, and a ref link. Bug: 1063749 Change-Id: I0d0850d82caaf1ac3bdfb55e28179592ea5bdf67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120080Reviewed-by:
-
Rohit Rao authored
BUG=1024115 Change-Id: I78dd1f2c79467f22cf8917d95be395f52c5343d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119750 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#753487}
-
Joshua Bell authored
The tests have moved to have a '.https' infix, so these expectations (files and entries) are unused/obsolete. Change-Id: I8c305115f3277e63510b1d3fb06ac8061b9f1b62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121356 Commit-Queue: Matt Giuca <mgiuca@chromium.org> Auto-Submit: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#753486}
-
rbpotter authored
Bug: 1026426 Change-Id: I54d838a9832a2540b2603aab936d4cd44f31eb24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119870 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#753485}
-
Lukasz Anforowicz authored
NetworkService was incorrectly using "bad_message_reason" crash key name when reporting a bad mojo message. This CL switches to using the correct "mojo-message-error" name (one that is recognized by the crash analysis services). This CL also moves the crash key definition to the //mojo layer, so that it can be reused both from //content and from //services/network. Bug: 987986 Change-Id: I772ae563df2f62ea430235524397b8492455de23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118690Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#753484}
-
Christopher Cameron authored
This access was previously living in apps/platform_apps, and using extension mechanisms. In a previous patch, I had moved AppShimRegistry into apps/app_shim. This was a mistake -- AppShimRegistry is only for web apps (not for all app shims). Move it to be in web_applications/components, and update it in web_app::AppShortcutManager. R=loyso TBR=avi (chrome/) Bug: 1057195 Change-Id: I284a56b472fde55f33f30a84c5959a68e4f0a04a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116564 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#753483}
-
Kenichi Ishibashi authored
ServiceWorkerUtils::CreateResourceResponseHeadAndMetadata() assumes that |http_info->headers| is always set. We plan to use the function in crrev.com/c/2108260 to convert HttpResponseInfo to URLResponseHead. This CL is a preparation for the conversion so that we don't need to add a check in the function. See [1] for more detailed context. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2108260/3/content/browser/service_worker/service_worker_cache_writer_unittest.cc#b33 Bug: 1060076 Change-Id: I2a34b78ba47b3ff67a4659975b09151b5f03bec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120993Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#753482}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/046389926f10..d5db214564bd git log 046389926f10..d5db214564bd --date=short --first-parent --format='%ad %ae %s' 2020-03-26 jiawei.shao@intel.com Collect if a storage texture is declared as multisampled in shader Created with: gclient setdep -r src/third_party/dawn@d5db214564bd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ibc7e548525838506ca6f0aaee5301c12a5998d71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121544Reviewed-by:
-
