- 24 Oct, 2019 6 commits
-
-
Xinghui Lu authored
When performing the full URL lookup, strip out the fragment, username and password components. Fragments are only used for local navigations. Usernames/Passwords are too privacy sensitive. Bug: 1015469 Change-Id: Ib3885a0acc7c479087cb9e5fe55696cd4745b7a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872753 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#708848}
-
Livvie Lin authored
Renames omnibox_https_invalid.png since the triangle icon will be used for HTTP pages as well as part of crbug.com/1008219. Bug: 1008219 Change-Id: Idca6aec6f38fa393accb64858d87c8c62b8f4543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873958 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#708847}
-
Albert Chaulk authored
Cast javascript channels add a window.<foo>.postMessage(message) method to selected RenderFrame instances to allow renderers to push data to the embedder. The usage looks like this: Browser: add interface during init Renderer: bind JsChannelBindingProvider, call Register, provide JsChannelClient Browser: stick the pid/route/channel in a list Embedder: AddJavascriptChannels Browser: lookup current RenderFrame and corresponding channel, call JsChannelClient::CreateChannel, provide JsChannel Renderer: create JS bindings <script>: call function Renderer: JsChannel::PostMessage Browser: send message to embedder Bug: b/141864193 Test: desktop cast_shell build + custom html Change-Id: I1425cb115f679b876a8b9cb75c418b9d2a7a1506 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863073Reviewed-by:Dominick Ng <dominickn@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#708846}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9fb9a722fb28..e8843ab060ac git log 9fb9a722fb28..e8843ab060ac --date=short --no-merges --format='%ad %ae %s' 2019-10-23 treehugger-gerrit@google.com Merge "Remove the call to std::partition, and replace with a readable for loop." Created with: gclient setdep -r src/third_party/perfetto@e8843ab060ac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ib719ae291a42ec8619516d8b6f141ab37c1c7a95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876882Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708845}
-
Peter Kasting authored
* Convert the central loop of CalculateAndDoLayout() to two nested loops. The outer loop iterates once per line, the inner once per view. This allows unifying all existing calls to AdvanceOneLine() to a single one in the outer loop. * At this point AdvanceOneLine() can be inlined and simplified. Bug: 1015717 Change-Id: Iecd4832a7b8eafccd69b50a7951628fded1336f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874825 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#708844}
-
Sebastien Marchand authored
This help ensuring that an old version of chrome_child.dll won't be accidently packaged in the installer. This code should be removed once we drop support for the multi DLL build. Tested manually on a local build. Bug: 1017245, 726150 Change-Id: I49c3885f937d6b034d94340e23cd83341fc3bd77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876232 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#708843}
-
- 23 Oct, 2019 34 commits
-
-
Caleb Raitto authored
Change-Id: I23fbfa6a19299275501370180f3ea07136d33902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876552 Commit-Queue: Caleb Raitto <caraitto@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#708842}
-
Ionel Popescu authored
This CL updates the UI for datetime-local popup by integrating the new time picker in the popup. Tests are added to validate the new UI and the value submission. Bug: 1016992 Change-Id: Ic2ba800248aa863d9dbf5867e0722f6059da1089 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874822Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#708841}
-
Darren Shen authored
It seems that RenderWidgetHostViewAura::SetCompositionFromExistingText fails to respect the active widget of the TextInputManager, and since different widgets can have completely separate FrameTrees, getting the correct focused frame relies on routing to the active widget. Bug: 971985, 1013515 Change-Id: If4c4f4e776423bbcb9d3c99dccb5b43e2abfc012 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858545 Commit-Queue: Darren Shen <shend@chromium.org> Auto-Submit: Darren Shen <shend@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#708840}
-
Sebastien Marchand authored
Reason for removing: It's been a while (3 years), this isn't needed anymore. Change-Id: I2e289ebb6fb5e8f3c6786fbfa22697357617b0aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875550 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
-
Scott Violet authored
This is a reland. The original path at https://chromium-review.googlesource.com/c/chromium/src/+/1872566 included deleting third_party/blink/web_tests/platform/mac-mac10.10/paint/invalidation/overflow/float-overflow-right-expected.txt That was wrong (not sure why the rebaseline tool did that). Two special cases that carry over from the old code: . LayoutDeprecatedFlexibleBox always started layout at an origin of 0, even when rtl. This gives the same behavior. . When rtl end is treated as start. BUG=1014884 TEST=fast/deprecated-flexbox/017.html Change-Id: Ifdd1dd8581844a1365dfceed5fd316dff7a78fd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876073Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#708838}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/376ccc06cd30..9988f9da4047 git log 376ccc06cd30..9988f9da4047 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 jbudorick@chromium.org devil: add support for adb push --sync behind a flag. (RELAND) Created with: gclient setdep -r src/third_party/catapult@9988f9da4047 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:922145,chromium:1015280 Change-Id: I4ff8ed52f2fe5e275d2d51138d50433211f63aeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876881Reviewed-by:
-
Clark DuVall authored
Since this superclass is mostly concerned with handling intents, the best name I could come up with is IntentWindowAndroid. Bug: 1017274 Change-Id: Iaadba0d7adbea13dc11bbaf88af1029d7dc4ebbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876729 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#708836}
-
James Vecore authored
Added a top level property/attribute to bluetooth_device_list_item for an explicit aria-label and put aria-hidden on the div text to avoid repeating. Bug: 1007100 Change-Id: Ie2b910c3b1652c1929f8c223fc68d94a66ac2d6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876910Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#708835}
-
Peter Kasting authored
Indents the main loop in CalculateAndDoLayout() inside another block. That's it. No functional change, just a trivial one. The entire purpose of this CL is to make the next CL's diff actually readable, since otherwise it looks like garbage. TBR=tapted Bug: 1015717 Change-Id: Ieda8fc854c3641bc70e4dd9cff0ae85755451cf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874849Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Dale Curtis authored
We're not having any luck debugging these failures locally, so enable VLOG(1) and DVLOG(1) for a few tests to help debug on macOS. BUG=1003761,1014646 R=tmathmeyer Change-Id: Ie14b4c5be287eabb526a91fa6acfa8dcacc97940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876315 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#708833}
-
Robert Liao authored
This fixes a build error due to use of std::wstring. BUG= TBR=brucedawson@chromium.org Change-Id: Ibb7c6f3eb856457d5b787976b826ac675117973f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877451Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#708832}
-
Saman Sami authored
Bug: 620927 Change-Id: I3870dd2e6cad2278036dfd484e9410f0bb197572 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865653Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#708831}
-
Oystein Eftevaag authored
R=ssid@chromium.org BUG=1017462 Change-Id: I22e281df59c29436ac092b9d4c959d9856a6b201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876978 Auto-Submit: oysteine <oysteine@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#708830}
-
rbpotter authored
Correctly detect HTML _templates in Polymer 3 files that have been minified (so "_template: html`<div></div>`," becomes "_template:html`<div></div>`,"). This is necessary to correctly replace i18n template expressions for optimized Web UIs using Polymer 3. Bug: 965770 Change-Id: I41112d5fa437964fa079ee5cfa41115324fa2579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877251Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#708829}
-
Jae Hoon Kim authored
For users of DlcserviceClient, the possibliy to observe the download/install of a DLC is added. Bug: b:143098235 Test: autoninja -C out/Default chromeos_unittests && ./out/Default/chromeos_unittests Change-Id: I846f05664e1ff90626ac79af4dcc4e3dbfd7ce23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874815 Commit-Queue: Jae Hoon Kim <kimjae@chromium.org> Reviewed-by:
-
Ian Clelland authored
Pushed the expiry out approximately 1 year. Bug: 988768 Change-Id: Iff0f962886eb10678256c481fe9e96327668f989 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872464 Auto-Submit: Ian Clelland <iclelland@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cba64462d266..fbaef603dece git log cba64462d266..fbaef603dece --date=short --no-merges --format='%ad %ae %s' 2019-10-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-23 fmalita@chromium.org Color filter benchmarks 2019-10-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-23 csmartdalton@google.com Disable msaa on Pixel3a 2019-10-23 halcanary@google.com [minor] SkRemoteGlyphCache impl: add explicit 2019-10-23 jvanverth@google.com Set Metal rendertargetproxy via drawableSize 2019-10-23 senorblanco@chromium.org Dawn: implement unified UBOs. 2019-10-23 michaelludwig@google.com Revert "hide color filters from blitters" Created with: gclient setdep -r src/third_party/skia@fbaef603dece If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Bug: chromium:b/143074513 Change-Id: I0cd4b61e1b8471e2ccd0a7f638d8e2e8167fb770 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877134Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9709599c10ff..e7bf2eba2b5d Created with: gclient setdep -r src-internal@e7bf2eba2b5d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:1010713,chromium:b/141127636 Change-Id: If71b02cb4fffa4abec924bd38d245fe818b61051 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876919Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708825}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b1ae481f7fe3..ea98ebbe654a git log b1ae481f7fe3..ea98ebbe654a --date=short --no-merges --format='%ad %ae %s' 2019-10-23 vapier@chromium.org chromite_wrapper: modernize a bit 2019-10-23 gbeaty@chromium.org Avoid accessing the None json output on gclient sync failure. Created with: gclient setdep -r src/third_party/depot_tools@ea98ebbe654a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:997354 Change-Id: Ief28ec1a4d00bff25e164ab6927faaa498530fb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877133Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d7bf5c56b69b..4ff1c872045c git log d7bf5c56b69b..4ff1c872045c --date=short --no-merges --format='%ad %ae %s' 2019-10-23 mbonadei@webrtc.org Fix RTC_LOCKABLE RTC_EXPORT order for rtc::Thread. Created with: gclient setdep -r src/third_party/webrtc@4ff1c872045c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I96e855ead75938be93abf29ada262e9d4528a471 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877132Reviewed-by:
-
David Tseng authored
This is the on-going process to finish up the fork of ChromeVox Classic. Adding a build file will allow us to: - compress the ChromeVox Classic source* - remove deps.js which is a maintenance burden * - share string resources * - migrate all tests only for ChromeVox Classic to ui/accessibility/extensions - delete all Classic only js, assets from mainline ChromeVox * denotes things that happened in this change. Change-Id: I317be0ff2107eeb1f688da8690c38d191a55310b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874256 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#708822}
-
Garrett Beaty authored
This reverts commit f26b6b6d. Reason for revert: Causes presubmit failure due to generate_buildbot_json attempting to read deleted luci-milo-dev.cfg. Original change's description: > Migrate luci-milo-dev.cfg to starlark. > > Bug: 1011908 > Change-Id: Ic7f4fc26d75811f04c9f988866bb479a40e0d0c3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869713 > Auto-Submit: Garrett Beaty <gbeaty@chromium.org> > Reviewed-by: Aaron Gable <agable@chromium.org> > Commit-Queue: Garrett Beaty <gbeaty@chromium.org> > Cr-Commit-Position: refs/heads/master@{#708714} TBR=agable@chromium.org,gbeaty@chromium.org Change-Id: I16fd97a3ccef990cd0d2bc58314f6006a3328f82 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1011908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875660Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#708821}
-
Matt Mueller authored
Bug: 635205 Change-Id: I5b5e69ed79d017fcd36110c7ad73d08f8f6adea0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876739Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#708820}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/17e452a6..f3b63d6f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iaa9488a1705f6d50070ee7969c2f4942fcf88d7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877087Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708819}
-
Jamie Walch authored
We register a handler for Ctrl+Alt+Esc for remote assistance to give a keyboard shortcut for the local user to use if they need to disconnect the remote user in a hurry. Unfortunately, on Catalina this means that the user needs to whitelist the process for "monitor keyboard activity from all process" permission, which is more than we need and quite an alarming thing to ask our users to approve. Since this shortcut is not advertised anywhere, it seems more prudent to remove it, on Mac only for now, but potentially on all platforms in the future. Fixed: 1015242 Change-Id: I72ae4c214eb7d6fcec77bafff91495b07b7b91c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876206 Auto-Submit: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#708818}
-
Livvie Lin authored
https://chromium-review.googlesource.com/c/chromium/src/+/1769353 added a mode to IOSSSlErrorHandler that returns error HTML in a callback. This CL calls into IOSSSLErrorHandler::HandleSSLError from PrepareErrorPage to display the actual interstitial on an SSL error instead of a generic error page. Bug: 987407 Change-Id: I472e9012988a0b8fcc3f72d8dbc52aad07c067a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793260 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#708817}
-
manuk authored
With this CL, the doc provider will have 6 query-length related parameters: DocumentProviderMin(Max)QueryLength Limits for which inputs the provider will make a request to the drive backend. This is useful to relieving backend load. DocumentProviderMin(Max)QueryShowLength Limits for which inputs the provider will show doc suggestions (assuming the backend returned documents). These help analyze experiments by allowing observing the effect of changing |min(max)_query_length_| while keeping data populations consistent. DocumentProviderMin(Max)QueryLogLength Limits for which inputs the provider will log field_trial_triggered_(in_session_). These help analyze experiments by restricting data populations to avoid noise when only interested in a range of input lengths. E.g. experimenting with |max_query_show_length_| would affect only the small subset of long queries. Bug: 1015977, 864302 Change-Id: Iacb16d8b67b4adeb20e3e73d8570d45e0174d33a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869374 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#708816}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/75647d9e1ae7..720447713e24 git log 75647d9e1ae7..720447713e24 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 seanabraham@chromium.org chromeos_config: don't run HW tests for VM-only build target Created with: gclient setdep -r src/third_party/chromite@720447713e24 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I2c8daf827666d0762684c0da8e90ac2229841a3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875651Reviewed-by:
-
Peter Kasting authored
* Makes CreateLabelRange() a member function (and renames it CreateLabel()) to allow it to use various members that are currently passed as arguments the same way at both callsites. This makes the code simpler and more future-proof. It also allows moving the color-related functionality in from the caller. * To allow CreateLabel() to be const, moves the set_listener() call to the caller side. Only one caller needs this anyway. * Stop calling AdvanceOneLine() in the "very first line was empty" case, where it will have no effect, since |new_line| is false and there are no views to adjust. * The final post-loop call of AdvanceOneLine() doesn't actually care about whether |new_line| is set to false (since the adjusted values won't be read afterwards). Combined with the change above, this means the |new_line| arg can be eliminated entirely. * Change |max_line_height| (which sounds like the max height of all lines) to the less-ambiguous (and shorter) |line_height|, since it's the height of the current line. * At the end of the loop, adjust |remaining_string| before calling AdvanceOneLine() instead of after. These are independent, so this has no effect, but it will allow for a control flow change in a subsequent patch. Bug: 1015717 Change-Id: Ie1858c29b70f5c8ff1e9ba005a7fddb5e446e133 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875028 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Brandon Walderman authored
This change moves the logic for constructing DevTools endpoint URLs into a common location (DevToolsHttpEndpoint). Call sites that were previously building URL strings directly can now call the appropriate method on DevToolsHttpEndpoint instead. For example, List() returns an endpoint's /json/list URL. A DevToolsHttpEndpoint can be constructed from a NetAddress for the common case where the endpoint is running on localhost on a certain port. It can also be constructed from a URL with a path prefix. The prefix will be included in all URLs for that endpoint. This is mainly to support some downstream features in MSEdgeDriver that rely on devtools endpoints with path prefixes and which may be served over HTTPS. There is no functional change to ChromeDriver. Just some refactoring. Bug: 1016888 Change-Id: I50dc97f23637f58f972e7f5a5807e74a7af5f69a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874200Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Brandon Walderman <brwalder@microsoft.com> Cr-Commit-Position: refs/heads/master@{#708813}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/08af1c80188f..88a99e4382c1 git log 08af1c80188f..88a99e4382c1 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 tobine@google.com Vulkan:Roll Loader 2019-10-23 tobine@google.com OES_depth32 is for render buffer capability Created with: gclient setdep -r src/third_party/angle@88a99e4382c1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: None Change-Id: Ie62667ad86bd376e1c668cd0c066c6392d56359e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875652Reviewed-by:
-
Sammie Quon authored
It's an edge case when moving the divider either in portrait mode, or like in the video in the attached bug. Test: manual Fixed: 1017370 Change-Id: I78e11fc1785cf9d39363aa90c52a851243b9736e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877190Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#708811}
-
Mason Freed authored
Prior to this CL, the HTML Imports deprecation message would only be shown if HTML Imports was enabled directly by a command line flag. It would not show if the page being visited was participating in the Web Components v0 origin trial, and enabled the feature that way. Bug: 911943 Change-Id: I8884ea755fdcdd69e2af57c6f131eed83f76b4f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876799 Commit-Queue: Mason Freed <masonfreed@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#708810}
-
Natalie Chouinard authored
Bug: 1016957 Change-Id: I5baf2577d2df7fd37827811102bbcba746280542 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876877Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#708809}
-
