- 13 Dec, 2014 17 commits
-
-
reillyg authored
This is a possible fix for crashes observed in this function. The member variable browser_context_ is possibly invalid because the object may be freed by function->Run(). To avoid this we move the call to ProcessManager::Get() to before where function->Run() is called. BUG=441679 Review URL: https://codereview.chromium.org/798103002 Cr-Commit-Position: refs/heads/master@{#308214}
-
ckocagil authored
BUG=439572 Review URL: https://codereview.chromium.org/785763002 Cr-Commit-Position: refs/heads/master@{#308213}
-
dbeam authored
R=thestig@chromium.org BUG=none Review URL: https://codereview.chromium.org/801983002 Cr-Commit-Position: refs/heads/master@{#308212}
-
cmumford authored
Some cleanup: * Replaced iterator with range based for loop. * Renamed a few parameters/local variables to improve clarity: * ChromiumEnv::RestoreIfNecessary "result" param -> "dir_entries". * "dir_filepath" -> "dir_path" * ChromiumEnv::GetChildren "dir_string" -> "dir" * Accepted some "git cl format" improvements. Review URL: https://codereview.chromium.org/790913003 Cr-Commit-Position: refs/heads/master@{#308211}
-
reillyg authored
This change fixes the USB device handle tests on OS X by claiming the necessary interfaces before using them and using the right endpoint numbers. It also enables the HID connection tests on OS X by creating a MessageLoopForUI on the main thread (to mimic the usual configuration in the Chrome browser process) and a separate thread running a MessageLoopForIO. Review URL: https://codereview.chromium.org/804643002 Cr-Commit-Position: refs/heads/master@{#308210}
-
satorux authored
In favor of less things to have in chrome/browser/chromeos. BUG=437719 TEST=everything builds as before Review URL: https://codereview.chromium.org/799683003 Cr-Commit-Position: refs/heads/master@{#308209}
-
oshima authored
BUG=426292 Review URL: https://codereview.chromium.org/803693002 Cr-Commit-Position: refs/heads/master@{#308208}
-
tengs authored
BUG=420316 Review URL: https://codereview.chromium.org/792193003 Cr-Commit-Position: refs/heads/master@{#308207}
-
rvargas authored
BUG=417532 Review URL: https://codereview.chromium.org/785353003 Cr-Commit-Position: refs/heads/master@{#308206}
-
rvargas authored
BUG=417532 R=rtenneti@chromium.org Review URL: https://codereview.chromium.org/793463002 Cr-Commit-Position: refs/heads/master@{#308205}
-
spang authored
This adds a use_xkbcommon variable that allows usage of libxkbcommon in the build. Turn this on for linux ozone builds (except embedded builds). BUG=430194 TEST=build Review URL: https://codereview.chromium.org/751623003 Cr-Commit-Position: refs/heads/master@{#308204}
-
rvargas authored
BUG=417532 Review URL: https://codereview.chromium.org/785363002 Cr-Commit-Position: refs/heads/master@{#308203}
-
maruel authored
$ git log dbff01c15..b10edf25e --date=short --format='%ad %ae %s' | sed 's/@chromium\.org//' 2014-12-11 maruel Remove FileSystem; it's not used anymore even by tests. 2014-12-11 maruel Overhaul tests to stop using FileSystem in isolateserver.py. 2014-12-10 maruel Fix regression in 012067b422; exception bc 2 report_on_exception_exit() calls 2014-12-10 maruel Add coherent automatic https:// prefix to server flags. 2014-12-10 maruel Remove last remnant of support for --indir. 2014-12-09 maruel Get rid of tests/run_isolated/ and create a in-process isolate server mock. 2014-12-08 maruel Remove --isolated from run_isolated.py. R=vadimsh@chromium.org BUG= Review URL: https://codereview.chromium.org/794903006 Cr-Commit-Position: refs/heads/master@{#308202}
-
samuong authored
BUG=441757 TBR=jeremyim@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/804573004 Cr-Commit-Position: refs/heads/master@{#308201}
-
twellington authored
BUG=441481 Review URL: https://codereview.chromium.org/801533002 Cr-Commit-Position: refs/heads/master@{#308200}
-
arnarb authored
Allows the extension to display an infobar to collect explicit user consent before registering a key. BUG=426358 Review URL: https://codereview.chromium.org/766303003 Cr-Commit-Position: refs/heads/master@{#308199}
-
reed authored
BUG= Review URL: https://codereview.chromium.org/797753003 Cr-Commit-Position: refs/heads/master@{#308198}
-
- 12 Dec, 2014 23 commits
-
-
jbudorick authored
Dependent on https://codereview.chromium.org/787393003/ BUG= Review URL: https://codereview.chromium.org/796503004 Cr-Commit-Position: refs/heads/master@{#308197}
-
dbeam authored
R=benjhayden@chromium.org BUG=440741 Review URL: https://codereview.chromium.org/795353002 Cr-Commit-Position: refs/heads/master@{#308196}
-
samuong authored
Revert of Update DisplayConfigurator to use the asynchronous tasks (patchset #4 id:60001 of https://codereview.chromium.org/801493002/) Reason for revert: seems to be causing problems in display_unittests on the following bot: https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/5095 Original issue's description: > Update DisplayConfigurator to use the asynchronous tasks > > Now DisplayConfigurator can take advantage of asynchronous configuration APIs. > Note: For X11, NativeDisplayDelegate is still implemented via synchronous calls > so all configurations will be synchronous on X11. > > Notable changes: > 1) EnterState(), UpdateCachedDisplays() and FindMirrorMode() have been moved > into the DisplayLayoutManager implementation. > 2) NativeDisplayDelegate's initialization has been moved before grabbing the > server. Shouldn't cause any issues since the server doesn't need to be grabbed > when initializing NDD. > > BUG=429746 > TEST=display_unittests and manually on Link with X11 > > Committed: https://crrev.com/7547705543d6b711a166e513a43a4e43f93fd254 > Cr-Commit-Position: refs/heads/master@{#308175} TBR=derat@chromium.org,dnicoara@chromium.org NOTREECHECKS=true NOTRY=true BUG=429746 Review URL: https://codereview.chromium.org/797383002 Cr-Commit-Position: refs/heads/master@{#308195}
-
rlp authored
setting. The functions for showing hotwording and showing the audio history state now take into account the sign in state and correctly update when the sign in state changes. BUG=441419, 435637 Review URL: https://codereview.chromium.org/797763002 Cr-Commit-Position: refs/heads/master@{#308194}
-
cmumford authored
These two tests are new with the latest leveldb DEPS roll. Review URL: https://codereview.chromium.org/804473006 Cr-Commit-Position: refs/heads/master@{#308193}
-
rockot authored
This turns on functional support for the unlimitedStorage content_capabilities grant. BUG=409272 R=kalman@chromium.org Review URL: https://codereview.chromium.org/802593003 Cr-Commit-Position: refs/heads/master@{#308192}
-
pneubeck authored
The Init() function did never call back if the username_hash was empty, because GetPrivateSlotForChromeOSUser would return a nullptr and InitIfSlotsAvailable returning consistently false. Now the callback will be called once GetPrivateSlotForChromeOSUser returned. This change is on purpose kept minimal to allow merging to M40. BUG=434205 Review URL: https://codereview.chromium.org/802433002 Cr-Commit-Position: refs/heads/master@{#308191}
-
rdevlin.cronin authored
Previously, [BrowserActionsContainer animationEndFrame] only returned the frame after animation once animation had occurred. Replace this with an always- valid animationEndFrame method that returns the frame after animation, or the current frame if the container is not animating. Also, move the animation suppression for testing to the ToolbarActionsBar so that it is platform-independent. TBR=sky@chromium.org (moving animation suppression flag) BUG=435518 Review URL: https://codereview.chromium.org/795663003 Cr-Commit-Position: refs/heads/master@{#308190}
-
newt authored
The "app_name" string needs to be defined in an Android resources XML file instead of in android_chrome_strings.grd so the string isn't copied into every language (which makes it impossible to override the string from a single strings.xml file) BUG=441424 Review URL: https://codereview.chromium.org/800953002 Cr-Commit-Position: refs/heads/master@{#308189}
-
rnephew authored
Add AMP support to test runner. BUG=428729 Review URL: https://codereview.chromium.org/803643002 Cr-Commit-Position: refs/heads/master@{#308188}
-
oshima authored
The opacity stays 0.2f if the window is created and shown in inactive state because the opacity is set back to 1.0f only when the animation is applied. This CL uses 1.0f opacity as initial opacity and when transitioning from/to small shadow. BUG=433574 TEST=manual test. See the bug for repro step. Review URL: https://codereview.chromium.org/798673002 Cr-Commit-Position: refs/heads/master@{#308187}
-
zhaoqin authored
TBR=jbauman@chromium.org BUG=441785 NOTRY=true Review URL: https://codereview.chromium.org/787253004 Cr-Commit-Position: refs/heads/master@{#308186}
-
rvargas authored
BUG=417532 Review URL: https://codereview.chromium.org/789023002 Cr-Commit-Position: refs/heads/master@{#308185}
-
siggi authored
and metrics reporting. BUG=412384 Review URL: https://codereview.chromium.org/792163002 Cr-Commit-Position: refs/heads/master@{#308184}
-
satorux authored
In favor of less things to have in chrome/browser/chromeos. BUG=437691 TEST=everything builds as before Review URL: https://codereview.chromium.org/786693002 Cr-Commit-Position: refs/heads/master@{#308183}
-
pkasting authored
BUG=81439 TEST=none Review URL: https://codereview.chromium.org/777853003 Cr-Commit-Position: refs/heads/master@{#308182}
-
shrikant authored
As things seem to have stabilized after Cache check-in. I want to see and experiment with removing this limit. Modified Cache file version, so that it will be regenerated. BUG=441477 R=scottmg,cpu Review URL: https://codereview.chromium.org/796643004 Cr-Commit-Position: refs/heads/master@{#308181}
-
tengs authored
The metric in the app was broken for a while now. We will fix the metric natively so we don't have to deal with app lifetime issues. BUG=433697 Review URL: https://codereview.chromium.org/799623003 Cr-Commit-Position: refs/heads/master@{#308180}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/923676f..095dcae TBR=lushnikov@chromium.org,vsevik@chromium.org,dglazkov@chromium.org Review URL: https://codereview.chromium.org/799883003 Cr-Commit-Position: refs/heads/master@{#308179}
-
spang authored
Use the device's path in the device tree rather than a device name whitelist to determine if it is permanently attached. This is consistent with the strategy we've been using for touchscreens. This slightly changes the code to just remove non-keyboards from the keyboard list, instead of overloading INPUT_DEVICE_UNKNOWN to mean it is not a keyboard. TEST=manual on chromeos build on ubuntu BUG=437539 Review URL: https://codereview.chromium.org/798453002 Cr-Commit-Position: refs/heads/master@{#308178}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/a60b2ea..1629118 CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg TBR=scroggo@google.com Review URL: https://codereview.chromium.org/801903002 Cr-Commit-Position: refs/heads/master@{#308177}
-
kalman authored
use it for the experimental permission. BUG=440194 R=rockot@chromium.org Review URL: https://codereview.chromium.org/801603002 Cr-Commit-Position: refs/heads/master@{#308176}
-
dnicoara authored
Now DisplayConfigurator can take advantage of asynchronous configuration APIs. Note: For X11, NativeDisplayDelegate is still implemented via synchronous calls so all configurations will be synchronous on X11. Notable changes: 1) EnterState(), UpdateCachedDisplays() and FindMirrorMode() have been moved into the DisplayLayoutManager implementation. 2) NativeDisplayDelegate's initialization has been moved before grabbing the server. Shouldn't cause any issues since the server doesn't need to be grabbed when initializing NDD. BUG=429746 TEST=display_unittests and manually on Link with X11 Review URL: https://codereview.chromium.org/801493002 Cr-Commit-Position: refs/heads/master@{#308175}
-