GitLab

Test: conformance/uniforms/out-of-bounds-uniform-array-access.html
The breaking CL was reverted, this should now pass.

Bug: chromium:1042252
Change-Id: I96a76566ef5020b08d61965980b5d8be7ad1cbfe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002891Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Cr-Commit-Position: refs/heads/master@{#732402}

The passthrough calls glBlitFramebuffer, so this extension should be
added as required. ANGLE implements this extension on all backends.

Bug: chromium:1029829
Change-Id: Iaccedfd8ae0000b06b5b8126b9c1c86679767e67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002936Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Cr-Commit-Position: refs/heads/master@{#732401}

Adjust the exponential decay to decay more rapidly (about 3x higher
exponent) to reduce the number of samples we send.

`

Bug: 1035531
Change-Id: Ie6de6eaca5c6dc49cd2e674e4c9d82f30d59c294
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003291
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Auto-Submit: Stephen Chenney <schenney@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732400}

On receiving an auth error (HTTP 401), PerUserTopicSubscriptionManager
invalidates the access token and retries, based on the assumption that
the access token was likely expired. That makes sense once, but if the
second request fails with an auth error again, there's really no point
in trying again. In some cases, it might even lead to an infinite loop
of invalidating and re-requesting access tokens.
This CL changes the behavior so that a request is retried exactly once
on an auth error. If it fails again, it is abandoned (which already
happens for all other 4xx errors).

Bug: 1020117
Change-Id: I0c83d3eaa5bafcc8d9f81315921f8375661371af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000625
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732399}

This refactoring is a pre-requisite for hooking clipboard paste to
upload content checks for enterprise users.  See crbug.com/999150 for
more details.

Bug: 999152
Change-Id: I2ddc8d25435abff4abc00437de7a284708e5f842
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877532
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732398}

The correct access point is always ACCESS_POINT_AVATAR_BUBBLE_SIGN_IN.

Fixed: 1041469
Change-Id: Ia698fec6da8a221f36188a87f899a0bbd4a10d4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000639
Auto-Submit: David Roger <droger@chromium.org>
Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732397}

TBR=akihiroota

Bug: 1042673
Change-Id: Iccf2064ee5b817bc9e7f12c026cd8569e39d22b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002816Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732396}

This change caters to users that have a tendency to toggle between
a different language and the original language of a page.

Bug: 1014959, 1042410
Change-Id: I718124ce7791762f7311e511e2cac6d5d7d5a671
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003252
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Auto-Submit: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732395}

This change updates the mutable base::Value::GetList() to return
base::Value::ListView instead of base::Value::ListStorage&. This
improves both encapsulation and safety, as now all accesses to the
underlying Values are bounds-checked.

TBR=dcheng

Bug: 646113,990059
Change-Id: Id7d61862bf7cab1f7341f2c215f07249dbadf3b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801107
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732394}

TBR=foolip

Bug: 1042681
Change-Id: I6f44287a5774774deabe7ccc35f3f2ce7e3608a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003131Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732393}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0cfd3dc2afae..5bddf6a45982

git log 0cfd3dc2afae..5bddf6a45982 --date=short --first-parent --format='%ad %ae %s'
2020-01-16 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS.
2020-01-16 tvanderlippe@chromium.org Migrate workspace/ to ESM internally
2020-01-16 tvanderlippe@chromium.org Remove unused globals
2020-01-16 tvanderlippe@chromium.org Reland "Use typescript-eslint instead of tslint"
2020-01-16 tvanderlippe@chromium.org Migrate timeline_model/ to ESM internally
2020-01-16 szuend@chromium.org [cleanup] Remove unused {rotate} array utilities function

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@5bddf6a45982

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1006759
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Ib2703dc6570740947dd533d5a572dc681d642b57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004502Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#732392}

Moves the implementation of TabSwitcherDelegate "helpers" from Main to Scene
controller. Moves the temporary interface from MCGuts to SCGuts.

Bug: none
Change-Id: Ie874e8f754cd6e38ba3aa04c6e64ea68192c95dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992084
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732391}

clang-cl doesn't recognize the flag as it is.

CrOS doesn't know the flag. While that's not relevant for the ToT bots,
it makes sense to handle it already, to make it easier when we roll Clang.

Bug: 1042470
Change-Id: I3ae6476be2d2031f92a6c6613aa2138eba76fe9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003133Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732390}

map() returns a list in Python 2. Python 3 returns an iterator and if a list is needed it's necessary to call list().
Calling list() results in the same behaviour in both.
There should be no behavioural changes.

Ran "git cl format".

Fixes the following errors:
Traceback (most recent call last):
  File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 556, in <module>
    sys.exit(main())
  File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 551, in main
    return args.func(args, remaining_args)
  File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 267, in _Generate
    processor._GenerateModule(args, remaining_args, generator_modules,
  File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 238, in _GenerateModule
    generator.GenerateFiles(filtered_args)
  File "C:\Google\chromium\src\mojo\public\tools\bindings\generators\mojom_cpp_generator.py", line 461, in GenerateFiles
    self.WriteWithComment(self._GenerateModuleSharedMessageIdsHeader(),
  File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\template_expander.py", line 36, in GeneratorInternal
    parameters = generator(*args, **kwargs2)
  File "C:\Google\chromium\src\mojo\public\tools\bindings\generators\mojom_cpp_generator.py", line 438, in _GenerateModuleSharedMessageIdsHeader
    return self._GetJinjaExports()
  File "C:\Google\chromium\src\mojo\public\tools\bindings\generators\mojom_cpp_generator.py", line 330, in _GetJinjaExports
    "extra_public_headers": self._GetExtraPublicHeaders(),
  File "C:\Google\chromium\src\mojo\public\tools\bindings\generators\mojom_cpp_generator.py", line 276, in _GetExtraPublicHeaders
    self.module.structs + all_enums + self.module.unions)
TypeError: unsupported operand type(s) for +: 'map' and 'list'

Traceback (most recent call last):
  File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 556, in <module>
    sys.exit(main())
  File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 551, in main
    return args.func(args, remaining_args)
  File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 267, in _Generate
    processor._GenerateModule(args, remaining_args, generator_modules,
  File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 238, in _GenerateModule
    generator.GenerateFiles(filtered_args)
  File "C:\Google\chromium\src\mojo\public\tools\bindings\generators\mojom_cpp_generator.py", line 461, in GenerateFiles
    self.WriteWithComment(self._GenerateModuleSharedMessageIdsHeader(),
  File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\template_expander.py", line 36, in GeneratorInternal
    parameters = generator(*args, **kwargs2)
  File "C:\Google\chromium\src\mojo\public\tools\bindings\generators\mojom_cpp_generator.py", line 438, in _GenerateModuleSharedMessageIdsHeader
    return self._GetJinjaExports()
  File "C:\Google\chromium\src\mojo\public\tools\bindings\generators\mojom_cpp_generator.py", line 342, in _GetJinjaExports
    "uses_interfaces": self._ReferencesAnyHandleOrInterfaceType(),
  File "C:\Google\chromium\src\mojo\public\tools\bindings\generators\mojom_cpp_generator.py", line 289, in _ReferencesAnyHandleOrInterfaceType
    if len(self.module.interfaces) > 0:
TypeError: object of type 'map' has no len()

Traceback (most recent call last):
  File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 556, in <module>
    sys.exit(main())
  File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 551, in main
    return args.func(args, remaining_args)
  File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 267, in _Generate
    processor._GenerateModule(args, remaining_args, generator_modules,
  File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 238, in _GenerateModule
    generator.GenerateFiles(filtered_args)
  File "C:\Google\chromium\src\mojo\public\tools\bindings\generators\mojom_cpp_generator.py", line 461, in GenerateFiles
    self.WriteWithComment(self._GenerateModuleSharedMessageIdsHeader(),
  File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\template_expander.py", line 36, in GeneratorInternal
    parameters = generator(*args, **kwargs2)
  File "C:\Google\chromium\src\mojo\public\tools\bindings\generators\mojom_cpp_generator.py", line 438, in _GenerateModuleSharedMessageIdsHeader
    return self._GetJinjaExports()
  File "C:\Google\chromium\src\mojo\public\tools\bindings\generators\mojom_cpp_generator.py", line 343, in _GetJinjaExports
    "uses_native_types": self._ReferencesAnyNativeType(),
  File "C:\Google\chromium\src\mojo\public\tools\bindings\generators\mojom_cpp_generator.py", line 303, in _ReferencesAnyNativeType
    m.enums + m.structs + m.interfaces))
TypeError: unsupported operand type(s) for +: 'map' and 'list'

Traceback (most recent call last):
  File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 556, in <module>
    sys.exit(main())
  File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 551, in main
    return args.func(args, remaining_args)
  File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 267, in _Generate
    processor._GenerateModule(args, remaining_args, generator_modules,
  File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 215, in _GenerateModule
    AddComputedData(module)
  File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\generator.py", line 184, in AddComputedData
    _AddStructComputedData(True, struct)
  File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\generator.py", line 123, in _AddStructComputedData
    struct.packed = pack.PackedStruct(struct)
  File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\pack.py", line 130, in __init__
    if (len(struct.fields) == 0):
TypeError: object of type 'map' has no len()

Bug: 941669
Change-Id: I8f7d3fa25a610db32446ad6b2baa6edac1723601
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995335Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Raul Tambre <raul@tambre.ee>
Auto-Submit: Raul Tambre <raul@tambre.ee>
Cr-Commit-Position: refs/heads/master@{#732389}

As a step to convert legacy IPCs to the Mojo, this CL
converts browser side's BlinkTest IPCs to Mojo. This
CL introduces WebTestClient interface to replace the
IPC messages to Mojo methods in web_test.mojom file.
The interface starts to support the original messages
as below,

 - InitiateLayoutDump()
 - PrintMessageToStderr()
 - SetPopupBlockingEnabled()
 - NavigateSecondaryWindow()
 - GoToOffset
 - Reload()
 - LoadURLForFrame()
 - CloseRemainingWindows()
 - ResetDone()
 - SendBluetoothManualChooserEvent()
 - GetBluetoothManualChooserEvents()
 - SetBluetoothManualChooser()

This CL should not change any behavior.

Bug: 1039247
Change-Id: Ic30f8cc0cb19ec8a306b577f3c10567d91bdccf1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002047Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#732388}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/8013d477aeac..323a81fc5e30

git log 8013d477aeac..323a81fc5e30 --date=short --first-parent --format='%ad %ae %s'
2020-01-15 alanbaker@google.com Validate Vulkan 1.2 capabilities
2020-01-15 dneto@google.com Add basic support for Vulkan 1.2: SPV_ENV_VULKAN_1_2
2020-01-14 jaebaek@google.com Fix OpLine bug of merge-blocks pass (#3130)

Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@323a81fc5e30

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com,jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64
Bug: None
Tbr: radial-bots+chrome-roll@google.com,jonahr@google.com
Change-Id: If59e23feecc075d0f98777623d5c3b97927dc268
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003823Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#732387}

The expiry is the same as Browser.Tabs.TabSwitchResult and
Browser.Tabs.TotalSwitchDuration. These metrics needs to be analyzed
together.

Fixed: 1037572
Bug: 1037572
Change-Id: I5f19e9f612361488478e7e0ff2138cae91b5cb65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003217
Auto-Submit: François Doray <fdoray@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732386}

Fix stack-use-after-return error by not returning a reference of local
variable in RequestPrimaryAccount.

This is a reland of 268d26b8

Original change's description:
> ARC: Add a mojo method for getting the primary account
>
> ARC needs to know the identity of the primary account, but it cannot
> retrieve that from Android account manager.
>
> Add a mojo method in ArcAuthService for returning the primary account
> information from Chrome OS.
>
> Bug: b/141108534
> Test: browser_tests --gtest_filter="*Arc*AuthService*Test*"
> Change-Id: I01ec976a330d52421ab2ddfe5155c712c81967af
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810359
> Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org>
> Reviewed-by: Mattias Nissler <mnissler@chromium.org>
> Reviewed-by: Yury Khmel <khmel@chromium.org>
> Reviewed-by: Kush Sinha <sinhak@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#726738}

Bug: b/141108534
Cq-Include-Trybots: luci.chromium.try:linux_chromium_chromeos_asan_rel_ng
Change-Id: I3cf1d02c9dc0be5d23b7a3992747716efe576221
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997128Reviewed-by: Kush Sinha <sinhak@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732385}

Bug: 1006539
Change-Id: Icfdd0e27aeaf98e610a2324578bf651da2f2a045
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003174
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732384}

..between browser and shell bindings. The interface has gotten out of
sync after crrev.com/c/1951104 which introduced additional error
reporting.

TBR=yangguo@chromium.org

Bug: chromium:1030746
Change-Id: If609eb709156e3d0b2142e631878c8821fc1f84c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000622Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732383}

https://android.googlesource.com/platform/external/perfetto.git/+log/1039ef14d7ad..11c11a1a891c

git log 1039ef14d7ad..11c11a1a891c --date=short --first-parent --format='%ad %ae %s'
2020-01-16 treehugger-gerrit@google.com Merge "Make zlib optional"

Created with:
  gclient setdep -r src/third_party/perfetto@11c11a1a891c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: If07a3e03a4b8d8a219d3f13f857d454fa45a5a99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004501Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#732382}

The crowd deny preload list now contains sites with a site reputation
of UNSOLICITED_PROMPTS. If a site is not on the preload list the normal
UI is used, otherwise a safe browsing ping is made to ensure that the
preload list is accurate.

Unit tests and test-fixes in a follow-up CL: For the purposes of speed
I have removed the failing test, will be re-added in the follow-up CL
along with new tests to account for this logic change.

Reland that fixes a bug in previous CL. First CL is previous CL.

TBR=engedy@chromium.org

Bug: 1042611
Change-Id: Ic70a991860d1945d0432330ca866b139371ec0d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003320
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Auto-Submit: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732381}

https://chromium.googlesource.com/catapult.git/+log/e5b0598dee84..251c76530213

git log e5b0598dee84..251c76530213 --date=short --first-parent --format='%ad %ae %s'
2020-01-16 fancl@chromium.org Fix sending alert email
2020-01-16 dberris@chromium.org Fix the deployment automation for the Dashboard

Created with:
  gclient setdep -r src/third_party/catapult@251c76530213

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC wenbinzhang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1040775,chromium:953181
Tbr: wenbinzhang@google.com
Change-Id: I9e0b5abefb447a983c4d287e7574e0890d68f657
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003819Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#732380}

TBR=rdevlin.cronin

Bug: 1042671
Change-Id: I62171a6eee538597b5ea9a61e3a62c003ae0b79f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002914Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732379}

https://chromium.googlesource.com/angle/angle.git/+log/a7b91502cd7f..0d2c75f4d56a

git log a7b91502cd7f..0d2c75f4d56a --date=short --first-parent --format='%ad %ae %s'
2020-01-16 cwallez@chromium.org DisplayGLX::isValidNativeWindow, avoid X11 exiting the program
2020-01-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src d203754bc116..3ed344dd784e (3 commits)
2020-01-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src 834baaf8b227..ab883b9d257e (5 commits)
2020-01-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src 8013d477aeac..323a81fc5e30 (3 commits)
2020-01-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 488d35ac0b1c..5fc197dc7669 (13 commits)

Created with:
  gclient setdep -r src/third_party/angle@0d2c75f4d56a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: jonahr@google.com
Change-Id: I2951cb2563cb5121eef3087c893d0915dad51979
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004492Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#732378}

[base] Update expectations in PlatformThreadWinTest.SetBackgroundThreadModeFailsInIdlePriorityProcess.

When background thread mode is enabled in an idle process on Windows 7,
::GetThreadPriority() can return any of the value accepted as NORMAL or
BACKGROUND by base::PlatformThread::GetCurrentThreadPriority().

Fixed: 931720
Bug: 931720
Change-Id: Ic05f1a8a79cabddd9407eb0cf5db2d4f31d9e004
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002755Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732377}

Moves TabOpening protocol implementation and updates tests.

Bug: None
Change-Id: Iee5608fc34d288f3196dd77438825264add0f15c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984307
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732376}

Bug: 1011392
Change-Id: I1a3871505ae836adfbc393dfbe2ab028a0159817
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000410Reviewed-by: Victor Vasiliev <vasilvv@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732375}

This also includes refactoring of ambient authentication test fixture
into a separate header file to avoid code duplication.


Bug: 458508
Change-Id: I9c770835c4222bd4900aa6b6879ca60bca66b86b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000721
Commit-Queue: Rohit Agarwal <roagarwal@chromium.org>
Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732374}

This patch removes:
 - enum blink::ContentSecurityPolicyType
 - enum blink::ContentSecurityPolicySource
 - enum blink::mojom::WebContentSecurityPolicyType
 - All the static_cast<..> from/to the three deleted enum
 - All the STATIC_ASSERT_ENUM related to the three deleted enum.

Instead, network::mojom::ContentSecurityPolicy{Type,Source} are used
everywhere and all the conversions are removed.

See UnifyCSP:
https://docs.google.com/document/d/1v5mJnXJ5dSVXE_rgvJnNM9bzH0ni0YzdhPQ7GLqyhao

Bug: 1021462
Change-Id: I7d7da0760730fd13c047a02d66fba46be2b88e70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995263
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732373}

This metric is quite useful to compute click-through-rates for the
accessory. It's needed at least until we can launch.

Bug: 1041528
Change-Id: Ia55f561adea5bb9559e75e3595124eaa54414cb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002575
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Auto-Submit: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732372}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/90815b65..849589ec

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ie7d34d52ef6d9406044001c203c6fe9990dd5e79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002638Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#732371}

https://skia.googlesource.com/skia.git/+log/2900040bc4a0..c4b8eefe5653

git log 2900040bc4a0..c4b8eefe5653 --date=short --first-parent --format='%ad %ae %s'
2020-01-16 reed@google.com move SkV3 into header

Created with:
  gclient setdep -r src/third_party/skia@c4b8eefe5653

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: mtklein@google.com
Change-Id: I4f24165d58dfaf9688f2cb820685a459a5c8097f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004497Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#732370}

Bug: chromium:916975
Change-Id: I3c4935481883c8c855bd355a36feb35c57bc219f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000940Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Toon Verwaest <verwaest@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732369}

This reverts commit c94520a9.

Reason for revert: Found bug in CL

Original change's description:
> Reversed crowd deny preload list logic
> 
> The crowd deny preload list now contains sites with a site reputation
> of UNSOLICITED_PROMPTS. If a site is not on the preload list the normal
> UI is used, otherwise a safe browsing ping is made to ensure that the
> preload list is accurate.
> 
> Unit tests and test-fixes in a follow-up CL: For the purposes of speed
> I have removed the failing test, will be re-added in the follow-up CL
> along with new tests to account for this logic change.
> 
> Bug: 1042611
> Change-Id: I35e14d9b7cd8de5191291cd113a0e50a78e91f47
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003849
> Commit-Queue: Andy Paicu <andypaicu@chromium.org>
> Reviewed-by: Balazs Engedy <engedy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#732363}

TBR=engedy@chromium.org,andypaicu@chromium.org,hkamila@chromium.org

Change-Id: I5a6c4db81cc05e4137be44f6e234b4ee6a194f72
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1042611
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002519Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732368}

This CL adds a dcheck to ensure that the impl throughput did not
mis-calculate impl frames.

Bug: 1021963
Change-Id: Id582bf9f8fafc701b1de2d4e2a76f592a6e31171
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991973
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732367}

- AutofillPopupControllerImpl::UpdateDataListValues recreates all the view in
the dropdown.
- Later AutofillPopupControllerImpl::SetSelectedLine selects a new line and
passes the index of the previous one. It may not exist.

Bug: 965025
Change-Id: Ie53b521803dcf33b02602357bda39a30b5ba0f4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995392
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732366}

This reverts commit f7a4166c.

Reason for revert: This change results in consistent test failures on Windows and Mac (https://crbug.com/1042657).

Original change's description:
> Roll src/third_party/boringssl/src cb3f04f58..98b4cdba1
> 
> https://boringssl.googlesource.com/boringssl/+log/cb3f04f584a53844546aaa32e949534c453185aa..98b4cdba1e4ede26d845bcae8185ddb5b2feea93
> 
> The following commits have update notes:
>   0df6edff4 Split BN_prime_checks into two constants for generation and validation.
> 
> Bug: none
> Change-Id: Ia16ddb85756277144fc0ea410fb2b31840bf9332
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998162
> Commit-Queue: David Benjamin <davidben@chromium.org>
> Auto-Submit: David Benjamin <davidben@chromium.org>
> Reviewed-by: Steven Valdez <svaldez@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#732261}

TBR=davidben@chromium.org,svaldez@chromium.org

Change-Id: I79ac0bbab74553526588bf2c8d5690f25bac723c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1042657
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003851Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732365}

After crrev.com/c/1789603, KeycodeConverter::DomCodeToNativeKeycode() is
used to translate back XKB hardware keycode out of DomCode. Such
function does not properly handle cases like the one described in
crbug.com/1033080, where xcape tool [1] is used in conjunction with
xmodmap to make an ordinary key act as an extra modifier.

This change fixes it by passing original XKeyEvent's keycode through
Event::Properties to GtkUi instead of trying to figure it out of Event's
DomCode value.

[1] https://github.com/alols/xcape

Bug: 1033080
Change-Id: I0878eecdb9765b50111c08242aa96220d13d9216
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003871
Commit-Queue: Nick Yamane <nickdiego@igalia.com>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732364}

The crowd deny preload list now contains sites with a site reputation
of UNSOLICITED_PROMPTS. If a site is not on the preload list the normal
UI is used, otherwise a safe browsing ping is made to ensure that the
preload list is accurate.

Unit tests and test-fixes in a follow-up CL: For the purposes of speed
I have removed the failing test, will be re-added in the follow-up CL
along with new tests to account for this logic change.

Bug: 1042611
Change-Id: I35e14d9b7cd8de5191291cd113a0e50a78e91f47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003849
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732363}