- 01 Feb, 2018 40 commits
-
-
James West authored
- The MediaPipelineBackend::AudioDecoder interface allows SetConfig() to be called before SetDelegate(), but AudioDecoderSoftwareWrapper fails a DCHECK or potentially crashes if that happens. - AudioDecoderSoftwareWrapper::SetConfig() returns true if the codec is AC-3, E-AC-3, or DTS and the underlying audio decoder does not support them, and OnDecoderError() is later called on the DecoderDelegate. Those codecs cannot be decoded in software without a license, so SetConfig() should always return false if the underlying audio decoder does not support them. Bug: internal b/62147653 Test: cast_media_internal_unittests and smoke test on Chromecast Audio Change-Id: If351cb4e6bbd7cbe35550a559f032faafa8ed1b8 Reviewed-on: https://chromium-review.googlesource.com/896975Reviewed-by:
Stephen Lanham <slan@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: James West <jameswest@chromium.org> Cr-Commit-Position: refs/heads/master@{#533581}
-
Kazuhiro Inaba authored
The info was lost during a refactoring: 7803fe02870ac7833a30d3c71b15fe0aea159db BUG=807856 TEST=manually try the migration Change-Id: I5e986b53f099ce3c7c28bbb66fabf6eb7263521d Reviewed-on: https://chromium-review.googlesource.com/897066Reviewed-by:
Satoru Takabayashi <satorux@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Kazuhiro Inaba <kinaba@chromium.org> Cr-Commit-Position: refs/heads/master@{#533580}
-
Kenneth Russell authored
Fixed the suffixes for the two active histograms (BlacklistFeatureTestResults and BlacklistFeatureTestResultsWindows) and deleted an obsolete one (BlacklistFeatureTestResultsWin). NOTRY=true TBR=isherman@chromium.org Bug: None Change-Id: Ib5e372dfdf58acc5bc08c9bb17cacd938bd88c77 Reviewed-on: https://chromium-review.googlesource.com/882552 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#533579}
-
https://webrtc.googlesource.com/src.git/+log/6ade76d69d85..98fd8e5021de $ git log 6ade76d69..98fd8e502 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Id33b1e6bc90b935f38af5ac55f819834b6d12532 Reviewed-on: https://chromium-review.googlesource.com/896549Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533578}
-
Yoshifumi Inoue authored
This patch introduces test cases for |NextWordPosition()| to record current behavior as a preparation of the patch[1]. [1] http://crrev.com/c/737981 Introduce TextOffsetMapping to simplify word/paragraph selection Bug: 778507 Change-Id: Ic98cdea94e5be2f3d13448aa9e087a02b70a0df0 Reviewed-on: https://chromium-review.googlesource.com/895236 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#533577}
-
Koji Ishii authored
As our code becomes more matured, it became clear that there are good amount of needs to traverse NGPaintFragment or NGPhysicalFramgnet for a LayoutText/LayoutInline, with the offset to the container box. This is for one that legacy FrameRect is built that way and makes adopting existing code for NG easier, but there are certain operations that operates on a DOM node or a CSS box before line fragmentations. NGPaintFragment is not supposed to be shared across frames, nor at different subtree of a frame, and has a pointer to NGPhysicalFragment. This patch creates a list of NGPaintFragment and keep it in LayoutText/LayoutInline. Some of properties of NGPaintFragment are computed in pre-paint phase, such as VisualRect(), but the NGPaintFragment tree is constructed at the end of layout phase that this list is available whenever layout is complete. Because NGPaintFragment has a pointer to NGPhysicalFragment, NGInlineFragmentTraversal can use this mechanism to find NGPhysicalFragment for a LayoutText/LayoutInline. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I84b628674436523a0ef864aae50b973e6982313e Reviewed-on: https://chromium-review.googlesource.com/888362 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#533576}
-
Jaebaek Seo authored
WebKitHitTestTest.testUnfocusedNodeAndTouchRace fails when enabling --use-zoom-for-dsf, because AwContents.AwViewMethodsImpl.onTouchEvent() passes the event position in DIPs to nativeRequestNewHitTestDataAt() method while values in physical pixels are expected. This CL lets AwContents.AwViewMethodsImpl.onTouchEvent() passes those values in physical pixels when --use-zoom-for-dsf is enabled. TEST=webview_instrumentation_test org.chromium.android_webview.test. WebKitHitTestTest#testUnfocusedNodeAndTouchRace on NEXUS 5X Bug: 737777 Change-Id: I6a51be615d646a9bc671cfad7374c1f73a69fbd3 Reviewed-on: https://chromium-review.googlesource.com/895102 Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#533575}
-
Devlin Cronin authored
According to the documentation [1], app windows should only be returned from chrome.windows functions if they belong to the calling item. This makes sense, since Chrome Apps are supposed to be entirely separate from extensions running in the browser (which is the reason, e.g., we don't run content scripts in app windows or webviews). Currently, this isn't enforced if the extension supplies a filter. Fix this so that the restriction is properly enforced in all cases, whether the caller supplies a filter or not. Note: There's a reasonable amount of complexity that should be able to be cleaned up as a result of this change, but there's also a likelihood of this being merged. With that in mind, this is a deliberately small and targeted change. A followup will perform the rest of the cleanup. [1] https://chromium.googlesource.com/chromium/src/+/5c7b0986b75f2846359a8adde0d65b0ba31c2e00/chrome/common/extensions/api/windows.json#105 Bug: 804822 Bug: 805528 Change-Id: Ibbb118a8fd6c47a4e87b86380211af5132f3add1 Reviewed-on: https://chromium-review.googlesource.com/893944Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533574}
-
Siddhartha authored
BUG=803822 Change-Id: I6d635e220a5e7a1bf0001426ac4e6c643b90b8fd Reviewed-on: https://chromium-review.googlesource.com/892466Reviewed-by:
Dmitry Skiba <dskiba@chromium.org> Commit-Queue: Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#533573}
-
Sam McNally authored
Bug: 804793 Change-Id: I5db57099fd3a0d3e348dc97a95e30af21e79d5b2 Reviewed-on: https://chromium-review.googlesource.com/892543Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#533572}
-
Yuta Kitamura authored
WebTaskRunner is being deprecated. Use SingleThreadTaskRunner instead. Some files in core/ are also updated due to a change in #include dependency. Bug: 794845 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Idd1b01cba2be5a48eb0233058dbcad7e97c4dad1 Reviewed-on: https://chromium-review.googlesource.com/895130Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#533571}
-
Siddhartha authored
When TakeHandle() is called, the SharedMemory instance resets itself and transfers ownership to the caller. In this case stop tracking the instance since Unmap() will be noop since memory will be nullptr. On Mac TakeHandle() just duplicates the handle and doesn't reset the current instance. So, still tracking this memory is ok. Note: This will change how private memory footprint is calculated since we no longer track some shared memory instances. BUG=804399 Change-Id: I28ed88bfee2033cdf07595d314505413f067e49b Reviewed-on: https://chromium-review.googlesource.com/884999 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#533570}
-
https://chromium.googlesource.com/angle/angle.git/+log/61d5325e631e..15443ebad659 $ git log 61d5325e6..15443ebad --date=short --no-merges --format='%ad %ae %s' 2018-01-31 geofflang Fix angle_gles1_conformance_tests compilation in Chromium. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I7fbc0b9b4eeb7973a3d8a4f5853c98ee23fd5f68 Reviewed-on: https://chromium-review.googlesource.com/896327 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533569}
-
Kent Tamura authored
This CL has no behavior changes. Bug: 806641 Change-Id: Ia3a49d4f1e87ee9a1d027fa700d0c62567b35bf0 Reviewed-on: https://chromium-review.googlesource.com/897062Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#533568}
-
Kenichi Ishibashi authored
The current spec says that it isn't nullable [1]. This CL also removes null check in client-navigate-worker.js. There is test coverage for null clientId in fetch-event.https.html so the explicit check here is not needed. You can find spec discussion in [2]. [1] https://github.com/w3c/ServiceWorker/commit/8b483b091e0f0bae6b698cf05d915c2029748ae0 [2] https://github.com/w3c/ServiceWorker/issues/1266 Bug: 807818 Change-Id: I5ae4f866651931fee732516377b0fa155b0b5e22 Reviewed-on: https://chromium-review.googlesource.com/892762 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#533567}
-
Chris Nardi authored
According to the shortest-serialization principle [1], values should be omitted if their omission wouldn't change the value of reparsing. As "1"/"on" is the default value for font-feature-settings, omit this when serializing, matching the behavior of Firefox. [1]: https://github.com/w3c/csswg-drafts/issues/1564 Bug: 807744 Change-Id: Ieb8b86aa66aa303a82a895c42373177cf7f13d07 Reviewed-on: https://chromium-review.googlesource.com/896203Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Chris Nardi <cnardi@chromium.org> Cr-Commit-Position: refs/heads/master@{#533566}
-
Sergey Kuznetsov authored
Change-Id: Icb9ed445fa93d0206801eac21117494672165c2a Reviewed-on: https://chromium-review.googlesource.com/895766 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
-
Robert Liao authored
This reverts commit ddb183db. Reason for revert: MSVC generates dynamic initializers for constexpr constructors with non-constexpr variables. It's not clear if the C++ spec allows for this. Original change's description: > Make LazyInstance's constructor constexpr. > > This allows hiding the buffer into private state, this will allow adding more POD > members as a follow-up. > Believe it or not, there was a user of this private state up until very recently..! > https://chromium-review.googlesource.com/c/chromium/src/+/850294 > > This also allows removing the need for the LAZY_INSTANCE_INITIALIZER > construction hack (will follow-up with a mass removal CL). > > -Wglobal-constructors (https://chromium-review.googlesource.com/c/chromium/src/+/866738) > in //base guarantees that this doesn't result in global constructors. > > Bug: 797129 > Change-Id: Id891d051180b18155f0e23c0ec55cb0f4d3018ac > Reviewed-on: https://chromium-review.googlesource.com/861426 > Commit-Queue: Gabriel Charette <gab@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#530469} TBR=dcheng@chromium.org,gab@chromium.org,fdoray@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 797129, 807491 Change-Id: I3bac97268584295fdd39563428c7f7dbe9ae8560 Reviewed-on: https://chromium-review.googlesource.com/896603Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
-
Xiaocheng Hu authored
In spellchecker code, some callbacks are created by binding unretained ptrs, which is not necessarily safe. This patch changes them to use weak ptrs instead. Bug: 807397 Change-Id: I948da2c17f6d693ebf56d82f9300854b638a8826 Reviewed-on: https://chromium-review.googlesource.com/894475Reviewed-by:
Rachel Blum <groby@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#533563}
-
https://pdfium.googlesource.com/pdfium.git/+log/66ce22c6cdb3..f5ca90c00198 $ git log 66ce22c6c..f5ca90c00 --date=short --no-merges --format='%ad %ae %s' 2018-02-01 tsepez Rename some CJS / IJS names for clarity. 2018-02-01 tsepez Test more context overlap in fxjs/fxjs_v8_embeddertest.cpp Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I0e8bbf5acb0825bc75713f078cc91a98be843158 Reviewed-on: https://chromium-review.googlesource.com/896684Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533562}
-
Yoshifumi Inoue authored
This patch changes "thai-word-at-document-end.html" to utilize |selection_test()| for ease of maintenance. This patch is a preparation for the patch[1]. [1] http://crrev.com/c/737981 Introduce TextOffsetMapping to simplify word/paragraph selection Change-Id: I14ae5eb5b991ed3e6b4d51311e27eb4bbbf9a8c0 Reviewed-on: https://chromium-review.googlesource.com/895164Reviewed-by:
-
dpapad authored
Besides cr_elements_resources.grdp and cr_components_resources.grdp there are some Polymer related files that reside in ui/webui/resources/{js,html} and are often accidentally included in iOS/Android platforms unnecessarily. Moving those to their own grdp file to exclude them as a whole (and make it more robust for future additions). Bug: None Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I32849a383c6425ea02de197e8cda9630903f1624 Reviewed-on: https://chromium-review.googlesource.com/896031Reviewed-by:Dan Beam (no longer on Chrome) <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#533560}
-
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a3d1baf265f1..a7522c8b7424 $ git log a3d1baf26..a7522c8b7 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ia70650733a02ec9028f39adc708b5162ef29fe86 Reviewed-on: https://chromium-review.googlesource.com/896608 Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533559}
-
Xiaohan Wang authored
Also remove MediaLog member in WebEncryptedMediaClientImpl since it's not needed anymore. This also fixes the memory leak of RenderMediaLog created. BUG=807723 Change-Id: Ibe6dfc23964a0890147c2108e4bb4bd387e99f04 Reviewed-on: https://chromium-review.googlesource.com/896363Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#533558}
-
Emil A Eklund authored
Change NGBoxFragmentPainter to implement correct paint order for inline, block-flow, and floating children. All paint offsets are now computed in in the appropiate paint methods, removing the need for the is_inline and block_paint_offset_ fields. Bug: 714962 Test: fast/inline, fast/inline-block, fast/block Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I04cf6cd0d7d1f675fc310b966d41ad89d42d5852 Reviewed-on: https://chromium-review.googlesource.com/874607 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#533557}
-
https://chromium.googlesource.com/catapult.git/+log/f384e378fd53..76e0bf087745 $ git log f384e378f..76e0bf087 --date=short --no-merges --format='%ad %ae %s' 2018-01-31 eakuefner [Dashboard] Don't create extra statistics rows for legacy tests/memory metrics 2018-01-31 erikchen Fix a symbolize_trace issue with new traces being emitted by OOP HP. 2018-01-30 dproy Exclude blank URLs from reporting loading metrics 2018-01-31 charliea Treat BattOr errors as nonfatal and return them through StopTracing 2018-01-29 perezju [Systrace] Simplify BaseAgentTest.GetChromeProcessID Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I1585d6b355fea7cc2966418e2cfeb8416173ead0 Reviewed-on: https://chromium-review.googlesource.com/896942 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533556}
-
Christopher Cameron authored
In this block size_dip_ = size_dip; size_pixels_ = gfx::ConvertSizeToPixel(scale_factor_, size_dip_); scale_factor_ = scale_factor; We compute the DIP size using the old scale factor. TBR=fsamuel Bug: 807576 Change-Id: Ib1b1f0496301cbd356c84ceec18b951150fe5468 Reviewed-on: https://chromium-review.googlesource.com/896968Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#533555}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=anantha@chromium.org Change-Id: I9e5841bf97321467c78e84455add5a93d8cbf7d4 Reviewed-on: https://chromium-review.googlesource.com/897182Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#533554}
-
Toni Barzic authored
Adds additional delay before views screen locker reports to PowerEventObserver it's lock animations have finished. The goal is to add more time between lock window UI being shown and device suspend (more specifically stopping compositing on the root windows), and thus prevent flash of non lock UI when showing lock screen after device resume. The issue surfaced by switching to views based lock UI - with webui based lock screen, power event observer would wait for the animations in web ui to finish before stopping the compositors, which added more time (comared to views based solution) for the frame buffers to pick up frame buffers from after lock window is shown. BUG=807511 Change-Id: Iba75c03cf8058b19bed2dc6e791200a04252b603 Reviewed-on: https://chromium-review.googlesource.com/896577 Commit-Queue: Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#533553}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d4885785b02b..539248475d66 $ git log d4885785b..539248475 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I60042ed505d2e315ee99c0c7f98d8130bc529473 Reviewed-on: https://chromium-review.googlesource.com/896828Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533552}
-
Zhiling Huang authored
Bug: 807591 Change-Id: Id3764225bcf94ad2f87b32df9ea874272dd97c5d Reviewed-on: https://chromium-review.googlesource.com/896103Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Zhiling Huang <hzl@chromium.org> Cr-Commit-Position: refs/heads/master@{#533551}
-
Zhiheng Vincent Li authored
Bug: b/72722832 Test: cast_shell_junit_tests Change-Id: Ie1f26c346f7b5c0b95771c091f429b63bc6a49e2 Reviewed-on: https://chromium-review.googlesource.com/896374Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#533550}
-
Yoshifumi Inoue authored
This patch changes "skip-over-contenteditable.html" to utilize |selection_test()| for ease of maintenance. This patch is a preparation for the patch[1]. [1] http://crrev.com/c/737981 Introduce TextOffsetMapping to simplify word/paragraph selection Change-Id: I78798539a928a7319e439b8947bef7fd89fe695a Reviewed-on: https://chromium-review.googlesource.com/895342Reviewed-by:
-
Koji Ishii authored
Following bot results are included. 3420 3423 3424 3426 3428 3434 3438 5 lines were removed and 29 lines were deflaked by consecutive results since 3372. TBR=eae@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I5eb50fe97c29ec71ead2860fc3a47e24cb49417e Reviewed-on: https://chromium-review.googlesource.com/895166 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Takuto Ikuta authored
This is mainly for proguard steps which make build slow due to restricted parallelism on android_n5x_swarming_rel builder. Example build traces from slow builds: https://chromium-build-stats.appspot.com/ninja_log/2018/01/31/slave954-c4/ninja_log.slave954-c4.chrome-bot.20180131-023634.24049.gz/trace.html from https://ci.chromium.org/buildbot/tryserver.chromium.android/android_n5x_swarming_rel/351638 https://chromium-build-stats.appspot.com/ninja_log/2018/01/31/slave617-c4/ninja_log.slave617-c4.chrome-bot.20180131-021253.3583.gz/trace.html from https://ci.chromium.org/buildbot/tryserver.chromium.android/android_n5x_swarming_rel/351634 https://chromium-build-stats.appspot.com/ninja_log/2018/01/31/slave980-c4/ninja_log.slave980-c4.chrome-bot.20180131-021148.4142.gz/trace.html from https://ci.chromium.org/buildbot/tryserver.chromium.android/android_n5x_swarming_rel/351629 I investigate peak memory usage of some large/long time targets with args.gn of android_n5x_swarming_rel. |--------------------------------------------------------+-------------| | target | peak memory | |--------------------------------------------------------+-------------| | chrome_public_apk.proguard.jar | 843076 KB | | chrome_public_test_apk__apk.proguard.jar | 995208 KB | | chrome/android/monochrome_public_apk/classes.dex | 1178664 KB | | lib.unstripped/lib_unit_tests__library.so | 3181252 KB | | android_clang_arm/lib.unstripped/libmonochrome.so | 2718856 KB | | android_clang_arm/lib.unstripped/libwebviewchromium.so | 2362328 KB | |--------------------------------------------------------+-------------| So 4GB is sufficient. I tested the builder by modifing base_export.h to run linker for many targets in https://chromium-review.googlesource.com/c/894928/4 Bug: 804251 Change-Id: Ic5f985dba29d063a7541553813561f85c9dd3278 Reviewed-on: https://chromium-review.googlesource.com/894928 Commit-Queue: Takuto Ikuta <tikuta@google.com> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#533547}
-
Takuto Ikuta authored
This makes link time faster on the bots. Bug: 807660 Change-Id: Id4ae4a533971e53d5b095cec9bc73a5c273129af Reviewed-on: https://chromium-review.googlesource.com/895426Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Daniel Bratell <bratell@opera.com> Reviewed-by:
-
Trent Apted authored
This reverts commit cd5b76ea. Reason for revert: Suspected for persistent failures on linux-chromeos-rel. 4 cycles starting: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/4806 PrerenderBrowserTest.PrerenderWindowSize fails with ../../chrome/browser/prerender/prerender_browsertest.cc:1084: Failure Value of: DidDisplayPass(web_contents) Actual: false Expected: true (under NavigateToURLImpl(..)) Original change's description: > Allow navigations to opener's site to go back into opener SiteInstance. > > Previously, when a popup and its opener were cross-site, and neither > site required a dedicated process, navigating the popup back to the > opener's site did not swap processes, so the two ended up in different > processes and couldn't script each other. Even though > DetermineSiteInstanceForURL contains logic to place same-site popups > into their opener's SiteInstance (added as part of the fix for a > similar issue 796912), this logic was never reached because we never > attempted a process transfer in this case, thanks to > IsRendererTransferNeededForNavigation() returning false. > > This CL tweaks IsRendererTransferNeededForNavigation so that a > cross-process transfer is always attempted is such cases. This allows > DetermineSiteInstanceForURL to always place the popup that's going back > to its opener site into the opener's SiteInstance. > > Bug: 807184 > Change-Id: Ia4d8d8b2107d3b9e3b9329dd473c06d49b7bd5ec > Reviewed-on: https://chromium-review.googlesource.com/894369 > Reviewed-by: Charlie Reis <creis@chromium.org> > Commit-Queue: Alex Moshchuk <alexmos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533410} TBR=creis@chromium.org,alexmos@chromium.org Change-Id: Iabdd81f6a5dc75795985074684e6be77c462a398 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 807184 Reviewed-on: https://chromium-review.googlesource.com/896663Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#533545}
-
Hayato Ito authored
GetDistributedNodes() doesn't consider Incremental Shadow DOM. Let's replace it with FlattendAssignedNodes, which is aware of Incremental Shadow DOM. BUG: 776656 Change-Id: Ie2730816552e7ea81289a9d44cb8f12f88a8adc9 Reviewed-on: https://chromium-review.googlesource.com/892604 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Cr-Commit-Position: refs/heads/master@{#533544}
-
John Williams authored
This CL adds the media router git repository to the top-level DEPS file and adds supporting files that allow the code to be built as part of the main build process. The version of the media router that can be built from the Chromium tree is crippled because it contains to media route providers. Things coming in future CLs: - Nontrivial media route providers. - Execution of unit tests. - Incorporating the built extension into released build artifacts. - Integration with Chromium waterfall. Bug: 698796 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If5b4a02dfe27f618fd34e586bd8be07833b30d23 Reviewed-on: https://chromium-review.googlesource.com/783555 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#533543}
-
liberato@chromium.org authored
Previously, there were many instances of using RequestQuit as a quit closure for ServiceContextRefFactory. However, it's possible for the last ServiceContextRef(Impl) to be destroyed as part of ServiceContext teardown. This causes a closure to call back into a half-destructed ServiceContext. This CL exposes a method to get a weakly-bound RequestQuit closure, and updates all quit closures to use it. Bug: 806632 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I7551e74db5d7f1d85d946b611d0bcf6599503673 Reviewed-on: https://chromium-review.googlesource.com/894500Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#533542}
-
