- 13 Jul, 2018 40 commits
-
-
Jérôme Lebel authored
Adding chevron with animation to collapse and expand the 2 sections in the Sync and Google services settings. To support collapsable section, SettingsCollapsibleItem and SettingsCollapsibleCell classes are added. Screenshot: https://drive.google.com/open?id=1Q82j3xiB7ZYihyyCiS_xalh2AFcCzKTs Mocks: https://docs.google.com/presentation/d/1cZfr5FGWGSy0PNaQ8uzik0alLAH-5glh1vsb030vha8/edit?ts=5aba5455#slide=id.g3ae6bac383_31_43 Bug: 827072 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9f75fa1105faaf5e81133a1250a800aa5bfa2136 Reviewed-on: https://chromium-review.googlesource.com/1128758 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#574892}
-
Mihai Sardarescu authored
This CL makes sure that the email is filled on the Chrome sign-in page for all Chrome sign-in flows started from extensions. Bug: 856513 Change-Id: If90c80971bd2c95c5e44707fe166ea9228f12fed Reviewed-on: https://chromium-review.googlesource.com/1124696Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#574891}
-
Jochen Eisinger authored
The next step will be to figure out how to get back to the initiating WebContents, dump the redirect chain into a LoadURLParams struct, and continue the download as navigation. BUG=831073 R=qinmin@chromium.org,dtrainor@chromium.org Change-Id: I28c55fdc9982433b684184b234f8f503c46facc5 Reviewed-on: https://chromium-review.googlesource.com/1135307Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#574890}
-
Allen Bauer authored
Inactive tab hit-testing overlap regions is now calculated to be 1 dip above the top of the tab separator. Bug: 859204 Change-Id: Idbd92f9209ff2bbcd5516f26d1acfbd0b83ae563 Reviewed-on: https://chromium-review.googlesource.com/1135726Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#574889}
-
David 'Digit' Turner authored
This is done by adding a new |enable_language_splits| variable to the android_app_bundle GN template. Note that splitting by screen_density or ABI currently doesn't make sense for Chromium, but could be added in the future. Only the chrome_public_bundle target uses language-based splits in this CL. BUG=846633,820459 R=agrieve@chromium.org, yfriedman@chromium.org TBR=twellington@chromium.org,tedchoc@chromium.org Change-Id: Ic89f9dd4b8c78e8b2127bb19208db18bc8027eab Reviewed-on: https://chromium-review.googlesource.com/1125934 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#574888}
-
Daniel Cheng authored
exception_messages.* triggers the pattern match for the IPC owner presubmit, but it isn't actually an IPC-related file. Bug: 863161 Change-Id: Ia5655c49c991bcab308dca36bd41c4afc574f941 Reviewed-on: https://chromium-review.googlesource.com/1136063 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#574887}
-
Ned Nguyen authored
Bug: 771597 Change-Id: I432d1f2d39745f311c4aba259bce8d1a080e48ba Reviewed-on: https://chromium-review.googlesource.com/1136431Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#574886}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6234bd45..47b0a995 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iac4af3529c4772ca388c44c6410cd12f7cd7b071 Reviewed-on: https://chromium-review.googlesource.com/1136229Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574885}
-
Shik Chen authored
Some devices like VM or chromeboxes do not have built-in camera at all, we should not treat it as an error. BUG=b:77833131,b:64996728,chromium:832816,chromium:852302 TEST=external camera works on teemo (a chromebox) Change-Id: I2a19afa72ab9e0828f4c65a7761cd2b54d1ecfdd Reviewed-on: https://chromium-review.googlesource.com/1136451Reviewed-by:
Ricky Liang <jcliang@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#574884}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/27998f763495..74aa8cb5bd4e git log 27998f763495..74aa8cb5bd4e --date=short --no-merges --format='%ad %ae %s' 2018-07-13 dats@google.com drivefs: Add chronos to fuse-drivefs group Created with: gclient setdep -r src/third_party/chromite@74aa8cb5bd4e The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I6fb262d242f1435ee66abb20fee5c96cf2f0fa9a Reviewed-on: https://chromium-review.googlesource.com/1135357Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574883}
-
Adam Rice authored
When the WebSocketHandshakeReuseConnection feature was enabled, "Keep-Alive" would be included in the Connection header. This behaviour was copied from Firefox, however it is non-standard. Microsoft Edge does not include "Keep-Alive" in the Connection header, and Windows authentication works with WebSockets in Microsoft Edge. So it is unlikely any server depeneds on the presence of "Keep-Alive". Stop including "Keep-Alive" in the Connection header when WebSocketHandshakeReuseConnection is enabled. BUG=423609 Change-Id: Icaf232872c25b13951c7b22ac8d7f375eeadc9ff Reviewed-on: https://chromium-review.googlesource.com/1131354Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#574882}
-
Roman Sorokin authored
Fields set in the streamline configuration should not be modifable by user. BUG=chromium:857452 TEST=manual, I'm going to add tests checking this into CL:1131497 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I2835df9dd6b0bd68660302c634747fa216a53b8b Reviewed-on: https://chromium-review.googlesource.com/1134782 Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#574881}
-
Gauthier Ambard authored
This CL adds an animation for the TabGrid button in the toolbar. The button has an animation when the tab count is changing. It also rotates if a tab is added in background, to match the new animation. Bug: 843576 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia26e5a89db0ac0baeba0fc5d6ec57b58ff6fe30f Reviewed-on: https://chromium-review.googlesource.com/1131455 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#574880}
-
Vasilii Sukhanov authored
The masked password is displayed for non-PSL and non-Android credentials now. Later when the drop-down supports a bottom label, it'll be shown for all. Bug: 851021 Change-Id: I491e7c24a58311c1250e8e89cddb9ccae95a9296 Reviewed-on: https://chromium-review.googlesource.com/1135325Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#574879}
-
Gauthier Ambard authored
This CL adds the animation triggered when opening a new tab in background. Bug: 843576 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I243e375139f6e5c58e164ef43785db277604a4a4 Reviewed-on: https://chromium-review.googlesource.com/1131191 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#574878}
-
Kent Tamura authored
We'd like to make DOMNodeRemoved and DOMNodeRemovedFromDocument events asynchronous. This CL adds some UseCounters to investigate its impact. * kDOMNodeRemoved*EventDelayed: We already dispatch the events asynchronously in some cases. This counts them. * kDOMNodeRemoved*EventHandlerAccessDetachingNode: Count cases where - Accessing parentNode of to-be-removed Node - getElementById() for to-be-removed Node or its descendants - NodeList/HTMLCollection/querySelector*() for to-be-removed Node or its descendants in DONNodeRemoved* event handler. If we change the timing, we'll have incompatibility in such cases. This doesn't have a perfect coverage. For example, sibling access from a sibling of to-be-removed node is not counted. * kDOMNodeRemoved*EventListenedAtNonTarget: Count if the events are listened at non-target nodes. If we change the timing, bubbling/capturing won't work well. This CL has no behavior changes except UseCounters. If benchmarks regress a little, we won't revert this CL soon, and will revert after a branch point. If benchmarks regress very much, we'll revert this CL. Test infrastructure: * Add internals.clearUseCounter() so that we can test a UseCounter multiple times in a single test. Bug: 859391 Change-Id: Iefaa324217a3e914c7f095165aba513b847b328f Reviewed-on: https://chromium-review.googlesource.com/1134640 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#574877}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 115ba705. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21195 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mlamouri@chromium.org: external/wpt/remote-playback yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch TBR=robertma No-Export: true Change-Id: I4a6c5ebbff768dda66cf112598def030eee37936 Reviewed-on: https://chromium-review.googlesource.com/1136223 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#574876}
-
Aaron Leventhal authored
NVDA is announcing live region text changes multiple times. Only fire one type of live region event at a time. - Name from attribute change (e.g. from alt, aria-label, aria-labelledby, etc.): fire only a name change event. - Text contents change: fire only text removed/inserted events. Bug: 778478 Change-Id: I7dd17217826fe2ba18bd2c921839bcf19f7d63cf Reviewed-on: https://chromium-review.googlesource.com/1134021 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#574875}
-
Sergei Datsenko authored
Drivefs plumbing requires frequent changes here. Change-Id: Ic3b2b692c5166eaa40fa2df61ca277844f62dcaa Reviewed-on: https://chromium-review.googlesource.com/1136164 Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#574874}
-
Maxim Kolosovskiy authored
If chrome://flags/#enable-show-autofill-signatures is enabled, Chrome annotate forms and fields with its signatures. Before this CL, Chrome didn't show form signature for formless (i.e. <form> tag) forms. From this CL, Chrome annotates every field with its field signature and (!) form signature. Examples: <form form_signature="12345"> <input field_signature="7" form_signature="12345" > <input field_signature="8" form_signature="12345" > </form> <div> <input field_signature="1" form_signature="54321" > <input field_signature="2" form_signature="54321" > </div> Bug: 824793 Change-Id: Id5084e616689a9ddae0cccfa345a47f13cc2ab32 Reviewed-on: https://chromium-review.googlesource.com/1134787 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#574873}
-
Alexandr Ilin authored
This CL replaces the deprecated base::SharedMemory in gpu::SharedMemoryBufferBacking with the base::UnsafeSharedMemoryRegion. This involves cascading changes in many other files including the change of parameters in GpuChannelMsg_CreateCommandBuffer and GpuCommandBufferMsg_RegisterTransferBuffer ipc messages. Bug: 861844 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7c7afecd9fbf6d268ed72233f2e85a6f2d93da51 Reviewed-on: https://chromium-review.googlesource.com/1127948 Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#574872}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9cdbf1942de5..ebd37e2af478 git log 9cdbf1942de5..ebd37e2af478 --date=short --no-merges --format='%ad %ae %s' 2018-07-13 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 1617e69e3883..523c5e3122ed (1 commits) 2018-07-13 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files 2018-07-13 herb@google.com Introduce text blob processing but don't wire it up 2018-07-13 senorblanco@chromium.org GrTessellator: missing intersection rewind fix. Created with: gclient setdep -r src/third_party/skia@ebd37e2af478 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:860453 TBR=robertphillips@chromium.org Change-Id: I7a9b09b5ea246091a518875be4fe8024db9a196b Reviewed-on: https://chromium-review.googlesource.com/1135355Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574871}
-
Mike West authored
This reverts commit 49040ae7. Reason for revert: Findit (https://goo.gl/kROfz5) identified this CL at revision 574621 as the culprit for introducing flakiness in the tests as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNDkwNDBhZTc5NTU5MmQzYjBjNmE1YjAzNTMzNTY1Y2FlYjlhZTI2Ngw Original change's description: > Changed committed-interstitials flag from switch to feature. > > Removed 'committed-interstitials' switch and added SSLCommittedInterstitials > base::Feature. Name was changed to SSLCommmittedInterstitials since we are now > doing separate rampups for each kind of committed interstitial. Switch was > changed to Feature so that it can be enabled via variations. > > Bug: 755632 > Change-Id: I0f3e0e01a94be2b515aa596827cd447d14c24b56 > Reviewed-on: https://chromium-review.googlesource.com/1118975 > Commit-Queue: Carlos IL <carlosil@chromium.org> > Reviewed-by: Jialiu Lin <jialiul@chromium.org> > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Reviewed-by: Emily Stark <estark@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Cr-Commit-Position: refs/heads/master@{#574621} TBR=emaxx@chromium.org,estark@chromium.org,ortuno@chromium.org,jialiul@chromium.org,carlosil@chromium.org Change-Id: If9f9b15c8e3654dbd011104dfa469943bcd66e0c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 755632, 863272 Reviewed-on: https://chromium-review.googlesource.com/1136351Reviewed-by:
-
Marina Ciocea authored
Add sandboxing for audio service process, in preparation for moving APM to audio service[1]. Audio process privilege requirements: - Lockdown level of USER_LIMITED - Delayed integrity level of INTEGRITY_LEVEL_LOW For audio streams to create shared memory regions (using CreateFileMapping()), both settings are needed. [1] APM design doc: http://doc/1HJnii4kuBXshVM202TVPJt_9iDmlaCX-VhatjRxRbC4#heading=h.hv3b16z7nhgt Audio service Windows Sandboxing design draft: http://doc/15rT2e5tzfPBCwmdQjnC49lxIgjrSzbCDZbLxU9QxeT0#heading=h.xgjl2srtytjt Bug: 850878 Change-Id: I9b615e58f23ffee89bc41ab921a5878eed1b4b17 Reviewed-on: https://chromium-review.googlesource.com/1128888 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Penny MacNeil <pennymac@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#574869}
-
Yutaka Hirano authored
From what I heard wrapper tracing has been fully enabled for a while. Update a comment in trace_wrapper_v8_reference.h accordingly. Bug: None Change-Id: Ib6a9d89002fcf26dc7088a971df3b66ac5f2606c Reviewed-on: https://chromium-review.googlesource.com/1136258Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#574868}
-
Eric Noyau authored
Bug: None Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: If151d8de6e0a3e0f9aaec878f4b123909bbb7752 Reviewed-on: https://chromium-review.googlesource.com/1107804 Commit-Queue: Eric Noyau <noyau@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#574867}
-
Yuichiro Hanada authored
crrev.com/c/1112967 adds a check that sending key events is native or not and synthetic key events were not sent to exo clients after the CL. The check was introduced to make sure key press event and key release event always have the same key code. It's needed for Crostini apps tracking pressed key sets by observing key press/release events. However, after the CL, all synthetic events (for example, the back button on the shelf or keyboard navigation when ChromeVox is enabled) were not sent to ARC++ apps anymore. This CL is a quick hack for fixing this problem on ARC++ apps. We have to find a cleaner way to fix all problems later. Bug: 859071, 859797, 847500, 859797, 862140 Test: Confirmed the back button on the shelf works on ARC++ apps. Change-Id: Ia1da441cca8bc43687327b69cccf16fb8692046b Reviewed-on: https://chromium-review.googlesource.com/1133102 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#574866}
-
Colin Blundell authored
This CL ports ProfileIdentityProvider to talk to IdentityManager rather than SigninManager and ProfileOAuth2TokenService. The conversion is straightforward after a long line of preparatory work. Bug: 809452 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ifa638f1b7a9c77089bb87fd7215e60041c762d3a Reviewed-on: https://chromium-review.googlesource.com/1118163 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#574865}
-
Luciano Pacheco authored
Changed util.isDescendantEntry to proper check if the children entry is the same entry and addition to checking volumeEntry. This fixes the issue where DirectoryTree wasn't immediately marking crostini FakeItem as selected. Changed NavigationListModel to remove crostini FakeEntry from My Files if crostini becomes disabled, this fixes testCrostiniNotEnabled. Removed containEntry method since it isn't needed anymore. Bug: 862897 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ia499266637c3d4c30677ac91ce30b6bd46b0ad99 Reviewed-on: https://chromium-review.googlesource.com/1136260 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#574864}
-
Kinuko Yasuda authored
We haven't gotten the breakage reports for these types, but from what we've observed this could also be a source of breakage, and we want to be conservative not to break things before enabling this more broadly. Bug: 837771 Change-Id: I913e29a9bb0f77dd6cf61f8e4523e89e6d194222 Reviewed-on: https://chromium-review.googlesource.com/1136170Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#574863}
-
Khushal authored
Currently each decoder has its own cache which means each decoder could potentially keep the budget's maximum capacity allocated at any time. This is particularly bad because the GPU process has no notion of which decoder belongs to a background renderer, so the memory is not released even if the renderer is invisible. R=ericrk@chromium.org Bug: 859635 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I9aa709b860270f94ca83bb096deb74e5f6de0ff6 Reviewed-on: https://chromium-review.googlesource.com/1132330 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#574862}
-
Eric Karl authored
Changes in Skia require that Chrome explicitly specify whether an SkImage needs mips. With this change, we now request mips in two places - at image upload time, if needed immediately, or at image use time, if we need to add them to an existing upload. As mips use additional space and aren't needed for exactly-sized images, we try to avoid adding them unless necessary. To simplify handling, we abstract texture upload, colorspace conversion, and mip generation behind a new MakeTextureImage function. This function provides similar functionality to Skia's SkImage::makeTextureImage, but works around colorspace limitations (Skia's fn ignores colorspaces for now). Bug: 834837 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ib616c79c800f1b2f32011c225d6e5a6eff00c36c Reviewed-on: https://chromium-review.googlesource.com/1125304 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#574861}
-
Sergey Silkin authored
Bug: webrtc:9518 Change-Id: I527256e74bccd3daac3cd30bfbbd5b2977df0c74 Reviewed-on: https://chromium-review.googlesource.com/1134784 Commit-Queue: Sergey Silkin <ssilkin@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#574860}
-
Maja Kabus authored
Previous version of function made private and named createContextualFragmentFromString. createContextualFragment wraps createContextualFragmentFromString. Bug: 739170 Change-Id: I240f95d1a96e9022bed8fdaf3ec7a954ec9512c6 Reviewed-on: https://chromium-review.googlesource.com/1131188 Commit-Queue: Maja Kabus <kabusm@google.com> Reviewed-by:
-
Anders Hartvoll Ruud authored
How registered custom properties are reified is currently not specified [1]. For computed values, it should hopefully be pretty obvious how it should work. (For declared/inline style it is less clear). This patch adds tests for the computed style only. Note: * <transform-function> is not tested, because it appears that this syntax was re-added to the spec by mistake, so I expect support for <transform-function> will be reverted. * <transform-list> and list syntaxes in general are not tested, because it's currently broken in Blink. Tests for list syntaxes will be added along with the fix for that. [1] https://drafts.css-houdini.org/css-typed-om-1/#reify-stylevalue R=chrishtr@chromium.org Bug: 641877 Change-Id: Ic177bfe2b90897ec44ef4405c745171d8b226e82 Reviewed-on: https://chromium-review.googlesource.com/1134778Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#574858}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8495de1eb482..754b096de220 git log 8495de1eb482..754b096de220 --date=short --no-merges --format='%ad %ae %s' 2018-07-13 sabbakumov@yandex-team.ru Catch psutil.NoSuchProcess when iterating over processes Created with: gclient setdep -r src/third_party/catapult@754b096de220 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ie29632a9121d554ebc79a7a09b99860b853efd17 Reviewed-on: https://chromium-review.googlesource.com/1135354Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574857}
-
Adam Rice authored
With the WebSocketHandshakeReuseConnection feature enabled, WebSocket connections can be reused for auth. However, they can also be returned to the pool after other kinds of response. A WebSocket connection should not be reused if the handshake has failed, so explicitly close the connection on handshake failures. BUG=423609 Change-Id: If02924395cff1c36b1a172ded26df31840f1358c Reviewed-on: https://chromium-review.googlesource.com/1127079 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
-
Philipp Hancke authored
removes most usage of generateMediaStreamTrack in favor of await-ing tracks from getUserMedia and stopping them) BUG=836871 Change-Id: Id84f6cb6b3537faf2bb83332c5d7993550246581 Reviewed-on: https://chromium-review.googlesource.com/1117069Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#574855}
-
Dominik Röttsches authored
font_service was initially set up for Mandoline sandboxing html_viewer, compare https://crbug.com/492524 but since Mandoline has been deprecated, I do not see any use for this out of process service in mash/ash context anymore. The font_service itself has been upgraded to perform more FontConfig tasks and is run inside a utility process at the moment, but only from a Chrome browser context. Disable it here, as a preparation for moving the newly extended font_service to be run in-process. Bug: 492524 Change-Id: Id731ae4b4ed12403b293b9548f0af4a4b18c3802 Reviewed-on: https://chromium-review.googlesource.com/1135544Reviewed-by:
-
Antoine Labour authored
GetRasterDecoderContextState doesn't need to be in charge of validating GPUCreateCommandBufferConfig's attribs, it is simpler to do it in RasterCommandBufferStub::Initialize. Also for passthrough, don't force configuration needed for command buffer validation, as untrusted data isn't passed to the context directly, and allow ES3 contexts like on non-passthrough. Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I2d46dcb966eba60dc6f03faf24ef92dcffef773d Reviewed-on: https://chromium-review.googlesource.com/1134478Reviewed-by:
-
