GitLab

CommandBufferTaskExecutor needs to be created and destroyed on the GPU
thread. To ensure it's destroyed on the GPU thread we hold onto a
scoped_refptr there and destroy it last. Owning the object there and
passing around a raw pointer accomplishes the same thing with less
complexity.

Bug: none
Change-Id: I7c2d4f22044d28799c04144729c03d273abe7592
Reviewed-on: https://chromium-review.googlesource.com/c/1340907Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609557}

Cleans up manual usage of EmbeddedTestServer in XR tests, which was both
adding a lot of duplicate code and had the potential to fail to clean up
the server if the test failed, which could then affect other tests.

This is achieved by making EmbeddedTestServerRule lazy and applying it
to all ChromeActivityTestRules, not just WebappActivityTestRule.

Bug: 901923
Change-Id: I431dac3ce2488a1a5762a1ab1f5ec68aea16c9f5
Reviewed-on: https://chromium-review.googlesource.com/c/1320024
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609556}

This flag allows for controlling whether user-supplied filesystems in
CrOS are mounted with the 'nosymfollow' option that will cause symlink
traversal to be blocked. Will be configurable through VariationsService
as well as chrome://flags.

This needs CL:1338199 to land and then a deps roll to happen before
this can land.

"sudo -u chronos dbus-send --system --type=method_call --print-reply \
--dest=org.chromium.ChromeFeaturesService \
/org/chromium/ChromeFeaturesService \
"org.chromium.ChromeFeaturesServiceInterface.IsFsNosymfollowEnabled"

Bug: 867807
Test: look at chrome://flags as well as:
Change-Id: Iffd13ebf95a2d1bb12541a8c910aa0bba18ef79f
Reviewed-on: https://chromium-review.googlesource.com/c/1338173Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Micah Morton <mortonm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609555}

Bug: 869677
Change-Id: I2ec34190049473f512b30a8bc18f311ec92388e1
Reviewed-on: https://chromium-review.googlesource.com/c/1343049Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609554}

BUG=None
TEST=No code change

Change-Id: I1627f25269b4eeac33d78674a515aeeab028a124
Reviewed-on: https://chromium-review.googlesource.com/c/1343069Reviewed-by: Elijah Taylor <elijahtaylor@chromium.org>
Commit-Queue: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609553}

Currently we cache all the DownloadDBEntry when loading in-progress downloads.
However, this is not necessary and it wastes a lot of memory.
This CL no longer caches those entries, and will only cache them later
when OnDownloadUpdated() is called on an in-progress download.

BUG=893651

Change-Id: Id5c64f0efe6769446803d2b3ac4b58168917a27d
Reviewed-on: https://chromium-review.googlesource.com/c/1340950
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609552}

The original CL is crrev.com/c/1291289. It was reverted due to crash.
Please see crbug.com/903671.

We changed IsInArcAppWindow() to use the window property,
aura::client::kAppType, but it's not set for ARC++ Kiosk apps' window.
It makes text input on ARC++ Kiosk apps stop working.
This CL adds a temporary workaround for this situation. Ideally,
IsArcAppWindow() in arc_util.cc should handle windows of ARC++ Kiosk app
correctly.

Bug: 891825, 903671
Test: Can type text on Wikipedia kiosk app.
Change-Id: I3e6457ee3dc5f3fdcca35a7acbb007325697ddbd
Reviewed-on: https://chromium-review.googlesource.com/c/1339779Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609551}

After the client/service paint cache entries were added, these tests
started failing.  Fix this by clearing the client paint cache on every
iteration so that each op has to always serialize cached subtypes.

Change-Id: I7dfae5b5ae34864f77ae1fb28793b1ab2db94c86
Reviewed-on: https://chromium-review.googlesource.com/c/1343502Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609550}

This is a reland of 8fcafe0e

Wait for the file list to update before attempting to select its
contents.

Original change's description:
> Add tests for sharing and managing items in team drives.
>
> Bug: 903637
> Change-Id: Ic9f49f7de59210e400a578060eb611fafebe193f
> Reviewed-on: https://chromium-review.googlesource.com/c/1341287
> Commit-Queue: Sam McNally <sammc@chromium.org>
> Reviewed-by: Noel Gordon <noel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#609191}

Bug: 903637, 906577
Change-Id: Id6e2a1ab4eb4b0afb48c53c5cb6ea0e3b28bfa11
Reviewed-on: https://chromium-review.googlesource.com/c/1343399Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609549}

Bug: 797709
Change-Id: I7d0be2bd48d0ff5fd5288f1abd23657f5a77a7fe
Reviewed-on: https://chromium-review.googlesource.com/c/1341769
Commit-Queue: Sam McNally <sammc@chromium.org>
Reviewed-by: Sergei Datsenko <dats@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609548}

Fixed the cleanup functions to return a Promise and use explicit domains to make sure the cookies are cleaned up afterwards.

Bug: 729800
Change-Id: Iba3ca150431e21be26536658d3b5d77648edfe83
Reviewed-on: https://chromium-review.googlesource.com/c/1226199
Commit-Queue: Jarryd Goodman <jarrydg@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609547}

This is necessary because of recent Blink changes at r608013.

Bug: 905999
Change-Id: I111e3631e4d832afb48a4161552fc27a1bbb9630
Reviewed-on: https://chromium-review.googlesource.com/c/1343197Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609546}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ae6836ecee57..7da982abf99f


git log ae6836ecee57..7da982abf99f --date=short --no-merges --format='%ad %ae %s'
2018-11-19 efoo@chromium.org Update to use new LUCI builders


Created with:
  gclient setdep -r src/third_party/depot_tools@7da982abf99f

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:868202
TBR=agable@chromium.org

Change-Id: Ibf7a764150fdd25102bd318d37727901ffdceadc
Reviewed-on: https://chromium-review.googlesource.com/c/1343183Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#609545}

Bug: 870331, 905289
Change-Id: I4c5decd8b299d64d2b6c302bcd0049f8f9581f48
Reviewed-on: https://chromium-review.googlesource.com/c/1343258
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609544}

Bug: 755632
Change-Id: I7e156e2df3a3124a13a5b576b7d691d77dd9c08b
Reviewed-on: https://chromium-review.googlesource.com/c/1289687
Commit-Queue: Carlos IL <carlosil@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Doug Turner <dougt@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609543}

TBR=sullivan@chromium.org

Bug: 906656
Change-Id: I6eb1c8604b8dc6307fde4df09bfbe7c2918aeb8a
Reviewed-on: https://chromium-review.googlesource.com/c/1343062Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609542}

Change-Id: I5a5f176793365ee972b0a857531df9daef99ec03
Reviewed-on: https://chromium-review.googlesource.com/c/1343523
Commit-Queue: Xi Cheng <chengx@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609541}

Bug: 640835
Change-Id: I4aa79b8af48f7dfd63c288dc7c4506fa4a4bf73e
Reviewed-on: https://chromium-review.googlesource.com/c/1338999Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Adrienne Porter Felt <felt@chromium.org>
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609540}

When Crostini users invoke x-terminal-emulator $CMD, the contents of CMD
are eventually passed by CrostiniManager in an args[] array to crosh as part
of its URL.

Fixed in this CL: incorrect usage of vector<StringPiece>.
We were adding more pieces in line 1065 which were derived from temporaries
(return values of net::Escape...). The temporaries were thrown away but the
pieces still pointed to the same memory and we sent nonsense to
base::JoinString().

Bug: 898111
Change-Id: If5d3ffcb6ab28d01698ee48cd7fd3d2230381f95
Reviewed-on: https://chromium-review.googlesource.com/c/1341282
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609539}

WebglConformance_conformance2_rendering_canvas_resizing_with_pbo_bound is failing on
Linux Nvidia FYI release. Suppress this test.

BUG=906846
TBR=kbr@chromium.org

Change-Id: I4d93b16a54df7c247ce90022804fea36fc9408d4
Reviewed-on: https://chromium-review.googlesource.com/c/1343373Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609538}

https://webrtc.googlesource.com/src.git/+log/2e0c655bc6c5..b6787bcd79f8


git log 2e0c655bc6c5..b6787bcd79f8 --date=short --no-merges --format='%ad %ae %s'
2018-11-19 srte@webrtc.org Using data unit classes in DelayBasedBwe.


Created with:
  gclient setdep -r src/third_party/webrtc@b6787bcd79f8

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I337fe422ded952e3d233920072008c556733494a
Reviewed-on: https://chromium-review.googlesource.com/c/1343182Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#609537}

In crrev.com/c/1256016, we moved FidoAuthenticator instantiation and
ownership into the respective FidoDiscovery subclasses. This also
eliminated FidoRequestHandlerBase::CreateAuthenticatorFromDevice() which
was where we previously wrapped a discovered FidoDevice in a
FidoDeviceAuthenticator before adding it to the request handler.

In fido_request_handler_unittest, this was used as a testing seam to
inject a FakeFidoAuthenticator implementation. Injection of the fake was
dropped, but the "real" FidoDeviceAuthenticator was still casted into a
pointer to the fake elsewhere. While this seems to not bother compilers
too much, it's probably a Bad Idea. This CL therefore entirely removes
the FakeFidoAuthenticator class (without changing semantics of the
fixture or the tests).

Bug: 903294
Change-Id: I7a6bad330b1152dc455ded5b6db3d3309f4eb3be
Reviewed-on: https://chromium-review.googlesource.com/c/1340903Reviewed-by: Jun Choi <hongjunchoi@chromium.org>
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609536}

Bug: 903972
Change-Id: Iba29af4d63e0e8dc68c728d0965e22c11bed8653
Reviewed-on: https://chromium-review.googlesource.com/c/1343354Reviewed-by: Mike Wittman <wittman@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609535}

Bug: 835717, 880027
Change-Id: I074ea4b911132477853bf95be70a36b7d62c4f79
Reviewed-on: https://chromium-review.googlesource.com/c/1330903Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609534}

The model's visibility property starts off as false even though the
browsing mode bottom toolbar is visible initially. Also looks like we
had a bug in the view binder where visibility did the opposite of
what we wanted it to. Not sure how anything worked without this fix...

Bug: 905551
Change-Id: I6737aa480563f5c19d3938486b575dbd5841a184
Reviewed-on: https://chromium-review.googlesource.com/c/1341143Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609533}

For chromad kerberos users, we do not resolve mount paths and instead
rely on the domain controller to resolve it. This CL fixes a bug where
windows URIs were not converted to the cannoncial smb:// format that is
expected by libsmbclient resulting in an INVALID_OPERATION error.

Bug: chromium:906269
Change-Id: I363e9375a32d2d0d6a990c0fdaab11a4aced064a
Reviewed-on: https://chromium-review.googlesource.com/c/1341022Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609532}

Change-Id: Ic230f0ab94f94adfd96cb513710d1c129e96d1db
Reviewed-on: https://chromium-review.googlesource.com/c/1343053Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Artur Khachatryan <khachatryan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609531}

Replace std::vector in Network Quality Estimator (NQE) by an array.
This is an attempt to avoid the crash that happens only on
Windows when rtt_ms_observations_ vector is referenced.

Change-Id: I8a3e0e45be6881bfb02442a62c7403aaa5b8078f
Bug: 899808
TBR: ryansturm@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1343345Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609530}

The phones were flashed to aosp recently and the exact version changed
a little.

R=jbudorick
NOTRY=true  # crbug.com/906840 for akar failures

Bug: 880623
Change-Id: If0e0b4f8e5cf5bcc6269b879af873f0f8dc5bf84
Reviewed-on: https://chromium-review.googlesource.com/c/1343295
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609529}

Change-Id: I59fe94a572d24fef984cb6d1494d6e209217d8f0
Reviewed-on: https://chromium-review.googlesource.com/c/1343497Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609528}

NotificationIntentInterceptorTest is based on UI automator to click on
Android UI outside Chrome UI, it relies on Android UI implementation,
that we probably can delete this test.

TBR=dtrainor@chromium.org, qinmin@chromium.org

Bug: 906843
Change-Id: I83f81f960ddbe8e9f6cb8d2a70820c811182a313
Reviewed-on: https://chromium-review.googlesource.com/c/1343375Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609527}

Bug: 899437
Change-Id: I4d6167d30a7b7014c17393960fce3ecb1470b80e
Reviewed-on: https://chromium-review.googlesource.com/c/1342778
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609526}

More cleanups, this is just within ash, not within app_list or shelf.

Bug: 906684
Change-Id: I42b6a0b6765481685a1ec5e612b4d849f8f3f0ff
Reviewed-on: https://chromium-review.googlesource.com/c/1342766Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609525}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/26fa18517532..739d7c2cc952


Created with:
  gclient setdep -r src-internal@739d7c2cc952

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I5c7c5f663099d2f1d25bad9ffb663307531387b1
Reviewed-on: https://chromium-review.googlesource.com/c/1342944Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#609524}

Bug: 900608
Change-Id: Ic1647bbcc227f8ac497b01a05a4ca4fcefe3b9ae
Reviewed-on: https://chromium-review.googlesource.com/c/1340829
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609523}

Some Linux drivers do not seem to recover well after OUT_OF_MEM and context lost.

BUG=893117
TEST=bots
R=piman@chromium.org

Change-Id: I55faefe2d631f3a682dd0b441d2a835836b792a6
Reviewed-on: https://chromium-review.googlesource.com/c/1343102Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609522}

Bug: chromium:905702
Test: manual, unit tests
Change-Id: I8e6902706a67eaa1e712c6c1147c4cc696b67fb2
Reviewed-on: https://chromium-review.googlesource.com/c/1338170
Commit-Queue: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609521}

NetworkContext::domain_reliability_monitor_ was being destroyed before the URLLoaders that are owned by NetworkContext::url_loader_factories_ because of the declaration order. Reset domain_reliability_monitor_ in the destructor so that it's not used later (since we null-check it before use).

Bug: 906452
Change-Id: Ib4ec198953142672a3991a4c62436733bd8da171
Reviewed-on: https://chromium-review.googlesource.com/c/1343337
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Doug Turner <dougt@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609520}

Bug: 876901
Change-Id: Ic8a37a79fe8bd41606f6be2ef5e5e2e6bc268e7e
Reviewed-on: https://chromium-review.googlesource.com/c/1341738Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609519}

GenericDmaBufVideoFrameValidator swaps U plane and V plane addresses so that
VideoFrameValidator is able to libyuv::I420Copy in the order Y, U and V. This
is a wrong design, meaning VideoFrameMapper does not only map but also
does something. VideoFrameMapper caller should expect the address acquired by
VideoFrame::data(UPlane) is V plane's and one by VideoFrame::data(VPlane) is U
plane's in the case of YV12 VideoFrame.

BUG=chromium:895230, chromium:856562
TEST=VDA unittest on hana with --frame_validator=check
TEST=VEA unittest on hana with --native_input

Change-Id: Ibf5e5685d95634fe6720f07dc154fd01907516d8
Reviewed-on: https://chromium-review.googlesource.com/c/1341783Reviewed-by: Pawel Osciak <posciak@chromium.org>
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609518}