GitLab

https://chromium.googlesource.com/catapult.git/+log/5b31e690a48d..58f6c4682e28


git log 5b31e690a48d..58f6c4682e28 --date=short --no-merges --format='%ad %ae %s'
2019-06-03 dberris@chromium.org SheriffRedux: Move skip_files to .gcloudignore


Created with:
  gclient setdep -r src/third_party/catapult@58f6c4682e28

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=crouleau@chromium.org

Change-Id: I1fde781b5341a98844780db1ad2397e1b9870c9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640798Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#665509}

The maximum resolution supported by guado is 1080p in video decoding. HW decoder
on guado (V4L2VideoDecoder) won't raise an error when the initial resolution
(e.g. 2K video) is unsupported. It causes chrome to not fallback and make 2k
video decoding undoable. This CL adds workaround to V4L2VideoDecoder for this
issue. It parses every vp8 encoded frame, checks the resolution on key frame and
invokes NotifyError() if the resolution is unsupported.

Bug: b:131366944
Test: run video_decode_accelerator_unittest on guado with 2K video file and get NotifyError
Test: 2K video can be seen on guado
Change-Id: Ic1ba2fa4a281dee6953d1696f991681217364f2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637001Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665508}

Renaming power_save_blocker_ozone to
power_save_blocker_stub because "_ozone" is a misnomer as
power save is OS-specific, not display-system-specific.

Power_save_blocker_stub is being used for non-ChromeOS Ozone
platforms such as Chromecast.

Bug: 495661
Change-Id: I3bc547a1c66accebb4e7285dc18e45a8aaacae0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636130Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Arnaud Mandy <arnaud.mandy@intel.com>
Cr-Commit-Position: refs/heads/master@{#665507}

Now the OOR-CORS is enabled by default at m76, but we want to
run some of layout tests w/o OOR-CORS for the potential risk
to postpone the launch beyond the m76. Legacy code path should
work well until then.

Bug: 905971
Change-Id: Ife79c90a031c9b729c629509da83e1ff2ac2a2c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635081
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665506}

Modified implementation and tests based on CSSWG resolution[1] and spec
change.

[1] https://github.com/w3c/csswg-drafts/issues/3849

Bug: 939811
Change-Id: Ia09af8926fa9cd0f00b36f4c20d6857a254bf009
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640539Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665505}

After adding the QueueShareMemoryRegionWhenReady() async API, we no
longer need the synchronous blocking API on DWriteFontLookupTableBuilder
to wait for the font lookup table to be ready. Remove the API and adapt
tests to use the async API and methods of ScopedTaskEnvironment.

Bug: 960263, 889864
Change-Id: I739de35f1eaf43dbf88f43ad589b29dcc84347a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631376Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Auto-Submit: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665504}

This CL implements PlzDedicatedWorker for nested dedicated workers. This new
path is used only when the runtime flags
(kOffMainThreadDedicatedWorkerScriptFetch + kPlzDedicatedWorker) are enabled.

// Technical details

Specifically, this CL associates WebWorkerFetchContext cloned for nested
dedicated workers with a script response fetched by the browser process (i.e.,
PlzDedicatedWorker).

 - Before this CL, WebWorkerFetchContext for nested dedicated workers is just
   cloned from a parent worker's fetch context. This means nested dedicated
   workers directly fetch the worker script without using the browser-fetched
   script.
 - After this CL, the fetch context is still cloned from the parent's one, but
   some fields of that take different values passed from the browser process
   (e.g., service worker provider info and loader factory info). The fetch
   context loads the browser-fetched script in response to a resource request
   from Blink.

This doesn't change results of existing tests because this change is not
sufficient to fix (service) worker tests disabled for PlzDedicatedWorker.
Subsequent CLs will fix them.

Design doc:
https://docs.google.com/document/d/1fWsD0oIa5sNDfUFWGJZ41pDo3zzsbFGyQSNdV8nOG4I/edit#

Bug: 906991
Change-Id: I63e375f2e29e73cc59caa30be242155217e52919
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635128
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665503}

This change is trying to make a couple of suspicious IOBuffers use different
vtable to see which one is the cause of the crashes.

Bug: 959627
Change-Id: I34465f5e38313944b9266672f5d15e83d9b81e34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638300
Auto-Submit: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665502}

The methods of the metrics file are now only used in the handler file
and FaviconRequestOrigin is only needed by the callers of the handler,
so we no longer need a separate file. This also fixes the fact that the
namespace used in that file had a typo (favicon instead of favicon_base).

Change-Id: Ia96b26940a355817bdfc9ef101d3122910ec63df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634885
Auto-Submit: Victor Vianna <victorvianna@google.com>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Commit-Queue: Victor Vianna <victorvianna@google.com>
Cr-Commit-Position: refs/heads/master@{#665501}

The SAML password expiry notification is given extra prominence every
time the user unlocks the screen - it pops up again as if it was a new
notification, instead of staying as a little number (1) next to the
clock in the bottom bar.
If the notification is currently not shown (ie has already been
dismissed) then the notification should not be reshown just because
the user has unlocked the screen. It can still be reshown due to
the passage of time as the password expiration becomes more imminent.

Bug: 930109
Change-Id: Ie7d7a4669e8ae14bde76d36aa358a97c73553a21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638459
Commit-Queue: A Olsen <olsen@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665500}

https://android.googlesource.com/platform/external/perfetto.git/+log/9e68bfc4b622..22727920c2e0

git log 9e68bfc4b622..22727920c2e0 --date=short --no-merges --format='%ad %ae %s'
2019-06-01 primiano@google.com Fix IWYU and GCC build, add missing includes
2019-06-01 primiano@google.com Merge "Add PRESUBMIT check for include violations"

Change-Id: Ib6a2cd8bf5da512a16c8aac62cd6af5958e82bdd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639380
Commit-Queue: Primiano Tucci <primiano@chromium.org>
Auto-Submit: Primiano Tucci <primiano@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665499}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/80180caaa9b2..65d5e72625ef


Created with:
  gclient setdep -r src-internal@65d5e72625ef

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=harringtond@google.com,orphis@google.com,shend@google.com

Change-Id: I8223cc06f60e07bfddd0012bbc40743f76bb87ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640900Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#665498}

When using '--gtest_repeat' setup of the test environemt will be done multiple
times on the same environment. This will result in crashes as e.g.
initialization of the Vaapi should only be done once.

TEST=ran new VDA perf tests on eve

BUG=953114

Change-Id: Iacc837c114796d9c90b8cd9724719e7d13348680
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610672
Commit-Queue: David Staessens <dstaessens@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665497}

R=fdoray@chromium.org, skyostil@chromium.org

Change-Id: I7210c5fc7a20cc2a2b367dd5d81d1551b2bd1f85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636136
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665496}

This patch hangs preserved trailing spaces when `text-align`
is `start` (or `left` in LTR or `right` in RTL).

The previous tests did not cover `start` case because it was
thought not observable, but issue 966773 discovered that it
is ovservable, and tests figured out that all impls hang in
this case.

This patch matches LayoutNG to legacy. The test is tentative
until the CSS WG resolution.

One test was failing before this patch but was accidentally
passed. Now it really fails:

Bug: 966773
Change-Id: I324b0c83e7aa9e5f3233b7bc56b262ddc5ee1fe2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640139
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665495}

This CL extracts the content-type utility into
//ios/web/web_view/content_type_util.* so that it can be shared between
CRWWebController, WebStateImpl and CRWWKNavigationHandler.

Bug: 956511
Change-Id: I0097d7b89c0f0f972beadf7753c34097a0c0847e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634730
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665494}

An old TODO is applied.

Bug: 277296
Change-Id: I1272f8106b526ecb1f95a59db9c9e33a3568211e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634689Reviewed-by: Raymes Khoury <raymes@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665493}

MessageLoopCurrent::task_runner() is depecated.
This CL replaces it with with ThreadTaskRunnerHandle::Get().
A small step towards deleting MessageLoop.

This CL was generated with git cl split.
Refer to the top-level CL if necessary :
https://chromium-review.googlesource.com/c/chromium/src/+/1631693

Please CQ if LGTY!

This CL was uploaded by git cl split.

R=timvolodine@chromium.org

Bug: 616447
Change-Id: I8336c678dfe4e0342003a89bd794e4c3715b9874
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635628
Auto-Submit: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665492}

This is a reland of crrev.com/c/1605442. PS1 is the original landed CL.

Add support to detect managed pinning and managed permissions
and display badges next to the toggles.

Screenshot:
https://bugs.chromium.org/p/chromium/issues/detail?id=953580#c4

TBR: raymes@chromium.org
Bug: 953580, 965910
Change-Id: Ie2ce836ffe6a4683ec5ba1437352ffb6ac846402
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619587
Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665491}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3e719632482a..80180caaa9b2


Created with:
  gclient setdep -r src-internal@80180caaa9b2

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=melandory@google.com,hiroshige@google.com,mlamouri@google.com,loyso@google.com

Change-Id: I895213c6148d244ed7814f993e28fa548e4d3fda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640252Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#665490}

Before this patch we reported the committed URL to our backend in the
initial request. The committed URL can potentially contain PII and can
therefore not be kept.

This patch changes that and reports the data url from the intent as
passed to chrome by a caller. There is approval for that piece of
information to be logged.

Bug: b/133732376
Change-Id: Idb98a727d37f2b9e7488f2f84b8fd273c2f4240f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632252
Commit-Queue: Mathias Carlen <mcarlen@chromium.org>
Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665489}

This CL adds additional metrics to the video_decode_accelerator_perf_tests. The
average and 25/50/75 percentiles for both frame decode and frame delivery times
are now calculated and output to the command line and the metrics json file.

TEST=ran new VDA perf tests on eve

BUG=953114

Change-Id: I25024d8baa2496014cedba0b706d862c8cc0711e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611076
Commit-Queue: David Staessens <dstaessens@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665488}

This CL aims to slim down ServiceWorkerGlobalScopeClient by moving its
ServiceWorkerHostAssociatedPtr member into ServiceWorkerGlobalScope, to
facilitate removing ServiceWorkerGlobalScopeClient completely in the
future.

Previously,
CallerXXX --> ServiceWorkerGlobalScopeClient -Mojo calls-> Remote
ServiceWorkerHost impl.
Now,
CallerXXX -GetServiceWorkerHost()-> ServiceWorkerGlobalScope
          then -Mojo calls-> Remote ServiceWorkerHost impl

BUG=931142

Change-Id: I1f8250210faf4ef0f34ef81f06d1a79ba23c3a3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636517Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Leon Han <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#665487}

WebContents::GetDelegate() can return nullptr.

BUG=b:64863368
TEST=Browse a PDF with an ARC Custom Tab on a Chromebook and see no crash

Change-Id: I15a25cb573581e3be932f02452dde396bab5eb25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638303Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665486}

Add retry for "right-click" to show the context menu for "remove folder
shortcut" menu. The right-click is on directory-tree (LHS), there is an
event listener p1[ for file selection (RHS), which races with this
right-click and makes this flaky.

I've added a local log for a retry and I could see it failing in the
first run and succeeding in the second run, this is a stopgap fix,
there is still a chance to race between the retry and the click after
it, but the window is much smaller. As the TODO in [1], I'll try to
remove the event listener to eliminate this race.

[1] - https://cs.chromium.org/chromium/src/ui/file_manager/file_manager/foreground/js/file_manager_commands.js?l=362-366&rcl=051250e22e8533ec28b9baa56ba945e9deda3166

Bug: 936429
Change-Id: Ibcb1cbfec9d22cb451d74f481bf4af4255e0f752
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640817
Auto-Submit: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665485}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

Please note that, despite rolling to chrome/android, this profile is
used for both Linux and Android.

The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=gbiv@chromium.org

Change-Id: Ib73ee05dddfcd7b1e7d7dc3f73a2e057260762ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640898Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#665484}

First usages of StrongAlias in production code. Fewer bare strings.

Bug: 954080
Change-Id: I1be4a54ac45f66ad21df4d0707b28f01fee01a53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636199
Commit-Queue: Maciej Pawlowski <mpawlowski@opera.com>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665483}

When switching to inline settings, we want to hide all views except the
origin, not just the timestamp. This groups all views that need to be
hidden together so it's easier to hide and show them again.

The previous CL http://crrev.com/c/1565001 did not handle the summary
text view that is shown for list and progress style notifications.

Bug: 955410
Change-Id: I3190cf112ee926b6e8ca1edc0953e1a3cd494273
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615467Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665482}

GLenum is typedefed in webgl_video_texture.idl and
webgl_rendering_context_base.idl.
We should avoid such duplicates in case of inconsistency.

This CL removes one of them, which focuses on a narrow scope.


Bug: 839389
Change-Id: I88f0d0cd52168480a2cf4f17a54ecd81d79c3fe5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640529Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Auto-Submit: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665481}

This CL cleans up kChromeUISyncResourcesHost which isn't used. In doing
so, it removes a context menu check that makes the normal page options
not appear on chrome://syncresources, as well as a default implementation
that looks like it was intended to remove these options on all WebUIs.

Bug: None
Change-Id: Id7a8bce3ca68759d143178ebe50615d00dcaec13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634593
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665480}

MessageLoop will go away, eventually.

ScopedTaskEnvironment will per default start a ThreadPool, which should
be fine in most of the cases. If you belive your test needs to make sure
that no ThreadPool runs let me know and I will update the patch.

BUG=891670
This CL was uploaded by git cl split.

R=henrika@chromium.org

Change-Id: I78f63048cdfeb41f0d87aeaa4a1e9a9f837e095a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636202
Auto-Submit: Carlos Caballero <carlscab@google.com>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665479}

MessageLoop will go away, eventually.

ScopedTaskEnvironment will per default start a ThreadPool, which should
be fine in most of the cases. If you belive your test needs to make sure
that no ThreadPool runs let me know and I will update the patch.

BUG=891670
This CL was uploaded by git cl split.

R=henrika@chromium.org

Change-Id: I69b6fbe7658dfe423b99079de5218ff94ac2ba7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635618
Auto-Submit: Carlos Caballero <carlscab@google.com>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665478}

For additional enterprise reporting, we need to retrieve the
package id from the registration. This commit adds a getter and
tests.

Bug: 844468
Test: unit_tests --gtest_filter "CrostiniRegistryServiceTest.*"
Change-Id: Icfea51476cf8e00068391a1953e5ab6ad0cc6e06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634697
Commit-Queue: Alex Oldemeier <aoldemeier@chromium.org>
Reviewed-by: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665477}

Though Web IDL spec removed [PrimaryGlobal] and made [Exposed] required [1],
many blink's IDL files have not followed it yet. So, this CL adds the keyword
to the IDL files which don't have the keyword yet in the renderer/core/animation
directory.

[1] https://github.com/heycam/webidl/issues/365

Bug: 963267
Change-Id: Ied1032d67bcdaa52e7fa3265471fd53f4b5ddd8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640743Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#665476}

Use Scoped* helpers to reset flags back to the default value for other
tests.

Change-Id: Icb5bdcdb36f09051703f0fab129211b617c4efee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637568Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665475}

For enum histograms ranging from 0 to N, 1 should be passed as the min,
N as the max and N + 1 (or the number of values) as the bucket count.
For files app histograms, N + 1 is passed for both max and bucket count.
This causes the middle value to not have a bucket. Pass N as the max to
avoid this problem.

Bug: 969600
Change-Id: I1725fdf8d97a9932174a47aaebe8382b3010db0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640148Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665474}

A huge(tested on downstream build - chromium68 with gcc 8.2,
about 180MB) compile warning messages are printed during
building chromium. One of major warning messages is about
memory operation.

Previously, I tried to fix the warning by fixing related code(
https://chromium-review.googlesource.com/c/chromium/src/+/1637021),
but it was not accepted. As a second option, this CL suppress
the warning. And the build flag is added only for (!clang and !win and
!nonacl) build.

Below is a sample message:
src/third_party/blink/renderer/platform/wtf/vector.h:193:13
warning: 'void* memcpy(void*, const void*, size_t)' writing to
an object of type 'class blink::Member<blink::TreeScopeEventContext>'
with no trivial copy-assignment; use copy-assignment or
copy-initialization instead [-Wclass-memaccess]

Bug: 819294
Change-Id: Ibfdc7bc278fc4f2a4640d770754de42ab5438e79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638211Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: JunHo Seo <junho0924.seo@lge.com>
Cr-Commit-Position: refs/heads/master@{#665473}

This adds fields for the Termina kernel version and a list of
installed apps to the existing device management backend proto.

Test: compile
Bug: 844468
Change-Id: Iee48c736a67cf466beff91086374250f1cb22cbe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628617
Commit-Queue: Alex Oldemeier <aoldemeier@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665472}

Disable:
SitePerProcessHitTestBrowserTest.SurfaceHitTestPointerEventsNoneChanged

Flaky on all bots.

TBR=clamy@chromium.org,sunxd@chromium.org
BUG=968970

Change-Id: I1db969e3a610cc8e2af385d8bbf0b5d6d6185e9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640251Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665471}

Bug: 969015
Change-Id: I74bf788a0cabed4a78702a2fb9c6e033feaaf7ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635684Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Tomasz Moniuszko <tmoniuszko@opera.com>
Cr-Commit-Position: refs/heads/master@{#665470}