- 21 Oct, 2019 40 commits
-
-
Martin Kreichgauer authored
This adds code to parse the maxCredentialCountInList and maxCredentialIdLength fields from authenticatorGetInfo responses. GetAssertionTask is changed to filter and batch allow lists when silently probing credentials according to these values, if the authenticator supports it. In particular, probing is skipped if the allow list fits into a single batch (and the request doesn't have an App ID that the GetAssertionTask might have to fall back to). MakeCredentialTask similarly filters and batches before silently probing for credentials in the exclude list parameter. Probing is skipped entirely, if the exclude list fits into a single batch and the request does not carry an appIdExclude extension. Fixed: 954613 Change-Id: I644e602054e4e2ebb4101b98b867f5dbc61e0901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867448 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#708023}
-
Oystein Eftevaag authored
All usage has now been replaced by the Perfetto-based Consumer API Reduces MonochromePublic.apk size by 20.5k. BUG=839086,1006760 TBR=dcheng@chromium.org Change-Id: I9e778ec1fa51f674c4769466db36b8ef51aa97fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820017Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#708022}
-
rbpotter authored
Feature launched in M77. Bug: 949585 Change-Id: I83dd05bb5941de84ea44958121ef13eb59566503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868654Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#708021}
-
Sammie Quon authored
It seems the opaque background has no children anymore, and repaints afterwards, so I don't think a render cache is needed. Test: none Bug: 10158843 Change-Id: I5f99340f177d8a655f231d3565c972fee337f062 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868916Reviewed-by:
Mitsuru Oshima (slow) <oshima@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#708020}
-
Alex Newcomer authored
Added test coverage, noticed we need to have a gesture of atleast 6px for us to register a ui::ET_GESTURE_SCROLL_UPDATE, which is required for us to move the hotseat. Change-Id: I73020cda89ab252fc5d7497ac9eccd1fb5e7f232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1870051 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#708019}
-
John Lee authored
This CL adds temporary checkboxes to the bottom right of the tab strip to allow for easy testing of 4 modes: 1) Most Recently Used ordering with auto-closing tab strip 2) Most Recently Used ordering when tab strip is closed manually 3) Default ordering with auto-closing tab strip 4) Default ordering with no auto-closing tab strip This CL also brings back drag-and-drop for unpinned tabs for cases where MRU is disabled. Bug: 989131, 1005554, 1005565 Change-Id: Iae066c2d85da712ecae29c040468cf67b31fd0d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867477 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/62b68fec1b2c..75c59424e3f1 git log 62b68fec1b2c..75c59424e3f1 --date=short --no-merges --format='%ad %ae %s' 2019-10-21 apolito@google.com [fetch] use py3 for fetch Created with: gclient setdep -r src/third_party/depot_tools@75c59424e3f1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:939847 Change-Id: Icc2676f2b266b1e725f097c98019744ed97a8143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872893Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708017}
-
Findit authored
This reverts commit 7777033e. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 707985 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzc3NzcwMzNlZGFkMzA1ZTI5YThlMmM0OTk4ODIzNThkNzAxN2NhY2IM Sample Failed Build: https://ci.chromium.org/b/8898950660954702496 Sample Failed Step: compile Original change's description: > Introduce an empty WebRTC component. > > While testing the WebRTC component build in [1], there was a problem > with some testonly code Chromium depends on (which cannot be part of the > WebRTC component). > > In order to support this use case, [2] will make the testonly code > needed by Chromium depend on the WebRTC component and this CL is needed > in order to land everything in an incremental fashion. > > [1] - https://chromium-review.googlesource.com/c/chromium/src/+/1868961 > [2] - https://webrtc-review.googlesource.com/c/src/+/157427 > > Bug: webrtc:9419 > Change-Id: Ie995af67a7ab4ba1a2e5bb012f2e9b33be056acb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872937 > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#707985} Change-Id: I259491613f592da9a5b4584de9fecca895d9398e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:9419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872944 Cr-Commit-Position: refs/heads/master@{#708016}
-
Mitsuru Oshima authored
I could cleanly apply this change to 78. Bug: 987819 Test: manually tested on 4k display device Change-Id: I9ed0c3a0f1007b46a213030fa19edf25dcb3810b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868840Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Mitsuru Oshima (slow) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#708015}
-
Etienne Bergeron authored
The code for ItemizeTextToRuns is really slow on some corner cases. This CL is fixing the performance issue (see http://crbug.com/924915). The main issue is that each iteration of the ItemizeText loop will move forward by the smallest amount of characters (size of the run) and then the whole logic to find the breaking position is applied again. As an example, the following text: "\n!\n!\n!\n!\n!\n!\n!\n!\n!\n!\n!\n!" * Computing the breaking point of "bidi direction" is O(n) * Computing the breaking point of "script" is O(n) Unfortunately, most runs will be split at the \n since it's a special character. This means the complexity of this code will be O(n^2). The proposed code in this CL is: 1) Splitting in block of same bidi direction 2) Splitting in sequence of characters with compatible script 3) Splitting for special characters / style This way, the 1) and 2) are only executed once (e.g. O(n) ) by character. NOTE: This bad pattern was happening often with emoji since they are often isolated in a run as a special characters. Bug: 924915, 1014119 Change-Id: I8d950e166ff01285ad0ce9796e38321ec502f368 Fixed: 2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865673Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#708014}
-
Michael Ludwig authored
This refactors DoDrawQuad's material branching into an internal function that can be reused by DrawRenderPassQuad. This makes DrawRenderPassQuad independent of the bypass quad's material type. Bug: 1013735 Change-Id: I0c8b316ac11fc34aed9d2f1e6ae88f06931bbf56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860594 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Reviewed-by:
weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#708013}
-
Ken Rockot authored
Almost of all of the code in this class is shared acoss all instances of the tempate. This introduces a ThreadSafeForwarderBase class and moves the logic into it. No functional changes. Bug: 1016022 Change-Id: I515c472f8a6fdc97fdd25d90db596d23a89ce543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871195Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#708012}
-
Andres Calderon Jaramillo authored
This CL stops and restarts the camera capture stream in V4L2CaptureDelegate the first time a timeout is detected while polling for captured frames. This is a workaround for a Huddly GO camera issue where the camera gets into a deadlock state at times at the beginning of the capture session. The underlying issue seems to be a kernel driver synchronization problem, but upgrading the kernel might not be practical in the short term for affected devices. 1) Flash M78 Chrome OS image. 2) Deploy Chrome in debug mode (a bunch of irrelevant DCHECKs must be deleted). 3) In non-kiosk mode, visit https://webrtc.github.io/samples/src/content/devices/input-output/ 4) Switch between the two Huddly GO streams constantly while monitoring /var/log/chrome/chrome. Eventually, the deadlock path is hit (see the DLOG(WARNING) in v4l2_capture_delegate.cc) but we recover successfully and the camera continues capturing normally. Change-Id: Idc90aa8b9dbb069c419c3ca1b90be9b47d4a6c51 Bug: 1010557,b:141978989 Test: on a guado with a Huddly GO: Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859901 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#708011}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/3c79cf2ab9f2..2c8b5c637028 git log 3c79cf2ab9f2..2c8b5c637028 --date=short --no-merges --format='%ad %ae %s' 2019-10-21 cwallez@chromium.org Introduce the webgpu[_cpp].h headers. 2019-10-21 rharrison@chromium.org Rolling 3 dependencies 2019-10-21 rafael.cintron@microsoft.com Plug D3D 11on12 memory leak Created with: gclient setdep -r src/third_party/dawn@2c8b5c637028 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: Ib1e0c945cd3524dbf7ce3af477d123eee30cf6a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872922Reviewed-by:
-
Kevin Marshall authored
This is a reland of 3692f7b0 Adds a missing GN dep which caused a build breakage on component/debug builds. Original change's description: > [web_engine] Add "web_engine_shell" standalone executable. > > Implements a simple standalone executable which will launch a fullscreen > browsing session and navigate it to a given URL. Similar to > content_shell, but using Web Engine instead. > > The flow is kept deliberately simple and linear so it can serve as a > functioning code sample for aspiring embedders of Web Engine. > > The shell can be used to test arbitrary static data, which is sourced > from //fuchsia/engine/test/shell_data and hosted under the content URL > fuchsia-dir://shell-data/ . > > The shell can also optionally request that the DevTools server be > started at a port specified on the command line. > > Bug: 1016485 > Change-Id: I09ad56f20553acc83fbf38924fa3e8d8a98a1200 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869887 > Commit-Queue: Kevin Marshall <kmarshall@chromium.org> > Reviewed-by: David Dorwin <ddorwin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#707911} TBR=ddorwin@chromium.org Bug: 1016485 Change-Id: I49728ffa5ab21e8a329bd8e1fefdb1071460ef4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872827Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#708009}
-
Xiaoqian Dai authored
Previously it was in HomeLauncherGestureHandler. That means all eligible windows were hidden before the drag actually started. Move it to its own class DragWindowFromShelfController so that we only hide window when drag actually starts. It will also be benificial for the class DragWindowFromShelfController to be called from other caller. Bug: 997885 Change-Id: I0cb8285c9505b48db76d4f5e5103ca24ebe1d90a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872804Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5f192c2cad99..c21b70d6b576 Created with: gclient setdep -r src-internal@c21b70d6b576 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I012e250854cb7d4456085ff60990ead802af0384 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872920Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708007}
-
Victor Costan authored
Bug: 1016038 Change-Id: I3faa9e5071e09a5923e9321fc1449431f22ca666 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869384 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#708006}
-
Alex Cooper authored
This is the first step in removing WebVR. This change removes WebVR from about://flags and also removes the separate command-line switch that was used. In order to keep the tests running for the time being, this change modifies the blink webvr feature to be set to "test." The browser tests for WebVr have been updated to set the new flags that will turn on WebVr. This also removes the Origin Trial flag for WebVr, and as such deletes the origin trial layout tests as well. Bug: 960132 Change-Id: Ia625e3ae9986183ef2746dcb69e595cab49fd981 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862855 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#708005}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8c61f5295030..0ce6d876771d git log 8c61f5295030..0ce6d876771d --date=short --no-merges --format='%ad %ae %s' 2019-10-21 lamontjones@chromium.org config: add R79 to luci-scheduler. Created with: gclient setdep -r src/third_party/chromite@0ce6d876771d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I348c232627a58e6e1653d8c23850c07148173af1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872923Reviewed-by:
-
Jordan Bayles authored
This patch includes a lot of namespace moves and general name cleanup for the Open Screen platform code. Change-Id: I00b12810dd2828fe178d48f21032f25be6e5030c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867450 Commit-Queue: Jordan Bayles <jophba@chromium.org> Auto-Submit: Jordan Bayles <jophba@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#708003}
-
Ken Rockot authored
Also renames it to AsyncDomStorageDatabase 'cause that's what it be. Bug: 1000959 Change-Id: I4bc29a722155b4bb890353b83efdc4100917bf33 Tbr: avi@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1870110 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#708002}
-
Aga Wronska authored
Bug: 1008189 Change-Id: Iab2a10cb9e8e6a5f3737b0515308ad5213a41776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864624Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
-
Manas Verma authored
Keeping track of whether a user verification attempt ends with a success, a "not allowed" error, or a different error. Bug: 949269 Change-Id: Icc50d85e0d1bb56a1c575dc5ee86af86d4276ef2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864402 Commit-Queue: Manas Verma <manasverma@google.com> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#708000}
-
Min Qin authored
BUG=965215 Change-Id: I06b867c8adcdeae00dcde4d603e0e16eb0a0820d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869020 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#707999}
-
Xing Liu authored
Chime is a notification library pulled in downstream clank repo, which needs to ship in Android DFM. This CL sets up the boilerplate for chime DFM module. Bug: 1013386 Change-Id: I161613ca16adf5131d55b1803b6ad9e5821c80eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867379 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#707998}
-
Kelvin Jiang authored
This CL removes the need for defining a custom unordered comparison method for vectors of RequestAction Bug: 1015642 Change-Id: Iac7f0366e832dd58a8fbd921461fd534d3d453b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1870053 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Auto-Submit: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#707997}
-
Chris Davis authored
Fix delayloads_unittests to properly handle is_multi_dll_chrome set to false and when run on win7. A previous change to modify behavior based on CHROME_MULTIPLE_DLL_BROWSER was not correct since is_multi_dll_chrome was not checked in the tests BUILD.gn. Also, Windows7 will load user32 due to static dependencies starting from oleaut32.dll which are not present on windows 10. Unfortunately oleaut32 is pulled in from many dependencies during dll load of chrome (when merged) or chrome_child. Change-Id: If364f08c35e6c881249b2be3ce092eb2ddd48a68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872563 Commit-Queue: Chris Davis <chrdavis@microsoft.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Cliff Smolinsky <cliffsmo@microsoft.com> Cr-Commit-Position: refs/heads/master@{#707996}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/dd6606f6cee7..88adfb7aa2e6 git log dd6606f6cee7..88adfb7aa2e6 --date=short --no-merges --format='%ad %ae %s' 2019-10-21 dproy@google.com Merge "processor: Walk up stack to find matching begin event" Created with: gclient setdep -r src/third_party/perfetto@88adfb7aa2e6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I4cbeac4e71614fa2aa803780ee7838eff25b7270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872836Reviewed-by:
-
Boris Sazonov authored
This CL addresses cases when no favicon is shown for some credentials. This may happen when the credential has been saved in a different app, as in this case credential origin is an opaque URL for which no favicon can be obtained. To work around this, this CL adds plumbing to pass the URL of the page for which TouchToFill has been triggered. If the credential origin is opaque, TouchToFillController requests a favicon for the frame origin. Bug: 1012646, 1016486 Change-Id: I6d803734460279b3f079db77d05992c39a43ac02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865338 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#707994}
-
Maks Orlovich authored
(~3 remain that seem to need somewhat more attention) Bug: 1016512 Change-Id: Iebec6305b440a33b611773730727df4d3c725260 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872412Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#707993}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I580879e2dc32f13383b5d9d2b4dc44a7fdd3460e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872160Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#707992}
-
Allen Bauer authored
If a dialog/sheet is constructed and destroyed having never been shown, the normal tear-down sequence never happens. This change ensures that the underlying NSWindow had actually been invoked as a sheet. If not, immediately initiate destruction. Bug: 1000893 Change-Id: I9a7947db38bd1edcdda64627507fdfc834b127ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869403Reviewed-by:
Sidney San Martín <sdy@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#707991}
-
Lan Wei authored
For the case that the snap point is the same as the scroll position, we set the snap_at_gesture_scroll_end flag to be true, but there is no scroll snap animation happen, We pass a callback of setting hover state dirty to snap function, and when the snap point is the same as the scroll position, the callback will be executed to update the hover state right away. Majid's CL to change SnapCoordinator::PerformSnapping to return true when the snap point is the same as the scroll position: https://chromium-review.googlesource.com/c/chromium/src/+/1769044 Bug: 877132 Change-Id: I4cfc1bf03ee980b4b68e74aad79a8bec6a906da1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790259 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#707990}
-
Robert Liao authored
Individual classes now extend from Microsoft::WRL::RuntimeClass. BUG=1014283 Change-Id: Ic56344114a2b0432d0d29992a3dab8896ab2ae39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863551 Auto-Submit: Robert Liao <robliao@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#707989}
-
minch authored
Bug: 1002733 Change-Id: I6254d5d5feeb1e6fa1fcb72b8109453523683b97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867094Reviewed-by:
-
Sophie Chang authored
Bug: 968542 Change-Id: I5f2846630bb5ff1a4f648b59bbe332c7e557b121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871330Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#707987}
-
Mikel Astiz authored
This adds basic support for persisting encryption keys on disk using a dedicated file (intentionally outside sync's directory), containing an encrypted protocol buffer as introduced in this very patch. Bug: 1012660 Change-Id: Ie9fedae86799f412703914dbfec53e3d0b85a2c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865324 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#707986}
-
Mirko Bonadei authored
While testing the WebRTC component build in [1], there was a problem with some testonly code Chromium depends on (which cannot be part of the WebRTC component). In order to support this use case, [2] will make the testonly code needed by Chromium depend on the WebRTC component and this CL is needed in order to land everything in an incremental fashion. [1] - https://chromium-review.googlesource.com/c/chromium/src/+/1868961 [2] - https://webrtc-review.googlesource.com/c/src/+/157427 Bug: webrtc:9419 Change-Id: Ie995af67a7ab4ba1a2e5bb012f2e9b33be056acb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872937Reviewed-by:
-
Sammie Quon authored
Caused regression in attached bug. UX still wants this will try to possibly re-enable this for M-80. But for M-79 we should disable it. TBR=oshima@chromium.org Test: none Bug: 1016047 Change-Id: I41bee546750b712b575ff3ed70a6245009bcf0c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872767 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#707984}
-
