- 05 Jan, 2021 40 commits
-
-
Leonard Grey authored
Bug: 1152274 Change-Id: I9a067d0db2d6ad05d353db9f655272cd16bc4efc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595601Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#840300}
-
Dale Curtis authored
This uses the shared main thread context to convert these frames into SkImages. Since there's no reason to create a new IO-thread context, the entire conversion process is moved to the main thread. Fixed: 1161825 Test: https://plnkr.co/edit/k6Itrjzzj60vT2fC?preview Change-Id: I5e161cfc1e498442409f577d279a85c8c1322522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611341Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#840299}
-
Lijin Shen authored
There is no guarantee native will be initialized when onConfigurationChanged is called Bug: 1162510 Change-Id: Iac48e4dc0c9ab3c6a080a72afeee52657fd32aa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606874 Commit-Queue: Lijin Shen <lazzzis@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#840298}
-
Xida Chen authored
This CL handles transition keyframes when we composite background color animation. Bug: 1153670 Change-Id: I9252db7f7344472d8fc9f1866d1f5b2a038dd2f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589114 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#840297}
-
Dave Tapuska authored
These methods are uncalled via CompositorDependencies interface. BUG=1097816 Change-Id: Id5d6ffd39246f6ff55b965c04c38a7e0403ab409 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587372 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#840296}
-
David Bokan authored
The Filter callback in this class may be called multiple times so this should be a RepeatingCallback. We also convert to pass-by-value to indicate a transfer of ownership. No change to call sites as they already use BindRepeating. Bug: 1152268 Change-Id: I82df5dcc1a505cac4b778af1495209b3c74f6db2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605875Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#840295}
-
David Maunder authored
It is not possible to define GetInstance() generically - i.e. one code path would return a ProfileProtoDB<Foo>* and another ProfileProtoDB<Bar>*. The only way of unifying these would be to return a void pointer, however, that would start to require a lot of static casting. It is much cleaner to define the GetInstance() methods per template. Bug: 1159157 Change-Id: I4cbc39f9a4f03346e7f30179b13b3b18a47f1f95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597658Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#840294}
-
chrome://add-supervisionMichael Giuffrida authored
This upgrades the Add Supervision WebUI to Polymer 3 and removes all HTML imports. Previously, most of the UI was in Polymer 2 using HTML imports. We had two targets for post_message_api.js, including one that modulized it so OOBE and EDU Coexistence could use PostMessageAPIServer in JS modules. Now, everything is a module. No duplicate post_message_api.js target is needed. * Update the Add Supervision UI to a Polymer 3 component, replacing HTML imports with JS import statements and using html_to_js to templatize * Remove modulization, make everything just a .js module * Remove webview examples that didn't work and aren't necessary Bug: 1111430 Change-Id: I54d441fb965e6cbf1bd982b86ec4bfa611c63f1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600822Reviewed-by:
Dan S <danan@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#840293}
-
Yuheng Huang authored
Add a story to track performance of subsequent open tab search with loading case Bug: 1099917 Change-Id: I8e37f2f5f6771adcf35923f0c92af61c03d16f97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605386Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#840292}
-
David Bokan authored
This CL cleans up some remaining trivial callsites currently using base::Bind where the called method already takes a modern {Once,Repeating}Callback. Bug: 1152268 Change-Id: I0c36a55354195899f6c2a0c134ac4da63a5a4339 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602557Reviewed-by: -
Sergei Glazunov authored
This field points past the end of an allocation; therefore, it can refer to an invalid allocation slot, which will lead to a crash in the CheckedPtr constructor. Bug: 1158039 Change-Id: Iaa141a51e680994a4c6bc9aabb6039621424706b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611704 Auto-Submit: Sergei Glazunov <glazunov@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#840290}
-
Yuke Liao authored
This CL adds a presubmit script for the coverage related merge scripts to make sure unit tests are enforced when changes are made. Change-Id: Ifde0971374cba3f48c921bdc8ec404cca5eb1d54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611327 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#840289}
-
Hui Yingst authored
This CL migrates |available_area_|, |document_size_| and FillRect() from using pp::Rect/pp::Size to using their gfx:: equivalents in OutOfProcessInstance, so that they can be migrated into PdfViewPluginBase later. This CL also changes a constructor of PaintReadyRect(), so that it no longer takes pp::Rect type as one of its inputs. Bug: 1101101 Change-Id: I40569e34768d81d609d6077c14857581b0198445 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606035 Commit-Queue: Hui Yingst <nigi@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#840288}
-
Yuheng Huang authored
This CL exposes trace events of tab search browser API calls to benchmark so that it's more trackable. Bug: 1099917 Change-Id: I97ba634c842b1d802538aa24df4b53e2ea41bc5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611684Reviewed-by:
-
Hao Li authored
The creation of query set with the type of pipeline-statistics is supported on all backends, but its extension is not enabled in blink, add the extension name of pipeline statistics query for testing query set creation. Bug: dawn:434 Change-Id: I507ab9dbcf87725392b2c105c40769a9f007c4b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607695 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#840286}
-
Lachlan Ford authored
Hand selection was failing due to missing bindings in OpenXR. This change adds those bindings. Change-Id: Idda0db8215ab45cbcfcd1019d111e011604dc2ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598738Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Lachlan Ford <laford@microsoft.com> Cr-Commit-Position: refs/heads/master@{#840285}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/30550a74a101..e8f563f111db If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kmoon@google.com,sahel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1138953,chromium:1145230 Tbr: kmoon@google.com,sahel@google.com Change-Id: Id3a310f46da07119e16ab030e82d5971b0af81cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611326Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Kahmy Moon <kmoon@google.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840284}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ee8ca5255488..472239462122 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I9a688337704daf83edb56514a1fd081fe56a837c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611166Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840283}
-
David Bokan authored
DevicePermissionsPrompt::AskForUsbDevices receives a reply in the given callback. This callback is stored a UsbDevicePermissionsPrompt object but cleared after being invoked so it can only ever be invoked once. Bug: 1152268 Change-Id: Ic867e6907129496f7e46dbe8c799c8e97f02ad5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601069Reviewed-by:
-
Alex Turner authored
The experiment is being abandoned, so this cl removes the code for it. Bug: 1161316 Change-Id: I4d5091982874f1c36afbf21c6e81eee867e08ed9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597853Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ibec4e1652b3d8b5e04e27e5e4bbc2e6413eace2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611012Reviewed-by:
-
Jérôme Lebel authored
Disable: CreditCardViewControllerTestCase/testOTRAddCreditCardsActionOpensAddCreditCardSettings Failing with: https://ci.chromium.org/ui/p/chromium/builders/ci/ios14-beta-simulator/4238/overview https://ci.chromium.org/ui/p/chromium/builders/ci/ios14-sdk-simulator/5839/overview Bug: 1163116 Change-Id: I95e70a19f2b4ee7965094d57c0273d0cd9913aec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607310Reviewed-by:
Javier Flores <javierrobles@chromium.org> Commit-Queue: Javier Flores <javierrobles@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#840279}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2c541cdf0089..de6e3a9d85af 2021-01-05 dproy@chromium.org [trace-viewer] Fix displaying args when value is 0. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC matthewdeluca@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1036492 Tbr: matthewdeluca@google.com Change-Id: Id6c4e706409e6176a2750652f7f93a1a4f9e3a60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611604Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b6ea6edc3f4e..973bd4ba0f57 2021-01-05 syoussefi@chromium.org Complete I/O block GLSL tests 2021-01-05 syoussefi@chromium.org Vulkan: Directly capture non-gl_Postion builtins If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: I0eb3e3310acfee7c00a703944d0a47180cbbc997 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611165Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1609847937-8a3dc54f6d6b8008f835ccf1ed36d98d27bfc95a.profdata to chrome-mac-master-1609869437-1a950cb4179e276745ee2e9da68ac232cb554183.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I0a9fd508a981f10581ff16febf6bf25b0541e318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611609Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ee8ca5255488..472239462122 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I21eb7e6c6898f61f59d68f5798fbb03b8cdca190 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611167Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1609847937-af9ee8d51bc6a0aba5c9a2202bd2fb2e3011ef58.profdata to chrome-linux-master-1609869437-8f3fde660eac6867df6a9ca50d8e63b86cfec419.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I89fab73b60cccc189956629fdcfe4c31d611f7da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611607Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7d63f91e4a43..6356cb1904b8 2021-01-05 fmalita@chromium.org Fix skottie2movie after asyncRescaleAndReadPixels changes 2021-01-05 johnstiles@google.com Fix type error with Metal mod(vec, float) intrinsic. 2021-01-05 egdaniel@google.com Use sk_sp for GrVkPipeline. 2021-01-05 fmalita@chromium.org [svg] Text rotate support 2021-01-05 brianosman@google.com Add 'tint' (used by Dawn) to Skia's DEPS If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC johnstiles@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: johnstiles@google.com Change-Id: Ic3ba13775768c954478cf2d3153333e1b6a16409 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611168Reviewed-by:
-
Alex Moshchuk authored
Bug: 1149486, 1149487 Change-Id: I60dee7921e417a1e96efd91b5cfbe6b19516e89e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599473 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Auto-Submit: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#840272}
-
James Hollyer authored
The new XBox Controller is out so we are adding support to the gamepad API. The mappings match up to the XBox One Controller mappings so this patch applies those mappings to this productID. Bug: 1147578 Change-Id: I362294ac73dede831fbd3641eb84cc9f0f896fc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580484Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: James Hollyer <jameshollyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#840271}
-
Nico Weber authored
- remove many now-fixed issues, update open issues - things basically work now, so recommend using trunk lld less strongly - add section with pointers on how to make repros Bug: 1149587 Change-Id: I4524c99c4894b1669a4d12dfcda677b31fea491c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611444 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#840270}
-
Clark DuVall authored
WebView didn't previously log the synthetic trial for isolated splits, and may not have supported synthetic trials at all previously. This matches the setup in chrome_browser_main.cc. Bug: 1150162 Change-Id: I837c6b04059fcbd34248ebbe372bd08374f58b65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605007Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#840269}
-
Evan Stade authored
Bug: 1161143 Change-Id: I52317cbd7b760218036a3cb99a9e53f6e5ed1e97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603120 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#840268}
-
Tommy Li authored
This CL collapses entries that with previously uniquified keywords, i.e. "example.com_" and resets their keywords from their URL, which should be regenerated as "example.com". All safe_for_autoreplace() engines are either prepopulated or generated as the user browses, so they should all have keywords of the form "example.com" (they should all look like hostnames). If they end in an underscore, it's because we tried to uniquify it in the past, and it's leftover in the database. Engines that the user manually edited would no longer be marked as safe_for_autoreplace(), so we are only talking about prepopulated or autogenerated engines. By resetting the keyword from the URL, we will set it up to be eligible for automatic de-duplication with other "example.com" replaceable engines. The full design is in: go/chrome-search-engines-2020-improvements Bug: 1022775 Change-Id: I2763b6d7371aa266c1d8d720725876bf3107b6a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598005 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#840267}
-
Abigail Klein authored
installation events from a11y page. While Linux, ChromeOS, and early versions of Windows do not have their own captions settings so Chrome introduced our own, MacOS and later versions of Windows have their own captions settings which open externally. In the former case, the Live Caption toggle exists on captions_subpage.html, while in the latter case, the toggle exists on a11y_page.html--but both use the same captions_handler webui to observe the soda installation. This CL fixes a bug where the soda installation was not being observed in the latter case. The previous assumption was that allowing javascript on one webui page allowed it on all pages--but that is apparently not the case. This CL explicitly allows javascript on the captions_handler from a11y_page.js. Bug: 1055150, 1156247 Change-Id: I54ab7e3207459d4c1e56e2da65361a6725b522c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601230Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#840266}
-
Wenbin Zhang authored
Use the new tag to disable the failing test on pixel 4a. Bug: chromium:1162969 Change-Id: Iaf802cd5450cfe69ae217f3f473b1dc2aa860617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610352 Auto-Submit: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
-
Sigurdur Asgeirsson authored
This will get us DCHECK and CHECK failures from the field, and if needed we can add additional instrumentation to figure out what's going on. Bug: 1143281 Change-Id: I83c8c4470a71d195970673a3cc8c1ff1efd264e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611524Reviewed-by:
Patrick Monette <pmonette@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#840264}
-
Maksim Ivanov authored
Fix bug found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I6fb3b2d9f0fcaa7fae7ac8e6ef89dc37196455a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560582Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#840263}
-
Stephen McGruer authored
This change also adds a timeout for generating the manifest (5 minutes), so that failures (e.g. bug 1161274) do not just silently hang at 'Collecting tests...'. Bug: 1161274 Change-Id: I55e2cfb37b230135694a3ad4a5f95a1cc2fdaa58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611124 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Auto-Submit: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#840262}
-
Brian Geffon authored
This CL adds a declaration for ChannelPosix so it can be extended. This will keep things cleaner when we add a Fast PosixChannel, otherwise things would become unweildy in a single file. Bug: b:173022729 Change-Id: Ie4ed21b885a62e4d755ae393484aa2717e0668b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586045 Commit-Queue: Ken Rockot <rockot@google.com> Auto-Submit: Brian Geffon <bgeffon@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#840261}
-
