Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 22 Oct, 2014 8 commits
    • zmo's avatar
      Detect built-in varyings' invariant setting conflicts. · ad0c1301
      zmo authored 
      BUG=421710
TEST=conformance/glsl/misc/shaders-with-invariance.html
R=bajones@chromium.org

Review URL: https://codereview.chromium.org/660123002

Cr-Commit-Position: refs/heads/master@{#300580}
      ad0c1301
    • dcheng's avatar
      Standardize usage of virtual/override/final in chrome/browser/media · d7e84a05
      dcheng authored 
      The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=scherkus@chromium.org

Review URL: https://codereview.chromium.org/665323004

Cr-Commit-Position: refs/heads/master@{#300579}
      d7e84a05
    • qinmin's avatar
      Fix a crash when cameraInfo is NULL · f3c57f9b
      qinmin authored 
      It is possible that cameraInfo returns NULL.
However, the NULL case is not well handled and it will cause crashes.
This change also removed the unncessary JNI call to convert an int to string

BUG=424775

Review URL: https://codereview.chromium.org/667433003

Cr-Commit-Position: refs/heads/master@{#300578}
      f3c57f9b
    • ebraminio's avatar
      Add myself on AUTHOR · 2bbc4fbf
      ebraminio authored 
      BUG=

Review URL: https://codereview.chromium.org/656583005

Cr-Commit-Position: refs/heads/master@{#300577}
      2bbc4fbf
    • jbudorick's avatar
      [Android] OWNERS changes to b/a/buildbot and b/a/pylib · 4ddcc3a0
      jbudorick authored 
      craigdh, frankf, and ilevy are no longer working on chrome.

BUG=

Review URL: https://codereview.chromium.org/670783002

Cr-Commit-Position: refs/heads/master@{#300576}
      4ddcc3a0
    • dcheng's avatar
      Standardize usage of virtual/override/final in chrome/browser/browsing_data · d2d19203
      dcheng authored 
      The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=mkwst@chromium.org

Review URL: https://codereview.chromium.org/666123002

Cr-Commit-Position: refs/heads/master@{#300575}
      d2d19203
    • jbauman's avatar
      Reset DelegatedFrameHost SurfaceFactory when output_surface_id changes. · b64da3f3
      jbauman authored 
      This is similar to the DelegatedFrameResourceCollection logic and avoids returning resources created by one output surface to a different one.

Review URL: https://codereview.chromium.org/650533004

Cr-Commit-Position: refs/heads/master@{#300574}
      b64da3f3
    • dcheng's avatar
      Standardize usage of virtual/override/final in printing/ · d5a0f18a
      dcheng authored 
      The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=vitalybuka@chromium.org

Review URL: https://codereview.chromium.org/668073002

Cr-Commit-Position: refs/heads/master@{#300573}
      d5a0f18a
  3. 21 Oct, 2014 32 commits