- 27 Mar, 2019 40 commits
-
-
Liquan(Max) Gu authored
This CL is to fix a bug in FCP++. FCP++ is currently using a set for ranking the nodes' size. When two node sizes are the same, the set will ignore one of them. This bug will manifest in the following scenario: * A and B element have the same size, which is the largest on the page. * When the set adds A and B, it ignores B implicitly. * A is detached from the DOM. * LCP reports a candidate. At this time, LCP should have reported B, but as B is not in the ranking set, it's ignored by LCP as well. Bug: 944248 Change-Id: I55d6856ff93191494a0bd46f7043b76c2f674b7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534303Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#644802}
-
Becca Hughes authored
Add field trial testing config for preseed stable exp. BUG=931791 Change-Id: I5db4299e1a347cb52565d862a60f1b0ff3c12783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540458 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#644801}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/58cb9bcb7e0a..f27b5ca150c5 Created with: gclient setdep -r src-internal@f27b5ca150c5 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=robertocn@chromium.org,noel@chromium.org,eirage@chromium.org Change-Id: If17d627742106624408f11b9259b2e35fdea476a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541503Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644800}
-
Nico Weber authored
- Move global win-only flags from //build/config/compiler to //build/config/win:compiler which the former already references if is_win - Move /FC from the toolchain to //build/config/win:compiler too: The toolchain isn't where random compiler flags should be added. - This allows moving msvc_use_absolute_paths from a gni file to a gn file, so do that as well. No intended behavior change. Bug: none Change-Id: I1b35a4242649105e005b94df911849ebf44d7c5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541636 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#644799}
-
Dominik Röttsches authored
Change-Id: I58eacb74a1cd2335119ba508b27656088285dc1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541776 Auto-Submit: Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#644798}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8c020057. With Chromium commits locally applied on WPT: 685a1df9 "Extend canvas getContextAttributes WPTest" 11eae161 "HTMLVideoElement: implement playsinline and auto-fullscreen." 1bf12f7c "Revert "Fix external/wpt/event-timing/event-timing-onloadobserve.html to be more deterministic"" efbe41b8 "Change unoptimized-images feature policy to unoptimized-lossy-images." 34ea864a "Revert "Change unoptimized-images feature policy to unoptimized-lossy-images."" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I8300b9b3c3096f7c63a3d10a7fcb1f2c1a4ce04e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541496Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644797}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/df5b28fdb45c..e43cda5f76de git log df5b28fdb45c..e43cda5f76de --date=short --no-merges --format='%ad %ae %s' 2019-03-27 capn@google.com Add GLES unit tests to Kokoro Windows CI Created with: gclient setdep -r src/third_party/swiftshader@e43cda5f76de The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: Ifa2b18d9d9722e231c59c61ff1b760bfe8f29104 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541499Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644796}
-
Ehsan Karamad authored
This reverts commit 8fce3374. Reason for revert: This is causing test failures. I will wait for crrev.com/c/1535965 to land and then try this again in case the failures are due to non NetworkService code path. Original change's description: > [ MimeHandlerView ] (frame-based MHV) postMessage > > This CL hooks up post messaging API for frame-based MimeHandlerView. A > current post message test which runs only for BrowserPlugin version is > now modified to run for frame-based MimeHandlerView as well. > > Bug: 659750 > Change-Id: Ie58fa733f463e697e38a100f78e0e50e7431b983 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539869 > Reviewed-by: James MacLean <wjmaclean@chromium.org> > Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#644640} TBR=ekaramad@chromium.org,wjmaclean@chromium.org Change-Id: I9b14956a23b601c35e626c8a691ea000160823dc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 659750 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541583Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#644795}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I196dc9dd1a90f5c9dc69a2905c374ddbee691631 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541498Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/bc2a48ba8635..2d11abbb30a0 git log bc2a48ba8635..2d11abbb30a0 --date=short --no-merges --format='%ad %ae %s' 2019-03-27 perezju@chromium.org [systrace] Replace generate_random_filename_for_test with tempfile_ext Created with: gclient setdep -r src/third_party/catapult@2d11abbb30a0 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:945342 TBR=sadrul@chromium.org Change-Id: I9aebb0e02870c29783b01dbb863e55d462efcd21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541502Reviewed-by:
-
Zhang Xiangze authored
Usage of compositor_task_runner has been moved to CreateSubmitter() Change-Id: Iedd9eb118f0308ceb97a2857f32b6fed5b5b378c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1537568Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#644792}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0a9ce6e0..4a2582bf Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I57e28ce8cc308d0a499cf69331665ed3cc73cd27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541424Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644791}
-
Dominik Röttsches authored
Fixes fuzzer issues listed in Bugs line. Remove behdad@google.com from OWNERS. https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz.git/+log/bcb4e505d6ff..ec2a5dc859b0 $ git log bcb4e505d..ec2a5dc85 --date=short --no-merges --format='%ad %ae %s' 2019-03-26 behdad Use class templates for Null objects 2019-03-26 behdad [aat] Add missing check to ankr table 2019-03-25 behdad [docs] Update 2019-03-25 behdad Update ChangeLog generation 2019-03-26 qxliu completely remove lines that are commented out 2019-03-26 qxliu update arguments in_populate_gids_to_retain() and _create_old_gid_to_new_gid_map() so they don't use deprecated variable 2019-03-25 qxliu try to remove deprecated variable from struct definition Created with: roll-dep src/third_party/harfbuzz-ng/src TBR=bashi@chromium.org,behdad@chromium.org,drott@chromium.org,eae@chromium.org,jshin@chromium.org,bungeman@chromium.org Bug: 945855, 944346 Change-Id: I632436a98f9d3fd5de96d71a326c3ec4922af758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540002 Commit-Queue: Ben Wagner <bungeman@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#644790}
-
Stefan Zager authored
Because PageWidgetDelegate::Animate can run arbitrary script, it's possible that a LocalFrameView could call Dispose() -- and delete its LocalFrameUkmAggregator -- while there is a UKM measurement in progress. By making LocalFrameUkmAggregator ref-counted, instances of ScopedUkmHierarchicalTimer can keep it alive while a measurement is in progress. BUG=943500 R=schenney@chromium.org Change-Id: Icc1346db664583a4e5686c2f15a9f261305fb5cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539182Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#644789}
-
Yuwei Huang authored
This CL renames a few files in grpc_support. This makes it easier to track changes in cl 1540360. Bug: 927962 Change-Id: I492926e8fd92310b8b7fdf671457f001a1585556 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539631 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#644788}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8f22a28e30b0..afa61c94e50e git log 8f22a28e30b0..afa61c94e50e --date=short --no-merges --format='%ad %ae %s' 2019-03-27 crodbro@webrtc.org Avoid calling OnRoundTripTimeUpdate with invalid RTTs. Created with: gclient setdep -r src/third_party/webrtc@afa61c94e50e The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:none TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I25e7f82a149720c4b15a46c09e34430199e88704 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541597Reviewed-by:
-
Thomas Tangl authored
|prefs::kContextualSearchEnabled| is added to the list of synced prefs that are observed during settings opt-in. Bug: 933647 Change-Id: I3db775f98127286971cd5a1e3b2d5ddeee583959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538530Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#644786}
-
Chris Cunningham authored
Meant to do this earlier in: https://chromium-review.googlesource.com/c/chromium/src/+/1534711 With this final step we can get the pieces we need to pass from WMPI to the VideoDecodeStatsReporter. Bug: 907909 Change-Id: Ic0c4055071435b273e80aba9bf4bdde03c139d7d TBR: sandersd@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539904 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#644785}
-
Brian White authored
This reverts commit b1ef7206. Reason for revert: The is causing crashes on Linux CFI bot: https://ci.chromium.org/p/chromium/builders/ci/Linux%20CFI/13126 Original change's description: > Enable DownloadDBForNewDownloads by default > > BUG=842245 > > Change-Id: Ieea0d3bcaef8f8f47a32c74845c056c452ca7f8c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532922 > Commit-Queue: Min Qin <qinmin@chromium.org> > Reviewed-by: Xing Liu <xingliu@chromium.org> > Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#644406} TBR=qinmin@chromium.org,shaktisahu@chromium.org,xingliu@chromium.org Change-Id: I8a9550ab957e439b3a40b9caf38205d902354075 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 842245 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541660Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#644784}
-
Christian Fremerey authored
When starting video capture with a device that is rotated, e.g. a convertible in portrait orientation, the rotation of the captured video intermittently (most of the time) comes out wrong. The root cause is that rotation events are ignored before capturing is started but may end up arriving before. This CL fixes this by storing the rotation in case rotation events are received while capturing is not started. Bug: 944215 Change-Id: I1346772341044c92be754d11d17a519397598df9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540459Reviewed-by:
Ricky Liang <jcliang@chromium.org> Reviewed-by:
Sheng-hao Tsao <shenghao@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#644783}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c476e5da4fef..0ed4c3763465 git log c476e5da4fef..0ed4c3763465 --date=short --no-merges --format='%ad %ae %s' 2019-03-27 fmalita@chromium.org [skottie] Fix handling of hidden shapes and layers Created with: gclient setdep -r src/third_party/skia@0ed4c3763465 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: I5928d58cc2a57a414b3982385c000653ab3b117c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541577Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b5a48042d7f2..5c4690c2f4e8 git log b5a48042d7f2..5c4690c2f4e8 --date=short --no-merges --format='%ad %ae %s' 2019-03-27 lannm@chromium.org Filter out Legacy-Code-Review=-1 Gerrit changes from CQ 2019-03-27 evanhernandez@chromium.org chromeos_config: Do not run BranchUtilTestStage. Created with: gclient setdep -r src/third_party/chromite@5c4690c2f4e8 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I0c9a691458a85ffc341d058d89c6e889323a13b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541596Reviewed-by:
-
chrome://flagsJonathan Backer authored
Change-Id: I7da6fbcf9e935c88057e71190089883a4cb18fe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539875 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#644780}
-
Olivier Robin authored
These methods can be calle asynchronously. It is necessary to check that the web_frame was not destroyed before processing it. Bug: 942427 Change-Id: Icc46dae9193c4fd9ef9612ce47239bd50eef33d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538194 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#644779}
-
David 'Digit' Turner authored
The crazy linker used to parse /proc/self/exe and /proc/self/maps in order to find the value of the process-global |r_debug| variable maintained by the system linker. Unfortunately, this operation is flaky on Android L (see attached bug for details). In the end this prevents Crashpad from generating valid stack traces, because it will not see libchrome.so in the current process when this happens. This CL uses getauxval() instead to get the same address, since this function is available from the C library starting with API level 18 / Android KitKat. + Add new unit-test to check that RDebug::GetAddress() works correctly. BUG=946380 R=pasko@chromium.org, agrieve@chromium.org, jperaza@chromium.org Change-Id: I90212f94206fda05be515bdbd6fc7f1285f041a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541117Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#644778}
-
Leonard Grey authored
This was broken by the GM2 style update. Since these constants are only used in the infobar, we can unconditionally use dark mode style. Bug: 940900 Change-Id: I9da25d945da94e72c4e0c7d8a08dfd8ca021196c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539125 Auto-Submit: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#644777}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ffaffb18986d..58cb9bcb7e0a Created with: gclient setdep -r src-internal@58cb9bcb7e0a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=robertocn@chromium.org,noel@chromium.org,eirage@chromium.org Change-Id: Ic7e081131f497d8ef2c59d831076cd1309c1ef8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541576Reviewed-by:
-
Richard Townsend authored
This reverts commit 7ff0fd56. Reason for revert: Caused timeouts on chrome's perf builders. Original change's description: > benchmark: add basic partition allocator coverage > > Intention of this benchmark is to collect profiling data of hotspots > within the partition allocator and a performance baseline for > work on thread-local caches. > > Bug: 907444 > Change-Id: Ia112fad5e23dfdf47f44077ed3ab776b13ddf0b3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1350878 > Commit-Queue: Richard Townsend <richard.townsend@arm.com> > Reviewed-by: François Doray <fdoray@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#642530} TBR=fdoray@chromium.org,haraken@chromium.org,richard.townsend@arm.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 907444 Bug: 946034 Change-Id: I8ba16efc8aa749b2c72592a659fcbc6cd10bb4ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539980 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#644775}
-
Karolina Soltys authored
All of it is purely mechanical except for chrome/android/javatests/src/org/chromium/chrome/browser/fullscreen/FullscreenManagerTestUtils.java Bug: 863341 Change-Id: I3f352e9f02a49bc894f2d9a917a8aa4332c8e0a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532016Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Karolina Soltys <ksolt@chromium.org> Cr-Commit-Position: refs/heads/master@{#644774}
-
Tanja Gornak authored
Currently messages are not persisted for the FCM invalidations, because the sender id for which invaliations are marked lazy mismatches the id received in the incoming messages. In addition, messages are replayed before app handler is knows, so they aren't passed to it. This patch implements the fix. Bug: 882887, 944484 Change-Id: I6f53d65488f196f76dedc0b8ae23f9889d5c13a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1533875Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#644773}
-
Alessio Bazzica authored
NOTRY=True Bug: webrtc:9577 Change-Id: I6c045db1ccb087634277fa5a2d444cbd6bfdde45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541182 Commit-Queue: Ale Bzk <alessiob@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#644772}
-
Brian Osman authored
Skia's NullGL interface is deprecated, and soon to be removed. For some unit tests in other modules, the Mock GrContext is a drop-in replacement. Here, we end up testing the same path in PaintCanvasVideoRenderer, but with slightly different behavior inside Skia. Ultimately, NewSkImageFromVideoFrameNative returns nullptr. Previously, this was due to the context being abandoned. Now, it fails because the Mock context doesn't support adopted textures at all. (The new code would test the same code path even without the abandonContext call). See also: https://cs.chromium.org/chromium/src/media/renderers/paint_canvas_video_renderer.cc?l=239 Change-Id: Ida0b22c7c60fc5217d5931b79f44a61cc80992b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540357 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#644771}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2b058ca0584c..bc2a48ba8635 git log 2b058ca0584c..bc2a48ba8635 --date=short --no-merges --format='%ad %ae %s' 2019-03-27 perezju@chromium.org [tracing] Restrict writing unstructured trace data Created with: gclient setdep -r src/third_party/catapult@bc2a48ba8635 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:928278 TBR=sadrul@chromium.org Change-Id: I8e6796bc485064108e410bce22f32c0ae8e20ad4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541337Reviewed-by:
-
Noel Gordon authored
Text diff --- C:\b\s\w\iomudyw9\layout-test-results\paint/invalidation/scroll/scrollbar-damage-and-full-viewport-repaint-expected.txt +++ C:\b\s\w\iomudyw9\layout-test-results\paint/invalidation/scroll/scrollbar-damage-and-full-viewport-repaint-actual.txt @@ -4,11 +4,21 @@ "name": "LayoutView #document", "bounds": [1000, 600], "drawsContent": false, + "backgroundColor": "#FFFFFF" + }, + { + "name": "Scrolling Layer", + "bounds": [1000, 600], + "drawsContent": false + }, + { + "name": "Scrolling Contents Layer", + "bounds": [1000, 600], "contentsOpaque": true, "backgroundColor": "#FFFFFF", "paintInvalidations": [ { - "object": "LayoutBlockFlow DIV id='container'", + "object": "HorizontalScrollbar", "rect": [1, 236, 185, 15], "reason": "scroll control" } Tbr: wangxianzhu@chromium.org No-try: true Bug: 919789 Change-Id: Id2bbe29d28fae1b72f64b1deed5649e4ee5ece3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541616Reviewed-by:Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#644769}
-
Noel Gordon authored
Tbr: foolip@ Bug: 626703 Change-Id: Iea612e6bed06bea1799d51b59c770d230b1dfd44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541396Reviewed-by:
-
arthursonzogni authored
This test is still flaky. Error: ``` Value of: trace_receiver_helper.TraceHasMatchingString("TestEarlyEvent") Actual: false Stack trace: ``` Expected: true Tbr: oysteine@chromium.org Bug: 1534867 Change-Id: Id5c1111d1e5dc8dfc97b09c835caae24457bf28c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541179Reviewed-by:Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#644767}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c8ba8b240967..8f22a28e30b0 git log c8ba8b240967..8f22a28e30b0 --date=short --no-merges --format='%ad %ae %s' 2019-03-27 phensman@webrtc.org Check render size instead of frame size. 2019-03-27 brandtr@webrtc.org Change VideoCodecTestStats API. Created with: gclient setdep -r src/third_party/webrtc@8f22a28e30b0 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I477b4d0f25c1026e1064eb3ea71d4db7cf931a34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541336Reviewed-by:
-
Justin Cohen authored
Bug: 930123, 943569 Change-Id: If434286ed7188e83966ff97acb5f441bbc70ae4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540103Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#644765}
-
Brian Salomon authored
Bug: skia:8193 Change-Id: Ic261aaebaae07ddc5c710f422f2a7bdfa3cd611d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536814Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Brian Salomon <bsalomon@google.com> Cr-Commit-Position: refs/heads/master@{#644764}
-
Javier Ernesto Flores Robles authored
TBR=rohitrao@chromium.org,kkhorimoto@chromium.org Bug: 946461 Change-Id: Id255939ef535ef51d0c7807de8b5fda7b9b809e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541181Reviewed-by:
-
