GitLab

After a test times out during a ChromeDriver command, trigger a Chrome
crash and a minidump collection for troubleshooting. This is not
available on tests connecting to a remote browser, or when running on
Android.


Bug: 1045241
Change-Id: I3cb82d95875d0f58a4acee69d249a92801b8024b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032238Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Tricia Crichton <triciac@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740311}

Bug: 1003888
Change-Id: Ic968514bdfbe23bbf4a0455cb5cf760d256b4e81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042091
Commit-Queue: Roman Aleksandrov <raleksandrov@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740310}

Add RecordUserMetricsAction on the content.mojom.RendererHost interface
to replace the legacy IPC message.

Bug: 1047458
Change-Id: Ie2009fd7a0c0ca58b68e71ba278097f5f1b0b97b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047064
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740309}

This reverts commit 1c4a6244.

Reason for revert: suspect it cause some failures in CrOS tests:
https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/3017
AutoLaunchedKioskTest.CrashRestore
CryptohomeKeyDelegateServiceProviderTest.SignatureErrorKeyRemoved
CryptohomeKeyDelegateServiceProviderTest.SignatureErrorUnsupportedAlgorithm
CryptohomeKeyDelegateServiceProviderTest.SignatureErrorWhileSigning
CryptohomeKeyDelegateServiceProviderTest.SignatureSuccessSha1
CryptohomeKeyDelegateServiceProviderTest.SignatureSuccessSha256
KioskEnterpriseTest.EnterpriseKioskApp
SigninExtensionsDeviceCloudPolicyBrowserTest.ManagedStorage

Original change's description:
> Reland "[Extensions] Enable content verification for new policy non-webstore installs"
> 
> This is a reland of bf17bc25
> 
> Original change's description:
> > [Extensions] Enable content verification for new policy non-webstore installs
> > 
> > After this commit:
> >  * For non-webstore policy force-installed extensions, write
> >  computed_hashes.json on installation.
> >  * If (according to computed_hashes.json) extension's resource is
> >  detected corrupted, this extension will be disabled and  reinstalled.
> >  This applies only for policy force-installed extensions, and for
> >  webstore extensions it worked before this commit.
> > 
> > This commit will NOT change behavior for already-installed extension.
> > So, if some (non-webstore) extension was already corrupted, it will not
> > be detected. The reason for this is that there is no source of truth for
> > resources of already-installed non-webstore extension. It's possible to
> > reinstall all previously-installed non-webstore extensions, but it's out
> > of scope of this commit. See the bug for more details.
> > 
> > Bug: 958794
> > Change-Id: Ie9c014e7fd998f4eae6e852a59bd692d57ff7d8c
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012964
> > Commit-Queue: Oleg Davydov <burunduk@chromium.org>
> > Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
> > Reviewed-by: Sergey Poromov <poromov@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#737034}
> 
> Bug: 958794
> Change-Id: I90d2c398712b1c716f5299a199c72e12e42b0c8f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033160
> Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
> Reviewed-by: Sergey Poromov <poromov@chromium.org>
> Commit-Queue: Oleg Davydov <burunduk@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#740269}

TBR=lazyboy@chromium.org,poromov@chromium.org,burunduk@chromium.org

Change-Id: I16e79207100000f77b7e3c4fa26ca6908b9785ea
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 958794
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050686Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740308}

This reverts commit 0c502205.

Reason for revert: Still flaky, not sure why yet!

Original change's description:
> Reland "Add browser tests for Reader Mode omnibox icon."
> 
> This reverts commit 6e766760.
> Flakes should be taken care of by adding an observer to
> wait for distillability results before asserting state.
> 
> Bug: 992074
> Change-Id: I4dfc86dbd78fd812961194d9ea7e58baea7ff478
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042398
> Commit-Queue: Katie Dektar <katie@chromium.org>
> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#739946}

TBR=ellyjones@chromium.org,dmazzoni@chromium.org,katie@chromium.org

Change-Id: I391f5b9fedcc3620301378eb5a084696dda9a890
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1049344
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049909Reviewed-by: Katie Dektar <katie@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740307}

This reverts commit e2beb407.

Reason for revert: The original change caused webkit_layout_tests
failures due to a change in qemu_target.QemuTarget() arguments.
See crbug.com/1050935

Original change's description:
> [fuchsia] add option to retry test environment setup steps.
>
> Also adds debug logging for qemu-img invocations in the qemu target.
>
> Bug: 1046861
> Change-Id: Ia37a9701391e3437cf03f1f041ddca671d5e0770
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023387
> Commit-Queue: Stephen Roe <steveroe@google.com>
> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#740058}

TBR=kmarshall@chromium.org,sergeyu@chromium.org,steveroe@google.com,chonggu@google.com

Change-Id: I62ad6c4e708dcf32556fd6b5f6b4d1d6145640c2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1046861
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050606
Auto-Submit: Stephen Roe <steveroe@google.com>
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740306}

This removes merge session stage for auth context preparation once it
is deprecated and source of extra failures.

TEST=Locally
BUG=b:148670963

Change-Id: I61fafb236a83cf2b9e9f1f65cd8ae029c734fe3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048109Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Kush Sinha <sinhak@chromium.org>
Commit-Queue: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740305}

This is an implementation of the pattern proposal for Assistant Autofill
fallback handler.

Note that this does not solve the full range of issues we might have
with phone numbers. This works for static pages, where we know what the
expected input-format is.

This CL gives more flexibility in how to combine the values as an
expression. All available information is automatically extracted and
exposed for use.

This should go together with the backend CL: cl/293790701

Bug: b/147755494
Bug: b/147281090
Change-Id: I4f5e03fde7001767df92ba869d990b1804d421fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030887
Commit-Queue: Sandro Maggi <sandromaggi@google.com>
Reviewed-by: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#740304}

Bug: 947004
Change-Id: I827370184a0d5a1f152717ee3b0030803c59393c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050263
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Emilio Cobos Álvarez <emilio@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740303}

This CL removes an un-used function in PaintRenderingContext2d

Bug: None
Change-Id: Idb16af53d2f63132576bff64973f39c6d91459af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050604Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740302}

Bug: 1045064
Change-Id: Ie1d98f575ce365471b027a79b768228d9308c37b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044911Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740301}

This is a reland of 6f1a4faf

Original change's description:
> Payment: Drop AndroidPayTokenization IDL dictionary
> 
> Bug: 839389
> Change-Id: Iacb7a04b9889ba7cf7daf652699e996554a9ee85
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045298
> Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
> Reviewed-by: Danyao Wang <danyao@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#740125}

Bug: 839389
Change-Id: I5feaaab1e05b14613c92a7ac30bf7c5ad069eead
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049147
Auto-Submit: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Danyao Wang <danyao@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740300}

Bug: 993920

Change-Id: I365f256909fb60ed976e26576d48e2589acf9f37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047408Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740299}

Revert "Undo the exposing of HaTS-Friendly-Settings flags", as a Finch config (cl/294428725) has been devised and tested to ensure that the two forced-on groups work.

This reverts commit 3b9c94b7.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Undo the exposing of HaTS-Friendly-Settings flags
> 
> Bug: 1045348
> Change-Id: I5c5950cb53e424d756d1de98fea122d6d75815e7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2046131
> Commit-Queue: Huanzhong Huang <huanzhong@chromium.org>
> Reviewed-by: Martin Šrámek <msramek@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#740253}

TBR=msramek@chromium.org,huanzhong@chromium.org

Change-Id: I1dc3f2b6d6dd01a56f9898430af595ca9c3aee5b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1045348
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050684Reviewed-by: Huanzhong Huang <huanzhong@chromium.org>
Commit-Queue: Huanzhong Huang <huanzhong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740298}

This reverts commit 472b61b0.

Reason for revert: This CL probably caused the failures of CrSettingsPeoplePageSyncAccountControlTest.All
The first failed build: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/86751?blamelist=1#blamelist-tab

Test 'CrSettingsPeoplePageSyncAccountControlTest.All' completed with the following status(es): 'FAILURE','FAILURE'

Test 'CrSettingsPeoplePageSyncAccountControlTest.All' had the following logs when run:

================================================================================

[ RUN      ] CrSettingsPeoplePageSyncAccountControlTest.All
[18619:18619:0210/184737.873886:10428715594:ERROR:edid_parser.cc(102)] Too short EDID data: manufacturer id
[18619:18619:0210/184739.304554:INFO:content_main_runner_impl.cc(948)] Chrome is running in full browser mode.
[18619:18754:0210/184741.088128:ERROR:object_proxy.cc(632)] Failed to call method: org.freedesktop.DBus.Properties.Get: object_path= /org/freedesktop/UPower: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.UPower was not provided by any .service files
[18619:18754:0210/184741.088268:WARNING:property.cc(144)] DaemonVersion: GetAndBlock: failed.
[18619:18754:0210/184741.088784:ERROR:object_proxy.cc(632)] Failed to call method: org.freedesktop.UPower.GetDisplayDevice: object_path= /org/freedesktop/UPower: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.UPower was not provided by any .service files
[18619:18754:0210/184741.089292:ERROR:object_proxy.cc(632)] Failed to call method: org.freedesktop.UPower.EnumerateDevices: object_path= /org/freedesktop/UPower: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.UPower was not provided by any .service files
[18619:18619:0210/184741.509719:WARNING:gaia_auth_fetcher.cc(989)] Could not reach Google Accounts servers: errno -11
[18619:18619:0210/184742.399987:WARNING:gaia_auth_fetcher.cc(989)] Could not reach Google Accounts servers: errno -11
[18619:18619:0210/184742.896965:WARNING:CONSOLE(0)] "HTML Imports is deprecated and will be removed in M80, around February 2020. Please use ES modules instead. See https://www.chromestatus.com/features/5144752345317376 and https://developers.google.com/web/updates/2019/07/web-components-time-to-upgrade for more details.", source:  (0)
[18619:18619:0210/184744.965914:WARNING:gaia_auth_fetcher.cc(989)] Could not reach Google Accounts servers: errno -11
[18619:18619:0210/184746.311487:INFO:CONSOLE(1045)] "Running TestCase CrSettingsPeoplePageSyncAccountControlTest.All", source: file:///b/s/w/ir/chrome/test/data/webui/test_api.js (1045)
[18619:18619:0210/184748.205791:ERROR:CONSOLE(49)] "Mocha test failed: SyncAccountControl not signed in and no stored accounts
Error: Uncaught TypeError: this.syncBrowserProxy_.turnOnSync is not a function (chrome://settings/people_page/sync_account_control.js:413)
    at Context.<anonymous> (file:///b/s/w/ir/chrome/test/data/webui/settings/sync_account_control_test.js:123:34)
", source: file:///b/s/w/ir/chrome/test/data/webui/mocha_adapter.js (49)
[18619:18619:0210/184748.207968:ERROR:CONSOLE(413)] "Uncaught TypeError: this.syncBrowserProxy_.turnOnSync is not a function", source: chrome://settings/people_page/sync_account_control.js (413)
[18619:18619:0210/184749.544505:ERROR:CONSOLE(49)] "Mocha test failed: SyncAccountControl "before each" hook in "SyncAccountControl"
TypeError: Cannot read property 'call' of undefined
", source: file:///b/s/w/ir/chrome/test/data/webui/mocha_adapter.js (49)
[18619:18619:0210/184749.546775:ERROR:CONSOLE(6093)] "Uncaught TypeError: Cannot read property 'isPending' of undefined", source: file:///b/s/w/ir/third_party/mocha/mocha.js (6093)
[18619:18619:0210/184753.193344:WARNING:gaia_auth_fetcher.cc(989)] Could not reach Google Accounts servers: errno -11
[18619:18619:0210/184815.096606:WARNING:gaia_auth_fetcher.cc(989)] Could not reach Google Accounts servers: errno -11
../../base/test/scoped_run_loop_timeout.cc:26: Failure
Failed
RunLoop::Run() timed out.
Google Test trace:
../../chrome/browser/ui/webui/web_ui_test_handler.cc:94: WebUITestHandler::WaitForResult
Stack trace:
#0 0x560f6d110b87 base::test::ScopedRunLoopTimeout::ScopedRunLoopTimeout()::$_0::operator()()
#1 0x560f6d110b1d base::internal::FunctorTraits<>::Invoke<>()
#2 0x560f6d110add base::internal::InvokeHelper<>::MakeItSo<>()
#3 0x560f6d110ab1 _ZN4base8internal7InvokerINS0_9BindStateIZNS_4test20ScopedRunLoopTimeoutC1ENS_9TimeDeltaEE3$_0JEEEFvvEE7RunImplIRKS6_RKNSt4__Cr5tupleIJEEEJEEEvOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE
#4 0x560f6d110a82 base::internal::Invoker<>::Run()
#5 0x7f614f3c0d27 _ZNO4base12OnceCallbackIFvvEE3RunEv
#6 0x7f614f506a5a base::(anonymous namespace)::OnRunLoopTimeout()
#7 0x7f614f50a677 base::internal::FunctorTraits<>::Invoke<>()
#8 0x7f614f50a547 base::internal::InvokeHelper<>::MakeItSo<>()
#9 0x7f614f50a4d3 _ZN4base8internal7InvokerINS0_9BindStateIPFvPNS_7RunLoopENS_12OnceCallbackIFvvEEEEJNS0_17UnretainedWrapperIS3_EENS_17RepeatingCallbackIS6_EEEEES6_E7RunImplIS9_NSt4__Cr5tupleIJSB_SD_EEEJLm0ELm1EEEEvOT_OT0_NSH_16integer_sequenceImJXspT1_EEEE
#10 0x7f614f50a467 base::internal::Invoker<>::RunOnce()
#11 0x7f614f3c0d27 _ZNO4base12OnceCallbackIFvvEE3RunEv
#12 0x7f614f50abc7 base::internal::CancelableCallbackImpl<>::ForwardOnce<>()
#13 0x7f614f50b035 base::internal::FunctorTraits<>::Invoke<>()
#14 0x7f614f50af07 base::internal::InvokeHelper<>::MakeItSo<>()
#15 0x7f614f50ae72 _ZN4base8internal7InvokerINS0_9BindStateIMNS0_22CancelableCallbackImplINS_12OnceCallbackIFvvEEEEEFvvEJNS_7WeakPtrIS7_EEEEES5_E7RunImplIS9_NSt4__Cr5tupleIJSB_EEEJLm0EEEEvOT_OT0_NSF_16integer_sequenceImJXspT1_EEEE
#16 0x7f614f50ae27 base::internal::Invoker<>::RunOnce()
#17 0x7f614f3c0d27 _ZNO4base12OnceCallbackIFvvEE3RunEv
#18 0x7f614f57a35d base::TaskAnnotator::RunTask()
#19 0x7f614f5c164a base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl()
#20 0x7f614f5c0dab base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoSomeWork()
#21 0x7f614f5c199c base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoSomeWork()
#22 0x7f614f46e364 base::MessagePumpGlib::HandleDispatch()
#23 0x7f614f46eea1 base::(anonymous namespace)::WorkSourceDispatch()
#24 0x7f611b332197 g_main_context_dispatch
#25 0x7f611b3323f0 (/lib/x86_64-linux-gnu/libglib-2.0.so.0.4800.2+0x4a3ef)
#26 0x7f611b33249c g_main_context_iteration
#27 0x7f614f46e476 base::MessagePumpGlib::Run()
#28 0x7f614f5c257d base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run()
#29 0x7f614f506598 base::RunLoop::Run()
#30 0x560f6e4d628d content::RunThisRunLoop()
#31 0x560f721a865f WebUITestHandler::WaitForResult()
#32 0x560f721a821f WebUITestHandler::RunJavaScriptTestWithResult()
#33 0x560f6d0f109d BaseWebUIBrowserTest::RunJavascriptUsingHandler()
#34 0x560f6d0f1646 BaseWebUIBrowserTest::RunJavascriptAsyncTest()
#35 0x560f6d0f153d BaseWebUIBrowserTest::RunJavascriptTestF()
#36 0x560f6a24dcb6 CrSettingsPeoplePageSyncAccountControlTest_All_Test::RunTestOnMainThread()
#37 0x560f6e41b20d content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#38 0x560f6e41f1c3 base::internal::FunctorTraits<>::Invoke<>()
#39 0x560f6e41f131 base::internal::InvokeHelper<>::MakeItSo<>()
#40 0x560f6e41f0d7 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIS6_NSt4__Cr5tupleIJS8_EEEJLm0EEEEvOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE
#41 0x560f6e41f087 base::internal::Invoker<>::RunOnce()
#42 0x560f67c6a337 _ZNO4base12OnceCallbackIFvvEE3RunEv
#43 0x560f6d247b0b ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
#44 0x560f6d24677d ChromeBrowserMainParts::PreMainMessageLoopRun()
#45 0x7f61436308ce content::BrowserMainLoop::PreMainMessageLoopRun()
#46 0x7f614363c163 base::internal::FunctorTraits<>::Invoke<>()
#47 0x7f614363c071 base::internal::InvokeHelper<>::MakeItSo<>()
#48 0x7f614363bff7 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE7RunImplIS6_NSt4__Cr5tupleIJS8_EEEJLm0EEEEiOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE
#49 0x7f614363bfa7 base::internal::Invoker<>::RunOnce()
#50 0x7f61439f3967 _ZNO4base12OnceCallbackIFivEE3RunEv
#51 0x7f614484c7f9 content::StartupTaskRunner::RunAllTasksNow()
#52 0x7f614362f0cb content::BrowserMainLoop::CreateStartupTasks()
#53 0x7f6143640116 content::BrowserMainRunnerImpl::Initialize()
#54 0x7f614362bb64 content::BrowserMain()
#55 0x7f61458a2554 content::RunBrowserProcessMain()
#56 0x7f61458a3bab content::ContentMainRunnerImpl::RunServiceManager()
#57 0x7f61458a34f5 content::ContentMainRunnerImpl::Run()
#58 0x7f614589eda8 content::ContentServiceManagerMainDelegate::RunEmbedderProcess()
#59 0x7f611631c599 service_manager::Main()
#60 0x7f61458a1f70 content::ContentMain()
#61 0x560f6e41acbe content::BrowserTestBase::SetUp()
#62 0x560f6d0deef1 InProcessBrowserTest::SetUp()
#63 0x560f6a4d3074 testing::internal::HandleSehExceptionsInMethodIfSupported<>()
#64 0x560f6a4c47b2 testing::internal::HandleExceptionsInMethodIfSupported<>()

Original change's description:
> cros: Update sync disconnect dialog for SplitSettingsSync
> 
> Browser settings for sync uses a "sign out" dialog to handle when the
> user clicks "Turn off". Depending on the use case the dialog title and
> buttons may say "Turn off" or "Sign out". Update the strings for
> SplitSettingsSync to use "Turn off".
> 
> Because Chrome OS users cannot sign out, wire the dialog's "Turn off"
> button to a new method in PeopleHandler. The existing code path for
> sign out/disconnect assumes DICE, which Chrome OS does not support.
> 
> Bug: 1050677
> Test: manual, button labels are different (and match Linux)
> Change-Id: If8933bb651343d757f04f8b2a5d3d11087610c9d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047765
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Commit-Queue: James Cook <jamescook@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#740068}

TBR=jamescook@chromium.org,xiyuan@chromium.org

Change-Id: I4e6468b9388d7cc887dd358bed9ccd3c0d4714a2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1050677
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050315Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740297}

This reverts commit 5bf31665.

Reason for revert: this CL probably caused GmockCallbackSupportTest.RunOnceClosureValueMultipleCall failures. 
The first failed build https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome/3283

Test 'GmockCallbackSupportTest.RunOnceClosureValueMultipleCall' completed with the following status(es): 'FAILURE','FAILURE'

Test 'GmockCallbackSupportTest.RunOnceClosureValueMultipleCall' had the following logs when run:

================================================================================

[ RUN      ] GmockCallbackSupportTest.RunOnceClosureValueMultipleCall
../../base/test/gmock_callback_support_unittest.cc:174: Failure
Death test: check.Call()
    Result: died but not with expected error.
  Expected: contains regular expression "copyable_cb->data"
Actual msg:
[  DEATH   ]
Stack trace:
#0 0x57c25d527cd4 base::test::GmockCallbackSupportTest_RunOnceClosureValueMultipleCall_Test::TestBody()

[  FAILED  ] GmockCallbackSupportTest.RunOnceClosureValueMultipleCall (26 ms)
[ RUN      ] GmockCallbackSupportTest.RunOnceClosureValueMultipleCall
../../base/test/gmock_callback_support_unittest.cc:174: Failure
Death test: check.Call()
    Result: died but not with expected error.
  Expected: contains regular expression "copyable_cb->data"
Actual msg:
[  DEATH   ]
Stack trace:
#0 0x58a33c3f9cd4 base::test::GmockCallbackSupportTest_RunOnceClosureValueMultipleCall_Test::TestBody()

[  FAILED  ] GmockCallbackSupportTest.RunOnceClosureValueMultipleCall (29 ms)

Original change's description:
> Fix RunOnceClosure(OnceClosure) to take a OnceClosure by value
> 
> Bug: None
> Change-Id: Iddf32bab6d0ab7ca195db02cc24d31e669a49051
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037184
> Commit-Queue: Anand Mistry <amistry@chromium.org>
> Reviewed-by: kylechar <kylechar@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#740079}

TBR=amistry@chromium.org,kylechar@chromium.org

Change-Id: I913831e1a782e9e684417582b5a8503c2f9a9fd2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050491Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740296}

Using wpt-import in Chromium 0c336bd0.
With Chromium commits locally applied on WPT:
5579aad0 "SharedWorker: Name shared workers identically in credentials mode WPT"
822dbfeb "[LayoutNG] Clip when hit-testing floats inside clipped containers."


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: Id4c57a34b633ff4193cd102b99ec8328f5428dd9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050130Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#740295}

This reverts commit d709d76f.

Reason for revert: The culprit cannot cause that failure. Relanding...

Original change's description:
> Revert "Fix flaky SingleSampleMetricsFactoryImpl DCHECK_DEATH test."
> 
> This reverts commit 5381b40a.
> 
> Reason for revert: this CL probably caused GmockCallbackSupportTest.RunOnceClosureValueMultipleCall failures. 
> The first failed build https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome/3283
> 
> Test 'GmockCallbackSupportTest.RunOnceClosureValueMultipleCall' completed with the following status(es): 'FAILURE','FAILURE'
> 
> Test 'GmockCallbackSupportTest.RunOnceClosureValueMultipleCall' had the following logs when run:
> 
> ================================================================================
> 
> [ RUN      ] GmockCallbackSupportTest.RunOnceClosureValueMultipleCall
> ../../base/test/gmock_callback_support_unittest.cc:174: Failure
> Death test: check.Call()
>     Result: died but not with expected error.
>   Expected: contains regular expression "copyable_cb->data"
> Actual msg:
> [  DEATH   ]
> Stack trace:
> #0 0x57c25d527cd4 base::test::GmockCallbackSupportTest_RunOnceClosureValueMultipleCall_Test::TestBody()
> 
> [  FAILED  ] GmockCallbackSupportTest.RunOnceClosureValueMultipleCall (26 ms)
> [ RUN      ] GmockCallbackSupportTest.RunOnceClosureValueMultipleCall
> ../../base/test/gmock_callback_support_unittest.cc:174: Failure
> Death test: check.Call()
>     Result: died but not with expected error.
>   Expected: contains regular expression "copyable_cb->data"
> Actual msg:
> [  DEATH   ]
> Stack trace:
> #0 0x58a33c3f9cd4 base::test::GmockCallbackSupportTest_RunOnceClosureValueMultipleCall_Test::TestBody()
> 
> [  FAILED  ] GmockCallbackSupportTest.RunOnceClosureValueMultipleCall (29 ms)
> 
> 
> Original change's description:
> > Fix flaky SingleSampleMetricsFactoryImpl DCHECK_DEATH test.
> > 
> > Test was missing the FLAGS_gtest_death_test_style = "threadsafe"
> > declaration that's necessary for multi-threaded death tests. See
> > https://github.com/google/googletest/blob/master/googletest/docs/advanced.md#death-tests-and-threads
> > 
> > R=​isherman
> > 
> > Fixed: 1009360
> > Change-Id: I795e055c9fdfda727853ce52c1278dd430cbfdef
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049023
> > Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
> > Commit-Queue: Ilya Sherman <isherman@chromium.org>
> > Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
> > Reviewed-by: Ilya Sherman <isherman@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#740119}
> 
> TBR=dalecurtis@chromium.org,isherman@chromium.org
> 
> Change-Id: I06415066abd98925dc7dcaac961e666ca68d6864
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050365
> Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#740270}

TBR=dalecurtis@chromium.org,isherman@chromium.org,kolos@chromium.org

Change-Id: I231b0c108d09f35a59216d08b401a28fbf2b4d31
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050271Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740294}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/74cb8b70d83f..eecaa7adff55

git log 74cb8b70d83f..eecaa7adff55 --date=short --first-parent --format='%ad %ae %s'
2020-02-11 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS.

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@eecaa7adff55

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Ib229be3cd45164f889371ac3a120a85f1349271a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050553Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#740293}

This CL merges AccountIdProvider into AccountManagerFacade and renames
the AccountIdProvider.getAccountId to
AccountManagerFacade.getAccountGaiaId.

Bug: 914920
Change-Id: Ie2288b9f0520de387b9c65e90cdac8e1f4bc5928
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027790Reviewed-by: Alex Ilin <alexilin@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Tanmoy Mollik <triploblastic@chromium.org>
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740292}

Python 2 hasattr() returns False if any exception is thrown getattr().
Python 3 hasattr() returns False only if AttributeError is thrown during getattr(), other exceptions bubble up.
This changes Get() of ReferenceKind to raise AttributeError if a key doesn't exist. Works on both Python 2 and 3.

Traceback (most recent call last):
  File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 556, in <module>
    sys.exit(main())
  File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 551, in main
    return args.func(args, remaining_args)
  File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 267, in _Generate
    processor._GenerateModule(args, remaining_args, generator_modules,
  File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 238, in _GenerateModule
    generator.GenerateFiles(filtered_args)
  File "C:\Google\chromium\src\mojo\public\tools\bindings\generators\mojom_cpp_generator.py", line 474, in GenerateFiles
    self.WriteWithComment(self._GenerateModuleHeader(),
  File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\template_expander.py", line 37, in GeneratorInternal
    return ApplyTemplate(args[0], path_to_template, parameters, **kwargs)
  File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\template_expander.py", line 30, in ApplyTemplate
    return template.render(params)
  File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\..\..\..\..\..\..\..\third_party\jinja2\asyncsupport.py", line 76, in render
    return original_render(self, *args, **kwargs)
  File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\..\..\..\..\..\..\..\third_party\jinja2\environment.py", line 1008, in render
    return self.environment.handle_exception(exc_info, True)
  File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\..\..\..\..\..\..\..\third_party\jinja2\environment.py", line 780, in handle_exception
    reraise(exc_type, exc_value, tb)
  File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\..\..\..\..\..\..\..\third_party\jinja2\_compat.py", line 37, in reraise
    raise value.with_traceback(tb)
  File "gen\mojo\public\tools\bindings\cpp_templates.zip\tmpl_4b4c750a11f14c4ee990ca69a07408825b11d62d.py", line 150, in <module>
  File "gen\mojo\public\tools\bindings\cpp_templates.zip\tmpl_099a6a43ff1b4fa6287654d9857c8f4fdf034f1d.py", line 67, in <module>
  File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\..\..\..\..\..\..\..\third_party\jinja2\runtime.py", line 579, in _invoke
    rv = self._func(*arguments)
  File "gen\mojo\public\tools\bindings\cpp_templates.zip\tmpl_e38a8ce638d637e8fae51a29557e063840fe3968.py", line 13, in <module>
  File "C:\Google\chromium\src\mojo\public\tools\bindings\generators\mojom_cpp_generator.py", line 706, in _GetCppWrapperParamType
    cpp_wrapper_type = self._GetCppWrapperType(kind)
  File "C:\Google\chromium\src\mojo\public\tools\bindings\generators\mojom_cpp_generator.py", line 589, in _GetCppWrapperType
    if self._IsTypemappedKind(kind):
  File "C:\Google\chromium\src\mojo\public\tools\bindings\generators\mojom_cpp_generator.py", line 525, in _IsTypemappedKind
    return hasattr(kind, "name") and \
  File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\module.py", line 158, in Get
    return self.shared_definition[name]
KeyError: 'name'

Bug: 941669
Change-Id: I06f9cbdf9792d0739a670cd3404b6c977a3bac6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043880Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Raul Tambre <raul@tambre.ee>
Cr-Commit-Position: refs/heads/master@{#740291}

With goma client 189, this should now work, and it cuts the number
of (internal) compile process executions in half, which on some systems
helps a little bit with performance.

If you don't have goma client 189 yet, this will cause every compile
job to fall back to local. It was released ~3am Easter on Feb 5 2020.

Goma should auto-update. You can see your current version in
`cat ~/goma/MANIFEST` / `type c:\src\goma\goma-win64\MANIFEST`
(the VERSION= line).

If it's out-of-date, you can explicitly update with
`~/goma/goma_ctl.py update` / `c:\src\goma\goma-win64\goma_ctl.bat update`

Bug: 1049161, b/148147812
Change-Id: I2769021721d2a767b413243905052d64917d69c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032802Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740290}

Still images are quite fast to decode, in comparison to videos, which
need to be decoded in two phases (first frame and then rest). We should
not hold up still image decoding while video are being processed. This
will make the picker dialog more responsive with mixed content.

Bug: 1029056, 895776
Change-Id: Ida535a273a9aef50fc6f567b0e3300b3299fe769
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031029
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Auto-Submit: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740289}

Switch the native fs usage bubble to use the DialogDelegate
closure callbacks rather than overriding Close/Cancel/Accept.

Bug: 1011446
Change-Id: Iec30886dbe1d53f9d4a40f33eb4082f17f73d68c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047404Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740288}

Older versions of Android implement file locking incorrectly in the
Java standard library: they throw IOException instead of returning null
when the lock is already held by another process. This causes us to
crash when the lock is already held, without attempting to retry or
considering whether we're intending to crash vs warn.

Catch and ignore the exception when it comes from the tryLock call, and
only consider IOException fatal when it's thrown by the RandomAccessFile
constructor.

Bug: 558377
Fixed: 1048982
Change-Id: I66c5665a8e94e2713233b9799db6694ce5bfa077
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050366
Commit-Queue: Richard Coles <torne@chromium.org>
Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org>
Auto-Submit: Richard Coles <torne@chromium.org>
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740287}

This method allows to scroll specific rect into view if needed and
ensure that no scrolling animations run. This ability is required
for browser automation, for example to test user interaction with
specific region of the element.

Bug: 1049173
Change-Id: Ia79a5f45a0e3757f35a1e79603def451e29b13e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044715
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740286}

https://android.googlesource.com/platform/external/perfetto.git/+log/081d18cb9c92..cc2257e06aa7

git log 081d18cb9c92..cc2257e06aa7 --date=short --first-parent --format='%ad %ae %s'
2020-02-11 taylori@google.com Merge "perfetto-ui: Fix selecting second counter"

Created with:
  gclient setdep -r src/third_party/perfetto@cc2257e06aa7

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: Idd033d39b1a7d265331cbcbd359b90bc3a2e68f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050550Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#740285}

This is a followup to https://crrev.com/c/2039190 which added an API
to query the opt-in state.

Actually using any of the new APIs is still left for future CLs.

Bug: 1049141
Change-Id: I3bda91ad80286a070c47465ecbb7ad5677db1126
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039450
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740284}

Change-Id: Ib3b297674c11fd9d3ed71a775b681ba6d2f65fab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041873
Auto-Submit: Oliver Li <olivierli@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Oliver Li <olivierli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740283}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/582021e12e80..d31fdd914bc4


Created with:
  gclient setdep -r src-internal@d31fdd914bc4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: I50bc9cd0fbd2f97fd949026810dd9a31b3f60fb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050546Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#740282}

This is part of moving IndexedDB to live in the storage service.  This
API used by BrowserContext needs to communicate over the
IndexedDBControl interface instead of directly via IndexedDBContext.

Bug: 1015214
Change-Id: I86ce83390f297c8780bfab9c38f393de2c58a888
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047964Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Auto-Submit: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740281}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c05ee8a3ffb4..74cb8b70d83f

git log c05ee8a3ffb4..74cb8b70d83f --date=short --first-parent --format='%ad %ae %s'
2020-02-11 aerotwist@chromium.org Fixes UIString closure annotation

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@74cb8b70d83f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Ie90d92227db497c32a4311831df0d0220a951ca1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050545Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#740280}

This change fully deprecates the |SUGGESTION| type chips that were
rendered in a separate row.

Bug: b/149080863
Change-Id: I5e232c710aac8aa251bf6a573977f557bc0e3f7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033259
Commit-Queue: Sandro Maggi <sandromaggi@google.com>
Reviewed-by: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#740279}

Using wpt-import in Chromium 6c573ee6.
With Chromium commits locally applied on WPT:
5579aad0 "SharedWorker: Name shared workers identically in credentials mode WPT"
822dbfeb "[LayoutNG] Clip when hit-testing floats inside clipped containers."
ca0673ac "Fix line-breaking-replaced-006"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org:
  external/wpt/fetch

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: I3fc1c1c9cfed2605f6aaad7377cbd7bb3f4e3c04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050126Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#740278}

Addresses unbounded memory growth of font_data_table_ in
CSSSegmentedFontFace leading to out of memory situations when animating
variable fonts.

Manually tested observing Chrome's task manager memory consumption on
Linux for a tab running a variable font animation test page. Tab memory
stays around 75MB over a period of 2 minutes vs. growing to around 1.3GB
before.

Bug: 778352
Change-Id: I53b1f5805974d667aec35d6a9358205f5346b63c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032112
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740277}

Change-Id: I15fe2194703605918de6a3253d978e7e14ccae31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2046172
Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org>
Auto-Submit: Denis Kuznetsov [CET] <antrim@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740276}

https://skia.googlesource.com/skia.git/+log/88c3793a4eaa..dc2782c380f6

git log 88c3793a4eaa..dc2782c380f6 --date=short --first-parent --format='%ad %ae %s'
2020-02-11 reed@google.com Update OverdrawColorFilter to clarify how it interprets its input array.
2020-02-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 a8e6a463121b..b40d48a67c93 (10 commits)
2020-02-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader b3b2a4fc756f..196d81774ef8 (1 commits)
2020-02-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 437a856b..32b4892f (392 commits)

Created with:
  gclient setdep -r src/third_party/skia@dc2782c380f6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC stani@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: stani@google.com
Change-Id: Ic700a604e198f5f8614b005df0e7f2fe155fd9d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050543Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#740275}

https://android.googlesource.com/platform/external/perfetto.git/+log/c7b6ede78ab7..081d18cb9c92

git log c7b6ede78ab7..081d18cb9c92 --date=short --first-parent --format='%ad %ae %s'
2020-02-11 taylori@google.com Merge "perfetto-ui: Fix gridlines"

Created with:
  gclient setdep -r src/third_party/perfetto@081d18cb9c92

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I4572597924be5cfc1a591b976ef5094ad371e270
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050544Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#740274}

GetOwnerName() must return unique value for each handler within
the same invalidation service. This is currently not the case for
CloudPolicyInvalidator.

This change documents this contract to avoid further API misuse and
updates TODO for codepath depending on this contract.

Bug: 1020117, 1049591
Change-Id: I7fbda6569bf6837c274be753fee5a472bbe2fff4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049973Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com>
Cr-Commit-Position: refs/heads/master@{#740273}

Bug: v8:10149
Change-Id: I3abaf70fef14307cc40adbc3759b6ec9c84c31d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050484
Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org>
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Auto-Submit: Santiago Aboy Solanes <solanes@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740272}