- 15 Mar, 2018 40 commits
-
-
Eric Seckler authored
Use SoftwareOutputDevice for headless and pass on the full-pipeline flag to the viz process and its DisplayScheduler. Bug: 786067 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ief3a80777cf339b435724410f45ae64686c4beff Reviewed-on: https://chromium-review.googlesource.com/960862 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#543369}
-
Xiyuan Xia authored
Use a token to represent answer card contents since SearchResult data will go through mojo and views::View* will not work. When app list search code is in the same process of its ui, AnswerCardCotnentsRegistry works as a middle man to map token to underlying view. This CL covers this part. When they are in two processes, the token is the embedding token that could be used to embed answer card contents in app list ui. This part will be implemented in a follow-up CL. Bug: 812434 Change-Id: Ic15bb89c40e370bb3c5967f38efa58828be3967f Reviewed-on: https://chromium-review.googlesource.com/957742Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#543368}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3335c7c4..1acdfd58 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ic44c64b75aca382b50a7b54557dee8cd66456f1b Reviewed-on: https://chromium-review.googlesource.com/963715Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#543367}
-
xlai authored
The experimental canvas features have been divided into the following groups of features: - Canvas2dContextLostRestored - Canvas2dScrollPathIntoView - CanvasColorManagement - CanvasHitRegion - CanvasImageSmoothing - CanvasTransformations - ExtendedTextMetrics - ExtendedImageBitmapOptions - ExtraWebGLVideoTextureMetadata - OffscreenCanvas - OffscreenCanvasText TBR=pfeldman@chromium.org Bug: 817381 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Icff1d8aed866ed1f2e09e054755867c437e9de42 Reviewed-on: https://chromium-review.googlesource.com/957646 Commit-Queue: Olivia Lai <xlai@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#543366}
-
Matthew Cary authored
This callback was recently added to the CustomTabs API, but the benchmark tool was not updated and crashes when receiving this unexpected callback. Change-Id: I4288af96791f4ac5087a8a16ad5cb9a25a150b58 Reviewed-on: https://chromium-review.googlesource.com/964323Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#543365}
-
Geoff Lang authored
BUG=749748 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I65841d24748352db302da7e5890bcbb77dd581d2 Reviewed-on: https://chromium-review.googlesource.com/952216Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#543364}
-
Roger Tawa authored
- generate single CAF event per device, for its lifetime - avoid sending RLZ pings too early in the device lifetime - do the above while respecting chromeos privacy guarantees The exact changes are described in the PRD and design doc: https://docs.google.com/document/d/1Q3UnTO9PSKd8oIysOSV7M5mv3x3o8pK3IaV45NL9riM/edit?usp=sharing https://docs.google.com/document/d/1BC9O0fXCEP56T619jZTyuELrMPVO4PFRkvUEHo8dmwk/edit# This change also fixes a bug that did not stop the ShutdownCheck() even after completing an RLZ ping. Bug: 820783 Change-Id: Iec2a017504fa43d7fda2db5c77a1c9de2cacff2a Reviewed-on: https://chromium-review.googlesource.com/959601Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#543363}
-
Alexander Timin authored
Create newly-introduced WorkerSchedulerProxy in DedicatedWorkerThread and plumb it to WorkerScheduler via WebThreadCreationParams. BUG=776416 R=kinuko@chromium.org, haraken@chromium.org Change-Id: I48de4ee3986b1c53dd22c3b9da82ac7bb9a3ee54 Reviewed-on: https://chromium-review.googlesource.com/957046Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#543362}
-
Ian Vollick authored
Previously we would not relayout children if the size changed. This is problematic for children that wish to anchor to their parent. Bug: 821220 Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I3cbc91fd9a4d4d398d8ef3eba5f42b1f577f46f2 Reviewed-on: https://chromium-review.googlesource.com/962972Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#543361}
-
https://webrtc.googlesource.com/src.git/+log/ee205f5bbae6..a12b1d625cc9 $ git log ee205f5bb..a12b1d625 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I88c9dd71b7d5db338a2372f8538e39c5eb26c378 Reviewed-on: https://chromium-review.googlesource.com/963717Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543360}
-
Erik Språng authored
Refactoring CL has now landed: https://webrtc-review.googlesource.com/c/src/+/61781 We can remove tsan suppressions for class names that no longer exist. Bug: webrtc:9012 Change-Id: Idbc4b7fe980811ec0d11e805d6e0def08ec98233 Reviewed-on: https://chromium-review.googlesource.com/964261Reviewed-by:
Alexander Potapenko <glider@chromium.org> Commit-Queue: Alexander Potapenko <glider@chromium.org> Cr-Commit-Position: refs/heads/master@{#543359}
-
Christian Dullweber authored
When a profile is deleted, all browsing_data is removed and the folder is marked for deletion on shutdown. Bookmarks are currently not deleted until the folder is deleted. As bookmarks can contains sensitive data they should also be removed immediately. This also changes SigninManagerAndroidTest to use ChromeBrowsingDataRemoverDelegate. Bug: 803643, 748484 Change-Id: Icebfcec44d61d8b38939a8cee8dc4a92b6f9e258 Reviewed-on: https://chromium-review.googlesource.com/957040 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#543358}
-
Sylvain Defresne authored
Call -dismissLanguageSelector on navigation by adding a call in -tabModel:willStartLoadingTab: (in BVC). Fix a regression that was introduced by http://crrev.com/c/867042 where -notifyTabLoading: was not called. Bug: 820590, 809577 Change-Id: I718c20bb4beefd04a51a7b49f69e320907705d0d Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/962450Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#543357}
-
Elly Fong-Jones authored
This change causes polychrome builds to use TabDialogsViewsMac or TabDialogsViews as appropriate, instead of TabDialogsViews in all cases. This fixes a bunch of browser tests. Bug: 817408 Change-Id: I1f3f43411856bfc70232e969ce3afaa484a52ee3 Reviewed-on: https://chromium-review.googlesource.com/960682 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#543356}
-
Gabriel Charette authored
It was merely added to match previous allowance before migration to TaskScheduler, but this allowance doesn't appear to be needed (bots are happy without). Bug: 815225 Change-Id: Ie8ab830fe3807ed29fa91ea06c30b326082e93c6 Reviewed-on: https://chromium-review.googlesource.com/961455Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#543355}
-
Mugdha Lakhani authored
process from the renderer, all the way through to OfflineItemsCollector, so that it can be used in notifications. Also persist it using DataManager. Additionally, a unit test has been added under browser_tests. Bug: 813564 Change-Id: I8953deb9a7b19ed6cdab16806e79ffad98186256 Reviewed-on: https://chromium-review.googlesource.com/956183 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#543354}
-
Elly Fong-Jones authored
This change: 1) Introduces Cocoa shims for GetViewsBubbleForBrowser and GetAnchorReferenceBoundsForBrowser; 2) Adds calls to those shims as needed from the Views code (when in polychrome-cocoa mode) This fixes ExtensionMessageBubbleViewBrowserTest.* in all three of cocoa, polychrome-cocoa, and polychrome-views. Bug: 817408 Change-Id: I4b1ac44c23cd6979013b35534e028fe38c4f8353 Reviewed-on: https://chromium-review.googlesource.com/962873 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#543353}
-
Max Morin authored
This is a reland of a7c1c185 Clusterfuzz issues were (hopefully) fixed by https://chromium-review.googlesource.com/c/chromium/src/+/962124 Original change's description: > Fix yet another AudioOutputDevice crash. > > Bug is identical to the last :/. No idea why it's much more frequent with mojo, > possibly a race is likely to happen when destroying a frame: |callback_| is > destroyed due to frame being destroyed, and authorization is failed for the > same reason. With the per process message filter, authorization wouldn't fail > due to the frame being destructed. > > Bug: 819277 > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: Ic17dc96d2c83a08732b43094bac2f2c3fa7035ad > Reviewed-on: https://chromium-review.googlesource.com/951774 > Commit-Queue: Max Morin <maxmorin@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#541801} Bug: 819277 Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ia6aca4d8f93d1534a364abe9d467829bde928de7 Reviewed-on: https://chromium-review.googlesource.com/962721 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#543352}
-
Max Morin authored
This test suite takes 4000 ms on my machine. By removing all the Sleeps and using mock time instead, this CL reduces the time to 40 ms. Bug: None Change-Id: Id9cb35aa04fc5e576a8886d0c183542fc9fcc0f8 Reviewed-on: https://chromium-review.googlesource.com/962446 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by:
-
Tomasz Moniuszko authored
Crash happens when Widget with no non-client view (for example TYPE_WINDOW_FRAMELESS) is being shown on Windows 7 with Aero Glass disabled. This is a regression introduced by https://chromium-review.googlesource.com/924315. ResetWindowControls is called from HWNDMessageHandler::OnSysCommand. Previously it wasn't called if non-client view was null because ShouldHandleSystemCommands returned false in such case. Bug: 189112 Change-Id: Ia12013ab11fd67dd28bcaf5d490c846928569a78 Reviewed-on: https://chromium-review.googlesource.com/960029 Commit-Queue: Tomasz Moniuszko <tmoniuszko@opera.com> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#543350}
-
Michael Lippautz authored
Intercept weak field visitation in VisitWeak. Bug: chromium:802273 Change-Id: Ie7885409764c9de9debaf1811d84f3928afbc80f Reviewed-on: https://chromium-review.googlesource.com/962806 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Charles Harrison authored
This patch also fixes up some missing dependencies to get components_perftests building + passing on all targets. Bug: 648992 Change-Id: I911bdea5ba946e58037f40a4bfa0d534486be761 Reviewed-on: https://chromium-review.googlesource.com/957224 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#543348}
-
Benoit Lize authored
Bug: 819228 Change-Id: I5813d2c77c04d7dd00303a874ba6bd2a09acf946 Reviewed-on: https://chromium-review.googlesource.com/952967Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#543347}
-
https://skia.googlesource.com/skia.git/+log/30ce2a3620ff..945ac788d85d $ git log 30ce2a362..945ac788d --date=short --no-merges --format='%ad %ae %s' 2018-03-15 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 5eaddbd01..0b0dcbc1c (1 commit) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: I13b75da8cfa3f9354c7b22788bb9436c04613daa Reviewed-on: https://chromium-review.googlesource.com/963712Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543346}
-
Vitaliy Rebrov authored
Fixed typical problem with unit tests and global variables. If unit test modifies global variables then it can affect other tests which are runned in the same process. Added reseting of the global variables to avoid this. Change-Id: I2045700473ac074209f4d48a6cedbd3dad24ccd5 Reviewed-on: https://chromium-review.googlesource.com/952905 Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru> Reviewed-by:
Carlos Pizano <cpu@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#543345}
-
https://chromium.googlesource.com/angle/angle.git/+log/5eaddbd018ea..0b0dcbc1cffa $ git log 5eaddbd01..0b0dcbc1c --date=short --no-merges --format='%ad %ae %s' 2018-03-14 oetuaho Prune empty cases and switch statements Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Iabd3eef196468911f4846edc1e2d3a987d3d5e52 Reviewed-on: https://chromium-review.googlesource.com/963705Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543344}
-
Yuki Shiino authored
ActiveScriptWrappable is designed to be inherited. The ctor should be protected:. Also all classes that support virtual member functions should have the virtual dtor. Change-Id: I1eaa60b45607b5404868e0d293a150e1b98dfc5b Reviewed-on: https://chromium-review.googlesource.com/964068Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
-
Yuhong Sha authored
Currently whitespaces can not be shown in the built-in XML Viewer. It is proper to remove trim in text node creation for whitespaces show. Bug: 736690 Signed-off-by:
Yuhong Sha <yuhong.sha@samsung.com> Change-Id: I55ca0f61d76f3a45a9dabdd0b5805a2e895e1fc2 Reviewed-on: https://chromium-review.googlesource.com/950489 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#543342}
-
stkhapugin@chromium.org authored
Allows using Cmd+C/Cmd+V/Cmd+X when the textfield is in pre-edit state. Allows using arrow-left and arrow-right keys to go to the start/end of the string and exit pre-edit, like on desktop. Bug: 136291 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ibe71f4d2b6adba3df310051edf4ffa42832217c2 Reviewed-on: https://chromium-review.googlesource.com/951783 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#543341}
-
Hiroki Nakagawa authored
This is a preparation CL for implementing module loading on workers. WorkerOrWorkletModuleFetchCoordinator (strictly speaking, WorkletModuleResponsesMap) is a key class for module loading on worklets. It's primarily owned by Worklet class on the main thread, and its reference is passed to the WorkletGlobalScope on the worklet context thread before module loading happens. Before this CL, the reference is passed from Worklet to WorkletGlobalScope when worklet.addModule() is called in the JS context. This path is specific for worklets and not called for workers. To pass the reference in a common way, this CL passes the reference with GlobalScopeCreationParams struct that is commonly used for creating a new global scope. Design doc: https://docs.google.com/document/d/1IMGWAK7Wq37mLehwkbysNRBBnhQBo3z2MbYyMkViEnY/edit#heading=h.637avx8i5qtn Bug: 680046 Change-Id: I6dde98ef83c5fb6ae7898c63bdbecd3ebfbd36dd Reviewed-on: https://chromium-review.googlesource.com/961747 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Zhuoyu Qian authored
This is part of the gradual process of putting all types that derive from CSSValue into blink::cssvalue:: namespace. Bug: 667961 Signed-off-by:
Zhuoyu Qian <zhuoyu.qian@samsung.com> Change-Id: Ia34819a0518e339ed2d310361452355207346801 Reviewed-on: https://chromium-review.googlesource.com/956165Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#543339}
-
Ramin Halavati authored
Traffic annotation auditor new executables are rolled for Linux and Windows. Bug: 690323 Change-Id: Ibbfa8868736b4cbe6fd101ecf93fbf15626832f0 Reviewed-on: https://chromium-review.googlesource.com/963323Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#543338}
-
Rob Buis authored
In order to make this work, because comments are already stripped by the time ParseRGBParameters/ParseHSLParameters is reached, relax the strictness and simply require the color components to be there. This works since although the comment is stripped out, the effect is that it still acts as a separator and will preserve numeric tokens: 1/* comment */2 -> NumericToken(1) + NumericToken(2) Behavior matches Firefox. Bug: 808888 Change-Id: I43ae53a0d7630b8229745a347c5fb914f8949589 Reviewed-on: https://chromium-review.googlesource.com/962989Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
-
Erik Språng authored
Bug: webrtc:9012 Change-Id: Ib83fa7046c2e7517e0051e0fdb433487ad636ceb Reviewed-on: https://chromium-review.googlesource.com/962784Reviewed-by:
-
Daniel Bratell authored
pch makes jumbo builds slower instead of faster since each pch file will only be used 1-3 times instead of many times, and in Blink the pch files contain a lot of code so creating them takes a long time. This saves about 20% of the Blink build time on Windows. Bug: 809010 Change-Id: Ia512646110572e4939e8e3cc1a9cd946b780cb97 Reviewed-on: https://chromium-review.googlesource.com/962785Reviewed-by:
-
Friedrich Horschig authored
If the screen space doesn't suffice for multiple action bar icons, the help icon will be pushed to the Overflow menu which is what happens when a search is triggered. Even after the search is closed, the item wasn't moved back but stayed in the overflow menu. With this CL, we ensure that the help icon stays in the action bar if sufficient space is available. Bug: 821687 Change-Id: Icb438f9988f9114f563e920ddc95f27ebdac5434 Reviewed-on: https://chromium-review.googlesource.com/962425Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#543334}
-
Fredrik Söderquist authored
Combine all the fields that make up a <paint> into a class: SVGPaint. Move the bulk of the style builder function for <paint> from the template to StyleBuilderConverter. This should make future work on <paint> resolution easier. Also split the existing setters on {SVG,}ComputedStyle to avoid having bools to indicate if the "visited" portion should be set or not. The new way more closely resemble other color properties. Add accessors to SVGPaint to both make code easier to read, and reduce the dependence on SVGPaintType. Bug: 769774 Change-Id: Ifad043c9e423f0fc7aa79fef78e635b2abb4636c Reviewed-on: https://chromium-review.googlesource.com/961062Reviewed-by:Stephen Chenney <schenney@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#543333}
-
Devlin Cronin authored
APIBindingBridge calls back into JS to allow custom JS bindings to register any hooks needed. Check context validity before executing JS, and gracefully throw an error if the context is invalid. Add unittests for the same. Bug: 819968 Change-Id: Ibb724537c4bf3d320a6f4a80b9f19fe413e00840 Reviewed-on: https://chromium-review.googlesource.com/958296Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#543332}
-
Ramin Halavati authored
Updating annotations.xml is requested before landing any CL that changes an annotation. To do the tests fast on trybots, only .mm and .cc files are checked. Also the tests do not cover ChromeOS and ios specifc code. This annotation has been moved to ChromeOS specific code by a build file change, hence gone unnoticed by the trybots. This is a typical case that the FYI bot gets the problem and fires an error for manual update of annotations.xml Annotation is marked deprecated as we still do not support ChromeOS in annotations.xml. Bug: 690323 Change-Id: Iab001e8916c3da7e97f68e9dfc67b42017d4f658 Reviewed-on: https://chromium-review.googlesource.com/962764Reviewed-by:
-
Zhuoyu Qian authored
Use Editor::ExecuteCommand() instead of Editor::CreateCommand().Execute() to avoid the dependence of Editor::Command in SelectionController.cpp Signed-off-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#543330}
-
