- 28 Aug, 2019 40 commits
-
-
Ian Kilpatrick authored
It is possible for the caching system to believe that atomic-inlines would have been impacted by floats. As a result we threw away a (perfectly good) cached layout result. This ignores line-boxes in this calculation. Change-Id: Icc6dbe948ba88d54b252ceb06b2d50aecc558296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772387 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#691024}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/2002bac5500d..1b2f2b335b20 git log 2002bac5500d..1b2f2b335b20 --date=short --no-merges --format='%ad %ae %s' 2019-08-28 vapier@chromium.org lint: fix up consider-merging-isinstance warnings Created with: gclient setdep -r src/third_party/chromite@1b2f2b335b20 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ibaf41bfb54ccf8731908b9ac4b30601511d35ac9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774144Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691023}
-
Abhishek Bhardwaj authored
This change increments the network wait timeout from 1 minute to 5 minutes. This is done because after manual testing it was found that it could take up to just over a minute for shill to notify Chrome of a network change. 5 minutes is used as the absolute worst case. BUG=924762 TEST=Unit tests. Change-Id: I60a412930f379fd7639d01e9c856c0443e8ef14a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757460 Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#691022}
-
David Bokan authored
Looking at code and the crash stacks, it looks like we're synchronously closing a WebViewImpl while it's handling an input event. This CL adds some debugging to crash earlier so we can get a stack showing where the Close call is coming from. Bug: 992315 Change-Id: I16b17cbbec6dfdafadfc334028a31227ae61ccae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769348 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#691021}
-
Xianzhu Wang authored
They were to handle cases that layer tree and transform tree had different hierarchy. We can remove them because the cases no longer exist in layer tree mode (for ui compositor only). Bug: 993937 Change-Id: If496b5fc821fb786f281093be8ef2efed86e7bce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770510 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#691020}
-
Abhishek Bhardwaj authored
This change moves a function that semantically belongs in ResetState. BUG=924762 TEST=Unit tests. Change-Id: I8a8d0c446cda8e8a828857d80031b97e28206fc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757459 Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fd849a537a4b..7be971fa3a4e git log fd849a537a4b..7be971fa3a4e --date=short --no-merges --format='%ad %ae %s' 2019-08-28 michaelludwig@google.com Fix flutter roll Created with: gclient setdep -r src/third_party/skia@7be971fa3a4e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@google.com Bug: None Change-Id: Ie547ba81d094effe2fdf505ff64c34c69f97f609 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774139Reviewed-by:
-
Regan Hsu authored
Test: * Manually test by clicking system tray > bluetooth section > gear which opens bluetooth device page directly. The banner will not be present. * Manually go to settings page and notice banner. Then, navigate into a subpage and notice that the banner is not present. Bug: 997844 Change-Id: Iefe52c0e0111f15adf6c88147a77e4e2210fd0d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773204 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#691017}
-
Kurt Horimoto authored
This test passes now after crrev.com/c/1769082, but we've noticed some flake that isn't reproducing. This CL re-enables it separately so it can be easily reverted if necessary. Bug: 989550 Change-Id: If84c590547a57403ad0bd36079550fe98fc53b1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769354 Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#691016}
-
Dan Beam authored
Adds: * kNtpZeroSuggest feature * both kNtpRealbox and kNtpZeroSuggest to about:flags * IsNtpRealboxEnabled() accessor, as zero suggest forces on realbox R=mahmadi@chromium.org Bug: 243926, 778489, 996516 Change-Id: Ifa91141c6459376a0e677b5c6ea527c13c5b59d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769595 Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#691015}
-
Darren Shen authored
TestSelectNetwork TestSelectConnectedNetwork TestDeviceRequisition TBR=antrim@chromium.org Bug: 997685 Change-Id: I07fbc27aa47f430981d4581b6d51a9db2a7b305f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773998Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#691014}
-
Lukasz Anforowicz authored
This CL breaks-out two additional special-cases out of the old kIncorrectLock category: - kExcludedScheme will be used for chrome-extension, since non-allowlisted extensions will use an incompatible request_initiator until https://crbug.com/940068 is fixed. - kExcludedUniversalAccessPlugin will be used for requests from renderers which are embedding a universal-access plugin (like Flash) - the renderer is proxying requests on behalf of the (potentially cross-origin = request_initiator-incompatible) plugin. The CL adds or modifies tests, so that if we started to treat an incorrect lock as a bad message, then the tests would fail without the additional exceptions outlined above. Bug: 920634 Change-Id: I93f14a43d6569c010898a662c250d2bda0613fca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762677 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#691013}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I1e5be8fb11b79811e1349fcec148ea06c78ec199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773659Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691012}
-
Darren Shen authored
TBR=pfeldman@chromium.org Bug: 997911 Change-Id: I66aa9d4e1bd8e3167d1fd28113a67c145fb2adc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773265Reviewed-by:
-
Ahmed Fakhry authored
- Alert on overview enter that users can use Tab to navigate. - Give a tip when either a window or a desk mini_view are highlighted that Ctrl+W can be used to close. - Announce that a mini_view is of the active desk when it is so. - Alert that a window is closed in overview mode. TBR=dtseng@chromium.org for minor change in `spoken_feedback_browsertest.cc`. BUG=997007 TEST=Manually on device. Change-Id: I2f10ad14b6e3d77560b0cb7dc485c3867c099fc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773725 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#691010}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: Ibbe13c85a5e5842db9d5a0909009a9e1b42dcff0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700961 Auto-Submit: Eric Foo <efoo@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#691009}
-
Alexey Baskakov authored
We will introduce a "batched writes" API in next CLs. Current access to the apps that are owned by WebAppRegistrar (the LevelDb) should be read-only. Next CL: Make WebAppRegistrar::AllApps API read only (const). Bug: 891172 Change-Id: Id3fb57f341683ead6ce83359d9f8d2147603b73b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772932Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#691008}
-
Scott Violet authored
Here's the set of classes/changes: weblayer_private.BrowserControllerClient: this is a singleton that is supplied when creating BrowserControllerImpl. It will duplicate the C++ BrowserObserver interface along with any other server->client calls we want. BrowserController: supplies an implementation (as an inner class) of BrowserControllerClient to BrowserControllerImpl. BrowserController's inner class forwards calls to BrowserObservers. BrowserObserverProxy: there is a C++ and Java class with this name. The two are tightly coupled. The C++ side implements BrowserObserver and forwards to the java side. The java side forwards to BrowserControllerClient. BUG=none TEST=none Change-Id: I2817149224f4ac2045769c4ce0c3f81040dc7507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772501 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#691007}
-
Hiroshige Hayashizaki authored
Bug: 990561 Change-Id: I0df8d84b450a644d979c1f9c8764f9d2de4c1d9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755283 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#691006}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: Ia891d4988299e76925beb57bc69c22e19187eaa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700872Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#691005}
-
Darren Shen authored
TBR=shuchen@chromium.org Bug: 997888 Change-Id: Ic7dfb8088ec76028c2c1daabdcd582c210c7560b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772931Reviewed-by:
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: I0037f36b9da556a802e14d452be1b582b7357179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700844 Commit-Queue: Eric Foo <efoo@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#691003}
-
Kurt Horimoto authored
In iOS13, the minimum duration for the long press gesture recognizer was increased to 0.75s in order to mitigate interactions between this feature and iOS's built in drag-and-drop functionality. However, web::WebViewLongPressElementForContextMenu() was still using 0.7 as the action's press duration, which caused our context menu tests to fail. This CL updates the duration for this helper to 0.75s and re-enables disabled tests. Bug: 989550 Change-Id: I02cb1208ba0b27d9d70722f1da381f57c0aa1e54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769082Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#691002}
-
Rose Garcia authored
Use the custom menu order functions to set the order of the buttons in the menu panel init function. The ability to set the button order is not user facing but can be done in remote debugging using the updatePositionAttributes_ function. Tested using emulated Chrome on Linux with flags --enable-experimental-accessibility-switch-access and --enable-experimental-accessibility-switch-access-text. Use of updateButtonOrder function does not impact the order or function of the menu. Button order can be manipulated manually using the updatePositionAttributes function. Bug: 994256 Change-Id: If76d9a48d74e738129d9e0788e03c599d6cf6e32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770432Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Commit-Queue: Rose Garcia <rosalindag@google.com> Cr-Commit-Position: refs/heads/master@{#691001}
-
Mark Pearson authored
Remove History.InMemoryTypedUrlVisitCount, which we don't need The others are still useful. Make them all non-expired and extend their expiration to 2020-02-16. Also make sky@ and mpearson@ the owners, transferring from away from gab@. Bug: 969934 Change-Id: I9a9707502f438cf6804070dd49ec079305761f01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773205Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#691000}
-
Jamie Walch authored
macOS Mojave does not recognize .bundle directories as valid candidates for accessibility permissions. Now that Chrome disclaims responsibility for native messaging hosts it launches (crbug.com/945969), Chrome Remote Desktop's Remote Support mode no longer works because its top-level directory ends in .bundle. This CL renames it to .app instead and maintains a symlink with the old .bundle suffix. The main purpose of the symlink is to allow the launchd script for Remote Access to be unchanged, as changing it causes the previously-granted accessibility permissions to be lost. It also has a lesser benefit of not breaking any third-party dependencies that may exist. Bug: 996993 Change-Id: Ifac617c819540152253cdcf2d2344f1022a87cdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773861 Auto-Submit: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#690999}
-
Akihiro Ota authored
This does two things: 1. Cleans up the language switching code to use consistent terms. Most notably, it changes all instances of "inner-node switching" to "sub-node switching". 2. Cleans up the language switching test infrastructure. A test naming scheme was implemented to easily communicate the purpose of each test. Also, tests were added to cover the two language switching behaviors: node-level and sub-node-level switching. Each document in the test databank is tested using node-level and sub-node-level switching. Bug: 923068 Change-Id: Ia16b785381966d97e089aae5dc08e23173876d08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754703 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#690998}
-
Jinsuk Kim authored
This CL adds haptic feedback to basic back/forward gesture navigation UI when edge swipe is made to the point where the action will be triggered. Bug: 992997 Change-Id: I5af8ac7513091afc5ea667727d376214fd39fb22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772780Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#690997}
-
Cliff Smolinsky authored
When a tooltip is hidden the widget is hidden, rather than closed, which results in the old information showing briefly when it is shown again. This happens because Show() runs before OnPaint() when the information gets updated. This change closes the widget in Hide() which results in the information getting repopulated properly. Bug: 985472 Change-Id: Ib007067e952b6f0b8532cdf82f52742b7ac3316c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709635 Commit-Queue: Cliff Smolinsky <cliffsmo@microsoft.com> Reviewed-by:
-
Ben Mason authored
This reverts commit 78fac991. Reason for revert: Breaking some internal builders. Will reland once they are no longer building these targets. Original change's description: > Enable dist fusing for all feature modules. (reland) > > Fixed: I have disabled building of the system image in next-* builds > so there should no longer be an issue. next-* builds can be re-enabled > when bundletool is updated. > > This reverts commit 7c77403d. > > Original change's description: > > Revert "Enable dist fusing for all feature modules." > > > > This reverts commit 27ca1df7. > > > > Reason for revert: This CL causes an official build failure > > https://crbug.com/996658 > > > > Original change's description: > > > Enable dist fusing for all feature modules. > > > > > > Change-Id: I66848fec159450a6d531e0af3f867988aa8b148f > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763431 > > > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > > > Commit-Queue: Ben Mason <benmason@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#689075} > > > > TBR=tiborg@chromium.org,benmason@chromium.org > > > > Change-Id: Ib696df42847a54c1257fae41ecb544df40f47e75 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764159 > > Reviewed-by: Alex Ilin <alexilin@chromium.org> > > Commit-Queue: Alex Ilin <alexilin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#689454} > > TBR=alexilin@chromium.org,tiborg@chromium.org,benmason@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Change-Id: Id4687e7980b238cdbea04a1c8921b57a974f7cd0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768946 > Reviewed-by: Ben Mason <benmason@chromium.org> > Commit-Queue: Ben Mason <benmason@chromium.org> > Cr-Commit-Position: refs/heads/master@{#689947} TBR=alexilin@chromium.org,tiborg@chromium.org,benmason@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ib1558378a9b2a12b7f0260a04eeb1fbe4d1330b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773836Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#690995}
-
Maggie Cai authored
Extend the AllSitesAction metrics expiry day. BUG=None Change-Id: I84ebdb8d51e2ff0033e3b8afd726331d7e877850 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771487Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#690994}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: I265ac56aa1e95426b15ce94ab4d536ff4af37fad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700881 Auto-Submit: Eric Foo <efoo@chromium.org> Reviewed-by:
Peter Williamson <petewil@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#690993}
-
Yoshisato Yanagisawa authored
To test the behaviors with ATS, let me add these builders. Bug: 981433 Change-Id: I1883a4b0c16ec242564a6c29894dea32db51eb04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771230Reviewed-by:
Fumitoshi Ukai <ukai@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#690992}
-
Hesen Zhang authored
- Changed LoadIcons API to taking IconBundle as input. - Completed loading icons in DisplayNotification. - Handle empty input case. - Added unit test for DisplayNotification with icons. Bug: 963290 Change-Id: Iaaf9318a594ab0ac42a344692536daccc1f0c76d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772370 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#690991}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/674ee74e88d7..fd849a537a4b git log 674ee74e88d7..fd849a537a4b --date=short --no-merges --format='%ad %ae %s' 2019-08-27 michaelludwig@google.com Revert "Combine snapBackImage and snapSpecial" 2019-08-27 michaelludwig@google.com Add Color4f variant for DrawEdgeAAQuad 2019-08-27 michaelludwig@google.com Revert "Calculate draw bounds in drawEdgeAAImageSet" 2019-08-27 fmalita@chromium.org [skottie] Disable text baseline snapping 2019-08-27 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-08-27 michaelludwig@google.com Combine snapBackImage and snapSpecial 2019-08-27 senorblanco@chromium.org gn format third_party/dawn/BUILD.gn. 2019-08-27 halcanary@google.com SkPlainTextEditor: from experimental to modules 2019-08-27 herb@google.com Check RemoteStrike pointer is still valid to send 2019-08-27 bungeman@google.com Add a way to disable baseline snapping. 2019-08-27 egdaniel@google.com Have visitProxies take a GrTexutreProxy instead of GrSurfaceProxy. 2019-08-27 michaelludwig@google.com Calculate draw bounds in drawEdgeAAImageSet 2019-08-27 csmartdalton@google.com Add renderTasks to the DAG before calling addDependency Created with: gclient setdep -r src/third_party/skia@fd849a537a4b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@google.com Bug: chromium:795132,chromium:985500 Change-Id: Id141237d624d36800fc4aad03e7a24e20f7a7e68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774036Reviewed-by:
-
Darren Shen authored
TBR=cammie@chromium.org Bug: 997808,997732 Change-Id: I641f087328102947802a565dc0cf3475f011fb9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772779 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
-
Harsh Patel authored
Updated life_of_a_resource docs to include the new inheritance structure for R.java files. Also removed ResourceRewriter references as ResourceRewriter is removed, and onResourcesLoaded is used instead for rewriting webview resources. Change-Id: I2b6babd4ca070a211e063c4ba181d457dde329c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746948 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#690988}
-
Erik Chen authored
Previously, BrowserPlugin was going to the main frame RenderWidget. This assumes that the main frame RenderWidget exists, which in the future will not exist for remote main frames. Bug: 995981 Change-Id: I25b76e4ee9f99c7c0ca60a57088ecf95c99fe2c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772485 Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#690987}
-
David Bokan authored
This is a small amendment to https://crrev.com/c/1763375. The null check added there should go before the DCHECK. Bug: 997430 Change-Id: Iabdef43de616b6207516b7efff1c6ecd8e81de81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771621 Auto-Submit: David Bokan <bokan@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f79bd7c2ef34..2002bac5500d git log f79bd7c2ef34..2002bac5500d --date=short --no-merges --format='%ad %ae %s' 2019-08-28 haddowk@chromium.org [moblab] Enlarge the size of the moblab vm disk. 2019-08-27 saklein@chromium.org Package/GetBestVisible: Add chroot and build target handling. Created with: gclient setdep -r src/third_party/chromite@2002bac5500d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: If34424d8cd2c1f58e5d76edec0f2a9280d901dc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774037Reviewed-by:
-
