GitLab

http://crrev.com/c/1179263 switched
SocketExtensionWithDnsLookupFunction::StartDnsLookup to use mojo API.

Bug: 874659
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ia65b22c593e6df68dfc20b60942747015a46cc8d
Reviewed-on: https://chromium-review.googlesource.com/1180256Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584161}

https://skia.googlesource.com/skia.git/+log/bc414ed5dec5..54ff302cdc5a


git log bc414ed5dec5..54ff302cdc5a --date=short --no-merges --format='%ad %ae %s'
2018-08-17 caryclark@skia.org avoid degenerate point in addPath extend mode
2018-08-17 caryclark@skia.org pathops remove degenerate line on close
2018-08-17 fmalita@chromium.org [skottie] Initial text layer plumbing
2018-08-17 allanmac@google.com Documentation updates and improved gcc compatibility.
2018-08-17 robertphillips@google.com Revert "Make directFilterMaskGPU & directFilterRRectMaskGPU no longer require canFilterMaskGPU's permission"
2018-08-17 robertphillips@google.com Remove occluder feature from blur mask filter
2018-08-17 caryclark@skia.org fixup winding contours
2018-08-17 benjaminwagner@google.com [Bazel] Enable GPU for Android build.
2018-08-17 z102.zhang@samsung.com After call 'va_start',some place not call 'va_end'
2018-08-17 z102.zhang@samsung.com BAD_COPY_PASTE in SkSLLayout.h
2018-08-17 kjlubick@google.com [PathKit] Add docs page
2018-08-17 robertphillips@google.com Make directFilterMaskGPU & directFilterRRectMaskGPU no longer require canFilterMaskGPU's permission


Created with:
  gclient setdep -r src/third_party/skia@54ff302cdc5a

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=kjlubick@chromium.org

Change-Id: I8a7337f8e7278f392886303b5be26db192743de2
Reviewed-on: https://chromium-review.googlesource.com/1180010Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#584160}

- Moves ScriptResource::SingleCachedMetadataHandlerImpl out of
  ScriptResource and into the blink namespace so it can be used by other
  script-like resources.
- Creates this CacheHandler type for RawResource type kRaw, which will
  be needed for WASM modules.

Bug: chromium:719172
Change-Id: I34a2740310d2d3f4ccb0cea1bb664db0b9c53f5e
Reviewed-on: https://chromium-review.googlesource.com/1174903
Commit-Queue: Bill Budge <bbudge@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584159}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ed0d273bfa51..7de5f08c459c


git log ed0d273bfa51..7de5f08c459c --date=short --no-merges --format='%ad %ae %s'
2018-08-17 jbudorick@chromium.org bot_update: remove --gerrit_repo and --gerrit_ref.


Created with:
  gclient setdep -r src/third_party/depot_tools@7de5f08c459c

The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:865882
TBR=agable@chromium.org

Change-Id: Ic1d09bb6c6bb7739af9f9a6d7b078c32e6cdd8ff
Reviewed-on: https://chromium-review.googlesource.com/1180004Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#584158}

WebAuthN is now enabled by default on Android but intentionally
is not supported by WebView

Bug: 875174
Change-Id: Iea94af1ed20884bcd6957ffb5057deb30cb8fb25
Reviewed-on: https://chromium-review.googlesource.com/1179964Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584157}

This reverts commit dd9f811b.

Reason for revert: Causing renderer crashes in some VR tests https://crbug.com/875121

Original change's description:
> Add support for reporting EGL Timestamps via
> presentation feedback.
> 
> This CL adds support for reporting egl_composite_interval and
> presentation_time via the presentation feedabck.
> GLSurfacePresentationHelper uses the new interface
> EGLTImestampClient to query the egl timestamp info.
> 
> Bug: 790761
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: I7e1f3200bba41bf3252b8acedc68393eeeb76df5
> Reviewed-on: https://chromium-review.googlesource.com/1106600
> Commit-Queue: vikas soni <vikassoni@chromium.org>
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#583360}

TBR=penghuang@chromium.org,brianderson@chromium.org,piman@chromium.org,ericrk@chromium.org,vikassoni@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 790761
Change-Id: I75d1140881a8ae2d94512bde56dae5b27d532d7c
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1180042Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584156}

Tests may interact with the WebRunner FIDL services and the underlying
browser objects for end to end testing of service and browser
functionality.

* Add a browser test launcher main() for WebRunner.
* Add some simple navigation tests.
* Wire up GoBack()/GoForward() FIDL calls.
* Add embedded test server resources and initialization logic.
* Add missing deletion & notification calls to BrowserContext dtor.
* Use FIDL events for navigation state changes.

* Bug fixes:
  ** Move BrowserContext and Screen deletion to PostMainMessageLoopRun(),
     so that they may use the MessageLoop during teardown.
  ** Fix Frame dtor to allow for null WindowTreeHosts (headless case)
  ** Fix std::move logic in Frame ctor which lead to no WebContents
     observer being registered.

Bug: 871594

Change-Id: I36bcbd2436d534d366c6be4eeb54b9f9feadd1ac
Reviewed-on: https://chromium-review.googlesource.com/1164539
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584155}

Also, move UI support source out of the UI library.  Those files are
meant to supply capabilitie to the UI library, but not live in the
library itself.

BUG=
R=acondor

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ice761aa2d0f18f32bf9600e4a202421f5f705e51
Reviewed-on: https://chromium-review.googlesource.com/1179979Reviewed-by: Aldo Culquicondor <acondor@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584154}

Will be used for an Assistant suggestion chip.

Bug: b:111694337
Change-Id: I9acb85b359cd8d7293fe9163468ce1d63fec40d2
Reviewed-on: https://chromium-review.googlesource.com/1179971
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584153}

This reverts commit d3c0d246.

Reason for revert: Speculative revert for issue 864351, which started
on Canary channel the day after this was landed. The tests in the
FileSystemURLLoaderFactoryTest suite remain disabled, because they
hit a NetworkService feature check now, under Cast, if re-enabled.

Original change's description:
> Simplify implementation of FileSystemOperationRunner.
>
> - Use a base::AutoReset instance to manage a single integer tracking
>   whether the completion callback for an operation is invoked before
>   we have actually returned to the caller.
> - Remove the now-unused OperationHandle and BeginOperationScoper.
> - Replace SupportsWeakPtr with an internal WeakPtrFactory.
> - Replace potentially unsafe use of GetWeakPtr() with a |weak_ptr_|
>   member.
> - Temporarily disables the recently-added FileSystemURLLoaderFactoryTest
>   tests, which have incorrect threading, causing WeakPtr checks to
>   fire.
>
> Bug: 846985, 860547
> Change-Id: Ia059b1b87ef11f3218aeb6c65d7b8dd62be6c393
> Reviewed-on: https://chromium-review.googlesource.com/1074427
> Commit-Queue: Wez <wez@chromium.org>
> Reviewed-by: Ken Rockot <rockot@chromium.org>
> Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
> Reviewed-by: Chris Mumford <cmumford@chromium.org>
> Reviewed-by: Alexander Alekseev <alemate@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#574220}

TBR=wez@chromium.org,rockot@chromium.org,alemate@chromium.org,noel@chromium.org,fukino@chromium.org,cmumford@chromium.org,tzik@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 846985, 860547, 864351
Change-Id: Ib858c73226785d9fbef3459d49e6cc3fd670d040
Reviewed-on: https://chromium-review.googlesource.com/1179782
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584152}

This reverts commit 434f3432.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 584133 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzQzNGYzNDMyNTkwODg4Yjg5OGNlODVmZGI5OWVhYmZiYjJkNTlmNzIM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium/android-rel/738

Sample Failed Step: compile

Original change's description:
> Disable flaky RestoreHistogramTest testWritingHistogramAtStartup.
> 
> TBR=tedchoc@chromium.org
> NOTRY=true (disabling a test)
> 
> Bug: 875372
> Change-Id: Ia51964a62207de7300b159e80a3e4816af8f579b
> Reviewed-on: https://chromium-review.googlesource.com/1180165
> Reviewed-by: apacible <apacible@chromium.org>
> Commit-Queue: apacible <apacible@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#584133}

Change-Id: Ib147d1b5da422966072e141e1612b571aaf29587
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 875372
Reviewed-on: https://chromium-review.googlesource.com/1180263
Cr-Commit-Position: refs/heads/master@{#584151}

Google URL preferences are moved to the persistent storage list for the
incognito mode.
This CL does not change any behavior.

Bug: 861722
Change-Id: I72c4cb075551b81c1ceeb04eaadbeff7f53447b5
Reviewed-on: https://chromium-review.googlesource.com/1176805Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584150}

Adds support to sync the virtual clocks of the various
threads created throughout the porgram. This code doesn't
include cross-thread posting yet.

Bug: 852076
Change-Id: I7936f464f9bfbd35eed3840841c0d8b27c138edc
Reviewed-on: https://chromium-review.googlesource.com/1165145Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584149}

TBR=pkasting@chromium.org
NOTRY=true (disabling tests)

Bug: 872705
Change-Id: Id68190e7ece3004b58fe1450a9e2421d7fad81da
Reviewed-on: https://chromium-review.googlesource.com/1180251Reviewed-by: apacible <apacible@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584148}

Add the structure for a basic media session service that
will control media sessions and audio focus across the
entire system.

The mojo API is based on the current public content API.

BUG=875004

Change-Id: Ie7ab6be5c13ba89e4e8865d9f65fb1533b6925af
Reviewed-on: https://chromium-review.googlesource.com/1178681
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584147}

Phase 2 of the work to replace url_template with action and params as
per the updated WebShareTarget spec:
https://wicg.github.io/web-share-target/.

This work stops the parser from parsing |url_template| for
|share_target| and instead parses |action| and |params|. This will
effectively disable any downstream dependencies which trigger when
|url_template| is populated. Disabled codepaths are in
chrome/browser/webshare and chrome/android/webapk. This will be
quickly remedied before M70.

See the bug for a detailed plan for performing these changes.

Bug: 871788
Change-Id: If15f1158ae439286c7a2d64538842c21fd1b9d5f
Reviewed-on: https://chromium-review.googlesource.com/1168115
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584146}

Apple doesn't allow advertising with service data, as a result we are
advertising the EID in the form of service UUID in the advertisement.
Chrome on Mac advertises in this form, however Chrome on all platform
needs to parse this form of advertisement as well since iOS phone can
only advertise in this form.

Bug: 875074
Change-Id: I654d2cfbbf5692cf9b17876b2d05bfad07f7bba2
Reviewed-on: https://chromium-review.googlesource.com/1171253
Commit-Queue: Yuankai Yu <yyk@google.com>
Reviewed-by: Jun Choi <hongjunchoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584145}

Also make notification_helper_unittests run on the CrWinAsan* bots since
they now run tests on Win10 and that suite only has issues on Win7.

Some tests currently fail under asan. I'm for now not running the
suites containing these tests at all. I'll fix (or disable individual
tests) and gradually add the missing test suites:

- cc_unittests fails LayerTreeHostBlendingPixelTest, https://crbug.com/875223
- install_static_unittests fails GetSandboxSidPrefix, https://crbug.com/875225
- sbox_integration_tests fails TestAddressSanitizer, https://crbug.com/875242
- browser_tests (and viz_browser_tests and network_service_browser_tests)
  fail PictureInPicture (https://crbug.com/873234), MouseLeave (https://crbug.com/856169)
- sync_integration_tests fails MC_MergeDifferentBMModelsModeratelyComplex,
  https://crbug.com/875239

Bug: 869973
Change-Id: I5173419ac0a9ed4879dcfc91614ffc335d749b04
Reviewed-on: https://chromium-review.googlesource.com/1179087Reviewed-by: Reid Kleckner <rnk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584144}

Looks like the test is in fact flaky-timeout on all platforms.

TBR=foolip

No-Try: True
Bug: 875249
Change-Id: I9e6a3c96afbf539c8c685ef079993c138826ea18
Reviewed-on: https://chromium-review.googlesource.com/1180248Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584143}

TBR=sandersd@chromium.org
NOTRY=true (disabling a test)

Bug: 875278
Change-Id: I26c070fc09e5c7798fcbed324286c7b4e7ece379
Reviewed-on: https://chromium-review.googlesource.com/1180247Reviewed-by: apacible <apacible@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584142}

R=abdulsyed@chromium.org

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I8c56ab263b32979b6e310e777b91895220200af7
Reviewed-on: https://chromium-review.googlesource.com/1180175Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584141}

It is flakily crashing.

TBR=sandersd@chromium.org
NOTRY=true (disabling a test)

Bug: 875390
Change-Id: I22c9fd4a28ef513682b3dac7c5c2706c4cdd0b37
Reviewed-on: https://chromium-review.googlesource.com/1180180Reviewed-by: apacible <apacible@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584140}

TBR=rohitrao@chromium.org
NOTRY=true (disabling tests)

Bug: 875313
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ib632b4395c18c417832a43d4cbe1082bfc8a7044
Reviewed-on: https://chromium-review.googlesource.com/1180173Reviewed-by: apacible <apacible@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584139}

The custom control fullscreen detection will be used to override
DisplayType so that an inline playback that is "effectively fullscreen"
will be represented as fullscreen with regards to watch time.

Bug: 875083
Change-Id: Ie5ced38ae559cfa3d1cfc046cd94a4a34b139ccb
Reviewed-on: https://chromium-review.googlesource.com/1178998Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584138}

Generating the test data at build time is causing issues on certain
bots. The files are too large to commit to source control, so store them
in the CIPD package chromium/chrome/test_data/safe_browsing/dmg.

Bug: 817663
Change-Id: Iebf45db581e2bfdefab0eda32722f81cf036d900
Reviewed-on: https://chromium-review.googlesource.com/1175041Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584137}

Previously the CL was reverted because it hits a DCHECK in the test.
The reason is that in the test, the guest web contents is ready, but it
is not yet attached to the render widget host view.

This CL fixes the problem by waiting for at most of 200ms for the guest
web contents to be attached. I have ran this locally for more than
20 times and there is no failure.

Patchset 1 is the same as the CL that was reverted, so that it is
easier to review

Bug: 873211
Change-Id: I5c36da5be5d812bbd5f1964605fc6697166a2539
Reviewed-on: https://chromium-review.googlesource.com/1177884
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584136}

This CL makes the predictor compatible with the network service. All used APIs
correctly work with the disabled network service as well, so there is no need
to keep both code paths.

Since all requests to the NetworkContext should be made on the UI thread, this
CL modifies predictors::PreconnectManager class so it lives entirely on the UI
thread instead of IO thread.

We cannot issue synchronous requests to the proxy resolution service with the
network service. This CL removes skipping preresolving in cases when a proxy is
enabled, since it relies on synchronous call to the proxy resolution service.
Follow-up CL that sends an asynchronous request to the proxy resolution service
in parallel with a resolve host request will be submitted shortly.

Bug: 809583
Change-Id: I1afe9895fc1fba163d8519df465f98a4c6a5e552
Reviewed-on: https://chromium-review.googlesource.com/1165550
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584135}

There are bugs in MediaCodec on Marshmallow that are trivially hit
when using this API there, so we need to limit our usage to Nougat.

This also partially reverts a speculative fix to MediaCodecBridge,
but not the log message for errors it added.

BUG=873094
TEST=none

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I4762456ed18a4c26f1f730d736cfd1f94c9dbe48
Reviewed-on: https://chromium-review.googlesource.com/1180062Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584134}

TBR=tedchoc@chromium.org
NOTRY=true (disabling a test)

Bug: 875372
Change-Id: Ia51964a62207de7300b159e80a3e4816af8f579b
Reviewed-on: https://chromium-review.googlesource.com/1180165Reviewed-by: apacible <apacible@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584133}

NOTRY=true (disabling tests)

Bug: 875137, 622387
TBR: dtseng@chromium.org
Change-Id: I625e4bcf454fb7dcdf67e83cfbe2ac643d9d8c7e
Reviewed-on: https://chromium-review.googlesource.com/1179974
Commit-Queue: apacible <apacible@chromium.org>
Reviewed-by: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584132}

This is a reland of http://crrev/c/1178467.
TextSuggestionsTouchBarControllerTest.InvalidRange was modified so that
it sets the controller's text and range before calling
updateTextSelection:range:offset:.

Previously, -updateTextSelection:range:offset: could receive an invalid
range from WebContentsTextObserver::DidChangeTextSelection(). This
invalid range would then cause a crash in -requestSuggestions.

A check has been added to -updateTextSelection:range:offset: to make
sure that a selection with an invalid range is not passed to
-requestSuggestions. This should prevent future crashes.

TextSuggestionsTouchBarControllerTest.InvalidRange tests that an
invalid range does not crash the controller and is handled
properly.

Bug: 717553
Change-Id: I579cac326c3de86321286d4981c05e15f844021b
Reviewed-on: https://chromium-review.googlesource.com/1180068Reviewed-by: Sarah Chan <spqchan@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Tessa Nijssen <tnijssen@google.com>
Cr-Commit-Position: refs/heads/master@{#584131}

This reverts commit ac8b0d15.

Reason for revert: Did not fix the issue.

Original change's description:
> Speculative MCVD fix: Bind OnBuffersAvailableCB on known good thread.
> 
> Crash dumps are unclear and the issue seems resolved on Pixel hardware,
> but some earlier stack traces suggest we're getting a null TaskRunner
> when attempting to BindToCurrentLoop during CreateCodec(). As such
> move binding to a known good thread.
> 
> This should be reverted if the issue is not fixed. If it is fixed
> there's additional work to be done to understand the consequences
> of CreateCodec() being called on an unexpected thread.
> 
> BUG=873094
> TEST=none
> 
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: I2928d7866c1f40de63f526ee7393d2d8b90884f2
> Reviewed-on: https://chromium-review.googlesource.com/1175092
> Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
> Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#583067}

TBR=dalecurtis@chromium.org,tguilbert@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 873094
Change-Id: I0d7824f4caacbc8663d05b8b62f2bff2061f45a7
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1179339Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584130}

The new implementation works by embedding debug info in object
files instead of parsing compiler warning output. As a result,
our official builds are much less noisy. See the new header file
ui/base/resource/whitelist.h for details on how it works.

It is also simpler because it does not rely on wrapper scripts for
collecting the set of whitelisted resource ids. As a result we no
longer need, and can remove, the wrapper scripts for the compiler
and ar.

It is also theoretically more precise because it only whitelists
resource ids mentioned in archive members that were chosen by the
linker, although I didn't see an improvement in monochrome. It may
be possible to gain even more precision by extending the compiler
(see comments on bug) but first we'd need to investigate whether that
would be worth it.

Bug: 648475, 684788
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I12d83a8aaffa42c3afcdcc834f7dd7536b7a9248
Reviewed-on: https://chromium-review.googlesource.com/1174012Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584129}

The CanvasImageProvider locks images, limited by a budget, to avoid GPU
discardable ref churn. In the non deferral mode, these images are
released on an external signal indicating the end of a task which
mutated the canvas.

The above mechanism is brittle, and can result in holding this memory
for long durations depending on when the release is triggered. Instead
queue a task each time we start adding images to this list, to ensure
they are eventually cleared.

R=ericrk@chromium.org, fserb@chromium.org

Bug: 872117
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ie9179e498ef70c78ac091a15aa871b16ae5d80ca
Reviewed-on: https://chromium-review.googlesource.com/1179376Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584128}

The OnConnect method has been removed from the service_manager::Service
class, but was left in a comment.

Change-Id: Iab8d940928b3a7927ba1e0da16deea02df3d6ecb
Reviewed-on: https://chromium-review.googlesource.com/1180001
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584127}

This is similar to dns_api.cc, in that there is no way to cancel the
request.

Bug: 874659
Change-Id: I7fdc70d786a7b86e3a92ea2c8de6a108bcfa2aaf
Reviewed-on: https://chromium-review.googlesource.com/1179263Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584126}

Makes the VR bisect compatible with both the old method of running perf
tests (directly calling run_benchmark) and the new method (calling
run_performance_tests). Which method to use is dynamically chosen based
on the current commit's position relative to the CL that changed which
format the VR tests use on swarming.

Bug: 865533
Change-Id: I235c59c8df2f340c0d9407f0b204d65e74eea18a
Reviewed-on: https://chromium-review.googlesource.com/1178625Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584125}

Also fix a crash on shutdown if one of those dialogs is open in overview.

Test: manual
Bug: 850028
Change-Id: I31917875dc7a1c770c61f48b04766e49ef4b9786
Reviewed-on: https://chromium-review.googlesource.com/1178891
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584124}

Bug: 875306
TBR: rakina@chromium.org
Change-Id: I9931c29235114845ada33661169c5152096bb165
Reviewed-on: https://chromium-review.googlesource.com/1180061
Commit-Queue: apacible <apacible@chromium.org>
Reviewed-by: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584123}

This is a reland of dccf844a

This was reverted because NetworkContextConfigurationBrowserTests
were failing on Mac due to crbug.com/843324. This is because those
tests call AddSimulatedFailure() on the host resolver, which now
sends those rules to NetworkServiceTest (which doesn't work on Mac).
I disabled the NetworkContextConfigurationBrowserTests on Mac that
run with network service enabled.

Original change's description:
> Convert dns_api.cc to mojo host resolver
>
> Bug: 874658
> Cq-Include-Trybots: luci.chromium.try:linux_mojo
> Change-Id: I576d2877ec71df8e489d349916f758ba6fe74263
> Reviewed-on: https://chromium-review.googlesource.com/1176725
> Reviewed-by: Will Harris <wfh@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Commit-Queue: Clark DuVall <cduvall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#583878}

TBR=wfh@chromium.org,jam@chromium.org

Bug: 874658
Change-Id: Ib26c612a450a48818a10f817bd2d309292d4c9ea
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1179922Reviewed-by: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584122}