- 17 Dec, 2019 40 commits
-
-
Yann Dago authored
Bug: 1009162 Change-Id: I2eb0819e55257184b0b81467827dc7e145a47234 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969970Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#725531}
-
Vasilii Sukhanov authored
TBR=asvitkine@chromium.org Bug: 986298 Change-Id: Ia1540bd7e110c06388c059afe81e65fc1fdf922e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970174 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#725530}
-
Anders Hartvoll Ruud authored
Some properties cascade separately, but use the same storage location on ComputedStyle. For example, -webkit-writing-mode and writing-mode, or css-logical properties and their physical counterparts. Such situations can not be resolved cascade-time (at least not always), hence we need a way to solve this apply-time. There is currently a mechanism for dealing with writing-mode and zoom: StyleCascade::Filter. The same mechanism can be used for css-logical properties, however, since it would mean maintaining a large switch by hand, this CL generates code for it instead. Any property which has some other property map to it, is called a "slot". Slots are marked as such in css_properties.json5 ('is_slot'), and properties also specify which slots they map to ('slots'). See StyleCascade::Resolver::SetSlot for a more detailed explanation. Note that this CL adds support for mapping a property to more than one slot, which is currently unused, but necessary for supporting -webkit-border-image in the future. BUG=947004,985043 Change-Id: I22f75e32efa41dafbc2f5aaf4fafa0f7b1a53191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967321 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#725529}
-
Muhamed Parić authored
Test: unit_tests --gtest-filter="PluginVmImageManagerDriveTest.*" Bug: 1001463 Change-Id: Ibf89a1b339c75c9f3b61140b69763058251f9256 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967080 Commit-Queue: Muhamed Parić <muhamedp@google.com> Reviewed-by:
Alex Oldemeier <aoldemeier@chromium.org> Cr-Commit-Position: refs/heads/master@{#725528}
-
Weiliang Chen authored
This CL moves the overlay promotion logic that used to be in OverlayCandidateList onto OverlayProcessorAndroid. For Android pre-SurfaceControl code path, we keep track of promotion hints for resources. It was kept on OverlayCandidateList, and it makes implementation of OverlayCandidateList complicated. OverlayProcessorAndroid now implements CheckOverlaySupport, which helps keeping track of the promotion hints. This is CL 13/? of overlay processor refactor. R=rjkroege Bug: 963597 Change-Id: Ia4ff00e1a1f92687505b8ec985ddceec004683b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961082 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#725527}
-
Andreas Haas authored
This CL changes the length field of TypedFlexibleArrayBufferView from unsigned to size_t. The reason is that internally TypedFlexibleArrayBufferView already operates on size_t and currently uses a checked_cast to convert to size_t. To avoid potential renderer crashes I adjusted now ValidateUniformParameters to check the size of the incoming TypedFlexibleArrayBufferView and throw an exception if it is too big. Background: we prepare ArrayBuffers to be bigger than 4GB. Therefore we changed the size field to size_t. Now we are changing all uses of ByteLength to be able to deal with size_t, either by accepting a size_t, or by throwing an exception if the size is too big. R=kbr@chromium.org Bug: chromium:1008840 Change-Id: Iaaacc3672931d11df285876f042cce084c9976c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963803 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#725526}
-
Weiliang Chen authored
After we have split OverlayProcessor into subclasses that is implemented by different platform, move Android pre-SurfaceControl only code to OverlayProcessorAndroid. This is CL 12/? of overlay processor refactor. R=rjkroege Bug: 963597 Change-Id: I162c4a66eabb4674eff7dd2b0e337d18d9ee0153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960072 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a2aa7738b96d..a0a6e29dda17 git log a2aa7738b96d..a0a6e29dda17 --date=short --first-parent --format='%ad %ae %s' 2019-12-17 mathias@chromium.org Add AUTHORS file and presubmit check Created with: gclient setdep -r src/third_party/devtools-frontend/src@a0a6e29dda17 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I35f208c704d638c2a64eedfcffc8bb420b22e529 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971466Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#725524}
-
Weiliang Chen authored
Add an OverlayProcessorStub class that provides empty implementation to OverlayProcessorInterface. This could be used on platforms that don't support overlay. For example linux platforms that doesn't use Ozone don't have overlay. This is CL 11/? of overlay processor refactor. R=rjkroege Bug: 963597 Change-Id: I7be11ad4ac9aa860bb579ae01f4b7d23d68c9ac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960866 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
-
Weiliang Chen authored
Merge the last OverlayCandidateValidatorSurfaceControl class's functionalities into an OverlayProcessorSurfaceControl class, which is a subclass of OverlayProcessorUsingStrategy. This is used for Android SurfaceControl. This is the last of the OverlayCandidateValidator. Delete remaining OverlayCandidateValidator code. This is CL 10/? of overlay processor refactor. R=rjkroege Bug: 963597 Change-Id: I48d660894f41127332f2719ca57805e5df8aa231 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960717 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
-
Ian Kilpatrick authored
We already have logic for this case, but we were unconditionally missing the cache inside of: NGConstraintSpace::MaySkipLayout ... which was bad. The existing logic was: https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/core/layout/ng/ng_layout_utils.cc;l=231;drc=121fca518bce891ce834bb325d600f1e99dd972a?originalUrl=https:%2F%2Fcs.chromium.org%2F Bug: 845235 Change-Id: Ibd34ae655d8ec67c2de2fc777b98b4b7bad42b83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966385Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#725521}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f247162c. With Chromium commits locally applied on WPT: c15c1083 "Add test that datachannels close when connection does." ba9444b7 "html: reflection.js adds test cases of unicode comparisons for 's'." fadf6027 "[css-pseudo] Recalculate viewport units in ::marker" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I3a414980d4cf981681c0f319466b5281d9028054 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971590Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#725520}
-
Tim van der Lippe authored
It should use a let-assignment instead of a var. Change-Id: I6430076cb4a0e8a88e57b497877efb3b1e04ffd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970215 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#725519}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1bcd9c3c16c5..9699b3de8952 git log 1bcd9c3c16c5..9699b3de8952 --date=short --first-parent --format='%ad %ae %s' 2019-12-17 lalitm@google.com Merge "Update doc in gpu related proto" Created with: gclient setdep -r src/third_party/perfetto@9699b3de8952 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ifc000a7cbb812e49d32e3ddddc65a3a750f5b0b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971463Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fcd6bfb5..3e618bf6 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibb86042b83698c22f9c2c8eec761f9f86c5cf09d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971670Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#725517}
-
Arthur Hemery authored
We added COOP parsing and it makes sense to have COEP parsed in the network service as well, for security and consistency reasons. Change-Id: I5cef31934572dd1fab7774488a29085a20fe3e39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926504Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#725516}
-
Xiang Ji authored
Bug: 35021 Change-Id: I228444d8b81d34fa6071fcb3a55facdbeda694f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970763 Auto-Submit: Xiang Ji <jxiang@google.com> Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#725515}
-
Roman Sorokin authored
After this change ChromeVox correctly signals for loaded screens. Bug: 955129 Change-Id: If3b480b3ae0da5e2bc02af065ddd22246e0b991d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953716Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#725514}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3a8df884d169..00a1bcb441d6 git log 3a8df884d169..00a1bcb441d6 --date=short --first-parent --format='%ad %ae %s' 2019-12-17 ilnik@webrtc.org Ensure that unset capture timestamp wouldn't cause incorrect SR rtp timestamps 2019-12-17 srte@webrtc.org Don't allow creation of sockets for wild card IPs in emulated networks. Created with: gclient setdep -r src/third_party/webrtc@00a1bcb441d6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I9da01d6ea542b1bdcfa5617b2e9517e3684fcd93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971462Reviewed-by:
-
Anders Hartvoll Ruud authored
LayoutTheme needs to know whether a form element has been styled by the author or not, versus the style we would have had if no user/author declarations existed for those properties. Currently, we do this by caching the computed values of the affected properties after applying user-agent (non-important) declarations. However, this approach does not work for StyleCascade, since the UA declarations can be overwritten cascade-time, losing the information we need. Therefore, this CL adds the affected properties to the cascade twice: once using the normal name, and once under an -internal-ua counterpart. During Apply, the -internal-ua properties are not applied to ComputedStyle, but instead applied to UAStyle; a short-lived object tied to the lifetime of StyleResolverState. Because -internal properties are UA only, the author has no way of overwriting those values. After Apply, we can then compare the UAStyle, against the corresponding values on ComputedStyle. This CL exceeds the 9-bit limit of CSSPropertyID, so the limit has been bumped to 10 bit. A DataEquals function was necessary on NinePieceImage, since operator== for some reason only does a pointer comparison. Sidenote: While -internal-ua border and background properties must have computed values according to what the user-agent specifies, it does not mean that they are not affected by author declarations at all. Author provided side-effects via high priority properties like 'font-size' and 'zoom' must be reflected in the UAStyle. Hence, we couldn't just apply all the user-agent stuff first (if we had that capability); we'd need to mix in some author declarations in there as well. This is why I think it makes sense to treat them as separate properties. Finally, note that UAStyle is currently unused for now, even when the CSSCascade flag is enabled. A future CL will add low-priority properties to the cascade in general, and this will be the appropriate moment for StyleResolver/UAStyle integration. BUG=947004,1033860 Binary-Size: crbug.com/1033860 Change-Id: I7a5c06a30b0220c334ff2f7529933382a16057bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967238 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6a3eff70748a..a2aa7738b96d git log 6a3eff70748a..a2aa7738b96d --date=short --first-parent --format='%ad %ae %s' 2019-12-17 bmeurer@chromium.org [blink] Sync CSS properties. 2019-12-17 janscheffler@chromium.org Add unit tests to package.json 2019-12-17 szuend@chromium.org Split ModelData.uiLocationToRawLocations into two methods 2019-12-17 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update Devtools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@a2aa7738b96d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1032016,chromium:1032920 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3bbcd5caf113f89415ad2680b7f9b34a0954f642 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971461Reviewed-by:
-
Francois Beaufort authored
This CL adds a second prompt to the existing NFC permission flow. This prompt is about warning user that Android NFC setting is turned off and that they should turn it on manually so that website can interact with NFC devices. A follow-up CL will monitor when Android NFC setting changes. This will allow Chrome to show an infobar to let user know. Screenshots: https://photos.app.goo.gl/L95hrsGkGrB2aRkX8 Change-Id: Icc6d6aca41e1b8169c364e9b20b4d127e6ababf5 Bug: 520391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940241 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#725510}
-
Abhijeet Kandalkar authored
The goal of this CL is to, - Use new downcast helper and remove DEFINE_DOCUMENT_TYPE_CASTS to adopt new downcast helpers. - Use IsA<XMLDocument>(element) in place of IsXMLDocument(element) Bug: 891908 Change-Id: Ie1d5d1cf2bc2dcf8c057ace08e26b9132b755103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969201Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#725509}
-
Michael van Ouwerkerk authored
Also: * drop sharing_ prefix from some file names * update java_package Bug: 1030653 Change-Id: I63a6d55f099e3a79a9337df5330f89008673b2b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970472Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#725508}
-
Stephane Zermatten authored
With this change, prompt actions with allow_interrupt=true can be interrupted. When an element matching an interrupt is found during a prompt with this flag set, the touchable area is covered to allow for the script defined by the interrupt to run. After the interrupt, the touchable area is recovered, and the webpage jumps back to the previously focused element. Implementation-wise, this make prompt use the same logic as WaitForDom for waiting for element and interrupts. This change also allows the same interrupt to be fired more than once during an action. This is necessary as prompt can be long-lived. This was forbidden to prevent loops where the same interrupt would fire right after it's returned, because the DOM hasn't had time to fully update yet. With this change, an interrupt is prevented from firing only for one check (checks are done every 2s) right after it's run. Bug: b/146311363 Change-Id: I5646b6216d00ace198f59be3f2c91a37b1bf1892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967461 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#725507}
-
Sergey Talantov authored
SyncService::DisableReason was implemented as simple bitmask. For this purpose EnumSet is more appropriate. Bug: 864556 Change-Id: I53ac7a5f256092cec91a755eb1b13b2fa0a2c2ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967243Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#725506}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4642612f23bb..1bcd9c3c16c5 git log 4642612f23bb..1bcd9c3c16c5 --date=short --first-parent --format='%ad %ae %s' 2019-12-17 treehugger-gerrit@google.com Merge "Don't use sprintf for hex dumping." 2019-12-17 treehugger-gerrit@google.com Merge "trace processor: Export NaN/Infinity debug annotations to JSON properly" 2019-12-17 fmayer@google.com Merge "Doc fix adb killall -> adb shell killall." Created with: gclient setdep -r src/third_party/perfetto@1bcd9c3c16c5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ifb4a5bbe6b9faab623619e836ee3e56e76adce55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971458Reviewed-by:
-
Tobias Sargeant authored
Bug: 1034767 Change-Id: I31ca13f9e65f7b25c0400c1364dc36d67bc13f33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970560 Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#725504}
-
Oriol Brufau authored
r718609 added support for 'content' in ::marker when using LayoutNG. This patch renames a variable and fixes a comment according to that. It also exposes the counter of a ::marker in CounterValueForElement, which is used by internal tests. BUG=457718 TEST=fast/css/counters/counterValueForElementById.html The test fails in legacy since content in ::marker isn't supported yet. Change-Id: I157d633590cca21fa2b7fe12ef7f37a919e95d62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970559 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/064614205d70..6a3eff70748a git log 064614205d70..6a3eff70748a --date=short --first-parent --format='%ad %ae %s' 2019-12-17 szuend@chromium.org Mark audits web tests as 'slow' 2019-12-17 tvanderlippe@chromium.org Reland "Let console asserts show up in the test results" Created with: gclient setdep -r src/third_party/devtools-frontend/src@6a3eff70748a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1034903 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1e6078abbc99dd7f78b9f08ec16e82e6ed8f1a6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971457Reviewed-by:
-
Mario Sanchez Prada authored
This CL migrates code to the new BrowserInterfaceBroker class. This allows retrieving the remote implementation in the browser process without relying on the InterfaceProvider API. Bug: 936482, 1002647 Change-Id: I191cadc676a5f5876707040d54305a67155921af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953763 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#725501}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3b8e5aa3..fcd6bfb5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I518d62545039b6934a0de2394480173ab293a160 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971490Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=eugenebut@google.com Change-Id: Id016517529a6e8bd99ffcab5a0a2c0848cfbb28c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969981Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#725499}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/bd963dc11651..4642612f23bb git log bd963dc11651..4642612f23bb --date=short --first-parent --format='%ad %ae %s' 2019-12-17 fmayer@google.com Merge "Revert "Disable profilable CTS test."" Created with: gclient setdep -r src/third_party/perfetto@4642612f23bb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I4cef3d7a6586987cbcd1f61635a1854d253cbb7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971455Reviewed-by:
-
Hajime Hoshi authored
Autofill can show a popup for forms. As the popup is bound to WebContents, a popup bound to a frozen frame in the cache might be unexpectedly shown on the current WebContents. It is hard to fix autofill to deal with this. Then let's ban back-forward cache when autofill is used. Bug: 1031076 Change-Id: Ie315412136a11cb656f73b15b40e05ec1d72de7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955248Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#725497}
-
Wei Lee authored
It will consider the available screen width / height and also respect the aspect ratio, trying to find a proper window size before showing window and streaming. Bug: 1015349 Test: Manually tested and the issue is fixed on kip. Change-Id: If6e8f98b3e93ee4555faec6956f1d673418ceeca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969081 Commit-Queue: Wei Lee <wtlee@chromium.org> Auto-Submit: Wei Lee <wtlee@chromium.org> Reviewed-by:
Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#725496}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fdb2b7d53038..cbeabd969bbe git log fdb2b7d53038..cbeabd969bbe --date=short --first-parent --format='%ad %ae %s' 2019-12-17 reed@google.com Can't fold ctm and color matrix when in perspective Created with: gclient setdep -r src/third_party/skia@cbeabd969bbe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: I66b4124412539c6512619c74c11755c79205af86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971454Reviewed-by:
-
Rune Lillesveen authored
If a style changes between -webkit-linear-gradient and -linear-gradient, consider them different. There is an issue with values being flipped in order which made us not paint invalidate when the start/stop values were flipped. We could probably have optimized this by detecting this flip, but for simplicity consider gradients of different type different. Bug: 713407 Change-Id: I53d9a8d0f517fb3f587c34aeb8fa04f4432a69c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970991Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#725494}
-
Ramin Halavati authored
Autofocus will be back for incognito tab launch intents. In a next CL this feature will be moved behind a 1P only check. Bug: 1030188 Change-Id: I9c419b43a83295f4abf4abbb2e9b91aeedf16a7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970614Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Auto-Submit: Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#725493}
-
Camille Lamy authored
This CL removes the provisional DocumentLoader from FrameLoader. This corresponds to the step 8k in the linked doc in the bug. Bug: 855189 Change-Id: I8da13d8556fea3051e9172d9042c50dca565c92a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670867Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#725492}
-
