GitLab

BUG=68910
TEST=playing a compressed wave should fail gracefully

Review URL: http://codereview.chromium.org/6288008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71801 0039d316-1c4b-4281-b951-d872f2087c98

situation where the opener ends up the same as the tab being
closed. The only way I could see this happening is a new tab getting
the same address as a tab that was deleted. This seems unlikely, but
I've added the code to make sure we clean up properly when a tab is
deleted. I'm also adding a couple more checks.

BUG=34135
TEST=none

Review URL: http://codereview.chromium.org/6346008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71800 0039d316-1c4b-4281-b951-d872f2087c98

ResourceHandler's expect to be deleted on the IO thread after their ref count goes to 0. Change the unit test to explicitly drop ref count and run the IO thread's message loop.

BUG=69414
TEST=valgrind trybots

Review URL: http://codereview.chromium.org/6136006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71798 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=brettw

Review URL: http://codereview.chromium.org/6361002


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71797 0039d316-1c4b-4281-b951-d872f2087c98

Weak symbols are either broken or they don't work the way that we need.
Either way, the current weak symbol based scheme is causing
runtime-linker aborts on systems without NSS 3.12.6.

This change switches to using dlsym to lookup the symbol at runtime.

BUG=69345
TEST=Run chrome on systems with libnss.so < 3.12.6

http://codereview.chromium.org/6250008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71796 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=still works

Review URL: http://codereview.chromium.org/6307006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71795 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6296014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71794 0039d316-1c4b-4281-b951-d872f2087c98

the new code location under Source/.

Review URL: http://codereview.chromium.org/6264004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71793 0039d316-1c4b-4281-b951-d872f2087c98

This change will enable a fix for issue 57289, which requires a different base directory for extensions.

BUG=70111
TEST=ExtensionServiceTest.ExternalPrefProvider

Review URL: http://codereview.chromium.org/6293006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71792 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/6241008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71791 0039d316-1c4b-4281-b951-d872f2087c98

BUG=64877
TEST=Existing unittests; manual testing.

Review URL: http://codereview.chromium.org/6310012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71790 0039d316-1c4b-4281-b951-d872f2087c98

Revert http://src.chromium.org/viewvc/chrome?view=rev&revision=70896 to move speech input back behind a flag.
We have more work to do and the feature isn't ready for M10 so moving it back behind a flag.

BUG=61677
TEST=browser_tests --gtest_filter="SpeechInputBrowserTest.*"

Review URL: http://codereview.chromium.org/6353005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71789 0039d316-1c4b-4281-b951-d872f2087c98

BUG=60634, 67627
TEST=Manually interfere with Temp directory creation, see that expected failures happen.

Review URL: http://codereview.chromium.org/6297003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71788 0039d316-1c4b-4281-b951-d872f2087c98

This should address the wtc review in http://codereview.chromium.org/6338002/

BUG=64263
TEST=trybots

Review URL: http://codereview.chromium.org/6322003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71787 0039d316-1c4b-4281-b951-d872f2087c98

Also fix the following error when we try to get the width of column that does not exist anymore.

(views_examples:3921): Gtk-CRITICAL **: gtk_tree_view_column_get_width: assertion `GTK_IS_TREE_VIEW_COLUMN (tree_column)' failed

BUG=None
TEST=export GYP_DEFINES="toolkit_views" && gclient runhooks && make -j4 -k views_examples
     out/Debug/views_examples, go to the table tab. Now clicking in one of the checkboxes,
     the corresponded column should be removed.

Review URL: http://codereview.chromium.org/6256004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71786 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:9344, chromium-os:10605
TEST=manual

Review URL: http://codereview.chromium.org/6320007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71785 0039d316-1c4b-4281-b951-d872f2087c98

Make sure we show the restart message if system level Chrome has been upgraded manually by the user.

Also add scoped_allowio until they can be evaluated (see bug).

BUG=66715
TEST=See bug for details.

Review URL: http://codereview.chromium.org/6243007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71784 0039d316-1c4b-4281-b951-d872f2087c98

BUG=48383
TEST=Add or remove some files to a default plugin location and check in about:plugins whether the change got detected. Also part of integration tests.

Review URL: http://codereview.chromium.org/6163003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71783 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70092
TEST=GoogleUpdateTest.StatsConstent
TBR=cevans

Review URL: http://codereview.chromium.org/6354007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71782 0039d316-1c4b-4281-b951-d872f2087c98

Adjust the Find test for unselectable test so that it has the right expectation now that my change has been merged down.

BUG=68494
TEST=Fixing a test.

Review URL: http://codereview.chromium.org/6289007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71779 0039d316-1c4b-4281-b951-d872f2087c98

To make sure that all policy definitions match the expected format. The checker is called as a presubmit hook, and can also be invoked manually. Run it without any parameters (or with --help) to get usage information.

BUG=69527
TEST=manual: checker reports no errors for correct policy definitions, checker complains for malformed policy definitions, checker is invoked as presubmit hook when policy_templates.json has been changed

Review URL: http://codereview.chromium.org/6299001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71778 0039d316-1c4b-4281-b951-d872f2087c98

(I'm not sure about other platforms; on Linux, GTK has the weird quirk of
firing "context menu closed" before "context menu item selected", so it's
best to use a solution that doesn't try and track the visibility state of the
context menu).

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/6335008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71777 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71775 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=GoogleUpdateSettings::SetCollectStatsConsent
TBR=cevans

Review URL: http://codereview.chromium.org/6281008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71773 0039d316-1c4b-4281-b951-d872f2087c98

BUG=68751
TEST=mac passes


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71772 0039d316-1c4b-4281-b951-d872f2087c98

TBR=hclam

BUG=70076
TEST=browser_tests
Review URL: http://codereview.chromium.org/6241007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71771 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jam

BUG=70075
TEST=ipc_tests
Review URL: http://codereview.chromium.org/6304010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71770 0039d316-1c4b-4281-b951-d872f2087c98

We should probably have also more detailed OWNERS file below
in the file hierarchy. For example, for pyauto and webdriver.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6370003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71769 0039d316-1c4b-4281-b951-d872f2087c98

Change the Regkey helper to consistently use and return LONG
instead of bool.  Fix RegKey usage all over the code base and
get rid of workarounds due to lack of return value.

Reviewers:

brettw: everything (skip parts for other reviewers if you wish)
robertshield,grt: chrome_frame, installer
siggi: ceee


BUG=none
TEST=covered by existing tests



Review URL: http://codereview.chromium.org/6090006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71768 0039d316-1c4b-4281-b951-d872f2087c98

This still fixes the original bug and does it in a much simpler (and faster)
way. I was previously attempting to use an API to do this rather than just
setting the style directly but that API may have hidden side effects like
causing a window activation on some versions of Windows.

BUG=69724
TEST=WidgetWinTest::SetBoundsForZoomedWindow

Review URL: http://codereview.chromium.org/6331006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71767 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:8307
TEST=Compiled and saw it runs on netbook.

Review URL: http://codereview.chromium.org/6336005
Patch from Matt Falken <falken@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71766 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70000
TEST=clang/linux bots are 5x as fast.

Review URL: http://codereview.chromium.org/6324007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71765 0039d316-1c4b-4281-b951-d872f2087c98

BUG=61609
TEST=none
Review URL: http://codereview.chromium.org/6310011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71764 0039d316-1c4b-4281-b951-d872f2087c98

This change just suppresses the leaks for Bug 70062. (Unfortunately, I'm not totally sure why these leaks happen on these bots because "net/socket/ssl_client_socket_nss.cc" has not been changed these days. Since the only change under 'net/socket' is r71739 <http://crrev.com/71739>, it emerged these leaks?)

TBR=thestig,timurrrr 
BUG=70062
TEST=make the "Linux Tests (valgrind)(3)" bot and the "Chromium OS UI (valgrind)(3)" bot green.
Review URL: http://codereview.chromium.org/6290007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71763 0039d316-1c4b-4281-b951-d872f2087c98

This change removes the suppression rule for Bug 69906 because this leak seems to be fixed by r71641 <http://crrev.com/71641>. (Our heapchecker bots already works well without the suppressions for this bug.)

TBR=thestig,timurrrr 
BUG=69906
TEST=make the valgrind bots green without suppressions.
Review URL: http://codereview.chromium.org/6254008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71762 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://code.google.com/p/chromium/issues/detail?id=63695
TEST=http://www.zontera.com/banners/clients_work/floating_flash/centered/dove/

Review URL: http://codereview.chromium.org/6266009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71761 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=manually, trybots

Review URL: http://codereview.chromium.org/6284003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71760 0039d316-1c4b-4281-b951-d872f2087c98

this isn't needed any more.

BUG=none
TEST=trybots

Review URL: http://codereview.chromium.org/6269010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71759 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/6327009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71756 0039d316-1c4b-4281-b951-d872f2087c98

return the chrome browser process pid. In ChromeFrame we don't use the launcher which results
in a crash while running a number of perf tests. Added a helper function to return the browser
pid.

Added a handler for intercepting and debugging pure call errors in chrome frame perf tests.

BUG=none
TEST=ChromeFrame perf tests should run to completion.
TBR=amit

Review URL: http://codereview.chromium.org/6306004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71755 0039d316-1c4b-4281-b951-d872f2087c98