Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 11 Sep, 2018 35 commits
  3. 10 Sep, 2018 5 commits
    • Yuly Novikov's avatar
      Revert "[ozone/wayland] Refactor IME deps for ozone platform" · 6e18cb2b
      Yuly Novikov authored 
      This reverts commit 40a87fcf.

Reason for revert: Breaks "compile" in Debug and "compile confirm no-op" in Release

Original change's description:
> [ozone/wayland] Refactor IME deps for ozone platform
> 
> Refactor base/ime components and dependencies for ozone
> plaform integration to avoid cyclic dependencies.
> 
> - Groups ui/base/ime common types into their own GN component
>   (ime_types) to break a dependency cycle that ozone ime context
>   integration would cause on ChromeOS.
> - Groups some of ui/base/ime/linux interfaces into their own GN
>   component (ime_linux) to break a dependency cycle that ozone
>   ime context integration would cause on ChromeOS.
> - Move chromeos source files under is_chromeos flag to avoid
>   depending them when chromeos is not used, but ime is needed
>   (kudos to msisov@igalia.com).
> 
> Bug: 791920
> Change-Id: I0b1668564dde22c6e2b05ee1323ebbe4a1343475
> Reviewed-on: https://chromium-review.googlesource.com/1193871
> Commit-Queue: Jani Hautakangas <jani.hautakangas@lge.com>
> Reviewed-by: Shu Chen <shuchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#590072}

TBR=shuchen@chromium.org,yhanada@chromium.org,tonikitoo@igalia.com,msisov@igalia.com,jani.hautakangas@lge.com

Change-Id: I5b032277b66ff9d5f6daca34425c5464736db77e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 791920
Reviewed-on: https://chromium-review.googlesource.com/1217849Reviewed-by: default avatarYuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590119}
      6e18cb2b
    • Karan Bhatia's avatar
      UrlPatternIndex: Implement case-insensitive matching. · a9c4e1d4
      Karan Bhatia authored 
      This fixes an existing TODO in url_pattern_index to implement case-insensitive
matching. To do so:
  - Lower case the stored n grams. These n grams are used to find prospective
    matches for a particular url.
  - Modify URLPattern to handle case-insensitive matching. This involves
    lower-casing the url pattern and the url, before comparing them.

BUG=767605

Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: I1377c216d61392c508280141d0d947a47a3ee494
Reviewed-on: https://chromium-review.googlesource.com/1212183Reviewed-by: default avatarCharlie Harrison <csharrison@chromium.org>
Reviewed-by: default avatarNed Nguyen <nednguyen@google.com>
Reviewed-by: default avatarIstiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590118}
      a9c4e1d4
    • Kevin Strohbehn's avatar
      Long Press on Inactive Search Box no longer causes touch handle to appear · a9970a07
      Kevin Strohbehn authored 
      Bug: 882643
Change-Id: I6681f064e8a21ac5557c4c2adb4633af248e0119
Reviewed-on: https://chromium-review.googlesource.com/1217756Reviewed-by: default avatarWeidong Guo <weidongg@chromium.org>
Commit-Queue: Kevin Strohbehn <ginko@google.com>
Cr-Commit-Position: refs/heads/master@{#590117}
      a9970a07
    • Jia Meng's avatar
      Revert "Reland "[On-device adaptive brightness] Implement an AlsReader to ambient light."" · 511b8c96
      Jia Meng authored 
      This reverts commit a609f4ac.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Reland "[On-device adaptive brightness] Implement an AlsReader to ambient light."
> 
> 
> Original change's description:
> > Revert "[On-device adaptive brightness] Implement an AlsReader to ambient light."
> > 
> > This reverts commit ea692f36.
> > 
> > Reason for revert: broke the linux-chromeos-dbg (https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/7744)
> > 
> > Original change's description:
> > > [On-device adaptive brightness] Implement an AlsReader to ambient light.
> > > 
> > > 
> > > Bug: 881215
> > > Change-Id: I1cd5bf7ea517e426b54df1f4ebbb5a843b991dbe
> > > Reviewed-on: https://chromium-review.googlesource.com/1209000
> > > Reviewed-by: Michael Martis <martis@chromium.org>
> > > Reviewed-by: Dan Erat <derat@chromium.org>
> > > Commit-Queue: Jia Meng <jiameng@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#589843}
> > 
> > TBR=derat@chromium.org,jiameng@chromium.org,martis@chromium.org
> > 
> > Change-Id: Id12029b7d3b46eaed672525fe0bcf96960ea143c
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 881215
> > Reviewed-on: https://chromium-review.googlesource.com/1215603
> > Reviewed-by: Jia Meng <jiameng@chromium.org>
> > Commit-Queue: Jia Meng <jiameng@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#589850}
> 
> TBR=derat@chromium.org,jiameng@chromium.org,martis@chromium.org
> 
> Change-Id: I8f170731509b2b23d469519fd45d5876175111d5
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 881215
> Reviewed-on: https://chromium-review.googlesource.com/1217962
> Reviewed-by: Jia Meng <jiameng@chromium.org>
> Commit-Queue: Jia Meng <jiameng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#590115}

TBR=derat@chromium.org,jiameng@chromium.org,martis@chromium.org

Change-Id: Idc8436b6fcf1140e5c30912d4c0727e867c2cb9b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 881215
Reviewed-on: https://chromium-review.googlesource.com/1217982Reviewed-by: default avatarJia Meng <jiameng@chromium.org>
Commit-Queue: Jia Meng <jiameng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590116}
      511b8c96
    • Jia Meng's avatar
      Reland "[On-device adaptive brightness] Implement an AlsReader to ambient light." · a609f4ac
      Jia Meng authored 
      
Original change's description:
> Revert "[On-device adaptive brightness] Implement an AlsReader to ambient light."
> 
> This reverts commit ea692f36.
> 
> Reason for revert: broke the linux-chromeos-dbg (https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/7744)
> 
> Original change's description:
> > [On-device adaptive brightness] Implement an AlsReader to ambient light.
> > 
> > 
> > Bug: 881215
> > Change-Id: I1cd5bf7ea517e426b54df1f4ebbb5a843b991dbe
> > Reviewed-on: https://chromium-review.googlesource.com/1209000
> > Reviewed-by: Michael Martis <martis@chromium.org>
> > Reviewed-by: Dan Erat <derat@chromium.org>
> > Commit-Queue: Jia Meng <jiameng@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#589843}
> 
> TBR=derat@chromium.org,jiameng@chromium.org,martis@chromium.org
> 
> Change-Id: Id12029b7d3b46eaed672525fe0bcf96960ea143c
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 881215
> Reviewed-on: https://chromium-review.googlesource.com/1215603
> Reviewed-by: Jia Meng <jiameng@chromium.org>
> Commit-Queue: Jia Meng <jiameng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#589850}

TBR=derat@chromium.org,jiameng@chromium.org,martis@chromium.org

Change-Id: I8f170731509b2b23d469519fd45d5876175111d5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 881215
Reviewed-on: https://chromium-review.googlesource.com/1217962Reviewed-by: default avatarJia Meng <jiameng@chromium.org>
Commit-Queue: Jia Meng <jiameng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590115}
      a609f4ac