- 31 Dec, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c7539abc143c..5b5077c52716 git log c7539abc143c..5b5077c52716 --date=short --first-parent --format='%ad %ae %s' 2019-12-31 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update Devtools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@5b5077c52716 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I05eb9c7c7740edcabbf70335955e0a74d65cab36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984859Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727875}
-
Matt Falkenhagen authored
This matches process id and routing id in //content which are signed ints. Bug: 853867 Change-Id: I09c5999419c95708546e69dea61562e517fc6f5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981517Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#727874}
-
Gauthier Ambard authored
The Signin test were missing the dependency for the the app interface for EG2, leading to "unrecognized selector" error when running the test. Bug: none Change-Id: Iee424c0ca4a09472a7ccdadfff60aaf8381903b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985001 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#727873}
-
Maksim Ivanov authored
Add a test mixin for the ScopedTestSystemNSSKeySlot class, in order to simplify its usage in browser tests. This mixin is used in the WebviewClientCertsLoginTest tests, and will also be used in the future tests of the Chrome OS smart card user login. Bug: 1033936 Change-Id: If8f6b578b4dceb9805cc431fd5803f79c2a1d388 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967246 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#727872}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c9e75ab1ff47..b3788f22c908 git log c9e75ab1ff47..b3788f22c908 --date=short --first-parent --format='%ad %ae %s' 2019-12-31 khokhlov@google.com Reland "Reland "[Telemetry] Make proto trace format the default"" Created with: gclient setdep -r src/third_party/catapult@b3788f22c908 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1028612 Tbr: rmhasan@google.com Change-Id: Ifbffcda56802cd5b133a445bdfe9f552f34c898e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984905Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0ec2c7a2dc05..45d19fe06398 git log 0ec2c7a2dc05..45d19fe06398 --date=short --first-parent --format='%ad %ae %s' 2019-12-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 fca5a005aa88..942d91520aa8 (5 commits) 2019-12-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 59465799210b..10a900e5ffaf (1 commits) 2019-12-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 4d93cdf1..39f22a4b (126 commits) Created with: gclient setdep -r src/third_party/skia@45d19fe06398 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC nifong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nifong@google.com Change-Id: I67aa6817f5a39ea59a780da1d169e3f9fb839b73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984960Reviewed-by:
-
Regan Hsu authored
Currently, the arabic text within the buttons of the top header contents are misaligned. This CL sets a line height that matches the font size so that the text is aligned properly. Before: https://screenshot.googleplex.com/0oXw7thLSmn After: https://screenshot.googleplex.com/q2FWsqLdyKU Fixed: 1038004 Change-Id: I26d091523797bef1543f310c314ace70f3eaf738 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984471 Auto-Submit: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Gauthier Ambard authored
The test is failing for all config. TBR=stkhapugin@chromium.org Bug: 1036225 Change-Id: I3f9de1775e5be694c7131bf2cce18571324cc375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985000Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#727868}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4c53f9a5..e7dd8e8d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I82f0b848b5ef4bd5b5b96921bcfedd0f82669d53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984255Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727867}
-
Mitsuru Oshima authored
Refactored ash shell test harness so that test can provide prefs data. Confirmed that the test fails without fix. Bug: 1038374 Test: covered by unittest. also manually tested on device. Change-Id: Ic80f204993657a3b7b14a53dfbb0f17adbf70afb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982707Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Mitsuru Oshima (OOO til 12/30) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#727866}
-
Gauthier Ambard authored
WebStateDelegateTabHelperTest.GetJavaScriptDialogPresenter is failing. Disabling it. TBR=eugenebut@chromium.org Bug: 1038514 Change-Id: I175e3fc76f1f71e60bc6bd79027f7722ea7c3b0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984999 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll broadwell AFDO profile from 81-3987.18-1577704324-benchmark-81.0.4011.0-r1 to 81-3987.18-1577704324-benchmark-81.0.4012.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I751ae41941d2cb88ed5f41e01a30e8ffb8128db7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984904Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I9f099a04a5dc36c561982d661a2220b14ec9770e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984869Reviewed-by:
-
Gauthier Ambard authored
This reverts commit 9d22c0b9. Reason for revert: InfobarBannerOverlayMediatorTest.SetUpConsumer is failing on smoke (iOS 13, iPhone simulator) https://ci.chromium.org/p/chrome/builders/ci/smoke/36760. I am not able to reproduce locally. Original change's description: > [iOS] Add UI support for infobar banner overlays. > > InfobarBannerOverlayCoordinator is a coordinator that will be shared > amongst all infobar banners. InfobarBannerOverlayMediator is a > superclass that implements behavior shared amongst all InfobarTypes, > such as setting the consumer, dispatching responses for user > interaction events, and setting up the overlay completion response. > > This CL also introduces the response infos necessary for banners: > - InfobarBannerConfirmButtonTapped is dispatched to notify the model > layer that the main button on a confirm infobar banner was tapped. > - InfobarBannerModalButtonTapped is dispatched to notify the model > layer that the modal button was tapped. > - InfobarBannerCompletion is used a completion response and stores > whether the dismissal was user-initiated. > > Bug: 1030357 > Change-Id: Ic08d76cb6b65638ebf26986116f5afd960251277 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970551 > Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> > Reviewed-by: Sergio Collazos <sczs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#727785} TBR=kkhorimoto@chromium.org,sczs@chromium.org Change-Id: I34685348049a79be1676e8aaa7431a51f599a029 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1030357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984318Reviewed-by:
-
Leon Han authored
The spec https://w3c.github.io/web-nfc/#the-record-type-string says " Two external types MUST be compared character by character, in case-insensitive manner. " BUG=520391 Change-Id: Ic8671ad6e0ec719ab692507b45f2893f9d1b4c01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980865 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Cr-Commit-Position: refs/heads/master@{#727861}
-
chromium-autoroll authored
Roll silvermont AFDO profile from 81-3987.18-1577705382-benchmark-81.0.4011.0-r1 to 81-3987.18-1577705382-benchmark-81.0.4012.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I6c96a439c8e70c190a183018758b3e722df2a278 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984903Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 42b687e7. With Chromium commits locally applied on WPT: c15c1083 "Add test that datachannels close when connection does." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I062da4e5f9bb5a9260f7e798b7c7fb9722acc6f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984256Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727859}
-
Virender Singh authored
This CL adds following information to PDFAccessibilityTree - ax::mojom::IntAttribute::kScrollXMin - ax::mojom::IntAttribute::kScrollXMax - ax::mojom::IntAttribute::kScrollX - ax::mojom::IntAttribute::kScrollYMin - ax::mojom::IntAttribute::kScrollYMax - ax::mojom::IntAttribute::kScrollY It enables partial implementation of IScrollProvider, following methods will work with this change - IScrollProvider::get_HorizontallyScrollable - IScrollProvider::get_VerticallyScrollable - IScrollProvider::get_HorizontalScrollPercent - IScrollProvider::get_VerticalScrollPercent This information is required by Screen readers to announce the current scroll position and extent of scroll to the user. Tests: The best way to test this change will be through browser tests. However, it requires the second part of the change, detailed in the associated bug, to be completed. Bug: 1034521 Change-Id: I11067b2af4d5bd73e62d89c8ce86fb00b5f3f7ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969412Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Virender Singh <virens@microsoft.com> Cr-Commit-Position: refs/heads/master@{#727858}
-
Abhijeet Kandalkar authored
The goal of this CL is to use new downcast helper and remove DEFINE_TIMING_FUNCTION_TYPE_CASTS to adopt new downcast helpers. This CL removes DEFINE_TIMING_FUNCTION_TYPE_CASTS for below classes. - LinearTimingFunction, - CubicBezierTimingFunction, - StepsTimingFunction Bug: 891908 Change-Id: I6485f964d3715ba13d5bdf503b4f6d1028379f40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983112 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#727857}
-
Abhijeet Kandalkar authored
The goal of this CL is to remove DEFINE_DOCUMENT_TYPE_CASTS and use new downcast helper for HTMLDocument class. Bug: 891908 Change-Id: I7eab4f7f4b3be69abb10a124ed00dee9eda28e27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971184Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#727856}
-
Yuki Shiino authored
Implements Interface.exposed_constructs that returns a list of the constructs that are exposed on the global object. Bug: 839389 Change-Id: I1e6dbc119e3371818ed418829e530214b76d2497 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983116Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#727855}
-
Peter Kasting authored
This makes it possible to use with base::Bind() and should generate better code as well. This also triggered security warnings about calling StringPrintf() with non-format-strings (like "Hello" instead of "%s", "Hello"), so switched the affected callers to call LogStatus(), the underlying function PrintStatus() wraps. This also required properly forward-declaring LogStatus() in example_window.h instead of just doing so in example_base.cc. Also a few other misc. bits of cleanup while I was touching this. Bug: none Change-Id: I2cd2fcf4a47842fa6a9c3da147d96c0e8af31cab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983429 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#727854}
-
Leon Han authored
The spec change: https://github.com/w3c/web-nfc/pull/474/ BUG=520391 Change-Id: If1e4a6513410f3705bec4da7b2cc514c209a3cd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978622 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by:
François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#727853}
-
Wez authored
Allow the discardable GPU cache size to be configured via the command- line and from the WebEngine config. Bug: 1020358 Change-Id: Ida99520eef8a2633fe504e3867609ae82108b624 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941196 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#727852}
-
Tiancong Wang authored
Many Chrome OS bots started to run out of memory when linking Chrome with ThinLTO. Will use ThinLTO cache as a workaround. Note this might increase build time in Chrome OS for ~30min. TBR=thakis@chromium.org Bug: chromium:1038040, chromium:964328 Test: None Change-Id: I95474cb23820c3c5cb109f74cfc87e74178700a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984355 Commit-Queue: George Burgess <gbiv@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
George Burgess <gbiv@chromium.org> Reviewed-by:
Tiancong Wang <tcwang@google.com> Cr-Commit-Position: refs/heads/master@{#727851}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c65d0069ec56..0ec2c7a2dc05 git log c65d0069ec56..0ec2c7a2dc05 --date=short --first-parent --format='%ad %ae %s' 2019-12-31 mtklein@google.com Revert "refresh image shader cs/at logic" 2019-12-31 mtklein@google.com Revert "clarify that there's no kMedium here" 2019-12-31 mtklein@google.com Revert "pass more information to shaders" 2019-12-31 csmartdalton@google.com Rename GpuPathRenderers::kAll to kDefault 2019-12-31 csmartdalton@google.com Add a mechanism to insert framebuffer barriers for NVIDIA tessellation 2019-12-31 mtklein@google.com pass more information to shaders 2019-12-30 brianosman@google.com Make it safe to include SkRuntimeEffect.h from client code 2019-12-30 mtklein@google.com clarify that there's no kMedium here 2019-12-30 mtklein@google.com refresh image shader cs/at logic 2019-12-30 brianosman@google.com More SkRuntimeEffect tests Created with: gclient setdep -r src/third_party/skia@0ec2c7a2dc05 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC nifong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nifong@google.com Change-Id: I9eba9cef98ea51cb6ab25f16749ec52264d0bbbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984697Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: Ic25a06c870128707ef6dcaa1315108729e2cf114 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984641Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727849}
-
Aaron Gable authored
a5bcbd72 Update default VS to 2019 ff241a58 Update Rust example to match modern gn needs. 56246794 Fix quoting preprocessor defines for compilation database Bug: 1038361 Change-Id: I74a864e0d4ec41bae0795353a30e2c032a580c14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984714Reviewed-by:Peter Kasting <pkasting@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Auto-Submit: Aaron Gable <agable@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#727848}
-
Mason Freed authored
Prior to [1], these tests were run with and without the FormControlsRefresh feature enabled. Therefore, they needed to check the state of the flag to alter their behavior. After [1], these tests are only run with the feature enabled, and therefore do not need to check. TBR=wangxianzhu@chromium.org [1] https://chromium-review.googlesource.com/c/chromium/src/+/1888124 Change-Id: I6704d3a8c2daab3eeefaabe22b6c5a8592b8c870 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984698Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#727847}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I67de5512136d26cdf450e3cbee90bde669a548af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982678Reviewed-by:
-
Kent Tamura authored
* Fold HTMLInputElement::IsInRequiredRadioButtonGroup() into RadioInputType::ValueMissing(), which was the only caller. * Move HTMLInputElement::CheckedRadioButtonForGroup() to RadioInputType because it is used only by RadioInputType. * Make HTMLInputElement::GetRadioButtonGroupScope public because now it is used by RadioInputType. This CL has no behavior changes. Change-Id: I1811e208cf071d4e657d9f88e393dfdd1d2fe800 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982512Reviewed-by:
-
Kent Tamura authored
Specification: https://www.w3.org/TR/1999/REC-xpath-19991116/#NT-ExprWhitespace Bug: 1036767 Change-Id: I337ec70fefe8259d50bcf89a67b6e73c68fa585f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980251Reviewed-by:
-
Kent Tamura authored
According to the last two paragraphs of [1], UA should dispatch 'input' and 'change' events if it fills control values on behalf of a user. [1] https://html.spec.whatwg.org/C/#common-input-element-events Bug: 1037728 Change-Id: Ic389cc4e3bc4523f740b0164ac863baba66dcd35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981241Reviewed-by:
-
Robert Woods authored
NavigateApplicationWindow (previously ShowApplicationWindow) has been refactored to only show the application window, but we still need the ability to handle files in a tab. This CL lifts the file handling functionality up so that it works for apps that open in tabs as well as in windows. Bug: 829689 Change-Id: I6870d5a399ef993401b35d024bae06fe6269cac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961291 Commit-Queue: Robert Woods <robertwoods@google.com> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#727842}
-
Mason Freed authored
With this CL, recursive custom element constructions are no longer allowed. I.e. this will now only run the constructor once: class extends HTMLElement { constructor() { super(); customElements.upgrade(this); } } Previously, the code and spec had a bug which caused the above code snippet to infinitely recurse. In [1] the spec has changed, to set the custom element state to "failed" before the constructor is called. With this change in place, recursive calls will early-out at step #2 (of [2]), and avoid the recursion. [1] https://github.com/whatwg/html/pull/5126 [2] https://html.spec.whatwg.org/multipage/custom-elements.html#upgrades Bug: 966472 Change-Id: I76e88c0b70132eee2482c304ef9e727ae1fe8fc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931644Reviewed-by:Kent Tamura <tkent@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#727841}
-
Wenyu Fu authored
Creating RadioButtonWithEditText to achieve entering customized URL in a radio button group. By extending RadioButonWithDescription, this new UI widget shared most of the margin and style with the original button. Bug: 1036470 Change-Id: I395120490303e4a2f150248c551a8f1e952c4c0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966355 Auto-Submit: Wenyu Fu <wenyufu@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#727840}
-
Mason Freed authored
There were several performance regressions after [1] consolidated some NodeType bits from individual flags to a bitmask. This CL attempts to optimize back some of that performance. [1] https://chromium.googlesource.com/chromium/src/+/196a45a23b1e0c1ad89c125a0877ce367b6b4bf3 Bug: 1036088, 1036089 Change-Id: I24b263cc7360c0178b76d759268406630f99a5cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978913 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Michael Crouse authored
This change limits the number of hosts that are requested requested by the prediction model fetcher from the remote optimization guide service and is finch controllable. This will improve the request latency and load on the remote optimization guide service. It will also limit the total number of host model features maintain on the client. Additionally, only hosts that are not already in the host model features cache will be included in the request. This change also implements a least-recently-used in-memory cache for the host model features that the prediction manager maintains. The maximum size is controllable via finch and the default is set to hold 95% of all users hosts without needing to evict any host model features. Bug: 1036399 Change-Id: Ice9ab7c3c3505fc970ab72e1c78f5d628cd5157b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981632 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#727838}
-
Peter Boström authored
This is used in place of the tab-icon loading indicator as the favicon is not visible when the tab strip is hidden. Bug: chromium:1027377 Change-Id: I40c6e6b38023bfae4b5e9993bd9c9f4c8b2bbb3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959340 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#727837}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I917a989fd45bcfaf90cd9258e74d001d2122de12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984688Reviewed-by:
-
