GitLab

BUG=638744
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2279963002
Cr-Commit-Position: refs/heads/master@{#414636}

This patch adds a call to USBDEVFS_DISCARDURB when we time out a USB
transfer. This causes the host controller to stop polling the device for
data and means that a later transfer will receive the next bytes that
are sent from the device. Otherwise those bytes will be claimed by the
cancelled transfer and discarded.

BUG=640725

Review-Url: https://codereview.chromium.org/2274343002
Cr-Commit-Position: refs/heads/master@{#414635}

If PreferHtmlOverPlugins feature is enabled, map the obsolete ASK setting to DETECT_IMPORTANT_CONTENT.

More info about Html5 by Default here: go/hbd-design-doc

BUG=626728

Review-Url: https://codereview.chromium.org/2264583003
Cr-Commit-Position: refs/heads/master@{#414634}

Revert of Make calling SetHeader() with invalid value fatal (patchset #1 id:1 of https://codereview.chromium.org/2143903002/ )

Reason for revert:
This CL has served its purpose of finding bad callers of SetHeader() and should be reverted before the branch point.

Original issue's description:
> Make calling SetHeader() with invalid value fatal
>
> crrev.com/2134083003 made net::HttpUtil::IsValidHeaderValue() reject
> individual CR and NL as well as CRNL.
>
> I believe that all callers of net::HttpRequestHeaders::SetHeader() and
> SetHeaderIfMissing() which use user-supplied values already verify the
> value with IsValidHeaderValue() first. However, to be sure, temporarily
> make it a fatal error to call SetHeader() with an invalid value.
>
> If you see a crash attributed to this CL:
>
> 1. Associate it with the bug.
> 2. Follow the stack flow to work out how untrusted data ended up
> being passed to SetHeader().
> 3. Add a call to IsValidHeaderValue() at the point where the untrusted
> data was introduced. A tighter check such as IsToken() may be appopriate.
>
> BUG=627398
>
> Committed: https://crrev.com/c5c1a790acc423f359c22641ac2ab0f3f9e6d7a9
> Cr-Commit-Position: refs/heads/master@{#405702}

R=mmenke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=627398

Review-Url: https://codereview.chromium.org/2268423004
Cr-Commit-Position: refs/heads/master@{#414633}

TBR=waffles
BUG=615187

Review-Url: https://codereview.chromium.org/2286483002
Cr-Commit-Position: refs/heads/master@{#414632}

Most of the fields in CastSysInfoDummy will have format
dummy.field_name. This will allow run widevine cdm testing code in
desktop build.

BUG=internal b/27699230
TEST=Run widevine testing code

Review-Url: https://codereview.chromium.org/2066743004
Cr-Commit-Position: refs/heads/master@{#414631}

BUG=640133
TEST=manually

Review-Url: https://codereview.chromium.org/2285533002
Cr-Commit-Position: refs/heads/master@{#414630}

The function eglCreateImageKHR() seems to fail on this GPU
for L8 textures which results in YUV->RGB conversion failures.
EGLImage is used for Spitzer in WebView.

BUG=632461
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2281663002
Cr-Commit-Position: refs/heads/master@{#414629}

This moved from policy/proto to components/policy/proto in https://codereview.chromium.org/2273783002 and this updates the Python server code to unbreak the test.

TBR=jianli@chromium.org

Review-Url: https://codereview.chromium.org/2286473003
Cr-Commit-Position: refs/heads/master@{#414628}

BUG=613883

Review-Url: https://codereview.chromium.org/2269863002
Cr-Commit-Position: refs/heads/master@{#414627}

Reason: It's unnecessary and uncommon for test case classes to subclass
the class that they're testing. Dre added this when he added this file,
and I didn't notice this in code review at the time.

This is a refactoring CL, no behavior changes.

Review-Url: https://codereview.chromium.org/2276413002
Cr-Commit-Position: refs/heads/master@{#414626}

CoC has now better contact avenues if submitter is uncomfortable with
a "blind" community@ account - two direct e-mails added.

It also now offers a way to send anonymous reports.

R=ben@chromium.org
BUG=none

Review-Url: https://codereview.chromium.org/2273433002
Cr-Commit-Position: refs/heads/master@{#414625}

This is a first-aid patch that make expandEnd/RangeToSentenceBoundary()
compare the sentence boundaries found with the input range before
returning, so that the returned range is always a super-range of
the input range, and hence, a valid EphemeralRange.

This patch does not fix the root cause of the bugs, as we do not expect startOfSentence()'s return value to be beyond that of endOfSentence()'s.
It simply stops the crashing at expandEnd/RangeToSentenceBoundary.

BUG=640905
TEST=n/a; this is a first-aid patch

Review-Url: https://codereview.chromium.org/2274183003
Cr-Commit-Position: refs/heads/master@{#414624}

Direct access to LayoutPart is deprecated and being removed soon. The
replacement is LayoutPartItem, which routes methods through the new
block layout API. (See linked crbug for details.) This means the
ownerLayoutObject() method is also deprecated, to be replaced with
ownerLayoutItem().

There are no functional changes.

BUG=499321
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2266403007
Cr-Commit-Position: refs/heads/master@{#414623}

There are a few callsites with DispatchSelectEvent flag. This CL updates them
so that they dispatch 'select' event themselves, and remove
NeedToDispatchSelectEvent argument.

Review-Url: https://codereview.chromium.org/2268893008
Cr-Commit-Position: refs/heads/master@{#414622}

This CL switches several differently styled sub-headers to all use h2
tags. This is good because it makes them all consistent and h2 is a good
choice because screen readers may scan for h2 tags specifically to give
the user context about what is on the screen.

BUG=638461
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2273083002
Cr-Commit-Position: refs/heads/master@{#414621}

This CL changes the layout of the search input within a sub-page to more
closely match the updated mocks.

BUG=638453
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2279093002
Cr-Commit-Position: refs/heads/master@{#414620}

660a5e69d661 win: switch crashpad_handler.exe to /subsystem:windows and
             add .com
b35ee1fca189 Adding support for on-demand uploads

Review-Url: https://codereview.chromium.org/2277943002
Cr-Commit-Position: refs/heads/master@{#414619}

This is part 1 of staging crrev.com/2266073002.

Part 1: Add empty config("default_stack_frames").
Part 2: Disable this config in third_party/ffmpeg.
Part 3: Move Chromium -fomit/-fno-omit-frame-pointer logic into this config.

TBR=brettw@chromium.org
TBR=dpranke@chromium.org
BUG=636489

Review-Url: https://codereview.chromium.org/2280533004
Cr-Commit-Position: refs/heads/master@{#414618}

On server migration, the session pooling map (ip_aliases_) was not correctly updated by the QuicStreamFactory , leaving a zombie entry in the map, which subsequently led to a use-after-free. This CL corrects this behavior in the QuicStreamFactory.

BUG=639916

Review-Url: https://codereview.chromium.org/2277953002
Cr-Commit-Position: refs/heads/master@{#414617}

On tablet, the back key already works, due to the browser caching a
navigation history. This CL implements the same thing on phones, by
caching a backstack history in download activity.

BUG=616324

Review-Url: https://codereview.chromium.org/2271583006
Cr-Commit-Position: refs/heads/master@{#414616}

BUG=None

Review-Url: https://codereview.chromium.org/2269173002
Cr-Commit-Position: refs/heads/master@{#414615}

This is a continuation of the work to make files in content/browser/loader like resource_dispatcher_host_imp.cc/.h
not depend on code outside of the loader folder. The callers of the BeginSaveFile and BeginDownload
methods which are SaveFileManager and DownloadManagerImpl now implement the preamble code in the
old BeginSaveFile and BeginDownload methods. These callers directly call the new
ResourceDispatcherHostImpl::BeginURLRequest method (Previously ResourceDispatcherHostImpl::BeginRequestInternal).

Additionally ResourceDispatcherHostImpl now has a new function InitializeURLRequest which needs to be called before
BeginURLRequest. This function sets the referrer and associates the request with the ResourceRequestInfoImpl structure.

I have left the ResourceDispatcherHostImpl::CreateResourceHandlerForDownload function as is for now. This function
is invoked from content/browser/loader/mime_type_handler.cc file which requires an instance of the
DownloadResourceHandler object to continue. The knowledge of download specific handlers has moved out
to a callback function DownloadResourceHandler::Create which is registered with ResourceDispatcherHostImpl in the constructor.
I agree that this is a touch ugly. There are tests which expect to override the ResourceDispatcherHostImpl::CreateResourceHandlerForDownload function.
Did not want to break those tests in this patchset.
Added TODO's in the code

However the RDH interface is still a work in progress. There are other annoyances in
ResourceDispatcherHostImpl today like the CreateRequestInfo function which is invoked in the BeginSaveFile and
BeginDownload code path. I have left this as is for now. Will look into a better way in a subsequent patch.

BUG=598073
TBR=jam

Review-Url: https://codereview.chromium.org/2251643003
Cr-Commit-Position: refs/heads/master@{#414614}

Status is needed for session removal in remote cdm.

BUG=
TEST=No check failure when remove session on chromecast.

Review-Url: https://codereview.chromium.org/2280743002
Cr-Commit-Position: refs/heads/master@{#414613}

BUG=640924, 614277
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2277213002
Cr-Commit-Position: refs/heads/master@{#414612}

https://pdfium.googlesource.com/pdfium.git/+log/a1d2111945ac..9b57ec9ff50a

$ git log a1d211194..9b57ec9ff --date=short --no-merges --format='%ad %ae %s'
2016-08-25 jaepark Clean up CPDFSDK_PageView methods.
2016-08-25 npm Change " to ' in gyp file for consistency

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2284513002
Cr-Commit-Position: refs/heads/master@{#414611}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/5359adae29ae..eedef30a4151

$ git log 5359adae2..eedef30a4 --date=short --no-merges --format='%ad %ae %s'
2016-08-25 eakuefner [TBMv2] Make ValueSet a class
2016-08-25 ccraik Validate files needed by Android tools
2016-08-25 eakuefner [StyleGuide] Allow classes
2016-08-25 fmeawad v8CallStats: a script to transform the traces into call stat dumps

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2277193003
Cr-Commit-Position: refs/heads/master@{#414610}

BUG=chromium:631640
TEST=manual

Review-Url: https://codereview.chromium.org/2277803005
Cr-Commit-Position: refs/heads/master@{#414609}

BUG=603217
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2277993002
Cr-Commit-Position: refs/heads/master@{#414608}

When converting an ICC profile to a ColorSpace, the primaries are extracted.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/24f935a3d8cdfcdfbabd23928a42304b1ffc52ba
Review-Url: https://codereview.chromium.org/2229953003
Cr-Original-Commit-Position: refs/heads/master@{#413914}
Cr-Commit-Position: refs/heads/master@{#414607}

If the field trial is enabled, read a "tag" value from the variation parameters
and pass it on to the component updater. After the experimental component is
installed, read command-line arguments and a "suffix" string from its manifest;
pass the command-line arguments to the SwReporter when it's launched, and
append the suffix to all histograms it logs to distinguish them from reports
from the default reporter.

BUG=631480

Review-Url: https://codereview.chromium.org/2278013002
Cr-Commit-Position: refs/heads/master@{#414606}

Using RTLD_DEEPBIND by default is problematic (see comments
in native_library_posix.cc), but in the case of Mojo services
where the host binary is lightweight but otherwise may export some
conflicting symbols (e.g. tcmalloc), it is desirable.

This CL adds a NativeLibraryOptions structure and a new
LoadNativeLibraryWithOptions() call. The only supported
option (|prefer_own_symbols|) only affects behavior on
non-OSX, non-Android, POSIX systems.

The default behavior of LoadNativeLibrary is unchanged.

Also adds a unit test for general native library loading since
there wasn't one before.

BUG=594674

Review-Url: https://codereview.chromium.org/2277863002
Cr-Commit-Position: refs/heads/master@{#414605}

There seems to be some bug in the implmentation in cc::Surfaces.
It looks like it might be swapping an invalid frame when doing
the readback.

This reverts https://codereview.chromium.org/2189493002
and uses the readback layer from
https://codereview.chromium.org/2243663002 instead for issuing
the readback.

For the time being that's totally fine. The main advantage was
that it avoided the need for a browser commit which helps with
trying to do a final readback while the surface goes away (i.e
onPause).

TBR=danakj@chromium.org

BUG=640561

Review-Url: https://codereview.chromium.org/2279113002
Cr-Commit-Position: refs/heads/master@{#414604}

Introduce mojom.GpuServiceInternal interface, which GpuServiceProxy
in window server uses to communicate to GpuServiceInternal in the gpu
process.

BUG=613366

Review-Url: https://codereview.chromium.org/2276963002
Cr-Commit-Position: refs/heads/master@{#414603}

This is another test CL for `webkit-patch rebaseline-cl`.

Review-Url: https://codereview.chromium.org/2271823002
Cr-Commit-Position: refs/heads/master@{#414602}

R=rch@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2277633006
Cr-Commit-Position: refs/heads/master@{#414601}

The ExtensionMsg_Loaded_Params had a number of issues:
- it never pickled the id
- it never pickled the tab specific permissions
- it didn't use the explicit id when constructing the extension

The latter is useful to safe work in the normal case, and important in
tests since test extensions may not have keys or paths.

BUG=640837

Review-Url: https://codereview.chromium.org/2279013002
Cr-Commit-Position: refs/heads/master@{#414600}

I uploaded a screenshot on the issue page.

BUG=629689

Review-Url: https://codereview.chromium.org/2257743003
Cr-Commit-Position: refs/heads/master@{#414599}

BUG=595761

Review-Url: https://codereview.chromium.org/2278793003
Cr-Commit-Position: refs/heads/master@{#414598}

We add two histograms:
1. Navigation.ClearSiteData.Parameters - the mask of parameters
2. Navigation.ClearSiteData.Duration - the duration of the clearing task

BUG=607897

Review-Url: https://codereview.chromium.org/2274853002
Cr-Commit-Position: refs/heads/master@{#414597}