GitLab

BUG=391943
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/379233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282113 0039d316-1c4b-4281-b951-d872f2087c98

GetNexeFd() in ppb_nacl_private_impl will change soon to be an internal method,
not one exposed through the PPB_NaCl_Private interface. From inside Chromium,
base::Callback is much easier to use than PP_CompletionCallback or
TrackedCallback.

This is one of a series of changes to refactor the pexe downloading logic in
the trusted plugin.

BUG=370556

Review URL: https://codereview.chromium.org/380773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282112 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Disable another WebView fullscreen video test until we land fullscreen IPC changes (https://codereview.chromium.org/371933003/)

Reason for revert:
revert this as all related CLs are committed

Original issue's description:
> Disable another WebView fullscreen video test until we land fullscreen IPC changes
> 
> there are 2 changes needs to be submitted before we reenable the tests:
> 1. https://codereview.chromium.org/290643005/ and
> 2. https://codereview.chromium.org/292573004/
> 
> the blink change will break all the tests, so we need to reenable the test after the chromium change lands
> 
> BUG=367346
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281627

TBR=boliu@chromium.org
BUG=367346

Review URL: https://codereview.chromium.org/382583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282111 0039d316-1c4b-4281-b951-d872f2087c98

Currently, AcceleratorController delivers accelerators to GlobalCommandsListenerChromeOS (which is an AcceleratorTarget). We respect the same conditions found within AcceleratorController to disallow shortcuts in specific instances (e.g. login screen locked screen, empty windows). AcceleratorController is owned by the ash::Shell and knows about existing keyboard shortcuts/actions.

BUG=336761
TEST=interactive_ui_tests --gtest_filter=GlobalCommandsApiTest.*

And, manually, on a desktop build of Chrome with GYP_DEFINES=chromeos=1...

with a component extension:

Verified that
- a global shortcut (ctrl+shift+0) works with focus in
1. web content
2. shelf
3. toolbars (omni box, View(s)).

Verified that processing does not occur in the following cases (similarly to most other ash accelerators) as expected:
- OOBE
- locked screen
- desktop with no windows open
- sign in screen (after logging out).

Review URL: https://codereview.chromium.org/350943003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282110 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391861
R=asargent@chromium.org
TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/377833009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282109 0039d316-1c4b-4281-b951-d872f2087c98

Ports over more gyp logic for the icu target. Doesn't correctly account
for host toolchains yet, but it's closer.

All hail GN. oRZ

BUG=none

Review URL: https://codereview.chromium.org/377113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282108 0039d316-1c4b-4281-b951-d872f2087c98

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/381643003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282107 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/380783003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282106 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/379843005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282105 0039d316-1c4b-4281-b951-d872f2087c98

Blink won't find carriage returns from Windows clipboards.
Strip those characters before calling WebContents::Find.

The newline character is displayed wrong in textfields.
Swap it out for the Unicode newline symbol: ␤ (0x2424).
(the glyph isn't available on Win Views for me now...)

See before/after pics at http://crbug.com/371450#c7

BUG=371450
TEST=Find-in-page works well for string containing line breaks.
R=pkasting@chromium.org
TBR=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/374253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282102 0039d316-1c4b-4281-b951-d872f2087c98

BUG=360311
NOTRY=true

Review URL: https://codereview.chromium.org/379923008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282100 0039d316-1c4b-4281-b951-d872f2087c98

Changed registration API to work for one network at once.
Fixed comments.
Replaced argument GCDDevice with just string id.

BUG=383167
R=alexsemenov@chromium.org, asargent@chromium.org, asvitkine@chromium.org, noamsml@chromium.org

Review URL: https://codereview.chromium.org/363883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282099 0039d316-1c4b-4281-b951-d872f2087c98

implement it for mDNS (WiFi devices forthcoming)

BUG=383167

Review URL: https://codereview.chromium.org/356613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282098 0039d316-1c4b-4281-b951-d872f2087c98

Note: this is a reland of https://codereview.chromium.org/373153002/
after plugging a memory leak.

BookmarkStorage isn't ref counted anymore since
https://codereview.chromium.org/370323002, and the LoadCallback() task
now gets a WeakPtr to the owning BookmarkStorage. However, it gets a
raw pointer to the BookmarkLoadDetails object, which is still owned
by BookmarkStorage and may have been destroyed when the background
task runs.

This happened on iOS tests after a recent merge.

TBR=sky@chromium.org
BUG=165760

Review URL: https://codereview.chromium.org/376203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282097 0039d316-1c4b-4281-b951-d872f2087c98

Fix incorrect usage of ProfileInfoCache in GAIAInfoUpdateService: SetGAIANameOfProfileAtIndex may change the profile index.
Also add some warning comments in profile_info_cache.h.

BUG=372381

Review URL: https://codereview.chromium.org/373083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282095 0039d316-1c4b-4281-b951-d872f2087c98

TBR=tonyg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/378363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282094 0039d316-1c4b-4281-b951-d872f2087c98

in Google Update settings.

Consequentially, the backed up client_id now keeps its dashes and crash_keys
strips them at runtime rather than when backing it up
(https://codereview.chromium.org/372473004/ will add support for stripped
client_id backups for some time).

Also rename a lot of methods involved in setting the client id; having all of
them named "SetClientID" makes this series of calls very hard to follow!

BUG=391338
TBR=thestig

Review URL: https://codereview.chromium.org/365133005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282093 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/376243003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282091 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://codereview.chromium.org/353093004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282090 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromedriver:843
TBR=stgao@chromium.org

Review URL: https://codereview.chromium.org/379803007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282089 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943

Review URL: https://codereview.chromium.org/376183005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282088 0039d316-1c4b-4281-b951-d872f2087c98

Apparently some desktop drivers do not generate an INVALID_OPERATION, so we
should enforce it in GPU command buffer.

BUG=391953
TEST=conformance_renderbuffers_framebuffer_object_attachment passing on all GPU bots
R=kbr@chromium.org,bajones@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/379623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282085 0039d316-1c4b-4281-b951-d872f2087c98

BUG=386652
R=sadrul@chromium.org, oshima@chromium.org
TBR=kevers@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/356263003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282081 0039d316-1c4b-4281-b951-d872f2087c98

WebViewGuest is growing fairly large (~ 1600 lines). This CL aims to move all permission related code to a new helper class WebViewPermissionHelper:

- Rename PluginPermissionHelper to WebViewPermissionHelper;
- Move permission request code:
--- Include permissions: Download, PointerLock, Media, Geolocation, FileSystem, Plugin;
--- Not include: New Window API, Dialog API.

Review URL: https://codereview.chromium.org/347113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282080 0039d316-1c4b-4281-b951-d872f2087c98

A BUILD.gn file was checked into the real location so this secondary-tree file is unused.

R=tfarina@chromium.org

Review URL: https://codereview.chromium.org/378633005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282078 0039d316-1c4b-4281-b951-d872f2087c98

This variable changed name to avoid ambiguity with dependencies.

R=noelallen@chromium.org

Review URL: https://codereview.chromium.org/374213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282077 0039d316-1c4b-4281-b951-d872f2087c98

This variable changed name.

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/375873006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282076 0039d316-1c4b-4281-b951-d872f2087c98

The default was "iPhone", but that's not supported in Xcode 6, so use
"iPhone 5" in that case.

Also remove an unnecessary call to |connect| when printing supported
devices on Xcode 6. This call is not needed and just hangs for a few
seconds so remove it (all that's really needed is to load the
CoreSimulation framework.

BUG=390581
TEST=With Xcode 6 installed, build iossim then run iossim with no
optional paramters (e.g. out/Debug-iphonesimulator/iossim path/to/my.app
TBR=rohitrao@chromium.org

Review URL: https://codereview.chromium.org/379863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282075 0039d316-1c4b-4281-b951-d872f2087c98

This CL brings SetGAIAGivenNameOfProfileAtIndex in line with SetGAIANameOfProfileAtIndex.

BUG=372381

Review URL: https://codereview.chromium.org/373093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282074 0039d316-1c4b-4281-b951-d872f2087c98

Changes committed in r281468 were overly restrictive about when the
zoom bubble can be shown. This CL restores the old behaviour, noting
that the usual cases where the zoom bubble is supressed, namely
for changes initiated from the wrench menu and for changes in the
dev tools window, are done elsewhere in the browser.

BUG=391680

Review URL: https://codereview.chromium.org/372813003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282073 0039d316-1c4b-4281-b951-d872f2087c98

Without this, the class can hardly be used within a component (unless we work around it).

Adds a workaround for link failure of components_tests due to infobar component bug (crbug.com/386171).

BUG=387751,382865,386171
TBR=jam
TEST=Variations*

Review URL: https://codereview.chromium.org/366373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282072 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
NOTRY=True
R=kalman@chromium.org

Review URL: https://codereview.chromium.org/377273003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282071 0039d316-1c4b-4281-b951-d872f2087c98

On Android there is no software fallback for the video decoder.  Disable the
fallback path and remove the dependencies.

BUG= https://code.google.com/p/nativeclient/issues/detail?id=3032
R=bbudge@chromium.org

Review URL: https://codereview.chromium.org/364003003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282070 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282069 0039d316-1c4b-4281-b951-d872f2087c98

https://skia.googlesource.com/skia/+log/6815011292f0a130db2b35ca0f862b246769f3b8..874a62acef5ec2ecccdbb99ec4d86402a3341e6a

CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_layout_rel
TBR=jcgregorio@google.com
BUG=

Review URL: https://codereview.chromium.org/374403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282068 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282067 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r13453: (noelallen) Create GN files for trusted source libraries.
r13454: (dyen) Added support for uploading log urls when uploading toolchain packages.
r13455: (dyen) Updated some documentation for the package_version files.
r13456: (dschuff) Give the minidump_generator_lib gyp rule a shorter name

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_rel_precise32,linux_arm_cross_compile,linux_nacl_sdk_build
R=binji@chromium.org

Review URL: https://codereview.chromium.org/377083003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282066 0039d316-1c4b-4281-b951-d872f2087c98

    
    Change HistoryService::ScheduleAutocomplete interface to take
    a base::Callback<void(HistoryBackend*, HistoryDatabase*)> and propagate
    to HistoryBackend::ScheduleAutocomplete and to the client.
    With this change HistoryService and HistoryBackend no longer need to be
    aware of the HistoryURLProvider and HistoryURLProviderParams.
    
    BUG=374728
    TEST=unit_tets --gtest_filter=History*

Review URL: https://codereview.chromium.org/376703007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282064 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds support for storage of the camera connection
information in the devices' names enumeration and subsequently
in the VideoCaptureDevice::Name structure.

-[AVCaptureDevice transportType] indicates the connection type 
to the camera: USB, Built-in, PCI, etc. Note that this info is only 
available for AVFoundation API and not for QTKit. 

Chromium style check forces to move complex constructors
and destructors from video_capture_device.h to .cc.

TEST: Verify that the FaceTime Built-in HD (USB) used in 
MBA >=2013 does not show incorrect modelID and vendorID
in the camera name -- those fields should be empty since
they only exist for USB or built-in cameras..

BUG=336651

Review URL: https://codereview.chromium.org/366593003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282063 0039d316-1c4b-4281-b951-d872f2087c98

BUG=392484
NOTRY=True
NOTREECHECKS=True
TBR=zty@chromium.org

Review URL: https://codereview.chromium.org/376253003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282061 0039d316-1c4b-4281-b951-d872f2087c98