- 03 Apr, 2020 40 commits
-
-
Dave Tapuska authored
Like crrev.com/511a3ee8 the 2d text tests were failing cause they weren't waiting for the font to be ready. Use the same code I wrote in the other tests for the rest of them. BUG=1066953 Change-Id: If32fb0704a1ed1b0d96d8be1e07c94138fa2f982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135544Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#756281}
-
Mohsen Izadi authored
Currently, EventLatency metrics only measure total latency from event timestamp up to frame presentation (and for scroll events, from event timestamp up to gpu-swap-end). This CL adds top-level compositor breakdowns. Further breakdowns for blink and viz stages will be added in follow-up CLs. Bug: 1054009 Change-Id: I65341dbc10d08b8acbd05185cf270b0a1fc4d842 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132853Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#756280}
-
Chris Harrelson authored
This field doesn't do anything in cc in layer list mode, and is not called in other clients of cc than Blink. Layer::should_check_backface_visibility() does all the actual work in layer list mode. Bug: 1008483 Change-Id: Ia535f6912d6c6a9b3305851639360ae9693fd375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131024Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#756279}
-
Ewann authored
This CL moves ClearBrowsingDataUIDelegate to the privacy coordinator and adds back his delegate to the ClearBrowsingDataTableViewController. Bug: 1066846 Change-Id: Id712379d41275b3d7c522687ccb4072b3fd4041e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134011 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#756278}
-
Philip Rogers authored
This test had a minor typo which was discovered when upstreaming the CSS version of the test in https://chromium-review.googlesource.com/c/chromium/src/+/2134034. Change-Id: I3f8e0218b2c78dc82bdbe3693ffb51111edefc6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135545 Commit-Queue: Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#756277}
-
chrome://flagsPeng Huang authored
Bug: None Change-Id: Ib16fde51ee8d23ca6003df99fd998cf24a02a7f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134620Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#756276}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8ce842d38d0b..c89ca0ba09ed git log 8ce842d38d0b..c89ca0ba09ed --date=short --first-parent --format='%ad %ae %s' 2020-04-02 kjlubick@google.com [canvaskit] Tweak matrix benchmarks 2020-04-02 kjlubick@google.com [canvaskit] Handle passing matrix values into CK ourselves. 2020-04-02 mtklein@google.com eliminate_dead_code in place 2020-04-02 lovisolo@google.com ios.py: Bugfix to prevent iOS tasks from failing with "Error: ImageMountFailed". 2020-04-02 mtklein@google.com don't need Builders 2020-04-02 csmartdalton@google.com Disable baseVertexBaseInstanceSupport if instancing is not supported 2020-04-02 fmalita@chromium.org [skottie] Cleanup pass 2020-04-02 borenet@google.com Update Go Deps 2020-04-02 mtklein@google.com pass around programs by value 2020-04-02 mtklein@google.com pull out schedule, finalize 2020-04-02 bsalomon@google.com Reland x2 "Assert that all GrCaps colortype/format -> swizzle queries are legal." 2020-04-02 brianosman@google.com Add GrVkPipelineStateBuilder and GrMtlPipelineStateBuilder trace events 2020-04-02 bsalomon@google.com Rename outputView->writeView and outputSwizzle->writeSwizzle 2020-04-02 bsalomon@google.com Remove color type from promise image proxy callback. 2020-04-02 westont@google.com Broke Debian9 things in skolo. 2020-04-02 mtklein@google.com reframe liveness_analysis as eliminate_dead_code 2020-04-02 westont@google.com [infra] Upgrade to Debian 10 for GCE tasks. 2020-04-02 brianosman@google.com Remove more remnants of SkVertices bone support 2020-04-02 brianosman@google.com Stop including SkVertices.h from so many places 2020-04-02 kjlubick@google.com [canvaskit] Add tests for RTShader 2020-04-02 hcm@google.com Update Skia milestone to 84 Created with: gclient setdep -r src/third_party/skia@c89ca0ba09ed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: michaelludwig@google.com Change-Id: I8df7b00859aea2405b764c26e5bd4efd849cdcfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135790Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756275}
-
Kurt Catti-Schmidt authored
This change introduces two new classes that will be used for CSS Grid in LayoutNG, as well as the runtime flag "LayoutNGGrid" that enables CSS Grid support in LayoutNG. This is not at all functional yet but will allow for the subsequent changes to focus on the implementation instead of boilerplate. Bug: 1045599 Change-Id: I04fb4455761b1f66cf567440fc5298a39230cbbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042056Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#756274}
-
Katie D authored
This increases code coverage by 100% for select_to_speak_tray.h. Bug: 1067399 Change-Id: I59c8caa322aae3189d04da0afe8520cdfb2ab457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134862Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#756273}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/93040c8d0d4a..e4aa679c5945 git log 93040c8d0d4a..e4aa679c5945 --date=short --first-parent --format='%ad %ae %s' 2020-04-03 jmadill@chromium.org Texture: Pass explicit unpack buffer to setImage. 2020-04-03 jmadill@chromium.org Vulkan: Fix FBO cache when updating disabled attachments. Created with: gclient setdep -r src/third_party/angle@e4aa679c5945 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: I4aa46391152946c8f0996393c0c6397ef56884d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135788Reviewed-by:
-
Dominic Farolino authored
This CL adds a few "missing" relevant mutations WPTs; specifically, it exercises going from a valid state, to the state specified by the invalid value default, by setting an img's `crossorigin` attribute to a bogus value. R=fs@opera.com, hiroshige@chromium.org Bug: 1061685 Change-Id: I07166be176925693267c287fde53f4f09b3aeff8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135542Reviewed-by:
-
Mugdha Lakhani authored
When there's no security status icon to show, currently WebLayer keeps the blank space for it. A more elegant UI is to start the URL bar text at the leftmost edge in this case, without leaving any gap for the icon, and animate to the right once the icon is ready to be shown. This CL reuses code from Clank for the security button animation. GIFs before and after the change can be seen here: https://drive.google.com/drive/folders/1qyRRQzysAkFdKgwiKBk_aEqrvCB48M8i?usp=sharing Bug: 1025607 Change-Id: I831ae02f1fdf096170a8296b3d8b8916c505aa70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132333 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Auto-Submit: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#756270}
-
arthursonzogni authored
(1) 2020-03-12: pmeuleman@ added support for parsing COOP for SW main resource response, just before M82 branch cut. https://chromium-review.googlesource.com/c/chromium/src/+/2100790 The parser is executed from the browser process, violating: https://chromium.googlesource.com/chromium/src/+/master/docs/security/rule-of-2.md The unittest is entirely executed from the browser process. (2) 2020-03-16: arthursonzogni@ added 8 equivalent WPT subtests: https://chromium-review.googlesource.com/c/chromium/src/+/2102577 Today, yhirano@ is working on avoiding parsing COEP from the browser process: https://chromium-review.googlesource.com/c/chromium/src/+/2132902 and arthursonzogni@ is doing the same for both COOP and COEP: https://chromium-review.googlesource.com/c/chromium/src/+/2134292/10 https://chromium-review.googlesource.com/c/chromium/src/+/2134374/7 Since the unittest (1) is run entirely in the browser process, there are no ways to move the parsing to the renderer process without breaking this test. It needs to be removed. The WPT tests (2) are enough. This patch removes ServiceWorkerNavigationLoaderTest.ResponseWithCoop. This unblocks removing COOP parser usages from the browser process. Bug: 1059295 Change-Id: I838eb387387d9b735d25cef6ecda999f1fab1f32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135688Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#756269}
-
Anders Hartvoll Ruud authored
CascadeMap now holds the cascaded declarations for the user-agent, user, and author origins separately. The 'revert' keyword is resolved to the cascaded value for the target origin before being applied to ComputedStyle. (This can happen recursively up to the kUserAgent origin. Note that 'revert' will not yet work to/from surrogates (css-logical properties), nor in @keyframes. Bug: 579788 Change-Id: I98b40d596867129e486035f9cd9f20e7b7cbe08e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130268 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#756268}
-
Hailey Wang authored
Add usage of MaxSimultaneousLoad threshold in BackgroundTabLoadingPolicy's loading logic. Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/2122479 Reland due to test failing because of dependencies on system core number. Removed these dependencies in unit tests. Bug: 1059341 Change-Id: I20fd569aa13c2912ba8f6366bf5d3916f72e8f58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134190Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Hailey Wang <haileywang@google.com> Cr-Commit-Position: refs/heads/master@{#756267}
-
Manuel Rego Casasnovas authored
This patch removes LayoutTheme::IsFocusRingOutset() as it's only implemented in one place and returns always "false". Due to this we can also remove the method ShouldDrawInnerFocusRingForContrast() in graphics_context.cc, as it always return "false" too. No new tests as it's covered by existent tests, just removing dead code. Change-Id: Ib4715770603d2ac66b353c7d077b75385e24aa3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134248Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/52e2dbf1c115..16d0d371d549 git log 52e2dbf1c115..16d0d371d549 --date=short --first-parent --format='%ad %ae %s' 2020-04-03 mbonadei@webrtc.org Apply performance-for-range-copy fixes. 2020-04-03 tommi@webrtc.org Remove seemingly unused timer 2020-04-03 titovartem@google.com Extract PeerConfigurerImpl into separate file Created with: gclient setdep -r src/third_party/webrtc@16d0d371d549 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I3a13a527edbb8983551e078e52c4d4782f058cc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135787Reviewed-by:
-
Jesse Schettler authored
Use cros_healthd to collect and report fan info for each of the device's fans. Bug: 1035579 Test: DeviceStatusCollector.TestCrosHealthdInfo Change-Id: I1f458f923e6017d601390bca9b4070b0590d53e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135314Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#756264}
-
Wez authored
This reverts commit 81e217be. Reason for revert: Broke the official builders' archive step. Original change's description: > [fuchsia] Migrate cr_package_fuchsia() to use SDK-provided rules. > > Migrate the cr_package_fuchsia() rule to use the SDK-provided > fuchsia_component() and fuchsia_package() rules internally. > > TBR=jbudorick > > Bug: 1050703 > Change-Id: I1ba54308f2f2f6fc0f0b305dab2b9c927a38b21e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094989 > Commit-Queue: Wez <wez@chromium.org> > Auto-Submit: Wez <wez@chromium.org> > Reviewed-by: Kevin Marshall <kmarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#756250} TBR=ddorwin@chromium.org,wez@chromium.org,kmarshall@chromium.org,sergeyu@chromium.org,jbudorick@chromium.org,wilkinsonclay@google.com Change-Id: I9077ce9e4cab5dd85e3d5fc4f4d09cc91033e811 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1050703, 1067614 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135691Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#756263}
-
Marc Treib authored
- Extract a new SetVotesForPendingCredentials() out of CreatePendingCredentials(). - Remove "update" param from SavePendingToStore() since it can be inferred from pending_credentials_state_. - Merge ProcessUpdate() together with corresponding code for the IsNewLogin() case into a new SetVotesAndRecordMetricsForPendingCredentials(). - Call UploadVotesAndMetrics() from within SavePendingToStore(), rather than at its call sites. No behavior changes. Bug: 1067194 Change-Id: Ib85a35de9a44b6ec362442351416b27368243cd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134007 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#756262}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/f99302c4efe6..2ce5fda2fea8 git log f99302c4efe6..2ce5fda2fea8 --date=short --first-parent --format='%ad %ae %s' 2020-04-03 bclayton@google.com Kokoro: Add the ppa:ubuntu-toolchain-r/test apt-repository Created with: gclient setdep -r src/third_party/swiftshader@2ce5fda2fea8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ia17d0e2ee711a0679e6f0d377231a864ed65f0f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135602Reviewed-by:
-
Elly Fong-Jones authored
Bug: None Change-Id: Ic7166feb015cf069d58173ea97c1976f008ecfaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132768 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#756260}
-
Raymond Toy authored
As with other fixes, use HasSampleAccurateValuesTimeline() to determine if there are sample-accurate values which is either caused by timeline events or connected inputs to the AudioParam. Added IsAudioRate() if any AudioParam is k-rate and use that to determine how to handle the AudioParam. This applies to the 6 AudioParams of a PannerNode, and the 9 AudioParams for an AudioListener since they're closely coupled. Performance impact is negligible, based on Spotify's benchmark. Without this CL (macbook pro): TEST μs MIN Q1 MEDIAN Q3 MAX Baseline 495 495 530 550 556 1765 Panner-equalpower 359 359 377 395 399 1186 Panner-HRTF 948 948 1023 1119 1135 7163 With this CL: TEST μs MIN Q1 MEDIAN Q3 MAX Baseline 496 496 545 558 578 8654 Panner-equalpower 359 359 377 395 399 611 Panner-HRTF 941 941 1021 1119 1134 8270 Bug: 1015760 Change-Id: Iea0ef37ae07c7113c8ab9cc3e1cb47e6179a151e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096786 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#756259}
-
Scott Violet authored
This reverts commit 935efb98. Reason for revert: As 81 hasn't shipped yet, and the client library is being used from trunk, this is a bit aggresive. We need to wait until 83 goes to stable before doing this. Original change's description: > [WebLayer] Remove support for M79 > > Fixes this TODO before M83 branches. > > Bug: 1031830 > Change-Id: I280cc8378cb1124fdcc12965ff067382d669ef09 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132827 > Auto-Submit: Clark DuVall <cduvall@chromium.org> > Commit-Queue: Scott Violet <sky@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#755513} TBR=sky@chromium.org,cduvall@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1031830 Change-Id: Ie53395a683e34b95750577cec2ccfab8141131f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135539Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#756258}
-
Danyao Wang authored
The bridge implements PaymentAppFactoryInterface on the Java side and acts as a PaymentAppFactory::Delegate on the C++ side to allow Java to invoke C++ PaymentAppService. This patch sets up the basic scaffolding. A subsequent CL will fill in the actual onPaymentAppCreated() callback, which is the most substantial part of the bridge. Bug: 1063118 Change-Id: Ie3b93b719712b9b95865ee769415c4cd91d35392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133120Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#756257}
-
Tom McKee authored
In seemingly rare cases, LatencyInfo instances associated with CompositorFrames have ukm:SourceIds that we do not expect. More specifically, we're sometimes seeing unexpected kInvalidSourceIds and we're also sometimes seeing source id disagreement amongst multiple LatencyInfos associated to a single CompositorFrame. See the linked bug for more details, but we're currently seeing these issues intermittently while scrolling and navigating simultaneously. This CL adds a histogram to record when we're seeing these unexpected cases so that we can get a better sense of how often this happens in the wild. Bug: 1062764 Change-Id: I5f69c430df4e29a07eedda77fed0e64f529f1bc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129861Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Tom McKee <tommckee@chromium.org> Cr-Commit-Position: refs/heads/master@{#756256}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Iebc6543337143e0c74fe04cd142672eed2554635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135605Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-p10-rolls@google.com Change-Id: I1efa42cacfc40ddfa3642a9c2ef5deda7b26e70f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135372Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756254}
-
Omer Katz authored
This is to address flaky timeouts of these tests. Bug: 986235 Change-Id: I82658d97947ea1314290f9ffbd40b6529b80e04e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134253Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#756253}
-
kylechar authored
Two checks about the DrawQuad rects were added as deserialization errors. Add equivalent DCHECKs during serialization so the errors are caught closer to the source in debug builds. Bug: 1066139 Change-Id: I69665dd200d7ee2028fac6e55bd0264967ed9216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134609Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#756252}
-
Daniel Rubery authored
When recording metrics for malware deep scanning, every verdict that is not VERDICT_UNSPECIFIED is a success. But SCAN_FAILURE should count as failure. Change-Id: I961f19d4a719be53ab04d6f39caf083f919a392a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134914 Auto-Submit: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#756251}
-
Wez authored
Migrate the cr_package_fuchsia() rule to use the SDK-provided fuchsia_component() and fuchsia_package() rules internally. TBR=jbudorick Bug: 1050703 Change-Id: I1ba54308f2f2f6fc0f0b305dab2b9c927a38b21e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094989 Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#756250}
-
Christos Froussios authored
TBR=rsorokin Bug: 1067461 Change-Id: Ieae7074a542b9addfafc8be773ee4d8343b785a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135613 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#756249}
-
Anastasiia Nikolaienko authored
This change is limited to Chrome OS and is not related to Win7 Tests failure. This is a reland of 0a948617 TBR=xiyuan@chromium.org Original change's description: > Add EDU login flow: CSS fixes > > Address comments to UI implementation - update margins and logo size. > New screenshots: > http://slides/1Trd6FeBKqts4iAfYpE8lzzgpeaB_hE8vL8tTY5YA2PI > > Bug: 1054798 > Change-Id: Ic7bf2d72f5cb6cf07b27b95159b06d838283255b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132398 > Reviewed-by: Kush Sinha <sinhak@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> > Cr-Commit-Position: refs/heads/master@{#756012} Bug: 1054798, 1067443 Change-Id: I2dc2c9345808be2f3e84a3c4c91c3a1db6076a0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134015 Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#756248}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 123ddc4d. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 2688e49a "De-flake two lazyload WPT tests." 8fa00285 "[webauthn] Fix resident key credentials.get() WPT" edb8adb1 "Implement and ship RTCRtpSendParameters.degradationPreference" 2fb88bb8 "Use integer coordinates for Actions.pointerMove." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Icc1850715a23dcb51b9a1da88c5df1ae3fd3e6b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135706Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756247}
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: I65e2e168c67edd2ffd2363479164f1a4e027c4b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135646Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#756246}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/47cd4085b978..52e2dbf1c115 git log 47cd4085b978..52e2dbf1c115 --date=short --first-parent --format='%ad %ae %s' 2020-04-03 mbonadei@webrtc.org Add voip_unittests to gn_isolate_map.pyl 2020-04-03 jonaso@webrtc.org Don't trigger OnNetworkChange when changing from 3G to 4G 2020-04-03 jonaso@webrtc.org Add new AdapterTypes to android sdk 2020-04-03 deadbeef@webrtc.org Temporarily increase DTLS buffer size to 2. Created with: gclient setdep -r src/third_party/webrtc@52e2dbf1c115 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1063834 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I6b31577b50d696823ed779dd6613cf98dc78c43c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135601Reviewed-by:
-
Anthony Vallee-Dubois authored
This is a prerequisite to allow DeviceAccountInitializer to be used on desktop to fetch authcodes for invalidations registration. Bug: 1026261 Change-Id: I9db6fbe4c420b34b5cc734207d728cc67045a1a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134188Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#756244}
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: Iaef4f9e9baf735635e2b763bb246749fd0cc55e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134005Reviewed-by:
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: Ica922d40136c54683d995e134cdc3df0ea6d8dd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135667Reviewed-by:
-
