- 18 Jun, 2018 40 commits
-
-
Xiaohan Wang authored
- Add hardware secure codecs and encryption_scheme support - Use a vector for supported session types in case we need to support more session types in the future - Use the mojom type directly on the client side to avoid duplicate code Bug: 848532 Test: No functionality change. Change-Id: Ieb61bdd223bc340593eb633b5f85e1abc3cec6f8 Reviewed-on: https://chromium-review.googlesource.com/1102836Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#568237}
-
crystallambert@chromium.org authored
Sample extension that uses a content script to find images on pages, then displays images in popup. If user clicks image it will download. Extension has options page where users can choose to save downloaded images, download them again, or display them as thumbnails in popup. This extension may be used in updated debugging tutorial. Bug: None Change-Id: I38a2bd5af135ad74b889e8366ae36a08d6d53cb0 Reviewed-on: https://chromium-review.googlesource.com/1053958Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Crystal Lambert <crystallambert@chromium.org> Cr-Commit-Position: refs/heads/master@{#568236}
-
danakj authored
And SetShouldFlattenTransformFromPropertyTree() becomes SetShouldFlattenScreenSpaceTransformFromPropertyTree() as per the TODO to rename it more appropritely. R=enne@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I783e8474f39899de99ca6cf51e102f5ea604b836 Reviewed-on: https://chromium-review.googlesource.com/1101915Reviewed-by:
weiliangc <weiliangc@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#568235}
-
Dominick Ng authored
This CL makes several improvements to the accessibility of the intent picker bubble: 1. Reducing the opacity applied to the ink drop highlight for focused items (increasing text contrast slightly) 2. Adding a role override to the bubble to avoid the screen reader saying "Unknown" for the picker purpose 3. Making each label button focusable so they can be tabbed through. BUG=760200,825700 Change-Id: Ib2477b786350b07325a615f77ba4b168b1bb5cc7 Reviewed-on: https://chromium-review.googlesource.com/1102228 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#568234}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1bc7e6d68e88..4ce4cb826374 git log 1bc7e6d68e88..4ce4cb826374 --date=short --no-merges --format='%ad %ae %s' 2018-06-15 lalitm@google.com trace_processor: fix build when offsetof was being used on non-POD 2018-06-13 treehugger-gerrit@google.com Merge "Add emscripten_task_runner.h/.cc" 2018-06-13 hjd@google.com Merge "WASM: 512mb should be enough for everyone" 2018-06-13 hjd@google.com Add emscripten_task_runner.h/.cc 2018-06-13 hjd@google.com WASM: 512mb should be enough for everyone 2018-06-13 lalitm@google.com trace_processor: add database class to contain all the tables 2018-06-12 treehugger-gerrit@google.com Merge "ui: Fix protojs generation" 2018-06-12 hjd@google.com ui: Fix protojs generation 2018-06-12 taylori@google.com trace_processor: Add the process table methods to trace_storage 2018-06-12 lalitm@google.com trace_processor: fix unittests on Android 2018-06-11 lalitm@google.com trace_processor: add sqlite virtual table implementation of sched slices 2018-06-07 treehugger-gerrit@google.com Merge "trace_processor: fix comments pending from aosp/697250" 2018-06-07 primiano@google.com Merge "perfetto: add vscode directory to gitignore" 2018-06-07 lalitm@google.com trace_processor: fix comments pending from aosp/697250 2018-06-07 lalitm@google.com perfetto: add vscode directory to gitignore 2018-06-07 treehugger-gerrit@google.com Merge "perfetto: add device feature test for checking CPU count" 2018-06-06 lalitm@google.com perfetto: add device feature test for checking CPU count Created with: gclient setdep -r src/third_party/perfetto@4ce4cb826374 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:80416541,chromium:80416541,chromium:80416541,chromium:80416541,chromium:79961252 TBR=perfetto-bugs@chromium.org Change-Id: Iada3fe4edbdb88b671b0faca034b85ca6bce304a Reviewed-on: https://chromium-review.googlesource.com/1104719 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568233}
-
lgcheng authored
USB detach event not delivered to Arc container After usb_service called OnDeviceRemoved(), query usb_service for this device will not(gurantee) return any result. Use the scoped_refptr passed by OnDeviceRemoved directly and deliver the detach event to ARC container. Bug: 853353 Test: Manual Change-Id: I74214b455a678548c3a80eebf214fdfa5beced99 Reviewed-on: https://chromium-review.googlesource.com/1103284 Commit-Queue: Long Cheng <lgcheng@google.com> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#568232}
-
Esmael El-Moslimany authored
Bug: 624849 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I83171f753c73b50e7d674e3f588cd5eb6e3f01d7 Reviewed-on: https://chromium-review.googlesource.com/1089643 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#568231}
-
Carlos Knippschild authored
Bug: 687364 Change-Id: I4727334dcf0060b5a8202a9694e7bd60d31029ec Reviewed-on: https://chromium-review.googlesource.com/1105031Reviewed-by:
Dmitry Titov <dimich@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#568230}
-
Ryan Sturm authored
Per UX decision, this change makes the InfoBar better for users. Instead of using an InfoBar Button for pausing/resuming subresource loading, we will use an InfoBar clickable link. Bug: 853885 Change-Id: Ia967baec922d0c363f48d26e057e121fa6ae969f Reviewed-on: https://chromium-review.googlesource.com/1104722Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#568229}
-
John Budorick authored
TBR=dpranke@chromium.org No-Try: true Bug: 828031 Change-Id: Ica36364071464f05fe96b52cf699672617b3bbfa Reviewed-on: https://chromium-review.googlesource.com/1105414 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#568228}
-
Emily Hanley authored
Bug: 713357 Change-Id: Ia2d35c069e5bc07b8c2d0c7fb4b81f7000b43371 Reviewed-on: https://chromium-review.googlesource.com/1104893Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#568227}
-
Anna Offenwanger authored
This is a reland of 5d3c459e TBR=dcheng@chromium.org,vollick@chromium.org,klausw@chromium.org,mthiesse@chromium.org,ijamardo@chromium.org Original change's description: > Merging WebVR 1.1 RequestPresent into WebXR RequestSession > > In the WebVR 1.1 spec, the blink code was informed about devices then sent requests > for pipelines to those devices via the mojo interfaces. In the WebXR spec, the > decision about which device to use is left up to the browser, and not decided > until the pipline request has been made. This CL moves the blink<->device interface > pointers from being call parameters to being return parameters to better align > with WebXR. > As WebVR is being deprecated, as much of the old VR code as is possible > has been cleaned out. > > Bug: 842042 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_vr > Change-Id: I67da418829c05479eb3b2a6c5ef1633d8da92564 > Reviewed-on: https://chromium-review.googlesource.com/1080967 > Commit-Queue: Bill Orr <billorr@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Ian Vollick <vollick@chromium.org> > Reviewed-by: Klaus Weidner <klausw@chromium.org> > Reviewed-by: Bill Orr <billorr@chromium.org> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567430} Bug: 842042 Change-Id: I6278326460a6c74df6c1c6f414fc826079d8ca27 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_vr Reviewed-on: https://chromium-review.googlesource.com/1102800 Commit-Queue: Anna Offenwanger <offenwanger@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#568226}
-
Sky Malice authored
To facilitate notifying feed of foregrounds, added FeedEventReporter to act as the entry point. This class has a dummy clone because it is called outside of Feed code. Bug: 831648 Change-Id: Id25205e33b03d20cd63c6b97920d2cb90ac3d4c2 Reviewed-on: https://chromium-review.googlesource.com/1095774Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#568225}
-
Gang Wu authored
1. Add Delete all function for both content and jornal. 2. Update DeleteContentByPrefix to use leveldb_proto::UpdateEntriesWithRemoveFilter. 3. Fix FakeDB<T>::UpdateEntriesWithRemoveFilter the way to handle erase during iteration. Bug:831633 Change-Id: I7ae4df74244b3c3ac5c0bf36ea2e2bdc7839d375 Reviewed-on: https://chromium-review.googlesource.com/1103939Reviewed-by:
-
Khushal authored
R=enne@chromium.org Bug: 84706 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Idf3ce80d9c9a63ac651b03c6dacb0002b659445a Reviewed-on: https://chromium-review.googlesource.com/1101957Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#568223}
-
Aaron Leventhal authored
Bug: 846570 Change-Id: I60e851b4e09658424de11b2f978dfd9dfcd1b67d Reviewed-on: https://chromium-review.googlesource.com/1099880 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#568222}
-
Tom Anderson authored
This is a reland of e6db40d9 Reason for reland: All bots should now have libuuid1 installed (bug 853048). Original change's description: > Update fontconfig to 6cc99d6a > > Changelog [1]. This is necessary to pick up [2] for fixing undefined-shift > UBSAN errors detected by clusterfuzz, [3] to allow removing a build workaround, > [4] to fix a bug and clean up some log spam, [5] to fix CFI builds, and [6] to > fix a use-after-free. > > Fontconfig also now requires libuuid as a dependency, so whitelist it as a > dependency since we statically link fontconfig. > > [1] https://chromium.googlesource.com/external/fontconfig/+log/b546940435ebfb0df575bc7a2350d1e913919c34..6cc99d6a82ad67d2f5eac887b28bca13c0dfddde > [2] https://chromium.googlesource.com/external/fontconfig/+/c60ed9ef66e59584f8b54323018e9e6c69925c7e > [3] https://chromium.googlesource.com/external/fontconfig/+/b8a225b3c3495942480377b7b3404710c70be914 > [4] https://chromium.googlesource.com/external/fontconfig/+/7ad010e80bdf8e41303e322882ece908f5e04c74 > [5] https://chromium.googlesource.com/external/fontconfig/+/096e8019be595c2224aaabf98da630ee917ee51c > [6] https://chromium.googlesource.com/external/fontconfig/+/6cc99d6a82ad67d2f5eac887b28bca13c0dfddde > > BUG=831146,822737,787020,829890,847323 > TBR=thestig,dnicoara > > Change-Id: Ic2d1bd19af8ca131c960a30d09246827c115ccec > Reviewed-on: https://chromium-review.googlesource.com/1095538 > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Daniel Nicoara <dnicoara@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567445} TBR=thestig,dnicoara Bug: 831146, 822737, 787020, 829890, 847323, 853048 Change-Id: Id42738aaf5841bd219dc0e9209680c87e88f4869 Reviewed-on: https://chromium-review.googlesource.com/1104759Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#568221}
-
Kyle Horimoto authored
This operation attempts to connect to a remote device over BLE via the listener role via BleConnectionManager. Bug: 824568, 752273 Change-Id: Ie6be7b139b8234049df4d1f1c2535254a1b962a0 Reviewed-on: https://chromium-review.googlesource.com/1103009 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#568220}
-
Steven Holte authored
This reverts commit 08410d56. Reason for revert: This appears to be causing build failures due to a DEPS issue: https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8943347677136985328%2F%2B%2Fsteps%2Fgenerate_build_files%2F0%2Fstdout BUG=853968 Original change's description: > Fuchsia: Implement MixerOutputStreamFuchsia using AudioRenderer2. > > Previously MixerOutputStreamFuchsia was using media_client library, > which is deprecated now. Update it to use AudioRenderer2 FIDL interface > directly. > > Bug: 851733 > Change-Id: I72a43369d16ecd626aa7294a6f3500b57bb3731e > Reviewed-on: https://chromium-review.googlesource.com/1100376 > Reviewed-by: Kenneth MacKay <kmackay@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568159} TBR=wez@chromium.org,sergeyu@chromium.org,kmackay@chromium.org Change-Id: I9b5b2262d8ddc2edb706fb6fbec3d1fdc6d19563 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 851733 Reviewed-on: https://chromium-review.googlesource.com/1105320Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#568219}
-
Christopher Cameron authored
The surface sync APIs are used in views mode (becaused we use a single ui::Compositor). Delete some of the now-dead code from RWHVMac (it has deep roots which still need to go). Change-Id: I6f065288c27d3ebecf113494751bfc8dfd199fd7 Reviewed-on: https://chromium-review.googlesource.com/1105024Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#568218}
-
Wez authored
Update the TestDelegate: - Add RunUntilRedirect() and RunUntilAuthRequired() APIs. - Create a clean separation between "legacy" and new API closures. - Call the on_<event> closures in-line, rather than via PostTask. - Use OnceClosures for new APIs instead of RepeatingClosure. - Remove set_quit_on_redirect() and set_quit_on_auth_required(). Related changes to tests, including: - Add necessary RunUntilIdle() calls after e.g. RunUntil*(), in various tests that were relying on QuitWhenIdle behaviour. - Update FakeExternalProtocolHandlerDelegate, ExternalProtocolHandlerTest, EmbeddedTestServerTest, CancelRequestDelegate and SSLClientAuthTestDelegate to use QuitClosure. Bug: 850145 Change-Id: I9320e5b7dc3e4aac883fa49dcdcd6384bc7d3ce9 Reviewed-on: https://chromium-review.googlesource.com/1094209Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#568217}
-
Theresa authored
Add the default selectable item background to the bookmarks/downloads shortcuts on the "simplified NTP". BUG=852392 Change-Id: Iebf2dce9d36d458d566a15ee2e9eeb8b1362bdee Reviewed-on: https://chromium-review.googlesource.com/1105192Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#568216}
-
Sadrul Habib Chowdhury authored
BUG=778749 Change-Id: I0f3cfea90ffefa739c82a673a4e2e8abd5dfba00 Reviewed-on: https://chromium-review.googlesource.com/1104582Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#568215}
-
Steven Holte authored
TBR=bauerb NOTRY=true Bug: 847341 Change-Id: If94212431798176fc4b692088930c9c35d36074d Reviewed-on: https://chromium-review.googlesource.com/1105406 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
-
Pavel Feldman authored
Change-Id: I6e391fadbbf47aa6427a16495bdca3c88d456b05 Reviewed-on: https://chromium-review.googlesource.com/1105041Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#568213}
-
John Budorick authored
Follow up to crrev.com/c/1104308 Bug: 828031 Change-Id: I6ebb02a2c1d0aae83c8db9d7c3e13e2c154d965a Reviewed-on: https://chromium-review.googlesource.com/1105121Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#568212}
-
Xiaocheng Hu authored
[LayoutNG] Stop NGInlineFragmentTraversal::SelfFragmentsOf() from collecting descendants of already collected inline fragments The above function is used to compute rects of a LayoutInline, and is especially useful when the LayoutInline doesn't generates its own boxes. However, currently the function may collect a fragment even if there's an inline ancestor fragment collected. For example: <span id="culled"> <span id="preserved" style="border: 1px solid black"> text </span> </span> When calling SelfFragmentsOf() on SPAN#culled, it collects both the box fragment of SPAN#preserved and the text fragment. This results in wrong calculation of rects of culled inline elements, and also some failures in client-rect-related tests. This also conflicts with the legacy behavior, where if a LayoutInline has already has an InlineBox, the legacy rect generation functions no longer collect the descendant InlineBoxes. This patch fixes the issue by storing a stack of currently entered inline box fragments, and collect a fragment only if none of its ancestor inline fragments is entered (which means all of them, if any, are culled). While being a standalone fix, this patch also helps preserving more inline fragments to make hit testing inline elements easier. Bug: 851075 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I8567f1258221c78806be1bb1628b8a63c7ea3281 Reviewed-on: https://chromium-review.googlesource.com/1091921 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#568211}
-
Chong Zhang authored
The following tests are failing on Mojo Linux Perf: * loading.desktop.network_service/AirBnB_cold * loading.desktop.network_service/AirBnB_warm * loading.desktop.network_service/Kenh14_cold * loading.desktop.network_service/Kenh14_warm * loading.desktop.network_service/Taobao_cold * loading.desktop.network_service/Taobao_warm See bug for deailed reports. This patch also cleaned up platform filters (only have Linux bot). (TBR since it's Mojo Linux Perf bot only) TBR=kouhei@chromium.org Bug: 853835 Change-Id: Idaf3487bd8933b93cd8f4e93c81645dcc8712ade Reviewed-on: https://chromium-review.googlesource.com/1105023Reviewed-by:
Chong Zhang <chongz@chromium.org> Commit-Queue: Chong Zhang <chongz@chromium.org> Cr-Commit-Position: refs/heads/master@{#568210}
-
Max Moroz authored
This reverts commit 5cf1517a. Reason for revert: this change won't work as explained in https://bugs.chromium.org/p/chromium/issues/detail?id=808775#c9 and on clusterfuzz-dev@chromium.org Original change's description: > Increase memory size for media_vpx_video_decoder_fuzzer > > The maximum frame size in VP8 is 16,384 x 16,384, which uses most of the > default 2048 Mb allowed. Bumping up the size to 4096 Mb to handle the larger > frame size. > > BUG=808775 > TEST=fuzzer test case passes > > Change-Id: I8e1e56bbd0936e745792f34106c7e638ff5a1c2b > Reviewed-on: https://chromium-review.googlesource.com/1100004 > Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> > Commit-Queue: John Rummell <jrummell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567355} TBR=jrummell@chromium.org,chcunningham@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 808775 Change-Id: I47d8005442d6b81dcd023a1071e344c2e09304e5 Reviewed-on: https://chromium-review.googlesource.com/1104826Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
-
mark a. foltz authored
https://chromium.googlesource.com/media_router.git/+log/50d927e72030..9f9f41bdd831 $ git log 50d927e72..9f9f41bdd --date=short --no-merges --format='%ad %ae %s' 2018-06-14 mfoltz First step to deprecate and remove test: URLs from mr.TestProvider. 2018-06-05 mfoltz [Media Router] Associate issues with sink IDs 2018-03-20 mfoltz [DIAL MRP] Use the correct URL for DELETE. Created with: roll-dep src/chrome/browser/resources/media_router/extension/src Change-Id: Icfc0e013d228a0e3456e0e98c0c69c85af8ee7b8 TBR=imcheng Change-Id: Icfc0e013d228a0e3456e0e98c0c69c85af8ee7b8 Reviewed-on: https://chromium-review.googlesource.com/1103440Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#568208}
-
Xiaocheng Hu authored
Old implementation of NGInlineFragmentTraversal traverses all descendants of an NGPhysicalFragment, and uses a filter to decide which fragments to emit. As a result, the implementation is convoluted. This patch rewrites it by using a visitor that can decide the traversal process, and also when/what to emit. As a result, the implementation is greatly simplified. Bug: 851075 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I67a1331f906981e48cc366697234f8d5996c02ea Reviewed-on: https://chromium-review.googlesource.com/1097877 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
-
spqchan authored
Add a test that checks if the BrowserTouchBar's BookmarkTapHelperObserver gets removed when it's destroyed. Follow up to: https://chromium-review.googlesource.com/c/chromium/src/+/1099483 Bug: 852222 Change-Id: I60c08a195a8b8adb1848d120c3492783fa615ba9 Reviewed-on: https://chromium-review.googlesource.com/1101484 Commit-Queue: Sarah Chan <spqchan@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#568206}
-
Steven Bennetts authored
This CL removes the unused network_dropdown.js and related C++ support classes including network_menu.cc. It also includes some related cleanup. Bug: 689198, 728806 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ieb1e97ce4c4308874f8c977f4d6290a0d91bf15d Reviewed-on: https://chromium-review.googlesource.com/1083173 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#568205}
-
Ryan Sturm authored
This behavior will now match UKMPageLoadMetricsObserver, which is key to keeping the metrics in sync. Change-Id: Ic92efc53e8c68d8f298ebdb8c9059c4e0604afb0 Reviewed-on: https://chromium-review.googlesource.com/1101700 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#568204}
-
Ryan Landay authored
In the Android horizontal tab switcher, we determine which tab thumbnails to render based on the index of the currently-centered tab, as determined by NonOverlappingStack#computeReferenceIndex() (this is a virtual method called by Stack since the logic for updating visibility is shared between the overlapping and non-overlapping tab switchers). We currently have a bug where the tab thumbnails are becoming blank during quick scrolling. This is because the current implementation of this method uses mScrollTarget instead of mScrollOffset to determine the centered tab (basically, mScrollTarget is where we're going and mScrollOffset is where we are, and is actually used for rendering). This CL fixes this bug by updating this method's implementation to use the value returned from getCenteredTabIndex(), which uses mScrollOffset instead of mScrollTarget. Bug: 853879,831359 Change-Id: I129c03ca80297c15b670d223bfc6630b6d8de68c Reviewed-on: https://chromium-review.googlesource.com/1105021Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/heads/master@{#568203}
-
Paul Miller authored
BUG=628650 Change-Id: Ia78bfe6ad2d12362cb85bcc4580d907fe1ed6b47 Reviewed-on: https://chromium-review.googlesource.com/1105181Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Paul Miller <paulmiller@chromium.org> Cr-Commit-Position: refs/heads/master@{#568202}
-
Bill Orr authored
This is a reland of edb91802 Original change's description: > Add an interface to communicate between the fake openvr and tests > > This change creates a way for tests to control the behavior of > the fake OpenVR, and allows devices to send information up to > tests. > > BUG=801034 > > Change-Id: Ie0fe035ada9553114c054717f52788d375d5c62f > Reviewed-on: https://chromium-review.googlesource.com/1100157 > Commit-Queue: Bill Orr <billorr@chromium.org> > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567725} Bug: 801034 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ic4c1b4891df8ba1de9d7bf07863d4b696ec81de0 Reviewed-on: https://chromium-review.googlesource.com/1104761 Commit-Queue: Bill Orr <billorr@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#568201}
-
Jiaquan He authored
This commit reenables ClickingContextMenuDoesNotDismiss but moves it into Ash. Bug: 733662 Change-Id: If176458fd07d949c8d21082b40ed06f4f571b3d5 Reviewed-on: https://chromium-review.googlesource.com/1100675 Commit-Queue: Jiaquan He <hejq@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#568200}
-
Xiaocheng Hu authored
The layout test's baseline somehow got one "PASS" line missing, making it incorrectly marked as failure. This patch corrects it. Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ia0281dd694b72103b97858bfc3104766c5f4ef4c Reviewed-on: https://chromium-review.googlesource.com/1104720 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
-
Mark Pilgrim authored
Bug: 714018 Change-Id: I9ecc53ebb303b1c08ca4f21f9b948fdbfa02598c Reviewed-on: https://chromium-review.googlesource.com/1104387Reviewed-by:
-
