- 17 Apr, 2020 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6144906469fe..9a846fe623f6 Created with: gclient setdep -r src-internal@9a846fe623f6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ricea@google.com,nektar@google.com,guidou@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: ricea@google.com,nektar@google.com,guidou@google.com Change-Id: I17ca99a5ee7248119e9fd641b5a5ee32d8f9a016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154092Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759944}
-
Meredith Lane authored
This reverts commit c462e4b7. Reason for revert: Causes a heap-use-after-free on win-asan. First failure: https://ci.chromium.org/p/chromium/builders/ci/win-asan/11631 Original change's description: > weblayer: allow calling Navigate() from onNavigationStarted > > At the time OnNavigationStarted() is called it's not safe to call > Navigate(). This patch delays the navigate until it is safe (when > NavigationThrottleImpl::WillStartRequest() is called). > > BUG=1070569 > TEST=NavigationBrowserTest.NavigateFromRendererInitiatedNavigation > > Change-Id: Ia110bb94e64d6551c9db302ae41b735ad5a8a5e5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153758 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#759872} TBR=sky@chromium.org,jam@chromium.org Change-Id: I67a8b8d121ea1223650ee35a013068da20de6fb9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1070569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154348Reviewed-by:
Meredith Lane <meredithl@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#759943}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I49c5a216200fb3cbf4a8a8f477289337f5ac1444 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154099Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759942}
-
Johann authored
Use HeapMojoReceiver wrapper so that Oilpan will GC the object. Change-Id: Ie86954d7a9e5e705cf33eda703d2427bb060f777 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100457Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#759941}
-
Antonio Gomes authored
BUG=767015, 1063749 R=rego@igalia.com Change-Id: Idc6d1855985252853f96ad45bf470abe2dc5cc3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153605Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#759940}
-
Ramin Halavati authored
Independent OffTheRecord profile manager is getting deprecated. PresentationReciverWindowController class is updated to use the newer profile APIs instead of that. Bug: 1033903 Change-Id: If2f664e01227a39be78c79c71eb2f5b02ea6b678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151448Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#759939}
-
Antonio Gomes authored
BUG=767015, 1063749 R=rego@igalia.com Change-Id: Ie5a6454850f580d7ada804d83760689366522258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152607 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
Antonio Gomes authored
BUG=767015, 1063749 R=rego@igalia.com Change-Id: Id629b9295751069d705c0d4a9677c8e402958f20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151552 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c4fb400988c9..acac5d6f9d72 git log c4fb400988c9..acac5d6f9d72 --date=short --first-parent --format='%ad %ae %s' 2020-04-17 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@acac5d6f9d72 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id4cd0ec294fe546621a18f72ec3e245da974c863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154096Reviewed-by:
-
Jon Mann authored
Previously we were listening for updates directly from the NetworkConfigurationHandler, but sync relies on some metadata which can be updated after that callback is executed. This change ensures that the metadata has been updated first. Bug: 966270 Change-Id: I8367da2e11279609e40caa0fbc160457aaf5be3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151892 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#759935}
-
Peter Kotwicz authored
Removes unused: WebappActivity#loadUrlIfPostShareTarget() WebappActivity#createTabDelegateFactory() BUG=None Change-Id: Ifa7294b87fc2815eebdba7adbd25cc1fe56b00bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148538Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#759934}
-
Tao Bai authored
- Combined 7 components junit tests into one. - Fix a variations test which didn't work with other tests. Bug: 1069479 Change-Id: Ife508b4c481805f66a2a655f29224c4c5295e12d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152987Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#759933}
-
Lei Zhang authored
Currently, every PDFiumFormFiller instance has its own ID counter. Multiple PDFiumFormFiller instances may exist in the same process. Meanwhile, PDFium expects every timer to have a unique ID inside a given process. This leads to a clash where timers do not work right due to duplicate timer IDs inside PDFium. To fix this, make all PDFiumFormFiller instances share an ID counter. Bug: 1071689 Change-Id: Ide58aef8258a357196308f2d9d1ab7c967238c14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153942Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#759932}
-
dpapad authored
Bug: 1069258 Change-Id: I25e66ab27d894c466875a6412b8876bd7727d89f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152997 Auto-Submit: dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#759931}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a3564739..bd63f0e0 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I17a37f7ebcbfe0e29040cde9845fb876d863d81a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153973Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759930}
-
Meredith Lane authored
Disables P2PQuicTransportMockConnectionTests.OnDatagramReceived. Follow up to https://crrev.com/c/2153066 TBR=ianswett@chromium.org BUG=1071340 Change-Id: I27338618d6a20346a1fe7bb33c0e5a6d93a8fd36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153455Reviewed-by:
-
Yutaka Hirano authored
The HTTP header is malformed due to the trailing semicolon. Remove it. Bug: None Change-Id: Ifb6042fa169bdf373be418fab89c67ad94e105fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151777Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#759928}
-
Chris Whelan authored
Cast app annotations are given the prefix "app." in order for them to be properly grouped in bugreports. Bug: 67907746 Test: cast_crash_storage_impl_fuchsia_unittest Change-Id: I13a526a2e6552b4d3bfee919be29752a518575f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151308 Commit-Queue: Christopher Whelan <chwhelan@google.com> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#759927}
-
Matt Menke authored
We want to get rid of the single argument AddHeader() method as the two argument AddHeader() and SetHeader() methods are safer and more flexible. In this case, switching to SetHeader() to make clear that we only expect one instance of each of the headers being set. Bug: 1068194 Change-Id: Ieeeb96ea9b55e8ddb606ee64949d7b3271226aca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149686Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#759926}
-
Hirokazu Honda authored
Zeo-Copy Video Capture is controlled by ChromeOS overlays [1, 2]. This adds the chrome UI flag so as to switch the feature via UI. The default behavior respects the overlay settings. The feature is forced to enable and disable once the flag is switched in chrome://flags. [1] https://chromium-review.googlesource.com/c/chromiumos/overlays/board-overlays/+/1835900 [2] https://chromium-review.googlesource.com/c/chromiumos/overlays/board-overlays/+/1835900 Bug: 982201 Test: Disable/Enable the feature in chrome://flags Change-Id: Ic329b3c01122a1ba3eac1de9363c3c2b3c0e139d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143093Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#759925}
-
Jon Mann authored
Allows observers of the NetworkMetadataStore to watch for updates. Bug: 966270 Change-Id: Ibc4df7bd28a0222e30445453c1298d26e0c0c5a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151173Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Commit-Queue: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#759924}
-
Scott Haseley authored
This removes the metrics added in crrev.com/c/1535484. Sufficient data was collected for purposes of looking at starvation in the wild, so the metrics are being marked as obsolete and removed. Bug: 1053271, 1037721 Change-Id: I6b5a3eeabfabdac1a926edc06c717e3748c74fa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147915Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Scott Haseley <shaseley@chromium.org> Cr-Commit-Position: refs/heads/master@{#759923}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/16abfa5e42d1..9ad01787a88f git log 16abfa5e42d1..9ad01787a88f --date=short --first-parent --format='%ad %ae %s' 2020-04-17 reed@google.com remove legacy deserialization of overdrawcolorfilter Created with: gclient setdep -r src/third_party/skia@9ad01787a88f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: I8fd4217df1a06dcdb76c9b1432550d5665b9afbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154088Reviewed-by:
-
Lukasz Anforowicz authored
Bug: 1069567 Change-Id: Ie83b99f25e5d8d13f466c91f8d5118bfd039e856 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144418Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#759921}
-
Ted Choc authored
If a Runnable throws an AssertionError, it will be re-attempted. This should allow for using assertions directly inside of the runnable with causes attached w/o the need for using Criteria/error conditions. BUG=1071247 Change-Id: I6a0f2a5625f3de5b18c49d59b4d1b8b87f5acf0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151483 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#759920}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I8a538c535fb1f9615c361dc7048b41bd00d5f548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153944Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759919}
-
Allen Bauer authored
Part of Views Documentation effort. Change-Id: If1f3b114d22ff7ee673939c4b5be1a37d7aae1c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152889Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#759918}
-
Sadrul Habib Chowdhury authored
If a frame is not produced, and the reason is anything other than 'no damage', (e.g. if draw is aborted because of checkerboarding etc.), then mark that frame as a 'dropped frame'. BUG=790761 Change-Id: I9783563fe2d8e87fa0fabad91895fc238b8050b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147694 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#759917}
-
Meredith Lane authored
This reverts commit 2fe1a951. Reason for revert: Broke the build for Windows deterministic. First failure: https://ci.chromium.org/p/chromium/builders/ci/Windows%20deterministic/16277 Original change's description: > Updater: Allow branding in uninstall.cmd and enable --uninstall test. > > Bug: 1070206, 1062285 > Change-Id: Ia5c5222efcf2b90e41f1db9f5cac216a15befb4f > Fixed: 1070206 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147752 > Commit-Queue: Joshua Pawlicki <waffles@chromium.org> > Reviewed-by: Sorin Jianu <sorin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#758812} TBR=sorin@chromium.org,waffles@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1070206, 1062285 Change-Id: I080bf5b0dc601f08b977971abdea2d74607cabc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153183Reviewed-by:
-
Jesse McKenna authored
The Power.BatteryPercentDrop histogram is now recorded on Windows (per https://crbug.com/794105), so the description can be updated to reflect that. Change-Id: I87acedf254a78acf2c777a76d183d930e155a718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153752Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#759915}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5491b2a8263c..d8d981721371 git log 5491b2a8263c..d8d981721371 --date=short --first-parent --format='%ad %ae %s' 2020-04-17 fancl@chromium.org Fix bug for cleanup multiple services 2020-04-17 fancl@chromium.org Dashboard: Bypassing group_id from front-end Created with: gclient setdep -r src/third_party/catapult@d8d981721371 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1064955 Tbr: skyostil@google.com Change-Id: Iae018153f1a4851adc125215f2cbf03b287b8a25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154086Reviewed-by:
-
John Z Wu authored
It is no longer necessary to split the interface like this anymore because we no longer use build flags to control public headers. Change-Id: I1214850f799f8f73dec96103a264c8f2440ab6ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154026 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#759913}
-
David Tseng authored
R=dmazzoni@chromium.org Bug: 1046430 Change-Id: I134e5b7bfa2f38ea7143baad2f0f43f2ecc0dc18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149400 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#759912}
-
Kent Tamura authored
This CL has no behavior changes because changes are behind a runtime flag. After this CL, fast/ruby/ tests won't crash with LayoutNGRuby flag. Bug: 1069817 Change-Id: Ie9c1f3ce05e9e09838f8bf7c7c07e0288bdfa466 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152132Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#759911}
-
phillis authored
Add UMA metrics to track different type of errors that occur during updating badge process R=chromium-metrics-reviews@google.com, cmumford@chromium.org Bug: 1051682 Change-Id: I42d0105ec652feb9130b37566d62d358f6d38e76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121427 Commit-Queue: Phillis Tang <phillis@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#759910}
-
Xianzhu Wang authored
This is just a safety measure for some theoretical corner cases that the bug may occur when the LayoutView and the document element are not in the same composited layer. However, I haven't succeeded to create such a test case yet. TBR to catch up with the next canary build, so that this CL can be merged together with crrev.com/759821. TBR=pdr@chromium.org Bug: 1070952 Change-Id: I1f8448da81aea18fc08515ec3f7b0b7d03bca197 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153904Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#759909}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/800a89ae20a4..6144906469fe Created with: gclient setdep -r src-internal@6144906469fe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ricea@google.com,nektar@google.com,guidou@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1053795,chromium:1054179 Tbr: ricea@google.com,nektar@google.com,guidou@google.com Change-Id: I6d1ec815372d159b957987b936e7944445c729e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153993Reviewed-by:
-
Bettina authored
Bug: 1071510 Change-Id: I3eb8f81c96815469a0f50473eb12a1702e873097 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153313 Auto-Submit: Bettina Dea <bdea@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#759907}
-
Gyuyoung Kim authored
This CL migrates flex-sizing-rows-min-max-height.html from fast/css-grid-layout to external/wpt/css/css-grid/layout-algorithm with WPT styles, adding links to the relevant specs, and test description. This test is renamed to flex-sizing-rows-min-max-height-001.html to be align with existing tests. Bug: 1063749 Change-Id: Ie02efebdbbe50c3a7a6307dac3a2097a25d9ad86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152567 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
-
Karandeep Bhatia authored
IndexedRuleset.median_match_time_avg/MatchAll perftest shows a regression after r759462 due to computation of rule count in the UrlPatternIndexMatcher constructor. This CL changes UrlPatternIndexMatcher rule count to be lazily computed which should ensure that the cost of computation is only paid by clients which use the rule count. When the perf test is run locally on my machine: Without this CL: *RESULT IndexedRuleset.median_match_time: MatchAll= 231364 us With this CL: *RESULT IndexedRuleset.median_match_time: MatchAll= 80248 us Note that the test regression is exaggerated since the test creates a UrlPatternIndexMatcher for each request. BUG=1071599 Change-Id: I6364e4b9043494d18389a41c517b90756ba4c8f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153693 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#759905}
-
